Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Add some () to attempt to workaround build issue on osx

2018-05-25 Thread Michael Niedermayer 
On Thu, May 24, 2018 at 01:39:00PM -0300, James Almer wrote:
> On 5/23/2018 9:38 PM, Michael Niedermayer wrote:
> > On Tue, May 22, 2018 at 06:13:47PM -0300, James Almer wrote:
> >> On 5/22/2018 3:57 PM, Michael Niedermayer wrote:
> >>> May fix ticket7209
> >>>
> >>> Signed-off-by: Michael Niedermayer 
> >>> ---
> >>>  libavformat/mxfenc.c | 12 ++--
> >>>  1 file changed, 6 insertions(+), 6 deletions(-)
> >>>
> >>> diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
> >>> index 44425bf6c9..77f60f5874 100644
> >>> --- a/libavformat/mxfenc.c
> >>> +++ b/libavformat/mxfenc.c
> >>> @@ -1149,23 +1149,23 @@ static int get_trc(UID ul, enum 
> >>> AVColorTransferCharacteristic trc)
> >>>  switch (trc){
> >>>  case AVCOL_TRC_GAMMA28   :
> >>>  case AVCOL_TRC_GAMMA22   :
> >>> -memcpy(ul, 
> >>> (UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x01,0x00,0x00},
> >>>  16);
> >>> +memcpy(ul, 
> >>> ((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x01,0x00,0x00}),
> >>>  16);
> >>>  return 0;
> >>>  case AVCOL_TRC_BT709 :
> >>>  case AVCOL_TRC_SMPTE170M :
> >>> -memcpy(ul, 
> >>> (UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x02,0x00,0x00},
> >>>  16);
> >>> +memcpy(ul, 
> >>> ((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x02,0x00,0x00}),
> >>>  16);
> >>>  return 0;
> >>>  case AVCOL_TRC_SMPTE240M :
> >>> -memcpy(ul, 
> >>> (UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x03,0x00,0x00},
> >>>  16);
> >>> +memcpy(ul, 
> >>> ((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x03,0x00,0x00}),
> >>>  16);
> >>>  return 0;
> >>>  case AVCOL_TRC_BT1361_ECG:
> >>> -memcpy(ul, 
> >>> (UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x06,0x04,0x01,0x01,0x01,0x01,0x05,0x00,0x00},
> >>>  16);
> >>> +memcpy(ul, 
> >>> ((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x06,0x04,0x01,0x01,0x01,0x01,0x05,0x00,0x00}),
> >>>  16);
> >>>  return 0;
> >>>  case AVCOL_TRC_LINEAR:
> >>> -memcpy(ul, 
> >>> (UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x06,0x04,0x01,0x01,0x01,0x01,0x06,0x00,0x00},
> >>>  16);
> >>> +memcpy(ul, 
> >>> ((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x06,0x04,0x01,0x01,0x01,0x01,0x06,0x00,0x00}),
> >>>  16);
> >>>  return 0;
> >>>  case AVCOL_TRC_SMPTE428  :
> >>> -memcpy(ul, 
> >>> (UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x08,0x04,0x01,0x01,0x01,0x01,0x07,0x00,0x00},
> >>>  16);
> >>> +memcpy(ul, 
> >>> ((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x08,0x04,0x01,0x01,0x01,0x01,0x07,0x00,0x00}),
> >>>  16);
> >>>  return 0;
> >>>  default:
> >>>  return -1;
> >>
> >> Why not just declare these as static const like mxf_mpeg2_codec_uls or
> >> the descriptor keys right above this function?
> > 
> > possible but it would seperate the values from the switch/case, making
> > it harder to see what is stored by what.
> > If people prefer i can change it to that ?
> > I think its more readable as is / with the patch above though
> 
> It's fine as is with me. I think it looks odd when compared to other
> functions writing UID constants, so it was a suggestion based on
> consistency more than anything.

will apply

thanks


[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Add some () to attempt to workaround build issue on osx

2018-05-24 Thread James Almer 
On 5/23/2018 9:38 PM, Michael Niedermayer wrote:
> On Tue, May 22, 2018 at 06:13:47PM -0300, James Almer wrote:
>> On 5/22/2018 3:57 PM, Michael Niedermayer wrote:
>>> May fix ticket7209
>>>
>>> Signed-off-by: Michael Niedermayer 
>>> ---
>>>  libavformat/mxfenc.c | 12 ++--
>>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
>>> index 44425bf6c9..77f60f5874 100644
>>> --- a/libavformat/mxfenc.c
>>> +++ b/libavformat/mxfenc.c
>>> @@ -1149,23 +1149,23 @@ static int get_trc(UID ul, enum 
>>> AVColorTransferCharacteristic trc)
>>>  switch (trc){
>>>  case AVCOL_TRC_GAMMA28   :
>>>  case AVCOL_TRC_GAMMA22   :
>>> -memcpy(ul, 
>>> (UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x01,0x00,0x00},
>>>  16);
>>> +memcpy(ul, 
>>> ((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x01,0x00,0x00}),
>>>  16);
>>>  return 0;
>>>  case AVCOL_TRC_BT709 :
>>>  case AVCOL_TRC_SMPTE170M :
>>> -memcpy(ul, 
>>> (UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x02,0x00,0x00},
>>>  16);
>>> +memcpy(ul, 
>>> ((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x02,0x00,0x00}),
>>>  16);
>>>  return 0;
>>>  case AVCOL_TRC_SMPTE240M :
>>> -memcpy(ul, 
>>> (UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x03,0x00,0x00},
>>>  16);
>>> +memcpy(ul, 
>>> ((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x03,0x00,0x00}),
>>>  16);
>>>  return 0;
>>>  case AVCOL_TRC_BT1361_ECG:
>>> -memcpy(ul, 
>>> (UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x06,0x04,0x01,0x01,0x01,0x01,0x05,0x00,0x00},
>>>  16);
>>> +memcpy(ul, 
>>> ((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x06,0x04,0x01,0x01,0x01,0x01,0x05,0x00,0x00}),
>>>  16);
>>>  return 0;
>>>  case AVCOL_TRC_LINEAR:
>>> -memcpy(ul, 
>>> (UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x06,0x04,0x01,0x01,0x01,0x01,0x06,0x00,0x00},
>>>  16);
>>> +memcpy(ul, 
>>> ((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x06,0x04,0x01,0x01,0x01,0x01,0x06,0x00,0x00}),
>>>  16);
>>>  return 0;
>>>  case AVCOL_TRC_SMPTE428  :
>>> -memcpy(ul, 
>>> (UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x08,0x04,0x01,0x01,0x01,0x01,0x07,0x00,0x00},
>>>  16);
>>> +memcpy(ul, 
>>> ((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x08,0x04,0x01,0x01,0x01,0x01,0x07,0x00,0x00}),
>>>  16);
>>>  return 0;
>>>  default:
>>>  return -1;
>>
>> Why not just declare these as static const like mxf_mpeg2_codec_uls or
>> the descriptor keys right above this function?
> 
> possible but it would seperate the values from the switch/case, making
> it harder to see what is stored by what.
> If people prefer i can change it to that ?
> I think its more readable as is / with the patch above though

It's fine as is with me. I think it looks odd when compared to other
functions writing UID constants, so it was a suggestion based on
consistency more than anything.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Add some () to attempt to workaround build issue on osx

2018-05-23 Thread Michael Niedermayer 
On Tue, May 22, 2018 at 06:13:47PM -0300, James Almer wrote:
> On 5/22/2018 3:57 PM, Michael Niedermayer wrote:
> > May fix ticket7209
> > 
> > Signed-off-by: Michael Niedermayer 
> > ---
> >  libavformat/mxfenc.c | 12 ++--
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> > 
> > diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
> > index 44425bf6c9..77f60f5874 100644
> > --- a/libavformat/mxfenc.c
> > +++ b/libavformat/mxfenc.c
> > @@ -1149,23 +1149,23 @@ static int get_trc(UID ul, enum 
> > AVColorTransferCharacteristic trc)
> >  switch (trc){
> >  case AVCOL_TRC_GAMMA28   :
> >  case AVCOL_TRC_GAMMA22   :
> > -memcpy(ul, 
> > (UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x01,0x00,0x00},
> >  16);
> > +memcpy(ul, 
> > ((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x01,0x00,0x00}),
> >  16);
> >  return 0;
> >  case AVCOL_TRC_BT709 :
> >  case AVCOL_TRC_SMPTE170M :
> > -memcpy(ul, 
> > (UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x02,0x00,0x00},
> >  16);
> > +memcpy(ul, 
> > ((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x02,0x00,0x00}),
> >  16);
> >  return 0;
> >  case AVCOL_TRC_SMPTE240M :
> > -memcpy(ul, 
> > (UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x03,0x00,0x00},
> >  16);
> > +memcpy(ul, 
> > ((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x03,0x00,0x00}),
> >  16);
> >  return 0;
> >  case AVCOL_TRC_BT1361_ECG:
> > -memcpy(ul, 
> > (UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x06,0x04,0x01,0x01,0x01,0x01,0x05,0x00,0x00},
> >  16);
> > +memcpy(ul, 
> > ((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x06,0x04,0x01,0x01,0x01,0x01,0x05,0x00,0x00}),
> >  16);
> >  return 0;
> >  case AVCOL_TRC_LINEAR:
> > -memcpy(ul, 
> > (UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x06,0x04,0x01,0x01,0x01,0x01,0x06,0x00,0x00},
> >  16);
> > +memcpy(ul, 
> > ((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x06,0x04,0x01,0x01,0x01,0x01,0x06,0x00,0x00}),
> >  16);
> >  return 0;
> >  case AVCOL_TRC_SMPTE428  :
> > -memcpy(ul, 
> > (UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x08,0x04,0x01,0x01,0x01,0x01,0x07,0x00,0x00},
> >  16);
> > +memcpy(ul, 
> > ((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x08,0x04,0x01,0x01,0x01,0x01,0x07,0x00,0x00}),
> >  16);
> >  return 0;
> >  default:
> >  return -1;
> 
> Why not just declare these as static const like mxf_mpeg2_codec_uls or
> the descriptor keys right above this function?

possible but it would seperate the values from the switch/case, making
it harder to see what is stored by what.
If people prefer i can change it to that ?
I think its more readable as is / with the patch above though

[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Add some () to attempt to workaround build issue on osx

2018-05-23 Thread Jim DeLaHunt 

On 5/22/2018 3:57 PM, Michael Niedermayer wrote:

May fix ticket7209

Signed-off-by: Michael Niedermayer http://ffmpeg.org/mailman/listinfo/ffmpeg-devel>>
---
 libavformat/mxfenc.c | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
index 44425bf6c9..77f60f5874 100644
--- a/libavformat/mxfenc.c
+++ b/libavformat/mxfenc.c
@@ -1149,23 +1149,23 @@ static int get_trc(UID ul, enum 
AVColorTransferCharacteristic trc)
 switch (trc){
 case AVCOL_TRC_GAMMA28   :
 case AVCOL_TRC_GAMMA22   :
-memcpy(ul, 
(UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x01,0x00,0x00},
 16);
+memcpy(ul, 
((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x01,0x00,0x00}),
 16);
 return 0;
 case AVCOL_TRC_BT709 :
 case AVCOL_TRC_SMPTE170M :
-memcpy(ul, 
(UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x02,0x00,0x00},
 16);
+memcpy(ul, 
((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x02,0x00,0x00}),
 16);
 return 0;
 case AVCOL_TRC_SMPTE240M :
-memcpy(ul, 
(UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x03,0x00,0x00},
 16);
+memcpy(ul, 
((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x03,0x00,0x00}),
 16);
 return 0;
 case AVCOL_TRC_BT1361_ECG:
-memcpy(ul, 
(UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x06,0x04,0x01,0x01,0x01,0x01,0x05,0x00,0x00},
 16);
+memcpy(ul, 
((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x06,0x04,0x01,0x01,0x01,0x01,0x05,0x00,0x00}),
 16);
 return 0;
 case AVCOL_TRC_LINEAR:
-memcpy(ul, 
(UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x06,0x04,0x01,0x01,0x01,0x01,0x06,0x00,0x00},
 16);
+memcpy(ul, 
((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x06,0x04,0x01,0x01,0x01,0x01,0x06,0x00,0x00}),
 16);
 return 0;
 case AVCOL_TRC_SMPTE428  :
-memcpy(ul, 
(UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x08,0x04,0x01,0x01,0x01,0x01,0x07,0x00,0x00},
 16);
+memcpy(ul, 
((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x08,0x04,0x01,0x01,0x01,0x01,0x07,0x00,0x00}),
 16);
 return 0;
 default:
 return -1;


I independently authored this change on my Mac OS X 10.11.6 system. It was 
effective in correcting the compile errors
in libavformat/mxfenc.o, and then make fate ran successfully.

--
--Jim DeLaHunt, j...@jdlh.com http://blog.jdlh.com/ (http://jdlh.com/)
  multilingual websites consultant

  355-1027 Davie St, Vancouver BC V6E 4L2, Canada
 Canada mobile +1-604-376-8953

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Add some () to attempt to workaround build issue on osx

2018-05-22 Thread James Almer 
On 5/22/2018 3:57 PM, Michael Niedermayer wrote:
> May fix ticket7209
> 
> Signed-off-by: Michael Niedermayer 
> ---
>  libavformat/mxfenc.c | 12 ++--
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
> index 44425bf6c9..77f60f5874 100644
> --- a/libavformat/mxfenc.c
> +++ b/libavformat/mxfenc.c
> @@ -1149,23 +1149,23 @@ static int get_trc(UID ul, enum 
> AVColorTransferCharacteristic trc)
>  switch (trc){
>  case AVCOL_TRC_GAMMA28   :
>  case AVCOL_TRC_GAMMA22   :
> -memcpy(ul, 
> (UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x01,0x00,0x00},
>  16);
> +memcpy(ul, 
> ((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x01,0x00,0x00}),
>  16);
>  return 0;
>  case AVCOL_TRC_BT709 :
>  case AVCOL_TRC_SMPTE170M :
> -memcpy(ul, 
> (UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x02,0x00,0x00},
>  16);
> +memcpy(ul, 
> ((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x02,0x00,0x00}),
>  16);
>  return 0;
>  case AVCOL_TRC_SMPTE240M :
> -memcpy(ul, 
> (UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x03,0x00,0x00},
>  16);
> +memcpy(ul, 
> ((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x03,0x00,0x00}),
>  16);
>  return 0;
>  case AVCOL_TRC_BT1361_ECG:
> -memcpy(ul, 
> (UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x06,0x04,0x01,0x01,0x01,0x01,0x05,0x00,0x00},
>  16);
> +memcpy(ul, 
> ((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x06,0x04,0x01,0x01,0x01,0x01,0x05,0x00,0x00}),
>  16);
>  return 0;
>  case AVCOL_TRC_LINEAR:
> -memcpy(ul, 
> (UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x06,0x04,0x01,0x01,0x01,0x01,0x06,0x00,0x00},
>  16);
> +memcpy(ul, 
> ((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x06,0x04,0x01,0x01,0x01,0x01,0x06,0x00,0x00}),
>  16);
>  return 0;
>  case AVCOL_TRC_SMPTE428  :
> -memcpy(ul, 
> (UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x08,0x04,0x01,0x01,0x01,0x01,0x07,0x00,0x00},
>  16);
> +memcpy(ul, 
> ((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x08,0x04,0x01,0x01,0x01,0x01,0x07,0x00,0x00}),
>  16);
>  return 0;
>  default:
>  return -1;

Why not just declare these as static const like mxf_mpeg2_codec_uls or
the descriptor keys right above this function?
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] libavformat/mxfenc: Add some () to attempt to workaround build issue on osx

2018-05-22 Thread Michael Niedermayer 
May fix ticket7209

Signed-off-by: Michael Niedermayer 
---
 libavformat/mxfenc.c | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
index 44425bf6c9..77f60f5874 100644
--- a/libavformat/mxfenc.c
+++ b/libavformat/mxfenc.c
@@ -1149,23 +1149,23 @@ static int get_trc(UID ul, enum 
AVColorTransferCharacteristic trc)
 switch (trc){
 case AVCOL_TRC_GAMMA28   :
 case AVCOL_TRC_GAMMA22   :
-memcpy(ul, 
(UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x01,0x00,0x00},
 16);
+memcpy(ul, 
((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x01,0x00,0x00}),
 16);
 return 0;
 case AVCOL_TRC_BT709 :
 case AVCOL_TRC_SMPTE170M :
-memcpy(ul, 
(UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x02,0x00,0x00},
 16);
+memcpy(ul, 
((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x02,0x00,0x00}),
 16);
 return 0;
 case AVCOL_TRC_SMPTE240M :
-memcpy(ul, 
(UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x03,0x00,0x00},
 16);
+memcpy(ul, 
((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x01,0x01,0x01,0x03,0x00,0x00}),
 16);
 return 0;
 case AVCOL_TRC_BT1361_ECG:
-memcpy(ul, 
(UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x06,0x04,0x01,0x01,0x01,0x01,0x05,0x00,0x00},
 16);
+memcpy(ul, 
((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x06,0x04,0x01,0x01,0x01,0x01,0x05,0x00,0x00}),
 16);
 return 0;
 case AVCOL_TRC_LINEAR:
-memcpy(ul, 
(UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x06,0x04,0x01,0x01,0x01,0x01,0x06,0x00,0x00},
 16);
+memcpy(ul, 
((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x06,0x04,0x01,0x01,0x01,0x01,0x06,0x00,0x00}),
 16);
 return 0;
 case AVCOL_TRC_SMPTE428  :
-memcpy(ul, 
(UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x08,0x04,0x01,0x01,0x01,0x01,0x07,0x00,0x00},
 16);
+memcpy(ul, 
((UID){0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x08,0x04,0x01,0x01,0x01,0x01,0x07,0x00,0x00}),
 16);
 return 0;
 default:
 return -1;
-- 
2.17.0

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel