Re: [Flightgear-devel] segfaults in SGShaderAnimatio n::~SGShaderAnimation (), Patch
On Wednesday 31 January 2007 07:35:15 Frederic Bouvier wrote: > Nick, > > Selon Nick Warne : > > Fred, Mathias > > > > I got this again tonight :-((( > > > > Chat [mpserve] GFS is now online, using > > > > Chat [mpserve] Aircraft/B-2/Models/b2-spirit.xml > > > > Chat [mpserve] GFS is now online, using > > > > Chat [mpserve] Aircraft/B-2/Models/b2-spirit.xml > > > > Segmentation fault > > > > Another person in IRC reports the same crash at the same time when this > > aircraft joined/left/joined. > > > > The common theme here is neither of us _have_ that model 'b2-spirit' ! > > Not every segfault is in SGShaderAnimation ;-) > > Could you provide a gdb backtrace please ? Update on this. I tried to recreate it (with help from people in IRC), but to no avail. Tonight I got the MP 'new player' join crash again: Chat [mpserve] PWOE is now online, using Chat [mpserve] Aircraft/c172p/Models/c172p.xml Segmentation fault I guess I will have to run fgfs everytime from now on in debugger to catch it. More to follow. Nick - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] segfaults in SGShaderAnimatio n::~SGShaderAnimation (), Patch
On Friday 26 January 2007 20:45:55 Nick Warne wrote:
> On Friday 26 January 2007 20:14, Maik Justus wrote:
> > Hi Fred,
> >
> > your patch works fine for me.
> >
> >
> > Big thanks!
> > Maik
>
> Fred,
>
> I tested with Maik while I was building. I just tested with ndim, and NO
> CRASH - it looks very, very good.
>
> Thank you!
>
> Nick
Fred, Mathias
I got this again tonight :-(((
Chat [mpserve] GFS is now online, using
Chat [mpserve] Aircraft/B-2/Models/b2-spirit.xml
Chat [mpserve] GFS is now online, using
Chat [mpserve] Aircraft/B-2/Models/b2-spirit.xml
Segmentation fault
Another person in IRC reports the same crash at the same time when this
aircraft joined/left/joined.
The common theme here is neither of us _have_ that model 'b2-spirit' !
Nick
>
> > Frederic Bouvier schrieb am 26.01.2007 20:41:
> > > Selon Nick Warne :
> > >> Reports from IRC say this is fixed in plib, but I can still get a 100%
> > >> reliable crash with OSG build.
> > >>
> > >> Enter MP server using Harrier. Get someone to join/leave/join with
> > >> the dhc2F.
> > >> Immediate segfault on the second join.
> > >>
> > >> Below is my earlier mail with trace etc.
> > >
> > > Are you able to test the patch below. If it works for you, I'll commit
> > > it.
> > >
> > > -Fred
> > >
> > > cvs -z4 -q diff -u -wb -- shadanim.cxx (in directory
> > > C:\Devel\SimGear\simgear\scene\model\)
> > > Index: shadanim.cxx
> > > ===
> > > RCS file:
> > > /var/cvs/SimGear-0.3/SimGear/simgear/scene/model/shadanim.cxx,v
> > > retrieving revision 1.9
> > > diff -u -w -b -r1.9 shadanim.cxx
> > > --- shadanim.cxx 3 Dec 2006 16:57:21 - 1.9
> > > +++ shadanim.cxx 26 Jan 2007 19:14:34 -
> > > @@ -126,14 +126,12 @@
> > > static osg::TextureCubeMap*
> > > getOrCreateTextureCubeMap()
> > > {
> > > - static osg::TextureCubeMap* textureCubeMap = 0;
> > > - if (textureCubeMap)
> > > -return textureCubeMap;
> > > + static osg::ref_ptr textureCubeMap;
> > >
> > >static SGMutex mutex;
> > >SGGuard locker(mutex);
> > > - if (textureCubeMap)
> > > -return textureCubeMap;
> > > + if (textureCubeMap.get())
> > > +return textureCubeMap.get();
> > >
> > >// create and setup the texture object
> > >textureCubeMap = new osg::TextureCubeMap;
> > > @@ -146,7 +144,7 @@
> > >
> > >textureCubeMap->setUpdateCallback(new SGMapGenCallback);
> > >
> > > - return textureCubeMap;
> > > + return textureCubeMap.get();
> > > }
> > >
> > > static void create_specular_highlights(osg::Node *node)
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] segfaults in SGShaderAnimatio n::~SGShaderAnimation (), Patch
On Friday 26 January 2007 20:14, Maik Justus wrote:
> Hi Fred,
>
> your patch works fine for me.
>
>
> Big thanks!
> Maik
Fred,
I tested with Maik while I was building. I just tested with ndim, and NO
CRASH - it looks very, very good.
Thank you!
Nick
>
> Frederic Bouvier schrieb am 26.01.2007 20:41:
> > Selon Nick Warne :
> >> Reports from IRC say this is fixed in plib, but I can still get a 100%
> >> reliable crash with OSG build.
> >>
> >> Enter MP server using Harrier. Get someone to join/leave/join with the
> >> dhc2F.
> >> Immediate segfault on the second join.
> >>
> >> Below is my earlier mail with trace etc.
> >
> > Are you able to test the patch below. If it works for you, I'll commit
> > it.
> >
> > -Fred
> >
> > cvs -z4 -q diff -u -wb -- shadanim.cxx (in directory
> > C:\Devel\SimGear\simgear\scene\model\)
> > Index: shadanim.cxx
> > ===
> > RCS file: /var/cvs/SimGear-0.3/SimGear/simgear/scene/model/shadanim.cxx,v
> > retrieving revision 1.9
> > diff -u -w -b -r1.9 shadanim.cxx
> > --- shadanim.cxx3 Dec 2006 16:57:21 - 1.9
> > +++ shadanim.cxx26 Jan 2007 19:14:34 -
> > @@ -126,14 +126,12 @@
> > static osg::TextureCubeMap*
> > getOrCreateTextureCubeMap()
> > {
> > - static osg::TextureCubeMap* textureCubeMap = 0;
> > - if (textureCubeMap)
> > -return textureCubeMap;
> > + static osg::ref_ptr textureCubeMap;
> >
> >static SGMutex mutex;
> >SGGuard locker(mutex);
> > - if (textureCubeMap)
> > -return textureCubeMap;
> > + if (textureCubeMap.get())
> > +return textureCubeMap.get();
> >
> >// create and setup the texture object
> >textureCubeMap = new osg::TextureCubeMap;
> > @@ -146,7 +144,7 @@
> >
> >textureCubeMap->setUpdateCallback(new SGMapGenCallback);
> >
> > - return textureCubeMap;
> > + return textureCubeMap.get();
> > }
> >
> > static void create_specular_highlights(osg::Node *node)
>
> -
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share
> your opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> ___
> Flightgear-devel mailing list
> Flightgear-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/flightgear-devel
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] segfaults in SGShaderAnimatio n::~SGShaderAnimation (), Patch
On Friday 26 January 2007 19:08, Maik Justus wrote:
> Hi all,
>
> here is a workaround for osg. It disables the chrome shader, but as long
> as this causes the fatal crashes we need to commit.
>
> Unfortunately I am not compiling osg myself; I am using Olafs
> precompiled library. Therefore I can not dig into the code :-(
I believe, looking at my traces, this function in
OpenSceneGraph/src/osg/StateSet.cpp is where it happens. Why/how/what I
haven't a clue.
void StateSet::setTextureAttributeAndModes(unsigned int unit,StateAttribute
*attribute, StateAttribute::GLModeValue value)
{
if (attribute)
{
if (attribute->isTextureAttribute())
{
if (value&StateAttribute::INHERIT)
{
removeTextureAttribute(unit,attribute->getType());
}
else
Nick
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel
