Re: [Freeipa-devel] [PATCH] 942 webui: add examples to network address validator error message

2016-01-08 Thread Martin Basti 



On 22.12.2015 14:33, Gabe Alford wrote:

LGTM.

Gabe

On Tue, Dec 22, 2015 at 6:06 AM, Petr Vobornik > wrote:


https://fedorahosted.org/freeipa/ticket/5532
-- 
Petr Vobornik


--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code





ACK

Pushed to:
master: a291ca87803c1cbaeaba60006b52596ad77b7f4b
ipa-4-3: 77f9a3a669d109a54eaee896c7fc2ebe741c81cd

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [PATCH] 942 webui: add examples to network address validator error message

2015-12-22 Thread Petr Vobornik 

https://fedorahosted.org/freeipa/ticket/5532
--
Petr Vobornik
From 8ba63e0e76c75253fe4cd16d4aae245a1714ea77 Mon Sep 17 00:00:00 2001
From: Petr Vobornik 
Date: Tue, 22 Dec 2015 14:05:02 +0100
Subject: [PATCH] webui: add examples to network address validator error
 message

https://fedorahosted.org/freeipa/ticket/5532
---
 install/ui/test/data/ipa_init.json | 2 +-
 ipalib/plugins/internal.py | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/install/ui/test/data/ipa_init.json b/install/ui/test/data/ipa_init.json
index 3ac827811c347bc03e3c93ea1d91a5f9cf558080..310eef1055a19dd40f8221c2967b09773595b80b 100644
--- a/install/ui/test/data/ipa_init.json
+++ b/install/ui/test/data/ipa_init.json
@@ -696,7 +696,7 @@
 "ip_v6_address": "Not a valid IPv6 address",
 "max_value": "Maximum value is ${value}",
 "min_value": "Minimum value is ${value}",
-"net_address": "Not a valid network address",
+"net_address": "Not a valid network address (examples: 2001:db8::/64, 192.0.2.0/24)",
 "parse": "Parse error",
 "port": "'${port}' is not a valid port",
 "required": "Required field",
diff --git a/ipalib/plugins/internal.py b/ipalib/plugins/internal.py
index 1c58b6bd1dc5bc97398374f1c32ff30409e5a001..2cead97926ccb8c5c33fe69f79ab3a479bdf1c53 100644
--- a/ipalib/plugins/internal.py
+++ b/ipalib/plugins/internal.py
@@ -843,7 +843,7 @@ class i18n_messages(Command):
 "ip_v6_address": _('Not a valid IPv6 address'),
 "max_value": _("Maximum value is ${value}"),
 "min_value": _("Minimum value is ${value}"),
-"net_address": _("Not a valid network address"),
+"net_address": _("Not a valid network address (examples: 2001:db8::/64, 192.0.2.0/24)"),
 "parse": _("Parse error"),
 "port": _("'${port}' is not a valid port"),
 "required": _("Required field"),
-- 
2.4.3

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH] 942 webui: add examples to network address validator error message

2015-12-22 Thread Gabe Alford 
LGTM.

Gabe

On Tue, Dec 22, 2015 at 6:06 AM, Petr Vobornik  wrote:

> https://fedorahosted.org/freeipa/ticket/5532
> --
> Petr Vobornik
>
> --
> Manage your subscription for the Freeipa-devel mailing list:
> https://www.redhat.com/mailman/listinfo/freeipa-devel
> Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
>
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code