Re: [gentoo-portage-dev] [PATCH] Repoman subversion support

2008-05-14 Thread Fabian Groffen
On 14-05-2008 16:27:28 +0200, Arfrever Frehtes Taifersar Arahesis wrote:
> 2008-05-14 00:32 Marius Mauch <[EMAIL PROTECTED]> napisał(a):
> > Merged in r10325 with some minor changes (removed the 'svn update' bit
> > until someone remembers why exactly it's there
> 
> During committing, only files, which are being committed, are being
> updated, so `svn up` is certainly a good idea. Please add it.

Details here are that the code did this:

if vcs == "cvs":
myf=open(checkdir+"/CVS/Entries","r")
if vcs == "svn":
myf=os.popen("svn update > /dev/null; svn list")

genone's remark here refers to this `svn update`, of which I don't
recall any more why I added it.  All I know is that I think I needed it
for some reason to get a correct output of "list".  However, I have no
proof here, so he removed the svn update, which gives a non-announced
possible modification of the local repository.


-- 
Fabian Groffen
Gentoo on a different level
-- 
gentoo-portage-dev@lists.gentoo.org mailing list



Re: [gentoo-portage-dev] [PATCH] Repoman subversion support

2008-05-14 Thread Arfrever Frehtes Taifersar Arahesis
2008-05-14 00:32 Marius Mauch <[EMAIL PROTECTED]> napisał(a):
> Merged in r10325 with some minor changes (removed the 'svn update' bit
> until someone remembers why exactly it's there

During committing, only files, which are being committed, are being
updated, so `svn up` is certainly a good idea. Please add it.


Re: [gentoo-portage-dev] [PATCH] show binhosts as "repository"

2008-05-14 Thread Fabian Groffen
On 14-05-2008 00:45:10 +0200, Marius Mauch wrote:
> On Mon, 12 May 2008 20:53:35 +0200
> Fabian Groffen <[EMAIL PROTECTED]> wrote:
> 
> > The following patch shows the url to the binhost in an emerge -av as
> > repository name, instead of "unknown".  Unfortunately the patch
> > doesn't store the binhost url, such that portage can't show where the
> > package comes from when unmerged.
> 
> Not sure if this is the right thing to do, or if the reponame in those
> cases should be the one from the source repo that was used to generate
> those binary packages. Not saying that the binhost name here is
> useless, quite the opposite, just a bit concerned about mixing
> different things here.

The idea behind it is that the repo_name of the binhost is not
necessarily useful.  In many cases it will contain the default repo_name
value, since people just create binpkgs with a standard Portage install.

I agree it is a hack.  Perhaps a combination of the repo_name and its
url would be the best.


-- 
Fabian Groffen
Gentoo on a different level
-- 
gentoo-portage-dev@lists.gentoo.org mailing list