Re: [gentoo-portage-dev] [PATCH] SyncManager: redirect command stderr to stdout (bug 566132)
On 11/23/2015 02:39 AM, Alexander Berntsen wrote: > Sorry for not being up to date what this does, but the bug complains > specifically about GitHub mirrors, while the patch itself seems far > more invasive. Is it the case that they should *never* go to STDERR? Since the sync modules can call a variety of different commands, it's hard to predict which ones will unnecessarily write to stderr. So, the assumption here is that the process exit status is a more reliable indicator for errors. For example, the python code in GitSync will write an error message to stderr if the git process exits with non-zero status. -- Thanks, Zac
Re: [gentoo-portage-dev] [PATCH] SyncManager: redirect command stderr to stdout (bug 566132)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Sorry for not being up to date what this does, but the bug complains specifically about GitHub mirrors, while the patch itself seems far more invasive. Is it the case that they should *never* go to STDERR? - -- Alexander berna...@gentoo.org https://secure.plaimi.net/~alexander -BEGIN PGP SIGNATURE- Version: GnuPG v2 iQIcBAEBCgAGBQJWUuzpAAoJENQqWdRUGk8BMdQQAKACO5bGwnXxbyNRuh/KzIiH e38mzzvxDibJTTz32XSsOn1w9StZkSWAcDwT8Ef4QGeQJxmLTXUW+5eUsAVoaNxy VY81iQbDmcSf+erljYEuUBBOFDMORYGwhSROdvvLE/0d3LFP6AurWx9a4kb229j7 DB8HmpjXkkpT65YgJvp2vD51x+K5HsDOKTObBcDreiea21u2X6DNcGbVOK35IXs3 fbTovSrL39qTk8zPSvuwePHlfWelsTCmj/+2EmLVJMTem/cTo0uxCfGCOmwALusk FI4YcV1zf1cMrL1tqU9B7bYSH8oci4Rfs80IanieDwpd59V32xQ8ckyOP8ME5gG/ xbqipfwbWJyyUFErL7BZE9/H90tib9uofR9mxP9BylXjsDMbu/sC7OA2ElBNVilp TJGvmRb3jdIWsSddNsOgdN2XofR20G5Ow/NKEvpueM42Pk4s6lqYwZODmsU5kOsS wSw6ErQO6RCKfu0iQhQo3VS4EjP95sVl21nXtJk6v8AkNwNkU1TNZ8f1Ds5CaALR 79XpFL3JQy/zwd0uMY7kOjgezJJeu4nhfSz2k1ZDNLHokTcqhqR4WdXqzkWA2iZq Y6p6CLWY57TIiih0ASt+NSfrkRl1628irZyVcyoVKDpaWCVcWq+G1sAl4pmAXpXV nVhyL0zqartr+TNlFz2N =g6l5 -END PGP SIGNATURE-
Re: [gentoo-portage-dev] [PATCH v2] SpawnProcess: re-check cgroup.procs until empty (bug 566420)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 This looks pretty dirty. But I guess I trust you, so ACK. - -- Alexander berna...@gentoo.org https://secure.plaimi.net/~alexander -BEGIN PGP SIGNATURE- Version: GnuPG v2 iQIcBAEBCgAGBQJWUus6AAoJENQqWdRUGk8BS/sQAN3Qw7bv/lZb5PksYqKMqIFL PwilyLidtj4XeACurnJzsGODC/I2jhxhdBkG7bfLPMmQ0xrobJWVHKK6t2SBOtDK M/fLz/3nuN4Anyrt0jEEqhkp4kZaJOquWr7k3Rg6o9XXtETP/Y+MKqU1vh8EkgPE Rswk3XasOLxmzT5BtEiOIOuwUknEUB3McmLZhZfSMhwKKePtZfV2TP4AFqr8qng5 Rl4ULMQrC6jbuI6BxZySyPS14+SppkLYK5NOR/eiTRmcXqJ3tRJPr392U+Pg9dav OxZvUcteOCK8W52kCgPy46vp/tXqmBC1Euy5vRe+y2MqoGB+4kCrqI+qy2W0WGx3 3sV5viSf0bW+pE1dKFq5eVoxdJwBKiEg/PNY1ff7GqOeXC33AacR1d0UtIuOKZ9o ZSokwp0flhn8MalIK98q4a1HEWSlCScoKLDaqCUWpA3QxqEHX0p3iaapwgHPRaz0 JtjzOjkMkTytuVZzFgM4Ce2KgRBbgKBjdGOZDkz1oqC6zQ+y19ZBc7Bc1FMY5e5r rKEjl56z4ereVDMNSVa6eoRtDH3sWi1qD+avUm/wpelJNAO+jg0uFuVJnKzQXIw1 WkJDbzb/1982/25W3j3ebE5AgGZB+1CAs2P6SS+8kwJC9DIUfdvbWVk4GmeuhWKw AUQsjgXPxZTryLb0T/8t =VjYT -END PGP SIGNATURE-
Re: [gentoo-portage-dev] [PATCH] SpawnProcess: make _cancel kill all processes in cgroup (bug 566414)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 LGTM. - -- Alexander berna...@gentoo.org https://secure.plaimi.net/~alexander -BEGIN PGP SIGNATURE- Version: GnuPG v2 iQIcBAEBCgAGBQJWUuoxAAoJENQqWdRUGk8BsS8P/jBjggVVjB3see3RQN/wiBHi vzs1StQ0mtAeB3VTlW8uL6IvBljUMu3g3VxFB5+1sq9jE9mKbKFGXOU/iuwkKoIt tLNseVpDWnwKaamFDBFpRbeCA+9w4QiYgdlcbU48wIbQs2pSObpumfLslisnNuEy LjkwbcoHrf++kCbN3yGzZgSMoD1nSK0zrl5t4Zwf8CFifOeKs3M/Sv31mrhhu+C+ mwGhCupN2gYHKj8zoZqc6lVvWLNujlALz1bLej6A4cSLDgzuE8bRfbNVUrDM5hdo wsKXxTsMHIdMpjhbZsz2zZfE53gVK6eQlKETZhveX6me7MJ9Zhm+EYHTg1CpRK9L YtKE0gYszKRdpzTmTU2ZF3stycORUrWCbtg5lyO6ipwaEoBtNuagYAPn+dKjXMzf WipZeKsgvHITWLLI7U2ci/jkp4Fn+kNBnE5+oFAmSjCpdT0Xy9M8kwz1q3YU7BCQ Jz/smlmom3NGQqu9A2DXWAi2Ak4Se7Oaj3SuydCnvE6mkaY+pB4D1qlEMA3qc91N eP3/NCWZeyPGaIsBpQ/kKcREex6zztzYZpzo9Q9wxKc3tbfoMmcVg5LJ/dxAsWC8 wpdaaKtDnK+gURnda6BS2yQ9m9I5BUh5N23sUuavC3W/rZCUosbq15rE42N7yhcH Bp5yVyvltJ+BXmcF5kFL =pBUO -END PGP SIGNATURE-
