Re: [gentoo-portage-dev] [PATCH] ebuild: Extend helper-in-global-scope ban to all EAPIs

2016-06-26 Thread Michał Górny 
On Sun, 26 Jun 2016 17:07:09 -0700
Zac Medico  wrote:

> On 05/20/2016 03:27 PM, Michał Górny wrote:
> > On Thu,  5 May 2016 23:10:43 +0200
> > Michał Górny  wrote:
> >   
> >> Make helper calls in global scope fatal in all supported EAPIs since
> >> this is the behavior required by PMS and all major offenders are fixed
> >> already.
> >> ---
> >>  bin/eapi.sh   |  4 
> >>  bin/ebuild.sh | 30 ++
> >>  2 files changed, 6 insertions(+), 28 deletions(-)  
> > 
> > Merged now.
> >   
> 
> Seems we might need to revert this patch:
> 
> https://forums.gentoo.org/viewtopic-t-1047248.html

If we revert it, people will stop caring for another year...

-- 
Best regards,
Michał Górny



pgpjRRa6t3u7q.pgp
Description: OpenPGP digital signature

Re: [gentoo-portage-dev] [PATCH] ebuild: Extend helper-in-global-scope ban to all EAPIs

2016-06-26 Thread Zac Medico 
On 05/20/2016 03:27 PM, Michał Górny wrote:
> On Thu,  5 May 2016 23:10:43 +0200
> Michał Górny  wrote:
> 
>> Make helper calls in global scope fatal in all supported EAPIs since
>> this is the behavior required by PMS and all major offenders are fixed
>> already.
>> ---
>>  bin/eapi.sh   |  4 
>>  bin/ebuild.sh | 30 ++
>>  2 files changed, 6 insertions(+), 28 deletions(-)
> 
> Merged now.
> 

Seems we might need to revert this patch:

https://forums.gentoo.org/viewtopic-t-1047248.html
-- 
Thanks,
Zac

Re: [gentoo-portage-dev] [PATCH] ebuild: Extend helper-in-global-scope ban to all EAPIs

2016-05-20 Thread Michał Górny 
On Thu,  5 May 2016 23:10:43 +0200
Michał Górny  wrote:

> Make helper calls in global scope fatal in all supported EAPIs since
> this is the behavior required by PMS and all major offenders are fixed
> already.
> ---
>  bin/eapi.sh   |  4 
>  bin/ebuild.sh | 30 ++
>  2 files changed, 6 insertions(+), 28 deletions(-)

Merged now.

-- 
Best regards,
Michał Górny



pgpfu5F4jC_jU.pgp
Description: OpenPGP digital signature

Re: [gentoo-portage-dev] [PATCH] ebuild: Extend helper-in-global-scope ban to all EAPIs

2016-05-06 Thread Zac Medico 
On 05/06/2016 06:14 AM, Alexander Berntsen wrote:
> Patch looks OK, but this is hardly an area that I'm very knowledgeable
> about, so if anyone else wants to chime in, that would be great. :)

Looks good to me. We could have done this a long time ago, except that
it would have broken the illegal multislot stuff in toolchain packages.
-- 
Thanks,
Zac

Re: [gentoo-portage-dev] [PATCH] ebuild: Extend helper-in-global-scope ban to all EAPIs

2016-05-06 Thread Alexander Berntsen 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

Patch looks OK, but this is hardly an area that I'm very knowledgeable
about, so if anyone else wants to chime in, that would be great. :)

- -- 
Alexander
berna...@gentoo.org
https://secure.plaimi.net/~alexander
-BEGIN PGP SIGNATURE-
Version: GnuPG v2

iQIcBAEBCgAGBQJXLJjJAAoJENQqWdRUGk8BjqEQALTr4oZiev7SASu7AO91VgNh
63PUABMW9r0VeitKGuFP6HUthm3xk8cmNU44HKO/gZ9IyOkDTO+r+v60E1RbyES7
3nXfoU2vEoYTFiDo+UVvaZN92sJZMZvbU/DPOS3l+C8I7Saep/ZL6sb2556ohHWL
GI0xqy/5kMMNIX99AVCA9UW6APr/ofBHP+bRlkUpHmffbRGYqHpuPoGyYWg2kpWQ
XHKPgydntXRxJu4SCWdPlkD/CSjwEXt367TL60rBi7I7Q1sqZ50Tt731SmA9Z5Su
47NYdKExzphIknZ4l76zsvbFB7rkEhYi0Qz073Hc+Whp0zRgvl2akN/IN1lwTbV8
dIyu2Z3gIjp1I/m4JCdSXkniKKhG10UfCjg+nzX9wXDAhjDI5kzogYO2EkRqdkuV
n5h1ZyhBiYv/9XyIQw/B44kqPTs/QLsUbvIiFPoHEoVJ3iqab39lRW1NLYAjy4ul
TxMlwdSWCCP69JzdES5xp67WV6yBKPrOq/Wu1HO7KOlZkBDpFyz/7hvPRBcTBHTZ
sInLc+RCKhA5OyE2SWNH5NvQKYNqTyA6dpwgSsCvt61DVd908v1rWNMW8SJzj6CW
hOYEXVG85IMveoJD5RN41QWEh/To2ISbTkEiQDaG+z3tYmQ7CvcowBiRNhNQcdOr
lhLs30RL34n95bQoc9Zo
=qHwh
-END PGP SIGNATURE-