Re: [gentoo-portage-dev] [PATCH] glsa-check: fix truncated CVE ids in listmode (bug 692134)

2019-09-01 Thread Aaron Bauman
On Sat, Aug 31, 2019 at 09:11:11PM -0700, Zac Medico wrote:
> Use a regular expression to search for CVE ids in GLSA references.
> Import unicode_literals from __future__ since portage's Glsa class
> returns unicode strings for all python versions.
> 
> Reported-by: Georg Weiss 
> Bug: https://bugs.gentoo.org/692134
> Signed-off-by: Zac Medico 
> ---
>  bin/glsa-check | 11 +--
>  1 file changed, 9 insertions(+), 2 deletions(-)

Applied and checked multiple large GLSA's which contain numerous CVE's (e.g.
Chromium)

Acked-by: Aaron Bauman 

-- 
Cheers,
Aaron


signature.asc
Description: PGP signature


[gentoo-portage-dev] [PATCH] glsa-check: update man page

2019-09-01 Thread Aaron Bauman
* remove `new`
* add --reverse option information

Signed-off-by: Aaron Bauman 
---
 man/glsa-check.1 | 11 +++
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/man/glsa-check.1 b/man/glsa-check.1
index bb15cf5a9..8ec94b371 100644
--- a/man/glsa-check.1
+++ b/man/glsa-check.1
@@ -1,4 +1,7 @@
-.TH "GLSA\-CHECK" "1" "August 2019" "Portage VERSION" "Portage"
+.\" generated with Ronn/v0.7.3
+.\" http://github.com/rtomayko/ronn/tree/0.7.3
+.
+.TH "GLSA\-CHECK" "1" "September 2019" "" ""
 .
 .SH "NAME"
 \fBglsa\-check\fR \- Tool to locally monitor and manage GLSAs
@@ -37,9 +40,6 @@
 \fBV\fR, \fB\-\-version\fR Show information about \fBglsa\-check\fR\.
 .
 .P
-\fB\-q\fR, \fB\-\-quiet\fR Be less verbose and do not send empty mail\.
-.
-.P
 \fB\-v\fR, \fB\-\-verbose\fR Print more messages\.
 .
 .P
@@ -51,6 +51,9 @@
 .P
 \fB\-m\fR, \fB\-\-mail\fR Send a mail with the given GLSAs to the 
administrator\.
 .
+.P
+\fB\-r\fR, \fB\-\-reverse\fR List GLSAs in reverse order
+.
 .SH "EXAMPLES"
 \fBglsa\-check \-t all\fR Test the system against all GLSAs in the GLSA 
repository\.
 .
-- 
2.23.0




[gentoo-portage-dev] [PATCH] glsa-check: update man page with -r option

2019-09-01 Thread Aaron Bauman
Signed-off-by: Aaron Bauman 
---
 man/glsa-check.1 | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/man/glsa-check.1 b/man/glsa-check.1
index bb15cf5a9..23b5e9d94 100644
--- a/man/glsa-check.1
+++ b/man/glsa-check.1
@@ -1,4 +1,4 @@
-.TH "GLSA\-CHECK" "1" "August 2019" "Portage VERSION" "Portage"
+.TH "GLSA\-CHECK" "1" "September 2019" "Portage VERSION" "Portage"
 .
 .SH "NAME"
 \fBglsa\-check\fR \- Tool to locally monitor and manage GLSAs
@@ -37,9 +37,6 @@
 \fBV\fR, \fB\-\-version\fR Show information about \fBglsa\-check\fR\.
 .
 .P
-\fB\-q\fR, \fB\-\-quiet\fR Be less verbose and do not send empty mail\.
-.
-.P
 \fB\-v\fR, \fB\-\-verbose\fR Print more messages\.
 .
 .P
@@ -51,6 +48,9 @@
 .P
 \fB\-m\fR, \fB\-\-mail\fR Send a mail with the given GLSAs to the 
administrator\.
 .
+.P
+\fB\-r\fR, \fB\-\-reverse\fR List GLSAs in reverse order
+.
 .SH "EXAMPLES"
 \fBglsa\-check \-t all\fR Test the system against all GLSAs in the GLSA 
repository\.
 .
-- 
2.23.0




Re: [gentoo-portage-dev] [PATCH] glsa-check: add --reverse option (bug 235970)

2019-09-01 Thread Aaron Bauman
On Sat, Aug 31, 2019 at 09:41:55PM -0700, Zac Medico wrote:
> Add --reverse option which causes GLSAs to be listed in reverse order,
> so that the most recent GLSAs are listed earlier.
> 
> Suggested-by: Pavel Sanda 
> Bug: https://bugs.gentoo.org/235970
> Signed-off-by: Zac Medico 
> ---
>  bin/glsa-check | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/bin/glsa-check b/bin/glsa-check
> index 95ef16fde..6dbb7513c 100755
> --- a/bin/glsa-check
> +++ b/bin/glsa-check
> @@ -67,6 +67,8 @@ parser.add_argument("-e", "--emergelike", 
> action="store_false", dest="least_chan
>   help="Upgrade to latest version (not least-change)")
>  parser.add_argument("-c", "--cve", action="store_true", dest="list_cve",
>   help="Show CVE IDs in listing mode")
> +parser.add_argument("-r", "--reverse", action="store_true", dest="reverse",
> + help="List GLSAs in reverse order")
>  
>  options, params = parser.parse_known_args()
>  
> @@ -162,8 +164,7 @@ def summarylist(myglsalist, fd1=sys.stdout, 
> fd2=sys.stderr, encoding="utf-8"):
>   fd2.write(green("[U]")+" means the system is not affected 
> and\n")
>   fd2.write(red("[N]")+" indicates that the system might be 
> affected.\n\n")
>  
> - myglsalist.sort()
> - for myid in myglsalist:
> + for myid in sorted(myglsalist, reverse=options.reverse):
>   try:
>   myglsa = Glsa(myid, portage.settings, vardb, portdb)
>   except (GlsaTypeException, GlsaFormatException) as e:
> -- 
> 2.21.0
> 
> 

Applied and works great here on multiple combinations.

Acked-by: Aaron Bauman 

--
Cheers,
Aaron


signature.asc
Description: PGP signature


Re: [gentoo-portage-dev] [PATCH] glsa-check: update man page

2019-09-01 Thread Aaron Bauman
On Sun, Sep 01, 2019 at 11:27:01AM -0400, Aaron Bauman wrote:
> * remove `new`
> * add --reverse option information
> 
> Signed-off-by: Aaron Bauman 
> ---
>  man/glsa-check.1 | 11 +++

Please ignore

-- 
Cheers,
Aaron


signature.asc
Description: PGP signature


Re: [gentoo-portage-dev] [PATCH] glsa-check: update man page with -r option

2019-09-01 Thread Zac Medico
On 9/1/19 9:07 AM, Aaron Bauman wrote:
> Signed-off-by: Aaron Bauman 
> ---
>  man/glsa-check.1 | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/man/glsa-check.1 b/man/glsa-check.1
> index bb15cf5a9..23b5e9d94 100644
> --- a/man/glsa-check.1
> +++ b/man/glsa-check.1
> @@ -1,4 +1,4 @@
> -.TH "GLSA\-CHECK" "1" "August 2019" "Portage VERSION" "Portage"
> +.TH "GLSA\-CHECK" "1" "September 2019" "Portage VERSION" "Portage"
>  .
>  .SH "NAME"
>  \fBglsa\-check\fR \- Tool to locally monitor and manage GLSAs
> @@ -37,9 +37,6 @@
>  \fBV\fR, \fB\-\-version\fR Show information about \fBglsa\-check\fR\.
>  .
>  .P
> -\fB\-q\fR, \fB\-\-quiet\fR Be less verbose and do not send empty mail\.
> -.
> -.P
>  \fB\-v\fR, \fB\-\-verbose\fR Print more messages\.
>  .
>  .P
> @@ -51,6 +48,9 @@
>  .P
>  \fB\-m\fR, \fB\-\-mail\fR Send a mail with the given GLSAs to the 
> administrator\.
>  .
> +.P
> +\fB\-r\fR, \fB\-\-reverse\fR List GLSAs in reverse order
> +.
>  .SH "EXAMPLES"
>  \fBglsa\-check \-t all\fR Test the system against all GLSAs in the GLSA 
> repository\.
>  .
> 

Thanks, merged:

https://gitweb.gentoo.org/proj/portage.git/commit/?id=636ca48fa524efe5c0d1b69e35e86a422e6d4be1
-- 
Thanks,
Zac



signature.asc
Description: OpenPGP digital signature