Change in ...osmo-sip-connector[master]: Define hold/retrieve functions for MO calls
keith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15069 ) Change subject: Define hold/retrieve functions for MO calls .. Define hold/retrieve functions for MO calls My original patch that introduced this functionality, bd2d14bd4af592c2694217d84aaf81d759d2ca1 only did so for MT calls. Change-Id: Ifd42ed94053f6a38abfe6d6b18e2fe3582d037bb --- M src/sip.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/sip.c b/src/sip.c index 4eb7689..350eb0b 100644 --- a/src/sip.c +++ b/src/sip.c @@ -614,6 +614,8 @@ leg->base.call = call; leg->base.release_call = sip_release_call; leg->base.dtmf = sip_dtmf_call; + leg->base.hold_call = sip_hold_call; + leg->base.retrieve_call = sip_retrieve_call; leg->agent = agent; leg->nua_handle = nua_handle(agent->nua, leg, TAG_END()); -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15069 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ifd42ed94053f6a38abfe6d6b18e2fe3582d037bb Gerrit-Change-Number: 15069 Gerrit-PatchSet: 2 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in ...osmo-sip-connector[master]: Define hold/retrieve functions for MO calls
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15069 ) Change subject: Define hold/retrieve functions for MO calls .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15069 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ifd42ed94053f6a38abfe6d6b18e2fe3582d037bb Gerrit-Change-Number: 15069 Gerrit-PatchSet: 1 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 06 Aug 2019 17:31:36 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sip-connector[master]: Define hold/retrieve functions for MO calls
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15069 ) Change subject: Define hold/retrieve functions for MO calls .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15069 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ifd42ed94053f6a38abfe6d6b18e2fe3582d037bb Gerrit-Change-Number: 15069 Gerrit-PatchSet: 1 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 06 Aug 2019 16:22:29 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sip-connector[master]: Define hold/retrieve functions for MO calls
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15069 Change subject: Define hold/retrieve functions for MO calls .. Define hold/retrieve functions for MO calls My original patch that introduced this functionality, bd2d14bd4af592c2694217d84aaf81d759d2ca1 only did so for MT calls. Change-Id: Ifd42ed94053f6a38abfe6d6b18e2fe3582d037bb --- M src/sip.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/69/15069/1 diff --git a/src/sip.c b/src/sip.c index 4eb7689..350eb0b 100644 --- a/src/sip.c +++ b/src/sip.c @@ -614,6 +614,8 @@ leg->base.call = call; leg->base.release_call = sip_release_call; leg->base.dtmf = sip_dtmf_call; + leg->base.hold_call = sip_hold_call; + leg->base.retrieve_call = sip_retrieve_call; leg->agent = agent; leg->nua_handle = nua_handle(agent->nua, leg, TAG_END()); -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15069 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ifd42ed94053f6a38abfe6d6b18e2fe3582d037bb Gerrit-Change-Number: 15069 Gerrit-PatchSet: 1 Gerrit-Owner: keith Gerrit-MessageType: newchange
