Change in osmo-msc[master]: move project specific manuals to their own repos
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11726 ) Change subject: move project specific manuals to their own repos .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/11726/2/myscript.sh File myscript.sh: https://gerrit.osmocom.org/#/c/11726/2/myscript.sh@1 PS2, Line 1: echo "hello world" > wtf? I am sure this was very important for debugging stuff, although I can't remember the details :p - will remove that in the next patch. -- To view, visit https://gerrit.osmocom.org/11726 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f9c27f81940b02414f0e618483bffade72e8cf7 Gerrit-Change-Number: 11726 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: osmith Gerrit-CC: Harald Welte Gerrit-Comment-Date: Tue, 20 Nov 2018 09:24:58 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-msc[master]: move project specific manuals to their own repos
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11726 ) Change subject: move project specific manuals to their own repos .. Patch Set 2: Code-Review-1 (1 comment) looks mint except for myscript.sh https://gerrit.osmocom.org/#/c/11726/2/myscript.sh File myscript.sh: https://gerrit.osmocom.org/#/c/11726/2/myscript.sh@1 PS2, Line 1: echo "hello world" wtf? -- To view, visit https://gerrit.osmocom.org/11726 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f9c27f81940b02414f0e618483bffade72e8cf7 Gerrit-Change-Number: 11726 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: osmith Gerrit-CC: Harald Welte Gerrit-Comment-Date: Tue, 20 Nov 2018 01:44:17 + Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
Change in osmo-msc[master]: move project specific manuals to their own repos
Hello Pau Espin Pedrol, Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11726 to look at the new patch set (#2). Change subject: move project specific manuals to their own repos .. move project specific manuals to their own repos Build manuals when ./configure --enable-manuals is specified. Requires osmo-gsm-manuals to be installed. Related: OS#3385 Depends: I96933dd4dd6cac159847647f1c642215051a9aad (osmo-gsm-manuals) Change-Id: I2f9c27f81940b02414f0e618483bffade72e8cf7 --- M .gitignore M configure.ac M doc/Makefile.am A doc/manuals/Makefile.am A doc/manuals/chapters/control.adoc A doc/manuals/chapters/counters.adoc A doc/manuals/chapters/counters_generated.adoc A doc/manuals/chapters/net.adoc A doc/manuals/chapters/overview.adoc A doc/manuals/chapters/running.adoc A doc/manuals/images/sgs-imsi_attach_lu.msc A doc/manuals/images/sgs-mo_call_no_ps_ho.msc A doc/manuals/images/sgs-mo_sms_idle.msc A doc/manuals/images/sgs-mt_call_idle.msc A doc/manuals/images/sgs-mt_sms_idle.msc A doc/manuals/osmomsc-usermanual-docinfo.xml A doc/manuals/osmomsc-usermanual.adoc A doc/manuals/osmomsc-vty-reference.xml A doc/manuals/vty/msc_vty_additions.xml A doc/manuals/vty/msc_vty_reference.xml A myscript.sh 21 files changed, 3,318 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/26/11726/2 -- To view, visit https://gerrit.osmocom.org/11726 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2f9c27f81940b02414f0e618483bffade72e8cf7 Gerrit-Change-Number: 11726 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: osmith Gerrit-CC: Harald Welte
Change in osmo-msc[master]: move project specific manuals to their own repos
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11726 ) Change subject: move project specific manuals to their own repos .. Patch Set 1: I agree that 'man' is a bad naming choice. Call it manual, put it straight into the 'doc' directory, whatever. But don't call anything but man-pages related bits 'man', it will just confuse people. -- To view, visit https://gerrit.osmocom.org/11726 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f9c27f81940b02414f0e618483bffade72e8cf7 Gerrit-Change-Number: 11726 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: osmith Gerrit-CC: Harald Welte Gerrit-Comment-Date: Tue, 13 Nov 2018 14:57:41 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-msc[master]: move project specific manuals to their own repos
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11726 )
Change subject: move project specific manuals to their own repos
..
Patch Set 1:
(2 comments)
> I associate 'man' with the unix manpages. IIUC we are generating / going to
> generate manpages from this, but IMHO this should be called 'manuals'; or
> rather, just be directly in the doc/ dir, after all, "documentation /
> manuals" is redundant.
I agree with the name being confusing for manpages, so I welcome suggestions
for better folder names. And yes, the plan is to generate manpages eventually.
There's a separate issue for this: https://osmocom.org/issues/3386
If we did place the files directly in the doc folder, what about the project
repositories that already have files in there? I think it would be good to
separate the files that end up in the PDFs from the files that are meant to be
read otherwise. Also some doc folders already have Makefile.am inside (see
below).
My idea was to have this commit a blueprint to how to do it with the other
repositories as well, so it would be nice if we could find a solution that
works for all projects.
How about "doc/manuals" then? Or "doc/pdf"?
$ for i in *; do [ -d "$i/doc" ] || continue; echo ":: $i/doc"; ls $i/doc;
done
:: libosmocore/doc
vty
:: libosmo-sccp/doc
Makefile.am Makefile.in examples
:: osmo-bsc/doc
BS11-OML.txtassignment-fsm.dot handover-inter-bsc-in.msc lchan.msc
mgw-endpoint.msc
Makefilee1-data-model.txt handover-inter-bsc-in-fsm.dot
lchan-fsm.dot mgw-endpoint-fsm.dot
Makefile.am exampleshandover-inter-bsc-out.msc
lchan-rtp-fsm.dot timeslot.msc
Makefile.in handover.mschandover-inter-bsc-out-fsm.dot
legend_for_fsm_diagrams.dot timeslot-fsm.dot
assignment.msc handover.txthandover-intra-bsc-fsm.dot
legend_for_ladder_diagrams.msc ts-and-lchan-fsm-lifecycle.msc
:: osmo-bts/doc
Makefile.am control_interface.txt examples phy_link.txt startup.txt
:: osmo-ggsn/doc
Compliance.html Makefile.am Makefile.in examples osmo-ggsn.8 sgsnemu.8
:: osmo-hlr/doc
Makefile.am Makefile.in examples
:: osmo-iuh/doc
Makefile.am READMEhnb_cs_lu.msc hnb_cs_mo_sms.msc
hnb_cs_mt_sms.msc hnb_ps_pdp_act.msc
Makefile.in examples hnb_cs_mo_call.msc hnb_cs_mt_call.msc hnb_ps_lu.msc
protocols_around_hnbgw.txt
:: osmo-mgw/doc
Makefile.am Makefile.in examples
:: osmo-msc/doc
Makefile.am Makefile.in examples man
:: osmo-sgsn/doc
Makefile.am Makefile.in examples
:: osmo-sip-connector/doc
Makefile.am Makefile.in examples
:: osmo-trx/doc
Makefile.am Makefile.in examples
:: osmo-ttcn3-hacks/doc
osmodevcon2018-ttcn3_test_suites.adoc
https://gerrit.osmocom.org/#/c/11726/1/.gitignore
File .gitignore:
https://gerrit.osmocom.org/#/c/11726/1/.gitignore@66
PS1, Line 66: *.html
> Seems that the manuals get generated in the root dir of the {source,build}
> tree? I would prefer a su […]
They get generated in the manuals folder (doc/man currently). Some files also
end up in a "generated" subfolder (like it is the case with the current build
scripts in osmo-gsm-manuals.git), so doc/man/generated.
https://gerrit.osmocom.org/#/c/11726/1/doc/man/chapters/counters_generated.adoc
File doc/man/chapters/counters_generated.adoc:
https://gerrit.osmocom.org/#/c/11726/1/doc/man/chapters/counters_generated.adoc@6
PS1, Line 6: .msc - mobile switching center
> whitespace
It says "// autogenerated by show asciidoc counters" on top and it was copy
pasted from osmo-gsm-manuals.git's OsmoMSC folder. Should we change it anyway?
--
To view, visit https://gerrit.osmocom.org/11726
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f9c27f81940b02414f0e618483bffade72e8cf7
Gerrit-Change-Number: 11726
Gerrit-PatchSet: 1
Gerrit-Owner: osmith
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr
Gerrit-Reviewer: Pau Espin Pedrol
Gerrit-Reviewer: osmith
Gerrit-Comment-Date: Tue, 13 Nov 2018 13:07:02 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Change in osmo-msc[master]: move project specific manuals to their own repos
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/11726 )
Change subject: move project specific manuals to their own repos
..
Patch Set 1: Code-Review+1
(3 comments)
I associate 'man' with the unix manpages. IIUC we are generating / going to
generate manpages from this, but IMHO this should be called 'manuals'; or
rather, just be directly in the doc/ dir, after all, "documentation / manuals"
is redundant.
https://gerrit.osmocom.org/#/c/11726/1/.gitignore
File .gitignore:
https://gerrit.osmocom.org/#/c/11726/1/.gitignore@66
PS1, Line 66: *.html
Seems that the manuals get generated in the root dir of the {source,build}
tree? I would prefer a subdir
https://gerrit.osmocom.org/#/c/11726/1/doc/man/chapters/counters_generated.adoc
File doc/man/chapters/counters_generated.adoc:
https://gerrit.osmocom.org/#/c/11726/1/doc/man/chapters/counters_generated.adoc@6
PS1, Line 6: .msc - mobile switching center
whitespace
https://gerrit.osmocom.org/#/c/11726/1/doc/man/chapters/counters_generated.adoc@37
PS1, Line 37: | msc.active_calls | <> |
whitespace
--
To view, visit https://gerrit.osmocom.org/11726
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f9c27f81940b02414f0e618483bffade72e8cf7
Gerrit-Change-Number: 11726
Gerrit-PatchSet: 1
Gerrit-Owner: osmith
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr
Gerrit-Reviewer: Pau Espin Pedrol
Gerrit-Comment-Date: Mon, 12 Nov 2018 17:54:31 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
Change in osmo-msc[master]: move project specific manuals to their own repos
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11726 ) Change subject: move project specific manuals to their own repos .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11726 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f9c27f81940b02414f0e618483bffade72e8cf7 Gerrit-Change-Number: 11726 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Mon, 12 Nov 2018 13:33:30 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
