[MERGED] osmo-msc[master]: ussd.h: cosmetic: remove useless comment
Vadim Yanitskiy has submitted this change and it was merged. Change subject: ussd.h: cosmetic: remove useless comment .. ussd.h: cosmetic: remove useless comment We usually put comments for functions in *.c files, while header files are usually plain listings of the API without comments. Change-Id: I6b0d1d9e1a1b1ffb71cb9905e74f6fad2333bb65 --- M include/osmocom/msc/ussd.h 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/msc/ussd.h b/include/osmocom/msc/ussd.h index 2665468..84a3d6a 100644 --- a/include/osmocom/msc/ussd.h +++ b/include/osmocom/msc/ussd.h @@ -1,8 +1,6 @@ #ifndef _USSD_H #define _USSD_H -/* Handler function for mobile-originated USSD messages */ - #include int handle_rcv_ussd(struct gsm_subscriber_connection *conn, struct msgb *msg); -- To view, visit https://gerrit.osmocom.org/7672 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b0d1d9e1a1b1ffb71cb9905e74f6fad2333bb65 Gerrit-PatchSet: 3 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Vadim Yanitskiy
osmo-msc[master]: ussd.h: cosmetic: remove useless comment
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7672 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b0d1d9e1a1b1ffb71cb9905e74f6fad2333bb65 Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Vadim Yanitskiy Gerrit-HasComments: No
osmo-msc[master]: ussd.h: cosmetic: remove useless comment
Patch Set 2: > we put comments for functions typically in the .c file, by the > implementation of the function. .h files are usually plain listings > of the API without comments. Neels, ok, removed. -- To view, visit https://gerrit.osmocom.org/7672 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b0d1d9e1a1b1ffb71cb9905e74f6fad2333bb65 Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Vadim Yanitskiy Gerrit-HasComments: No
[PATCH] osmo-msc[master]: ussd.h: cosmetic: remove useless comment
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7672 to look at the new patch set (#2). ussd.h: cosmetic: remove useless comment We usually put comments for functions in *.c files, while header files are usually plain listings of the API without comments. Change-Id: I6b0d1d9e1a1b1ffb71cb9905e74f6fad2333bb65 --- M include/osmocom/msc/ussd.h 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/72/7672/2 diff --git a/include/osmocom/msc/ussd.h b/include/osmocom/msc/ussd.h index 2665468..84a3d6a 100644 --- a/include/osmocom/msc/ussd.h +++ b/include/osmocom/msc/ussd.h @@ -1,8 +1,6 @@ #ifndef _USSD_H #define _USSD_H -/* Handler function for mobile-originated USSD messages */ - #include int handle_rcv_ussd(struct gsm_subscriber_connection *conn, struct msgb *msg); -- To view, visit https://gerrit.osmocom.org/7672 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6b0d1d9e1a1b1ffb71cb9905e74f6fad2333bb65 Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Vadim Yanitskiy