Re: Type-level error messages

2015-10-29 Thread Adam Sandberg Eriksson
When you pulled the latest version from git did you pull both arcanist
and libphutil? I think I saw a similar error when I missed one. Also
`arc upgrade` should do the right thing for you (in the future).

~adam


On Thu, 29 Oct 2015, at 09:23 PM, Iavor Diatchki wrote:
> Hello,
>
> I've updated the implementation to match the discussion from this
> morning.  The idea is that `TypeError msd` is a type-family that can
> never be reduced, similar to `Any`.  We don't do anything special in
> the constraint solver, however when printing errors, if we encounter
> any constraints of the form:  * TypeError msg  * TypeError msg ~
> Something  * Something ~ TypeError msg
>
> Then we evaluate `msg` and use it as the error message.
>
> This is fairly simple, and appears to work quite well.  The
> implementation is on branch `wip/custom-type-errors`
> (https://github.com/ghc/ghc/tree/wip/custom-type-errors).
>
>
> == Arc Difficulties Below ===
>
> I tried to update the Phabricator patch but failed.  This is
> what I did:
>
> 1. arc diff master --update D1236 --head custom-type-errors
>
> Exception ERR-CONDUIT-CALL: API Method "differential.creatediff" does
> not define these parameters: 'arcanistProject'. (Run with `--trace`
> for a full exception trace.)
>
> 2. I thought that maybe I need to update `arcanist`, so I pulled the
>latest version for git.
>
> 3.arc diff master --update D1236 --head custom-type-errors
>
> Exception Failed to load class or interface 'PhutilClassMapQuery': the
> class or interface 'PhutilClassMapQuery' is not defined in the library
> map for any loaded phutil library. If this symbol was recently added
> or moved, your library map may be out of date. You can rebuild the map
> by running 'arc liberate'. For more information, see:
> http://www.phabricator.com/docs/phabricator/article/libphutil_Libraries_User_Guide.html
> (Run with `--trace` for a full exception trace.)
>
> 4.arc liberate
>
> Exception Failed to load class or interface 'PhutilClassMapQuery': the
> class or interface 'PhutilClassMapQuery' is not defined in the library
> map for any loaded phutil library. If this symbol was recently added
> or moved, your library map may be out of date. You can rebuild the map
> by running 'arc liberate'. For more information, see:
> http://www.phabricator.com/docs/phabricator/article/libphutil_Libraries_User_Guide.html
> (Run with `--trace` for a full exception trace.)
>
>
> Any advice on what I am doing wrong?
>
> -Iavor
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> On Wed, Oct 28, 2015 at 10:17 AM, Iavor Diatchki
>  wrote:
>> I have also written my thoughts on the questions posed by Richard on
>> the wiki page.
>>
>>
>>
>>
>> On Wed, Oct 28, 2015 at 7:07 AM, Richard Eisenberg
>>  wrote:
>>>
>>>
On Oct 28, 2015, at 10:02 AM, "Augustsson, Lennart"  
wrote:
>>>
>>>
> I've put in my answers to your questions.
>>>
>>> And I've responded.
> _
> ghc-devs mailing list ghc-devs@haskell.org
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


Re: Type-level error messages

2015-10-29 Thread Iavor Diatchki
Hello,

I've updated the implementation to match the discussion from this morning.
The idea is that `TypeError msd` is a type-family that can never be
reduced, similar to `Any`.  We don't do anything special in the constraint
solver, however when printing errors, if we encounter any constraints of
the form:
  * TypeError msg
  * TypeError msg ~ Something
  * Something ~ TypeError msg

Then we evaluate `msg` and use it as the error message.

This is fairly simple, and appears to work quite well.  The implementation
is on branch `wip/custom-type-errors`  (
https://github.com/ghc/ghc/tree/wip/custom-type-errors).


== Arc Difficulties Below ===

I tried to update the Phabricator patch but failed.  This is what I did:

1. arc diff master --update D1236 --head custom-type-errors

Exception
ERR-CONDUIT-CALL: API Method "differential.creatediff" does not define
these parameters: 'arcanistProject'.
(Run with `--trace` for a full exception trace.)

2. I thought that maybe I need to update `arcanist`, so I pulled the latest
version for git.

3. arc diff master --update D1236 --head custom-type-errors

Exception
Failed to load class or interface 'PhutilClassMapQuery': the class or
interface 'PhutilClassMapQuery' is not defined in the library map for any
loaded phutil library. If this symbol was recently added or moved, your
library map may be out of date. You can rebuild the map by running 'arc
liberate'. For more information, see:
http://www.phabricator.com/docs/phabricator/article/libphutil_Libraries_User_Guide.html
(Run with `--trace` for a full exception trace.)

4. arc liberate

Exception
Failed to load class or interface 'PhutilClassMapQuery': the class or
interface 'PhutilClassMapQuery' is not defined in the library map for any
loaded phutil library. If this symbol was recently added or moved, your
library map may be out of date. You can rebuild the map by running 'arc
liberate'. For more information, see:
http://www.phabricator.com/docs/phabricator/article/libphutil_Libraries_User_Guide.html
(Run with `--trace` for a full exception trace.)


Any advice on what I am doing wrong?

-Iavor




















On Wed, Oct 28, 2015 at 10:17 AM, Iavor Diatchki 
wrote:

> I have also written my thoughts on the questions posed by Richard on the
> wiki page.
>
>
>
>
> On Wed, Oct 28, 2015 at 7:07 AM, Richard Eisenberg 
> wrote:
>
>>
>> On Oct 28, 2015, at 10:02 AM, "Augustsson, Lennart" <
>> lennart.augusts...@sc.com> wrote:
>>
>> > I've put in my answers to your questions.
>>
>> And I've responded.
>
>
>
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


Re: Type-level error messages

2015-10-28 Thread Iavor Diatchki
I have also written my thoughts on the questions posed by Richard on the
wiki page.




On Wed, Oct 28, 2015 at 7:07 AM, Richard Eisenberg 
wrote:

>
> On Oct 28, 2015, at 10:02 AM, "Augustsson, Lennart" <
> lennart.augusts...@sc.com> wrote:
>
> > I've put in my answers to your questions.
>
> And I've responded.
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


Re: Type-level error messages

2015-10-28 Thread Richard Eisenberg

On Oct 28, 2015, at 10:02 AM, "Augustsson, Lennart"  
wrote:

> I've put in my answers to your questions.

And I've responded.
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


Re: Type-level error messages

2015-10-28 Thread Richard Eisenberg

On Oct 28, 2015, at 7:39 AM, Ben Gamari  wrote:

> It does look pretty reasonable but keep in mind that there are a number
> of comments on the Phabricator Diff that still need to be addressed.

And I have three burning questions at the bottom of the wiki page 
https://ghc.haskell.org/trac/ghc/wiki/Proposal/CustomTypeErrors. The first, in 
particular, needs to be addressed to make this feature useful.

Richard
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


Re: Type-level error messages

2015-10-28 Thread Ben Gamari
Iavor Diatchki  writes:

>> I think that the branch should be in an OK state, except that it is not
>> merged with the latest HEAD.
>
It does look pretty reasonable but keep in mind that there are a number
of comments on the Phabricator Diff that still need to be addressed.

Thanks!

- Ben



signature.asc
Description: PGP signature
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


RE: Type-level error messages

2015-10-27 Thread Simon Peyton Jones
It would be great to document some of these common workflows.

Simon

| -Original Message-
| From: ghc-devs [mailto:ghc-devs-boun...@haskell.org] On Behalf Of Matthew
| Pickering
| Sent: 27 October 2015 21:10
| To: Iavor Diatchki
| Cc: ghc-devs@haskell.org
| Subject: Re: Type-level error messages
| 
| Hi Iavor,
| 
| You can update your diff by using "arc diff --update D1236"
| 
| Matt
| 
| On Tue, Oct 27, 2015 at 8:48 PM, Iavor Diatchki
|  wrote:
| > Hi Ben,
| >
| > I updated the wiki page for GHC 8.0.1 to add an entry for the custom type
| > errors (under "in flight, but likely to make it").  It shouldn't be a
| > problem to make all changes needed by the end of November.
| >
| > Ther phabricator link is this:
| > https://phabricator.haskell.org/D1236
| >
| > The ticket is here:
| > https://ghc.haskell.org/trac/ghc/ticket/9637
| >
| >
| > Disclaimer: I don't really understand the phabricator work-flow, I just
| > blindly followed the instructions on the wiki to create this, but I don't
| > really know how to update it or make changes to it.  I'd be happy to push a
| > standard git branch, if that would be useful for you.  It certainly would
| be
| > easier for me, as I have a good mental model of what git does, but have
| only
| > very rudimentary understanding of phabricator.
| >
| > -Iavor
| >
| >
| >
| >
| >
| > On Tue, Oct 27, 2015 at 11:27 AM, Ben Gamari  wrote:
| >>
| >> Iavor Diatchki  writes:
| >>
| >> > Hello,
| >> >
| >> Hello!
| >>
| >> Very good timing on the message; we just finished discussing your work
| >> not more than an hour ago. You can disregard my message; I didn't notice
| >> yours before sending it.
| >>
| >> > On Thu, Oct 22, 2015 at 9:47 AM, Simon Peyton Jones
| >> > 
| >> > wrote:
| >> >
| >> >> I’ve forgotten the state of your type-level error messages work.  How’s
| >> >> it
| >> >> going?
| >> >>
| >> >> I think we should try to add it to 8.0.1.  The current status is that
| >> >> the
| >> >> idea is implemented on a branch.  Then, there were some comments and
| >> >> suggestions that maybe we should do things in a different way,
| >> >> implementation wise.  I haven't had a chance to look into these in
| >> >> detail,
| >> >> or implement them, and as far as I know nobody else has stepped up to
| >> >> make
| >> >> the changes.  So we could simply go with the current version, and if
| >> >> for
| >> >> some reason we want to change the implementation we could do it later,
| >> >> as I
| >> >> don't think the API will be affected in any way.When do the changes
| >> >> need to happen by, so that it makes it in 8.0?   I have been a bit
| >> >> busy,
| >> >> but I could probably find some time to make whatever changes are
| >> >> required
| >> >> for this to be merged.
| >> >>
| >> >> OK good!  In that case
| >> >>
| >> >> · Add it to the hoped-for features in the GHC 8.01. status page
| >> >>
| >> > Where is the GHC 8.01 status page?
| >> >
| >> Here,
| >>
| >> https://ghc.haskell.org/trac/ghc/wiki/Status/GHC-8.0.1
| >>
| >> > · Write a wiki page with a specification
| >> >>
| >> >> Here is the specification:
| >> > https://ghc.haskell.org/trac/ghc/wiki/CustomTypeErros
| >> >
| >> Great! I have moved this to,
| >>
| >> https://ghc.haskell.org/trac/ghc/wiki/Proposal/CustomTypeErrors
| >>
| >> and left a redirect page in the old location.
| >>
| >> Is there a Trac ticket for this?
| >>
| >> >
| >> >> · Announce the proposal and seek feedback
| >> >>
| >> > We already had a discussion about it, there are notes on the wiki.  I
| >> > don't
| >> > think any of the comments were about the actual design, the comments
| >> > seem
| >> > to be more about the implementation.  On that front, if I am to make the
| >> > necessary changes, maybe we could have a chat (or e-mail conversation)
| >> > to
| >> > make sure that I understand the changes and the motivation for
| >> > them---the
| >> > wiki is not a great media for question/answer type of discussions.
| >> >
| >> I'll let you and Simon work this out.
| >>
| >> >> · Meanwhile make sure the branch reflects what you want to be
| &

Re: Type-level error messages

2015-10-27 Thread Matthew Pickering
Hi Iavor,

You can update your diff by using "arc diff --update D1236"

Matt

On Tue, Oct 27, 2015 at 8:48 PM, Iavor Diatchki
 wrote:
> Hi Ben,
>
> I updated the wiki page for GHC 8.0.1 to add an entry for the custom type
> errors (under "in flight, but likely to make it").  It shouldn't be a
> problem to make all changes needed by the end of November.
>
> Ther phabricator link is this:
> https://phabricator.haskell.org/D1236
>
> The ticket is here:
> https://ghc.haskell.org/trac/ghc/ticket/9637
>
>
> Disclaimer: I don't really understand the phabricator work-flow, I just
> blindly followed the instructions on the wiki to create this, but I don't
> really know how to update it or make changes to it.  I'd be happy to push a
> standard git branch, if that would be useful for you.  It certainly would be
> easier for me, as I have a good mental model of what git does, but have only
> very rudimentary understanding of phabricator.
>
> -Iavor
>
>
>
>
>
> On Tue, Oct 27, 2015 at 11:27 AM, Ben Gamari  wrote:
>>
>> Iavor Diatchki  writes:
>>
>> > Hello,
>> >
>> Hello!
>>
>> Very good timing on the message; we just finished discussing your work
>> not more than an hour ago. You can disregard my message; I didn't notice
>> yours before sending it.
>>
>> > On Thu, Oct 22, 2015 at 9:47 AM, Simon Peyton Jones
>> > 
>> > wrote:
>> >
>> >> I’ve forgotten the state of your type-level error messages work.  How’s
>> >> it
>> >> going?
>> >>
>> >> I think we should try to add it to 8.0.1.  The current status is that
>> >> the
>> >> idea is implemented on a branch.  Then, there were some comments and
>> >> suggestions that maybe we should do things in a different way,
>> >> implementation wise.  I haven't had a chance to look into these in
>> >> detail,
>> >> or implement them, and as far as I know nobody else has stepped up to
>> >> make
>> >> the changes.  So we could simply go with the current version, and if
>> >> for
>> >> some reason we want to change the implementation we could do it later,
>> >> as I
>> >> don't think the API will be affected in any way.When do the changes
>> >> need to happen by, so that it makes it in 8.0?   I have been a bit
>> >> busy,
>> >> but I could probably find some time to make whatever changes are
>> >> required
>> >> for this to be merged.
>> >>
>> >> OK good!  In that case
>> >>
>> >> · Add it to the hoped-for features in the GHC 8.01. status page
>> >>
>> > Where is the GHC 8.01 status page?
>> >
>> Here,
>>
>> https://ghc.haskell.org/trac/ghc/wiki/Status/GHC-8.0.1
>>
>> > · Write a wiki page with a specification
>> >>
>> >> Here is the specification:
>> > https://ghc.haskell.org/trac/ghc/wiki/CustomTypeErros
>> >
>> Great! I have moved this to,
>>
>> https://ghc.haskell.org/trac/ghc/wiki/Proposal/CustomTypeErrors
>>
>> and left a redirect page in the old location.
>>
>> Is there a Trac ticket for this?
>>
>> >
>> >> · Announce the proposal and seek feedback
>> >>
>> > We already had a discussion about it, there are notes on the wiki.  I
>> > don't
>> > think any of the comments were about the actual design, the comments
>> > seem
>> > to be more about the implementation.  On that front, if I am to make the
>> > necessary changes, maybe we could have a chat (or e-mail conversation)
>> > to
>> > make sure that I understand the changes and the motivation for
>> > them---the
>> > wiki is not a great media for question/answer type of discussions.
>> >
>> I'll let you and Simon work this out.
>>
>> >> · Meanwhile make sure the branch reflects what you want to be
>> >> in
>> >> it
>> >>
>> >> I think that the branch should be in an OK state, except that it is not
>> > merged with the latest HEAD.
>> >
>> Where can this branch be found?
>>
>> Cheers,
>>
>> - Ben
>
>
>
> ___
> ghc-devs mailing list
> ghc-devs@haskell.org
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
>
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


Re: Type-level error messages

2015-10-27 Thread Iavor Diatchki
Hi Ben,

I updated the wiki page for GHC 8.0.1 to add an entry for the custom type
errors (under "in flight, but likely to make it").  It shouldn't be a
problem to make all changes needed by the end of November.

Ther phabricator link is this:
https://phabricator.haskell.org/D1236

The ticket is here:
https://ghc.haskell.org/trac/ghc/ticket/9637


Disclaimer: I don't really understand the phabricator work-flow, I just
 blindly followed the instructions on the wiki to create this, but I don't
really know how to update it or make changes to it.  I'd be happy to push a
standard git branch, if that would be useful for you.  It certainly would
be easier for me, as I have a good mental model of what git does, but have
only very rudimentary understanding of phabricator.

-Iavor





On Tue, Oct 27, 2015 at 11:27 AM, Ben Gamari  wrote:

> Iavor Diatchki  writes:
>
> > Hello,
> >
> Hello!
>
> Very good timing on the message; we just finished discussing your work
> not more than an hour ago. You can disregard my message; I didn't notice
> yours before sending it.
>
> > On Thu, Oct 22, 2015 at 9:47 AM, Simon Peyton Jones <
> simo...@microsoft.com>
> > wrote:
> >
> >> I’ve forgotten the state of your type-level error messages work.  How’s
> it
> >> going?
> >>
> >> I think we should try to add it to 8.0.1.  The current status is that
> the
> >> idea is implemented on a branch.  Then, there were some comments and
> >> suggestions that maybe we should do things in a different way,
> >> implementation wise.  I haven't had a chance to look into these in
> detail,
> >> or implement them, and as far as I know nobody else has stepped up to
> make
> >> the changes.  So we could simply go with the current version, and if for
> >> some reason we want to change the implementation we could do it later,
> as I
> >> don't think the API will be affected in any way.When do the changes
> >> need to happen by, so that it makes it in 8.0?   I have been a bit busy,
> >> but I could probably find some time to make whatever changes are
> required
> >> for this to be merged.
> >>
> >> OK good!  In that case
> >>
> >> · Add it to the hoped-for features in the GHC 8.01. status page
> >>
> > Where is the GHC 8.01 status page?
> >
> Here,
>
> https://ghc.haskell.org/trac/ghc/wiki/Status/GHC-8.0.1
>
> > · Write a wiki page with a specification
> >>
> >> Here is the specification:
> > https://ghc.haskell.org/trac/ghc/wiki/CustomTypeErros
> >
> Great! I have moved this to,
>
> https://ghc.haskell.org/trac/ghc/wiki/Proposal/CustomTypeErrors
>
> and left a redirect page in the old location.
>
> Is there a Trac ticket for this?
>
> >
> >> · Announce the proposal and seek feedback
> >>
> > We already had a discussion about it, there are notes on the wiki.  I
> don't
> > think any of the comments were about the actual design, the comments seem
> > to be more about the implementation.  On that front, if I am to make the
> > necessary changes, maybe we could have a chat (or e-mail conversation) to
> > make sure that I understand the changes and the motivation for them---the
> > wiki is not a great media for question/answer type of discussions.
> >
> I'll let you and Simon work this out.
>
> >> · Meanwhile make sure the branch reflects what you want to be in
> >> it
> >>
> >> I think that the branch should be in an OK state, except that it is not
> > merged with the latest HEAD.
> >
> Where can this branch be found?
>
> Cheers,
>
> - Ben
>
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


Re: Type-level error messages

2015-10-27 Thread Ben Gamari
Iavor Diatchki  writes:

> Hello,
>
Hello!

Very good timing on the message; we just finished discussing your work
not more than an hour ago. You can disregard my message; I didn't notice
yours before sending it.

> On Thu, Oct 22, 2015 at 9:47 AM, Simon Peyton Jones 
> wrote:
>
>> I’ve forgotten the state of your type-level error messages work.  How’s it
>> going?
>>
>> I think we should try to add it to 8.0.1.  The current status is that the
>> idea is implemented on a branch.  Then, there were some comments and
>> suggestions that maybe we should do things in a different way,
>> implementation wise.  I haven't had a chance to look into these in detail,
>> or implement them, and as far as I know nobody else has stepped up to make
>> the changes.  So we could simply go with the current version, and if for
>> some reason we want to change the implementation we could do it later, as I
>> don't think the API will be affected in any way.When do the changes
>> need to happen by, so that it makes it in 8.0?   I have been a bit busy,
>> but I could probably find some time to make whatever changes are required
>> for this to be merged.
>>
>> OK good!  In that case
>>
>> · Add it to the hoped-for features in the GHC 8.01. status page
>>
> Where is the GHC 8.01 status page?
>
Here,

https://ghc.haskell.org/trac/ghc/wiki/Status/GHC-8.0.1

> · Write a wiki page with a specification
>>
>> Here is the specification:
> https://ghc.haskell.org/trac/ghc/wiki/CustomTypeErros
>
Great! I have moved this to,

https://ghc.haskell.org/trac/ghc/wiki/Proposal/CustomTypeErrors

and left a redirect page in the old location.

Is there a Trac ticket for this?

>
>> · Announce the proposal and seek feedback
>>
> We already had a discussion about it, there are notes on the wiki.  I don't
> think any of the comments were about the actual design, the comments seem
> to be more about the implementation.  On that front, if I am to make the
> necessary changes, maybe we could have a chat (or e-mail conversation) to
> make sure that I understand the changes and the motivation for them---the
> wiki is not a great media for question/answer type of discussions.
>
I'll let you and Simon work this out.

>> · Meanwhile make sure the branch reflects what you want to be in
>> it
>>
>> I think that the branch should be in an OK state, except that it is not
> merged with the latest HEAD.
>
Where can this branch be found?

Cheers,

- Ben


signature.asc
Description: PGP signature
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


RE: Type-level error messages

2015-10-27 Thread Ben Gamari
Simon Peyton Jones  writes:

> I’ve forgotten the state of your type-level error messages work.  How’s it 
> going?
>
> Iavor Diatchki  writes:
> 
> > I think we should try to add it to 8.0.1. The current status is that
> > the idea is implemented on a branch. Then, there were some comments
> > and suggestions that maybe we should do things in a different way,
> > implementation wise. I haven't had a chance to look into these in
> > detail, or implement them, and as far as I know nobody else has
> > stepped up to make the changes. So we could simply go with the current
> > version, and if for some reason we want to change the implementation
> > we could do it later, as I don't think the API will be affected in any
> > way. When do the changes need to happen by, so that it makes it in
> > 8.0? I have been a bit busy, but I could probably find some time to
> > make whatever changes are required for this to be merged.
>
Hi Iavor,

Do you think you will be able to get to this for 8.0? To be viable for
8.0 you should plan on having a patch ready for merge by the last week
of November, which means the specification and such should be finished a
fair bit sooner.

Again, the outstanding tasks are,

 * Add it to the hoped-for features in the GHC 8.01. status page

 * Write a wiki page with a specification

 * Announce the proposal and seek feedback

 * Meanwhile make sure the branch reflects what you want to be in it

Cheers,

- Ben


signature.asc
Description: PGP signature
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


Re: Type-level error messages

2015-10-27 Thread Iavor Diatchki
Hello,

On Thu, Oct 22, 2015 at 9:47 AM, Simon Peyton Jones 
wrote:

> I’ve forgotten the state of your type-level error messages work.  How’s it
> going?
>
> I think we should try to add it to 8.0.1.  The current status is that the
> idea is implemented on a branch.  Then, there were some comments and
> suggestions that maybe we should do things in a different way,
> implementation wise.  I haven't had a chance to look into these in detail,
> or implement them, and as far as I know nobody else has stepped up to make
> the changes.  So we could simply go with the current version, and if for
> some reason we want to change the implementation we could do it later, as I
> don't think the API will be affected in any way.When do the changes
> need to happen by, so that it makes it in 8.0?   I have been a bit busy,
> but I could probably find some time to make whatever changes are required
> for this to be merged.
>
>
>



> OK good!  In that case
>
> · Add it to the hoped-for features in the GHC 8.01. status page
>
Where is the GHC 8.01 status page?

· Write a wiki page with a specification
>
> Here is the specification:
https://ghc.haskell.org/trac/ghc/wiki/CustomTypeErros


> · Announce the proposal and seek feedback
>
We already had a discussion about it, there are notes on the wiki.  I don't
think any of the comments were about the actual design, the comments seem
to be more about the implementation.  On that front, if I am to make the
necessary changes, maybe we could have a chat (or e-mail conversation) to
make sure that I understand the changes and the motivation for them---the
wiki is not a great media for question/answer type of discussions.


> · Meanwhile make sure the branch reflects what you want to be in
> it
>
> I think that the branch should be in an OK state, except that it is not
merged with the latest HEAD.


-Iavor







>
> If you don’t have time, well, no harm done… any progress you make on the
> above will still be useful.
>
>
>
> Simon
>
>
>
> *From:* Iavor Diatchki [mailto:iavor.diatc...@gmail.com]
> *Sent:* 22 October 2015 17:42
> *To:* Simon Peyton Jones
> *Cc:* Augustsson, Lennart
> *Subject:* Re: Type-level error messages
>
>
>
> Hello,
>
>
>
> I think we should try to add it to 8.0.1.  The current status is that the
> idea is implemented on a branch.  Then, there were some comments and
> suggestions that maybe we should do things in a different way,
> implementation wise.  I haven't had a chance to look into these in detail,
> or implement them, and as far as I know nobody else has stepped up to make
> the changes.  So we could simply go with the current version, and if for
> some reason we want to change the implementation we could do it later, as I
> don't think the API will be affected in any way.When do the changes
> need to happen by, so that it makes it in 8.0?   I have been a bit busy,
> but I could probably find some time to make whatever changes are required
> for this to be merged.
>
>
>
> -Iavor
>
>
>
>
>
>
>
>
>
>
>
>
>
> On Thu, Oct 22, 2015 at 3:47 AM, Simon Peyton Jones 
> wrote:
>
> Iavor
>
> I’ve forgotten the state of your type-level error messages work.  How’s it
> going?
>
> It’s not mentioned on
> https://ghc.haskell.org/trac/ghc/wiki/Status/GHC-8.0.1: shouldn’t it be?
>
> Simon
>
>
>
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


RE: Type-level error messages

2015-10-22 Thread Simon Peyton Jones
I’ve forgotten the state of your type-level error messages work.  How’s it 
going?
I think we should try to add it to 8.0.1.  The current status is that the idea 
is implemented on a branch.  Then, there were some comments and suggestions 
that maybe we should do things in a different way, implementation wise.  I 
haven't had a chance to look into these in detail, or implement them, and as 
far as I know nobody else has stepped up to make the changes.  So we could 
simply go with the current version, and if for some reason we want to change 
the implementation we could do it later, as I don't think the API will be 
affected in any way.When do the changes need to happen by, so that it makes 
it in 8.0?   I have been a bit busy, but I could probably find some time to 
make whatever changes are required for this to be merged.

OK good!  In that case

· Add it to the hoped-for features in the GHC 8.01. status page

· Write a wiki page with a specification

· Announce the proposal and seek feedback

· Meanwhile make sure the branch reflects what you want to be in it

If you don’t have time, well, no harm done… any progress you make on the above 
will still be useful.

Simon

From: Iavor Diatchki [mailto:iavor.diatc...@gmail.com]
Sent: 22 October 2015 17:42
To: Simon Peyton Jones
Cc: Augustsson, Lennart
Subject: Re: Type-level error messages

Hello,

I think we should try to add it to 8.0.1.  The current status is that the idea 
is implemented on a branch.  Then, there were some comments and suggestions 
that maybe we should do things in a different way, implementation wise.  I 
haven't had a chance to look into these in detail, or implement them, and as 
far as I know nobody else has stepped up to make the changes.  So we could 
simply go with the current version, and if for some reason we want to change 
the implementation we could do it later, as I don't think the API will be 
affected in any way.When do the changes need to happen by, so that it makes 
it in 8.0?   I have been a bit busy, but I could probably find some time to 
make whatever changes are required for this to be merged.

-Iavor






On Thu, Oct 22, 2015 at 3:47 AM, Simon Peyton Jones 
mailto:simo...@microsoft.com>> wrote:
Iavor
I’ve forgotten the state of your type-level error messages work.  How’s it 
going?
It’s not mentioned on https://ghc.haskell.org/trac/ghc/wiki/Status/GHC-8.0.1: 
shouldn’t it be?
Simon

___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs