Re: [PATCH] git svn fetch: Create correct commit timestamp when using --localtime
Junio C Hamanowrites: > > Yep, seems alright. Can you apply directly? > > Been a bit preoccupied as of late. Thanks. > > Surely, I'll just add your Reviewed-by: myself ;-) OK, thanks. This will fix the bug I've reported here a week or so ago (see the References header). urs
Re: [PATCH] git svn fetch: Create correct commit timestamp when using --localtime
Eric Wongwrites: > Junio C Hamano wrote: >> Urs Thuermann writes: >> >> > In parse_svn_date() prepend the correct UTC offset to the timestamp >> > returned. This is the offset in effect at the commit time instead of >> > the offset in effect at calling time. >> > >> > Signed-off-by: Urs Thuermann >> > --- >> > perl/Git/SVN.pm | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> >> Thanks; sounds sensible. >> >> Eric? > > Yep, seems alright. Can you apply directly? > Been a bit preoccupied as of late. Thanks. Surely, I'll just add your Reviewed-by: myself ;-) Thanks.
Re: [PATCH] git svn fetch: Create correct commit timestamp when using --localtime
Junio C Hamanowrote: > Urs Thuermann writes: > > > In parse_svn_date() prepend the correct UTC offset to the timestamp > > returned. This is the offset in effect at the commit time instead of > > the offset in effect at calling time. > > > > Signed-off-by: Urs Thuermann > > --- > > perl/Git/SVN.pm | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Thanks; sounds sensible. > > Eric? Yep, seems alright. Can you apply directly? Been a bit preoccupied as of late. Thanks.
Re: [PATCH] git svn fetch: Create correct commit timestamp when using --localtime
Urs Thuermannwrites: > In parse_svn_date() prepend the correct UTC offset to the timestamp > returned. This is the offset in effect at the commit time instead of > the offset in effect at calling time. > > Signed-off-by: Urs Thuermann > --- > perl/Git/SVN.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks; sounds sensible. Eric? > > diff --git a/perl/Git/SVN.pm b/perl/Git/SVN.pm > index 98518f4..bc4eed3 100644 > --- a/perl/Git/SVN.pm > +++ b/perl/Git/SVN.pm > @@ -1416,7 +1416,7 @@ sub parse_svn_date { > delete $ENV{TZ}; > } > > - my $our_TZ = get_tz_offset(); > + my $our_TZ = get_tz_offset($epoch_in_UTC); > > # This converts $epoch_in_UTC into our local timezone. > my ($sec, $min, $hour, $mday, $mon, $year,
[PATCH] git svn fetch: Create correct commit timestamp when using --localtime
In parse_svn_date() prepend the correct UTC offset to the timestamp returned. This is the offset in effect at the commit time instead of the offset in effect at calling time. Signed-off-by: Urs Thuermann--- perl/Git/SVN.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/perl/Git/SVN.pm b/perl/Git/SVN.pm index 98518f4..bc4eed3 100644 --- a/perl/Git/SVN.pm +++ b/perl/Git/SVN.pm @@ -1416,7 +1416,7 @@ sub parse_svn_date { delete $ENV{TZ}; } - my $our_TZ = get_tz_offset(); + my $our_TZ = get_tz_offset($epoch_in_UTC); # This converts $epoch_in_UTC into our local timezone. my ($sec, $min, $hour, $mday, $mon, $year, -- 2.1.4