Re: [PATCH 0/7] Modernize t9300-fast-import

[Jeff King]

On Thu, Nov 19, 2015 at 10:54:11PM -0500, Eric Sunshine wrote:

> On Thu, Nov 19, 2015 at 2:09 PM, Johannes Sixt  wrote:
> > Some time ago, I had to dig into t9300-fast-import and found it quite
> > unhelpful that it does not follow our modern best-practices. This series
> > brings it up-to-date. I thought I submit it now while it is quiet in
> > the area.
> >
> > The larger patches are best viewed using -w -color-words because the
> > regular patch text is ... overwhelming.
> 
> For what it's worth, I read through the series (with care, I hope) and
> didn't find anything amiss.

Thanks, both. I gave it a quick read and didn't see anything wrong. The
end result is certainly nicer to read. :)

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 0/7] Modernize t9300-fast-import

[Johannes Sixt]

Some time ago, I had to dig into t9300-fast-import and found it quite
unhelpful that it does not follow our modern best-practices. This series
brings it up-to-date. I thought I submit it now while it is quiet in
the area.

The larger patches are best viewed using -w -color-words because the
regular patch text is ... overwhelming.

Improving shell coding style is outside the scope of this series. I mean
fixing eyesores such as 'cat >foo < bar', or minor
things such as quoting <<\EOF when the here-doc does not require
substitutions.

In case the large patches don't make it to the list, the series is also
available from

  https://github.com/j6t/git.git modernize-t9300

Johannes Sixt (7):
  modernize t9300: single-quote placement and indentation
  modernize t9300: use test_must_fail
  modernize t9300: use test_must_be_empty
  modernize t9300: wrap lines after &&
  modernize t9300: use test_when_finished for clean-up
  modernize t9300: mark here-doc words to ignore tab indentation
  modernize t9300: move test preparations into test_expect_success

 t/t9300-fast-import.sh | 3629 
 1 file changed, 1822 insertions(+), 1807 deletions(-)

-- 
2.6.2.337.ga235d84

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/7] Modernize t9300-fast-import

[Eric Sunshine]

On Thu, Nov 19, 2015 at 2:09 PM, Johannes Sixt  wrote:
> Some time ago, I had to dig into t9300-fast-import and found it quite
> unhelpful that it does not follow our modern best-practices. This series
> brings it up-to-date. I thought I submit it now while it is quiet in
> the area.
>
> The larger patches are best viewed using -w -color-words because the
> regular patch text is ... overwhelming.

For what it's worth, I read through the series (with care, I hope) and
didn't find anything amiss.

> Improving shell coding style is outside the scope of this series. I mean
> fixing eyesores such as 'cat >foo < bar', or minor
> things such as quoting <<\EOF when the here-doc does not require
> substitutions.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html