Re: [Github-comments] [geany/geany] Filetype file editing overrides filetype changes with new versions of Geany (#1552)

2017-07-24 Thread elextr
@eliardocosta then make a specific issue, stop hijacking this one.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1552#issuecomment-317600651

Re: [Github-comments] [geany/geany] Filetype file editing overrides filetype changes with new versions of Geany (#1552)

2017-07-24 Thread Eliardo Costa
Thank you for your reply! I deleted the file but the problem continues :/

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1552#issuecomment-317594074

Re: [Github-comments] [geany/geany] Regression: No syntax highlighting for bash lists with one item (#1308)

2017-07-24 Thread elextr
Closed #1308 via #1503.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1308#event-1177068382

Re: [Github-comments] [geany/geany] Update Scintilla to version 3.7.5 (#1503)

2017-07-24 Thread elextr
Merged #1503.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1503#event-1177068375

Re: [Github-comments] [geany/geany] Update Scintilla to version 3.7.5 (#1503)

2017-07-24 Thread elextr
I have been using this without the bugfix no problems, though I don't use wrap 
and @b4n is happy and @kugel- is happy so merged.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1503#issuecomment-317583738

Re: [Github-comments] [geany/geany] Filetype file editing overrides filetype changes with new versions of Geany (#1552)

2017-07-24 Thread elextr
The edited `filetypes.common` is saved in your user config directory and 
overrides the system file.  Delete the one in the user config.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1552#issuecomment-317581486

Re: [Github-comments] [geany/geany] Filetype file editing overrides filetype changes with new versions of Geany (#1552)

2017-07-24 Thread Eliardo Costa
@elextr I was trying to set Julia in Geany in `Tools -> Configuration Files`, I 
open and save `filestypes.common` for accident and now I can't open Geany. Just 
try reinstall but with no success. When I try open Geany in terminal I see this:
```
Geany:ERROR:highlighting.c:861:styleset_from_mapping: assertion failed: (ft_id 
!= GEANY_FILETYPES_NONE)
```
Can someone help me fixing it? Thanks!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1552#issuecomment-317560473

Re: [Github-comments] [geany/geany] Add utils_get_real_path() and use it (#1224)

2017-07-24 Thread Thomas Martitz
What about this?

(On a related note, our `realpath()` implementation for win32, called by 
`tm_get_real_path()` is buggy, see #1534)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1224#issuecomment-317560311

Re: [Github-comments] [geany/geany] Handle continuous G_IO_IN-s without any data (#1461)

2017-07-24 Thread Thomas Martitz
@b4n What do you think? I'm not 100% convinced that we shouldn't go back to 
normal mode of operation, however I think the current state is acceptable and 
the bug is rather annoying when it occurs (BUT I have noticed the bug in this 
one scenario with the scope debugger plugin).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1461#issuecomment-317558556

Re: [Github-comments] [geany/geany] Update Scintilla to version 3.7.5 (#1503)

2017-07-24 Thread Thomas Martitz
I'm using scintilla-375 + the above bugfix without problems thus far.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1503#issuecomment-317556268

Re: [Github-comments] [geany/geany] Fixes & changes for #1470 (#1554)

2017-07-24 Thread Thomas Martitz
I wonder why I didn't see any warnings. I understand that my CFLAGS may not be 
pedantic enough for the unused variables, but I should have seen the 
uninitialized access one.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1554#issuecomment-317555741

Re: [Github-comments] [geany/geany] Snippets: Use ASCII ellipsis for the cursor placeholder (957b49b)

2017-07-24 Thread Thomas Martitz
I disagree that it looks better, I prefer one char. Unfortunately … is 
troublesome.
I then chose _ because it's also less likely to mess up the tagmanager due to 
syntax errors introduced by the ellipsis.

I don't feel very strong about it, though.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/commit/957b49b868214a4aea81641dedeabb98a497e4c1#commitcomment-23274521

Re: [Github-comments] [geany/geany] Fixes & changes for #1470 (#1554)

2017-07-24 Thread Thomas Martitz
kugel- commented on this pull request.



> @@ -2458,7 +2457,7 @@ void editor_insert_text_block(GeanyEditor *editor, 
> const gchar *text, gint inser
gint line_start = sci_get_line_from_position(sci, insert_pos);
GString *buf;
const gchar *eol = editor_get_eol_char(editor);
-   gint idx;
+   gint idx = 0;

Looking at it more closely, the issue is more serious, and your fix seems 
insufficient. I'll look into it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1554#discussion_r129151468

Re: [Github-comments] [geany/geany] Geany Locking up when typing or copying of text (#1540)

2017-07-24 Thread AdamDanischewski
It may seem daunting because of the amount of rows, but it shouldn't take very 
long since its a binary search the complexity is O(log n) at worst. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1540#issuecomment-317491704

Re: [Github-comments] [geany/geany] Add an editor option to enable IME's candidate window display inline (#1514)

2017-07-24 Thread elextr
@sinpowei well, somebody (other than you :) needs to test it, but not many 
Geany contributors use IME languages so most (all?) can't test it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1514#issuecomment-317369842

Re: [Github-comments] [geany/geany] Add an editor option to enable IME's candidate window display inline (#1514)

2017-07-24 Thread Sinpo Wei
@b4n I've already changed the code many days ago, how can this be merged into 
new release? 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1514#issuecomment-317367501

Re: [Github-comments] [geany/geany] Geany Locking up when typing or copying of text (#1540)

2017-07-24 Thread hdaz000700
Hi Adam, 

Yes I have started working on segmentation but with that technique its going to 
take some time before, I track down where the issue is and there could be more 
than one 

I'll update if and when I do fine the issues... :) 

Cheers
Daz

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1540#issuecomment-317350724