Re: [PATCH 1/2] CI: reduce ASAN log redirection umbrella size
on my experiments, asan log was grouped under "show vtest results". on provided branch indeed there are no grouping. I'll play a bit, maybe we'll end with dropping that log redirection ср, 17 апр. 2024 г. в 21:17, William Lallemand : > On Sun, Apr 14, 2024 at 09:23:51AM +0200, Ilya Shipitsin wrote: > > previously ASAN_OPTIONS=log_path=asan.log was intended for VTest > > execution only, it should not affect "haproxy -vv" and hsproxy > > config smoke testing > > --- > > .github/workflows/vtest.yml | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/.github/workflows/vtest.yml b/.github/workflows/vtest.yml > > index 9d0bf48b0..5ee8a7a64 100644 > > --- a/.github/workflows/vtest.yml > > +++ b/.github/workflows/vtest.yml > > @@ -42,8 +42,6 @@ jobs: > ># Configure a short TMPDIR to prevent failures due to long unix > socket > ># paths. > >TMPDIR: /tmp > > - # Force ASAN output into asan.log to make the output more > readable. > > - ASAN_OPTIONS: log_path=asan.log > >OT_CPP_VERSION: 1.6.0 > > steps: > > - uses: actions/checkout@v4 > > @@ -143,6 +141,9 @@ jobs: > >run: echo "::add-matcher::.github/vtest.json" > > - name: Run VTest for HAProxy ${{ > steps.show-version.outputs.version }} > >id: vtest > > + env: > > +# Force ASAN output into asan.log to make the output more > readable. > > +ASAN_OPTIONS: log_path=asan.log > >run: | > > # This is required for macOS which does not actually allow to > increase > > # the '-n' soft limit to the hard limit, thus failing to run. > > > Ilya, > > I still don't get how ASAN is working with the CI. Each time I have an > ASAN issue I can't get a trace out of github. > > For example, there was an issue with ASAN in this commit: > > https://github.com/haproxy/haproxy/commit/bdee8ace814139771efa90cc200c67e7d9b72751 > > I couldn't get a trace in the CI: > https://github.com/haproxy/haproxy/actions/runs/8724600484/job/23936238899 > > But I had no problem when testing it from my computer, I'm just doing a > ` make reg-tests reg-tests/ssl/crt_store.vtc -- --debug` and have the > ASAN output directly. > > Do you think we could achieve the same thing with github actions? I > never saw an output from this asan.log file in the CI. > > -- > William Lallemand >
Re: [PATCH 1/2] CI: reduce ASAN log redirection umbrella size
On Sun, Apr 14, 2024 at 09:23:51AM +0200, Ilya Shipitsin wrote: > previously ASAN_OPTIONS=log_path=asan.log was intended for VTest > execution only, it should not affect "haproxy -vv" and hsproxy > config smoke testing > --- > .github/workflows/vtest.yml | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/.github/workflows/vtest.yml b/.github/workflows/vtest.yml > index 9d0bf48b0..5ee8a7a64 100644 > --- a/.github/workflows/vtest.yml > +++ b/.github/workflows/vtest.yml > @@ -42,8 +42,6 @@ jobs: ># Configure a short TMPDIR to prevent failures due to long unix socket ># paths. >TMPDIR: /tmp > - # Force ASAN output into asan.log to make the output more readable. > - ASAN_OPTIONS: log_path=asan.log >OT_CPP_VERSION: 1.6.0 > steps: > - uses: actions/checkout@v4 > @@ -143,6 +141,9 @@ jobs: >run: echo "::add-matcher::.github/vtest.json" > - name: Run VTest for HAProxy ${{ steps.show-version.outputs.version }} >id: vtest > + env: > +# Force ASAN output into asan.log to make the output more readable. > +ASAN_OPTIONS: log_path=asan.log >run: | > # This is required for macOS which does not actually allow to > increase > # the '-n' soft limit to the hard limit, thus failing to run. Ilya, I still don't get how ASAN is working with the CI. Each time I have an ASAN issue I can't get a trace out of github. For example, there was an issue with ASAN in this commit: https://github.com/haproxy/haproxy/commit/bdee8ace814139771efa90cc200c67e7d9b72751 I couldn't get a trace in the CI: https://github.com/haproxy/haproxy/actions/runs/8724600484/job/23936238899 But I had no problem when testing it from my computer, I'm just doing a ` make reg-tests reg-tests/ssl/crt_store.vtc -- --debug` and have the ASAN output directly. Do you think we could achieve the same thing with github actions? I never saw an output from this asan.log file in the CI. -- William Lallemand
Re: [PATCH 0/2] CI cleanup, spell fixes
On Sun, Apr 14, 2024 at 09:23:50AM +0200, Ilya Shipitsin wrote: > the main part is reducing ASAN_OPTIONS scope, it was supposed > only to capture output of vtests, accidently it covered "config smoke tests" > as well (...) Both merged, thank you Ilya! willy