[jira] [Commented] (HDFS-15396) Fix TestViewFileSystemOverloadSchemeHdfsFileSystemContract#testListStatusRootDir
[ https://issues.apache.org/jira/browse/HDFS-15396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127782#comment-17127782 ] Ayush Saxena commented on HDFS-15396: - Thanx [~umamaheswararao] for the review. I am ok with whichever way you feel good > Fix > TestViewFileSystemOverloadSchemeHdfsFileSystemContract#testListStatusRootDir > > > Key: HDFS-15396 > URL: https://issues.apache.org/jira/browse/HDFS-15396 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Fix For: 3.4.0 > > > Exception : > {code:java} > java.lang.IllegalArgumentException: Can not create a Path from an empty string > at org.apache.hadoop.fs.Path.checkPathArg(Path.java:172) > at org.apache.hadoop.fs.Path.(Path.java:184) > at > org.apache.hadoop.fs.viewfs.ViewFileSystem$InternalDirOfViewFs.listStatus(ViewFileSystem.java:1207) > at > org.apache.hadoop.fs.viewfs.ViewFileSystem.listStatus(ViewFileSystem.java:514) > at > org.apache.hadoop.fs.FileSystemContractBaseTest.assertListStatusFinds(FileSystemContractBaseTest.java:867) > at > org.apache.hadoop.fs.viewfs.TestViewFileSystemOverloadSchemeHdfsFileSystemContract.testListStatusRootDir(TestViewFileSystemOverloadSchemeHdfsFileSystemContract.java:119) > {code} > The reason for failure being, the mount destination for /user and /append in > the test is just the URI, with no further path. > Thus while listing, in order to fetch the permissions, the destination URI is > used to get the path, which resolves being empty. Hence the failure -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-15396) Fix TestViewFileSystemOverloadSchemeHdfsFileSystemContract#testListStatusRootDir
[ https://issues.apache.org/jira/browse/HDFS-15396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127746#comment-17127746 ] Hudson commented on HDFS-15396: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #18336 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/18336/]) HDFS-15396. Fix (github: rev a8610c15c498531bf3c011f1b0ace8ef61f2) * (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java > Fix > TestViewFileSystemOverloadSchemeHdfsFileSystemContract#testListStatusRootDir > > > Key: HDFS-15396 > URL: https://issues.apache.org/jira/browse/HDFS-15396 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > > Exception : > {code:java} > java.lang.IllegalArgumentException: Can not create a Path from an empty string > at org.apache.hadoop.fs.Path.checkPathArg(Path.java:172) > at org.apache.hadoop.fs.Path.(Path.java:184) > at > org.apache.hadoop.fs.viewfs.ViewFileSystem$InternalDirOfViewFs.listStatus(ViewFileSystem.java:1207) > at > org.apache.hadoop.fs.viewfs.ViewFileSystem.listStatus(ViewFileSystem.java:514) > at > org.apache.hadoop.fs.FileSystemContractBaseTest.assertListStatusFinds(FileSystemContractBaseTest.java:867) > at > org.apache.hadoop.fs.viewfs.TestViewFileSystemOverloadSchemeHdfsFileSystemContract.testListStatusRootDir(TestViewFileSystemOverloadSchemeHdfsFileSystemContract.java:119) > {code} > The reason for failure being, the mount destination for /user and /append in > the test is just the URI, with no further path. > Thus while listing, in order to fetch the permissions, the destination URI is > used to get the path, which resolves being empty. Hence the failure -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-15396) Fix TestViewFileSystemOverloadSchemeHdfsFileSystemContract#testListStatusRootDir
[ https://issues.apache.org/jira/browse/HDFS-15396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127521#comment-17127521 ] Ayush Saxena commented on HDFS-15396: - Thanx [~umamaheswararao] have updated to resolve to "/" in case of empty path > Fix > TestViewFileSystemOverloadSchemeHdfsFileSystemContract#testListStatusRootDir > > > Key: HDFS-15396 > URL: https://issues.apache.org/jira/browse/HDFS-15396 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > > Exception : > {code:java} > java.lang.IllegalArgumentException: Can not create a Path from an empty string > at org.apache.hadoop.fs.Path.checkPathArg(Path.java:172) > at org.apache.hadoop.fs.Path.(Path.java:184) > at > org.apache.hadoop.fs.viewfs.ViewFileSystem$InternalDirOfViewFs.listStatus(ViewFileSystem.java:1207) > at > org.apache.hadoop.fs.viewfs.ViewFileSystem.listStatus(ViewFileSystem.java:514) > at > org.apache.hadoop.fs.FileSystemContractBaseTest.assertListStatusFinds(FileSystemContractBaseTest.java:867) > at > org.apache.hadoop.fs.viewfs.TestViewFileSystemOverloadSchemeHdfsFileSystemContract.testListStatusRootDir(TestViewFileSystemOverloadSchemeHdfsFileSystemContract.java:119) > {code} > The reason for failure being, the mount destination for /user and /append in > the test is just the URI, with no further path. > Thus while listing, in order to fetch the permissions, the destination URI is > used to get the path, which resolves being empty. Hence the failure -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-15396) Fix TestViewFileSystemOverloadSchemeHdfsFileSystemContract#testListStatusRootDir
[ https://issues.apache.org/jira/browse/HDFS-15396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127519#comment-17127519 ] Uma Maheswara Rao G commented on HDFS-15396: [~ayushtkn] Thanks you for reporting. Since that was in common, hdfs tests were not run in yetus report. While I was working on HADOOP-17060, I tried a fix for this. Instead of changing test, the most appropriate fix should be, adding "/" when path component is empty. With that change tests would pass. Feel free to take the code from [https://github.com/apache/hadoop/pull/2061] if you want. Appreciate your efforts and thanks for that. cc: [~Abhishek262] > Fix > TestViewFileSystemOverloadSchemeHdfsFileSystemContract#testListStatusRootDir > > > Key: HDFS-15396 > URL: https://issues.apache.org/jira/browse/HDFS-15396 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > > Exception : > {code:java} > java.lang.IllegalArgumentException: Can not create a Path from an empty string > at org.apache.hadoop.fs.Path.checkPathArg(Path.java:172) > at org.apache.hadoop.fs.Path.(Path.java:184) > at > org.apache.hadoop.fs.viewfs.ViewFileSystem$InternalDirOfViewFs.listStatus(ViewFileSystem.java:1207) > at > org.apache.hadoop.fs.viewfs.ViewFileSystem.listStatus(ViewFileSystem.java:514) > at > org.apache.hadoop.fs.FileSystemContractBaseTest.assertListStatusFinds(FileSystemContractBaseTest.java:867) > at > org.apache.hadoop.fs.viewfs.TestViewFileSystemOverloadSchemeHdfsFileSystemContract.testListStatusRootDir(TestViewFileSystemOverloadSchemeHdfsFileSystemContract.java:119) > {code} > The reason for failure being, the mount destination for /user and /append in > the test is just the URI, with no further path. > Thus while listing, in order to fetch the permissions, the destination URI is > used to get the path, which resolves being empty. Hence the failure -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-15396) Fix TestViewFileSystemOverloadSchemeHdfsFileSystemContract#testListStatusRootDir
[ https://issues.apache.org/jira/browse/HDFS-15396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127347#comment-17127347 ] Ayush Saxena commented on HDFS-15396: - Raised PR : https://github.com/apache/hadoop/pull/2059 As of now modified the test to change the mount entry. A possible alternative could be to be handle empty string in {{listStatus}} and resolve it to "/" or home directory but am not sure, doing that would be good... > Fix > TestViewFileSystemOverloadSchemeHdfsFileSystemContract#testListStatusRootDir > > > Key: HDFS-15396 > URL: https://issues.apache.org/jira/browse/HDFS-15396 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > > Exception : > {code:java} > java.lang.IllegalArgumentException: Can not create a Path from an empty string > at org.apache.hadoop.fs.Path.checkPathArg(Path.java:172) > at org.apache.hadoop.fs.Path.(Path.java:184) > at > org.apache.hadoop.fs.viewfs.ViewFileSystem$InternalDirOfViewFs.listStatus(ViewFileSystem.java:1207) > at > org.apache.hadoop.fs.viewfs.ViewFileSystem.listStatus(ViewFileSystem.java:514) > at > org.apache.hadoop.fs.FileSystemContractBaseTest.assertListStatusFinds(FileSystemContractBaseTest.java:867) > at > org.apache.hadoop.fs.viewfs.TestViewFileSystemOverloadSchemeHdfsFileSystemContract.testListStatusRootDir(TestViewFileSystemOverloadSchemeHdfsFileSystemContract.java:119) > {code} > The reason for failure being, the mount destination for /user and /append in > the test is just the URI, with no further path. > Thus while listing, in order to fetch the permissions, the destination URI is > used to get the path, which resolves being empty. Hence the failure -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org