[jira] [Commented] (HDFS-15538) Fix the documentation for dfs.namenode.replication.max-streams-hard-limit in hdfs-default.xml
[ https://issues.apache.org/jira/browse/HDFS-15538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230375#comment-17230375 ] Takanobu Asanuma commented on HDFS-15538: - [~risyomei] Thanks for updating the patch, and thanks for your message! +1 on [^HDFS-15538.002.patch], pending jenkins. > Fix the documentation for dfs.namenode.replication.max-streams-hard-limit in > hdfs-default.xml > - > > Key: HDFS-15538 > URL: https://issues.apache.org/jira/browse/HDFS-15538 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Xieming Li >Assignee: Xieming Li >Priority: Major > Labels: documentation > Attachments: HDFS-15538.001.patch, HDFS-15538.002.patch > > > The description of dfs.namenode.replication.max-streams-hard-limit in > hdfs-default.xml is misleading. > The maxReplicationStreams is not limiting the replication streams with the > highest priority. > [https://github.com/apache/hadoop/blob/branch-3.3.0/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java#L2463-L2471] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-15538) Fix the documentation for dfs.namenode.replication.max-streams-hard-limit in hdfs-default.xml
[ https://issues.apache.org/jira/browse/HDFS-15538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230359#comment-17230359 ] Xieming Li commented on HDFS-15538: --- [~tasanuma] I apologize for not updating this ticket for a long time as I didn't noticed it. and Congratulations on your promotion to PMC! I have updated the ticket base on your comment. > Fix the documentation for dfs.namenode.replication.max-streams-hard-limit in > hdfs-default.xml > - > > Key: HDFS-15538 > URL: https://issues.apache.org/jira/browse/HDFS-15538 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Xieming Li >Assignee: Xieming Li >Priority: Major > Labels: documentation > Attachments: HDFS-15538.001.patch > > > The description of dfs.namenode.replication.max-streams-hard-limit in > hdfs-default.xml is misleading. > The maxReplicationStreams is not limiting the replication streams with the > highest priority. > [https://github.com/apache/hadoop/blob/branch-3.3.0/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java#L2463-L2471] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-15538) Fix the documentation for dfs.namenode.replication.max-streams-hard-limit in hdfs-default.xml
[ https://issues.apache.org/jira/browse/HDFS-15538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182956#comment-17182956 ] Hadoop QA commented on HDFS-15538: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 30m 47s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m 0s{color} | {color:green} No case conflicting files found. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 20m 57s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 16s{color} | {color:green} trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 10s{color} | {color:green} trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 15s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 39m 59s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 49s{color} | {color:green} trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 23s{color} | {color:green} trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 10s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 11s{color} | {color:green} the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 11s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 3s{color} | {color:green} the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 9s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 15m 7s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 48s{color} | {color:green} the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 20s{color} | {color:green} the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}119m 30s{color} | {color:red} hadoop-hdfs in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 33s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}217m 16s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes | | | hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics | | | hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader | | | hadoop.hdfs.TestGetFileChecksum | | | hadoop.hdfs.server.balancer
[jira] [Commented] (HDFS-15538) Fix the documentation for dfs.namenode.replication.max-streams-hard-limit in hdfs-default.xml
[ https://issues.apache.org/jira/browse/HDFS-15538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182900#comment-17182900 ] Takanobu Asanuma commented on HDFS-15538: - Sorry, I cancel my last vote. [~risyomei] maxReplicationStreams is dfs.namenode.replication.max-streams. Could you fix the description of dfs.namenode.replication.max-streams? > Fix the documentation for dfs.namenode.replication.max-streams-hard-limit in > hdfs-default.xml > - > > Key: HDFS-15538 > URL: https://issues.apache.org/jira/browse/HDFS-15538 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Xieming Li >Assignee: Xieming Li >Priority: Major > Labels: documentation > Attachments: HDFS-15538.001.patch > > > The description of dfs.namenode.replication.max-streams-hard-limit in > hdfs-default.xml is misleading. > The maxReplicationStreams is not limiting the replication streams with the > highest priority. > [https://github.com/apache/hadoop/blob/branch-3.3.0/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java#L2463-L2471] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-15538) Fix the documentation for dfs.namenode.replication.max-streams-hard-limit in hdfs-default.xml
[ https://issues.apache.org/jira/browse/HDFS-15538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182896#comment-17182896 ] Takanobu Asanuma commented on HDFS-15538: - +1 on [^HDFS-15538.001.patch]. > Fix the documentation for dfs.namenode.replication.max-streams-hard-limit in > hdfs-default.xml > - > > Key: HDFS-15538 > URL: https://issues.apache.org/jira/browse/HDFS-15538 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Xieming Li >Assignee: Xieming Li >Priority: Major > Labels: documentation > Attachments: HDFS-15538.001.patch > > > The description of dfs.namenode.replication.max-streams-hard-limit in > hdfs-default.xml is misleading. > The maxReplicationStreams is not limiting the replication streams with the > highest priority. > [https://github.com/apache/hadoop/blob/branch-3.3.0/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java#L2463-L2471] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org