[jira] [Commented] (AMBARI-20125) DataNode Storage alert is duplicated
[ https://issues.apache.org/jira/browse/AMBARI-20125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879814#comment-15879814 ] Hudson commented on AMBARI-20125: - SUCCESS: Integrated in Jenkins build Ambari-branch-2.5 #1062 (See [https://builds.apache.org/job/Ambari-branch-2.5/1062/]) AMBARI-20125 - DataNode Storage alert is duplicated (rzang) (rzang: [http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=602e0a3e23a3a0cab0ac0dd27bda6374017b1d43]) * (edit) ambari-web/app/controllers/main/service/info/summary.js > DataNode Storage alert is duplicated > > > Key: AMBARI-20125 > URL: https://issues.apache.org/jira/browse/AMBARI-20125 > Project: Ambari > Issue Type: Bug > Components: ambari-web >Affects Versions: 2.5.0 >Reporter: Richard Zang >Assignee: Richard Zang >Priority: Critical > Fix For: 2.5.0 > > Attachments: AMBARI-20125.patch > > > In the HDFS alert popup, "DataNode Storage" item is duplicated. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (AMBARI-20125) DataNode Storage alert is duplicated
[ https://issues.apache.org/jira/browse/AMBARI-20125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879773#comment-15879773 ] Hudson commented on AMBARI-20125: - SUCCESS: Integrated in Jenkins build Ambari-trunk-Commit #6819 (See [https://builds.apache.org/job/Ambari-trunk-Commit/6819/]) AMBARI-20125 - DataNode Storage alert is duplicated (rzang) (rzang: [http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=f936bcfdb3cc6451bd1fa82e0d6e98f2aec285df]) * (edit) ambari-web/app/controllers/main/service/info/summary.js > DataNode Storage alert is duplicated > > > Key: AMBARI-20125 > URL: https://issues.apache.org/jira/browse/AMBARI-20125 > Project: Ambari > Issue Type: Bug > Components: ambari-web >Affects Versions: 2.5.0 >Reporter: Richard Zang >Assignee: Richard Zang >Priority: Critical > Fix For: 2.5.0 > > Attachments: AMBARI-20125.patch > > > In the HDFS alert popup, "DataNode Storage" item is duplicated. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (AMBARI-20125) DataNode Storage alert is duplicated
[ https://issues.apache.org/jira/browse/AMBARI-20125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879688#comment-15879688 ] Hadoop QA commented on AMBARI-20125: {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12854107/AMBARI-20125.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in ambari-web. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/10695//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/10695//console This message is automatically generated. > DataNode Storage alert is duplicated > > > Key: AMBARI-20125 > URL: https://issues.apache.org/jira/browse/AMBARI-20125 > Project: Ambari > Issue Type: Bug > Components: ambari-web >Affects Versions: 2.5.0 >Reporter: Richard Zang >Assignee: Richard Zang >Priority: Critical > Fix For: 2.5.0 > > Attachments: AMBARI-20125.patch > > > In the HDFS alert popup, "DataNode Storage" item is duplicated. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (AMBARI-20125) DataNode Storage alert is duplicated
[ https://issues.apache.org/jira/browse/AMBARI-20125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879624#comment-15879624 ] Richard Zang commented on AMBARI-20125: --- When we try to sort alert collection in the order of "critical, warning, ok, unknown, other", we made modification to original looping collection "serviceDefinitions" during the forEach loop. Also, alert definition with multiple alert instances distributed in different categories got pushed multiple times during the sort. This led to duplicated entries after processing. {code} var property = context.get('componentName') ? 'componentName' : 'serviceName'; var serviceDefinitions = this.get('controller.content').filterProperty(property, context.get(property)); // definitions should be sorted in order: critical, warning, ok, unknown, other var definitionTypes = { "isCritical": [], "isWarning": [], "isOK": [], "isUnknown": [] }; serviceDefinitions.forEach(function (definition) { Object.keys(definitionTypes).forEach(function (type) { if (definition.get(type)) { definition.set('isCollapsed', true); definitionTypes[type].push(definition); serviceDefinitions = serviceDefinitions.without(definition); } }); }); serviceDefinitions = definitionTypes.isCritical.concat(definitionTypes.isWarning, definitionTypes.isOK, definitionTypes.isUnknown, serviceDefinitions); return serviceDefinitions; {code} > DataNode Storage alert is duplicated > > > Key: AMBARI-20125 > URL: https://issues.apache.org/jira/browse/AMBARI-20125 > Project: Ambari > Issue Type: Bug > Components: ambari-web >Affects Versions: 2.5.0 >Reporter: Richard Zang >Assignee: Richard Zang >Priority: Critical > Fix For: 2.5.0 > > > In the HDFS alert popup, "DataNode Storage" item is duplicated. -- This message was sent by Atlassian JIRA (v6.3.15#6346)