[GitHub] carbondata issue #959: [CARBONDATA-1053] supported char Type for hive

[chenliang613]

Github user chenliang613 commented on the issue:

https://github.com/apache/carbondata/pull/959
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] carbondata pull request #960: Disable travis CI

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/960


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] carbondata issue #960: Disable travis CI

[chenliang613]

Github user chenliang613 commented on the issue:

https://github.com/apache/carbondata/pull/960
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] carbondata issue #959: [CARBONDATA-1053] supported char Type for hive

[chenliang613]

Github user chenliang613 commented on the issue:

https://github.com/apache/carbondata/pull/959
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] carbondata issue #959: [CARBONDATA-1053] supported char Type for hive

[chenliang613]

Github user chenliang613 commented on the issue:

https://github.com/apache/carbondata/pull/959
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] carbondata issue #960: Disable travis CI

[chenliang613]

Github user chenliang613 commented on the issue:

https://github.com/apache/carbondata/pull/960
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] carbondata issue #959: [CARBONDATA-1053] supported char Type for hive

[chenliang613]

Github user chenliang613 commented on the issue:

https://github.com/apache/carbondata/pull/959
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] carbondata issue #932: [CARBONDATA-1074] Add TablePage and ConvertedRow, pre...

[chenliang613]

Github user chenliang613 commented on the issue:

https://github.com/apache/carbondata/pull/932
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] carbondata issue #960: Disable travis CI

[chenliang613]

Github user chenliang613 commented on the issue:

https://github.com/apache/carbondata/pull/960
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] carbondata pull request #860: [CARBONDATA-917] Resolved Bug For Select Count...

[anubhav100]

Github user anubhav100 closed the pull request at:

https://github.com/apache/carbondata/pull/860


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] carbondata pull request #917: [CARBONDATA-1053] supported char type for hive

[anubhav100]

Github user anubhav100 closed the pull request at:

https://github.com/apache/carbondata/pull/917


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] carbondata pull request #933: [CARBONDATA-1075] Close Dictionary Server when...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/933


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] carbondata issue #933: [CARBONDATA-1075] Close Dictionary Server when applic...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/933
  
LGTM, but it can work only if user explicitly says context.stop() otherwise 
won't work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (CARBONDATA-1095) Fix rebase issues of presto and hive integration

[Liang Chen (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CARBONDATA-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Liang Chen resolved CARBONDATA-1095.

   Resolution: Fixed
Fix Version/s: 1.2.0

> Fix rebase issues of presto and hive integration
> 
>
> Key: CARBONDATA-1095
> URL: https://issues.apache.org/jira/browse/CARBONDATA-1095
> Project: CarbonData
>  Issue Type: Task
>  Components: hive-integration, presto-integration
>Reporter: Liang Chen
>Assignee: Liang Chen
> Fix For: 1.2.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> After rebasing presto and hive branch to master , there are some issues need 
> to be fixed, for example : the number of class parameters changed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] carbondata pull request #956: [CARBONDATA-1095] Fix issues after rebasing pr...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/956


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] carbondata pull request #957: [CARBONDATA-1090] added the integration test c...

[anubhav100]

Github user anubhav100 closed the pull request at:

https://github.com/apache/carbondata/pull/957


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] carbondata issue #957: [CARBONDATA-1090] added the integration test cases fo...

[anubhav100]

Github user anubhav100 commented on the issue:

https://github.com/apache/carbondata/pull/957
  
@chenliang613 sure closing it for today


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] carbondata issue #957: [CARBONDATA-1090] added the integration test cases fo...

[chenliang613]

Github user chenliang613 commented on the issue:

https://github.com/apache/carbondata/pull/957
  
@anubhav100  i am rebasing hive branch to master,  please raise this pr on 
tomorrow.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] carbondata pull request #955: [WIP] Inset Filter Pushdown in 2.1

[sounakr]

Github user sounakr closed the pull request at:

https://github.com/apache/carbondata/pull/955


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] carbondata pull request #957: [CARBONDATA-1090] added the integration test c...

[anubhav100]

GitHub user anubhav100 opened a pull request:

https://github.com/apache/carbondata/pull/957

[CARBONDATA-1090] added the integration test cases for hive integration



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anubhav100/incubator-carbondata 
CARBONDATA-1090

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/957.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #957


commit 30221692f26d5d53d3771c34186492f28493e4d8
Author: anubhav100 
Date:   2017-05-26T10:26:47Z

added theintegration test cases for hive integration




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (CARBONDATA-1097) describe formatted query should display no_inverted_index column

[Rahul Kumar (JIRA)]

Rahul Kumar created CARBONDATA-1097:
---

 Summary: describe formatted query should display no_inverted_index 
column
 Key: CARBONDATA-1097
 URL: https://issues.apache.org/jira/browse/CARBONDATA-1097
 Project: CarbonData
  Issue Type: Bug
Reporter: Rahul Kumar
Assignee: Rahul Kumar
Priority: Minor






--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] carbondata pull request #952: [CARBONDATA-1094] Wrong results returned by th...

[kumarvishal09]

Github user kumarvishal09 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/952#discussion_r118631844
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/ExcludeFilterExecuterImpl.java
 ---
@@ -43,6 +52,11 @@ public 
ExcludeFilterExecuterImpl(DimColumnResolvedFilterInfo dimColEvaluatorInfo
 this.segmentProperties = segmentProperties;
 
FilterUtil.prepareKeysFromSurrogates(dimColEvaluatorInfo.getFilterValues(), 
segmentProperties,
 dimColEvaluatorInfo.getDimension(), dimColumnExecuterInfo);
+// check if inverted index exists for the filter column
+isInvertedIndexColumn = CarbonUtil
+.hasEncoding(dimColEvaluatorInfo.getDimension().getEncoder(),
+Encoding.INVERTED_INDEX);
+isSortColumn = 
dimColEvaluatorInfo.getDimension().getColumnSchema().isSortColumn();
--- End diff --

Please correct me...Inverted Index and sort column are two different 
property. Sort column property is for dimension which is participating in 
global sort. If any column which is not present in sort column can be sorted 
vertically(column wise), so i think isSortedColumn is not required


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] carbondata pull request #952: [CARBONDATA-1094] Wrong results returned by th...

[kumarvishal09]

Github user kumarvishal09 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/952#discussion_r118667317
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RangeValueFilterExecuterImpl.java
 ---
@@ -474,80 +495,142 @@ private BitSet 
setFilterdIndexToBitSet(DimensionColumnDataChunk dimensionColumnD
   int numerOfRows) {
 BitSet bitSet = new BitSet(numerOfRows);
 // if (dimensionColumnDataChunk instanceof 
FixedLengthDimensionDataChunk) {
-int start = 0;
-int startMin = 0;
-int endMax = 0;
-int startIndex = 0;
 byte[][] filterValues = this.filterRangesValues;
-// For Range expression we expect two values. The First is the Min 
Value and Second is the
-// Max value.
-if (startBlockMinIsDefaultStart == false) {
-
-  start = CarbonUtil
-  .getFirstIndexUsingBinarySearch(dimensionColumnDataChunk,
-  startIndex, numerOfRows - 1, filterValues[0], 
greaterThanExp);
+if (dimensionColumnDataChunk.isExplicitSorted()) {
+  int start = 0;
+  int startMin = 0;
+  int endMax = 0;
+  int startIndex = 0;
+  // For Range expression we expect two values. The First is the Min 
Value and Second is the
+  // Max value.
+  if (startBlockMinIsDefaultStart == false) {
 
-  if (greaterThanExp == true && start >= 0) {
 start = CarbonUtil
-.nextGreaterValueToTarget(start, dimensionColumnDataChunk, 
filterValues[0],
-numerOfRows);
-  }
+.getFirstIndexUsingBinarySearch(dimensionColumnDataChunk, 
startIndex, numerOfRows - 1,
+filterValues[0], greaterThanExp);
 
-  if (start < 0) {
-start = -(start + 1);
-if (start == numerOfRows) {
-  start = start - 1;
+if (greaterThanExp == true && start >= 0) {
+  start = CarbonUtil
+  .nextGreaterValueToTarget(start, dimensionColumnDataChunk, 
filterValues[0],
+  numerOfRows);
 }
-// Method will compare the tentative index value after binary 
search, this tentative
-// index needs to be compared by the filter member if its >= 
filter then from that
-// index the bitset will be considered for filtering process.
-if ((ByteUtil.compare(filterValues[0], 
dimensionColumnDataChunk.getChunkData(start)))
-> 0) {
-  start = start + 1;
+
+if (start < 0) {
+  start = -(start + 1);
+  if (start == numerOfRows) {
+start = start - 1;
+  }
+  // Method will compare the tentative index value after binary 
search, this tentative
+  // index needs to be compared by the filter member if its >= 
filter then from that
+  // index the bitset will be considered for filtering process.
+  if ((ByteUtil.compare(filterValues[0], 
dimensionColumnDataChunk.getChunkData(start)))
+  > 0) {
+start = start + 1;
+  }
 }
+startMin = start;
+  } else {
+startMin = startIndex;
   }
-  startMin = start;
-} else {
-  startMin = startIndex;
-}
-
-if (endBlockMaxisDefaultEnd == false) {
-  start = CarbonUtil
-  .getFirstIndexUsingBinarySearch(dimensionColumnDataChunk, 
startIndex, numerOfRows - 1,
-  filterValues[1], lessThanEqualExp);
 
-  if (lessThanExp == true && start >= 0) {
-start =
-CarbonUtil.nextLesserValueToTarget(start, 
dimensionColumnDataChunk, filterValues[1]);
-  }
+  if (endBlockMaxisDefaultEnd == false) {
+start = CarbonUtil
+.getFirstIndexUsingBinarySearch(dimensionColumnDataChunk, 
startIndex, numerOfRows - 1,
+filterValues[1], lessThanEqualExp);
 
-  if (start < 0) {
-start = -(start + 1);
-if (start == numerOfRows) {
-  start = start - 1;
+if (lessThanExp == true && start >= 0) {
+  start =
+  CarbonUtil.nextLesserValueToTarget(start, 
dimensionColumnDataChunk, filterValues[1]);
 }
-// In case the start is less than 0, then positive value of start 
is pointing to the next
-// value of the searched key. So move to the previous one.
-if ((ByteUtil.compare(filterValues[1], 
dimensionColumnDataChunk.getChunkData(start))
-< 0)) {
-  start = start - 1;
+
+if (start < 0) {
+  start = -(start + 1);
+  if (start == numerOfRows) {
+start = start - 1;
+  }
  

[GitHub] carbondata pull request #952: [CARBONDATA-1094] Wrong results returned by th...

[kumarvishal09]

Github user kumarvishal09 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/952#discussion_r118667394
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RangeValueFilterExecuterImpl.java
 ---
@@ -474,80 +495,142 @@ private BitSet 
setFilterdIndexToBitSet(DimensionColumnDataChunk dimensionColumnD
   int numerOfRows) {
 BitSet bitSet = new BitSet(numerOfRows);
 // if (dimensionColumnDataChunk instanceof 
FixedLengthDimensionDataChunk) {
-int start = 0;
-int startMin = 0;
-int endMax = 0;
-int startIndex = 0;
 byte[][] filterValues = this.filterRangesValues;
-// For Range expression we expect two values. The First is the Min 
Value and Second is the
-// Max value.
-if (startBlockMinIsDefaultStart == false) {
-
-  start = CarbonUtil
-  .getFirstIndexUsingBinarySearch(dimensionColumnDataChunk,
-  startIndex, numerOfRows - 1, filterValues[0], 
greaterThanExp);
+if (dimensionColumnDataChunk.isExplicitSorted()) {
+  int start = 0;
+  int startMin = 0;
+  int endMax = 0;
+  int startIndex = 0;
+  // For Range expression we expect two values. The First is the Min 
Value and Second is the
+  // Max value.
+  if (startBlockMinIsDefaultStart == false) {
 
-  if (greaterThanExp == true && start >= 0) {
 start = CarbonUtil
-.nextGreaterValueToTarget(start, dimensionColumnDataChunk, 
filterValues[0],
-numerOfRows);
-  }
+.getFirstIndexUsingBinarySearch(dimensionColumnDataChunk, 
startIndex, numerOfRows - 1,
+filterValues[0], greaterThanExp);
 
-  if (start < 0) {
-start = -(start + 1);
-if (start == numerOfRows) {
-  start = start - 1;
+if (greaterThanExp == true && start >= 0) {
+  start = CarbonUtil
+  .nextGreaterValueToTarget(start, dimensionColumnDataChunk, 
filterValues[0],
+  numerOfRows);
 }
-// Method will compare the tentative index value after binary 
search, this tentative
-// index needs to be compared by the filter member if its >= 
filter then from that
-// index the bitset will be considered for filtering process.
-if ((ByteUtil.compare(filterValues[0], 
dimensionColumnDataChunk.getChunkData(start)))
-> 0) {
-  start = start + 1;
+
+if (start < 0) {
+  start = -(start + 1);
+  if (start == numerOfRows) {
+start = start - 1;
+  }
+  // Method will compare the tentative index value after binary 
search, this tentative
+  // index needs to be compared by the filter member if its >= 
filter then from that
+  // index the bitset will be considered for filtering process.
+  if ((ByteUtil.compare(filterValues[0], 
dimensionColumnDataChunk.getChunkData(start)))
+  > 0) {
+start = start + 1;
+  }
 }
+startMin = start;
+  } else {
+startMin = startIndex;
   }
-  startMin = start;
-} else {
-  startMin = startIndex;
-}
-
-if (endBlockMaxisDefaultEnd == false) {
-  start = CarbonUtil
-  .getFirstIndexUsingBinarySearch(dimensionColumnDataChunk, 
startIndex, numerOfRows - 1,
-  filterValues[1], lessThanEqualExp);
 
-  if (lessThanExp == true && start >= 0) {
-start =
-CarbonUtil.nextLesserValueToTarget(start, 
dimensionColumnDataChunk, filterValues[1]);
-  }
+  if (endBlockMaxisDefaultEnd == false) {
+start = CarbonUtil
+.getFirstIndexUsingBinarySearch(dimensionColumnDataChunk, 
startIndex, numerOfRows - 1,
+filterValues[1], lessThanEqualExp);
 
-  if (start < 0) {
-start = -(start + 1);
-if (start == numerOfRows) {
-  start = start - 1;
+if (lessThanExp == true && start >= 0) {
+  start =
+  CarbonUtil.nextLesserValueToTarget(start, 
dimensionColumnDataChunk, filterValues[1]);
 }
-// In case the start is less than 0, then positive value of start 
is pointing to the next
-// value of the searched key. So move to the previous one.
-if ((ByteUtil.compare(filterValues[1], 
dimensionColumnDataChunk.getChunkData(start))
-< 0)) {
-  start = start - 1;
+
+if (start < 0) {
+  start = -(start + 1);
+  if (start == numerOfRows) {
+start = start - 1;
+  }