[jira] [Commented] (HBASE-10893) Bug in Fast Diff Delta Block Encoding
[ https://issues.apache.org/jira/browse/HBASE-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963215#comment-13963215 ] Lars Hofhansl commented on HBASE-10893: --- Filed a sub task to keep this jira for the fix in the 0.89 branch. > Bug in Fast Diff Delta Block Encoding > - > > Key: HBASE-10893 > URL: https://issues.apache.org/jira/browse/HBASE-10893 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju > Fix For: 0.89-fb, 1.0.0 > > Attachments: HBASE-10893.patch > > > The following 2 key values if encoded and decoded, produce wrong results: > byte[] row = Bytes.toBytes("abcd"); > byte[] family = new byte[] { 'f' }; > byte[] qualifier0 = new byte[] { 'b' }; > byte[] qualifier1 = new byte[] { 'c' }; > byte[] value0 = new byte[] { 0x01 }; > byte[] value1 = new byte[] { 0x00 }; > kvList.add(new KeyValue(row, family, qualifier0, 0, Type.Put, value0)); > kvList.add(new KeyValue(row, family, qualifier1, 0, Type.Put, value1)); > while using Fast Diff Delta Block encoding. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10893) Bug in Fast Diff Delta Block Encoding
[ https://issues.apache.org/jira/browse/HBASE-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963116#comment-13963116 ] Lars Hofhansl commented on HBASE-10893: --- Sure. Will do in a bit :) > Bug in Fast Diff Delta Block Encoding > - > > Key: HBASE-10893 > URL: https://issues.apache.org/jira/browse/HBASE-10893 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju > Fix For: 0.89-fb, 1.0.0 > > Attachments: HBASE-10893.patch > > > The following 2 key values if encoded and decoded, produce wrong results: > byte[] row = Bytes.toBytes("abcd"); > byte[] family = new byte[] { 'f' }; > byte[] qualifier0 = new byte[] { 'b' }; > byte[] qualifier1 = new byte[] { 'c' }; > byte[] value0 = new byte[] { 0x01 }; > byte[] value1 = new byte[] { 0x00 }; > kvList.add(new KeyValue(row, family, qualifier0, 0, Type.Put, value0)); > kvList.add(new KeyValue(row, family, qualifier1, 0, Type.Put, value1)); > while using Fast Diff Delta Block encoding. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10893) Bug in Fast Diff Delta Block Encoding
[ https://issues.apache.org/jira/browse/HBASE-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963113#comment-13963113 ] Andrew Purtell commented on HBASE-10893: bq. I already ran the test in 0.94. Lemme include that a patch as well. Cool, if you put that up I'll carry it forward. Or since you've already done the work :-) I'd +1 a commit to 0.98 and trunk if you like. > Bug in Fast Diff Delta Block Encoding > - > > Key: HBASE-10893 > URL: https://issues.apache.org/jira/browse/HBASE-10893 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju > Fix For: 0.89-fb, 1.0.0 > > Attachments: HBASE-10893.patch > > > The following 2 key values if encoded and decoded, produce wrong results: > byte[] row = Bytes.toBytes("abcd"); > byte[] family = new byte[] { 'f' }; > byte[] qualifier0 = new byte[] { 'b' }; > byte[] qualifier1 = new byte[] { 'c' }; > byte[] value0 = new byte[] { 0x01 }; > byte[] value1 = new byte[] { 0x00 }; > kvList.add(new KeyValue(row, family, qualifier0, 0, Type.Put, value0)); > kvList.add(new KeyValue(row, family, qualifier1, 0, Type.Put, value1)); > while using Fast Diff Delta Block encoding. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10893) Bug in Fast Diff Delta Block Encoding
[ https://issues.apache.org/jira/browse/HBASE-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963104#comment-13963104 ] Lars Hofhansl commented on HBASE-10893: --- I already ran the test in 0.94. Lemme include that a patch as well. > Bug in Fast Diff Delta Block Encoding > - > > Key: HBASE-10893 > URL: https://issues.apache.org/jira/browse/HBASE-10893 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju > Fix For: 0.89-fb, 1.0.0 > > Attachments: HBASE-10893.patch > > > The following 2 key values if encoded and decoded, produce wrong results: > byte[] row = Bytes.toBytes("abcd"); > byte[] family = new byte[] { 'f' }; > byte[] qualifier0 = new byte[] { 'b' }; > byte[] qualifier1 = new byte[] { 'c' }; > byte[] value0 = new byte[] { 0x01 }; > byte[] value1 = new byte[] { 0x00 }; > kvList.add(new KeyValue(row, family, qualifier0, 0, Type.Put, value0)); > kvList.add(new KeyValue(row, family, qualifier1, 0, Type.Put, value1)); > while using Fast Diff Delta Block encoding. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10893) Bug in Fast Diff Delta Block Encoding
[ https://issues.apache.org/jira/browse/HBASE-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963097#comment-13963097 ] Andrew Purtell commented on HBASE-10893: Let me port the test to 0.96+ today. > Bug in Fast Diff Delta Block Encoding > - > > Key: HBASE-10893 > URL: https://issues.apache.org/jira/browse/HBASE-10893 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju > Fix For: 0.89-fb, 1.0.0 > > Attachments: HBASE-10893.patch > > > The following 2 key values if encoded and decoded, produce wrong results: > byte[] row = Bytes.toBytes("abcd"); > byte[] family = new byte[] { 'f' }; > byte[] qualifier0 = new byte[] { 'b' }; > byte[] qualifier1 = new byte[] { 'c' }; > byte[] value0 = new byte[] { 0x01 }; > byte[] value1 = new byte[] { 0x00 }; > kvList.add(new KeyValue(row, family, qualifier0, 0, Type.Put, value0)); > kvList.add(new KeyValue(row, family, qualifier1, 0, Type.Put, value1)); > while using Fast Diff Delta Block encoding. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10893) Bug in Fast Diff Delta Block Encoding
[ https://issues.apache.org/jira/browse/HBASE-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961186#comment-13961186 ] Andrew Purtell commented on HBASE-10893: Let's forward port the test. > Bug in Fast Diff Delta Block Encoding > - > > Key: HBASE-10893 > URL: https://issues.apache.org/jira/browse/HBASE-10893 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju > Fix For: 0.89-fb > > Attachments: HBASE-10893.patch > > > The following 2 key values if encoded and decoded, produce wrong results: > byte[] row = Bytes.toBytes("abcd"); > byte[] family = new byte[] { 'f' }; > byte[] qualifier0 = new byte[] { 'b' }; > byte[] qualifier1 = new byte[] { 'c' }; > byte[] value0 = new byte[] { 0x01 }; > byte[] value1 = new byte[] { 0x00 }; > kvList.add(new KeyValue(row, family, qualifier0, 0, Type.Put, value0)); > kvList.add(new KeyValue(row, family, qualifier1, 0, Type.Put, value1)); > while using Fast Diff Delta Block encoding. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10893) Bug in Fast Diff Delta Block Encoding
[ https://issues.apache.org/jira/browse/HBASE-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13957310#comment-13957310 ] Lars Hofhansl commented on HBASE-10893: --- The 0.94 code is quite a bit different, I tried the testZeroByte, and it passes fine there. > Bug in Fast Diff Delta Block Encoding > - > > Key: HBASE-10893 > URL: https://issues.apache.org/jira/browse/HBASE-10893 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju > Fix For: 0.89-fb > > Attachments: HBASE-10893.patch > > > The following 2 key values if encoded and decoded, produce wrong results: > byte[] row = Bytes.toBytes("abcd"); > byte[] family = new byte[] { 'f' }; > byte[] qualifier0 = new byte[] { 'b' }; > byte[] qualifier1 = new byte[] { 'c' }; > byte[] value0 = new byte[] { 0x01 }; > byte[] value1 = new byte[] { 0x00 }; > kvList.add(new KeyValue(row, family, qualifier0, 0, Type.Put, value0)); > kvList.add(new KeyValue(row, family, qualifier1, 0, Type.Put, value1)); > while using Fast Diff Delta Block encoding. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10893) Bug in Fast Diff Delta Block Encoding
[ https://issues.apache.org/jira/browse/HBASE-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13957194#comment-13957194 ] Liyin Tang commented on HBASE-10893: That's a quite serious bug and [~manukranthk] has already had a fix to this. > Bug in Fast Diff Delta Block Encoding > - > > Key: HBASE-10893 > URL: https://issues.apache.org/jira/browse/HBASE-10893 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju > Fix For: 0.89-fb > > > The following 2 key values if encoded and decoded, produce wrong results: > byte[] row = Bytes.toBytes("abcd"); > byte[] family = new byte[] { 'f' }; > byte[] qualifier0 = new byte[] { 'b' }; > byte[] qualifier1 = new byte[] { 'c' }; > byte[] value0 = new byte[] { 0x01 }; > byte[] value1 = new byte[] { 0x00 }; > kvList.add(new KeyValue(row, family, qualifier0, 0, Type.Put, value0)); > kvList.add(new KeyValue(row, family, qualifier1, 0, Type.Put, value1)); > while using Fast Diff Delta Block encoding. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10893) Bug in Fast Diff Delta Block Encoding
[ https://issues.apache.org/jira/browse/HBASE-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13957191#comment-13957191 ] Lars Hofhansl commented on HBASE-10893: --- What?! That's bad. Is that an issue in 0.94 and later as well? > Bug in Fast Diff Delta Block Encoding > - > > Key: HBASE-10893 > URL: https://issues.apache.org/jira/browse/HBASE-10893 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju > Fix For: 0.89-fb > > > The following 2 key values if encoded and decoded, produce wrong results: > byte[] row = Bytes.toBytes("abcd"); > byte[] family = new byte[] { 'f' }; > byte[] qualifier0 = new byte[] { 'b' }; > byte[] qualifier1 = new byte[] { 'c' }; > byte[] value0 = new byte[] { 0x01 }; > byte[] value1 = new byte[] { 0x00 }; > kvList.add(new KeyValue(row, family, qualifier0, 0, Type.Put, value0)); > kvList.add(new KeyValue(row, family, qualifier1, 0, Type.Put, value1)); > while using Fast Diff Delta Block encoding. -- This message was sent by Atlassian JIRA (v6.2#6252)