[jira] [Commented] (HBASE-9917) Fix it so Default Connection Pool does not spin up max threads even when not needed
[ https://issues.apache.org/jira/browse/HBASE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13821117#comment-13821117 ] Hudson commented on HBASE-9917: --- SUCCESS: Integrated in hbase-0.96-hadoop2 #118 (See [https://builds.apache.org/job/hbase-0.96-hadoop2/118/]) HBASE-9917 Fix it so Default Connection Pool does not spin up max threads even when not needed (stack: rev 1540946) * /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java > Fix it so Default Connection Pool does not spin up max threads even when not > needed > --- > > Key: HBASE-9917 > URL: https://issues.apache.org/jira/browse/HBASE-9917 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: stack >Assignee: stack > Fix For: 0.98.0, 0.96.1 > > Attachments: 9917.txt, pool.txt > > > Testing, I noticed that if we use the HConnection executor service as opposed > to the executor service that is created when you create an HTable without > passing in a connection: i.e > HConnectionManager.createConnection(config).getTable(tableName) > vs > HTable(config, tableName) > ... then we will spin up the max 256 threads and they will just hang out > though not being used. > We are encouraging HConnection#getTable over new HTable so worth fixing. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9917) Fix it so Default Connection Pool does not spin up max threads even when not needed
[ https://issues.apache.org/jira/browse/HBASE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820728#comment-13820728 ] Hudson commented on HBASE-9917: --- SUCCESS: Integrated in hbase-0.96 #187 (See [https://builds.apache.org/job/hbase-0.96/187/]) HBASE-9917 Fix it so Default Connection Pool does not spin up max threads even when not needed (stack: rev 1540946) * /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java > Fix it so Default Connection Pool does not spin up max threads even when not > needed > --- > > Key: HBASE-9917 > URL: https://issues.apache.org/jira/browse/HBASE-9917 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: stack >Assignee: stack > Fix For: 0.98.0, 0.96.1 > > Attachments: 9917.txt, pool.txt > > > Testing, I noticed that if we use the HConnection executor service as opposed > to the executor service that is created when you create an HTable without > passing in a connection: i.e > HConnectionManager.createConnection(config).getTable(tableName) > vs > HTable(config, tableName) > ... then we will spin up the max 256 threads and they will just hang out > though not being used. > We are encouraging HConnection#getTable over new HTable so worth fixing. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9917) Fix it so Default Connection Pool does not spin up max threads even when not needed
[ https://issues.apache.org/jira/browse/HBASE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820545#comment-13820545 ] Hudson commented on HBASE-9917: --- SUCCESS: Integrated in HBase-TRUNK #4678 (See [https://builds.apache.org/job/HBase-TRUNK/4678/]) HBASE-9917 Fix it so Default Connection Pool does not spin up max threads even when not needed (stack: rev 1540945) * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java > Fix it so Default Connection Pool does not spin up max threads even when not > needed > --- > > Key: HBASE-9917 > URL: https://issues.apache.org/jira/browse/HBASE-9917 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: stack >Assignee: stack > Fix For: 0.98.0, 0.96.1 > > Attachments: 9917.txt, pool.txt > > > Testing, I noticed that if we use the HConnection executor service as opposed > to the executor service that is created when you create an HTable without > passing in a connection: i.e > HConnectionManager.createConnection(config).getTable(tableName) > vs > HTable(config, tableName) > ... then we will spin up the max 256 threads and they will just hang out > though not being used. > We are encouraging HConnection#getTable over new HTable so worth fixing. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9917) Fix it so Default Connection Pool does not spin up max threads even when not needed
[ https://issues.apache.org/jira/browse/HBASE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820444#comment-13820444 ] Hudson commented on HBASE-9917: --- SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #835 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/835/]) HBASE-9917 Fix it so Default Connection Pool does not spin up max threads even when not needed (stack: rev 1540945) * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java > Fix it so Default Connection Pool does not spin up max threads even when not > needed > --- > > Key: HBASE-9917 > URL: https://issues.apache.org/jira/browse/HBASE-9917 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: stack >Assignee: stack > Fix For: 0.98.0, 0.96.1 > > Attachments: 9917.txt, pool.txt > > > Testing, I noticed that if we use the HConnection executor service as opposed > to the executor service that is created when you create an HTable without > passing in a connection: i.e > HConnectionManager.createConnection(config).getTable(tableName) > vs > HTable(config, tableName) > ... then we will spin up the max 256 threads and they will just hang out > though not being used. > We are encouraging HConnection#getTable over new HTable so worth fixing. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9917) Fix it so Default Connection Pool does not spin up max threads even when not needed
[ https://issues.apache.org/jira/browse/HBASE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817550#comment-13817550 ] Elliott Clark commented on HBASE-9917: -- +1 lgtm > Fix it so Default Connection Pool does not spin up max threads even when not > needed > --- > > Key: HBASE-9917 > URL: https://issues.apache.org/jira/browse/HBASE-9917 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: stack >Assignee: stack > Fix For: 0.98.0, 0.96.1 > > Attachments: 9917.txt, pool.txt > > > Testing, I noticed that if we use the HConnection executor service as opposed > to the executor service that is created when you create an HTable without > passing in a connection: i.e > HConnectionManager.createConnection(config).getTable(tableName) > vs > HTable(config, tableName) > ... then we will spin up the max 256 threads and they will just hang out > though not being used. > We are encouraging HConnection#getTable over new HTable so worth fixing. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9917) Fix it so Default Connection Pool does not spin up max threads even when not needed
[ https://issues.apache.org/jira/browse/HBASE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817517#comment-13817517 ] Nicolas Liochon commented on HBASE-9917: Skimmed through the patch, seems ok. +1. > Fix it so Default Connection Pool does not spin up max threads even when not > needed > --- > > Key: HBASE-9917 > URL: https://issues.apache.org/jira/browse/HBASE-9917 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: stack >Assignee: stack > Fix For: 0.98.0, 0.96.1 > > Attachments: 9917.txt, pool.txt > > > Testing, I noticed that if we use the HConnection executor service as opposed > to the executor service that is created when you create an HTable without > passing in a connection: i.e > HConnectionManager.createConnection(config).getTable(tableName) > vs > HTable(config, tableName) > ... then we will spin up the max 256 threads and they will just hang out > though not being used. > We are encouraging HConnection#getTable over new HTable so worth fixing. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9917) Fix it so Default Connection Pool does not spin up max threads even when not needed
[ https://issues.apache.org/jira/browse/HBASE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817396#comment-13817396 ] stack commented on HBASE-9917: -- Any chance of a review here? Previous we had hard-pegged 256 threads just sitting there idle. Now we have only threads that are doing work or those waiting around a while (keepalive 10 seonds) to see if more work about to come (else they die). > Fix it so Default Connection Pool does not spin up max threads even when not > needed > --- > > Key: HBASE-9917 > URL: https://issues.apache.org/jira/browse/HBASE-9917 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: stack >Assignee: stack > Fix For: 0.98.0, 0.96.1 > > Attachments: 9917.txt, pool.txt > > > Testing, I noticed that if we use the HConnection executor service as opposed > to the executor service that is created when you create an HTable without > passing in a connection: i.e > HConnectionManager.createConnection(config).getTable(tableName) > vs > HTable(config, tableName) > ... then we will spin up the max 256 threads and they will just hang out > though not being used. > We are encouraging HConnection#getTable over new HTable so worth fixing. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9917) Fix it so Default Connection Pool does not spin up max threads even when not needed
[ https://issues.apache.org/jira/browse/HBASE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817201#comment-13817201 ] Hadoop QA commented on HBASE-9917: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12612779/9917.txt against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop 1.0 profile. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1 warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:red}-1 site{color}. The patch appears to cause mvn site goal to fail. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7792//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7792//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7792//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7792//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7792//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7792//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7792//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7792//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7792//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7792//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7792//console This message is automatically generated. > Fix it so Default Connection Pool does not spin up max threads even when not > needed > --- > > Key: HBASE-9917 > URL: https://issues.apache.org/jira/browse/HBASE-9917 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: stack >Assignee: stack > Fix For: 0.98.0, 0.96.1 > > Attachments: 9917.txt, pool.txt > > > Testing, I noticed that if we use the HConnection executor service as opposed > to the executor service that is created when you create an HTable without > passing in a connection: i.e > HConnectionManager.createConnection(config).getTable(tableName) > vs > HTable(config, tableName) > ... then we will spin up the max 256 threads and they will just hang out > though not being used. > We are encouraging HConnection#getTable over new HTable so worth fixing. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9917) Fix it so Default Connection Pool does not spin up max threads even when not needed
[ https://issues.apache.org/jira/browse/HBASE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816965#comment-13816965 ] Hadoop QA commented on HBASE-9917: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12612744/pool.txt against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop 1.0 profile. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1 warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:red}-1 site{color}. The patch appears to cause mvn site goal to fail. {color:red}-1 core tests{color}. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7786//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7786//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7786//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7786//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7786//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7786//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7786//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7786//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7786//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7786//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7786//console This message is automatically generated. > Fix it so Default Connection Pool does not spin up max threads even when not > needed > --- > > Key: HBASE-9917 > URL: https://issues.apache.org/jira/browse/HBASE-9917 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: stack >Assignee: stack > Fix For: 0.98.0, 0.96.1 > > Attachments: pool.txt > > > Testing, I noticed that if we use the HConnection executor service as opposed > to the executor service that is created when you create an HTable without > passing in a connection: i.e > HConnectionManager.createConnection(config).getTable(tableName) > vs > HTable(config, tableName) > ... then we will spin up the max 256 threads and they will just hang out > though not being used. > We are encouraging HConnection#getTable over new HTable so worth fixing. -- This message was sent by Atlassian JIRA (v6.1#6144)