[jira] [Commented] (HBASE-12344) Split up TestAdmin
[ https://issues.apache.org/jira/browse/HBASE-12344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14199081#comment-14199081 ] Hudson commented on HBASE-12344: SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #625 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/625/]) HBASE-12344 Split up TestAdmin (apurtell: rev d1dd758430307ba367643872e9ad675eea229171) * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin2.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin1.java > Split up TestAdmin > -- > > Key: HBASE-12344 > URL: https://issues.apache.org/jira/browse/HBASE-12344 > Project: HBase > Issue Type: Task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 2.0.0, 0.98.8, 0.99.2 > > Attachments: HBASE-12344-0.98.patch, HBASE-12344-branch-1.patch, > HBASE-12344.patch > > > Running time for TestAdmin on a dev box is about 400 seconds before > HBASE-12142, 500 seconds after. Split it up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12344) Split up TestAdmin
[ https://issues.apache.org/jira/browse/HBASE-12344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14198951#comment-14198951 ] Hudson commented on HBASE-12344: FAILURE: Integrated in HBase-0.98 #656 (See [https://builds.apache.org/job/HBase-0.98/656/]) HBASE-12344 Split up TestAdmin (apurtell: rev d1dd758430307ba367643872e9ad675eea229171) * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin1.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin2.java > Split up TestAdmin > -- > > Key: HBASE-12344 > URL: https://issues.apache.org/jira/browse/HBASE-12344 > Project: HBase > Issue Type: Task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 2.0.0, 0.98.8, 0.99.2 > > Attachments: HBASE-12344-0.98.patch, HBASE-12344-branch-1.patch, > HBASE-12344.patch > > > Running time for TestAdmin on a dev box is about 400 seconds before > HBASE-12142, 500 seconds after. Split it up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12344) Split up TestAdmin
[ https://issues.apache.org/jira/browse/HBASE-12344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14198904#comment-14198904 ] Hudson commented on HBASE-12344: SUCCESS: Integrated in HBase-TRUNK #5746 (See [https://builds.apache.org/job/HBase-TRUNK/5746/]) HBASE-12344 Split up TestAdmin (apurtell: rev 48fd0369e5ed000cfb1f66b4d31d1ddfd308fd3a) * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin1.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin2.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java > Split up TestAdmin > -- > > Key: HBASE-12344 > URL: https://issues.apache.org/jira/browse/HBASE-12344 > Project: HBase > Issue Type: Task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 2.0.0, 0.98.8, 0.99.2 > > Attachments: HBASE-12344-0.98.patch, HBASE-12344-branch-1.patch, > HBASE-12344.patch > > > Running time for TestAdmin on a dev box is about 400 seconds before > HBASE-12142, 500 seconds after. Split it up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12344) Split up TestAdmin
[ https://issues.apache.org/jira/browse/HBASE-12344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14198891#comment-14198891 ] Hudson commented on HBASE-12344: FAILURE: Integrated in HBase-1.0 #433 (See [https://builds.apache.org/job/HBase-1.0/433/]) HBASE-12344 Split up TestAdmin (apurtell: rev 64fd02fcbdc7293d804bc005689e09805e0df2fb) * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin1.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin2.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java > Split up TestAdmin > -- > > Key: HBASE-12344 > URL: https://issues.apache.org/jira/browse/HBASE-12344 > Project: HBase > Issue Type: Task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 2.0.0, 0.98.8, 0.99.2 > > Attachments: HBASE-12344-0.98.patch, HBASE-12344-branch-1.patch, > HBASE-12344.patch > > > Running time for TestAdmin on a dev box is about 400 seconds before > HBASE-12142, 500 seconds after. Split it up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12344) Split up TestAdmin
[ https://issues.apache.org/jira/browse/HBASE-12344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14197652#comment-14197652 ] Talat UYARER commented on HBASE-12344: -- [~apurtell] Is there any explanation ? when splitted tests will be faster than now, we split all tests :D > Split up TestAdmin > -- > > Key: HBASE-12344 > URL: https://issues.apache.org/jira/browse/HBASE-12344 > Project: HBase > Issue Type: Task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 2.0.0, 0.98.8, 0.99.2 > > Attachments: HBASE-12344-0.98.patch, HBASE-12344-branch-1.patch, > HBASE-12344.patch > > > Running time for TestAdmin on a dev box is about 400 seconds before > HBASE-12142, 500 seconds after. Split it up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12344) Split up TestAdmin
[ https://issues.apache.org/jira/browse/HBASE-12344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14197463#comment-14197463 ] stack commented on HBASE-12344: --- +1 > Split up TestAdmin > -- > > Key: HBASE-12344 > URL: https://issues.apache.org/jira/browse/HBASE-12344 > Project: HBase > Issue Type: Task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 2.0.0, 0.98.8, 0.99.2 > > Attachments: HBASE-12344-0.98.patch, HBASE-12344-branch-1.patch, > HBASE-12344.patch > > > Running time for TestAdmin on a dev box is about 400 seconds before > HBASE-12142, 500 seconds after. Split it up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12344) Split up TestAdmin
[
https://issues.apache.org/jira/browse/HBASE-12344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14197422#comment-14197422
]
Hadoop QA commented on HBASE-12344:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12679409/HBASE-12344.patch
against trunk revision .
ATTACHMENT ID: 12679409
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+Map> server2Regions = new
HashMap>();
+HTableDescriptor htd = new
HTableDescriptor(TableName.valueOf("testDisableCatalogTable".getBytes()));
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11588//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11588//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11588//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11588//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11588//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11588//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11588//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11588//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11588//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11588//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11588//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11588//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11588//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11588//console
This message is automatically generated.
> Split up TestAdmin
> --
>
> Key: HBASE-12344
> URL: https://issues.apache.org/jira/browse/HBASE-12344
> Project: HBase
> Issue Type: Task
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
> Fix For: 2.0.0, 0.98.8, 0.99.2
>
> Attachments: HBASE-12344-0.98.patch, HBASE-12344-branch-1.patch,
> HBASE-12344.patch
>
>
> Running time for TestAdmin on a dev box is about 400 seconds before
> HBASE-12142, 500 seconds after. Split it up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12344) Split up TestAdmin
[ https://issues.apache.org/jira/browse/HBASE-12344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14197275#comment-14197275 ] Andrew Purtell commented on HBASE-12344: Running times on a dev box. 0.98 tested after commit of the HBASE-12219 addendum. *Before* ||test||branch||tests||running time (seconds)|| |TestAdmin|master|46|521.333| |TestAdmin|branch-1|46|551.264| |TestAdmin|0.98|47|457.811| *After* ||test||branch||tests||running time (seconds)|| |TestAdmin1|master|23|59.21| |TestAdmin2|master|23|58.724| |TestAdmin1|branch-1|23|57.578| |TestAdmin2|branch-1|23|59.635| |TestAdmin1|0.98|24|56.556| |TestAdmin2|0.98|23|60.226| I changed nothing beyond cloning TestAdmin into two separate files and removing half of the test cases from each. Really surprising how much running time has improved after splitting the unit. > Split up TestAdmin > -- > > Key: HBASE-12344 > URL: https://issues.apache.org/jira/browse/HBASE-12344 > Project: HBase > Issue Type: Task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 2.0.0, 0.98.8, 0.99.2 > > Attachments: HBASE-12344-0.98.patch, HBASE-12344-branch-1.patch > > > Running time for TestAdmin on a dev box is about 400 seconds before > HBASE-12142, 500 seconds after. Split it up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12344) Split up TestAdmin
[ https://issues.apache.org/jira/browse/HBASE-12344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14189809#comment-14189809 ] Talat UYARER commented on HBASE-12344: -- Hi [~apurtell] If you are not working on this, Could I assig myself ? > Split up TestAdmin > -- > > Key: HBASE-12344 > URL: https://issues.apache.org/jira/browse/HBASE-12344 > Project: HBase > Issue Type: Task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 2.0.0, 0.98.8, 0.99.2 > > > Running time for TestAdmin on a dev box is about 400 seconds before > HBASE-12142, 500 seconds after. Split it up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12344) Split up TestAdmin
[ https://issues.apache.org/jira/browse/HBASE-12344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183796#comment-14183796 ] Andrew Purtell commented on HBASE-12344: Running time above measured on 0.98 branch > Split up TestAdmin > -- > > Key: HBASE-12344 > URL: https://issues.apache.org/jira/browse/HBASE-12344 > Project: HBase > Issue Type: Task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 2.0.0, 0.98.8, 0.99.2 > > > Running time for TestAdmin on a dev box is about 400 seconds before > HBASE-12142, 500 seconds after. Split it up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
