[jira] [Commented] (HIVE-22122) TxnHandler.getValidWriteIdsForTable optimization for compacted tables
[ https://issues.apache.org/jira/browse/HIVE-22122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014385#comment-17014385 ] Denys Kuzmenko commented on HIVE-22122: --- Thank you [~pvary] for review! > TxnHandler.getValidWriteIdsForTable optimization for compacted tables > - > > Key: HIVE-22122 > URL: https://issues.apache.org/jira/browse/HIVE-22122 > Project: Hive > Issue Type: Bug > Components: Transactions >Reporter: Peter Vary >Assignee: Denys Kuzmenko >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22122.1.patch, HIVE-22122.2.patch > > Time Spent: 20m > Remaining Estimate: 0h > > When we do not find open writes for the given validTxnList then we either: > # do not have any writes on the table - we can return writeIdHwm = 0, and no > invalid/aborted writes; > # we have only compacted writes on the table - we can return writeIdHwm = > nextWriteId -1, and no invalid/aborted; > # we have compacted writes and some invalid writes on the table - we can > return the lowest invalid write as a writeIdHwm and set it as invalid. > What the current code does instead is sending writeIdHwm = nextWriteId -1, > and sending every write as invalid. This results the same response in case > 1-2, but probably a longer list in case 3. > So we have place for some optimizations -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22122) TxnHandler.getValidWriteIdsForTable optimization for compacted tables
[ https://issues.apache.org/jira/browse/HIVE-22122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993485#comment-16993485 ] Peter Vary commented on HIVE-22122: --- +1 > TxnHandler.getValidWriteIdsForTable optimization for compacted tables > - > > Key: HIVE-22122 > URL: https://issues.apache.org/jira/browse/HIVE-22122 > Project: Hive > Issue Type: Bug > Components: Transactions >Reporter: Peter Vary >Assignee: Denys Kuzmenko >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22122.1.patch, HIVE-22122.2.patch > > Time Spent: 20m > Remaining Estimate: 0h > > When we do not find open writes for the given validTxnList then we either: > # do not have any writes on the table - we can return writeIdHwm = 0, and no > invalid/aborted writes; > # we have only compacted writes on the table - we can return writeIdHwm = > nextWriteId -1, and no invalid/aborted; > # we have compacted writes and some invalid writes on the table - we can > return the lowest invalid write as a writeIdHwm and set it as invalid. > What the current code does instead is sending writeIdHwm = nextWriteId -1, > and sending every write as invalid. This results the same response in case > 1-2, but probably a longer list in case 3. > So we have place for some optimizations -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22122) TxnHandler.getValidWriteIdsForTable optimization for compacted tables
[ https://issues.apache.org/jira/browse/HIVE-22122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993408#comment-16993408 ] Denys Kuzmenko commented on HIVE-22122: --- [~pvary], could you please review. > TxnHandler.getValidWriteIdsForTable optimization for compacted tables > - > > Key: HIVE-22122 > URL: https://issues.apache.org/jira/browse/HIVE-22122 > Project: Hive > Issue Type: Bug > Components: Transactions >Reporter: Peter Vary >Assignee: Denys Kuzmenko >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22122.1.patch, HIVE-22122.2.patch > > Time Spent: 20m > Remaining Estimate: 0h > > When we do not find open writes for the given validTxnList then we either: > # do not have any writes on the table - we can return writeIdHwm = 0, and no > invalid/aborted writes; > # we have only compacted writes on the table - we can return writeIdHwm = > nextWriteId -1, and no invalid/aborted; > # we have compacted writes and some invalid writes on the table - we can > return the lowest invalid write as a writeIdHwm and set it as invalid. > What the current code does instead is sending writeIdHwm = nextWriteId -1, > and sending every write as invalid. This results the same response in case > 1-2, but probably a longer list in case 3. > So we have place for some optimizations -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22122) TxnHandler.getValidWriteIdsForTable optimization for compacted tables
[ https://issues.apache.org/jira/browse/HIVE-22122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16991116#comment-16991116 ] Hive QA commented on HIVE-22122: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12988271/HIVE-22122.2.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 17763 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/19825/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19825/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19825/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12988271 - PreCommit-HIVE-Build > TxnHandler.getValidWriteIdsForTable optimization for compacted tables > - > > Key: HIVE-22122 > URL: https://issues.apache.org/jira/browse/HIVE-22122 > Project: Hive > Issue Type: Bug > Components: Transactions >Reporter: Peter Vary >Assignee: Denys Kuzmenko >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22122.1.patch, HIVE-22122.2.patch > > Time Spent: 20m > Remaining Estimate: 0h > > When we do not find open writes for the given validTxnList then we either: > # do not have any writes on the table - we can return writeIdHwm = 0, and no > invalid/aborted writes; > # we have only compacted writes on the table - we can return writeIdHwm = > nextWriteId -1, and no invalid/aborted; > # we have compacted writes and some invalid writes on the table - we can > return the lowest invalid write as a writeIdHwm and set it as invalid. > What the current code does instead is sending writeIdHwm = nextWriteId -1, > and sending every write as invalid. This results the same response in case > 1-2, but probably a longer list in case 3. > So we have place for some optimizations -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22122) TxnHandler.getValidWriteIdsForTable optimization for compacted tables
[ https://issues.apache.org/jira/browse/HIVE-22122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16991092#comment-16991092 ] Hive QA commented on HIVE-22122: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 51s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 27s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 23s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 9s{color} | {color:blue} standalone-metastore/metastore-server in master has 179 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 28s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 28s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 14m 58s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19825/dev-support/hive-personality.sh | | git revision | master / a245e79 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | modules | C: standalone-metastore/metastore-server U: standalone-metastore/metastore-server | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-19825/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > TxnHandler.getValidWriteIdsForTable optimization for compacted tables > - > > Key: HIVE-22122 > URL: https://issues.apache.org/jira/browse/HIVE-22122 > Project: Hive > Issue Type: Bug > Components: Transactions >Reporter: Peter Vary >Assignee: Denys Kuzmenko >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22122.1.patch, HIVE-22122.2.patch > > Time Spent: 20m > Remaining Estimate: 0h > > When we do not find open writes for the given validTxnList then we either: > # do not have any writes on the table - we can return writeIdHwm = 0, and no > invalid/aborted writes; > # we have only compacted writes on the table - we can return writeIdHwm = > nextWriteId -1, and no invalid/aborted; > # we have compacted writes and some invalid writes on the table - we can > return the lowest invalid write as a writeIdHwm and set it as invalid. > What the current code does instead is sending writeIdHwm = nextWriteId -1, > and sending every write as invalid. This results the same response in case > 1-2, but probably a longer list in case 3. > So we have place for some optimizations -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22122) TxnHandler.getValidWriteIdsForTable optimization for compacted tables
[ https://issues.apache.org/jira/browse/HIVE-22122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990964#comment-16990964 ] Hive QA commented on HIVE-22122: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12987836/HIVE-22122.1.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17763 tests executed *Failed tests:* {noformat} org.apache.hive.jdbc.TestJdbcGenericUDTFGetSplits.testGenericUDTFOrderBySplitCount1 (batchId=284) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/19819/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19819/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19819/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12987836 - PreCommit-HIVE-Build > TxnHandler.getValidWriteIdsForTable optimization for compacted tables > - > > Key: HIVE-22122 > URL: https://issues.apache.org/jira/browse/HIVE-22122 > Project: Hive > Issue Type: Bug > Components: Transactions >Reporter: Peter Vary >Assignee: Denys Kuzmenko >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22122.1.patch > > Time Spent: 20m > Remaining Estimate: 0h > > When we do not find open writes for the given validTxnList then we either: > # do not have any writes on the table - we can return writeIdHwm = 0, and no > invalid/aborted writes; > # we have only compacted writes on the table - we can return writeIdHwm = > nextWriteId -1, and no invalid/aborted; > # we have compacted writes and some invalid writes on the table - we can > return the lowest invalid write as a writeIdHwm and set it as invalid. > What the current code does instead is sending writeIdHwm = nextWriteId -1, > and sending every write as invalid. This results the same response in case > 1-2, but probably a longer list in case 3. > So we have place for some optimizations -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22122) TxnHandler.getValidWriteIdsForTable optimization for compacted tables
[ https://issues.apache.org/jira/browse/HIVE-22122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990954#comment-16990954 ] Hive QA commented on HIVE-22122: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 46s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 27s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 23s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 15s{color} | {color:blue} standalone-metastore/metastore-server in master has 179 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 21s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 27s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 27s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 19s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 15m 1s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19819/dev-support/hive-personality.sh | | git revision | master / a245e79 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | modules | C: standalone-metastore/metastore-server U: standalone-metastore/metastore-server | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-19819/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > TxnHandler.getValidWriteIdsForTable optimization for compacted tables > - > > Key: HIVE-22122 > URL: https://issues.apache.org/jira/browse/HIVE-22122 > Project: Hive > Issue Type: Bug > Components: Transactions >Reporter: Peter Vary >Assignee: Denys Kuzmenko >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22122.1.patch > > Time Spent: 20m > Remaining Estimate: 0h > > When we do not find open writes for the given validTxnList then we either: > # do not have any writes on the table - we can return writeIdHwm = 0, and no > invalid/aborted writes; > # we have only compacted writes on the table - we can return writeIdHwm = > nextWriteId -1, and no invalid/aborted; > # we have compacted writes and some invalid writes on the table - we can > return the lowest invalid write as a writeIdHwm and set it as invalid. > What the current code does instead is sending writeIdHwm = nextWriteId -1, > and sending every write as invalid. This results the same response in case > 1-2, but probably a longer list in case 3. > So we have place for some optimizations -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22122) TxnHandler.getValidWriteIdsForTable optimization for compacted tables
[ https://issues.apache.org/jira/browse/HIVE-22122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908933#comment-16908933 ] Peter Vary commented on HIVE-22122: --- CC: [~sankarh] > TxnHandler.getValidWriteIdsForTable optimization for compacted tables > - > > Key: HIVE-22122 > URL: https://issues.apache.org/jira/browse/HIVE-22122 > Project: Hive > Issue Type: Bug > Components: Transactions >Reporter: Peter Vary >Priority: Major > > When we do not find open writes for the given validTxnList then we either: > # do not have any writes on the table - we can return writeIdHwm = 0, and no > invalid/aborted writes; > # we have only compacted writes on the table - we can return writeIdHwm = > nextWriteId -1, and no invalid/aborted; > # we have compacted writes and some invalid writes on the table - we can > return the lowest invalid write as a writeIdHwm and set it as invalid. > What the current code does instead is sending writeIdHwm = nextWriteId -1, > and sending every write as invalid. This results the same response in case > 1-2, but probably a longer list in case 3. > So we have place for some optimizations -- This message was sent by Atlassian JIRA (v7.6.14#76016)