[jira] [Commented] (HIVE-19500) Prevent multiple selectivity estimations for the same variable in conjuctions
[ https://issues.apache.org/jira/browse/HIVE-19500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490814#comment-16490814 ] Jesus Camacho Rodriguez commented on HIVE-19500: Cool, thanks [~kgyrtkirk] > Prevent multiple selectivity estimations for the same variable in conjuctions > - > > Key: HIVE-19500 > URL: https://issues.apache.org/jira/browse/HIVE-19500 > Project: Hive > Issue Type: Sub-task >Affects Versions: 3.0.0, 3.1.0 >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Fix For: 3.1.0, 4.0.0 > > Attachments: HIVE-19500.01.patch, HIVE-19500.02.patch, > HIVE-19500.03.patch, HIVE-19500.03.patch > > > see HIVE-19097 for problem description > for filters like: {{(d_year in (2001,2002) and d_year = 2001)}} the current > estimation is around {{(1/NDV)**2}} (iff column stats are available) > actually the source of the problem was a small typo in HIVE-17465 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19500) Prevent multiple selectivity estimations for the same variable in conjuctions
[ https://issues.apache.org/jira/browse/HIVE-19500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490572#comment-16490572 ] Hive QA commented on HIVE-19500: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12924790/HIVE-19500.03.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 14390 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/11202/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11202/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11202/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12924790 - PreCommit-HIVE-Build > Prevent multiple selectivity estimations for the same variable in conjuctions > - > > Key: HIVE-19500 > URL: https://issues.apache.org/jira/browse/HIVE-19500 > Project: Hive > Issue Type: Sub-task >Affects Versions: 3.0.0, 3.1.0 >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-19500.01.patch, HIVE-19500.02.patch, > HIVE-19500.03.patch, HIVE-19500.03.patch > > > see HIVE-19097 for problem description > for filters like: {{(d_year in (2001,2002) and d_year = 2001)}} the current > estimation is around {{(1/NDV)**2}} (iff column stats are available) > actually the source of the problem was a small typo in HIVE-17465 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19500) Prevent multiple selectivity estimations for the same variable in conjuctions
[ https://issues.apache.org/jira/browse/HIVE-19500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490530#comment-16490530 ] Hive QA commented on HIVE-19500: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 14s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 58s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 37s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 50s{color} | {color:blue} ql in master has 2323 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 55s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 37s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch 2 line(s) with tabs. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 13s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 57s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 12s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 22m 32s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-11202/dev-support/hive-personality.sh | | git revision | master / e84e89d | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-11202/yetus/whitespace-tabs.txt | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-11202/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Prevent multiple selectivity estimations for the same variable in conjuctions > - > > Key: HIVE-19500 > URL: https://issues.apache.org/jira/browse/HIVE-19500 > Project: Hive > Issue Type: Sub-task >Affects Versions: 3.0.0, 3.1.0 >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-19500.01.patch, HIVE-19500.02.patch, > HIVE-19500.03.patch, HIVE-19500.03.patch > > > see HIVE-19097 for problem description > for filters like: {{(d_year in (2001,2002) and d_year = 2001)}} the current > estimation is around {{(1/NDV)**2}} (iff column stats are available) > actually the source of the problem was a small typo in HIVE-17465 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19500) Prevent multiple selectivity estimations for the same variable in conjuctions
[ https://issues.apache.org/jira/browse/HIVE-19500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487650#comment-16487650 ] Jesus Camacho Rodriguez commented on HIVE-19500: It is not pleasant to do this. I agree and I trust you... and however, we decided as a community that no patch will go in without a clean QA run anymore. That is the only way to keep the build green. If the queue is long, that is another problem that we need to solve, and making the devs unable to bypass the ptest queue is the only way they care about making our test runs more stable and faster. FWIW, there are already patches almost ready to go in and make our runs faster, e.g., HIVE-19633. > Prevent multiple selectivity estimations for the same variable in conjuctions > - > > Key: HIVE-19500 > URL: https://issues.apache.org/jira/browse/HIVE-19500 > Project: Hive > Issue Type: Sub-task >Affects Versions: 3.0.0, 3.1.0 >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-19500.01.patch, HIVE-19500.02.patch, > HIVE-19500.03.patch > > > see HIVE-19097 for problem description > for filters like: {{(d_year in (2001,2002) and d_year = 2001)}} the current > estimation is around {{(1/NDV)**2}} (iff column stats are available) > actually the source of the problem was a small typo in HIVE-17465 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19500) Prevent multiple selectivity estimations for the same variable in conjuctions
[ https://issues.apache.org/jira/browse/HIVE-19500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487632#comment-16487632 ] Zoltan Haindrich commented on HIVE-19500: - but sure...revert it if you want...the queue is right now 39 long... which is ~2 days and I've bisected sample6 cause...the other seems to be some timing issue > Prevent multiple selectivity estimations for the same variable in conjuctions > - > > Key: HIVE-19500 > URL: https://issues.apache.org/jira/browse/HIVE-19500 > Project: Hive > Issue Type: Sub-task >Affects Versions: 3.0.0, 3.1.0 >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-19500.01.patch, HIVE-19500.02.patch, > HIVE-19500.03.patch > > > see HIVE-19097 for problem description > for filters like: {{(d_year in (2001,2002) and d_year = 2001)}} the current > estimation is around {{(1/NDV)**2}} (iff column stats are available) > actually the source of the problem was a small typo in HIVE-17465 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19500) Prevent multiple selectivity estimations for the same variable in conjuctions
[ https://issues.apache.org/jira/browse/HIVE-19500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487617#comment-16487617 ] Zoltan Haindrich commented on HIVE-19500: - I've checked it myself failures are not related > Prevent multiple selectivity estimations for the same variable in conjuctions > - > > Key: HIVE-19500 > URL: https://issues.apache.org/jira/browse/HIVE-19500 > Project: Hive > Issue Type: Sub-task >Affects Versions: 3.0.0, 3.1.0 >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-19500.01.patch, HIVE-19500.02.patch, > HIVE-19500.03.patch > > > see HIVE-19097 for problem description > for filters like: {{(d_year in (2001,2002) and d_year = 2001)}} the current > estimation is around {{(1/NDV)**2}} (iff column stats are available) > actually the source of the problem was a small typo in HIVE-17465 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19500) Prevent multiple selectivity estimations for the same variable in conjuctions
[ https://issues.apache.org/jira/browse/HIVE-19500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487614#comment-16487614 ] Jesus Camacho Rodriguez commented on HIVE-19500: [~kgyrtkirk], is there any reason why this patch went in without a clean QA run? If not, I will revert it. No commits without a clean run are allowed anymore in master, you can find more info here: http://mail-archives.apache.org/mod_mbox/hive-dev/201805.mbox/%3C75DCEC8A-9C05-46F4-B39D-63C201FD20DB%40apache.org%3E Thanks > Prevent multiple selectivity estimations for the same variable in conjuctions > - > > Key: HIVE-19500 > URL: https://issues.apache.org/jira/browse/HIVE-19500 > Project: Hive > Issue Type: Sub-task >Affects Versions: 3.0.0, 3.1.0 >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-19500.01.patch, HIVE-19500.02.patch, > HIVE-19500.03.patch > > > see HIVE-19097 for problem description > for filters like: {{(d_year in (2001,2002) and d_year = 2001)}} the current > estimation is around {{(1/NDV)**2}} (iff column stats are available) > actually the source of the problem was a small typo in HIVE-17465 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19500) Prevent multiple selectivity estimations for the same variable in conjuctions
[ https://issues.apache.org/jira/browse/HIVE-19500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16486839#comment-16486839 ] Hive QA commented on HIVE-19500: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12924496/HIVE-19500.03.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 14396 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample6] (batchId=69) org.apache.hive.minikdc.TestJdbcWithMiniKdc.testTokenAuth (batchId=255) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/11151/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11151/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11151/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12924496 - PreCommit-HIVE-Build > Prevent multiple selectivity estimations for the same variable in conjuctions > - > > Key: HIVE-19500 > URL: https://issues.apache.org/jira/browse/HIVE-19500 > Project: Hive > Issue Type: Sub-task >Affects Versions: 3.0.0, 3.1.0 >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-19500.01.patch, HIVE-19500.02.patch, > HIVE-19500.03.patch > > > see HIVE-19097 for problem description > for filters like: {{(d_year in (2001,2002) and d_year = 2001)}} the current > estimation is around {{(1/NDV)**2}} (iff column stats are available) > actually the source of the problem was a small typo in HIVE-17465 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19500) Prevent multiple selectivity estimations for the same variable in conjuctions
[ https://issues.apache.org/jira/browse/HIVE-19500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16486802#comment-16486802 ] Hive QA commented on HIVE-19500: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m 41s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 49s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 3s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 5m 45s{color} | {color:blue} ql in master has 2322 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 46s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 57s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 32s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 32s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 7s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch 2 line(s) with tabs. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m 5s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 11s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 33m 3s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-11151/dev-support/hive-personality.sh | | git revision | master / ed95ee9 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-11151/yetus/whitespace-tabs.txt | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-11151/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Prevent multiple selectivity estimations for the same variable in conjuctions > - > > Key: HIVE-19500 > URL: https://issues.apache.org/jira/browse/HIVE-19500 > Project: Hive > Issue Type: Sub-task >Affects Versions: 3.0.0, 3.1.0 >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-19500.01.patch, HIVE-19500.02.patch, > HIVE-19500.03.patch > > > see HIVE-19097 for problem description > for filters like: {{(d_year in (2001,2002) and d_year = 2001)}} the current > estimation is around {{(1/NDV)**2}} (iff column stats are available) > actually the source of the problem was a small typo in HIVE-17465 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19500) Prevent multiple selectivity estimations for the same variable in conjuctions
[ https://issues.apache.org/jira/browse/HIVE-19500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483609#comment-16483609 ] Zoltan Haindrich commented on HIVE-19500: - that's interesting...because this ticket fixes a serious underestimation - I think it shouldn't be causing others to get OOMs I think PerfCliDriver should be fixed; because currently in reality it doesn't use column stats correctly... [~ndembla] could you tell me on which queries you get OOMs with this patch? > Prevent multiple selectivity estimations for the same variable in conjuctions > - > > Key: HIVE-19500 > URL: https://issues.apache.org/jira/browse/HIVE-19500 > Project: Hive > Issue Type: Sub-task >Affects Versions: 3.0.0, 3.1.0 >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-19500.01.patch, HIVE-19500.02.patch > > > see HIVE-19097 for problem description > for filters like: {{(d_year in (2001,2002) and d_year = 2001)}} the current > estimation is around {{(1/NDV)**2}} (iff column stats are available) > actually the source of the problem was a small typo in HIVE-17465 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19500) Prevent multiple selectivity estimations for the same variable in conjuctions
[ https://issues.apache.org/jira/browse/HIVE-19500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478001#comment-16478001 ] Nita Dembla commented on HIVE-19500: I didn't have a good pass rate on TPCDS with 2nd patch here. Though the change fixes query74 but causes OOM's in other queries. > Prevent multiple selectivity estimations for the same variable in conjuctions > - > > Key: HIVE-19500 > URL: https://issues.apache.org/jira/browse/HIVE-19500 > Project: Hive > Issue Type: Sub-task >Affects Versions: 3.0.0, 3.1.0 >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-19500.01.patch, HIVE-19500.02.patch > > > see HIVE-19097 for problem description > for filters like: {{(d_year in (2001,2002) and d_year = 2001)}} the current > estimation is around {{(1/NDV)**2}} (iff column stats are available) > actually the source of the problem was a small typo in HIVE-17465 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19500) Prevent multiple selectivity estimations for the same variable in conjuctions
[ https://issues.apache.org/jira/browse/HIVE-19500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476982#comment-16476982 ] Hive QA commented on HIVE-19500: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12923508/HIVE-19500.02.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 21 failed/errored test(s), 14406 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[explainuser_1] (batchId=163) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[mergejoin] (batchId=169) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_multi] (batchId=158) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[union_stats] (batchId=159) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_decimal_cast] (batchId=162) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr] (batchId=156) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_mapjoin_reduce] (batchId=173) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorization_short_regress] (batchId=166) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorized_nested_mapjoin] (batchId=158) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_explainuser_1] (batchId=183) org.apache.hive.jdbc.TestTriggersWorkloadManager.testMultipleTriggers2 (batchId=240) org.apache.hive.jdbc.TestTriggersWorkloadManager.testTriggerCustomCreatedDynamicPartitions (batchId=240) org.apache.hive.jdbc.TestTriggersWorkloadManager.testTriggerCustomCreatedDynamicPartitionsMultiInsert (batchId=240) org.apache.hive.jdbc.TestTriggersWorkloadManager.testTriggerCustomCreatedDynamicPartitionsUnionAll (batchId=240) org.apache.hive.jdbc.TestTriggersWorkloadManager.testTriggerCustomCreatedFiles (batchId=240) org.apache.hive.jdbc.TestTriggersWorkloadManager.testTriggerCustomNonExistent (batchId=240) org.apache.hive.jdbc.TestTriggersWorkloadManager.testTriggerCustomReadOps (batchId=240) org.apache.hive.jdbc.TestTriggersWorkloadManager.testTriggerHighBytesRead (batchId=240) org.apache.hive.jdbc.TestTriggersWorkloadManager.testTriggerHighShuffleBytes (batchId=240) org.apache.hive.jdbc.TestTriggersWorkloadManager.testTriggerVertexRawInputSplitsNoKill (batchId=240) org.apache.hive.spark.client.TestSparkClient.testSimpleSparkJob (batchId=304) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/10982/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/10982/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-10982/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 21 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12923508 - PreCommit-HIVE-Build > Prevent multiple selectivity estimations for the same variable in conjuctions > - > > Key: HIVE-19500 > URL: https://issues.apache.org/jira/browse/HIVE-19500 > Project: Hive > Issue Type: Sub-task >Affects Versions: 3.0.0, 3.1.0 >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-19500.01.patch, HIVE-19500.02.patch > > > see HIVE-19097 for problem description > for filters like: {{(d_year in (2001,2002) and d_year = 2001)}} the current > estimation is around {{(1/NDV)**2}} (iff column stats are available) > actually the source of the problem was a small typo in HIVE-17465 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19500) Prevent multiple selectivity estimations for the same variable in conjuctions
[ https://issues.apache.org/jira/browse/HIVE-19500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476948#comment-16476948 ] Hive QA commented on HIVE-19500: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 13s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 2s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 36s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 53s{color} | {color:blue} ql in master has 2320 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 53s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 22s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 1s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 1s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 38s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch 2 line(s) with tabs. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 59s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 53s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 12s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 22m 15s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-10982/dev-support/hive-personality.sh | | git revision | master / 38c757c | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-10982/yetus/whitespace-tabs.txt | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-10982/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Prevent multiple selectivity estimations for the same variable in conjuctions > - > > Key: HIVE-19500 > URL: https://issues.apache.org/jira/browse/HIVE-19500 > Project: Hive > Issue Type: Sub-task >Affects Versions: 3.0.0, 3.1.0 >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-19500.01.patch, HIVE-19500.02.patch > > > see HIVE-19097 for problem description > for filters like: {{(d_year in (2001,2002) and d_year = 2001)}} the current > estimation is around {{(1/NDV)**2}} (iff column stats are available) > actually the source of the problem was a small typo in HIVE-17465 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19500) Prevent multiple selectivity estimations for the same variable in conjuctions
[ https://issues.apache.org/jira/browse/HIVE-19500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476824#comment-16476824 ] Ashutosh Chauhan commented on HIVE-19500: - +1 > Prevent multiple selectivity estimations for the same variable in conjuctions > - > > Key: HIVE-19500 > URL: https://issues.apache.org/jira/browse/HIVE-19500 > Project: Hive > Issue Type: Sub-task >Affects Versions: 3.0.0, 3.1.0 >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-19500.01.patch, HIVE-19500.02.patch > > > see HIVE-19097 for problem description > for filters like: {{(d_year in (2001,2002) and d_year = 2001)}} the current > estimation is around {{(1/NDV)**2}} (iff column stats are available) > actually the source of the problem was a small typo in HIVE-17465 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19500) Prevent multiple selectivity estimations for the same variable in conjuctions
[ https://issues.apache.org/jira/browse/HIVE-19500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476107#comment-16476107 ] Zoltan Haindrich commented on HIVE-19500: - patch#2: updated some q.out-s [~ashutoshc] could you please take a look? > Prevent multiple selectivity estimations for the same variable in conjuctions > - > > Key: HIVE-19500 > URL: https://issues.apache.org/jira/browse/HIVE-19500 > Project: Hive > Issue Type: Sub-task >Affects Versions: 3.0.0, 3.1.0 >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-19500.01.patch, HIVE-19500.02.patch > > > see HIVE-19097 for problem description > for filters like: {{(d_year in (2001,2002) and d_year = 2001)}} the current > estimation is around {{(1/NDV)**2}} (iff column stats are available) > actually the source of the problem was a small typo in HIVE-17465 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19500) Prevent multiple selectivity estimations for the same variable in conjuctions
[ https://issues.apache.org/jira/browse/HIVE-19500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473291#comment-16473291 ] Hive QA commented on HIVE-19500: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12923062/HIVE-19500.01.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 45 failed/errored test(s), 13566 tests executed *Failed tests:* {noformat} TestDbNotificationListener - did not produce a TEST-*.xml file (likely timed out) (batchId=247) TestHCatHiveCompatibility - did not produce a TEST-*.xml file (likely timed out) (batchId=247) TestJdbcWithDBTokenStoreNoDoAs - did not produce a TEST-*.xml file (likely timed out) (batchId=254) TestNegativeCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=95) [nopart_insert.q,insert_into_with_schema.q,input41.q,having1.q,create_table_failure3.q,default_constraint_invalid_default_value.q,database_drop_not_empty_restrict.q,windowing_after_orderby.q,orderbysortby.q,subquery_select_distinct2.q,authorization_uri_alterpart_loc.q,udf_last_day_error_1.q,constraint_duplicate_name.q,create_table_failure4.q,alter_tableprops_external_with_notnull_constraint.q,semijoin5.q,udf_format_number_wrong4.q,deletejar.q,exim_11_nonpart_noncompat_sorting.q,show_tables_bad_db2.q,drop_func_nonexistent.q,alter_table_non_partitioned_table_cascade.q,check_constraint_subquery.q,load_wrong_fileformat.q,check_constraint_udtf.q,lockneg_try_db_lock_conflict.q,udf_field_wrong_args_len.q,create_table_failure2.q,create_with_fk_constraints_enforced.q,groupby2_map_skew_multi_distinct.q,mm_update.q,authorization_update_noupdatepriv.q,show_columns2.q,authorization_insert_noselectpriv.q,orc_replace_columns3_acid.q,compare_double_bigint.q,authorization_set_nonexistent_conf.q,alter_rename_partition_failure3.q,split_sample_wrong_format2.q,create_with_fk_pk_same_tab.q,compare_double_bigint_2.q,authorization_show_roles_no_admin.q,materialized_view_authorization_rebuild_no_grant.q,unionLimit.q,authorization_revoke_table_fail2.q,duplicate_insert3.q,authorization_desc_table_nosel.q,stats_noscan_non_native.q,orc_change_serde_acid.q,create_or_replace_view7.q,exim_07_nonpart_noncompat_ifof.q,create_with_unique_constraints_enforced.q,udf_concat_ws_wrong2.q,fileformat_bad_class.q,merge_negative_2.q,exim_15_part_nonpart.q,authorization_not_owner_drop_view.q,external1.q,authorization_uri_insert.q,create_with_fk_wrong_ref.q,columnstats_tbllvl_incorrect_column.q,authorization_show_parts_nosel.q,authorization_not_owner_drop_tab.q,external2.q,authorization_deletejar.q,temp_table_create_like_partitions.q,udf_greatest_error_1.q,ptf_negative_AggrFuncsWithNoGBYNoPartDef.q,alter_view_as_select_not_exist.q,touch1.q,groupby3_map_skew_multi_distinct.q,insert_into_notnull_constraint.q,exchange_partition_neg_partition_missing.q,groupby_cube_multi_gby.q,columnstats_tbllvl.q,drop_invalid_constraint2.q,alter_table_add_partition.q,update_not_acid.q,archive5.q,alter_table_constraint_invalid_pk_col.q,ivyDownload.q,udf_instr_wrong_type.q,bad_sample_clause.q,authorization_not_owner_drop_tab2.q,authorization_alter_db_owner.q,show_columns1.q,orc_type_promotion3.q,create_view_failure8.q,strict_join.q,udf_add_months_error_1.q,groupby_cube2.q,groupby_cube1.q,groupby_rollup1.q,genericFileFormat.q,invalid_cast_from_binary_4.q,drop_invalid_constraint1.q,serde_regex.q,show_partitions1.q,check_constraint_nonboolean_expr.q,invalid_cast_from_binary_6.q,create_with_multi_pk_constraint.q,udf_field_wrong_type.q,groupby_grouping_sets4.q,groupby_grouping_sets3.q,insertsel_fail.q,udf_locate_wrong_type.q,orc_type_promotion1_acid.q,set_table_property.q,create_or_replace_view2.q,groupby_grouping_sets2.q,alter_view_failure.q,distinct_windowing_failure1.q,invalid_t_alter2.q,alter_table_constraint_invalid_fk_col1.q,invalid_varchar_length_2.q,authorization_show_grant_otheruser_alltabs.q,subquery_windowing_corr.q,compact_non_acid_table.q,authorization_view_4.q,authorization_disallow_transform.q,materialized_view_authorization_rebuild_other.q,authorization_fail_4.q,dbtxnmgr_nodblock.q,set_hiveconf_internal_variable1.q,input_part0_neg.q,udf_printf_wrong3.q,load_orc_negative2.q,druid_buckets.q,archive2.q,authorization_addjar.q,invalid_sum_syntax.q,insert_into_with_schema1.q,udf_add_months_error_2.q,dyn_part_max_per_node.q,authorization_revoke_table_fail1.q,udf_printf_wrong2.q,archive_multi3.q,udf_printf_wrong1.q,subquery_subquery_chain.q,authorization_view_disable_cbo_4.q,no_matching_udf.q,create_view_failure7.q,drop_native_udf.q,truncate_column_list_bucketing.q,authorization_uri_add_partition.q,authorization_view_disable_cbo_3.q,bad_exec_hooks.q,authorization_view_disable_cbo_2.q,fetchtask_ioexception.q,char_pad_convert_fail2.q,authorization_set_role_neg1.q,serde_regex3.q,authorization_delete_nodeletepriv.q,materialized_view_d
[jira] [Commented] (HIVE-19500) Prevent multiple selectivity estimations for the same variable in conjuctions
[ https://issues.apache.org/jira/browse/HIVE-19500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473281#comment-16473281 ] Hive QA commented on HIVE-19500: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 47s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 4s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 40s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 58s{color} | {color:blue} ql in master has 2321 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 55s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 0s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 0s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 37s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch 2 line(s) with tabs. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 5s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 52s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 21m 59s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-10861/dev-support/hive-personality.sh | | git revision | master / 8db979f | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-10861/yetus/whitespace-tabs.txt | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-10861/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Prevent multiple selectivity estimations for the same variable in conjuctions > - > > Key: HIVE-19500 > URL: https://issues.apache.org/jira/browse/HIVE-19500 > Project: Hive > Issue Type: Sub-task >Affects Versions: 3.0.0, 3.1.0 >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-19500.01.patch > > > see HIVE-19097 for problem description > for filters like: {{(d_year in (2001,2002) and d_year = 2001)}} the current > estimation is around {{(1/NDV)**2}} (iff column stats are available) > actually the source of the problem was a small typo in HIVE-17465 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19500) Prevent multiple selectivity estimations for the same variable in conjuctions
[ https://issues.apache.org/jira/browse/HIVE-19500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472350#comment-16472350 ] Zoltan Haindrich commented on HIVE-19500: - [~vgarg] I'm not sure if this was a typo in HIVE-17465 ; or it was part of the intended change > Prevent multiple selectivity estimations for the same variable in conjuctions > - > > Key: HIVE-19500 > URL: https://issues.apache.org/jira/browse/HIVE-19500 > Project: Hive > Issue Type: Sub-task >Affects Versions: 3.0.0, 3.1.0 >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-19500.01.patch > > > see HIVE-19097 for problem description > for filters like: {{(d_year in (2001,2002) and d_year = 2001)}} the current > estimation is around {{(1/NDV)**2}} (iff column stats are available) > actually the source of the problem was a small typo in HIVE-17465 -- This message was sent by Atlassian JIRA (v7.6.3#76005)