[jira] [Updated] (IGNITE-23208) Cluster wide CLI management of metrics
[ https://issues.apache.org/jira/browse/IGNITE-23208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-23208: Labels: iep-116 ignite-3 (was: ) > Cluster wide CLI management of metrics > -- > > Key: IGNITE-23208 > URL: https://issues.apache.org/jira/browse/IGNITE-23208 > Project: Ignite > Issue Type: Improvement >Affects Versions: 3.0 >Reporter: Andrey Novikov >Priority: Major > Labels: iep-116, ignite-3 > > It should be possible to enable or disable metrics sources by metrics source > name and to get list of all metrics sources names via Ignite Shell for all > nodes in cluster. > For now it is possible to do this only for node which process this request. > Possible syntax: > ignite metrics enable [--local] > ignite metrics disable [--local] > ignite metrics list [--local] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IGNITE-23208) Cluster wide CLI management of metrics
Andrey Novikov created IGNITE-23208: --- Summary: Cluster wide CLI management of metrics Key: IGNITE-23208 URL: https://issues.apache.org/jira/browse/IGNITE-23208 Project: Ignite Issue Type: Improvement Affects Versions: 3.0 Reporter: Andrey Novikov It should be possible to enable or disable metrics sources by metrics source name and to get list of all metrics sources names via Ignite Shell for all nodes in cluster. For now it is possible to do this only for node which process this request. Possible syntax: ignite metrics enable [--local] ignite metrics disable [--local] ignite metrics list [--local] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-22696) Add prometheus libs to opensensus module
[ https://issues.apache.org/jira/browse/IGNITE-22696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17866046#comment-17866046 ] Andrey Novikov commented on IGNITE-22696: - LGTM, thanks for your contribution! > Add prometheus libs to opensensus module > > > Key: IGNITE-22696 > URL: https://issues.apache.org/jira/browse/IGNITE-22696 > Project: Ignite > Issue Type: Improvement >Reporter: Matvei Kalistratov >Assignee: Matvei Kalistratov >Priority: Major > Fix For: 2.17 > > Time Spent: 1.5h > Remaining Estimate: 0h > > For now I have to download number of jars to configure metrics in prometheus > format for AI and point JVM_OPTS to these jar. Or build the jar by myself as > described in > [https://www.gridgain.com/resources/blog/setting-prometheus-apache-ignite-and-gridgain]. > Only after that it becomes possible to configure metrics using AI config. > That's quite uncomfortable to do that running AI in container in docker or > k8s and requires additional storage and init container to download, build and > store these jars, change config after that and restart AI. > Needed to add necessary libs to opensensus module to make it possible to > configure prometheus metrics exposing from the box. It should be enough just > to change AI config to get prometheus metrics work. > Libs needs to be added: > - io.prometheus simpleclient_httpserver > - io.opencensus opencensus-exporter-stats-prometheus -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (IGNITE-22601) Pass instance of ValidationManager to CmgRaftGroupListener constructor
[ https://issues.apache.org/jira/browse/IGNITE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov reassigned IGNITE-22601: --- Assignee: Andrey Novikov > Pass instance of ValidationManager to CmgRaftGroupListener constructor > -- > > Key: IGNITE-22601 > URL: https://issues.apache.org/jira/browse/IGNITE-22601 > Project: Ignite > Issue Type: Improvement > Components: general >Affects Versions: 3.0.0-beta2 >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Labels: ignite-3 > > *Motivation* > For now ValidationManager created in CmgRaftGroupListener constructor and it > is not possible to pass another implementation or access to it methods in > tests. > *What to do*: > * Change visibility of ValidationManager from package to public > * Make it a parameter in the ClusterManagementGroupManager constructor. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (IGNITE-22317) [Extensions] Release Ignite Spring Extensions
[ https://issues.apache.org/jira/browse/IGNITE-22317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov resolved IGNITE-22317. - Resolution: Fixed > [Extensions] Release Ignite Spring Extensions > - > > Key: IGNITE-22317 > URL: https://issues.apache.org/jira/browse/IGNITE-22317 > Project: Ignite > Issue Type: Task > Components: extensions >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Fix For: 2.16 > > > The following extenstions must be released: > - ignite-spring-data-ext > - ignite-spring-session-ext > - ignite-spring-cache-ext > - ignite-spring-tx-ext -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IGNITE-22601) Pass instance of ValidationManager to CmgRaftGroupListener constructor
Andrey Novikov created IGNITE-22601: --- Summary: Pass instance of ValidationManager to CmgRaftGroupListener constructor Key: IGNITE-22601 URL: https://issues.apache.org/jira/browse/IGNITE-22601 Project: Ignite Issue Type: Improvement Components: general Affects Versions: 3.0.0-beta2 Reporter: Andrey Novikov *Motivation* For now ValidationManager created in CmgRaftGroupListener constructor and it is not possible to pass another implementation or access to it methods in tests. *What to do*: * Change visibility of ValidationManager from package to public * Make it a parameter in the ClusterManagementGroupManager constructor. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-22601) Pass instance of ValidationManager to CmgRaftGroupListener constructor
[ https://issues.apache.org/jira/browse/IGNITE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-22601: Labels: ignite-3 (was: ) > Pass instance of ValidationManager to CmgRaftGroupListener constructor > -- > > Key: IGNITE-22601 > URL: https://issues.apache.org/jira/browse/IGNITE-22601 > Project: Ignite > Issue Type: Improvement > Components: general >Affects Versions: 3.0.0-beta2 >Reporter: Andrey Novikov >Priority: Major > Labels: ignite-3 > > *Motivation* > For now ValidationManager created in CmgRaftGroupListener constructor and it > is not possible to pass another implementation or access to it methods in > tests. > *What to do*: > * Change visibility of ValidationManager from package to public > * Make it a parameter in the ClusterManagementGroupManager constructor. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-22574) Ignite CLI: Allow to pass multiple files with cluster configuration for init command
[ https://issues.apache.org/jira/browse/IGNITE-22574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-22574: Description: *Motivation:* It is nice to have possibility to pass multiple files with cluster configuration on init step. The main idea of configuration separation is to create a complex configuration based on simple ones, for example in tests. Another reason for that can be restricted access to part of configuration that contains some credentials. *What to to:* * Rename "--config-file" option to "config-files" * Allow to pass multiple "--config-files" option for cluster init command in cli tool. * Merge content of passed files with configuration based they order. was: *Motivation:* It is nice to have possibility to pass multiple files with cluster configuration on init step. The main idea of configuration separation is to create a complex configuration based on simple ones, for example in tests. Another reason for that can be restricted access to part of configuration that contains some credentials. *What to to:* * Rename "--config-file" option to "--config-files" * Allow to pass multiple "--config-files" option for cluster init command in cli tool. * Merge content of passed files with configuration based they order. > Ignite CLI: Allow to pass multiple files with cluster configuration for init > command > > > Key: IGNITE-22574 > URL: https://issues.apache.org/jira/browse/IGNITE-22574 > Project: Ignite > Issue Type: Improvement > Components: cli >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Labels: ignite-3, ignite-3-cli-tool > Fix For: 3.0 > > > *Motivation:* > It is nice to have possibility to pass multiple files with cluster > configuration on init step. The main idea of configuration separation is to > create a complex configuration based on simple ones, for example in tests. > Another reason for that can be restricted access to part of configuration > that contains some credentials. > *What to to:* > * Rename "--config-file" option to "config-files" > * Allow to pass multiple "--config-files" option for cluster init command in > cli tool. > * Merge content of passed files with configuration based they order. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-22574) Ignite CLI: Allow to pass multiple files with cluster configuration for init command
[ https://issues.apache.org/jira/browse/IGNITE-22574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-22574: Description: *Motivation:* It is nice to have possibility to pass multiple files with cluster configuration on init step. The main idea of configuration separation is to create a complex configuration based on simple ones, for example in tests. Another reason for that can be restricted access to part of configuration that contains some credentials. *What to to:* * Rename "--config-file" option to "--config-files" * Allow to pass multiple "--config-files" option for cluster init command in cli tool. * Merge content of passed files with configuration based they order. was: *Motivation:* It is nice to have possibility to pass multiple files with cluster configuration on init step. The main idea of configuration separation is to create a complex configuration based on simple ones, for example in tests. Another reason for that can be restricted access to part of configuration that contains some credentials. *What to to:* * Allow to pass multiple "--config-file" option for cluster init command in cli tool. * Merge content of passed files with configuration based they order. > Ignite CLI: Allow to pass multiple files with cluster configuration for init > command > > > Key: IGNITE-22574 > URL: https://issues.apache.org/jira/browse/IGNITE-22574 > Project: Ignite > Issue Type: Improvement > Components: cli >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Labels: ignite-3, ignite-3-cli-tool > Fix For: 3.0 > > > *Motivation:* > It is nice to have possibility to pass multiple files with cluster > configuration on init step. The main idea of configuration separation is to > create a complex configuration based on simple ones, for example in tests. > Another reason for that can be restricted access to part of configuration > that contains some credentials. > *What to to:* > * Rename "--config-file" option to "--config-files" > * Allow to pass multiple "--config-files" option for cluster init command in > cli tool. > * Merge content of passed files with configuration based they order. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (IGNITE-22574) Ignite CLI: Allow to pass multiple files with cluster configuration for init command
[ https://issues.apache.org/jira/browse/IGNITE-22574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov reassigned IGNITE-22574: --- Assignee: Andrey Novikov > Ignite CLI: Allow to pass multiple files with cluster configuration for init > command > > > Key: IGNITE-22574 > URL: https://issues.apache.org/jira/browse/IGNITE-22574 > Project: Ignite > Issue Type: Improvement > Components: cli >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Labels: ignite-3, ignite-3-cli-tool > Fix For: 3.0 > > > *Motivation:* > It is nice to have possibility to pass multiple files with cluster > configuration on init step. The main idea of configuration separation is to > create a complex configuration based on simple ones, for example in tests. > Another reason for that can be restricted access to part of configuration > that contains some credentials. > *What to to:* > * Allow to pass multiple "--config-file" option for cluster init command in > cli tool. > * Merge content of passed files with configuration based they order. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-22574) Ignite CLI: Allow to pass multiple files with cluster configuration for init command
[ https://issues.apache.org/jira/browse/IGNITE-22574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-22574: Labels: ignite-3-cli-tool (was: ) > Ignite CLI: Allow to pass multiple files with cluster configuration for init > command > > > Key: IGNITE-22574 > URL: https://issues.apache.org/jira/browse/IGNITE-22574 > Project: Ignite > Issue Type: Improvement > Components: cli >Reporter: Andrey Novikov >Priority: Major > Labels: ignite-3-cli-tool > > *Motivation:* > It is nice to have possibility to pass multiple files with cluster > configuration on init step. The main idea of configuration separation is to > create a complex configuration based on simple ones, for example in tests. > Another reason for that can be restricted access to part of configuration > that contains some credentials. > *What to to:* > * Allow to pass multiple "--config-file" option for cluster init command in > cli tool. > * Merge content of passed files with configuration based they order. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-22574) Ignite CLI: Allow to pass multiple files with cluster configuration for init command
[ https://issues.apache.org/jira/browse/IGNITE-22574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-22574: Fix Version/s: 3.0 > Ignite CLI: Allow to pass multiple files with cluster configuration for init > command > > > Key: IGNITE-22574 > URL: https://issues.apache.org/jira/browse/IGNITE-22574 > Project: Ignite > Issue Type: Improvement > Components: cli >Reporter: Andrey Novikov >Priority: Major > Labels: ignite-3-cli-tool > Fix For: 3.0 > > > *Motivation:* > It is nice to have possibility to pass multiple files with cluster > configuration on init step. The main idea of configuration separation is to > create a complex configuration based on simple ones, for example in tests. > Another reason for that can be restricted access to part of configuration > that contains some credentials. > *What to to:* > * Allow to pass multiple "--config-file" option for cluster init command in > cli tool. > * Merge content of passed files with configuration based they order. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IGNITE-22574) Ignite CLI: Allow to pass multiple files with cluster configuration for init command
Andrey Novikov created IGNITE-22574: --- Summary: Ignite CLI: Allow to pass multiple files with cluster configuration for init command Key: IGNITE-22574 URL: https://issues.apache.org/jira/browse/IGNITE-22574 Project: Ignite Issue Type: Improvement Components: cli Reporter: Andrey Novikov *Motivation:* It is nice to have possibility to pass multiple files with cluster configuration on init step. The main idea of configuration separation is to create a complex configuration based on simple ones, for example in tests. Another reason for that can be restricted access to part of configuration that contains some credentials. *What to to:* * Allow to pass multiple "--config-file" option for cluster init command in cli tool. * Merge content of passed files with configuration based they order. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-22352) Fix bean creation race in spring-ses-ext
[ https://issues.apache.org/jira/browse/IGNITE-22352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850251#comment-17850251 ] Andrey Novikov commented on IGNITE-22352: - [~nshakarov], LGTM, thanks for your contribution! > Fix bean creation race in spring-ses-ext > > > Key: IGNITE-22352 > URL: https://issues.apache.org/jira/browse/IGNITE-22352 > Project: Ignite > Issue Type: Improvement >Reporter: Nusrat Shakarov >Assignee: Nusrat Shakarov >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-22352) Fix bean creation race in spring-ses-ext
[ https://issues.apache.org/jira/browse/IGNITE-22352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-22352: Reviewer: Andrey Novikov > Fix bean creation race in spring-ses-ext > > > Key: IGNITE-22352 > URL: https://issues.apache.org/jira/browse/IGNITE-22352 > Project: Ignite > Issue Type: Improvement >Reporter: Nusrat Shakarov >Assignee: Nusrat Shakarov >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (IGNITE-22352) Fix bean creation race in spring-ses-ext
[ https://issues.apache.org/jira/browse/IGNITE-22352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov reassigned IGNITE-22352: --- Assignee: Nusrat Shakarov (was: Andrey Novikov) > Fix bean creation race in spring-ses-ext > > > Key: IGNITE-22352 > URL: https://issues.apache.org/jira/browse/IGNITE-22352 > Project: Ignite > Issue Type: Improvement >Reporter: Nusrat Shakarov >Assignee: Nusrat Shakarov >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] (IGNITE-22352) Fix bean creation race in spring-ses-ext
[ https://issues.apache.org/jira/browse/IGNITE-22352 ] Andrey Novikov deleted comment on IGNITE-22352: - was (Author: anovikov): [~nshakarov], LGTM, thanks for your contribution! > Fix bean creation race in spring-ses-ext > > > Key: IGNITE-22352 > URL: https://issues.apache.org/jira/browse/IGNITE-22352 > Project: Ignite > Issue Type: Improvement >Reporter: Nusrat Shakarov >Assignee: Andrey Novikov >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-22352) Fix bean creation race in spring-ses-ext
[ https://issues.apache.org/jira/browse/IGNITE-22352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850249#comment-17850249 ] Andrey Novikov commented on IGNITE-22352: - [~nshakarov], LGTM, thanks for your contribution! > Fix bean creation race in spring-ses-ext > > > Key: IGNITE-22352 > URL: https://issues.apache.org/jira/browse/IGNITE-22352 > Project: Ignite > Issue Type: Improvement >Reporter: Nusrat Shakarov >Assignee: Andrey Novikov >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-22079) Add spring 6 support to spring-data extension
[ https://issues.apache.org/jira/browse/IGNITE-22079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849871#comment-17849871 ] Andrey Novikov commented on IGNITE-22079: - [~nshakarov] It looks like all the changes were made to IGNITE-22102 Does this ticket make sense now? > Add spring 6 support to spring-data extension > - > > Key: IGNITE-22079 > URL: https://issues.apache.org/jira/browse/IGNITE-22079 > Project: Ignite > Issue Type: Improvement >Reporter: Nusrat Shakarov >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-22078) Add spring 6 support to spring-tx extension
[ https://issues.apache.org/jira/browse/IGNITE-22078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849870#comment-17849870 ] Andrey Novikov commented on IGNITE-22078: - It looks like all the changes were made to IGNITE-22102 Does this ticket make sense now? > Add spring 6 support to spring-tx extension > --- > > Key: IGNITE-22078 > URL: https://issues.apache.org/jira/browse/IGNITE-22078 > Project: Ignite > Issue Type: Improvement >Reporter: Nusrat Shakarov >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-22102) Upgrade ignite spring extensions to spring 6
[ https://issues.apache.org/jira/browse/IGNITE-22102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849868#comment-17849868 ] Andrey Novikov commented on IGNITE-22102: - [~nshakarov], LGTM, thanks for your contribution! > Upgrade ignite spring extensions to spring 6 > > > Key: IGNITE-22102 > URL: https://issues.apache.org/jira/browse/IGNITE-22102 > Project: Ignite > Issue Type: Improvement >Reporter: Nusrat Shakarov >Assignee: Nusrat Shakarov >Priority: Major > > Upgrade the following extensions: > * ignite-spring-cache-ext > * ignite-spring-data-ext > * ignite-spring-tx-ext -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (IGNITE-22317) [Extensions] Release Ignite Spring Extensions
[ https://issues.apache.org/jira/browse/IGNITE-22317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov reassigned IGNITE-22317: --- Assignee: Andrey Novikov > [Extensions] Release Ignite Spring Extensions > - > > Key: IGNITE-22317 > URL: https://issues.apache.org/jira/browse/IGNITE-22317 > Project: Ignite > Issue Type: Task > Components: extensions >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Fix For: 2.16 > > > The following extenstions must be released: > - ignite-spring-data-ext > - ignite-spring-session-ext > - ignite-spring-cache-ext > - ignite-spring-tx-ext -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-22317) [Extensions] Release Ignite Spring Extensions
[ https://issues.apache.org/jira/browse/IGNITE-22317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-22317: Epic Link: IGNITE-22096 > [Extensions] Release Ignite Spring Extensions > - > > Key: IGNITE-22317 > URL: https://issues.apache.org/jira/browse/IGNITE-22317 > Project: Ignite > Issue Type: Task > Components: extensions >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Fix For: 2.16 > > > The following extenstions must be released: > - ignite-spring-data-ext > - ignite-spring-session-ext > - ignite-spring-cache-ext > - ignite-spring-tx-ext -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IGNITE-22317) [Extensions] Release Ignite Spring Extensions
Andrey Novikov created IGNITE-22317: --- Summary: [Extensions] Release Ignite Spring Extensions Key: IGNITE-22317 URL: https://issues.apache.org/jira/browse/IGNITE-22317 Project: Ignite Issue Type: Task Components: extensions Reporter: Andrey Novikov Fix For: 2.16 The following extenstions must be released: - ignite-spring-data-ext - ignite-spring-session-ext - ignite-spring-cache-ext - ignite-spring-tx-ext -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (IGNITE-20059) SpringBoot/Data extensions all use super-old, unsupported versions
[ https://issues.apache.org/jira/browse/IGNITE-20059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848907#comment-17848907 ] Andrey Novikov edited comment on IGNITE-20059 at 5/23/24 11:17 AM: --- [~sdarlington] It seems that these changes are no longer relevant as we updated to Spring 6 in IGNITE-22077 was (Author: anovikov): [~sdarlington] It seems that these changes are no longer required, as we updated to Spring 6 in IGNITE-22077 > SpringBoot/Data extensions all use super-old, unsupported versions > -- > > Key: IGNITE-20059 > URL: https://issues.apache.org/jira/browse/IGNITE-20059 > Project: Ignite > Issue Type: Improvement > Components: extensions, spring, springdata >Reporter: Stephen Darlington >Assignee: Stephen Darlington >Priority: Major > > All our Spring dependencies are very out of date. It's currently pointing to > version 2.2.13, which hasn't been supported since late 2020. This is an > obstacle to Ignite being added to the [Spring > Initializr|https://github.com/spring-io/start.spring.io/issues/960]. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-20059) SpringBoot/Data extensions all use super-old, unsupported versions
[ https://issues.apache.org/jira/browse/IGNITE-20059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848907#comment-17848907 ] Andrey Novikov commented on IGNITE-20059: - [~sdarlington] It seems that these changes are no longer required, as we updated to Spring 6 in IGNITE-22077 > SpringBoot/Data extensions all use super-old, unsupported versions > -- > > Key: IGNITE-20059 > URL: https://issues.apache.org/jira/browse/IGNITE-20059 > Project: Ignite > Issue Type: Improvement > Components: extensions, spring, springdata >Reporter: Stephen Darlington >Assignee: Stephen Darlington >Priority: Major > > All our Spring dependencies are very out of date. It's currently pointing to > version 2.2.13, which hasn't been supported since late 2020. This is an > obstacle to Ignite being added to the [Spring > Initializr|https://github.com/spring-io/start.spring.io/issues/960]. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-22311) Fix checkstyle in spring-ses-ext
[ https://issues.apache.org/jira/browse/IGNITE-22311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848884#comment-17848884 ] Andrey Novikov commented on IGNITE-22311: - LGTM > Fix checkstyle in spring-ses-ext > > > Key: IGNITE-22311 > URL: https://issues.apache.org/jira/browse/IGNITE-22311 > Project: Ignite > Issue Type: Improvement >Reporter: Nusrat Shakarov >Assignee: Nusrat Shakarov >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-22077) Add spring 6 support to spring-session extension
[ https://issues.apache.org/jira/browse/IGNITE-22077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848444#comment-17848444 ] Andrey Novikov commented on IGNITE-22077: - [~nshakarov], LGTM, thanks for your contribution! > Add spring 6 support to spring-session extension > > > Key: IGNITE-22077 > URL: https://issues.apache.org/jira/browse/IGNITE-22077 > Project: Ignite > Issue Type: Improvement >Reporter: Nusrat Shakarov >Assignee: Nusrat Shakarov >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-21841) The FilePageStoreManager constructor should not throw an exception
[ https://issues.apache.org/jira/browse/IGNITE-21841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-21841: Labels: ignite-3 (was: ) > The FilePageStoreManager constructor should not throw an exception > -- > > Key: IGNITE-21841 > URL: https://issues.apache.org/jira/browse/IGNITE-21841 > Project: Ignite > Issue Type: Improvement > Components: persistence >Affects Versions: 3.0.0-beta2 >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Labels: ignite-3 > Time Spent: 10m > Remaining Estimate: 0h > > Current implementation of FilePageStoreManager is throw an exception from > constructor, which is not recommended. > Let's create FilePageStoreFactory from the outside and pass it to the > constructor. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IGNITE-21841) The FilePageStoreManager constructor should not throw an exception
Andrey Novikov created IGNITE-21841: --- Summary: The FilePageStoreManager constructor should not throw an exception Key: IGNITE-21841 URL: https://issues.apache.org/jira/browse/IGNITE-21841 Project: Ignite Issue Type: Improvement Components: persistence Affects Versions: 3.0.0-beta2 Reporter: Andrey Novikov Current implementation of FilePageStoreManager is throw an exception from constructor, which is not recommended. Let's create FilePageStoreFactory from the outside and pass it to the constructor. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (IGNITE-21841) The FilePageStoreManager constructor should not throw an exception
[ https://issues.apache.org/jira/browse/IGNITE-21841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov reassigned IGNITE-21841: --- Assignee: Andrey Novikov > The FilePageStoreManager constructor should not throw an exception > -- > > Key: IGNITE-21841 > URL: https://issues.apache.org/jira/browse/IGNITE-21841 > Project: Ignite > Issue Type: Improvement > Components: persistence >Affects Versions: 3.0.0-beta2 >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > > Current implementation of FilePageStoreManager is throw an exception from > constructor, which is not recommended. > Let's create FilePageStoreFactory from the outside and pass it to the > constructor. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-21840) PersistentPageMemoryStorageEngine#createMvTable should return MvTableStorage
[ https://issues.apache.org/jira/browse/IGNITE-21840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-21840: Labels: ignite-3 (was: ) > PersistentPageMemoryStorageEngine#createMvTable should return MvTableStorage > > > Key: IGNITE-21840 > URL: https://issues.apache.org/jira/browse/IGNITE-21840 > Project: Ignite > Issue Type: Improvement > Components: persistence >Affects Versions: 3.0.0-beta2 >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Labels: ignite-3 > Fix For: 3.0.0-beta2 > > > Current implementation of PersistentPageMemoryStorageEngine#createMvTable > returns PersistentPageMemoryTableStorage which doesn't comply with the > contract described in StorageEngine. The use of this is not found in the code. > Let's return MvTableStorage instead of PersistentPageMemoryTableStorage. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (IGNITE-21840) PersistentPageMemoryStorageEngine#createMvTable should return MvTableStorage
[ https://issues.apache.org/jira/browse/IGNITE-21840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov reassigned IGNITE-21840: --- Assignee: Andrey Novikov > PersistentPageMemoryStorageEngine#createMvTable should return MvTableStorage > > > Key: IGNITE-21840 > URL: https://issues.apache.org/jira/browse/IGNITE-21840 > Project: Ignite > Issue Type: Improvement > Components: persistence >Affects Versions: 3.0.0-beta2 >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Fix For: 3.0.0-beta2 > > > Current implementation of PersistentPageMemoryStorageEngine#createMvTable > returns PersistentPageMemoryTableStorage which doesn't comply with the > contract described in StorageEngine. The use of this is not found in the code. > Let's return MvTableStorage instead of PersistentPageMemoryTableStorage. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IGNITE-21840) PersistentPageMemoryStorageEngine#createMvTable should return MvTableStorage
Andrey Novikov created IGNITE-21840: --- Summary: PersistentPageMemoryStorageEngine#createMvTable should return MvTableStorage Key: IGNITE-21840 URL: https://issues.apache.org/jira/browse/IGNITE-21840 Project: Ignite Issue Type: Improvement Components: persistence Affects Versions: 3.0.0-beta2 Reporter: Andrey Novikov Fix For: 3.0.0-beta2 Current implementation of PersistentPageMemoryStorageEngine#createMvTable returns PersistentPageMemoryTableStorage which doesn't comply with the contract described in StorageEngine. The use of this is not found in the code. Let's return MvTableStorage instead of PersistentPageMemoryTableStorage. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IGNITE-21817) CriteriaException must keep error code for mapping from SqlException
Andrey Novikov created IGNITE-21817: --- Summary: CriteriaException must keep error code for mapping from SqlException Key: IGNITE-21817 URL: https://issues.apache.org/jira/browse/IGNITE-21817 Project: Ignite Issue Type: Improvement Reporter: Andrey Novikov Current implementation of CriteriaExceptionMapperUtil#mapToPublicCriteriaException {code:java} public static Throwable mapToPublicCriteriaException(Throwable origin) { Throwable e = mapToPublicException(origin); if (e instanceof Error) { return e; } if (e instanceof CriteriaException) { return e; } if (e instanceof SqlException) { return new CriteriaException(INTERNAL_ERR, e); } ...{code} It looks like we doesn't need to map all SqlException to CriteriaException with errorCode = INTERNAL_ERR -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (IGNITE-21817) CriteriaException must keep error code for mapping from SqlException
[ https://issues.apache.org/jira/browse/IGNITE-21817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov reassigned IGNITE-21817: --- Assignee: Andrey Novikov > CriteriaException must keep error code for mapping from SqlException > - > > Key: IGNITE-21817 > URL: https://issues.apache.org/jira/browse/IGNITE-21817 > Project: Ignite > Issue Type: Improvement >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Labels: ignite-3 > > Current implementation of > CriteriaExceptionMapperUtil#mapToPublicCriteriaException > {code:java} > public static Throwable mapToPublicCriteriaException(Throwable origin) { > Throwable e = mapToPublicException(origin); > if (e instanceof Error) { > return e; > } > if (e instanceof CriteriaException) { > return e; > } > if (e instanceof SqlException) { > return new CriteriaException(INTERNAL_ERR, e); > } > ...{code} > It looks like we doesn't need to map all SqlException to CriteriaException > with errorCode = INTERNAL_ERR -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-21817) CriteriaException must keep error code for mapping from SqlException
[ https://issues.apache.org/jira/browse/IGNITE-21817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-21817: Labels: ignite-3 (was: ) > CriteriaException must keep error code for mapping from SqlException > - > > Key: IGNITE-21817 > URL: https://issues.apache.org/jira/browse/IGNITE-21817 > Project: Ignite > Issue Type: Improvement >Reporter: Andrey Novikov >Priority: Major > Labels: ignite-3 > > Current implementation of > CriteriaExceptionMapperUtil#mapToPublicCriteriaException > {code:java} > public static Throwable mapToPublicCriteriaException(Throwable origin) { > Throwable e = mapToPublicException(origin); > if (e instanceof Error) { > return e; > } > if (e instanceof CriteriaException) { > return e; > } > if (e instanceof SqlException) { > return new CriteriaException(INTERNAL_ERR, e); > } > ...{code} > It looks like we doesn't need to map all SqlException to CriteriaException > with errorCode = INTERNAL_ERR -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-21814) Incorrect validation error if configuration value is not initialized
[ https://issues.apache.org/jira/browse/IGNITE-21814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-21814: Labels: ignite-3 (was: ) > Incorrect validation error if configuration value is not initialized > > > Key: IGNITE-21814 > URL: https://issues.apache.org/jira/browse/IGNITE-21814 > Project: Ignite > Issue Type: Improvement > Components: cli >Affects Versions: 3.0.0-beta2 >Reporter: Andrey Novikov >Priority: Minor > Labels: ignite-3 > > KeysTrackingConfigurationVisitor#validate looks incorrect > {code:java} > if (val == null) { > String message = "'" + (currentKey() + fieldName) + "' configuration > value is not initialized."; > issues.add(new ValidationIssue(currentKey(), message)); > return; > } {code} > It throw exception which contains section and full field name in error > message: > > {noformat} > Validation did not pass for keys: [test.providers.basic., > 'test.providers.basic.secret' configuration value is not initialized.] > {noformat} > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IGNITE-21814) Incorrect validation error if configuration value is not initialized
Andrey Novikov created IGNITE-21814: --- Summary: Incorrect validation error if configuration value is not initialized Key: IGNITE-21814 URL: https://issues.apache.org/jira/browse/IGNITE-21814 Project: Ignite Issue Type: Improvement Components: cli Affects Versions: 3.0.0-beta2 Reporter: Andrey Novikov KeysTrackingConfigurationVisitor#validate looks incorrect {code:java} if (val == null) { String message = "'" + (currentKey() + fieldName) + "' configuration value is not initialized."; issues.add(new ValidationIssue(currentKey(), message)); return; } {code} It throw exception which contains section and full field name in error message: {noformat} Validation did not pass for keys: [test.providers.basic., 'test.providers.basic.secret' configuration value is not initialized.] {noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (IGNITE-20882) Append performance tests
[ https://issues.apache.org/jira/browse/IGNITE-20882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800470#comment-17800470 ] Andrey Novikov edited comment on IGNITE-20882 at 2/12/24 10:34 AM: --- Single-node embedded (CriteriaEmbeddedNodeBenchmark): ||Benchmark||Score(us/op)|| |criteriaGet|114,135 ± 1,129| |kvGet|72,062 ± 0,309| |sqlGet|105,260 ± 0,521| Two nodes, thin client(CriteriaThinClientBenchmark): ||Benchmark||Score(us/op)|| |criteriaGet|1780,171 ± 35,306| |kvGet|251,105 ± 8,618| |sqlGet|2694,740 ± 72,396| |criteriaGetNonNullTxDisablesPartitionAwareness|2935,503 ± 192,479| |kvGetNonNullTxDisablesPartitionAwareness|352,037 ± 7,819| |sqlGetNonNullTxDisablesPartitionAwareness|2814,066 ± 88,770| |sqlIterate|1603991,380 ± 12153,762| |criteriaIterate|1501173,640 ± 31600,562| was (Author: anovikov): Single-node embedded (CriteriaSingleNodeBenchmark): ||Benchmark||Score(us/op)|| |criteriaGet|1780,171 ± 35,306| |kvGet|121,114 ± 1,726| |sqlGet|1703,928 ± 34,945| Two nodes, thin client(CriteriaThinClientBenchmark): ||Benchmark||Score(us/op)|| |criteriaGet|1780,171 ± 35,306| |kvGet|251,105 ± 8,618| |sqlGet|2694,740 ± 72,396| |criteriaGetNonNullTxDisablesPartitionAwareness|2935,503 ± 192,479| |kvGetNonNullTxDisablesPartitionAwareness|352,037 ± 7,819| |sqlGetNonNullTxDisablesPartitionAwareness|2814,066 ± 88,770| |sqlIterate|1603991,380 ± 12153,762| |criteriaIterate|1501173,640 ± 31600,562| > Append performance tests > > > Key: IGNITE-20882 > URL: https://issues.apache.org/jira/browse/IGNITE-20882 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Labels: ignite-3 > Fix For: 3.0.0-beta2 > > Time Spent: 20m > Remaining Estimate: 0h > > # Compare single-key criteria vs single-key SQL vs table.get(PK) > * Expect to have similar performance > * Check single-node embedded, distributed with no partition awareness, > distributed with partition awareness > * NOTE: future improvement for criteria query – lookup affinity node if PK > or colocation key is in the criteria. > # Compare criteria vs SQL when affinity key is specified (unicast when > partition pruning is added) > # Compare criteria vs SQL for broadcast queries – latency and throughput > # Compare criteria vs SQL – time it takes to iterate over 10kk entries -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (IGNITE-21453) Fix force index hint test
[ https://issues.apache.org/jira/browse/IGNITE-21453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov reassigned IGNITE-21453: --- Assignee: Andrey Novikov > Fix force index hint test > - > > Key: IGNITE-21453 > URL: https://issues.apache.org/jira/browse/IGNITE-21453 > Project: Ignite > Issue Type: Bug > Components: sql >Reporter: Vadim Pakhnushev >Assignee: Andrey Novikov >Priority: Major > Labels: ignite-3 > > Test in the ForceIndexHintPlannerTest that verify a particular type of > relational operator doesn't always work, apparently the planner finds cheaper > index scan instead of the table scan. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-21416) Add documentation for FORCE_INDEX/NO_INDEX hints
[ https://issues.apache.org/jira/browse/IGNITE-21416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-21416: Description: Globally it works the same way as in [https://ignite.apache.org/docs/latest/SQL/sql-calcite#force_index-no_index], but has some difference when FORCE_INDEX and NO_INDEX used together in the same query. When both hints reference to the same index - it is invalid case. SQL is declarative language and we shouldn't expect {{hints}} collection is ordered: {code:java} SELECT /*+ FORCE_INDEX(IDX_ID), NO_INDEX */ * FROM TBL1 WHERE id = ? AND val = ? OR SELECT /*+ NO_INDEX(IDX_VAL), FORCE_INDEX(IDX_VAL) */ * FROM TBL1 WHERE val = ?{code} *What to do* We need to fix example section and rewrite "Hint Scope" section. was: Globally it works the same way as in [https://ignite.apache.org/docs/latest/SQL/sql-calcite#force_index-no_index], but has some difference when FORCE_INDEX and NO_INDEX used together in the same query. When both hints reference to the same index - it is invalid case. SQL is declarative language and we shouldn't expect {{hints}} collection is ordered:}}{}}} {code:java} SELECT /*+ FORCE_INDEX(IDX_ID), NO_INDEX */ * FROM TBL1 WHERE id = ? AND val = ? OR SELECT /*+ NO_INDEX(IDX_VAL), FORCE_INDEX(IDX_VAL) */ * FROM TBL1 WHERE val = ?{code} *What to do* We need to fix example section and rewrite "Hint Scope" section. > Add documentation for FORCE_INDEX/NO_INDEX hints > > > Key: IGNITE-21416 > URL: https://issues.apache.org/jira/browse/IGNITE-21416 > Project: Ignite > Issue Type: Improvement > Components: documentation, sql >Reporter: Andrey Novikov >Priority: Minor > Labels: ignite-3 > > Globally it works the same way as in > [https://ignite.apache.org/docs/latest/SQL/sql-calcite#force_index-no_index], > but has some difference when FORCE_INDEX and NO_INDEX used together in the > same query. > When both hints reference to the same index - it is invalid case. SQL is > declarative language and we shouldn't expect {{hints}} collection is ordered: > {code:java} > SELECT /*+ FORCE_INDEX(IDX_ID), NO_INDEX */ * FROM TBL1 WHERE id = ? AND val > = ? > OR > SELECT /*+ NO_INDEX(IDX_VAL), FORCE_INDEX(IDX_VAL) */ * FROM TBL1 WHERE val = > ?{code} > > *What to do* > We need to fix example section and rewrite "Hint Scope" section. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-21416) Add documentation for FORCE_INDEX/NO_INDEX hints
[ https://issues.apache.org/jira/browse/IGNITE-21416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-21416: Description: Globally it works the same way as in [https://ignite.apache.org/docs/latest/SQL/sql-calcite#force_index-no_index], but has some difference when FORCE_INDEX and NO_INDEX used together in the same query. When both hints reference to the same index - it is invalid case. SQL is declarative language and we shouldn't expect {{hints}} collection is ordered:{{{}{}}} {code:java} {code} {{SELECT /*+ FORCE_INDEX(IDX_ID), NO_INDEX */ * FROM TBL1 WHERE id = ? AND val = ?}} {{OR}} {{SELECT /*+ NO_INDEX(IDX_VAL), FORCE_INDEX(IDX_VAL) */ * FROM TBL1 WHERE val = ?}} *What to do* We need to fix example section and rewrite "Hint Scope" section. was: Globally it works the same way as in [https://ignite.apache.org/docs/latest/SQL/sql-calcite#force_index-no_index], but has some difference when FORCE_INDEX and NO_INDEX used together in the same query. When both hints reference to the same index {{SELECT /*+ FORCE_INDEX('idx'), NOINDEX *{*}/,{*} SELECT /*+ NO_INDEX(TBL1_IDX2), FORCE_INDEX(TBL2_IDX2) */, ...}} - it is invalid case. SQL is declarative language and we shouldn't expect {{hints}} collection is ordered. We need to fix example section and rewrite "Hint Scope" section. > Add documentation for FORCE_INDEX/NO_INDEX hints > > > Key: IGNITE-21416 > URL: https://issues.apache.org/jira/browse/IGNITE-21416 > Project: Ignite > Issue Type: Improvement > Components: documentation, sql >Reporter: Andrey Novikov >Priority: Minor > Labels: ignite-3 > > Globally it works the same way as in > [https://ignite.apache.org/docs/latest/SQL/sql-calcite#force_index-no_index], > but has some difference when FORCE_INDEX and NO_INDEX used together in the > same query. > When both hints reference to the same index - it is invalid case. SQL is > declarative language and we shouldn't expect {{hints}} collection is > ordered:{{{}{}}} > {code:java} > {code} > {{SELECT /*+ FORCE_INDEX(IDX_ID), NO_INDEX */ * FROM TBL1 WHERE id = ? AND > val = ?}} > {{OR}} > {{SELECT /*+ NO_INDEX(IDX_VAL), FORCE_INDEX(IDX_VAL) */ * FROM TBL1 WHERE val > = ?}} > > > *What to do* > We need to fix example section and rewrite "Hint Scope" section. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-21416) Add documentation for FORCE_INDEX/NO_INDEX hints
[ https://issues.apache.org/jira/browse/IGNITE-21416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-21416: Description: Globally it works the same way as in [https://ignite.apache.org/docs/latest/SQL/sql-calcite#force_index-no_index], but has some difference when FORCE_INDEX and NO_INDEX used together in the same query. When both hints reference to the same index - it is invalid case. SQL is declarative language and we shouldn't expect {{hints}} collection is ordered:}}{}}} {code:java} SELECT /*+ FORCE_INDEX(IDX_ID), NO_INDEX */ * FROM TBL1 WHERE id = ? AND val = ? OR SELECT /*+ NO_INDEX(IDX_VAL), FORCE_INDEX(IDX_VAL) */ * FROM TBL1 WHERE val = ?{code} *What to do* We need to fix example section and rewrite "Hint Scope" section. was: Globally it works the same way as in [https://ignite.apache.org/docs/latest/SQL/sql-calcite#force_index-no_index], but has some difference when FORCE_INDEX and NO_INDEX used together in the same query. When both hints reference to the same index - it is invalid case. SQL is declarative language and we shouldn't expect {{hints}} collection is ordered:{{{}{}}} {code:java} {code} {{SELECT /*+ FORCE_INDEX(IDX_ID), NO_INDEX */ * FROM TBL1 WHERE id = ? AND val = ?}} {{OR}} {{SELECT /*+ NO_INDEX(IDX_VAL), FORCE_INDEX(IDX_VAL) */ * FROM TBL1 WHERE val = ?}} *What to do* We need to fix example section and rewrite "Hint Scope" section. > Add documentation for FORCE_INDEX/NO_INDEX hints > > > Key: IGNITE-21416 > URL: https://issues.apache.org/jira/browse/IGNITE-21416 > Project: Ignite > Issue Type: Improvement > Components: documentation, sql >Reporter: Andrey Novikov >Priority: Minor > Labels: ignite-3 > > Globally it works the same way as in > [https://ignite.apache.org/docs/latest/SQL/sql-calcite#force_index-no_index], > but has some difference when FORCE_INDEX and NO_INDEX used together in the > same query. > When both hints reference to the same index - it is invalid case. SQL is > declarative language and we shouldn't expect {{hints}} collection is > ordered:}}{}}} > {code:java} > SELECT /*+ FORCE_INDEX(IDX_ID), NO_INDEX */ * FROM TBL1 WHERE id = ? AND val > = ? > OR > SELECT /*+ NO_INDEX(IDX_VAL), FORCE_INDEX(IDX_VAL) */ * FROM TBL1 WHERE val = > ?{code} > > *What to do* > We need to fix example section and rewrite "Hint Scope" section. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-21416) Add documentation for FORCE_INDEX/NO_INDEX hints
[ https://issues.apache.org/jira/browse/IGNITE-21416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-21416: Description: Globally it works the same way as in [https://ignite.apache.org/docs/latest/SQL/sql-calcite#force_index-no_index], but has some difference when FORCE_INDEX and NO_INDEX used together in the same query. When both hints reference to the same index {{SELECT /*+ FORCE_INDEX('idx'), NOINDEX *{*}/,{*} SELECT /*+ NO_INDEX(TBL1_IDX2), FORCE_INDEX(TBL2_IDX2) */, ...}} - it is invalid case. SQL is declarative language and we shouldn't expect {{hints}} collection is ordered. We need to fix example section and rewrite "Hint Scope" section. was: Globally it works the same way as in [https://ignite.apache.org/docs/latest/SQL/sql-calcite#force_index-no_index], but has some difference when FORCE_INDEX and NO_INDEX used together in the same query. When both hints reference to the same index {{SELECT /+ FORCE_INDEX('idx'), NOINDEX */, {{SELECT \{*}/{*}+ NO_INDEX(TBL1_IDX2), FORCE_INDEX(TBL2_IDX2) */, ...}} -}} it is invalid case. SQL is declarative language and we shouldn't expect {{hints}} collection is ordered. We need to fix example section and rewrite "Hint Scope" section. > Add documentation for FORCE_INDEX/NO_INDEX hints > > > Key: IGNITE-21416 > URL: https://issues.apache.org/jira/browse/IGNITE-21416 > Project: Ignite > Issue Type: Improvement > Components: documentation, sql >Reporter: Andrey Novikov >Priority: Minor > Labels: ignite-3 > > Globally it works the same way as in > [https://ignite.apache.org/docs/latest/SQL/sql-calcite#force_index-no_index], > but has some difference when FORCE_INDEX and NO_INDEX used together in the > same query. When both hints reference to the same index {{SELECT /*+ > FORCE_INDEX('idx'), NOINDEX *{*}/,{*} SELECT /*+ NO_INDEX(TBL1_IDX2), > FORCE_INDEX(TBL2_IDX2) */, ...}} - it is invalid case. SQL is declarative > language and we shouldn't expect {{hints}} collection is ordered. > We need to fix example section and rewrite "Hint Scope" section. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-21416) Add documentation for FORCE_INDEX/NO_INDEX hints
[ https://issues.apache.org/jira/browse/IGNITE-21416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-21416: Priority: Minor (was: Major) > Add documentation for FORCE_INDEX/NO_INDEX hints > > > Key: IGNITE-21416 > URL: https://issues.apache.org/jira/browse/IGNITE-21416 > Project: Ignite > Issue Type: Improvement > Components: documentation, sql >Reporter: Andrey Novikov >Priority: Minor > Labels: ignite-3 > > Globally it works the same way as in > [https://ignite.apache.org/docs/latest/SQL/sql-calcite#force_index-no_index], > but has some difference when FORCE_INDEX and NO_INDEX used together in the > same query. When both hints reference to the same index {{SELECT /+ > FORCE_INDEX('idx'), NOINDEX */, {{SELECT \{*}/{*}+ NO_INDEX(TBL1_IDX2), > FORCE_INDEX(TBL2_IDX2) */, ...}} -}} it is invalid case. SQL is declarative > language and we shouldn't expect {{hints}} collection is ordered. > We need to fix example section and rewrite "Hint Scope" section. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-21416) Add documentation for FORCE_INDEX/NO_INDEX hints
[ https://issues.apache.org/jira/browse/IGNITE-21416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-21416: Component/s: sql > Add documentation for FORCE_INDEX/NO_INDEX hints > > > Key: IGNITE-21416 > URL: https://issues.apache.org/jira/browse/IGNITE-21416 > Project: Ignite > Issue Type: Improvement > Components: documentation, sql >Reporter: Andrey Novikov >Priority: Major > Labels: ignite-3 > > Globally it works the same way as in > [https://ignite.apache.org/docs/latest/SQL/sql-calcite#force_index-no_index], > but has some difference when FORCE_INDEX and NO_INDEX used together in the > same query. When both hints reference to the same index {{SELECT /+ > FORCE_INDEX('idx'), NOINDEX */, {{SELECT \{*}/{*}+ NO_INDEX(TBL1_IDX2), > FORCE_INDEX(TBL2_IDX2) */, ...}} -}} it is invalid case. SQL is declarative > language and we shouldn't expect {{hints}} collection is ordered. > We need to fix example section and rewrite "Hint Scope" section. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-21416) Add documentation for FORCE_INDEX/NO_INDEX hints
[ https://issues.apache.org/jira/browse/IGNITE-21416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-21416: Labels: ignite-3 (was: ) > Add documentation for FORCE_INDEX/NO_INDEX hints > > > Key: IGNITE-21416 > URL: https://issues.apache.org/jira/browse/IGNITE-21416 > Project: Ignite > Issue Type: Improvement > Components: documentation >Reporter: Andrey Novikov >Priority: Major > Labels: ignite-3 > > Globally it works the same way as in > [https://ignite.apache.org/docs/latest/SQL/sql-calcite#force_index-no_index], > but has some difference when FORCE_INDEX and NO_INDEX used together in the > same query. When both hints reference to the same index {{SELECT /+ > FORCE_INDEX('idx'), NOINDEX */, {{SELECT \{*}/{*}+ NO_INDEX(TBL1_IDX2), > FORCE_INDEX(TBL2_IDX2) */, ...}} -}} it is invalid case. SQL is declarative > language and we shouldn't expect {{hints}} collection is ordered. > We need to fix example section and rewrite "Hint Scope" section. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-21416) Add documentation for FORCE_INDEX/NO_INDEX hints
[ https://issues.apache.org/jira/browse/IGNITE-21416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-21416: Description: Globally it works the same way as in [https://ignite.apache.org/docs/latest/SQL/sql-calcite#force_index-no_index], but has some difference when FORCE_INDEX and NO_INDEX used together in the same query. When both hints reference to the same index {{SELECT /+ FORCE_INDEX('idx'), NOINDEX */, {{SELECT \{*}/{*}+ NO_INDEX(TBL1_IDX2), FORCE_INDEX(TBL2_IDX2) */, ...}} -}} it is invalid case. SQL is declarative language and we shouldn't expect {{hints}} collection is ordered. We need to fix example section and rewrite "Hint Scope" section. was: Globally it works the same way as in [https://ignite.apache.org/docs/latest/SQL/sql-calcite#force_index-no_index], but has some difference when FORCE_INDEX and NO_INDEX used together in the same query. When both hints reference to the same index {{SELECT /*+ FORCE_INDEX('idx'), NOINDEX */, {{SELECT /*+ NO_INDEX(TBL1_IDX2), FORCE_INDEX(TBL2_IDX2) */, ...}} -}} it is invalid case. SQL is declarative language and we shouldn't expect {{hints}} collection is ordered. We need to fix example section and rewrite "Hint Scope" section. > Add documentation for FORCE_INDEX/NO_INDEX hints > > > Key: IGNITE-21416 > URL: https://issues.apache.org/jira/browse/IGNITE-21416 > Project: Ignite > Issue Type: Improvement > Components: documentation >Reporter: Andrey Novikov >Priority: Major > > Globally it works the same way as in > [https://ignite.apache.org/docs/latest/SQL/sql-calcite#force_index-no_index], > but has some difference when FORCE_INDEX and NO_INDEX used together in the > same query. When both hints reference to the same index {{SELECT /+ > FORCE_INDEX('idx'), NOINDEX */, {{SELECT \{*}/{*}+ NO_INDEX(TBL1_IDX2), > FORCE_INDEX(TBL2_IDX2) */, ...}} -}} it is invalid case. SQL is declarative > language and we shouldn't expect {{hints}} collection is ordered. > We need to fix example section and rewrite "Hint Scope" section. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IGNITE-21416) Add documentation for FORCE_INDEX/NO_INDEX hints
Andrey Novikov created IGNITE-21416: --- Summary: Add documentation for FORCE_INDEX/NO_INDEX hints Key: IGNITE-21416 URL: https://issues.apache.org/jira/browse/IGNITE-21416 Project: Ignite Issue Type: Improvement Components: documentation Reporter: Andrey Novikov Globally it works the same way as in [https://ignite.apache.org/docs/latest/SQL/sql-calcite#force_index-no_index], but has some difference when FORCE_INDEX and NO_INDEX used together in the same query. When both hints reference to the same index {{SELECT /*+ FORCE_INDEX('idx'), NOINDEX */, {{SELECT /*+ NO_INDEX(TBL1_IDX2), FORCE_INDEX(TBL2_IDX2) */, ...}} -}} it is invalid case. SQL is declarative language and we shouldn't expect {{hints}} collection is ordered. We need to fix example section and rewrite "Hint Scope" section. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-21404) Do not wrap SqlException into RuntimeException for PlannerHelper.optimize
[ https://issues.apache.org/jira/browse/IGNITE-21404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-21404: Labels: ignite-3 (was: ) > Do not wrap SqlException into RuntimeException for PlannerHelper.optimize > - > > Key: IGNITE-21404 > URL: https://issues.apache.org/jira/browse/IGNITE-21404 > Project: Ignite > Issue Type: Improvement > Components: jdbc, sql >Affects Versions: 3.0.0-beta1 >Reporter: Andrey Novikov >Priority: Minor > Labels: ignite-3 > > VolcanoRuleCall.java:250 wrap any exception into RuntimeException, so it can > break UX for public API as the actual exception will be in cause > > {code:java} > Caused by: java.lang.RuntimeException: Error while applying rule > ExposeIndexRule, args > [rel#27:IgniteLogicalTableScan.NONE.[].any(table=[PUBLIC, > TBL1],filters=AND(=($t2, _UTF-8'v'), =($t3, _UTF-8'v')),requiredColumns={0, > 1, 2, 3})] > at > org.apache.calcite.plan.volcano.VolcanoRuleCall.onMatch(VolcanoRuleCall.java:250) > at > org.apache.calcite.plan.volcano.TopDownRuleDriver.applyGenerator(TopDownRuleDriver.java:151) > at > org.apache.calcite.plan.volcano.TopDownRuleDriver.access$600(TopDownRuleDriver.java:51) > at > org.apache.calcite.plan.volcano.TopDownRuleDriver$ApplyRule.perform(TopDownRuleDriver.java:532) > at > org.apache.calcite.plan.volcano.TopDownRuleDriver.drive(TopDownRuleDriver.java:109) > at > org.apache.calcite.plan.volcano.VolcanoPlanner.findBestExp(VolcanoPlanner.java:524) > at > org.apache.calcite.tools.Programs$RuleSetProgram.run(Programs.java:328) > at > org.apache.ignite.internal.sql.engine.prepare.IgnitePlanner.transform(IgnitePlanner.java:386) > at > org.apache.ignite.internal.sql.engine.prepare.PlannerHelper.optimize(PlannerHelper.java:125) > at > org.apache.ignite.internal.sql.engine.planner.AbstractPlannerTest.physicalPlan(AbstractPlannerTest.java:384) > at > org.apache.ignite.internal.sql.engine.planner.AbstractPlannerTest.physicalPlan(AbstractPlannerTest.java:372) > at > org.apache.ignite.internal.sql.engine.planner.AbstractPlannerTest.physicalPlan(AbstractPlannerTest.java:356) > at > org.apache.ignite.internal.sql.engine.planner.AbstractPlannerTest.physicalPlan(AbstractPlannerTest.java:344) > at > org.apache.ignite.internal.sql.engine.planner.AbstractPlannerTest.physicalPlan(AbstractPlannerTest.java:333) > at > org.apache.ignite.internal.sql.engine.planner.hints.ForceIndexHintPlannerTest.lambda$testWithMultipleIndexHints$0(ForceIndexHintPlannerTest.java:137) > at > org.apache.ignite.internal.testframework.IgniteTestUtils.assertThrowsWithCause(IgniteTestUtils.java:313) > {code} > h3. Steps to reproduce > > Replace > IgniteTestUtils.assertThrowsWithCause to assertThrowsSqlException > For tests: > HashIndexPlannerTest#testHashIndexIsNotAppliedWithoutConditions, > HashIndexPlannerTest#hashIndexIsNotAppliedForRangeCondition > > Expected that SqlException will be thrown, not RuntimeException with > SqlException as cause -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IGNITE-21404) Do not wrap SqlException into RuntimeException for PlannerHelper.optimize
Andrey Novikov created IGNITE-21404: --- Summary: Do not wrap SqlException into RuntimeException for PlannerHelper.optimize Key: IGNITE-21404 URL: https://issues.apache.org/jira/browse/IGNITE-21404 Project: Ignite Issue Type: Improvement Components: jdbc, sql Affects Versions: 3.0.0-beta1 Reporter: Andrey Novikov VolcanoRuleCall.java:250 wrap any exception into RuntimeException, so it can break UX for public API as the actual exception will be in cause {code:java} Caused by: java.lang.RuntimeException: Error while applying rule ExposeIndexRule, args [rel#27:IgniteLogicalTableScan.NONE.[].any(table=[PUBLIC, TBL1],filters=AND(=($t2, _UTF-8'v'), =($t3, _UTF-8'v')),requiredColumns={0, 1, 2, 3})] at org.apache.calcite.plan.volcano.VolcanoRuleCall.onMatch(VolcanoRuleCall.java:250) at org.apache.calcite.plan.volcano.TopDownRuleDriver.applyGenerator(TopDownRuleDriver.java:151) at org.apache.calcite.plan.volcano.TopDownRuleDriver.access$600(TopDownRuleDriver.java:51) at org.apache.calcite.plan.volcano.TopDownRuleDriver$ApplyRule.perform(TopDownRuleDriver.java:532) at org.apache.calcite.plan.volcano.TopDownRuleDriver.drive(TopDownRuleDriver.java:109) at org.apache.calcite.plan.volcano.VolcanoPlanner.findBestExp(VolcanoPlanner.java:524) at org.apache.calcite.tools.Programs$RuleSetProgram.run(Programs.java:328) at org.apache.ignite.internal.sql.engine.prepare.IgnitePlanner.transform(IgnitePlanner.java:386) at org.apache.ignite.internal.sql.engine.prepare.PlannerHelper.optimize(PlannerHelper.java:125) at org.apache.ignite.internal.sql.engine.planner.AbstractPlannerTest.physicalPlan(AbstractPlannerTest.java:384) at org.apache.ignite.internal.sql.engine.planner.AbstractPlannerTest.physicalPlan(AbstractPlannerTest.java:372) at org.apache.ignite.internal.sql.engine.planner.AbstractPlannerTest.physicalPlan(AbstractPlannerTest.java:356) at org.apache.ignite.internal.sql.engine.planner.AbstractPlannerTest.physicalPlan(AbstractPlannerTest.java:344) at org.apache.ignite.internal.sql.engine.planner.AbstractPlannerTest.physicalPlan(AbstractPlannerTest.java:333) at org.apache.ignite.internal.sql.engine.planner.hints.ForceIndexHintPlannerTest.lambda$testWithMultipleIndexHints$0(ForceIndexHintPlannerTest.java:137) at org.apache.ignite.internal.testframework.IgniteTestUtils.assertThrowsWithCause(IgniteTestUtils.java:313) {code} h3. Steps to reproduce Replace IgniteTestUtils.assertThrowsWithCause to assertThrowsSqlException For tests: HashIndexPlannerTest#testHashIndexIsNotAppliedWithoutConditions, HashIndexPlannerTest#hashIndexIsNotAppliedForRangeCondition Expected that SqlException will be thrown, not RuntimeException with SqlException as cause -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (IGNITE-20882) Append performance tests
[ https://issues.apache.org/jira/browse/IGNITE-20882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800470#comment-17800470 ] Andrey Novikov edited comment on IGNITE-20882 at 1/24/24 8:28 AM: -- Single-node embedded (CriteriaSingleNodeBenchmark): ||Benchmark||Score(us/op)|| |criteriaGet|1780,171 ± 35,306| |kvGet|121,114 ± 1,726| |sqlGet|1703,928 ± 34,945| Two nodes, thin client(CriteriaThinClientBenchmark): ||Benchmark||Score(us/op)|| |criteriaGet|1780,171 ± 35,306| |kvGet|251,105 ± 8,618| |sqlGet|2694,740 ± 72,396| |criteriaGetNonNullTxDisablesPartitionAwareness|2935,503 ± 192,479| |kvGetNonNullTxDisablesPartitionAwareness|352,037 ± 7,819| |sqlGetNonNullTxDisablesPartitionAwareness|2814,066 ± 88,770| |sqlIterate|1603991,380 ± 12153,762| |criteriaIterate|1501173,640 ± 31600,562| was (Author: anovikov): Single-node embedded: ||Benchmark||Score(us/op)|| |CriteriaSingleNodeBenchmark.criteriaGet|1780,171 ± 35,306| |CriteriaSingleNodeBenchmark.kvGet|121,114 ± 1,726| |CriteriaSingleNodeBenchmark.sqlGet|1703,928 ± 34,945| > Append performance tests > > > Key: IGNITE-20882 > URL: https://issues.apache.org/jira/browse/IGNITE-20882 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Labels: ignite-3 > Time Spent: 10m > Remaining Estimate: 0h > > # Compare single-key criteria vs single-key SQL vs table.get(PK) > * Expect to have similar performance > * Check single-node embedded, distributed with no partition awareness, > distributed with partition awareness > * NOTE: future improvement for criteria query – lookup affinity node if PK > or colocation key is in the criteria. > # Compare criteria vs SQL when affinity key is specified (unicast when > partition pruning is added) > # Compare criteria vs SQL for broadcast queries – latency and throughput > # Compare criteria vs SQL – time it takes to iterate over 10kk entries -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (IGNITE-21278) Add FORCE_INDEX/NO_INDEX hints for calcite engine
[ https://issues.apache.org/jira/browse/IGNITE-21278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov reassigned IGNITE-21278: --- Assignee: Andrey Novikov > Add FORCE_INDEX/NO_INDEX hints for calcite engine > - > > Key: IGNITE-21278 > URL: https://issues.apache.org/jira/browse/IGNITE-21278 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Labels: ignite-3 > > As part of hints for Calcite, we could try to implement simple hint like > FORCE_INDEX/NO_INDEX. > As reference ignite 2.x documentation can be used > [https://ignite.apache.org/docs/latest/SQL/sql-calcite#force_index-no_index] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-21278) Add FORCE_INDEX/NO_INDEX hints for calcite engine
[ https://issues.apache.org/jira/browse/IGNITE-21278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-21278: Description: As part of hints for Calcite, we could try to implement simple hint like FORCE_INDEX/NO_INDEX. As reference ignite 2.x documentation can be used [https://ignite.apache.org/docs/latest/SQL/sql-calcite#force_index-no_index] was:As part of hints for Calcite, we could try to implement simple hint like FORCE_INDEX/NO_INDEX. > Add FORCE_INDEX/NO_INDEX hints for calcite engine > - > > Key: IGNITE-21278 > URL: https://issues.apache.org/jira/browse/IGNITE-21278 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Andrey Novikov >Priority: Major > Labels: ignite-3 > > As part of hints for Calcite, we could try to implement simple hint like > FORCE_INDEX/NO_INDEX. > As reference ignite 2.x documentation can be used > [https://ignite.apache.org/docs/latest/SQL/sql-calcite#force_index-no_index] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-21278) Add FORCE_INDEX/NO_INDEX hints for calcite engine
[ https://issues.apache.org/jira/browse/IGNITE-21278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-21278: Labels: ignite-3 (was: ) > Add FORCE_INDEX/NO_INDEX hints for calcite engine > - > > Key: IGNITE-21278 > URL: https://issues.apache.org/jira/browse/IGNITE-21278 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Andrey Novikov >Priority: Major > Labels: ignite-3 > > As part of hints for Calcite, we could try to implement simple hint like > FORCE_INDEX/NO_INDEX. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IGNITE-21278) Add FORCE_INDEX/NO_INDEX hints for calcite engine
Andrey Novikov created IGNITE-21278: --- Summary: Add FORCE_INDEX/NO_INDEX hints for calcite engine Key: IGNITE-21278 URL: https://issues.apache.org/jira/browse/IGNITE-21278 Project: Ignite Issue Type: Improvement Components: sql Reporter: Andrey Novikov As part of hints for Calcite, we could try to implement simple hint like FORCE_INDEX/NO_INDEX. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-20881) Add ability to enforce an index to be used
[ https://issues.apache.org/jira/browse/IGNITE-20881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-20881: Description: *What to do:* * Extend criteria api with index hint * Generate SQL with hint * Add a test that verifies that the passed index is used in the query As reference ignite 2.x implementation can be used [https://ignite.apache.org/docs/latest/SQL/sql-calcite#force_index-no_index] > Add ability to enforce an index to be used > -- > > Key: IGNITE-20881 > URL: https://issues.apache.org/jira/browse/IGNITE-20881 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Labels: ignite-3 > > *What to do:* > * Extend criteria api with index hint > * Generate SQL with hint > * Add a test that verifies that the passed index is used in the query > As reference ignite 2.x implementation can be used > [https://ignite.apache.org/docs/latest/SQL/sql-calcite#force_index-no_index] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-20881) Add ability to enforce an index to be used
[ https://issues.apache.org/jira/browse/IGNITE-20881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-20881: Description: *What to do:* * Extend criteria api with index hint * Generate SQL with hint * Add a test that verifies that the passed index is used in the query As reference ignite 2.x documentation can be used [https://ignite.apache.org/docs/latest/SQL/sql-calcite#force_index-no_index] was: *What to do:* * Extend criteria api with index hint * Generate SQL with hint * Add a test that verifies that the passed index is used in the query As reference ignite 2.x implementation can be used [https://ignite.apache.org/docs/latest/SQL/sql-calcite#force_index-no_index] > Add ability to enforce an index to be used > -- > > Key: IGNITE-20881 > URL: https://issues.apache.org/jira/browse/IGNITE-20881 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Labels: ignite-3 > > *What to do:* > * Extend criteria api with index hint > * Generate SQL with hint > * Add a test that verifies that the passed index is used in the query > As reference ignite 2.x documentation can be used > [https://ignite.apache.org/docs/latest/SQL/sql-calcite#force_index-no_index] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-20878) Basic criteria queries for record view
[ https://issues.apache.org/jira/browse/IGNITE-20878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-20878: Fix Version/s: 3.0.0-beta2 > Basic criteria queries for record view > -- > > Key: IGNITE-20878 > URL: https://issues.apache.org/jira/browse/IGNITE-20878 > Project: Ignite > Issue Type: New Feature > Components: sql >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Labels: ignite-3 > Fix For: 3.0.0-beta2 > > Time Spent: 18h 20m > Remaining Estimate: 0h > > Implement basic criteria query for record view. > The only field in {{CreteriaQueryOptions}} should be {{{}pageSize{}}}. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-20882) Append performance tests
[ https://issues.apache.org/jira/browse/IGNITE-20882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800470#comment-17800470 ] Andrey Novikov commented on IGNITE-20882: - Single-node embedded: ||Benchmark||Score(us/op)|| |CriteriaSingleNodeBenchmark.criteriaGet|1780,171 ± 35,306| |CriteriaSingleNodeBenchmark.kvGet|121,114 ± 1,726| |CriteriaSingleNodeBenchmark.sqlGet|1703,928 ± 34,945| > Append performance tests > > > Key: IGNITE-20882 > URL: https://issues.apache.org/jira/browse/IGNITE-20882 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Labels: ignite-3 > > # Compare single-key criteria vs single-key SQL vs table.get(PK) > * Expect to have similar performance > * Check single-node embedded, distributed with no partition awareness, > distributed with partition awareness > * NOTE: future improvement for criteria query – lookup affinity node if PK > or colocation key is in the criteria. > # Compare criteria vs SQL when affinity key is specified (unicast when > partition pruning is added) > # Compare criteria vs SQL for broadcast queries – latency and throughput > # Compare criteria vs SQL – time it takes to iterate over 10kk entries -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (IGNITE-21146) Error handling in Criteria queries
[ https://issues.apache.org/jira/browse/IGNITE-21146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov reassigned IGNITE-21146: --- Assignee: Andrey Novikov > Error handling in Criteria queries > -- > > Key: IGNITE-21146 > URL: https://issues.apache.org/jira/browse/IGNITE-21146 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Labels: ignite-3 > > Criteria query as a part of public Ignite API should throw only public > exceptions to end users that not depend from implementation. > *What to do:* > * add exception conversation from SqlException to public one > * add tests to check exceptions along with error messages, groups, codes -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-21146) Error handling in Criteria queries
[ https://issues.apache.org/jira/browse/IGNITE-21146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-21146: Labels: ignite-3 (was: ) > Error handling in Criteria queries > -- > > Key: IGNITE-21146 > URL: https://issues.apache.org/jira/browse/IGNITE-21146 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Andrey Novikov >Priority: Major > Labels: ignite-3 > > Criteria query as a part of public Ignite API should throw only public > exceptions to end users that not depend from implementation. > *What to do:* > * add exception conversation from SqlException to public one > * add tests to check exceptions along with error messages, groups, codes -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IGNITE-21146) Error handling in Criteria queries
Andrey Novikov created IGNITE-21146: --- Summary: Error handling in Criteria queries Key: IGNITE-21146 URL: https://issues.apache.org/jira/browse/IGNITE-21146 Project: Ignite Issue Type: Improvement Components: sql Reporter: Andrey Novikov Criteria query as a part of public Ignite API should throw only public exceptions to end users that not depend from implementation. *What to do:* * add exception conversation from SqlException to public one * add tests to check exceptions along with error messages, groups, codes -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-20878) Basic criteria queries for record view
[ https://issues.apache.org/jira/browse/IGNITE-20878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-20878: Description: Implement basic criteria query for record view. The only field in {{CreteriaQueryOptions}} should be {{{}pageSize{}}}. was: Implement basic criteria query for record view. The only field in {{CreteriaQueryOptions}} should be {{{}pageSize{}}}. Criteria to implement: equals > Basic criteria queries for record view > -- > > Key: IGNITE-20878 > URL: https://issues.apache.org/jira/browse/IGNITE-20878 > Project: Ignite > Issue Type: New Feature > Components: sql >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Labels: ignite-3 > Time Spent: 4h 40m > Remaining Estimate: 0h > > Implement basic criteria query for record view. > The only field in {{CreteriaQueryOptions}} should be {{{}pageSize{}}}. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (IGNITE-20977) Basic criteria queries for keyValue view
[ https://issues.apache.org/jira/browse/IGNITE-20977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov reassigned IGNITE-20977: --- Assignee: Andrey Novikov > Basic criteria queries for keyValue view > > > Key: IGNITE-20977 > URL: https://issues.apache.org/jira/browse/IGNITE-20977 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Labels: ignite-3 > > Implement basic criteria query for keyValue view. > For binary view manually map SqlRow to Entry using a schema, > e.g. like {{RecordView.put()}} does. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-20977) Basic criteria queries for keyValue view
[ https://issues.apache.org/jira/browse/IGNITE-20977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-20977: Labels: ignite-3 (was: ) > Basic criteria queries for keyValue view > > > Key: IGNITE-20977 > URL: https://issues.apache.org/jira/browse/IGNITE-20977 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Andrey Novikov >Priority: Major > Labels: ignite-3 > > Implement basic criteria query for keyValue view. > For binary view manually map SqlRow to Entry using a schema, > e.g. like {{RecordView.put()}} does. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IGNITE-20977) Basic criteria queries for keyValue view
Andrey Novikov created IGNITE-20977: --- Summary: Basic criteria queries for keyValue view Key: IGNITE-20977 URL: https://issues.apache.org/jira/browse/IGNITE-20977 Project: Ignite Issue Type: Improvement Components: sql Reporter: Andrey Novikov Implement basic criteria query for keyValue view. For binary view manually map SqlRow to Entry using a schema, e.g. like {{RecordView.put()}} does. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-20878) Basic criteria queries for record view
[ https://issues.apache.org/jira/browse/IGNITE-20878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-20878: Summary: Basic criteria queries for record view (was: Basic criteria queries) > Basic criteria queries for record view > -- > > Key: IGNITE-20878 > URL: https://issues.apache.org/jira/browse/IGNITE-20878 > Project: Ignite > Issue Type: New Feature > Components: sql >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Labels: ignite-3 > Time Spent: 10m > Remaining Estimate: 0h > > Implement basic criteria query for record view. > The only field in {{CreteriaQueryOptions}} should be {{{}pageSize{}}}. > Criteria to implement: equals -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-20878) Basic criteria queries
[ https://issues.apache.org/jira/browse/IGNITE-20878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-20878: Description: Implement basic criteria query for record view. The only field in {{CreteriaQueryOptions}} should be {{{}pageSize{}}}. Criteria to implement: equals was: Implement basic criteria query. The only field in {{CreteriaQueryOptions}} should be {{{}pageSize{}}}. Criteria to implement: equals > Basic criteria queries > -- > > Key: IGNITE-20878 > URL: https://issues.apache.org/jira/browse/IGNITE-20878 > Project: Ignite > Issue Type: New Feature > Components: sql >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Labels: ignite-3 > Time Spent: 10m > Remaining Estimate: 0h > > Implement basic criteria query for record view. > The only field in {{CreteriaQueryOptions}} should be {{{}pageSize{}}}. > Criteria to implement: equals -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (IGNITE-20879) Additional criterions for queries
[ https://issues.apache.org/jira/browse/IGNITE-20879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov reassigned IGNITE-20879: --- Assignee: Andrey Novikov > Additional criterions for queries > - > > Key: IGNITE-20879 > URL: https://issues.apache.org/jira/browse/IGNITE-20879 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Labels: ignite-3 > > Suggested Predicates List: > * Comparisons: >, <, >=, <=, IN > * Combination: AND, OR, NOT > * Nulls: IS NULL, IS NOT NULL -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (IGNITE-20881) Add ability to enforce an index to be used
[ https://issues.apache.org/jira/browse/IGNITE-20881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov reassigned IGNITE-20881: --- Assignee: Andrey Novikov > Add ability to enforce an index to be used > -- > > Key: IGNITE-20881 > URL: https://issues.apache.org/jira/browse/IGNITE-20881 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Labels: ignite-3 > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (IGNITE-20882) Append performance tests
[ https://issues.apache.org/jira/browse/IGNITE-20882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov reassigned IGNITE-20882: --- Assignee: Andrey Novikov > Append performance tests > > > Key: IGNITE-20882 > URL: https://issues.apache.org/jira/browse/IGNITE-20882 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Labels: ignite-3 > > # Compare single-key criteria vs single-key SQL vs table.get(PK) > * Expect to have similar performance > * Check single-node embedded, distributed with no partition awareness, > distributed with partition awareness > * NOTE: future improvement for criteria query – lookup affinity node if PK > or colocation key is in the criteria. > # Compare criteria vs SQL when affinity key is specified (unicast when > partition pruning is added) > # Compare criteria vs SQL for broadcast queries – latency and throughput > # Compare criteria vs SQL – time it takes to iterate over 10kk entries -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (IGNITE-20878) Basic criteria queries
[ https://issues.apache.org/jira/browse/IGNITE-20878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov reassigned IGNITE-20878: --- Assignee: Andrey Novikov > Basic criteria queries > -- > > Key: IGNITE-20878 > URL: https://issues.apache.org/jira/browse/IGNITE-20878 > Project: Ignite > Issue Type: New Feature > Components: sql >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > > Implement basic criteria query. The only field in {{CreteriaQueryOptions}} > should be {{{}pageSize{}}}. > Criteria to implement: equals -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IGNITE-20882) Append performance tests
Andrey Novikov created IGNITE-20882: --- Summary: Append performance tests Key: IGNITE-20882 URL: https://issues.apache.org/jira/browse/IGNITE-20882 Project: Ignite Issue Type: Improvement Components: sql Reporter: Andrey Novikov # Compare single-key criteria vs single-key SQL vs table.get(PK) * Expect to have similar performance * Check single-node embedded, distributed with no partition awareness, distributed with partition awareness * NOTE: future improvement for criteria query – lookup affinity node if PK or colocation key is in the criteria. # Compare criteria vs SQL when affinity key is specified (unicast when partition pruning is added) # Compare criteria vs SQL for broadcast queries – latency and throughput # Compare criteria vs SQL – time it takes to iterate over 10kk entries -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IGNITE-20881) Add ability to enforce an index to be used
Andrey Novikov created IGNITE-20881: --- Summary: Add ability to enforce an index to be used Key: IGNITE-20881 URL: https://issues.apache.org/jira/browse/IGNITE-20881 Project: Ignite Issue Type: Improvement Components: sql Reporter: Andrey Novikov -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IGNITE-20879) Additional criterions for queries
Andrey Novikov created IGNITE-20879: --- Summary: Additional criterions for queries Key: IGNITE-20879 URL: https://issues.apache.org/jira/browse/IGNITE-20879 Project: Ignite Issue Type: Improvement Components: sql Reporter: Andrey Novikov Suggested Predicates List: * Comparisons: >, <, >=, <=, IN * Combination: AND, OR, NOT * Nulls: IS NULL, IS NOT NULL -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IGNITE-20878) Basic criteria queries
Andrey Novikov created IGNITE-20878: --- Summary: Basic criteria queries Key: IGNITE-20878 URL: https://issues.apache.org/jira/browse/IGNITE-20878 Project: Ignite Issue Type: New Feature Components: sql Reporter: Andrey Novikov Implement basic criteria query. The only field in {{CreteriaQueryOptions}} should be {{{}pageSize{}}}. Criteria to implement: equals -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-20865) Ignite 3.0: Criteria API queries
[ https://issues.apache.org/jira/browse/IGNITE-20865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-20865: Labels: ignite-3 (was: ) > Ignite 3.0: Criteria API queries > > > Key: IGNITE-20865 > URL: https://issues.apache.org/jira/browse/IGNITE-20865 > Project: Ignite > Issue Type: Epic > Components: sql >Reporter: Andrey Novikov >Priority: Major > Labels: ignite-3 > > Criteria Query is logically just a facade for SQL – same way as Criteria API > is a facade for SQL in JPA. The easiest way to implement this feature then is > to just generate SQL queries. > There are different gateways to a table called Table Views. Currently we have > RecordView and KeyValueView. *Each view* should have the Criteria Query API. > The only difference is the type of objects the query result maps to. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IGNITE-20865) Ignite 3.0: Criteria API queries
Andrey Novikov created IGNITE-20865: --- Summary: Ignite 3.0: Criteria API queries Key: IGNITE-20865 URL: https://issues.apache.org/jira/browse/IGNITE-20865 Project: Ignite Issue Type: Epic Components: sql Reporter: Andrey Novikov Criteria Query is logically just a facade for SQL – same way as Criteria API is a facade for SQL in JPA. The easiest way to implement this feature then is to just generate SQL queries. There are different gateways to a table called Table Views. Currently we have RecordView and KeyValueView. *Each view* should have the Criteria Query API. The only difference is the type of objects the query result maps to. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-18302) ignite-spring-sessions: IgniteSession serialization drags its parent class
[ https://issues.apache.org/jira/browse/IGNITE-18302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-18302: Fix Version/s: (was: 2.16) > ignite-spring-sessions: IgniteSession serialization drags its parent class > -- > > Key: IGNITE-18302 > URL: https://issues.apache.org/jira/browse/IGNITE-18302 > Project: Ignite > Issue Type: Bug > Components: extensions >Affects Versions: 2.15 >Reporter: Alexandr Shapkin >Assignee: Andrey Novikov >Priority: Major > > In short, there is a bug in ignite-spring-session-ext implementation. > We store IgniteIndexedSessionRepository${{{}IgniteSession{}}} in the cache, > but it’s an internal non-static class, having a reference to the parent > [\{{{}IgniteIndexedSessionRepository{}}}] indirectly. > Hence, during the serialization Ignite also writes {{{}name=this$0, > type=Object, fieldId=0xCBDD23AA (-874699862){}}}, which is the reference to > {{{}IgniteIndexedSessionRepository{}}}. That leads to the following issues: > * we are serializing and saving internal utility data, like}} Ignite > ignite{}}}, {{private IndexResolver indexResolver}} etc > * one of the IgniteIndexedSessionRepository’s fields is IgniteCache itself - > {{IgniteCache sessions}} that basically keeps every > session so far leading to a StackOverflow error after some time. > > {code:java} > [2022-11-25T17:27:29,268][ERROR][sys-stripe-0-#1%USERS_IGNITE%][GridCacheIoManager] > Failed processing message [senderId=0f0ca915-d6cd-4580-92a3-1fbc3d2a5722, > msg=GridNearSingleGetResponse [futId=1669397231378, res=-547701325, > topVer=null, err=null, flags=0]] 2java.lang.StackOverflowError: null 3 at > org.apache.ignite.internal.marshaller.optimized.OptimizedMarshallerUtils.descriptorFromCache(OptimizedMarshallerUtils.java:328) > ~[ignite-core-8.8.22.jar:8.8.22] 4 at > org.apache.ignite.internal.marshaller.optimized.OptimizedMarshallerUtils.classDescriptor(OptimizedMarshallerUtils.java:273) > ~[ignite-core-8.8.22.jar:8.8.22] 5 at > org.apache.ignite.internal.marshaller.optimized.OptimizedObjectInputStream.readObject0(OptimizedObjectInputStream.java:354) > ~[ignite-core-8.8.22.jar:8.8.22] 6 at > org.apache.ignite.internal.marshaller.optimized.OptimizedObjectInputStream.readObjectOverride(OptimizedObjectInputStream.java:211) > ~[ignite-core-8.8.22.jar:8.8.22] 7 at > java.io.ObjectInputStream.readObject(ObjectInputStream.java:480) ~[?:?] 8 at > java.io.ObjectInputStream.readObject(ObjectInputStream.java:447) ~[?:?] 9 at > org.apache.ignite.internal.processors.cache.GridCacheProxyImpl.readExternal(GridCacheProxyImpl.java:1662) > ~[ignite-core-8.8.22.jar:8.8.22] 10 at > org.apache.ignite.internal.marshaller.optimized.OptimizedObjectInputStream.readExternalizable(OptimizedObjectInputStream.java:569) > ~[ignite-core-8.8.22.jar:8.8.22] 11 at > org.apache.ignite.internal.marshaller.optimized.OptimizedClassDescriptor.read(OptimizedClassDescriptor.java:979) > ~[ignite-core-8.8.22.jar:8.8.22] 12 at > org.apache.ignite.internal.marshaller.optimized.OptimizedObjectInputStream.readObject0(OptimizedObjectInputStream.java:359) > ~[ignite-core-8.8.22.jar:8.8.22] 13 at > org.apache.ignite.internal.marshaller.optimized.OptimizedObjectInputStream.readObjectOverride(OptimizedObjectInputStream.java:211) > ~[ignite-core-8.8.22.jar:8.8.22] 14 at > java.io.ObjectInputStream.readObject(ObjectInputStream.java:480) ~[?:?] 15 at > java.io.ObjectInputStream.readObject(ObjectInputStream.java:447) ~[?:?] 16... > 17[2022-11-25T17:27:29,276][ERROR][sys-stripe-0-#1%USERS_IGNITE%][] Critical > system error detected. Will be handled accordingly to configured handler > [hnd=StopNodeOrHaltFailureHandler [tryStop=false, timeout=0, > super=AbstractFailureHandler [ignoredFailureTypes=UnmodifiableSet > [SYSTEM_WORKER_BLOCKED, SYSTEM_CRITICAL_OPERATION_TIMEOUT]]], > failureCtx=FailureContext [type=CRITICAL_ERROR, > err=java.lang.StackOverflowError]]{code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-18302) ignite-spring-sessions: IgniteSession serialization drags its parent class
[ https://issues.apache.org/jira/browse/IGNITE-18302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761211#comment-17761211 ] Andrey Novikov commented on IGNITE-18302: - [~ashapkin] Can I take this issue? I see you can enough time to finish it. > ignite-spring-sessions: IgniteSession serialization drags its parent class > -- > > Key: IGNITE-18302 > URL: https://issues.apache.org/jira/browse/IGNITE-18302 > Project: Ignite > Issue Type: Bug > Components: extensions >Reporter: Alexandr Shapkin >Assignee: Alexandr Shapkin >Priority: Major > > In short, there is a bug in ignite-spring-session-ext implementation. > We store IgniteIndexedSessionRepository${{{}IgniteSession{}}} in the cache, > but it’s an internal non-static class, having a reference to the parent > [\{{{}IgniteIndexedSessionRepository{}}}] indirectly. > Hence, during the serialization Ignite also writes {{{}name=this$0, > type=Object, fieldId=0xCBDD23AA (-874699862){}}}, which is the reference to > {{{}IgniteIndexedSessionRepository{}}}. That leads to the following issues: > * we are serializing and saving internal utility data, like}} Ignite > ignite{}}}, {{private IndexResolver indexResolver}} etc > * one of the IgniteIndexedSessionRepository’s fields is IgniteCache itself - > {{IgniteCache sessions}} that basically keeps every > session so far leading to a StackOverflow error after some time. > > {code:java} > [2022-11-25T17:27:29,268][ERROR][sys-stripe-0-#1%USERS_IGNITE%][GridCacheIoManager] > Failed processing message [senderId=0f0ca915-d6cd-4580-92a3-1fbc3d2a5722, > msg=GridNearSingleGetResponse [futId=1669397231378, res=-547701325, > topVer=null, err=null, flags=0]] 2java.lang.StackOverflowError: null 3 at > org.apache.ignite.internal.marshaller.optimized.OptimizedMarshallerUtils.descriptorFromCache(OptimizedMarshallerUtils.java:328) > ~[ignite-core-8.8.22.jar:8.8.22] 4 at > org.apache.ignite.internal.marshaller.optimized.OptimizedMarshallerUtils.classDescriptor(OptimizedMarshallerUtils.java:273) > ~[ignite-core-8.8.22.jar:8.8.22] 5 at > org.apache.ignite.internal.marshaller.optimized.OptimizedObjectInputStream.readObject0(OptimizedObjectInputStream.java:354) > ~[ignite-core-8.8.22.jar:8.8.22] 6 at > org.apache.ignite.internal.marshaller.optimized.OptimizedObjectInputStream.readObjectOverride(OptimizedObjectInputStream.java:211) > ~[ignite-core-8.8.22.jar:8.8.22] 7 at > java.io.ObjectInputStream.readObject(ObjectInputStream.java:480) ~[?:?] 8 at > java.io.ObjectInputStream.readObject(ObjectInputStream.java:447) ~[?:?] 9 at > org.apache.ignite.internal.processors.cache.GridCacheProxyImpl.readExternal(GridCacheProxyImpl.java:1662) > ~[ignite-core-8.8.22.jar:8.8.22] 10 at > org.apache.ignite.internal.marshaller.optimized.OptimizedObjectInputStream.readExternalizable(OptimizedObjectInputStream.java:569) > ~[ignite-core-8.8.22.jar:8.8.22] 11 at > org.apache.ignite.internal.marshaller.optimized.OptimizedClassDescriptor.read(OptimizedClassDescriptor.java:979) > ~[ignite-core-8.8.22.jar:8.8.22] 12 at > org.apache.ignite.internal.marshaller.optimized.OptimizedObjectInputStream.readObject0(OptimizedObjectInputStream.java:359) > ~[ignite-core-8.8.22.jar:8.8.22] 13 at > org.apache.ignite.internal.marshaller.optimized.OptimizedObjectInputStream.readObjectOverride(OptimizedObjectInputStream.java:211) > ~[ignite-core-8.8.22.jar:8.8.22] 14 at > java.io.ObjectInputStream.readObject(ObjectInputStream.java:480) ~[?:?] 15 at > java.io.ObjectInputStream.readObject(ObjectInputStream.java:447) ~[?:?] 16... > 17[2022-11-25T17:27:29,276][ERROR][sys-stripe-0-#1%USERS_IGNITE%][] Critical > system error detected. Will be handled accordingly to configured handler > [hnd=StopNodeOrHaltFailureHandler [tryStop=false, timeout=0, > super=AbstractFailureHandler [ignoredFailureTypes=UnmodifiableSet > [SYSTEM_WORKER_BLOCKED, SYSTEM_CRITICAL_OPERATION_TIMEOUT]]], > failureCtx=FailureContext [type=CRITICAL_ERROR, > err=java.lang.StackOverflowError]]{code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-18302) ignite-spring-sessions: IgniteSession serialization drags its parent class
[ https://issues.apache.org/jira/browse/IGNITE-18302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750556#comment-17750556 ] Andrey Novikov commented on IGNITE-18302: - Let's move IgniteSession class to upper level as it will be used as value object in SQL. https://github.com/apache/ignite-extensions/pull/222#discussion_r1281232708 > ignite-spring-sessions: IgniteSession serialization drags its parent class > -- > > Key: IGNITE-18302 > URL: https://issues.apache.org/jira/browse/IGNITE-18302 > Project: Ignite > Issue Type: Bug > Components: extensions >Reporter: Alexandr Shapkin >Assignee: Alexandr Shapkin >Priority: Major > > In short, there is a bug in ignite-spring-session-ext implementation. > We store IgniteIndexedSessionRepository${{{}IgniteSession{}}} in the cache, > but it’s an internal non-static class, having a reference to the parent > [\{{{}IgniteIndexedSessionRepository{}}}] indirectly. > Hence, during the serialization Ignite also writes {{{}name=this$0, > type=Object, fieldId=0xCBDD23AA (-874699862){}}}, which is the reference to > {{{}IgniteIndexedSessionRepository{}}}. That leads to the following issues: > * we are serializing and saving internal utility data, like}} Ignite > ignite{}}}, {{private IndexResolver indexResolver}} etc > * one of the IgniteIndexedSessionRepository’s fields is IgniteCache itself - > {{IgniteCache sessions}} that basically keeps every > session so far leading to a StackOverflow error after some time. > > {code:java} > [2022-11-25T17:27:29,268][ERROR][sys-stripe-0-#1%USERS_IGNITE%][GridCacheIoManager] > Failed processing message [senderId=0f0ca915-d6cd-4580-92a3-1fbc3d2a5722, > msg=GridNearSingleGetResponse [futId=1669397231378, res=-547701325, > topVer=null, err=null, flags=0]] 2java.lang.StackOverflowError: null 3 at > org.apache.ignite.internal.marshaller.optimized.OptimizedMarshallerUtils.descriptorFromCache(OptimizedMarshallerUtils.java:328) > ~[ignite-core-8.8.22.jar:8.8.22] 4 at > org.apache.ignite.internal.marshaller.optimized.OptimizedMarshallerUtils.classDescriptor(OptimizedMarshallerUtils.java:273) > ~[ignite-core-8.8.22.jar:8.8.22] 5 at > org.apache.ignite.internal.marshaller.optimized.OptimizedObjectInputStream.readObject0(OptimizedObjectInputStream.java:354) > ~[ignite-core-8.8.22.jar:8.8.22] 6 at > org.apache.ignite.internal.marshaller.optimized.OptimizedObjectInputStream.readObjectOverride(OptimizedObjectInputStream.java:211) > ~[ignite-core-8.8.22.jar:8.8.22] 7 at > java.io.ObjectInputStream.readObject(ObjectInputStream.java:480) ~[?:?] 8 at > java.io.ObjectInputStream.readObject(ObjectInputStream.java:447) ~[?:?] 9 at > org.apache.ignite.internal.processors.cache.GridCacheProxyImpl.readExternal(GridCacheProxyImpl.java:1662) > ~[ignite-core-8.8.22.jar:8.8.22] 10 at > org.apache.ignite.internal.marshaller.optimized.OptimizedObjectInputStream.readExternalizable(OptimizedObjectInputStream.java:569) > ~[ignite-core-8.8.22.jar:8.8.22] 11 at > org.apache.ignite.internal.marshaller.optimized.OptimizedClassDescriptor.read(OptimizedClassDescriptor.java:979) > ~[ignite-core-8.8.22.jar:8.8.22] 12 at > org.apache.ignite.internal.marshaller.optimized.OptimizedObjectInputStream.readObject0(OptimizedObjectInputStream.java:359) > ~[ignite-core-8.8.22.jar:8.8.22] 13 at > org.apache.ignite.internal.marshaller.optimized.OptimizedObjectInputStream.readObjectOverride(OptimizedObjectInputStream.java:211) > ~[ignite-core-8.8.22.jar:8.8.22] 14 at > java.io.ObjectInputStream.readObject(ObjectInputStream.java:480) ~[?:?] 15 at > java.io.ObjectInputStream.readObject(ObjectInputStream.java:447) ~[?:?] 16... > 17[2022-11-25T17:27:29,276][ERROR][sys-stripe-0-#1%USERS_IGNITE%][] Critical > system error detected. Will be handled accordingly to configured handler > [hnd=StopNodeOrHaltFailureHandler [tryStop=false, timeout=0, > super=AbstractFailureHandler [ignoredFailureTypes=UnmodifiableSet > [SYSTEM_WORKER_BLOCKED, SYSTEM_CRITICAL_OPERATION_TIMEOUT]]], > failureCtx=FailureContext [type=CRITICAL_ERROR, > err=java.lang.StackOverflowError]]{code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IGNITE-19921) Add thin client support for Spring Session.
Andrey Novikov created IGNITE-19921: --- Summary: Add thin client support for Spring Session. Key: IGNITE-19921 URL: https://issues.apache.org/jira/browse/IGNITE-19921 Project: Ignite Issue Type: Improvement Components: extensions Reporter: Andrey Novikov It's needed to add thin client support for Spring Session. To work with a thin client it proposed: # Configure the bean of IgniteClient type # Mark the bean from step 1 with SpringSessionIgnite annotation. # Create session cache over create table query. At the moment, the repository configuration which uses node to access the cluster is performed in the same way. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (IGNITE-19921) Add thin client support for Spring Session.
[ https://issues.apache.org/jira/browse/IGNITE-19921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov reassigned IGNITE-19921: --- Assignee: Andrey Novikov > Add thin client support for Spring Session. > --- > > Key: IGNITE-19921 > URL: https://issues.apache.org/jira/browse/IGNITE-19921 > Project: Ignite > Issue Type: Improvement > Components: extensions >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > > It's needed to add thin client support for Spring Session. > To work with a thin client it proposed: > # Configure the bean of IgniteClient type > # Mark the bean from step 1 with SpringSessionIgnite annotation. > # Create session cache over create table query. > At the moment, the repository configuration which uses node to access the > cluster is performed in the same way. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IGNITE-18352) ignite-spring-sessions: Unsupported default cache name for Windows platform
Andrey Novikov created IGNITE-18352: --- Summary: ignite-spring-sessions: Unsupported default cache name for Windows platform Key: IGNITE-18352 URL: https://issues.apache.org/jira/browse/IGNITE-18352 Project: Ignite Issue Type: Bug Components: extensions Affects Versions: 1.0 Reporter: Andrey Novikov IgniteIndexedSessionRepository#DEFAULT_SESSION_MAP_NAME contains unsupported character `:` in cache name for Windows platform. *What to do:* Rename default name of map to `IgniteSessionCache` -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-17594) Provide ability to register listeners for query start/finish events
[ https://issues.apache.org/jira/browse/IGNITE-17594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598821#comment-17598821 ] Andrey Novikov commented on IGNITE-17594: - [~jooger] Can you please review this PR as maintainer of sql? > Provide ability to register listeners for query start/finish events > --- > > Key: IGNITE-17594 > URL: https://issues.apache.org/jira/browse/IGNITE-17594 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Fix For: 2.15 > > Time Spent: 10m > Remaining Estimate: 0h > > Need to expose internal API to provide ability to listen query start/finish > events. This allow to monitor query execution in monitoring tools. > Need to pass following properties: query, queryType, > schemaName, startTime, finishTime, local, {{{}cancellable{}}}, > {{{}enforceJoinOrder{}}}, {{{}lazy{}}}, {{{}distributedJoins{}}}, > {{failedReason}} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-17594) Provide ability to register listeners for query start/finish events
[ https://issues.apache.org/jira/browse/IGNITE-17594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-17594: Description: Need to expose internal API to provide ability to listen query start/finish events. This allow to monitor query execution in monitoring tools. Need to pass following properties: query, queryType, schemaName, startTime, finishTime, local, {{{}cancellable{}}}, {{{}enforceJoinOrder{}}}, {{{}lazy{}}}, {{{}distributedJoins{}}}, {{failedReason}} was: Need to expose internal API to provide ability to listen query start/finish events. Need to pass following properties: query, queryType, schemaName, startTime, finishTime, local, {{{}cancellable{}}}, {{{}enforceJoinOrder{}}}, {{{}lazy{}}}, {{{}distributedJoins{}}}, {{failedReason}} > Provide ability to register listeners for query start/finish events > --- > > Key: IGNITE-17594 > URL: https://issues.apache.org/jira/browse/IGNITE-17594 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Fix For: 2.15 > > Time Spent: 10m > Remaining Estimate: 0h > > Need to expose internal API to provide ability to listen query start/finish > events. This allow to monitor query execution in monitoring tools. > Need to pass following properties: query, queryType, > schemaName, startTime, finishTime, local, {{{}cancellable{}}}, > {{{}enforceJoinOrder{}}}, {{{}lazy{}}}, {{{}distributedJoins{}}}, > {{failedReason}} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-17594) Provide ability to register listeners for query start/finish events
[ https://issues.apache.org/jira/browse/IGNITE-17594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-17594: Description: Need to expose internal API to provide ability to listen query start/finish events. Need to pass following properties: query, queryType, schemaName, startTime, finishTime, local, {{{}cancellable{}}}, {{{}enforceJoinOrder{}}}, {{{}lazy{}}}, {{{}distributedJoins{}}}, {{failedReason}} was: Need to expose internal API to provide ability to listen query start/finish events. Need to pass following properties: local, {{{}cancellable{}}}, {{{}enforceJoinOrder{}}}, {{{}lazy{}}}, {{{}distributedJoins{}}}, {{failedReason}} > Provide ability to register listeners for query start/finish events > --- > > Key: IGNITE-17594 > URL: https://issues.apache.org/jira/browse/IGNITE-17594 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Fix For: 2.15 > > > Need to expose internal API to provide ability to listen query start/finish > events. > Need to pass following properties: query, queryType, > schemaName, startTime, finishTime, local, {{{}cancellable{}}}, > {{{}enforceJoinOrder{}}}, {{{}lazy{}}}, {{{}distributedJoins{}}}, > {{failedReason}} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-17594) Provide ability to register listeners for query start/finish events
[ https://issues.apache.org/jira/browse/IGNITE-17594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-17594: Description: Need to expose internal API to provide ability to listen query start/finish events. Need to pass following properties: local, {{{}cancellable{}}}, {{{}enforceJoinOrder{}}}, {{{}lazy{}}}, {{{}distributedJoins{}}}, {{failedReason}} was: To improve monitor of running queries on node we need to pass following properties {{{}cancellable{}}}, {{{}enforceJoinOrder{}}},{{{}lazy{}}},{{{}distributedJoins{}}},{{{}failedReason{}}} to existing listeners IgniteH2Indexing#registerQueryStartedListener, IgniteH2Indexing#registerQueryFinishedListener. *What to do:* Add {{{}enforceJoinOrder{}}},{{{}lazy{}}},{{{}distributedJoins{}}},{{{}failedReason{}}} to GridQueryFinishedInfo Add {{{}cancellable{}}}, {{{}enforceJoinOrder{}}},{{{}lazy{}}},{{{}distributedJoins{}}} to GridQueryStartedInfo > Provide ability to register listeners for query start/finish events > --- > > Key: IGNITE-17594 > URL: https://issues.apache.org/jira/browse/IGNITE-17594 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Fix For: 2.15 > > > Need to expose internal API to provide ability to listen query start/finish > events. > Need to pass following properties: local, {{{}cancellable{}}}, > {{{}enforceJoinOrder{}}}, {{{}lazy{}}}, {{{}distributedJoins{}}}, > {{failedReason}} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-17594) Provide ability to register listeners for query start/finish events
[ https://issues.apache.org/jira/browse/IGNITE-17594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-17594: Summary: Provide ability to register listeners for query start/finish events (was: Improve structures for query monitoring) > Provide ability to register listeners for query start/finish events > --- > > Key: IGNITE-17594 > URL: https://issues.apache.org/jira/browse/IGNITE-17594 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Fix For: 2.15 > > > To improve monitor of running queries on node we need to pass following > properties {{{}cancellable{}}}, > {{{}enforceJoinOrder{}}},{{{}lazy{}}},{{{}distributedJoins{}}},{{{}failedReason{}}} > to existing listeners IgniteH2Indexing#registerQueryStartedListener, > IgniteH2Indexing#registerQueryFinishedListener. > *What to do:* > Add > {{{}enforceJoinOrder{}}},{{{}lazy{}}},{{{}distributedJoins{}}},{{{}failedReason{}}} > to GridQueryFinishedInfo > Add {{{}cancellable{}}}, > {{{}enforceJoinOrder{}}},{{{}lazy{}}},{{{}distributedJoins{}}} to > GridQueryStartedInfo -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (IGNITE-17594) Improve structures for query monitoring
[ https://issues.apache.org/jira/browse/IGNITE-17594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov reassigned IGNITE-17594: --- Assignee: Andrey Novikov > Improve structures for query monitoring > --- > > Key: IGNITE-17594 > URL: https://issues.apache.org/jira/browse/IGNITE-17594 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Fix For: 2.15 > > > To improve monitor of running queries on node we need to pass following > properties {{{}cancellable{}}}, > {{{}enforceJoinOrder{}}},{{{}lazy{}}},{{{}distributedJoins{}}},{{{}failedReason{}}} > to existing listeners IgniteH2Indexing#registerQueryStartedListener, > IgniteH2Indexing#registerQueryFinishedListener. > *What to do:* > Add > {{{}enforceJoinOrder{}}},{{{}lazy{}}},{{{}distributedJoins{}}},{{{}failedReason{}}} > to GridQueryFinishedInfo > Add {{{}cancellable{}}}, > {{{}enforceJoinOrder{}}},{{{}lazy{}}},{{{}distributedJoins{}}} to > GridQueryStartedInfo -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IGNITE-17594) Improve structures for query monitoring
Andrey Novikov created IGNITE-17594: --- Summary: Improve structures for query monitoring Key: IGNITE-17594 URL: https://issues.apache.org/jira/browse/IGNITE-17594 Project: Ignite Issue Type: Improvement Components: sql Reporter: Andrey Novikov Fix For: 2.15 To improve monitor of running queries on node we need to pass following properties {{{}cancellable{}}}, {{{}enforceJoinOrder{}}},{{{}lazy{}}},{{{}distributedJoins{}}},{{{}failedReason{}}} to existing listeners IgniteH2Indexing#registerQueryStartedListener, IgniteH2Indexing#registerQueryFinishedListener. *What to do:* Add {{{}enforceJoinOrder{}}},{{{}lazy{}}},{{{}distributedJoins{}}},{{{}failedReason{}}} to GridQueryFinishedInfo Add {{{}cancellable{}}}, {{{}enforceJoinOrder{}}},{{{}lazy{}}},{{{}distributedJoins{}}} to GridQueryStartedInfo -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IGNITE-17187) Make SecurityPermission extendable in plugins
Andrey Novikov created IGNITE-17187: --- Summary: Make SecurityPermission extendable in plugins Key: IGNITE-17187 URL: https://issues.apache.org/jira/browse/IGNITE-17187 Project: Ignite Issue Type: Improvement Components: security Reporter: Andrey Novikov For now it not possible to define custom permission for the API that implemented in plugin. enum SecurityPermission can't be extended without changes in core product. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (IGNITE-15868) Unexpected command: PROBE when authorization is enabled
[ https://issues.apache.org/jira/browse/IGNITE-15868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441503#comment-17441503 ] Andrey Novikov commented on IGNITE-15868: - Merged to master. [Dmitriy Borunov|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=dmitriy.borunov] thanks for the contribution. > Unexpected command: PROBE when authorization is enabled > --- > > Key: IGNITE-15868 > URL: https://issues.apache.org/jira/browse/IGNITE-15868 > Project: Ignite > Issue Type: Bug > Components: platforms, thin client >Affects Versions: 2.12 >Reporter: Dmitriy Borunov >Priority: Major > Fix For: 2.13 > > Time Spent: 40m > Remaining Estimate: 0h > > Rest API Probe is not working when Control Center authorisation is enabled > {noformat} > [2021-11-01T13:35:33,550][ERROR][rest-#125%nebula-node%][GridRestProcessor] > Runtime error caught during grid runnable execution: GridWorker > [name=rest-proc-work > er, igniteInstanceName=nebula-node, finished=false, > heartbeatTs=1635773733544, hashCode=1386655371, interrupted=false, > runner=rest-#125%nebula-node%] > java.lang.AssertionError: Unexpected command: PROBE > at > org.apache.ignite.internal.processors.rest.GridRestProcessor.authorize(GridRestProcessor.java:968) > ~[ignite-core-8.8.10.jar:8.8.10] > at > org.apache.ignite.internal.processors.rest.GridRestProcessor.handleRequest(GridRestProcessor.java:286) > ~[ignite-core-8.8.10.jar:8.8.10] > at > org.apache.ignite.internal.processors.rest.GridRestProcessor.access$100(GridRestProcessor.java:108) > ~[ignite-core-8.8.10.jar:8.8.10] > at > org.apache.ignite.internal.processors.rest.GridRestProcessor$2.body(GridRestProcessor.java:183) > ~[ignite-core-8.8.10.jar:8.8.10] > at > org.apache.ignite.internal.util.worker.GridWorker.run(GridWorker.java:119) > [ignite-core-8.8.10.jar:8.8.10] > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) > [?:?] > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) > [?:?] > at java.lang.Thread.run(Thread.java:829) [?:?]{noformat} -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (IGNITE-15868) Unexpected command: PROBE when authorization is enabled
[ https://issues.apache.org/jira/browse/IGNITE-15868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov updated IGNITE-15868: Summary: Unexpected command: PROBE when authorization is enabled (was: Unexpected command: PROBE when Control Center authorisation is enabled) > Unexpected command: PROBE when authorization is enabled > --- > > Key: IGNITE-15868 > URL: https://issues.apache.org/jira/browse/IGNITE-15868 > Project: Ignite > Issue Type: Bug > Components: platforms, thin client >Affects Versions: 2.12 >Reporter: Dmitriy Borunov >Priority: Major > Fix For: 2.13 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Rest API Probe is not working when Control Center authorisation is enabled > {noformat} > [2021-11-01T13:35:33,550][ERROR][rest-#125%nebula-node%][GridRestProcessor] > Runtime error caught during grid runnable execution: GridWorker > [name=rest-proc-work > er, igniteInstanceName=nebula-node, finished=false, > heartbeatTs=1635773733544, hashCode=1386655371, interrupted=false, > runner=rest-#125%nebula-node%] > java.lang.AssertionError: Unexpected command: PROBE > at > org.apache.ignite.internal.processors.rest.GridRestProcessor.authorize(GridRestProcessor.java:968) > ~[ignite-core-8.8.10.jar:8.8.10] > at > org.apache.ignite.internal.processors.rest.GridRestProcessor.handleRequest(GridRestProcessor.java:286) > ~[ignite-core-8.8.10.jar:8.8.10] > at > org.apache.ignite.internal.processors.rest.GridRestProcessor.access$100(GridRestProcessor.java:108) > ~[ignite-core-8.8.10.jar:8.8.10] > at > org.apache.ignite.internal.processors.rest.GridRestProcessor$2.body(GridRestProcessor.java:183) > ~[ignite-core-8.8.10.jar:8.8.10] > at > org.apache.ignite.internal.util.worker.GridWorker.run(GridWorker.java:119) > [ignite-core-8.8.10.jar:8.8.10] > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) > [?:?] > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) > [?:?] > at java.lang.Thread.run(Thread.java:829) [?:?]{noformat} -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (IGNITE-15868) Unexpected command: PROBE when Control Center authorisation is enabled
[ https://issues.apache.org/jira/browse/IGNITE-15868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441502#comment-17441502 ] Andrey Novikov commented on IGNITE-15868: - LGTM. > Unexpected command: PROBE when Control Center authorisation is enabled > -- > > Key: IGNITE-15868 > URL: https://issues.apache.org/jira/browse/IGNITE-15868 > Project: Ignite > Issue Type: Bug > Components: platforms, thin client >Affects Versions: 2.12 >Reporter: Dmitriy Borunov >Priority: Major > Fix For: 2.13 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Rest API Probe is not working when Control Center authorisation is enabled > {noformat} > [2021-11-01T13:35:33,550][ERROR][rest-#125%nebula-node%][GridRestProcessor] > Runtime error caught during grid runnable execution: GridWorker > [name=rest-proc-work > er, igniteInstanceName=nebula-node, finished=false, > heartbeatTs=1635773733544, hashCode=1386655371, interrupted=false, > runner=rest-#125%nebula-node%] > java.lang.AssertionError: Unexpected command: PROBE > at > org.apache.ignite.internal.processors.rest.GridRestProcessor.authorize(GridRestProcessor.java:968) > ~[ignite-core-8.8.10.jar:8.8.10] > at > org.apache.ignite.internal.processors.rest.GridRestProcessor.handleRequest(GridRestProcessor.java:286) > ~[ignite-core-8.8.10.jar:8.8.10] > at > org.apache.ignite.internal.processors.rest.GridRestProcessor.access$100(GridRestProcessor.java:108) > ~[ignite-core-8.8.10.jar:8.8.10] > at > org.apache.ignite.internal.processors.rest.GridRestProcessor$2.body(GridRestProcessor.java:183) > ~[ignite-core-8.8.10.jar:8.8.10] > at > org.apache.ignite.internal.util.worker.GridWorker.run(GridWorker.java:119) > [ignite-core-8.8.10.jar:8.8.10] > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) > [?:?] > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) > [?:?] > at java.lang.Thread.run(Thread.java:829) [?:?]{noformat} -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (IGNITE-5387) Web console: Agent should report version of internal demo nodes
[ https://issues.apache.org/jira/browse/IGNITE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov reassigned IGNITE-5387: -- Assignee: (was: Andrey Novikov) > Web console: Agent should report version of internal demo nodes > --- > > Key: IGNITE-5387 > URL: https://issues.apache.org/jira/browse/IGNITE-5387 > Project: Ignite > Issue Type: Bug > Components: wizards >Affects Versions: 2.0 >Reporter: Vasiliy Sisko >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-5177) Failed javadoc generation for web-agent
[ https://issues.apache.org/jira/browse/IGNITE-5177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850480#comment-16850480 ] Andrey Novikov commented on IGNITE-5177: I think this is correct fix. Agent should not be deployed into maven and it don't introduce any public api. > Failed javadoc generation for web-agent > --- > > Key: IGNITE-5177 > URL: https://issues.apache.org/jira/browse/IGNITE-5177 > Project: Ignite > Issue Type: Bug >Reporter: Oleg Ostanin >Assignee: Andrey Novikov >Priority: Major > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-antrun-plugin:1.7:run > (javadoc-postprocessing-new) on project apache-ignite: An Ant BuildException > has occured: Execution failed due to: Class doesn't have description in file: > /home/oostanin/gg/incubator-ignite/target/javadoc/core/org/apache/ignite/console/agent/handlers/ClusterListener.html > [ERROR] Class doesn't have description in file: > /home/oostanin/gg/incubator-ignite/target/javadoc/core/org/apache/ignite/console/agent/handlers/DemoListener.html > [ERROR] Class doesn't have description in file: > /home/oostanin/gg/incubator-ignite/target/javadoc/core/org/apache/ignite/console/agent/rest/RestExecutor.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (IGNITE-5177) Failed javadoc generation for web-agent
[ https://issues.apache.org/jira/browse/IGNITE-5177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Novikov closed IGNITE-5177. -- > Failed javadoc generation for web-agent > --- > > Key: IGNITE-5177 > URL: https://issues.apache.org/jira/browse/IGNITE-5177 > Project: Ignite > Issue Type: Bug >Reporter: Oleg Ostanin >Assignee: Andrey Novikov >Priority: Major > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-antrun-plugin:1.7:run > (javadoc-postprocessing-new) on project apache-ignite: An Ant BuildException > has occured: Execution failed due to: Class doesn't have description in file: > /home/oostanin/gg/incubator-ignite/target/javadoc/core/org/apache/ignite/console/agent/handlers/ClusterListener.html > [ERROR] Class doesn't have description in file: > /home/oostanin/gg/incubator-ignite/target/javadoc/core/org/apache/ignite/console/agent/handlers/DemoListener.html > [ERROR] Class doesn't have description in file: > /home/oostanin/gg/incubator-ignite/target/javadoc/core/org/apache/ignite/console/agent/rest/RestExecutor.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)