[jira] [Comment Edited] (IGNITE-18875) Sql. Drop AbstractPlannerTest.TestTable.
[ https://issues.apache.org/jira/browse/IGNITE-18875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707142#comment-17707142 ] Evgeny Stanilovsky edited comment on IGNITE-18875 at 3/31/23 6:26 AM: -- [~yimengael] thanks for your effort, where can i found your PR ? You can link your PR for example like [1] TC , just register new acc: https://ci.ignite.apache.org/registerUser.html [1] https://issues.apache.org/jira/browse/IGNITE-18442 was (Author: zstan): [~yimengael] thanks for your effort, where can i found your PR ? You can link your PR for example like [1] TC access in progress. [1] https://issues.apache.org/jira/browse/IGNITE-18442 > Sql. Drop AbstractPlannerTest.TestTable. > > > Key: IGNITE-18875 > URL: https://issues.apache.org/jira/browse/IGNITE-18875 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Andrey Mashenkov >Assignee: Gael Yimen Yimga >Priority: Major > Labels: ignite-3, newbie, tech-debt-test > Fix For: 3.0.0-beta2 > > > Use test framework for schema configuration in tests. > Replace > {code:java} > org.apache.ignite.internal.sql.engine.planner.AbstractPlannerTest.TestTable > {code} > with > {code:java} > org.apache.ignite.internal.sql.engine.framework.TestTable > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (IGNITE-18875) Sql. Drop AbstractPlannerTest.TestTable.
[ https://issues.apache.org/jira/browse/IGNITE-18875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707104#comment-17707104 ] Gael Yimen Yimga edited comment on IGNITE-18875 at 3/31/23 5:46 AM: [~zstan] and [~amashenkov] I have created this [pull request|https://github.com/apache/ignite-3/pull/1873] to address this ticket. But I have made the following remark. ||Branch Name||Total Number of Tests||Total Number of Failures Tests||Total Number of Ignored Tests|| |Main|1290|378|21| |IGNITE-18875|1253|562|21| 1) First Notice is that the main branch has some test failures. i ran the following command .{_}*/gradlew clean test*{_} in order to run the tests. I was expecting the main branch to have zero failures. if that is the case, what am I doing wrong ? 2) Second notice, after my change in my branch, the number of total test increased, what is causing that ? and given that I have neither created new tests, nor deleted any tests, why is that the total number of Tests decreased ? 3) Can you guys please help on reviewing my pull request and advice if I'm in the right direction ? 4) I do not have access to [TeamCity|https://ci.ignite.apache.org/login.html] in order to trigger the tests suite. Could you please allow me the access to TeamCity ? was (Author: JIRAUSER299033): [~zstan] and [~amashenkov] I have created this [pull request|https://github.com/apache/ignite-3/pull/1873] to address this ticket. But I have made the following remark. ||Branch Name||Total Number of Tests||Total Number of Failures Tests||Total Number of Ignored Tests|| |Main|1290|378|21| |IGNITE-18875|1253|562|21| 1) First Notice is that the main branch has some test failures. i ran the following command .{_}*/gradlew clean test*{_} in order to run the tests. I was expecting the main branch to have zero failures. if that is the case, what am I doing wrong ? 2) Second notice, after my change in my branch, the number of total test increased, what is causing that ? and given that I have neither created new tests, nor deleted any tests, why is that the total number of Tests decreased ? 3) Can you guys please help on reviewing my pull request and advice if I'm in the right direction ? 4) I do not have access to [TeamCity|https://ci.ignite.apache.org/login.html] in order to trigger the tests suite. Could you please allow me the access to TeamCity ? > Sql. Drop AbstractPlannerTest.TestTable. > > > Key: IGNITE-18875 > URL: https://issues.apache.org/jira/browse/IGNITE-18875 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Andrey Mashenkov >Assignee: Gael Yimen Yimga >Priority: Major > Labels: ignite-3, newbie, tech-debt-test > Fix For: 3.0.0-beta2 > > > Use test framework for schema configuration in tests. > Replace > {code:java} > org.apache.ignite.internal.sql.engine.planner.AbstractPlannerTest.TestTable > {code} > with > {code:java} > org.apache.ignite.internal.sql.engine.framework.TestTable > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (IGNITE-18875) Sql. Drop AbstractPlannerTest.TestTable.
[ https://issues.apache.org/jira/browse/IGNITE-18875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707104#comment-17707104 ] Gael Yimen Yimga edited comment on IGNITE-18875 at 3/31/23 5:46 AM: [~zstan] and [~amashenkov] I have created this [pull request|https://github.com/apache/ignite-3/pull/1873] to address this ticket. But I have made the following remark. ||Branch Name||Total Number of Tests||Total Number of Failures Tests||Total Number of Ignored Tests|| |Main|1290|378|21| |IGNITE-18875|1253|562|21| 1) First Notice is that the main branch has some test failures. i ran the following command .{_}*/gradlew clean test*{_} in order to run the tests. I was expecting the main branch to have zero failures. if that is the case, what am I doing wrong ? 2) Second notice, after my change in my branch, the number of total test increased, what is causing that ? and given that I have neither created new tests, nor deleted any tests, why is that the total number of Tests decreased ? 3) Can you guys please help on reviewing my pull request and advice if I'm in the right direction ? 4) I do not have access to [TeamCity|https://ci.ignite.apache.org/login.html] in order to trigger the tests suite. Could you please allow me the access to TeamCity ? was (Author: JIRAUSER299033): [~zstan] and [~amashenkov] I have created this [pull request|https://github.com/apache/ignite-3/pull/1873] to address this ticket. But I have made the following remark. ||Branch Name||Total Number of Tests||Total Number of Failures Tests||Total Number of Ignored Tests|| |Main|1290|378|21| |IGNITE-18875|1253|562|21| 1) First Notice is that the main branch has some test failures. i ran the following command .{_}*/gradlew clean test*{_} in order to run the tests. I was expecting the main branch to have zero failures. if that is the case, what am I doing wrong ? 2) Second notice, after my change in my branch, the number of total test increased, what is causing that ? and given that I have neither created new tests, nor deleted any tests, why is that the total number of Tests decreased ? 3) Can you guys please help on reviewing my pull request and advice if I'm in the right direction ? 4) I do not have access to [TeamCity|https://ci.ignite.apache.org/login.html] in order to trigger the tests suite. Could you please allow me the access to TeamCity ? > Sql. Drop AbstractPlannerTest.TestTable. > > > Key: IGNITE-18875 > URL: https://issues.apache.org/jira/browse/IGNITE-18875 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Andrey Mashenkov >Assignee: Gael Yimen Yimga >Priority: Major > Labels: ignite-3, newbie, tech-debt-test > Fix For: 3.0.0-beta2 > > > Use test framework for schema configuration in tests. > Replace > {code:java} > org.apache.ignite.internal.sql.engine.planner.AbstractPlannerTest.TestTable > {code} > with > {code:java} > org.apache.ignite.internal.sql.engine.framework.TestTable > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (IGNITE-18875) Sql. Drop AbstractPlannerTest.TestTable.
[ https://issues.apache.org/jira/browse/IGNITE-18875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707104#comment-17707104 ] Gael Yimen Yimga edited comment on IGNITE-18875 at 3/31/23 5:40 AM: [~zstan] and [~amashenkov] I have created this [pull request|https://github.com/apache/ignite-3/pull/1873] to address this ticket. But I have made the following remark. ||Branch Name||Total Number of Tests||Total Number of Failures Tests||Total Number of Ignored Tests|| |Main|1290|378|21| |IGNITE-18875|1253|562|21| 1) First Notice is that the main branch has some test failures. i ran the following command .{_}*/gradlew clean test*{_} in order to run the tests. I was expecting the main branch to have zero failures. if that is the case, what am I doing wrong ? 2) Second notice, after my change in my branch, the number of total test increased, what is causing that ? and given that I have neither created new tests, nor deleted any tests, why is that the total number of Tests decreased ? 3) Can you guys please help on reviewing my pull request and advice if I'm in the right direction ? 4) I do not have access to [TeamCity|https://ci.ignite.apache.org/login.html] in order to trigger the tests suite. Could you please allow me the access to TeamCity ? was (Author: JIRAUSER299033): [~zstan] and [~amashenkov] I have created this [pull request|https://github.com/apache/ignite-3/pull/1873] to address this ticket. But I have made the following remark. ||Branch Name||Total Number of Tests||Total Number of Failures Tests||Total Number of Ignored Tests|| |Main|1290|378|21| |IGNITE-18875|1253|562|21| 1) First Notice is that the main branch has some test failures. i ran the following command .{_}*/gradlew clean test*{_} in order to run the tests. I was expecting the main branch to have zero failures. if that is the case, what am I doing wrong ? 2) Second notice, after my change in my branch, the number of total test increased, what is causing that ? and given that I have neither created new tests, nor deleted any tests, why is that the total number of Tests decreased ? 3) Can you guys please help on reviewing my pull request and advice if I'm in the right direction ? > Sql. Drop AbstractPlannerTest.TestTable. > > > Key: IGNITE-18875 > URL: https://issues.apache.org/jira/browse/IGNITE-18875 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Andrey Mashenkov >Assignee: Gael Yimen Yimga >Priority: Major > Labels: ignite-3, newbie, tech-debt-test > Fix For: 3.0.0-beta2 > > > Use test framework for schema configuration in tests. > Replace > {code:java} > org.apache.ignite.internal.sql.engine.planner.AbstractPlannerTest.TestTable > {code} > with > {code:java} > org.apache.ignite.internal.sql.engine.framework.TestTable > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)