[jira] [Commented] (IGNITE-9770) Re-run possible blockers from pr.html

2018-10-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644874#comment-16644874
 ] 

ASF GitHub Bot commented on IGNITE-9770:


asfgit closed pull request #27: IGNITE-9770 Add 'Re-run possible blockers' 
button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/observer/BuildInfo.java
 
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/observer/BuildInfo.java
deleted file mode 100644
index 9de4dd3..000
--- 
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/observer/BuildInfo.java
+++ /dev/null
@@ -1,81 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements.  See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License.  You may obtain a copy of the License at
- *
- *  http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.ignite.ci.observer;
-
-import org.apache.ignite.ci.tcmodel.result.Build;
-import org.apache.ignite.ci.user.ICredentialsProv;
-
-/**
- *
- */
-public class BuildInfo {
-/** Build. */
-public final Build build;
-
-/** Server id. */
-public final String srvId;
-
-/** */
-public final ICredentialsProv prov;
-
-/** JIRA ticket full name. */
-public final String ticket;
-
-/**
- * @param build Build.
- * @param srvId Server id.
- * @param prov Credentials.
- * @param ticket JIRA ticket name.
- */
-BuildInfo(Build build, String srvId, ICredentialsProv prov, String ticket) 
{
-this.build = build;
-this.srvId = srvId;
-this.prov = prov;
-this.ticket = ticket;
-}
-
-/** {@inheritDoc} */
-@Override public boolean equals(Object o) {
-if (this == o)
-return true;
-if (o == null || getClass() != o.getClass())
-return false;
-
-BuildInfo info = (BuildInfo)o;
-
-if (!build.equals(info.build))
-return false;
-if (!srvId.equals(info.srvId))
-return false;
-if (!prov.equals(info.prov))
-return false;
-
-return ticket.equals(info.ticket);
-}
-
-/** {@inheritDoc} */
-@Override public int hashCode() {
-int res = build.hashCode();
-
-res = 31 * res + srvId.hashCode();
-res = 31 * res + prov.hashCode();
-res = 31 * res + ticket.hashCode();
-
-return res;
-}
-}
diff --git 
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/observer/BuildObserver.java
 
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/observer/BuildObserver.java
index 8603d34..a6d302f 100644
--- 
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/observer/BuildObserver.java
+++ 
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/observer/BuildObserver.java
@@ -54,12 +54,11 @@ public void stop() {
 }
 
 /**
- * @param build Build id.
  * @param srvId Server id.
  * @param prov Credentials.
  * @param ticket JIRA ticket name.
  */
-public void observe(Build build, String srvId, ICredentialsProv prov, 
String ticket) {
-observerTask.builds.add(new BuildInfo(build, srvId, prov, ticket));
+public void observe(String srvId, ICredentialsProv prov, String ticket, 
Build... builds) {
+observerTask.builds.add(new BuildsInfo(srvId, prov, ticket, builds));
 }
 }
diff --git 
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/observer/BuildsInfo.java
 
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/observer/BuildsInfo.java
new file mode 100644
index 000..2dd3060
--- /dev/null
+++ 
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/observer/BuildsInfo.java
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the 

[jira] [Commented] (IGNITE-9770) Re-run possible blockers from pr.html

2018-10-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643161#comment-16643161
 ] 

ASF GitHub Bot commented on IGNITE-9770:


SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run 
possible blockers' button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r223661071
 
 

 ##
 File path: ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
 ##
 @@ -321,93 +343,82 @@ function notifyGit() {
 });
 }
 
-function triggerBuild(serverId, suiteId, branchName, top, observe, ticketId) {
+function triggerBuilds(serverId, suiteIdList, branchName, top, observe, 
ticketId) {
 var queueAtTop = isDefinedAndFilled(top) && top;
+var observeJira = isDefinedAndFilled(observe) && observe;
+var suiteIdsNotFound = suiteIdList.length === 0;
 
 Review comment:
   Will not work if `suiteIdList` is undefined.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Re-run possible blockers from pr.html
> -
>
> Key: IGNITE-9770
> URL: https://issues.apache.org/jira/browse/IGNITE-9770
> Project: Ignite
>  Issue Type: Sub-task
>Reporter: Nikolai Kulagin
>Assignee: Nikolai Kulagin
>Priority: Minor
>
> Show button for re-run possible blockers. Also show merged button with re-run 
> possible blockers JIRA, so the user re-run the possible tests and 
> does not wait for them to complete,but learn about the completed tests from 
> the comment to GitHib.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9770) Re-run possible blockers from pr.html

2018-10-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643154#comment-16643154
 ] 

ASF GitHub Bot commented on IGNITE-9770:


SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run 
possible blockers' button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r223661071
 
 

 ##
 File path: ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
 ##
 @@ -321,93 +343,82 @@ function notifyGit() {
 });
 }
 
-function triggerBuild(serverId, suiteId, branchName, top, observe, ticketId) {
+function triggerBuilds(serverId, suiteIdList, branchName, top, observe, 
ticketId) {
 var queueAtTop = isDefinedAndFilled(top) && top;
+var observeJira = isDefinedAndFilled(observe) && observe;
+var suiteIdsNotFound = suiteIdList.length === 0;
 
 Review comment:
   Will not work if `suiteIdList` is a single suite or undefined.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Re-run possible blockers from pr.html
> -
>
> Key: IGNITE-9770
> URL: https://issues.apache.org/jira/browse/IGNITE-9770
> Project: Ignite
>  Issue Type: Sub-task
>Reporter: Nikolai Kulagin
>Assignee: Nikolai Kulagin
>Priority: Minor
>
> Show button for re-run possible blockers. Also show merged button with re-run 
> possible blockers JIRA, so the user re-run the possible tests and 
> does not wait for them to complete,but learn about the completed tests from 
> the comment to GitHib.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9770) Re-run possible blockers from pr.html

2018-10-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642052#comment-16642052
 ] 

ASF GitHub Bot commented on IGNITE-9770:


SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run 
possible blockers' button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r223397571
 
 

 ##
 File path: ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
 ##
 @@ -328,7 +357,7 @@ function triggerBuild(serverId, suiteId, branchName, top, 
observe, ticketId) {
 url: 'rest/build/trigger',
 data: {
 "serverId": serverId,
-"suiteId": suiteId,
+"suiteIdList": suiteId,
 
 Review comment:
   suiteId -> suiteIds


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Re-run possible blockers from pr.html
> -
>
> Key: IGNITE-9770
> URL: https://issues.apache.org/jira/browse/IGNITE-9770
> Project: Ignite
>  Issue Type: Sub-task
>Reporter: Nikolai Kulagin
>Assignee: Nikolai Kulagin
>Priority: Minor
>
> Show button for re-run possible blockers. Also show merged button with re-run 
> possible blockers JIRA, so the user re-run the possible tests and 
> does not wait for them to complete,but learn about the completed tests from 
> the comment to GitHib.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9770) Re-run possible blockers from pr.html

2018-10-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641977#comment-16641977
 ] 

ASF GitHub Bot commented on IGNITE-9770:


SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run 
possible blockers' button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r223329487
 
 

 ##
 File path: 
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/observer/BuildsInfo.java
 ##
 @@ -0,0 +1,100 @@
+package org.apache.ignite.ci.observer;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Objects;
+import org.apache.ignite.ci.IAnalyticsEnabledTeamcity;
+import org.apache.ignite.ci.tcmodel.result.Build;
+import org.apache.ignite.ci.user.ICredentialsProv;
+
+public class BuildsInfo{
+/** Finished. */
+public static final String FINISHED = "finished";
+
+/** Server id. */
+public final String srvId;
+
+/** Build type id. */
+public final String buildTypeId;
+
+/** Branch name. */
+public final String branchName;
+
+/** Prov. */
+public final ICredentialsProv prov;
+
+/** JIRA ticket full name. */
+public final String ticket;
+
+/** Finished builds. */
+private final Map finishedBuilds = new HashMap<>();
+
+/**
+ * @param srvId Server id.
+ * @param prov Prov.
+ * @param ticket Ticket.
+ * @param builds Builds.
+ */
+public BuildsInfo(String srvId, ICredentialsProv prov, String ticket, 
Build[] builds) {
+this.srvId = srvId;
+this.prov = prov;
+this.ticket = ticket;
+this.buildTypeId = builds.length > 1 ? "IgniteTests24Java8_RunAll" : 
builds[0].buildTypeId;
+this.branchName = builds[0].branchName;
+
+for (Build build : builds)
+finishedBuilds.put(build, false);
+}
+
+/**
+ * @param teamcity Teamcity.
+ */
+public boolean isFinished(IAnalyticsEnabledTeamcity teamcity) {
+for (Map.Entry entry : finishedBuilds.entrySet()){
+if (!entry.getValue()){
+Build build = teamcity.getBuild(entry.getKey().getId());
+entry.setValue(build.state.equals(FINISHED));
+}
+}
+
+return !finishedBuilds.containsValue(false);
+}
+
+/**
+ * Return builds count.
+ */
+public int buildsCount(){
+return finishedBuilds.size();
+}
+
+/**
+ * Return finished builds count.
+ */
+public int finishedBuildsCount(){
+return (int)finishedBuilds.values().stream().filter(v -> v).count();
+}
+
+/** {@inheritDoc} */
+@Override public boolean equals(Object o) {
+if (this == o)
+return true;
+
+if (!(o instanceof BuildsInfo))
+return false;
+
+BuildsInfo info = (BuildsInfo)o;
+
+return Objects.equals(srvId, info.srvId) &&
+Objects.equals(buildTypeId, info.buildTypeId) &&
+Objects.equals(branchName, info.branchName) &&
+Objects.equals(prov, info.prov) &&
+Objects.equals(ticket, info.ticket) &&
+Objects.equals(finishedBuilds, info.finishedBuilds);
+}
+
+/** {@inheritDoc} */
+@Override public int hashCode() {
+
 
 Review comment:
   Remove empty line.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Re-run possible blockers from pr.html
> -
>
> Key: IGNITE-9770
> URL: https://issues.apache.org/jira/browse/IGNITE-9770
> Project: Ignite
>  Issue Type: Sub-task
>Reporter: Nikolai Kulagin
>Assignee: Nikolai Kulagin
>Priority: Minor
>
> Show button for re-run possible blockers. Also show merged button with re-run 
> possible blockers JIRA, so the user re-run the possible tests and 
> does not wait for them to complete,but learn about the completed tests from 
> the comment to GitHib.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9770) Re-run possible blockers from pr.html

2018-10-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641980#comment-16641980
 ] 

ASF GitHub Bot commented on IGNITE-9770:


SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run 
possible blockers' button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r223395846
 
 

 ##
 File path: ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
 ##
 @@ -214,14 +236,21 @@ function addBlockersData(server, settings) {
 return "";
 
 var blockers = "";
+var blockersList = "";
 
 Review comment:
   Variable is never used.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Re-run possible blockers from pr.html
> -
>
> Key: IGNITE-9770
> URL: https://issues.apache.org/jira/browse/IGNITE-9770
> Project: Ignite
>  Issue Type: Sub-task
>Reporter: Nikolai Kulagin
>Assignee: Nikolai Kulagin
>Priority: Minor
>
> Show button for re-run possible blockers. Also show merged button with re-run 
> possible blockers JIRA, so the user re-run the possible tests and 
> does not wait for them to complete,but learn about the completed tests from 
> the comment to GitHib.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9770) Re-run possible blockers from pr.html

2018-10-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641985#comment-16641985
 ] 

ASF GitHub Bot commented on IGNITE-9770:


SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run 
possible blockers' button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r223329723
 
 

 ##
 File path: 
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/observer/BuildsInfo.java
 ##
 @@ -0,0 +1,100 @@
+package org.apache.ignite.ci.observer;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Objects;
+import org.apache.ignite.ci.IAnalyticsEnabledTeamcity;
+import org.apache.ignite.ci.tcmodel.result.Build;
+import org.apache.ignite.ci.user.ICredentialsProv;
+
+public class BuildsInfo{
 
 Review comment:
   Need space before opening brace.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Re-run possible blockers from pr.html
> -
>
> Key: IGNITE-9770
> URL: https://issues.apache.org/jira/browse/IGNITE-9770
> Project: Ignite
>  Issue Type: Sub-task
>Reporter: Nikolai Kulagin
>Assignee: Nikolai Kulagin
>Priority: Minor
>
> Show button for re-run possible blockers. Also show merged button with re-run 
> possible blockers JIRA, so the user re-run the possible tests and 
> does not wait for them to complete,but learn about the completed tests from 
> the comment to GitHib.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9770) Re-run possible blockers from pr.html

2018-10-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641986#comment-16641986
 ] 

ASF GitHub Bot commented on IGNITE-9770:


SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run 
possible blockers' button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r223332768
 
 

 ##
 File path: ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
 ##
 @@ -355,59 +384,82 @@ function triggerBuild(serverId, suiteId, branchName, 
top, observe, ticketId) {
 });
 }
 
-function triggerBuilds(serverId, suiteIdList, branchName, top) {
-var res = "Trigger builds at server: " + serverId + "" +
-"Branch:" + branchName + "Top: " + top + "";
+function triggerBuilds(serverId, suiteIdList, branchName, top, observe, 
ticketId) {
+var possibleBlockersNotFound = suiteIdList.length === 0;
+var res = "";
 
-var partsOfStr = suiteIdList.split(',');
+if (possibleBlockersNotFound) {
+res = "Possible Blockers not found!";
+}
+else {
+res = "Trigger builds at server: " + serverId + "" +
+"Branch:" + branchName + "Top: " + top + "";
+
+var partsOfStr = suiteIdList.split(',');
 
-for (var i = 0; i < partsOfStr.length; i++) {
-var suite = partsOfStr[i];
-res += "Suite ID: " + suite + "";
+for (var i = 0; i < partsOfStr.length; i++) {
+var suite = partsOfStr[i];
+res += "Suite ID: " + suite + "";
+}
 }
+
 var triggerConfirm = $("#triggerConfirm");
 
 triggerConfirm.html(res);
 
-triggerConfirm.dialog({
-modal: true,
-buttons: {
-"Run": function() {
-$(this).dialog("close");
-
-var queueAtTop = isDefinedAndFilled(top) && top
-$.ajax({
-url: 'rest/build/triggerBuilds',
-data: {
-"serverId": serverId,
-"suiteIdList": suiteIdList,
-"branchName": branchName,
-"top": queueAtTop
-},
-success: function(result) {
-var dialog = $("#triggerDialog");
-
-dialog.html("Trigger builds at server: " + serverId + 
"" +
-" Suites " + suiteIdList + "Branch:" + 
branchName + "Top: " + top +
-" Result: " + result.result);
-dialog.dialog({
-modal: true,
-buttons: {
-"Ok": function() {
-$(this).dialog("close");
+if (possibleBlockersNotFound){
 
 Review comment:
   Add space before opening brace.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Re-run possible blockers from pr.html
> -
>
> Key: IGNITE-9770
> URL: https://issues.apache.org/jira/browse/IGNITE-9770
> Project: Ignite
>  Issue Type: Sub-task
>Reporter: Nikolai Kulagin
>Assignee: Nikolai Kulagin
>Priority: Minor
>
> Show button for re-run possible blockers. Also show merged button with re-run 
> possible blockers JIRA, so the user re-run the possible tests and 
> does not wait for them to complete,but learn about the completed tests from 
> the comment to GitHib.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9770) Re-run possible blockers from pr.html

2018-10-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641981#comment-16641981
 ] 

ASF GitHub Bot commented on IGNITE-9770:


SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run 
possible blockers' button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r223332273
 
 

 ##
 File path: ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
 ##
 @@ -355,59 +384,82 @@ function triggerBuild(serverId, suiteId, branchName, 
top, observe, ticketId) {
 });
 }
 
-function triggerBuilds(serverId, suiteIdList, branchName, top) {
-var res = "Trigger builds at server: " + serverId + "" +
-"Branch:" + branchName + "Top: " + top + "";
+function triggerBuilds(serverId, suiteIdList, branchName, top, observe, 
ticketId) {
+var possibleBlockersNotFound = suiteIdList.length === 0;
+var res = "";
 
-var partsOfStr = suiteIdList.split(',');
+if (possibleBlockersNotFound) {
 
 Review comment:
   Remove braces for one-line `if` statement.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Re-run possible blockers from pr.html
> -
>
> Key: IGNITE-9770
> URL: https://issues.apache.org/jira/browse/IGNITE-9770
> Project: Ignite
>  Issue Type: Sub-task
>Reporter: Nikolai Kulagin
>Assignee: Nikolai Kulagin
>Priority: Minor
>
> Show button for re-run possible blockers. Also show merged button with re-run 
> possible blockers JIRA, so the user re-run the possible tests and 
> does not wait for them to complete,but learn about the completed tests from 
> the comment to GitHib.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9770) Re-run possible blockers from pr.html

2018-10-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641978#comment-16641978
 ] 

ASF GitHub Bot commented on IGNITE-9770:


SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run 
possible blockers' button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r223388354
 
 

 ##
 File path: 
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/rest/TriggerBuild.java
 ##
 @@ -71,14 +72,16 @@ public SimpleResult triggerBuild(
 if (!prov.hasAccess(srvId))
 throw ServiceUnauthorizedException.noCreds(srvId);
 
+if (isNullOrEmpty(suiteIdList))
+return new SimpleResult("Error: nothing to run");
 
 Review comment:
   Missed dot.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Re-run possible blockers from pr.html
> -
>
> Key: IGNITE-9770
> URL: https://issues.apache.org/jira/browse/IGNITE-9770
> Project: Ignite
>  Issue Type: Sub-task
>Reporter: Nikolai Kulagin
>Assignee: Nikolai Kulagin
>Priority: Minor
>
> Show button for re-run possible blockers. Also show merged button with re-run 
> possible blockers JIRA, so the user re-run the possible tests and 
> does not wait for them to complete,but learn about the completed tests from 
> the comment to GitHib.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9770) Re-run possible blockers from pr.html

2018-10-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641984#comment-16641984
 ] 

ASF GitHub Bot commented on IGNITE-9770:


SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run 
possible blockers' button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r223397571
 
 

 ##
 File path: ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
 ##
 @@ -328,7 +357,7 @@ function triggerBuild(serverId, suiteId, branchName, top, 
observe, ticketId) {
 url: 'rest/build/trigger',
 data: {
 "serverId": serverId,
-"suiteId": suiteId,
+"suiteIdList": suiteId,
 
 Review comment:
   suiteId -> suiteIds


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Re-run possible blockers from pr.html
> -
>
> Key: IGNITE-9770
> URL: https://issues.apache.org/jira/browse/IGNITE-9770
> Project: Ignite
>  Issue Type: Sub-task
>Reporter: Nikolai Kulagin
>Assignee: Nikolai Kulagin
>Priority: Minor
>
> Show button for re-run possible blockers. Also show merged button with re-run 
> possible blockers JIRA, so the user re-run the possible tests and 
> does not wait for them to complete,but learn about the completed tests from 
> the comment to GitHib.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9770) Re-run possible blockers from pr.html

2018-10-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641979#comment-16641979
 ] 

ASF GitHub Bot commented on IGNITE-9770:


SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run 
possible blockers' button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r223387956
 
 

 ##
 File path: 
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/observer/BuildsInfo.java
 ##
 @@ -0,0 +1,100 @@
+package org.apache.ignite.ci.observer;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Objects;
+import org.apache.ignite.ci.IAnalyticsEnabledTeamcity;
+import org.apache.ignite.ci.tcmodel.result.Build;
+import org.apache.ignite.ci.user.ICredentialsProv;
+
+public class BuildsInfo{
+/** Finished. */
+public static final String FINISHED = "finished";
+
+/** Server id. */
+public final String srvId;
+
+/** Build type id. */
+public final String buildTypeId;
+
+/** Branch name. */
+public final String branchName;
+
+/** Prov. */
 
 Review comment:
   Credentials.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Re-run possible blockers from pr.html
> -
>
> Key: IGNITE-9770
> URL: https://issues.apache.org/jira/browse/IGNITE-9770
> Project: Ignite
>  Issue Type: Sub-task
>Reporter: Nikolai Kulagin
>Assignee: Nikolai Kulagin
>Priority: Minor
>
> Show button for re-run possible blockers. Also show merged button with re-run 
> possible blockers JIRA, so the user re-run the possible tests and 
> does not wait for them to complete,but learn about the completed tests from 
> the comment to GitHib.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9770) Re-run possible blockers from pr.html

2018-10-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641982#comment-16641982
 ] 

ASF GitHub Bot commented on IGNITE-9770:


SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run 
possible blockers' button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r223329630
 
 

 ##
 File path: 
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/observer/BuildsInfo.java
 ##
 @@ -0,0 +1,100 @@
+package org.apache.ignite.ci.observer;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Objects;
+import org.apache.ignite.ci.IAnalyticsEnabledTeamcity;
+import org.apache.ignite.ci.tcmodel.result.Build;
+import org.apache.ignite.ci.user.ICredentialsProv;
+
+public class BuildsInfo{
+/** Finished. */
+public static final String FINISHED = "finished";
+
+/** Server id. */
+public final String srvId;
+
+/** Build type id. */
+public final String buildTypeId;
+
+/** Branch name. */
+public final String branchName;
+
+/** Prov. */
+public final ICredentialsProv prov;
+
+/** JIRA ticket full name. */
+public final String ticket;
+
+/** Finished builds. */
+private final Map finishedBuilds = new HashMap<>();
+
+/**
+ * @param srvId Server id.
+ * @param prov Prov.
+ * @param ticket Ticket.
+ * @param builds Builds.
+ */
+public BuildsInfo(String srvId, ICredentialsProv prov, String ticket, 
Build[] builds) {
+this.srvId = srvId;
+this.prov = prov;
+this.ticket = ticket;
+this.buildTypeId = builds.length > 1 ? "IgniteTests24Java8_RunAll" : 
builds[0].buildTypeId;
+this.branchName = builds[0].branchName;
+
+for (Build build : builds)
+finishedBuilds.put(build, false);
+}
+
+/**
+ * @param teamcity Teamcity.
+ */
+public boolean isFinished(IAnalyticsEnabledTeamcity teamcity) {
+for (Map.Entry entry : finishedBuilds.entrySet()){
+if (!entry.getValue()){
 
 Review comment:
   Need space before opening brace.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Re-run possible blockers from pr.html
> -
>
> Key: IGNITE-9770
> URL: https://issues.apache.org/jira/browse/IGNITE-9770
> Project: Ignite
>  Issue Type: Sub-task
>Reporter: Nikolai Kulagin
>Assignee: Nikolai Kulagin
>Priority: Minor
>
> Show button for re-run possible blockers. Also show merged button with re-run 
> possible blockers JIRA, so the user re-run the possible tests and 
> does not wait for them to complete,but learn about the completed tests from 
> the comment to GitHib.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9770) Re-run possible blockers from pr.html

2018-10-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641987#comment-16641987
 ] 

ASF GitHub Bot commented on IGNITE-9770:


SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run 
possible blockers' button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r223387780
 
 

 ##
 File path: 
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/observer/BuildsInfo.java
 ##
 @@ -0,0 +1,100 @@
+package org.apache.ignite.ci.observer;
 
 Review comment:
   Missed license.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Re-run possible blockers from pr.html
> -
>
> Key: IGNITE-9770
> URL: https://issues.apache.org/jira/browse/IGNITE-9770
> Project: Ignite
>  Issue Type: Sub-task
>Reporter: Nikolai Kulagin
>Assignee: Nikolai Kulagin
>Priority: Minor
>
> Show button for re-run possible blockers. Also show merged button with re-run 
> possible blockers JIRA, so the user re-run the possible tests and 
> does not wait for them to complete,but learn about the completed tests from 
> the comment to GitHib.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9770) Re-run possible blockers from pr.html

2018-10-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641983#comment-16641983
 ] 

ASF GitHub Bot commented on IGNITE-9770:


SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run 
possible blockers' button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r223392275
 
 

 ##
 File path: 
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcbot/visa/TcBotTriggerAndSignOffService.java
 ##
 @@ -77,7 +78,7 @@
 @NotNull public String triggerBuildAndObserve(
 @Nullable String srvId,
 @Nullable String branchForTc,
-@Nullable String suiteId,
+@Nullable String suiteIdList,
 
 Review comment:
   Rename this method to `triggerBuildsAndObserve`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Re-run possible blockers from pr.html
> -
>
> Key: IGNITE-9770
> URL: https://issues.apache.org/jira/browse/IGNITE-9770
> Project: Ignite
>  Issue Type: Sub-task
>Reporter: Nikolai Kulagin
>Assignee: Nikolai Kulagin
>Priority: Minor
>
> Show button for re-run possible blockers. Also show merged button with re-run 
> possible blockers JIRA, so the user re-run the possible tests and 
> does not wait for them to complete,but learn about the completed tests from 
> the comment to GitHib.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9770) Re-run possible blockers from pr.html

2018-10-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638134#comment-16638134
 ] 

ASF GitHub Bot commented on IGNITE-9770:


SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run 
possible blockers' button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r222643151
 
 

 ##
 File path: ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
 ##
 @@ -171,9 +170,29 @@ function showChainCurrentStatusData(server, settings) {
 
 if (settings.isJiraAvailable()) {
 res += "Comment JIRA";
++ server.branchName + "\")'>Comment JIRA";
 }
 
+var blockersList = "";
+
+for (var i = 0; i < server.suites.length; i++) {
+var suite = server.suites[i];
+
+suite = suiteWithCriticalFailuresOnly(suite);
+
+if (suite != null) {
+if (blockersList.length !== 0)
+blockersList += ",";
+
+blockersList += suite.suiteId;
+}
+}
+
+res += " Re-run 
possible blockers";
+
+res += " Re-run 
possible blockers & Comment JIRA";
 
 Review comment:
   Too long line. Also, add `` tag and move this under 
`settings.isJiraAvailable()` check. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Re-run possible blockers from pr.html
> -
>
> Key: IGNITE-9770
> URL: https://issues.apache.org/jira/browse/IGNITE-9770
> Project: Ignite
>  Issue Type: Sub-task
>Reporter: Nikolai Kulagin
>Assignee: Nikolai Kulagin
>Priority: Minor
>
> Show button for re-run possible blockers. Also show merged button with re-run 
> possible blockers JIRA, so the user re-run the possible tests and 
> does not wait for them to complete,but learn about the completed tests from 
> the comment to GitHib.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9770) Re-run possible blockers from pr.html

2018-10-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638137#comment-16638137
 ] 

ASF GitHub Bot commented on IGNITE-9770:


SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run 
possible blockers' button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r222643571
 
 

 ##
 File path: ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
 ##
 @@ -125,11 +124,11 @@ function showChainCurrentStatusData(server, settings) {
 if (suitesFailedList.length !== 0 && isDefinedAndFilled(server.serverId) 
&& isDefinedAndFilled(server.branchName)) {
 mInfo += "Trigger failed " + cntFailed + " builds";
 mInfo += "  Re-run possible blockers from pr.html
> -
>
> Key: IGNITE-9770
> URL: https://issues.apache.org/jira/browse/IGNITE-9770
> Project: Ignite
>  Issue Type: Sub-task
>Reporter: Nikolai Kulagin
>Assignee: Nikolai Kulagin
>Priority: Minor
>
> Show button for re-run possible blockers. Also show merged button with re-run 
> possible blockers JIRA, so the user re-run the possible tests and 
> does not wait for them to complete,but learn about the completed tests from 
> the comment to GitHib.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9770) Re-run possible blockers from pr.html

2018-10-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638135#comment-16638135
 ] 

ASF GitHub Bot commented on IGNITE-9770:


SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run 
possible blockers' button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r222642202
 
 

 ##
 File path: 
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/rest/TriggerBuild.java
 ##
 @@ -167,7 +167,8 @@ private String observeJira(
 
 BuildObserver observer = 
CtxListener.getInjector(context).getInstance(BuildObserver.class);
 
-observer.observe(build, srvId, prov, "ignite-" + ticketId);
+for (Build build : builds)
 
 Review comment:
   We shouldn't observe builds for the same PR separately, because in such case 
we Bot will comment same ticket for every build. We should wait while all of 
the builds will be finished and comment only once.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Re-run possible blockers from pr.html
> -
>
> Key: IGNITE-9770
> URL: https://issues.apache.org/jira/browse/IGNITE-9770
> Project: Ignite
>  Issue Type: Sub-task
>Reporter: Nikolai Kulagin
>Assignee: Nikolai Kulagin
>Priority: Minor
>
> Show button for re-run possible blockers. Also show merged button with re-run 
> possible blockers JIRA, so the user re-run the possible tests and 
> does not wait for them to complete,but learn about the completed tests from 
> the comment to GitHib.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9770) Re-run possible blockers from pr.html

2018-10-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638136#comment-16638136
 ] 

ASF GitHub Bot commented on IGNITE-9770:


SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run 
possible blockers' button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r222642946
 
 

 ##
 File path: ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
 ##
 @@ -171,9 +170,29 @@ function showChainCurrentStatusData(server, settings) {
 
 if (settings.isJiraAvailable()) {
 res += "Comment JIRA";
++ server.branchName + "\")'>Comment JIRA";
 }
 
+var blockersList = "";
+
+for (var i = 0; i < server.suites.length; i++) {
+var suite = server.suites[i];
+
+suite = suiteWithCriticalFailuresOnly(suite);
+
+if (suite != null) {
+if (blockersList.length !== 0)
+blockersList += ",";
+
+blockersList += suite.suiteId;
+}
+}
+
+res += " Re-run 
possible blockers";
 
 Review comment:
   Too long line. Also, add `` tag.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Re-run possible blockers from pr.html
> -
>
> Key: IGNITE-9770
> URL: https://issues.apache.org/jira/browse/IGNITE-9770
> Project: Ignite
>  Issue Type: Sub-task
>Reporter: Nikolai Kulagin
>Assignee: Nikolai Kulagin
>Priority: Minor
>
> Show button for re-run possible blockers. Also show merged button with re-run 
> possible blockers JIRA, so the user re-run the possible tests and 
> does not wait for them to complete,but learn about the completed tests from 
> the comment to GitHib.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9770) Re-run possible blockers from pr.html

2018-10-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638139#comment-16638139
 ] 

ASF GitHub Bot commented on IGNITE-9770:


SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run 
possible blockers' button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r222643602
 
 

 ##
 File path: ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
 ##
 @@ -125,11 +124,11 @@ function showChainCurrentStatusData(server, settings) {
 if (suitesFailedList.length !== 0 && isDefinedAndFilled(server.serverId) 
&& isDefinedAndFilled(server.branchName)) {
 mInfo += "Trigger failed " + cntFailed + " builds";
 mInfo += "  Re-run possible blockers from pr.html
> -
>
> Key: IGNITE-9770
> URL: https://issues.apache.org/jira/browse/IGNITE-9770
> Project: Ignite
>  Issue Type: Sub-task
>Reporter: Nikolai Kulagin
>Assignee: Nikolai Kulagin
>Priority: Minor
>
> Show button for re-run possible blockers. Also show merged button with re-run 
> possible blockers JIRA, so the user re-run the possible tests and 
> does not wait for them to complete,but learn about the completed tests from 
> the comment to GitHib.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9770) Re-run possible blockers from pr.html

2018-10-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638138#comment-16638138
 ] 

ASF GitHub Bot commented on IGNITE-9770:


SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run 
possible blockers' button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r222642529
 
 

 ##
 File path: 
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/rest/TriggerBuild.java
 ##
 @@ -195,31 +196,42 @@ private String observeJira(
 @GET
 @Path("triggerBuilds")
 public SimpleResult triggerBuilds(
-@Nullable @QueryParam("serverId") String serverId,
+@Nullable @QueryParam("serverId") String srvId,
 @Nullable @QueryParam("branchName") String branchName,
 @NotNull @QueryParam("suiteIdList") String suiteIdList,
-@Nullable @QueryParam("top") Boolean top) {
+@Nullable @QueryParam("top") Boolean top,
+@Nullable @QueryParam("observe") Boolean observe,
+@Nullable @QueryParam("ticketId") String ticketId) {
+
+String jiraRes = "";
 
 final ICredentialsProv prov = ICredentialsProv.get(req);
 
-if (!prov.hasAccess(serverId))
-throw ServiceUnauthorizedException.noCreds(serverId);
+if (!prov.hasAccess(srvId))
+throw ServiceUnauthorizedException.noCreds(srvId);
 
 List strings = Arrays.asList(suiteIdList.split(","));
 if (strings.isEmpty())
 return new SimpleResult("Error: nothing to run");
 
-final ITeamcity helper = 
CtxListener.getTcHelper(context).server(serverId, prov);
+ITcHelper helper = CtxListener.getTcHelper(context);
+
+final ITeamcity teamcity = helper.server(srvId, prov);
 
 boolean queueToTop = top != null && top;
 
+List buildList = new ArrayList<>();
+
 for (String suiteId : strings) {
 System.out.println("Triggering [ " + suiteId + "," + branchName + 
"," + "top=" + queueToTop + "]");
 
-helper.triggerBuild(suiteId, branchName, false, queueToTop);
+buildList.add(teamcity.triggerBuild(suiteId, branchName, false, 
queueToTop));
 }
 
-return new SimpleResult("OK");
+if (observe != null && observe)
+jiraRes = observeJira(srvId, branchName, ticketId, helper, 
teamcity, prov, buildList.toArray(new Build[0]));
 
 Review comment:
   Redundant argument `new Build[0]`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Re-run possible blockers from pr.html
> -
>
> Key: IGNITE-9770
> URL: https://issues.apache.org/jira/browse/IGNITE-9770
> Project: Ignite
>  Issue Type: Sub-task
>Reporter: Nikolai Kulagin
>Assignee: Nikolai Kulagin
>Priority: Minor
>
> Show button for re-run possible blockers. Also show merged button with re-run 
> possible blockers JIRA, so the user re-run the possible tests and 
> does not wait for them to complete,but learn about the completed tests from 
> the comment to GitHib.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-9770) Re-run possible blockers from pr.html

2018-10-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-9770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637992#comment-16637992
 ] 

ASF GitHub Bot commented on IGNITE-9770:


zzzadruga opened a new pull request #27: IGNITE-9770 Add 'Re-run possible 
blockers' button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Re-run possible blockers from pr.html
> -
>
> Key: IGNITE-9770
> URL: https://issues.apache.org/jira/browse/IGNITE-9770
> Project: Ignite
>  Issue Type: Sub-task
>Reporter: Nikolai Kulagin
>Assignee: Nikolai Kulagin
>Priority: Minor
>
> Show button for re-run possible blockers. Also show merged button with re-run 
> possible blockers JIRA, so the user re-run the possible tests and 
> does not wait for them to complete,but learn about the completed tests from 
> the comment to GitHib.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)