[jira] [Updated] (LUCENE-9042) Refactor TopGroups.merge tests
[ https://issues.apache.org/jira/browse/LUCENE-9042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Diego Ceccarelli updated LUCENE-9042: - Attachment: LUCENE-9042.patch > Refactor TopGroups.merge tests > -- > > Key: LUCENE-9042 > URL: https://issues.apache.org/jira/browse/LUCENE-9042 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Diego Ceccarelli >Priority: Minor > Attachments: LUCENE-9042.patch > > > This task proposes a refactoring of the test coverage for the > {{TopGroups.merge}} method implemented in LUCENE-9010. For now it will cover > only 3 main cases. > 1. Merging to empty TopGroups > 2. Merging a TopGroups with scores and a TopGroups without scores (currently > broken because of LUCENE-8996 bug) > 3. Merging two TopGroups with scores. > I'm planning to increase the coverage testing also invalid inputs but I would > do that in a separate PR to keep the code readable. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (LUCENE-9042) Refactor TopGroups.merge tests
[ https://issues.apache.org/jira/browse/LUCENE-9042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Diego Ceccarelli updated LUCENE-9042: - Attachment: (was: LUCENE-9042.patch) > Refactor TopGroups.merge tests > -- > > Key: LUCENE-9042 > URL: https://issues.apache.org/jira/browse/LUCENE-9042 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Diego Ceccarelli >Priority: Minor > Attachments: LUCENE-9042.patch > > > This task proposes a refactoring of the test coverage for the > {{TopGroups.merge}} method implemented in LUCENE-9010. For now it will cover > only 3 main cases. > 1. Merging to empty TopGroups > 2. Merging a TopGroups with scores and a TopGroups without scores (currently > broken because of LUCENE-8996 bug) > 3. Merging two TopGroups with scores. > I'm planning to increase the coverage testing also invalid inputs but I would > do that in a separate PR to keep the code readable. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (LUCENE-9042) Refactor TopGroups.merge tests
[ https://issues.apache.org/jira/browse/LUCENE-9042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Diego Ceccarelli updated LUCENE-9042: - Attachment: (was: LUCENE-9042.patch) > Refactor TopGroups.merge tests > -- > > Key: LUCENE-9042 > URL: https://issues.apache.org/jira/browse/LUCENE-9042 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Diego Ceccarelli >Priority: Minor > Attachments: LUCENE-9042.patch > > > This task proposes a refactoring of the test coverage for the > {{TopGroups.merge}} method implemented in LUCENE-9010. For now it will cover > only 3 main cases. > 1. Merging to empty TopGroups > 2. Merging a TopGroups with scores and a TopGroups without scores (currently > broken because of LUCENE-8996 bug) > 3. Merging two TopGroups with scores. > I'm planning to increase the coverage testing also invalid inputs but I would > do that in a separate PR to keep the code readable. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (LUCENE-9042) Refactor TopGroups.merge tests
[ https://issues.apache.org/jira/browse/LUCENE-9042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Diego Ceccarelli updated LUCENE-9042: - Attachment: LUCENE-9042.patch > Refactor TopGroups.merge tests > -- > > Key: LUCENE-9042 > URL: https://issues.apache.org/jira/browse/LUCENE-9042 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Diego Ceccarelli >Priority: Minor > Attachments: LUCENE-9042.patch > > > This task proposes a refactoring of the test coverage for the > {{TopGroups.merge}} method implemented in LUCENE-9010. For now it will cover > only 3 main cases. > 1. Merging to empty TopGroups > 2. Merging a TopGroups with scores and a TopGroups without scores (currently > broken because of LUCENE-8996 bug) > 3. Merging two TopGroups with scores. > I'm planning to increase the coverage testing also invalid inputs but I would > do that in a separate PR to keep the code readable. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (LUCENE-9042) Refactor TopGroups.merge tests
[ https://issues.apache.org/jira/browse/LUCENE-9042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Diego Ceccarelli updated LUCENE-9042: - Attachment: LUCENE-9042.patch > Refactor TopGroups.merge tests > -- > > Key: LUCENE-9042 > URL: https://issues.apache.org/jira/browse/LUCENE-9042 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Diego Ceccarelli >Priority: Minor > Attachments: LUCENE-9042.patch > > > This task proposes a refactoring of the test coverage for the > {{TopGroups.merge}} method implemented in LUCENE-9010. For now it will cover > only 3 main cases. > 1. Merging to empty TopGroups > 2. Merging a TopGroups with scores and a TopGroups without scores (currently > broken because of LUCENE-8996 bug) > 3. Merging two TopGroups with scores. > I'm planning to increase the coverage testing also invalid inputs but I would > do that in a separate PR to keep the code readable. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (LUCENE-9042) Refactor TopGroups.merge tests
[ https://issues.apache.org/jira/browse/LUCENE-9042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Diego Ceccarelli updated LUCENE-9042: - Attachment: (was: LUCENE-9042.patch) > Refactor TopGroups.merge tests > -- > > Key: LUCENE-9042 > URL: https://issues.apache.org/jira/browse/LUCENE-9042 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Diego Ceccarelli >Priority: Minor > Attachments: LUCENE-9042.patch > > > This task proposes a refactoring of the test coverage for the > {{TopGroups.merge}} method implemented in LUCENE-9010. For now it will cover > only 3 main cases. > 1. Merging to empty TopGroups > 2. Merging a TopGroups with scores and a TopGroups without scores (currently > broken because of LUCENE-8996 bug) > 3. Merging two TopGroups with scores. > I'm planning to increase the coverage testing also invalid inputs but I would > do that in a separate PR to keep the code readable. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (LUCENE-9042) Refactor TopGroups.merge tests
[ https://issues.apache.org/jira/browse/LUCENE-9042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Diego Ceccarelli updated LUCENE-9042: - Attachment: (was: LUCENE-9042.patch) > Refactor TopGroups.merge tests > -- > > Key: LUCENE-9042 > URL: https://issues.apache.org/jira/browse/LUCENE-9042 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Diego Ceccarelli >Priority: Minor > Attachments: LUCENE-9042.patch > > > This task proposes a refactoring of the test coverage for the > {{TopGroups.merge}} method implemented in LUCENE-9010. For now it will cover > only 3 main cases. > 1. Merging to empty TopGroups > 2. Merging a TopGroups with scores and a TopGroups without scores (currently > broken because of LUCENE-8996 bug) > 3. Merging two TopGroups with scores. > I'm planning to increase the coverage testing also invalid inputs but I would > do that in a separate PR to keep the code readable. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (LUCENE-9042) Refactor TopGroups.merge tests
[ https://issues.apache.org/jira/browse/LUCENE-9042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Diego Ceccarelli updated LUCENE-9042: - Attachment: LUCENE-9042.patch > Refactor TopGroups.merge tests > -- > > Key: LUCENE-9042 > URL: https://issues.apache.org/jira/browse/LUCENE-9042 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Diego Ceccarelli >Priority: Minor > Attachments: LUCENE-9042.patch > > > This task proposes a refactoring of the test coverage for the > {{TopGroups.merge}} method implemented in LUCENE-9010. For now it will cover > only 3 main cases. > 1. Merging to empty TopGroups > 2. Merging a TopGroups with scores and a TopGroups without scores (currently > broken because of LUCENE-8996 bug) > 3. Merging two TopGroups with scores. > I'm planning to increase the coverage testing also invalid inputs but I would > do that in a separate PR to keep the code readable. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (LUCENE-9042) Refactor TopGroups.merge tests
[ https://issues.apache.org/jira/browse/LUCENE-9042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Diego Ceccarelli updated LUCENE-9042: - Attachment: LUCENE-9042.patch > Refactor TopGroups.merge tests > -- > > Key: LUCENE-9042 > URL: https://issues.apache.org/jira/browse/LUCENE-9042 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Diego Ceccarelli >Priority: Minor > Attachments: LUCENE-9042.patch > > > This task proposes a refactoring of the test coverage for the > {{TopGroups.merge}} method implemented in LUCENE-9010. For now it will cover > only 3 main cases. > 1. Merging to empty TopGroups > 2. Merging a TopGroups with scores and a TopGroups without scores (currently > broken because of LUCENE-8996 bug) > 3. Merging two TopGroups with scores. > I'm planning to increase the coverage testing also invalid inputs but I would > do that in a separate PR to keep the code readable. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (LUCENE-9042) Refactor TopGroups.merge tests
[ https://issues.apache.org/jira/browse/LUCENE-9042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Diego Ceccarelli updated LUCENE-9042: - Status: Patch Available (was: Open) > Refactor TopGroups.merge tests > -- > > Key: LUCENE-9042 > URL: https://issues.apache.org/jira/browse/LUCENE-9042 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Diego Ceccarelli >Priority: Minor > > This task proposes a refactoring of the test coverage for the > {{TopGroups.merge}} method implemented in LUCENE-9010. For now it will cover > only 3 main cases. > 1. Merging to empty TopGroups > 2. Merging a TopGroups with scores and a TopGroups without scores (currently > broken because of LUCENE-8996 bug) > 3. Merging two TopGroups with scores. > I'm planning to increase the coverage testing also invalid inputs but I would > do that in a separate PR to keep the code readable. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org