[jira] [Commented] (MESOS-1662) Mesos doesn't limit swap
[ https://issues.apache.org/jira/browse/MESOS-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14139289#comment-14139289 ] Chi Hoang commented on MESOS-1662: -- awesome! thanks! > Mesos doesn't limit swap > > > Key: MESOS-1662 > URL: https://issues.apache.org/jira/browse/MESOS-1662 > Project: Mesos > Issue Type: Bug > Components: isolation >Affects Versions: 0.19.1 >Reporter: Andrew Forgue >Assignee: Anton Lindström > Fix For: 0.20.0 > > > When using control groups, mesos will limit memory usage, but if the > CONFIG_MEMCG_SWAP config option is enabled swap usage is not limited. > This means that if a task that asked for 1G and allocated 4G, it will fill 3G > of swap. The expected behavior is that the cgroup should have OOMed. The > control group key for limiting both Memory+Swap is > memory.memsw.limit_in_bytes (not memory.limit_in_bytes). It looks like > CONFIG_MEMCG_SWAP showed up in Kernel 3.6. > Mesos should limit swap+memory if possible. I can't imagine when you'd want > to limit memory but not swap, but there may be some situations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-1662) Mesos doesn't limit swap
[ https://issues.apache.org/jira/browse/MESOS-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14139181#comment-14139181 ] Jie Yu commented on MESOS-1662: --- [~chi_groupon] This is fixed in 0.20.0 commit cfa168f5136f05d01ebb5ffa3a42a118db14c43e Author: Anton Lindström Date: Sun Aug 10 16:26:46 2014 -0700 Allowed cgroups mem isolator to limit swap by setting memory.memsw.limit_in_bytes. Review: https://reviews.apache.org/r/24316 > Mesos doesn't limit swap > > > Key: MESOS-1662 > URL: https://issues.apache.org/jira/browse/MESOS-1662 > Project: Mesos > Issue Type: Bug > Components: isolation >Affects Versions: 0.19.1 >Reporter: Andrew Forgue >Assignee: Anton Lindström > Fix For: 0.20.0 > > > When using control groups, mesos will limit memory usage, but if the > CONFIG_MEMCG_SWAP config option is enabled swap usage is not limited. > This means that if a task that asked for 1G and allocated 4G, it will fill 3G > of swap. The expected behavior is that the cgroup should have OOMed. The > control group key for limiting both Memory+Swap is > memory.memsw.limit_in_bytes (not memory.limit_in_bytes). It looks like > CONFIG_MEMCG_SWAP showed up in Kernel 3.6. > Mesos should limit swap+memory if possible. I can't imagine when you'd want > to limit memory but not swap, but there may be some situations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-1662) Mesos doesn't limit swap
[ https://issues.apache.org/jira/browse/MESOS-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14139176#comment-14139176 ] Chi Hoang commented on MESOS-1662: -- Wondering what happened with this fix. Status says fixed, but it wasn't included in 0.20.0. > Mesos doesn't limit swap > > > Key: MESOS-1662 > URL: https://issues.apache.org/jira/browse/MESOS-1662 > Project: Mesos > Issue Type: Bug > Components: isolation >Affects Versions: 0.19.1 >Reporter: Andrew Forgue >Assignee: Anton Lindström > > When using control groups, mesos will limit memory usage, but if the > CONFIG_MEMCG_SWAP config option is enabled swap usage is not limited. > This means that if a task that asked for 1G and allocated 4G, it will fill 3G > of swap. The expected behavior is that the cgroup should have OOMed. The > control group key for limiting both Memory+Swap is > memory.memsw.limit_in_bytes (not memory.limit_in_bytes). It looks like > CONFIG_MEMCG_SWAP showed up in Kernel 3.6. > Mesos should limit swap+memory if possible. I can't imagine when you'd want > to limit memory but not swap, but there may be some situations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-1662) Mesos doesn't limit swap
[ https://issues.apache.org/jira/browse/MESOS-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086440#comment-14086440 ] Anton Lindström commented on MESOS-1662: Messed up the previous review (I think), here's a new one: https://reviews.apache.org/r/24316/ > Mesos doesn't limit swap > > > Key: MESOS-1662 > URL: https://issues.apache.org/jira/browse/MESOS-1662 > Project: Mesos > Issue Type: Bug > Components: isolation >Affects Versions: 0.19.1 >Reporter: Andrew Forgue >Assignee: Anton Lindström > > When using control groups, mesos will limit memory usage, but if the > CONFIG_MEMCG_SWAP config option is enabled swap usage is not limited. > This means that if a task that asked for 1G and allocated 4G, it will fill 3G > of swap. The expected behavior is that the cgroup should have OOMed. The > control group key for limiting both Memory+Swap is > memory.memsw.limit_in_bytes (not memory.limit_in_bytes). It looks like > CONFIG_MEMCG_SWAP showed up in Kernel 3.6. > Mesos should limit swap+memory if possible. I can't imagine when you'd want > to limit memory but not swap, but there may be some situations. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MESOS-1662) Mesos doesn't limit swap
[ https://issues.apache.org/jira/browse/MESOS-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14085205#comment-14085205 ] Ian Downes commented on MESOS-1662: --- Note that memory.memsw.limit_in_bytes is not present in the fairly common case where swap is disabled, the code must be able to handle that scenario correctly. > Mesos doesn't limit swap > > > Key: MESOS-1662 > URL: https://issues.apache.org/jira/browse/MESOS-1662 > Project: Mesos > Issue Type: Bug > Components: isolation >Affects Versions: 0.19.1 >Reporter: Andrew Forgue >Assignee: Anton Lindström > > When using control groups, mesos will limit memory usage, but if the > CONFIG_MEMCG_SWAP config option is enabled swap usage is not limited. > This means that if a task that asked for 1G and allocated 4G, it will fill 3G > of swap. The expected behavior is that the cgroup should have OOMed. The > control group key for limiting both Memory+Swap is > memory.memsw.limit_in_bytes (not memory.limit_in_bytes). It looks like > CONFIG_MEMCG_SWAP showed up in Kernel 3.6. > Mesos should limit swap+memory if possible. I can't imagine when you'd want > to limit memory but not swap, but there may be some situations. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MESOS-1662) Mesos doesn't limit swap
[ https://issues.apache.org/jira/browse/MESOS-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14085188#comment-14085188 ] Jie Yu commented on MESOS-1662: --- +1 on adding a flag. > Mesos doesn't limit swap > > > Key: MESOS-1662 > URL: https://issues.apache.org/jira/browse/MESOS-1662 > Project: Mesos > Issue Type: Bug > Components: isolation >Affects Versions: 0.19.1 >Reporter: Andrew Forgue >Assignee: Anton Lindström > > When using control groups, mesos will limit memory usage, but if the > CONFIG_MEMCG_SWAP config option is enabled swap usage is not limited. > This means that if a task that asked for 1G and allocated 4G, it will fill 3G > of swap. The expected behavior is that the cgroup should have OOMed. The > control group key for limiting both Memory+Swap is > memory.memsw.limit_in_bytes (not memory.limit_in_bytes). It looks like > CONFIG_MEMCG_SWAP showed up in Kernel 3.6. > Mesos should limit swap+memory if possible. I can't imagine when you'd want > to limit memory but not swap, but there may be some situations. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MESOS-1662) Mesos doesn't limit swap
[ https://issues.apache.org/jira/browse/MESOS-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14085179#comment-14085179 ] Vinod Kone commented on MESOS-1662: --- I would like to give the users the ability to disable this feature (memory+swap) for atleast one release, before we making it the default. How about adding a flag (e.g, "--limit-swap") which defaults to false in 0.20.0. In 0.21.0 we can make the default to true and then kill the flag altogether in 0.22.0? > Mesos doesn't limit swap > > > Key: MESOS-1662 > URL: https://issues.apache.org/jira/browse/MESOS-1662 > Project: Mesos > Issue Type: Bug > Components: isolation >Affects Versions: 0.19.1 >Reporter: Andrew Forgue >Assignee: Anton Lindström > > When using control groups, mesos will limit memory usage, but if the > CONFIG_MEMCG_SWAP config option is enabled swap usage is not limited. > This means that if a task that asked for 1G and allocated 4G, it will fill 3G > of swap. The expected behavior is that the cgroup should have OOMed. The > control group key for limiting both Memory+Swap is > memory.memsw.limit_in_bytes (not memory.limit_in_bytes). It looks like > CONFIG_MEMCG_SWAP showed up in Kernel 3.6. > Mesos should limit swap+memory if possible. I can't imagine when you'd want > to limit memory but not swap, but there may be some situations. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MESOS-1662) Mesos doesn't limit swap
[ https://issues.apache.org/jira/browse/MESOS-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14085160#comment-14085160 ] Jie Yu commented on MESOS-1662: --- > because users may be running jobs that do use swap and which would now OOM > unexpectedly. For this case, I prefer OOM those jobs because they are actually using more memory than requested. > Mesos doesn't limit swap > > > Key: MESOS-1662 > URL: https://issues.apache.org/jira/browse/MESOS-1662 > Project: Mesos > Issue Type: Bug > Components: isolation >Affects Versions: 0.19.1 >Reporter: Andrew Forgue >Assignee: Anton Lindström > > When using control groups, mesos will limit memory usage, but if the > CONFIG_MEMCG_SWAP config option is enabled swap usage is not limited. > This means that if a task that asked for 1G and allocated 4G, it will fill 3G > of swap. The expected behavior is that the cgroup should have OOMed. The > control group key for limiting both Memory+Swap is > memory.memsw.limit_in_bytes (not memory.limit_in_bytes). It looks like > CONFIG_MEMCG_SWAP showed up in Kernel 3.6. > Mesos should limit swap+memory if possible. I can't imagine when you'd want > to limit memory but not swap, but there may be some situations. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MESOS-1662) Mesos doesn't limit swap
[ https://issues.apache.org/jira/browse/MESOS-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14085146#comment-14085146 ] Ian Downes commented on MESOS-1662: --- IIUC memory.memsw.limit_in_bytes has been around for a long time, it's only CONFIG_MEMCG_SWAP which is recent. > Mesos doesn't limit swap > > > Key: MESOS-1662 > URL: https://issues.apache.org/jira/browse/MESOS-1662 > Project: Mesos > Issue Type: Bug > Components: isolation >Affects Versions: 0.19.1 >Reporter: Andrew Forgue >Assignee: Anton Lindström > > When using control groups, mesos will limit memory usage, but if the > CONFIG_MEMCG_SWAP config option is enabled swap usage is not limited. > This means that if a task that asked for 1G and allocated 4G, it will fill 3G > of swap. The expected behavior is that the cgroup should have OOMed. The > control group key for limiting both Memory+Swap is > memory.memsw.limit_in_bytes (not memory.limit_in_bytes). It looks like > CONFIG_MEMCG_SWAP showed up in Kernel 3.6. > Mesos should limit swap+memory if possible. I can't imagine when you'd want > to limit memory but not swap, but there may be some situations. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MESOS-1662) Mesos doesn't limit swap
[ https://issues.apache.org/jira/browse/MESOS-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14085145#comment-14085145 ] Ian Downes commented on MESOS-1662: --- I tend to agree that Mesos should be able to limit memory+swap but this change needs some consideration because users may be running jobs that do use swap and which would now OOM unexpectedly. I can imagine users limiting memory and swap independently so perhaps this needs some discussion? > Mesos doesn't limit swap > > > Key: MESOS-1662 > URL: https://issues.apache.org/jira/browse/MESOS-1662 > Project: Mesos > Issue Type: Bug > Components: isolation >Affects Versions: 0.19.1 >Reporter: Andrew Forgue >Assignee: Anton Lindström > > When using control groups, mesos will limit memory usage, but if the > CONFIG_MEMCG_SWAP config option is enabled swap usage is not limited. > This means that if a task that asked for 1G and allocated 4G, it will fill 3G > of swap. The expected behavior is that the cgroup should have OOMed. The > control group key for limiting both Memory+Swap is > memory.memsw.limit_in_bytes (not memory.limit_in_bytes). It looks like > CONFIG_MEMCG_SWAP showed up in Kernel 3.6. > Mesos should limit swap+memory if possible. I can't imagine when you'd want > to limit memory but not swap, but there may be some situations. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MESOS-1662) Mesos doesn't limit swap
[ https://issues.apache.org/jira/browse/MESOS-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14085116#comment-14085116 ] Jie Yu commented on MESOS-1662: --- I am wondering can we set both memory.limit_in_bytes and memory.memsw.limit_in_bytes (if available since it may not be available on some kernels)? > Mesos doesn't limit swap > > > Key: MESOS-1662 > URL: https://issues.apache.org/jira/browse/MESOS-1662 > Project: Mesos > Issue Type: Bug > Components: isolation >Affects Versions: 0.19.1 >Reporter: Andrew Forgue >Assignee: Anton Lindström > > When using control groups, mesos will limit memory usage, but if the > CONFIG_MEMCG_SWAP config option is enabled swap usage is not limited. > This means that if a task that asked for 1G and allocated 4G, it will fill 3G > of swap. The expected behavior is that the cgroup should have OOMed. The > control group key for limiting both Memory+Swap is > memory.memsw.limit_in_bytes (not memory.limit_in_bytes). It looks like > CONFIG_MEMCG_SWAP showed up in Kernel 3.6. > Mesos should limit swap+memory if possible. I can't imagine when you'd want > to limit memory but not swap, but there may be some situations. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MESOS-1662) Mesos doesn't limit swap
[ https://issues.apache.org/jira/browse/MESOS-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14085098#comment-14085098 ] Anton Lindström commented on MESOS-1662: I'm changing from memory.limit_in_bytes to memory.memsw.limit_in_bytes where it's added. Sending a review right away. > Mesos doesn't limit swap > > > Key: MESOS-1662 > URL: https://issues.apache.org/jira/browse/MESOS-1662 > Project: Mesos > Issue Type: Bug > Components: isolation >Affects Versions: 0.19.1 >Reporter: Andrew Forgue >Assignee: Anton Lindström > > When using control groups, mesos will limit memory usage, but if the > CONFIG_MEMCG_SWAP config option is enabled swap usage is not limited. > This means that if a task that asked for 1G and allocated 4G, it will fill 3G > of swap. The expected behavior is that the cgroup should have OOMed. The > control group key for limiting both Memory+Swap is > memory.memsw.limit_in_bytes (not memory.limit_in_bytes). It looks like > CONFIG_MEMCG_SWAP showed up in Kernel 3.6. > Mesos should limit swap+memory if possible. I can't imagine when you'd want > to limit memory but not swap, but there may be some situations. -- This message was sent by Atlassian JIRA (v6.2#6252)
