[jira] [Comment Edited] (MESOS-2154) Port CFS quota support to Docker Containerizer

2016-08-11 Thread Zhitao Li (JIRA)

[ 
https://issues.apache.org/jira/browse/MESOS-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15418344#comment-15418344
 ] 

Zhitao Li edited comment on MESOS-2154 at 8/12/16 4:21 AM:
---

Wow, nice to see that. If there is already a legitimate fix, I don't see why we 
can't revive that patch.

Given that custom executor can work w/o this, maybe only do the version check 
for command executor (e.g. {{ExecutorInfo}} is not set)?


was (Author: zhitao):
Wow, nice to see that. If there is already a legitimate fix, I don't see why we 
can't revive that patch.

Given that custom executor can work w/o this, maybe only do it for command 
executor (e.g. {{ExecutorInfo}} is not set)?

> Port CFS quota support to Docker Containerizer
> --
>
> Key: MESOS-2154
> URL: https://issues.apache.org/jira/browse/MESOS-2154
> Project: Mesos
>  Issue Type: Improvement
>  Components: docker, isolation
>Affects Versions: 0.21.0
> Environment: Linux (Ubuntu 14.04.1)
>Reporter: Andrew Ortman
>Assignee: Steve Niemitz
>Priority: Minor
> Fix For: 1.0.0
>
>
> Port the CFS quota support the Mesos Containerizer has to the Docker 
> Containerizer. Whenever the --cgroup_enable_cfs flag is set, the Docker 
> Containerizer should update the cfs_period_us and cfs_quota_us values to 
> allow hard CPU capping on the container. 
> Current workaround is to pass those values as LXC configuration parameters



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (MESOS-2154) Port CFS quota support to Docker Containerizer

2016-08-11 Thread haosdent (JIRA)

[ 
https://issues.apache.org/jira/browse/MESOS-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15418340#comment-15418340
 ] 

haosdent edited comment on MESOS-2154 at 8/12/16 4:15 AM:
--

I have that before at https://reviews.apache.org/r/36181/diff/4#index_header. 
But feel it is not nice enough.  


was (Author: haosd...@gmail.com):
I have that before at https://reviews.apache.org/r/36181/diff/4#index_header. 
But don't feel it is not nice enough.  

> Port CFS quota support to Docker Containerizer
> --
>
> Key: MESOS-2154
> URL: https://issues.apache.org/jira/browse/MESOS-2154
> Project: Mesos
>  Issue Type: Improvement
>  Components: docker, isolation
>Affects Versions: 0.21.0
> Environment: Linux (Ubuntu 14.04.1)
>Reporter: Andrew Ortman
>Assignee: Steve Niemitz
>Priority: Minor
> Fix For: 1.0.0
>
>
> Port the CFS quota support the Mesos Containerizer has to the Docker 
> Containerizer. Whenever the --cgroup_enable_cfs flag is set, the Docker 
> Containerizer should update the cfs_period_us and cfs_quota_us values to 
> allow hard CPU capping on the container. 
> Current workaround is to pass those values as LXC configuration parameters



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (MESOS-2154) Port CFS quota support to Docker Containerizer

2016-08-11 Thread Zhitao Li (JIRA)

[ 
https://issues.apache.org/jira/browse/MESOS-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15418103#comment-15418103
 ] 

Zhitao Li edited comment on MESOS-2154 at 8/11/16 11:24 PM:


[~SteveNiemitz], can you elaborate how you tested this? I tried to run mesos 
agent with docker containerizer with cfs quota, but it does not seem to work 
for Mesos's built-in command executor.

In my testing, I believe the `__update` function was never invoked and instead 
short-circuited by a log line line like:
```
I0811 21:39:28.470679 95229 docker.cpp:1443] Ignoring updating container 
'ec3f2387-40de-4341-887d-68a0acce829a' with resources passed to update is 
identical to existing resources
```


was (Author: zhitao):
[~SteveNiemitz], can you elaborate how you tested this? I tried to run mesos 
agent with docker containerizer with cfs quota, but it does not seem to work 
for Mesos's built-in command executor.

> Port CFS quota support to Docker Containerizer
> --
>
> Key: MESOS-2154
> URL: https://issues.apache.org/jira/browse/MESOS-2154
> Project: Mesos
>  Issue Type: Improvement
>  Components: docker, isolation
>Affects Versions: 0.21.0
> Environment: Linux (Ubuntu 14.04.1)
>Reporter: Andrew Ortman
>Assignee: Steve Niemitz
>Priority: Minor
> Fix For: 1.0.0
>
>
> Port the CFS quota support the Mesos Containerizer has to the Docker 
> Containerizer. Whenever the --cgroup_enable_cfs flag is set, the Docker 
> Containerizer should update the cfs_period_us and cfs_quota_us values to 
> allow hard CPU capping on the container. 
> Current workaround is to pass those values as LXC configuration parameters



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)