[jira] [Commented] (NIFI-13110) Auto select relation in Create Connection
[ https://issues.apache.org/jira/browse/NIFI-13110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842534#comment-17842534 ] ASF subversion and git services commented on NIFI-13110: Commit 5a5947d1b04a5cda0c8967a197bd1b4c73f8cf39 in nifi's branch refs/heads/main from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=5a5947d1b0 ] NIFI-13110: (#8719) - Auto-selecting the relationship when the source processor only offers a single relationship. This closes #8719 > Auto select relation in Create Connection > - > > Key: NIFI-13110 > URL: https://issues.apache.org/jira/browse/NIFI-13110 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > When there is only a single Relationship, auto select it in the Create > Connection dialog. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13110) Auto select relation in Create Connection
[ https://issues.apache.org/jira/browse/NIFI-13110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13110: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Auto select relation in Create Connection > - > > Key: NIFI-13110 > URL: https://issues.apache.org/jira/browse/NIFI-13110 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > When there is only a single Relationship, auto select it in the Create > Connection dialog. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13110: Auto-selecting the relationship when the source processor only offers a single relationship [nifi]
scottyaslan merged PR #8719: URL: https://github.com/apache/nifi/pull/8719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13115] update context menu, search results overalay, and nf edi… [nifi]
scottyaslan commented on PR #8714: URL: https://github.com/apache/nifi/pull/8714#issuecomment-2087872530 @mcgilman Thanks for the review. I have rebased with latest main. Please merge once CI is green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-13118) ChunkDocument python processor not works with Split code - 'NoneType' object has no attribute 'getValue'
[ https://issues.apache.org/jira/browse/NIFI-13118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Gresock resolved NIFI-13118. Fix Version/s: 2.0.0-M3 Resolution: Fixed > ChunkDocument python processor not works with Split code - 'NoneType' object > has no attribute 'getValue' > > > Key: NIFI-13118 > URL: https://issues.apache.org/jira/browse/NIFI-13118 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 2.0.0-M1, 2.0.0-M2, 2.0.0-M3 >Reporter: Zoltán Kornél Török >Assignee: Zoltán Kornél Török >Priority: Major > Labels: python > Fix For: 2.0.0-M3 > > Time Spent: 20m > Remaining Estimate: 0h > > When you want to use ChunkDocument with split code settings we got : > {code:java} > PythonProcessor[type=ChunkDocument, id=e1f5691a-4845-3529-9b8b-052300f15375] > Failed to transform FlowFile[filename=1ad079db-cb83-49bc-8208-c1e35c5d8c52]: > py4j.Py4JException: An exception was raised by the Python Proxy. Return > Message: Traceback (most recent call last): > File "/opt/nifi/nifi-current/python/framework/py4j/java_gateway.py", line > 2466, in _call_proxy > return_value = getattr(self.pool[obj_id], method)(*params) > File "/opt/nifi/nifi-current/python/api/nifiapi/flowfiletransform.py", line > 33, in transformFlowFile > return self.transform(self.process_context, flowfile) > File "/opt/nifi/nifi-current/./python/extensions/ChunkDocument.py", line > 281, in transform > split_docs = self.split_docs(context, flowfile, documents) > File "/opt/nifi/nifi-current/./python/extensions/ChunkDocument.py", line > 212, in split_docs > language=context.getProperty(self.LANGUAGE).getValue(), > AttributeError: 'NoneType' object has no attribute 'getValue' {code} > It seems the LANGUAGE property is missing from the property_descriptors list, > and because of that it is not appear on the ui and the default value also not > initialize properly. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13118) ChunkDocument python processor not works with Split code - 'NoneType' object has no attribute 'getValue'
[ https://issues.apache.org/jira/browse/NIFI-13118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842515#comment-17842515 ] ASF subversion and git services commented on NIFI-13118: Commit 99d8433b7dae1e51f2f829b6bc138aa491ab02b1 in nifi's branch refs/heads/main from Zoltan Kornel Torok [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=99d8433b7d ] NIFI-13118: Add LANGUAGE to property_descriptor list Signed-off-by: Joe Gresock This closes #8720. > ChunkDocument python processor not works with Split code - 'NoneType' object > has no attribute 'getValue' > > > Key: NIFI-13118 > URL: https://issues.apache.org/jira/browse/NIFI-13118 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 2.0.0-M1, 2.0.0-M2, 2.0.0-M3 >Reporter: Zoltán Kornél Török >Assignee: Zoltán Kornél Török >Priority: Major > Labels: python > Time Spent: 10m > Remaining Estimate: 0h > > When you want to use ChunkDocument with split code settings we got : > {code:java} > PythonProcessor[type=ChunkDocument, id=e1f5691a-4845-3529-9b8b-052300f15375] > Failed to transform FlowFile[filename=1ad079db-cb83-49bc-8208-c1e35c5d8c52]: > py4j.Py4JException: An exception was raised by the Python Proxy. Return > Message: Traceback (most recent call last): > File "/opt/nifi/nifi-current/python/framework/py4j/java_gateway.py", line > 2466, in _call_proxy > return_value = getattr(self.pool[obj_id], method)(*params) > File "/opt/nifi/nifi-current/python/api/nifiapi/flowfiletransform.py", line > 33, in transformFlowFile > return self.transform(self.process_context, flowfile) > File "/opt/nifi/nifi-current/./python/extensions/ChunkDocument.py", line > 281, in transform > split_docs = self.split_docs(context, flowfile, documents) > File "/opt/nifi/nifi-current/./python/extensions/ChunkDocument.py", line > 212, in split_docs > language=context.getProperty(self.LANGUAGE).getValue(), > AttributeError: 'NoneType' object has no attribute 'getValue' {code} > It seems the LANGUAGE property is missing from the property_descriptors list, > and because of that it is not appear on the ui and the default value also not > initialize properly. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13118: Add LANGUAGE to property_descriptor list [nifi]
asfgit closed pull request #8720: NIFI-13118: Add LANGUAGE to property_descriptor list URL: https://github.com/apache/nifi/pull/8720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13093) better align nifi warn and material warn palettes
[ https://issues.apache.org/jira/browse/NIFI-13093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13093: --- Status: Patch Available (was: In Progress) > better align nifi warn and material warn palettes > - > > Key: NIFI-13093 > URL: https://issues.apache.org/jira/browse/NIFI-13093 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > When to use which palette? Or can we combine into a single palette? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13119) Resolve dependent value through Parameter is necessary
Matt Gilman created NIFI-13119: -- Summary: Resolve dependent value through Parameter is necessary Key: NIFI-13119 URL: https://issues.apache.org/jira/browse/NIFI-13119 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Matt Gilman Assignee: Matt Gilman When evaluating dependent Properties, the UI should identify when the Property value is a parameter reference and resolve the value accordingly. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13114: Only showing the primary node indicator when the node is clustered [nifi]
rfellows commented on PR #8713: URL: https://github.com/apache/nifi/pull/8713#issuecomment-2087190909 Will review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12833) Style "Primary Node Only" properly for both light and dark modes
[ https://issues.apache.org/jira/browse/NIFI-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842498#comment-17842498 ] ASF subversion and git services commented on NIFI-12833: Commit 280015749f1c9f94c384ed9dcf9ce32dfbee6d37 in nifi's branch refs/heads/main from Scott Aslan [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=280015749f ] [NIFI-13095] surface and contrast improvements (#8707) * [NIFI-13095] surface and contrast improvements * [NIFI-12833] primary node icon light/dark mode styling * [NIFI-13101] error page background color now matches light/dark theme * update PG and RPG names to use the material palette contrast color * update listing header text to use the material palette contrast color * update draggable icon hover styles * use surface contrast color for banners * use nifi-surface-default * update to use material primary contrast color for text displayed on top of material surfaces * restore context menu border * restore material theme * fix selected listing table style * remove unused themeing service * remove more invalid files * add even classes * restore yes-no scss * add even class to process-group-stats-in-out and remote-process-group-received-stats * update table hover and selection styles This closes #8707 > Style "Primary Node Only" properly for both light and dark modes > > > Key: NIFI-12833 > URL: https://issues.apache.org/jira/browse/NIFI-12833 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Scott Aslan >Priority: Major > Attachments: Screenshot 2024-02-22 at 10.43.01 AM.png, Screenshot > 2024-02-22 at 10.43.12 AM.png, Screenshot 2024-02-22 at 10.43.32 AM.png, > Screenshot 2024-02-22 at 10.43.54 AM.png > > Time Spent: 10m > Remaining Estimate: 0h > > We display an "icon" when a processor is "Primary Node Only". It shows on the > canvas as well as on the Summary listing. In reality these aren't actually > icons but DOM elements styled to look like icons. We should be consistent in > how they are displayed in both light and dark mode. > > !Screenshot 2024-02-22 at 10.43.54 AM.png!!Screenshot 2024-02-22 at 10.43.32 > AM.png! > > !Screenshot 2024-02-22 at 10.43.12 AM.png!!Screenshot 2024-02-22 at 10.43.01 > AM.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13095) UI - contrast ratio for processor type and bundle
[ https://issues.apache.org/jira/browse/NIFI-13095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13095: --- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > UI - contrast ratio for processor type and bundle > - > > Key: NIFI-13095 > URL: https://issues.apache.org/jira/browse/NIFI-13095 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Fix For: 2.0.0-M3 > > Attachments: image.png > > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13101) Full Screen Error is not themed for dark mode
[ https://issues.apache.org/jira/browse/NIFI-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842499#comment-17842499 ] ASF subversion and git services commented on NIFI-13101: Commit 280015749f1c9f94c384ed9dcf9ce32dfbee6d37 in nifi's branch refs/heads/main from Scott Aslan [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=280015749f ] [NIFI-13095] surface and contrast improvements (#8707) * [NIFI-13095] surface and contrast improvements * [NIFI-12833] primary node icon light/dark mode styling * [NIFI-13101] error page background color now matches light/dark theme * update PG and RPG names to use the material palette contrast color * update listing header text to use the material palette contrast color * update draggable icon hover styles * use surface contrast color for banners * use nifi-surface-default * update to use material primary contrast color for text displayed on top of material surfaces * restore context menu border * restore material theme * fix selected listing table style * remove unused themeing service * remove more invalid files * add even classes * restore yes-no scss * add even class to process-group-stats-in-out and remote-process-group-received-stats * update table hover and selection styles This closes #8707 > Full Screen Error is not themed for dark mode > - > > Key: NIFI-13101 > URL: https://issues.apache.org/jira/browse/NIFI-13101 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Scott Aslan >Priority: Major > Attachments: Screenshot 2024-04-25 at 1.55.09 PM.png, Screenshot > 2024-04-25 at 1.56.37 PM.png > > > When in dark mode, if you encounter an error that routes the user to a full > screen error... you can't read the error message. The text is light due to > dark mode being set but the background is not themed to be dark, so the text > is hidden. > > !Screenshot 2024-04-25 at 1.55.09 PM.png|width=581,height=310! > > !Screenshot 2024-04-25 at 1.56.37 PM.png|width=579,height=310! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13101) Full Screen Error is not themed for dark mode
[ https://issues.apache.org/jira/browse/NIFI-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13101: --- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > Full Screen Error is not themed for dark mode > - > > Key: NIFI-13101 > URL: https://issues.apache.org/jira/browse/NIFI-13101 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Scott Aslan >Priority: Major > Fix For: 2.0.0-M3 > > Attachments: Screenshot 2024-04-25 at 1.55.09 PM.png, Screenshot > 2024-04-25 at 1.56.37 PM.png > > > When in dark mode, if you encounter an error that routes the user to a full > screen error... you can't read the error message. The text is light due to > dark mode being set but the background is not themed to be dark, so the text > is hidden. > > !Screenshot 2024-04-25 at 1.55.09 PM.png|width=581,height=310! > > !Screenshot 2024-04-25 at 1.56.37 PM.png|width=579,height=310! -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13095] surface and contrast improvements [nifi]
rfellows merged PR #8707: URL: https://github.com/apache/nifi/pull/8707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13095) UI - contrast ratio for processor type and bundle
[ https://issues.apache.org/jira/browse/NIFI-13095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842497#comment-17842497 ] ASF subversion and git services commented on NIFI-13095: Commit 280015749f1c9f94c384ed9dcf9ce32dfbee6d37 in nifi's branch refs/heads/main from Scott Aslan [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=280015749f ] [NIFI-13095] surface and contrast improvements (#8707) * [NIFI-13095] surface and contrast improvements * [NIFI-12833] primary node icon light/dark mode styling * [NIFI-13101] error page background color now matches light/dark theme * update PG and RPG names to use the material palette contrast color * update listing header text to use the material palette contrast color * update draggable icon hover styles * use surface contrast color for banners * use nifi-surface-default * update to use material primary contrast color for text displayed on top of material surfaces * restore context menu border * restore material theme * fix selected listing table style * remove unused themeing service * remove more invalid files * add even classes * restore yes-no scss * add even class to process-group-stats-in-out and remote-process-group-received-stats * update table hover and selection styles This closes #8707 > UI - contrast ratio for processor type and bundle > - > > Key: NIFI-13095 > URL: https://issues.apache.org/jira/browse/NIFI-13095 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Attachments: image.png > > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-13118: Add LANGUAGE to property_descriptor list [nifi]
taz1988 opened a new pull request, #8720: URL: https://github.com/apache/nifi/pull/8720 # Summary [NIFI-13118](https://issues.apache.org/jira/browse/NIFI-13118) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI-13118) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-13118` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-13118` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-13118) ChunkDocument python processor not works with Split code - 'NoneType' object has no attribute 'getValue'
Zoltán Kornél Török created NIFI-13118: -- Summary: ChunkDocument python processor not works with Split code - 'NoneType' object has no attribute 'getValue' Key: NIFI-13118 URL: https://issues.apache.org/jira/browse/NIFI-13118 Project: Apache NiFi Issue Type: Bug Affects Versions: 2.0.0-M2, 2.0.0-M1, 2.0.0-M3 Reporter: Zoltán Kornél Török Assignee: Zoltán Kornél Török When you want to use ChunkDocument with split code settings we got : {code:java} PythonProcessor[type=ChunkDocument, id=e1f5691a-4845-3529-9b8b-052300f15375] Failed to transform FlowFile[filename=1ad079db-cb83-49bc-8208-c1e35c5d8c52]: py4j.Py4JException: An exception was raised by the Python Proxy. Return Message: Traceback (most recent call last): File "/opt/nifi/nifi-current/python/framework/py4j/java_gateway.py", line 2466, in _call_proxy return_value = getattr(self.pool[obj_id], method)(*params) File "/opt/nifi/nifi-current/python/api/nifiapi/flowfiletransform.py", line 33, in transformFlowFile return self.transform(self.process_context, flowfile) File "/opt/nifi/nifi-current/./python/extensions/ChunkDocument.py", line 281, in transform split_docs = self.split_docs(context, flowfile, documents) File "/opt/nifi/nifi-current/./python/extensions/ChunkDocument.py", line 212, in split_docs language=context.getProperty(self.LANGUAGE).getValue(), AttributeError: 'NoneType' object has no attribute 'getValue' {code} It seems the LANGUAGE property is missing from the property_descriptors list, and because of that it is not appear on the ui and the default value also not initialize properly. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13113: upgrade Iceberg from 1.5.0 to 1.5.1 [nifi]
sullis commented on PR #8712: URL: https://github.com/apache/nifi/pull/8712#issuecomment-2086862104 > Good call out. Let's wait for 1.5.2 Agreed. I will close this PR. I will open a new PR when Iceberg 1.5.2 is available. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-13117) Update resize handle
Matt Gilman created NIFI-13117: -- Summary: Update resize handle Key: NIFI-13117 URL: https://issues.apache.org/jira/browse/NIFI-13117 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Matt Gilman The current resize handle shown on the editor and diagnostic modal too closely resembles the comment indicator shown on the canvas. We should consider some alternatives for resize handle to maybe more closely resemble the textarea resize handle. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MINIFICPP-2346) Speed up MiNiFi Build with Conan package manager (C++)
[ https://issues.apache.org/jira/browse/MINIFICPP-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842449#comment-17842449 ] James Guzman (Medel) edited comment on MINIFICPP-2346 at 4/30/24 6:44 PM: -- I think it may be beneficial to leverage conan at the beginning for installing MiNiFi C++ external lib dependencies (conan supports Linux and Windows packages). For my medical robotics company, I created an ezconan python wrapper tool around conan for speeding up our C++ cmake build infrastructure for our medical robot. I can build that code on Linux and Windows with no issues and the rest of the software team and our other engineering teams use our build infrastructure. I wanted to try adding support for conan to the MiNiFi C++ project too since I am looking at using MiNiFi C++ to develop edge data pipelines programmatically as alternative to the yml approach. As for the vcpkg, CMake can generate those build files when we run CMake generate on Windows. Similar for Makefiles, where we run CMake generate on Linux and CMake generates them too. I will follow up on this thread with updates to my progress on conan for speeding up MiNiFi C++ builds [~szaszm] . I will keep you posted. I am also considering creating a MiNiFI C++ conan package that I can smoothly integrate MiNiFi C++ lib into other C++ projects like in my medical imaging robot. was (Author: james.medel): I think it may be beneficial to leverage conan at the beginning for installing MiNiFi C++ external lib dependencies (conan supports Linux and Windows packages). For my medical robotics company, I created an ezconan python wrapper tool around conan for speeding up our C++ cmake build infrastructure for our medical robot. I can build that code on Linux and Windows. I wanted to try adding support for conan to the MiNiFi C++ project too since I am looking at using MiNiFi C++ to develop edge data pipelines programmatically as alternative to the yml approach. As for the vcpkg, CMake can generate those build files when we run CMake generate on Windows. Similar for Makefiles, where we run CMake generate on Linux and CMake generates them too. I will follow up on this thread with updates to my progress on conan for speeding up MiNiFi C++ builds [~szaszm] . I will keep you posted. I am also considering creating a MiNiFI C++ conan package that I can smoothly integrate MiNiFi C++ lib into other C++ projects like in my medical imaging robot. > Speed up MiNiFi Build with Conan package manager (C++) > -- > > Key: MINIFICPP-2346 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2346 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Affects Versions: 0.15.0 > Environment: Ubuntu 22.04 >Reporter: James Guzman (Medel) >Assignee: James Guzman (Medel) >Priority: Minor > Labels: build, conan, ubuntu > > *Description of Issue:* Building MiNiFi C++ with just CMake is really slow. > During the the build process, it clones all the external dependencies and > then builds those external dependencies while its building MiNiFi CPP. > Sometimes the MiNiFi CPP build fails too when external lib dependencies fail > to download or fail to build. It would be faster to build MiNiFi C++ with the > external dependencies already preinstalled. > > *Potential Solution:* Integrate *conan version 2* into MiNiFi C++ project to > enable support for using *conan install* to install all or most of MiNiFi's > external dependencies, using *conan install --build=missing* to build them as > prebuilt binary conan packages, upload them to conancenter with {*}conan > upload{*}, and then run cmake generate to generate the appropriate build > files for the OS, then run make to build MiNiFi CPP. Also conan has really > good support for cross platform compatibility for Linux and Windows. At this > point because we already have most of MiNiFi CPP's external lib dependencies > installed with conan, our CMake build will just focus on building the MiNiFi > CPP code, enabling faster builds. Also I will need to account for backward > compatibility support with the previous way of installing MiNiFi CPP external > lib dependencies using CMake FetchContent_Declare(...) approach until > conanfile.py approach covers installing all these dependencies. A valid > verification of the MiNiFi C++ build would be to run GTESTs and if all the > expected test cases pass, then it may be fair to conclude we would be ready > to deprecate the slow CMake FetchContent_Declare(...) approach. > > *Steps to Perform MiNiFi C++ Build Enhancement (Plan to Integrate into > script(s)):* > # Install conan version 2 into MiNiFi C++ dev environment (my preference is > using docker container)
Re: [PR] NIFI-13113: upgrade Iceberg from 1.5.0 to 1.5.1 [nifi]
joewitt commented on PR #8712: URL: https://github.com/apache/nifi/pull/8712#issuecomment-2086268562 Good call out. Let's wait for 1.5.2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13113: upgrade Iceberg from 1.5.0 to 1.5.1 [nifi]
Kapkiai commented on PR #8712: URL: https://github.com/apache/nifi/pull/8712#issuecomment-2086240364 There is an issue on iceberg side https://github.com/apache/iceberg/issues/10251 where artifacts for scala2.12 seems to have been compiled with scala 2.13. I don’t think it affects NiFi, however, I think it is good we wait for a fix/patch release. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MINIFICPP-2346) Speed up MiNiFi Build with Conan package manager (C++)
[ https://issues.apache.org/jira/browse/MINIFICPP-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842451#comment-17842451 ] James Guzman (Medel) edited comment on MINIFICPP-2346 at 4/30/24 5:07 PM: -- [~szaszm] Does MiNiFi C++ have a jfrog repo where we can host conan repos publicly (alternative to conancenter)? In case I need to build conan packages for MiNiFi C++ external lib dependencies and upload them as prebuilt binary conan packages to jfrog. We could create a jfrog Windows repo for MiNiFi CPP's external libs built for Windows and a jfrog Linux repo for MiNiFi CPP's external libs built for Linux. Here is Jfrog: [https://jfrog.com/] was (Author: james.medel): [~szaszm] Does MiNiFi C++ have a jfrog repo where we can host conan repos (alternative to conancenter)? In case I need to build conan packages for MiNiFi C++ external lib dependencies and upload them as prebuilt binary conan packages to jfrog. We could create a jfrog Windows repo for MiNiFi CPP's external libs built for Windows and a jfrog Linux repo for MiNiFi CPP's external libs built for Linux. Here is Jfrog: [https://jfrog.com/] > Speed up MiNiFi Build with Conan package manager (C++) > -- > > Key: MINIFICPP-2346 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2346 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Affects Versions: 0.15.0 > Environment: Ubuntu 22.04 >Reporter: James Guzman (Medel) >Assignee: James Guzman (Medel) >Priority: Minor > Labels: build, conan, ubuntu > > *Description of Issue:* Building MiNiFi C++ with just CMake is really slow. > During the the build process, it clones all the external dependencies and > then builds those external dependencies while its building MiNiFi CPP. > Sometimes the MiNiFi CPP build fails too when external lib dependencies fail > to download or fail to build. It would be faster to build MiNiFi C++ with the > external dependencies already preinstalled. > > *Potential Solution:* Integrate *conan version 2* into MiNiFi C++ project to > enable support for using *conan install* to install all or most of MiNiFi's > external dependencies, using *conan install --build=missing* to build them as > prebuilt binary conan packages, upload them to conancenter with {*}conan > upload{*}, and then run cmake generate to generate the appropriate build > files for the OS, then run make to build MiNiFi CPP. Also conan has really > good support for cross platform compatibility for Linux and Windows. At this > point because we already have most of MiNiFi CPP's external lib dependencies > installed with conan, our CMake build will just focus on building the MiNiFi > CPP code, enabling faster builds. Also I will need to account for backward > compatibility support with the previous way of installing MiNiFi CPP external > lib dependencies using CMake FetchContent_Declare(...) approach until > conanfile.py approach covers installing all these dependencies. A valid > verification of the MiNiFi C++ build would be to run GTESTs and if all the > expected test cases pass, then it may be fair to conclude we would be ready > to deprecate the slow CMake FetchContent_Declare(...) approach. > > *Steps to Perform MiNiFi C++ Build Enhancement (Plan to Integrate into > script(s)):* > # Install conan version 2 into MiNiFi C++ dev environment (my preference is > using docker container) > # Create a conanfile.py file at root of MiNiFi C++ project where we run > "conan install" or "conan install --build=missing" to install MiNiFi C++ > external lib dependencies first. Then we run CMake to build MiNiFi C++. > # Find all MiNiFi C++ find_package(...) CMake function calls and check if > there is already supported conan packages on the conancenter, so we can > install those packages. > # Find all FetchContent_Declare(...) CMake function calls and check if there > is already supported conan packages on the conancenter, so we can install > those packages. > # At this point we will have used conan version 2 C++ package manager to > install almost all MiNiFi C++'s external dependencies. > ## With Conan, we will have installed these MiNiFi external lib dependencies > as prebuilt binary conan packages. > ## Or we will have instructed conan to first build each C++ external lib > dependency, upload each lib to conancenter. > # Thus, conan manages installing MiNiFi C++'s external lib dependencies, so > we can then run CMake to build MiNiFi faster. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MINIFICPP-2355) Build fails if CMAKE_BUILD_TYPE is not defined
[ https://issues.apache.org/jira/browse/MINIFICPP-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz resolved MINIFICPP-2355. - Resolution: Fixed > Build fails if CMAKE_BUILD_TYPE is not defined > -- > > Key: MINIFICPP-2355 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2355 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > Build fails with default `cmake .. && make` command due to CMAKE_BUILD_TYPE > not being defined, which is interpreted differently between subprojects. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MINIFICPP-2346) Speed up MiNiFi Build with Conan package manager (C++)
[ https://issues.apache.org/jira/browse/MINIFICPP-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842451#comment-17842451 ] James Guzman (Medel) edited comment on MINIFICPP-2346 at 4/30/24 5:04 PM: -- [~szaszm] Does MiNiFi C++ have a jfrog repo where we can host conan repos (alternative to conancenter)? In case I need to build conan packages for MiNiFi C++ external lib dependencies and upload them as prebuilt binary conan packages to jfrog. We could create a jfrog Windows repo for MiNiFi CPP's external libs built for Windows and a jfrog Linux repo for MiNiFi CPP's external libs built for Linux. Here is Jfrog: [https://jfrog.com/] was (Author: james.medel): [~szaszm] Does MiNiFi C++ have a jfrog repo where we can host conan repos (alternative to conancenter)? In case I need to build conan packages for MiNiFi C++ external lib dependencies and upload them as prebuilt binary conan packages to jfrog. We could create a jfrog Windows repo for MiNiFi C++'s external libs built for Windows and a jfrog Linux repo for MiNiFi C++'s external libs built for Linux. Here is Jfrog: https://jfrog.com/ > Speed up MiNiFi Build with Conan package manager (C++) > -- > > Key: MINIFICPP-2346 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2346 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Affects Versions: 0.15.0 > Environment: Ubuntu 22.04 >Reporter: James Guzman (Medel) >Assignee: James Guzman (Medel) >Priority: Minor > Labels: build, conan, ubuntu > > *Description of Issue:* Building MiNiFi C++ with just CMake is really slow. > During the the build process, it clones all the external dependencies and > then builds those external dependencies while its building MiNiFi CPP. > Sometimes the MiNiFi CPP build fails too when external lib dependencies fail > to download or fail to build. It would be faster to build MiNiFi C++ with the > external dependencies already preinstalled. > > *Potential Solution:* Integrate *conan version 2* into MiNiFi C++ project to > enable support for using *conan install* to install all or most of MiNiFi's > external dependencies, using *conan install --build=missing* to build them as > prebuilt binary conan packages, upload them to conancenter with {*}conan > upload{*}, and then run cmake generate to generate the appropriate build > files for the OS, then run make to build MiNiFi CPP. Also conan has really > good support for cross platform compatibility for Linux and Windows. At this > point because we already have most of MiNiFi CPP's external lib dependencies > installed with conan, our CMake build will just focus on building the MiNiFi > CPP code, enabling faster builds. Also I will need to account for backward > compatibility support with the previous way of installing MiNiFi CPP external > lib dependencies using CMake FetchContent_Declare(...) approach until > conanfile.py approach covers installing all these dependencies. A valid > verification of the MiNiFi C++ build would be to run GTESTs and if all the > expected test cases pass, then it may be fair to conclude we would be ready > to deprecate the slow CMake FetchContent_Declare(...) approach. > > *Steps to Perform MiNiFi C++ Build Enhancement (Plan to Integrate into > script(s)):* > # Install conan version 2 into MiNiFi C++ dev environment (my preference is > using docker container) > # Create a conanfile.py file at root of MiNiFi C++ project where we run > "conan install" or "conan install --build=missing" to install MiNiFi C++ > external lib dependencies first. Then we run CMake to build MiNiFi C++. > # Find all MiNiFi C++ find_package(...) CMake function calls and check if > there is already supported conan packages on the conancenter, so we can > install those packages. > # Find all FetchContent_Declare(...) CMake function calls and check if there > is already supported conan packages on the conancenter, so we can install > those packages. > # At this point we will have used conan version 2 C++ package manager to > install almost all MiNiFi C++'s external dependencies. > ## With Conan, we will have installed these MiNiFi external lib dependencies > as prebuilt binary conan packages. > ## Or we will have instructed conan to first build each C++ external lib > dependency, upload each lib to conancenter. > # Thus, conan manages installing MiNiFi C++'s external lib dependencies, so > we can then run CMake to build MiNiFi faster. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2355) Build fails if CMAKE_BUILD_TYPE is not defined
[ https://issues.apache.org/jira/browse/MINIFICPP-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2355: Fix Version/s: 0.99.0 > Build fails if CMAKE_BUILD_TYPE is not defined > -- > > Key: MINIFICPP-2355 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2355 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Major > Fix For: 0.99.0 > > Time Spent: 40m > Remaining Estimate: 0h > > Build fails with default `cmake .. && make` command due to CMAKE_BUILD_TYPE > not being defined, which is interpreted differently between subprojects. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2355 Fix build if CMAKE_BUILD_TYPE is undefined [nifi-minifi-cpp]
szaszm closed pull request #1774: MINIFICPP-2355 Fix build if CMAKE_BUILD_TYPE is undefined URL: https://github.com/apache/nifi-minifi-cpp/pull/1774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13102) Error Handling in Convert to Parameter and Empty Queue
[ https://issues.apache.org/jira/browse/NIFI-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13102: --- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > Error Handling in Convert to Parameter and Empty Queue > -- > > Key: NIFI-13102 > URL: https://issues.apache.org/jira/browse/NIFI-13102 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 20m > Remaining Estimate: 0h > > Currently, any API errors that occurs when converting to parameter or empty > queues are persisted in the store but not currently presented to the user. > These details should be surfaced either through a banner, full page, or snack > bar error. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MINIFICPP-2346) Speed up MiNiFi Build with Conan package manager (C++)
[ https://issues.apache.org/jira/browse/MINIFICPP-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842451#comment-17842451 ] James Guzman (Medel) commented on MINIFICPP-2346: - [~szaszm] Does MiNiFi C++ have a jfrog repo where we can host conan repos (alternative to conancenter)? In case I need to build conan packages for MiNiFi C++ external lib dependencies and upload them as prebuilt binary conan packages to jfrog. We could create a jfrog Windows repo for MiNiFi C++'s external libs built for Windows and a jfrog Linux repo for MiNiFi C++'s external libs built for Linux. Here is Jfrog: https://jfrog.com/ > Speed up MiNiFi Build with Conan package manager (C++) > -- > > Key: MINIFICPP-2346 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2346 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Affects Versions: 0.15.0 > Environment: Ubuntu 22.04 >Reporter: James Guzman (Medel) >Assignee: James Guzman (Medel) >Priority: Minor > Labels: build, conan, ubuntu > > *Description of Issue:* Building MiNiFi C++ with just CMake is really slow. > During the the build process, it clones all the external dependencies and > then builds those external dependencies while its building MiNiFi CPP. > Sometimes the MiNiFi CPP build fails too when external lib dependencies fail > to download or fail to build. It would be faster to build MiNiFi C++ with the > external dependencies already preinstalled. > > *Potential Solution:* Integrate *conan version 2* into MiNiFi C++ project to > enable support for using *conan install* to install all or most of MiNiFi's > external dependencies, using *conan install --build=missing* to build them as > prebuilt binary conan packages, upload them to conancenter with {*}conan > upload{*}, and then run cmake generate to generate the appropriate build > files for the OS, then run make to build MiNiFi CPP. Also conan has really > good support for cross platform compatibility for Linux and Windows. At this > point because we already have most of MiNiFi CPP's external lib dependencies > installed with conan, our CMake build will just focus on building the MiNiFi > CPP code, enabling faster builds. Also I will need to account for backward > compatibility support with the previous way of installing MiNiFi CPP external > lib dependencies using CMake FetchContent_Declare(...) approach until > conanfile.py approach covers installing all these dependencies. A valid > verification of the MiNiFi C++ build would be to run GTESTs and if all the > expected test cases pass, then it may be fair to conclude we would be ready > to deprecate the slow CMake FetchContent_Declare(...) approach. > > *Steps to Perform MiNiFi C++ Build Enhancement (Plan to Integrate into > script(s)):* > # Install conan version 2 into MiNiFi C++ dev environment (my preference is > using docker container) > # Create a conanfile.py file at root of MiNiFi C++ project where we run > "conan install" or "conan install --build=missing" to install MiNiFi C++ > external lib dependencies first. Then we run CMake to build MiNiFi C++. > # Find all MiNiFi C++ find_package(...) CMake function calls and check if > there is already supported conan packages on the conancenter, so we can > install those packages. > # Find all FetchContent_Declare(...) CMake function calls and check if there > is already supported conan packages on the conancenter, so we can install > those packages. > # At this point we will have used conan version 2 C++ package manager to > install almost all MiNiFi C++'s external dependencies. > ## With Conan, we will have installed these MiNiFi external lib dependencies > as prebuilt binary conan packages. > ## Or we will have instructed conan to first build each C++ external lib > dependency, upload each lib to conancenter. > # Thus, conan manages installing MiNiFi C++'s external lib dependencies, so > we can then run CMake to build MiNiFi faster. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13102) Error Handling in Convert to Parameter and Empty Queue
[ https://issues.apache.org/jira/browse/NIFI-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842450#comment-17842450 ] ASF subversion and git services commented on NIFI-13102: Commit 67b387e5c7a5e5bef82bcacd26c2be9ffc34f0c5 in nifi's branch refs/heads/main from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=67b387e5c7 ] NIFI-13102: (#8704) - Updating API error handling for Convert to Parameter and Empty Queue. This closes #8704 > Error Handling in Convert to Parameter and Empty Queue > -- > > Key: NIFI-13102 > URL: https://issues.apache.org/jira/browse/NIFI-13102 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Currently, any API errors that occurs when converting to parameter or empty > queues are persisted in the store but not currently presented to the user. > These details should be surfaced either through a banner, full page, or snack > bar error. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13102: Updating API error handling for Convert to Parameter and Empty Queue [nifi]
rfellows merged PR #8704: URL: https://github.com/apache/nifi/pull/8704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MINIFICPP-2346) Speed up MiNiFi Build with Conan package manager (C++)
[ https://issues.apache.org/jira/browse/MINIFICPP-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842449#comment-17842449 ] James Medel edited comment on MINIFICPP-2346 at 4/30/24 4:58 PM: - I think it may be beneficial to leverage conan at the beginning for installing MiNiFi C++ external lib dependencies (conan supports Linux and Windows packages). For my medical robotics company, I created an ezconan python wrapper tool around conan for speeding up our C++ cmake build infrastructure for our medical robot. I can build that code on Linux and Windows. I wanted to try adding support for conan to the MiNiFi C++ project too since I am looking at using MiNiFi C++ to develop edge data pipelines programmatically as alternative to the yml approach. As for the vcpkg, CMake can generate those build files when we run CMake generate on Windows. Similar for Makefiles, where we run CMake generate on Linux and CMake generates them too. I will follow up on this thread with updates to my progress on conan for speeding up MiNiFi C++ builds [~szaszm] . I will keep you posted. I am also considering creating a MiNiFI C++ conan package that I can smoothly integrate MiNiFi C++ lib into other C++ projects like in my medical imaging robot. was (Author: james.medel): I think it may be beneficial to leverage conan at the beginning for installing MiNiFi C++ external lib dependencies (conan supports Linux and Windows packages). For my medical robotics company, I created an ezconan python wrapper tool around conan for speeding up our C++ cmake build infrastructure for our medical robot. I can build that code on Linux and Windows. I wanted to try adding support for conan to the MiNiFi C++ project too since I am looking at using MiNiFi C++ to develop edge data pipelines programmatically as alternative to the yml approach. As for the vcpkg, CMake can generate those build files when we run CMake generate on Windows. I will follow up on this thread with updates to my progress on conan for speeding up MiNiFi C++ builds [~szaszm] . I will keep you posted. I am also considering creating a MiNiFI C++ conan package that I can smoothly integrate MiNiFi C++ lib into other C++ projects like in my medical imaging robot. > Speed up MiNiFi Build with Conan package manager (C++) > -- > > Key: MINIFICPP-2346 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2346 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Affects Versions: 0.15.0 > Environment: Ubuntu 22.04 >Reporter: James Medel >Assignee: James Medel >Priority: Minor > Labels: build, conan, ubuntu > > *Description of Issue:* Building MiNiFi C++ with just CMake is really slow. > During the the build process, it clones all the external dependencies and > then builds those external dependencies while its building MiNiFi CPP. > Sometimes the MiNiFi CPP build fails too when external lib dependencies fail > to download or fail to build. It would be faster to build MiNiFi C++ with the > external dependencies already preinstalled. > > *Potential Solution:* Integrate *conan version 2* into MiNiFi C++ project to > enable support for using *conan install* to install all or most of MiNiFi's > external dependencies, using *conan install --build=missing* to build them as > prebuilt binary conan packages, upload them to conancenter with {*}conan > upload{*}, and then run cmake generate to generate the appropriate build > files for the OS, then run make to build MiNiFi CPP. Also conan has really > good support for cross platform compatibility for Linux and Windows. At this > point because we already have most of MiNiFi CPP's external lib dependencies > installed with conan, our CMake build will just focus on building the MiNiFi > CPP code, enabling faster builds. Also I will need to account for backward > compatibility support with the previous way of installing MiNiFi CPP external > lib dependencies using CMake FetchContent_Declare(...) approach until > conanfile.py approach covers installing all these dependencies. A valid > verification of the MiNiFi C++ build would be to run GTESTs and if all the > expected test cases pass, then it may be fair to conclude we would be ready > to deprecate the slow CMake FetchContent_Declare(...) approach. > > *Steps to Perform MiNiFi C++ Build Enhancement (Plan to Integrate into > script(s)):* > # Install conan version 2 into MiNiFi C++ dev environment (my preference is > using docker container) > # Create a conanfile.py file at root of MiNiFi C++ project where we run > "conan install" or "conan install --build=missing" to install MiNiFi C++ > external lib dependencies first. Then we run CMake to build MiNiFi C++. > # Find all
[jira] [Commented] (MINIFICPP-2346) Speed up MiNiFi Build with Conan package manager (C++)
[ https://issues.apache.org/jira/browse/MINIFICPP-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842449#comment-17842449 ] James Medel commented on MINIFICPP-2346: I think it may be beneficial to leverage conan at the beginning for installing MiNiFi C++ external lib dependencies (conan supports Linux and Windows packages). For my medical robotics company, I created an ezconan python wrapper tool around conan for speeding up our C++ cmake build infrastructure for our medical robot. I can build that code on Linux and Windows. I wanted to try adding support for conan to the MiNiFi C++ project too since I am looking at using MiNiFi C++ to develop edge data pipelines programmatically as alternative to the yml approach. As for the vcpkg, CMake can generate those build files when we run CMake generate on Windows. I will follow up on this thread with updates to my progress on conan for speeding up MiNiFi C++ builds [~szaszm] . I will keep you posted. I am also considering creating a MiNiFI C++ conan package that I can smoothly integrate MiNiFi C++ lib into other C++ projects like in my medical imaging robot. > Speed up MiNiFi Build with Conan package manager (C++) > -- > > Key: MINIFICPP-2346 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2346 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Affects Versions: 0.15.0 > Environment: Ubuntu 22.04 >Reporter: James Medel >Assignee: James Medel >Priority: Minor > Labels: build, conan, ubuntu > > *Description of Issue:* Building MiNiFi C++ with just CMake is really slow. > During the the build process, it clones all the external dependencies and > then builds those external dependencies while its building MiNiFi CPP. > Sometimes the MiNiFi CPP build fails too when external lib dependencies fail > to download or fail to build. It would be faster to build MiNiFi C++ with the > external dependencies already preinstalled. > > *Potential Solution:* Integrate *conan version 2* into MiNiFi C++ project to > enable support for using *conan install* to install all or most of MiNiFi's > external dependencies, using *conan install --build=missing* to build them as > prebuilt binary conan packages, upload them to conancenter with {*}conan > upload{*}, and then run cmake generate to generate the appropriate build > files for the OS, then run make to build MiNiFi CPP. Also conan has really > good support for cross platform compatibility for Linux and Windows. At this > point because we already have most of MiNiFi CPP's external lib dependencies > installed with conan, our CMake build will just focus on building the MiNiFi > CPP code, enabling faster builds. Also I will need to account for backward > compatibility support with the previous way of installing MiNiFi CPP external > lib dependencies using CMake FetchContent_Declare(...) approach until > conanfile.py approach covers installing all these dependencies. A valid > verification of the MiNiFi C++ build would be to run GTESTs and if all the > expected test cases pass, then it may be fair to conclude we would be ready > to deprecate the slow CMake FetchContent_Declare(...) approach. > > *Steps to Perform MiNiFi C++ Build Enhancement (Plan to Integrate into > script(s)):* > # Install conan version 2 into MiNiFi C++ dev environment (my preference is > using docker container) > # Create a conanfile.py file at root of MiNiFi C++ project where we run > "conan install" or "conan install --build=missing" to install MiNiFi C++ > external lib dependencies first. Then we run CMake to build MiNiFi C++. > # Find all MiNiFi C++ find_package(...) CMake function calls and check if > there is already supported conan packages on the conancenter, so we can > install those packages. > # Find all FetchContent_Declare(...) CMake function calls and check if there > is already supported conan packages on the conancenter, so we can install > those packages. > # At this point we will have used conan version 2 C++ package manager to > install almost all MiNiFi C++'s external dependencies. > ## With Conan, we will have installed these MiNiFi external lib dependencies > as prebuilt binary conan packages. > ## Or we will have instructed conan to first build each C++ external lib > dependency, upload each lib to conancenter. > # Thus, conan manages installing MiNiFi C++'s external lib dependencies, so > we can then run CMake to build MiNiFi faster. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13115] update context menu, search results overalay, and nf edi… [nifi]
scottyaslan commented on code in PR #8714: URL: https://github.com/apache/nifi/pull/8714#discussion_r1585182484 ## nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/styles/_app.scss: ## @@ -354,8 +353,9 @@ } .property-editor { -background-color: $nifi-theme-surface-palette-darker; -box-shadow: 0 2px 5px rgba(0, 0, 0, 0.25); +background-color: var(--mat-menu-container-color); +box-shadow: 0 3px 6px rgba(0, 0, 0, 0.25); +border-radius: 4px; Review Comment: Good catch. I have updated it to be positioned like the other resized handles: ![Screenshot 2024-04-30 at 12 38 29 PM](https://github.com/apache/nifi/assets/6797571/ce62ade5-721c-4599-a582-49af20cd4aff) ![Screenshot 2024-04-30 at 12 37 55 PM](https://github.com/apache/nifi/assets/6797571/78563995-a128-4d3d-9b88-3906141fd79f) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13115] update context menu, search results overalay, and nf edi… [nifi]
scottyaslan commented on code in PR #8714: URL: https://github.com/apache/nifi/pull/8714#discussion_r1585182484 ## nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/styles/_app.scss: ## @@ -354,8 +353,9 @@ } .property-editor { -background-color: $nifi-theme-surface-palette-darker; -box-shadow: 0 2px 5px rgba(0, 0, 0, 0.25); +background-color: var(--mat-menu-container-color); +box-shadow: 0 3px 6px rgba(0, 0, 0, 0.25); +border-radius: 4px; Review Comment: Good catch. I have updated it to be positioned like the other resized handles: ![Screenshot 2024-04-30 at 12 37 55 PM](https://github.com/apache/nifi/assets/6797571/78563995-a128-4d3d-9b88-3906141fd79f) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-11423) Ability to Export Data Provenance Results as CSV
[ https://issues.apache.org/jira/browse/NIFI-11423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael W Moser resolved NIFI-11423. Resolution: Won't Do > Ability to Export Data Provenance Results as CSV > > > Key: NIFI-11423 > URL: https://issues.apache.org/jira/browse/NIFI-11423 > Project: Apache NiFi > Issue Type: New Feature > Components: Core Framework, Core UI >Reporter: Anson Yu >Priority: Minor > > Wanting to add a feature that allows a user to download the provenance as a > CSV for easier parsing. Currently only 1000 max is viewable for return, > looking to see if I can return a larger amount (within reason) and put into > CSV form. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11423) Ability to Export Data Provenance Results as CSV
[ https://issues.apache.org/jira/browse/NIFI-11423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842434#comment-17842434 ] Michael W Moser commented on NIFI-11423: >From within NiFi, InvokeHTTP can hit the REST nifi-api and retrieve provenance >events as JSON, then use a ConvertRecord to transform it to CSV. There doesn't appear to be a need to implement this in the NiFi UI. > Ability to Export Data Provenance Results as CSV > > > Key: NIFI-11423 > URL: https://issues.apache.org/jira/browse/NIFI-11423 > Project: Apache NiFi > Issue Type: New Feature > Components: Core Framework, Core UI >Reporter: Anson Yu >Priority: Minor > > Wanting to add a feature that allows a user to download the provenance as a > CSV for easier parsing. Currently only 1000 max is viewable for return, > looking to see if I can return a larger amount (within reason) and put into > CSV form. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-11423) Ability to Export Data Provenance Results as CSV
[ https://issues.apache.org/jira/browse/NIFI-11423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael W Moser reassigned NIFI-11423: -- Assignee: (was: Anson Yu) > Ability to Export Data Provenance Results as CSV > > > Key: NIFI-11423 > URL: https://issues.apache.org/jira/browse/NIFI-11423 > Project: Apache NiFi > Issue Type: New Feature > Components: Core Framework, Core UI >Reporter: Anson Yu >Priority: Minor > > Wanting to add a feature that allows a user to download the provenance as a > CSV for easier parsing. Currently only 1000 max is viewable for return, > looking to see if I can return a larger amount (within reason) and put into > CSV form. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-10752) Update Couchbase client to 3.x
[ https://issues.apache.org/jira/browse/NIFI-10752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess reassigned NIFI-10752: --- Assignee: Matt Burgess (was: Jeyassri Balachandran) > Update Couchbase client to 3.x > -- > > Key: NIFI-10752 > URL: https://issues.apache.org/jira/browse/NIFI-10752 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.18.0 >Reporter: Mike R >Assignee: Matt Burgess >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > Update com.couchbase.client.java-client to latest 3.x to remediate CVEs in > the program > Here are the release notes: [SDK Release Notes | Couchbase > Docs|https://docs.couchbase.com/java-sdk/current/project-docs/sdk-release-notes.html] -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2355 Fix build if CMAKE_BUILD_TYPE is undefined [nifi-minifi-cpp]
lordgamez commented on code in PR #1774: URL: https://github.com/apache/nifi-minifi-cpp/pull/1774#discussion_r1585105439 ## CMakeLists.txt: ## @@ -25,6 +25,10 @@ cmake_policy(SET CMP0135 NEW) # policy to set the timestamps of extracted conten project(nifi-minifi-cpp VERSION 0.99.0) set(PROJECT_NAME "nifi-minifi-cpp") +if (NOT CMAKE_BUILD_TYPE) +set(CMAKE_BUILD_TYPE "Release" CACHE STRING "Built type" FORCE) Review Comment: Fixed in d820cad82ffc9c44fbe2a34d1ad6ad6d8a9b013d -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2355 Fix build if CMAKE_BUILD_TYPE is undefined [nifi-minifi-cpp]
szaszm commented on code in PR #1774: URL: https://github.com/apache/nifi-minifi-cpp/pull/1774#discussion_r1585102353 ## CMakeLists.txt: ## @@ -25,6 +25,10 @@ cmake_policy(SET CMP0135 NEW) # policy to set the timestamps of extracted conten project(nifi-minifi-cpp VERSION 0.99.0) set(PROJECT_NAME "nifi-minifi-cpp") +if (NOT CMAKE_BUILD_TYPE) +set(CMAKE_BUILD_TYPE "Release" CACHE STRING "Built type" FORCE) Review Comment: ```suggestion set(CMAKE_BUILD_TYPE "Release" CACHE STRING "Build type" FORCE) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] MINIFICPP-2355 Fix build if CMAKE_BUILD_TYPE is undefined [nifi-minifi-cpp]
lordgamez opened a new pull request, #1774: URL: https://github.com/apache/nifi-minifi-cpp/pull/1774 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINIFICPP-2355) Build fails if CMAKE_BUILD_TYPE is not defined
Gábor Gyimesi created MINIFICPP-2355: Summary: Build fails if CMAKE_BUILD_TYPE is not defined Key: MINIFICPP-2355 URL: https://issues.apache.org/jira/browse/MINIFICPP-2355 Project: Apache NiFi MiNiFi C++ Issue Type: Bug Reporter: Gábor Gyimesi Assignee: Gábor Gyimesi Build fails with default `cmake .. && make` command due to CMAKE_BUILD_TYPE not being defined, which is interpreted differently between subprojects. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13110) Auto select relation in Create Connection
[ https://issues.apache.org/jira/browse/NIFI-13110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13110: --- Status: Patch Available (was: In Progress) > Auto select relation in Create Connection > - > > Key: NIFI-13110 > URL: https://issues.apache.org/jira/browse/NIFI-13110 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > When there is only a single Relationship, auto select it in the Create > Connection dialog. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MINIFICPP-2354) Release 0.99.0
Gábor Gyimesi created MINIFICPP-2354: Summary: Release 0.99.0 Key: MINIFICPP-2354 URL: https://issues.apache.org/jira/browse/MINIFICPP-2354 Project: Apache NiFi MiNiFi C++ Issue Type: Task Reporter: Gábor Gyimesi Assignee: Gábor Gyimesi -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] MINIFICPP-2336 Python bootstrap part 2 [nifi-minifi-cpp]
lordgamez opened a new pull request, #1773: URL: https://github.com/apache/nifi-minifi-cpp/pull/1773 https://issues.apache.org/jira/browse/MINIFICPP-2336 - Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (MINIFICPP-2344) Update version number to 0.99.0
[ https://issues.apache.org/jira/browse/MINIFICPP-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz resolved MINIFICPP-2344. - Resolution: Done > Update version number to 0.99.0 > --- > > Key: MINIFICPP-2344 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2344 > Project: Apache NiFi MiNiFi C++ > Issue Type: Task >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Major > Fix For: 0.99.0 > > Time Spent: 1h > Remaining Estimate: 0h > > This is the first milestone release towards version 1.0.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2344 Update version number to 0.99.0 [nifi-minifi-cpp]
szaszm closed pull request #1769: MINIFICPP-2344 Update version number to 0.99.0 URL: https://github.com/apache/nifi-minifi-cpp/pull/1769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINIFICPP-2353) improve some logs, accept the old yaml c2 mimetype
Marton Szasz created MINIFICPP-2353: --- Summary: improve some logs, accept the old yaml c2 mimetype Key: MINIFICPP-2353 URL: https://issues.apache.org/jira/browse/MINIFICPP-2353 Project: Apache NiFi MiNiFi C++ Issue Type: Improvement Reporter: Marton Szasz -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] MINIFICPP-2353 improve some logs, accept the old yaml c2 mimetype [nifi-minifi-cpp]
szaszm opened a new pull request, #1772: URL: https://github.com/apache/nifi-minifi-cpp/pull/1772 The SSLContextService change will conflict with #1749 (same change), I'll remove it if that gets merged first. --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-12903) UI - update disabled/enabled drag/drop colors
[ https://issues.apache.org/jira/browse/NIFI-12903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan reassigned NIFI-12903: -- Assignee: Scott Aslan > UI - update disabled/enabled drag/drop colors > - > > Key: NIFI-12903 > URL: https://issues.apache.org/jira/browse/NIFI-12903 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > > The connection prioritizers and the parameter context inheritance drag and > drop controls need to update the background color for enabled and disabled > states. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MINIFICPP-2352) Investivate ways to avoid reading full flow files into memory with RocksDB content repository
Marton Szasz created MINIFICPP-2352: --- Summary: Investivate ways to avoid reading full flow files into memory with RocksDB content repository Key: MINIFICPP-2352 URL: https://issues.apache.org/jira/browse/MINIFICPP-2352 Project: Apache NiFi MiNiFi C++ Issue Type: New Feature Reporter: Marton Szasz RocksDB seems to inherently read the full value into memory, which is fine for most usages, but not when large flow files contents are used in minifi. We should see if there are any options that lets us keep the contents on disk while working with them, like with FilesystemContentRepository. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-13110) Auto select relation in Create Connection
[ https://issues.apache.org/jira/browse/NIFI-13110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman reassigned NIFI-13110: -- Assignee: Matt Gilman > Auto select relation in Create Connection > - > > Key: NIFI-13110 > URL: https://issues.apache.org/jira/browse/NIFI-13110 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > > When there is only a single Relationship, auto select it in the Create > Connection dialog. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13115] update context menu, search results overalay, and nf edi… [nifi]
mcgilman commented on code in PR #8714: URL: https://github.com/apache/nifi/pull/8714#discussion_r1584783617 ## nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/styles/_app.scss: ## @@ -354,8 +353,9 @@ } .property-editor { -background-color: $nifi-theme-surface-palette-darker; -box-shadow: 0 2px 5px rgba(0, 0, 0, 0.25); +background-color: var(--mat-menu-container-color); +box-shadow: 0 3px 6px rgba(0, 0, 0, 0.25); +border-radius: 4px; Review Comment: The resize handle is rendered on top of the bottom right corner. We may want to consider updates there now that the modal uses a larger border radius. ![Screenshot 2024-04-30 at 8 58 54 AM](https://github.com/apache/nifi/assets/123395/4c8fd1a2-c0e7-415a-8bc6-5b33f443a97d) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINIFICPP-2351) MultipartUploadStateStorageTest transiently fails
Ferenc Gerlits created MINIFICPP-2351: - Summary: MultipartUploadStateStorageTest transiently fails Key: MINIFICPP-2351 URL: https://issues.apache.org/jira/browse/MINIFICPP-2351 Project: Apache NiFi MiNiFi C++ Issue Type: Bug Reporter: Ferenc Gerlits Failing centos CI job: [https://github.com/fgerlits/nifi-minifi-cpp/actions/runs/8891797372/job/24414499850] {noformat} --- Remove aged off state --- /opt/minifi/extensions/aws/tests/MultipartUploadStateStorageTest.cpp:138 ... /opt/minifi/extensions/aws/tests/MultipartUploadStateStorageTest.cpp:159: FAILED: REQUIRE( upload_storage_->getState("test_bucket", "key2") == state2 ) with expansion: std::nullopt == {?} === test cases: 4 | 3 passed | 1 failed assertions: 13 | 12 passed | 1 failed {noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MINIFICPP-2305) C2VerifyHeartbeatAndStopSecure test transiently fails in CI
[ https://issues.apache.org/jira/browse/MINIFICPP-2305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842370#comment-17842370 ] Ferenc Gerlits commented on MINIFICPP-2305: --- Another failure of the same kind on macos: https://github.com/apache/nifi-minifi-cpp/actions/runs/8894224658/job/24422028589?pr=1771 {noformat} Error: 4-30 12:37:34.731] [org::apache::nifi::minifi::core::flow::AdaptiveConfiguration] [error] Error while processing configuration file: Unable to parse configuration file as none of the possible required fields [Flow Controller] is available [in '' section of configuration file] libc++abi: terminating due to uncaught exception of type std::invalid_argument: Unable to parse configuration file as none of the possible required fields [Flow Controller] is available [in '' section of configuration file] {noformat} > C2VerifyHeartbeatAndStopSecure test transiently fails in CI > --- > > Key: MINIFICPP-2305 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2305 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Gábor Gyimesi >Priority: Major > Attachments: C2VerifyHeartbeatAndStopSecure_failure.log > > > C2VerifyHeartbeatAndStopSecure sometimes fails in CI: > {code:java} > Error: 2-23 14:39:39.239] > [org::apache::nifi::minifi::core::flow::AdaptiveConfiguration] [error] Error > while processing configuration file: Unable to parse configuration file as > none of the possible required fields [Flow Controller] is available [in '' > section of configuration file] > terminate called after throwing an instance of 'std::invalid_argument' > what(): Unable to parse configuration file as none of the possible > required fields [Flow Controller] is available [in '' section of > configuration file] {code} > More info in the attached logs. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13115] update context menu, search results overalay, and nf edi… [nifi]
mcgilman commented on PR #8714: URL: https://github.com/apache/nifi/pull/8714#issuecomment-2085249099 Will review... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12803) BUG - policy changes require page refresh to be applied
[ https://issues.apache.org/jira/browse/NIFI-12803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12803: --- Status: Patch Available (was: In Progress) > BUG - policy changes require page refresh to be applied > --- > > Key: NIFI-12803 > URL: https://issues.apache.org/jira/browse/NIFI-12803 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Matt Gilman >Priority: Major > Attachments: image-2024-02-15-13-57-03-890.png, > image-2024-02-15-13-58-17-784.png > > > !image-2024-02-15-13-57-03-890.png! > > !image-2024-02-15-13-58-17-784.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-12833: Ensuring permissions are updated when policies are changed [nifi]
mcgilman opened a new pull request, #8718: URL: https://github.com/apache/nifi/pull/8718 NIFI-12833: - Reloading current user when any policy changes. - Reloading the component for the policy whenever it's view permissions changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MINIFICPP-2346) Speed up MiNiFi Build with Conan package manager (C++)
[ https://issues.apache.org/jira/browse/MINIFICPP-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842368#comment-17842368 ] Marton Szasz commented on MINIFICPP-2346: - I was thinking about the same issue with build times, but I also had a failed experiment moving to conan a few years ago. Nowadays vcpkg seems more ubiquitous, so I was thinking trying that for binary package management instead. It may also work better on Windows, since Microsoft is backing it. What do you think? > Speed up MiNiFi Build with Conan package manager (C++) > -- > > Key: MINIFICPP-2346 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2346 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Affects Versions: 0.15.0 > Environment: Ubuntu 22.04 >Reporter: James Medel >Assignee: James Medel >Priority: Minor > Labels: build, conan, ubuntu > > *Description of Issue:* Building MiNiFi C++ with just CMake is really slow. > During the the build process, it clones all the external dependencies and > then builds those external dependencies while its building MiNiFi CPP. > Sometimes the MiNiFi CPP build fails too when external lib dependencies fail > to download or fail to build. It would be faster to build MiNiFi C++ with the > external dependencies already preinstalled. > > *Potential Solution:* Integrate *conan version 2* into MiNiFi C++ project to > enable support for using *conan install* to install all or most of MiNiFi's > external dependencies, using *conan install --build=missing* to build them as > prebuilt binary conan packages, upload them to conancenter with {*}conan > upload{*}, and then run cmake generate to generate the appropriate build > files for the OS, then run make to build MiNiFi CPP. Also conan has really > good support for cross platform compatibility for Linux and Windows. At this > point because we already have most of MiNiFi CPP's external lib dependencies > installed with conan, our CMake build will just focus on building the MiNiFi > CPP code, enabling faster builds. Also I will need to account for backward > compatibility support with the previous way of installing MiNiFi CPP external > lib dependencies using CMake FetchContent_Declare(...) approach until > conanfile.py approach covers installing all these dependencies. A valid > verification of the MiNiFi C++ build would be to run GTESTs and if all the > expected test cases pass, then it may be fair to conclude we would be ready > to deprecate the slow CMake FetchContent_Declare(...) approach. > > *Steps to Perform MiNiFi C++ Build Enhancement (Plan to Integrate into > script(s)):* > # Install conan version 2 into MiNiFi C++ dev environment (my preference is > using docker container) > # Create a conanfile.py file at root of MiNiFi C++ project where we run > "conan install" or "conan install --build=missing" to install MiNiFi C++ > external lib dependencies first. Then we run CMake to build MiNiFi C++. > # Find all MiNiFi C++ find_package(...) CMake function calls and check if > there is already supported conan packages on the conancenter, so we can > install those packages. > # Find all FetchContent_Declare(...) CMake function calls and check if there > is already supported conan packages on the conancenter, so we can install > those packages. > # At this point we will have used conan version 2 C++ package manager to > install almost all MiNiFi C++'s external dependencies. > ## With Conan, we will have installed these MiNiFi external lib dependencies > as prebuilt binary conan packages. > ## Or we will have instructed conan to first build each C++ external lib > dependency, upload each lib to conancenter. > # Thus, conan manages installing MiNiFi C++'s external lib dependencies, so > we can then run CMake to build MiNiFi faster. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MINIFICPP-2350) Implement parameter context, parameter substitution in flow definition, properties
Marton Szasz created MINIFICPP-2350: --- Summary: Implement parameter context, parameter substitution in flow definition, properties Key: MINIFICPP-2350 URL: https://issues.apache.org/jira/browse/MINIFICPP-2350 Project: Apache NiFi MiNiFi C++ Issue Type: New Feature Reporter: Marton Szasz -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MINIFICPP-897) Find and implement Modbus library
[ https://issues.apache.org/jira/browse/MINIFICPP-897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Zink resolved MINIFICPP-897. --- Resolution: Abandoned > Find and implement Modbus library > - > > Key: MINIFICPP-897 > URL: https://issues.apache.org/jira/browse/MINIFICPP-897 > Project: Apache NiFi MiNiFi C++ > Issue Type: New Feature >Reporter: Jeremy Dyer >Priority: Minor > > Not reinventing the wheel we should find a modbus library that has an Apache > friendly license and then part of this would involve setting up the "modbus" > extension and building that library as a CMake external project -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MINIFICPP-896) Modbus Master Processor
[ https://issues.apache.org/jira/browse/MINIFICPP-896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Zink resolved MINIFICPP-896. --- Resolution: Abandoned > Modbus Master Processor > --- > > Key: MINIFICPP-896 > URL: https://issues.apache.org/jira/browse/MINIFICPP-896 > Project: Apache NiFi MiNiFi C++ > Issue Type: New Feature >Reporter: Jeremy Dyer >Priority: Minor > > In a Modbus network the "master" sends requests for data. The first byte of > the message is the slave id. Every slave in the network receives the message > but if the first byte does not match their slave id then the message is > ignored by all slaves except the one with the matching id. This processor > would need to be able to send these messages to the network and allow for > users to construct standard modbus requests. This still requires some > thinking and might very well require some supporting controller services or > additional processors to make the implementation smooth. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MINIFICPP-2349) FetchModbusTcp
Martin Zink created MINIFICPP-2349: -- Summary: FetchModbusTcp Key: MINIFICPP-2349 URL: https://issues.apache.org/jira/browse/MINIFICPP-2349 Project: Apache NiFi MiNiFi C++ Issue Type: New Feature Reporter: Martin Zink Assignee: Martin Zink -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2295 Add controller service support for NiFi python processors [nifi-minifi-cpp]
fgerlits commented on code in PR #1762: URL: https://github.com/apache/nifi-minifi-cpp/pull/1762#discussion_r1584692377 ## extensions/python/types/PyProcessContext.cpp: ## @@ -104,6 +107,30 @@ PyObject* PyProcessContext::getStateManager(PyProcessContext* self, PyObject*) { return object::returnReference(context->getStateManager()); } +PyObject* PyProcessContext::getControllerService(PyProcessContext* self, PyObject* args) { + auto context = self->process_context_.lock(); + if (!context) { +PyErr_SetString(PyExc_AttributeError, "tried reading process context outside 'on_trigger'"); +return nullptr; + } + + const char* controller_service_name = nullptr; + const char* controller_service_type = nullptr; + if (!PyArg_ParseTuple(args, "s|s", _service_name, _service_type)) { +throw PyException(); + } + + if (auto controller_service = context->getControllerService(controller_service_name)) { +std::string controller_service_type_str = controller_service_type; +if (controller_service_type_str == "SSLContextService") { + auto ssl_ctx_service = std::dynamic_pointer_cast(controller_service); + return object::returnReference(std::weak_ptr(ssl_ctx_service)); +} + } Review Comment: Since we only support `SSLContextService` for now, I think we should change the titles (commit, Jira, PR) to reflect this, eg. "Add SSLContextService support for NiFi python processors". Also, we could log an error or warning here when the requested controller service type is something other than `SSLContextService`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2295 Add controller service support for NiFi python processors [nifi-minifi-cpp]
fgerlits commented on code in PR #1762: URL: https://github.com/apache/nifi-minifi-cpp/pull/1762#discussion_r1584692377 ## extensions/python/types/PyProcessContext.cpp: ## @@ -104,6 +107,30 @@ PyObject* PyProcessContext::getStateManager(PyProcessContext* self, PyObject*) { return object::returnReference(context->getStateManager()); } +PyObject* PyProcessContext::getControllerService(PyProcessContext* self, PyObject* args) { + auto context = self->process_context_.lock(); + if (!context) { +PyErr_SetString(PyExc_AttributeError, "tried reading process context outside 'on_trigger'"); +return nullptr; + } + + const char* controller_service_name = nullptr; + const char* controller_service_type = nullptr; + if (!PyArg_ParseTuple(args, "s|s", _service_name, _service_type)) { +throw PyException(); + } + + if (auto controller_service = context->getControllerService(controller_service_name)) { +std::string controller_service_type_str = controller_service_type; +if (controller_service_type_str == "SSLContextService") { + auto ssl_ctx_service = std::dynamic_pointer_cast(controller_service); + return object::returnReference(std::weak_ptr(ssl_ctx_service)); +} + } Review Comment: Since we only support `SSLContextService` for now, I think we should change the titles (commit, Jira, PR) to reflect this, eg. "Add SSLContextService support for NiFi python processors". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13116) PutDatabaseRecord (INSERT_IGNORE) uses Update keys while not specified
[ https://issues.apache.org/jira/browse/NIFI-13116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Pinevskiy updated NIFI-13116: - Fix Version/s: (was: 1.26.0) > PutDatabaseRecord (INSERT_IGNORE) uses Update keys while not specified > -- > > Key: NIFI-13116 > URL: https://issues.apache.org/jira/browse/NIFI-13116 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.25.0, 2.0.0-M2 >Reporter: Mikhail Pinevskiy >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > PutDatabaseRecord hides field "Update Keys" while using INSERT_IGNORE ("A > comma-separated list of column names that uniquely identifies a row in the > database for UPDATE statements. If the Statement Type is UPDATE and this > property is not set, the table's Primary Keys are used. In this case, if no > Primary Key exists, the conversion to SQL will fail if Unmatched Column > Behaviour is set to FAIL. This property is ignored if the Statement Type is > INSERT"). > Despite this field not being set and not being used, classes like > PostgreSQLDatabaseAdapter use it in methods for INSERT_IGNORE and UPSERT, > which triggers an exception if list of Update Keys is empty or null. > MySQLDatabaseAdapter methods have same checks for Update Keys, but do not use > them. With that for PostgreSQL we have "instert ... on conflict (Update Keys) > ignore", and for MySQL any constraint will trigger "on conflict" on any > constraint, not specified. > It means different and unclear behaviour, so i suggest removing use of Update > Keys in said classes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-13116 PutDatabaseRecord (INSERT_IGNORE) uses Update keys while n… [nifi]
Pinevskiy opened a new pull request, #8717: URL: https://github.com/apache/nifi/pull/8717 …ot specified # Summary [NIFI-13116](https://issues.apache.org/jira/browse/NIFI-13116) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] MINIFICPP-2312 Reduce shared_ptr usage for controller services [nifi-minifi-cpp]
fgerlits opened a new pull request, #1771: URL: https://github.com/apache/nifi-minifi-cpp/pull/1771 I have removed some `shared_ptr` usage, but more can be done later. The main problem is that the `ControllerServiceNodeMap` container is shared between the `FlowConfiguration`, the `ProcessGroup` and the `ProcessContext`. It should probably be created in the `FlowConfiguration`, moved to the `ProcessGroup`, and the `ProcessContext` would only have a pointer to it. I have renamed `ControllerServiceMap` to `ControllerServiceNodeMap` (because it stores `ControllerServiceNode`s), but git shows it as a removed file plus a new file. https://issues.apache.org/jira/browse/MINIFICPP-2312 --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13116 PutDatabaseRecord (INSERT_IGNORE) uses Update keys while n… [nifi]
Pinevskiy closed pull request #8716: NIFI-13116 PutDatabaseRecord (INSERT_IGNORE) uses Update keys while n… URL: https://github.com/apache/nifi/pull/8716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MINIFICPP-2341) Include custom relationships in C2 manifest for NiFi python processors
[ https://issues.apache.org/jira/browse/MINIFICPP-2341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi updated MINIFICPP-2341: - Epic Link: MINIFICPP-2272 > Include custom relationships in C2 manifest for NiFi python processors > --- > > Key: MINIFICPP-2341 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2341 > Project: Apache NiFi MiNiFi C++ > Issue Type: New Feature >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2344) Update version number to 0.99.0
[ https://issues.apache.org/jira/browse/MINIFICPP-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi updated MINIFICPP-2344: - Fix Version/s: 0.99.0 > Update version number to 0.99.0 > --- > > Key: MINIFICPP-2344 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2344 > Project: Apache NiFi MiNiFi C++ > Issue Type: Task >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Major > Fix For: 0.99.0 > > Time Spent: 50m > Remaining Estimate: 0h > > This is the first milestone release towards version 1.0.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MINIFICPP-2348) Remove bootstrap.sh and win_build_vs.bat build scripts
Gábor Gyimesi created MINIFICPP-2348: Summary: Remove bootstrap.sh and win_build_vs.bat build scripts Key: MINIFICPP-2348 URL: https://issues.apache.org/jira/browse/MINIFICPP-2348 Project: Apache NiFi MiNiFi C++ Issue Type: Task Reporter: Gábor Gyimesi With the python bootstrap script being the recommended for builds, we should remove the legacy build scripts. This includes updating the README files. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2344) Update version number to 0.99.0
[ https://issues.apache.org/jira/browse/MINIFICPP-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi updated MINIFICPP-2344: - Description: This is the first milestone release towards version 1.0.0 > Update version number to 0.99.0 > --- > > Key: MINIFICPP-2344 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2344 > Project: Apache NiFi MiNiFi C++ > Issue Type: Task >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > This is the first milestone release towards version 1.0.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2344) Update version number to 0.99.0
[ https://issues.apache.org/jira/browse/MINIFICPP-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi updated MINIFICPP-2344: - Summary: Update version number to 0.99.0 (was: Update version number to 1.0.0) > Update version number to 0.99.0 > --- > > Key: MINIFICPP-2344 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2344 > Project: Apache NiFi MiNiFi C++ > Issue Type: Task >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)