[jira] [Commented] (NIFI-766) UI should indicate when backpressure is configured for a Connection

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15572385#comment-15572385
 ] 

ASF GitHub Bot commented on NIFI-766:
-

Github user markap14 commented on the issue:

https://github.com/apache/nifi/pull/1080
  
@mcgilman @pvillard31 I made one slight change to ConnectionStatus to 
rename the getters/setters from setBackpressureDataSizeThresholdLong to 
setBackpressureBytesThreshold to align with the existing naming convention. 
Otherwise, all looks great! Tested and verified that all worked as expected. 
The UI looks great. Thanks for updating this, guys. It's been a long time 
coming and will be very helpful! +1 merged to master.


> UI should indicate when backpressure is configured for a Connection
> ---
>
> Key: NIFI-766
> URL: https://issues.apache.org/jira/browse/NIFI-766
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, Core UI
>Reporter: Mark Payne
>Assignee: Pierre Villard
> Fix For: 1.1.0
>
> Attachments: backpressure.png, backpressure_and_expiration.png, 
> normal.png
>
>
> It is sometimes unclear why a Processor is not running, if it is due to 
> backpressure. Recommend we add an icon to the Connection label to indicate 
> that backpressure is configured. If backpressure is "applied" (i.e., the 
> backpressure threshold has been reached), that icon should be highlighted 
> somehow.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-766) UI should indicate when backpressure is configured for a Connection

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15572380#comment-15572380
 ] 

ASF GitHub Bot commented on NIFI-766:
-

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1080


> UI should indicate when backpressure is configured for a Connection
> ---
>
> Key: NIFI-766
> URL: https://issues.apache.org/jira/browse/NIFI-766
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, Core UI
>Reporter: Mark Payne
>Assignee: Pierre Villard
> Fix For: 1.1.0
>
> Attachments: backpressure.png, backpressure_and_expiration.png, 
> normal.png
>
>
> It is sometimes unclear why a Processor is not running, if it is due to 
> backpressure. Recommend we add an icon to the Connection label to indicate 
> that backpressure is configured. If backpressure is "applied" (i.e., the 
> backpressure threshold has been reached), that icon should be highlighted 
> somehow.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-766) UI should indicate when backpressure is configured for a Connection

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15572378#comment-15572378
 ] 

ASF subversion and git services commented on NIFI-766:
--

Commit 26f46538b3cb6649918a64014f92d4adb9165133 in nifi's branch 
refs/heads/master from [~pvillard]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=26f4653 ]

NIFI-766:
- Improved connection UI display when backpressure is enabled
- Updating the connection label to include backpressure indicators for object 
count and data size thresholds.
- Coloring the connection path and drop shadow once backpressure is engaged.
- Fixing bug with expiration icon tooltip.
- Including columns in the summary table for backpressure.
- Updating empty queue action to reload the connection status upon completion 
to ensure an updated count.

This closes #1080.


> UI should indicate when backpressure is configured for a Connection
> ---
>
> Key: NIFI-766
> URL: https://issues.apache.org/jira/browse/NIFI-766
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, Core UI
>Reporter: Mark Payne
>Assignee: Pierre Villard
> Fix For: 1.1.0
>
> Attachments: backpressure.png, backpressure_and_expiration.png, 
> normal.png
>
>
> It is sometimes unclear why a Processor is not running, if it is due to 
> backpressure. Recommend we add an icon to the Connection label to indicate 
> that backpressure is configured. If backpressure is "applied" (i.e., the 
> backpressure threshold has been reached), that icon should be highlighted 
> somehow.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-766) UI should indicate when backpressure is configured for a Connection

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571841#comment-15571841
 ] 

ASF GitHub Bot commented on NIFI-766:
-

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1080
  
Can someone else finish up the review of this PR? I helped contribute to 
this PR and would prefer someone else's eyes on. Thanks!


> UI should indicate when backpressure is configured for a Connection
> ---
>
> Key: NIFI-766
> URL: https://issues.apache.org/jira/browse/NIFI-766
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, Core UI
>Reporter: Mark Payne
>Assignee: Pierre Villard
> Fix For: 1.1.0
>
> Attachments: backpressure.png, backpressure_and_expiration.png, 
> normal.png
>
>
> It is sometimes unclear why a Processor is not running, if it is due to 
> backpressure. Recommend we add an icon to the Connection label to indicate 
> that backpressure is configured. If backpressure is "applied" (i.e., the 
> backpressure threshold has been reached), that icon should be highlighted 
> somehow.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-766) UI should indicate when backpressure is configured for a Connection

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15536797#comment-15536797
 ] 

ASF GitHub Bot commented on NIFI-766:
-

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1080
  
@pvillard31,

Following some of the discussion on the mailing list recently and the 
original commentary on the JIRA [1], I'd like to propose shifting from an icon 
based approach when back pressure is engaged to a progress bar style approach 
where the user can quickly get a sense of how 'full' the queue is currently.


![backpressure](https://cloud.githubusercontent.com/assets/123395/19003638/c0abcfc6-871f-11e6-9338-c6b2500c4ee3.png)

The mockup shows various configuration scenarios. 

- Expiration (clock icon)
- Object and Data size backpressure (left and right bars respectively)
- Empty bar - backpressure not configured
- Partial bar - backpressure configured, partial represent precentage full
- Full solid bar - backpressure engaged

If you're up for some additional cycles on this PR I'd be happy to work 
through the changes with you. If not, I'm happy to take what you started and 
continue toward the mockup above.

Thanks!

[1] https://issues.apache.org/jira/browse/NIFI-766



> UI should indicate when backpressure is configured for a Connection
> ---
>
> Key: NIFI-766
> URL: https://issues.apache.org/jira/browse/NIFI-766
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, Core UI
>Reporter: Mark Payne
>Assignee: Pierre Villard
> Fix For: 1.1.0
>
> Attachments: backpressure.png, backpressure_and_expiration.png, 
> normal.png
>
>
> It is sometimes unclear why a Processor is not running, if it is due to 
> backpressure. Recommend we add an icon to the Connection label to indicate 
> that backpressure is configured. If backpressure is "applied" (i.e., the 
> backpressure threshold has been reached), that icon should be highlighted 
> somehow.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-766) UI should indicate when backpressure is configured for a Connection

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15530976#comment-15530976
 ] 

ASF GitHub Bot commented on NIFI-766:
-

GitHub user pvillard31 opened a pull request:

https://github.com/apache/nifi/pull/1080

NIFI-766 Added icon on connection when backpressure is enabled

Here is a proposition to display an icon on a connection when back pressure 
is enabled.

At the moment, there is no icon displayed whether back pressure is 
configured or not. (I am not sure it is worth adding information that is not 
that important to users: back pressure is configured by default)

First time I take a shot at UI dev, please review with care ;)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pvillard31/nifi backpressure

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1080.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1080


commit 529492fa84013e877adf300826a85d6be5e9f5d0
Author: Pierre Villard 
Date:   2016-09-28T21:39:09Z

Added icon on connection when backpressure is enabled




> UI should indicate when backpressure is configured for a Connection
> ---
>
> Key: NIFI-766
> URL: https://issues.apache.org/jira/browse/NIFI-766
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, Core UI
>Reporter: Mark Payne
>
> It is sometimes unclear why a Processor is not running, if it is due to 
> backpressure. Recommend we add an icon to the Connection label to indicate 
> that backpressure is configured. If backpressure is "applied" (i.e., the 
> backpressure threshold has been reached), that icon should be highlighted 
> somehow.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)