[GitHub] trafficserver issue #1370: Issue #1369: proxy.config.http.server_max_connect...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1370
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1393/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...

[persiaAziz]

Github user persiaAziz commented on the issue:

https://github.com/apache/trafficserver/pull/1357
  
I was thinking to have one overridable config for the client cert 
containing the partial or absolute path to avoid the memory allocation in 
Layout, but that will break the convention of having separate configs for path 
and filename. It could be also confusing for the user


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1374: Fix CID 1369398: Null pointer dereferences

[randall]

GitHub user randall opened a pull request:

https://github.com/apache/trafficserver/pull/1374

Fix CID 1369398: Null pointer dereferences



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/randall/trafficserver fix_1369398

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1374.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1374


commit 21f78fcd244adac98135b790daf300afdd732925
Author: Randall Meyer 
Date:   2017-01-25T15:31:55Z

Fix CID 1369398: Null pointer dereferences




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1368: Issue #1367: HdrHeap potential corruption

[shinrich]

Github user shinrich closed the pull request at:

https://github.com/apache/trafficserver/pull/1368


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1370: Issue #1369: proxy.config.http.server_max_connect...

[shinrich]

Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/pull/1370
  
Ok.  Still figuring out the new world order :-)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1366: Issue #1360: REGRESSION_TEST(SDK_API_OVERRIDABLE_...

[shinrich]

Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/pull/1366
  
Probably.  We will be pulling this back into our 7.1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1366: Issue #1360: REGRESSION_TEST(SDK_API_OVERR...

[shinrich]

Github user shinrich closed the pull request at:

https://github.com/apache/trafficserver/pull/1366


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1367: HdrHeap potential corruption

[shinrich]

Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/issues/1367
  
Hopefully this fixes what you saw @maskit.  Looking at the discussion on 
TS-2792 had it been solved before?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1374: Fix CID 1369398: Null pointer dereferences

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1374
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1391/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1357: TS-5022: reduce memory allocation in clien...

[SolidWallOfCode]

Github user SolidWallOfCode commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1357#discussion_r97822859
  
--- Diff: proxy/http/HttpSM.cc ---
@@ -5050,9 +5036,26 @@ HttpSM::do_http_server_open(bool raw)
   opt.set_sni_servername(host, len);
 }
 
-ats_scoped_str clientCert(
-  (Layout::relative_to(t_state.txn_conf->client_cert_filepath, 
t_state.txn_conf->client_cert_filename)));
-opt.set_client_certname(clientCert);
+SSLConfig::scoped_config params;
+ats_scoped_str clientCert;
--- End diff --

Why is this declared twice?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1374: Fix CID 1369398: Null pointer dereferences

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1374
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1285/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1370: Issue #1369: proxy.config.http.server_max_...

[SolidWallOfCode]

Github user SolidWallOfCode commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1370#discussion_r97822530
  
--- Diff: proxy/http/HttpSM.cc ---
@@ -4933,8 +4933,10 @@ HttpSM::do_http_server_open(bool raw)
 // between the statement above and the check below.
 // If this happens, we might go over the max by 1 but this is ok.
 if (sum >= t_state.http_config_param->server_max_connections) {
-  ink_assert(pending_action == nullptr);
-  pending_action = eventProcessor.schedule_in(this, 
HRTIME_MSECONDS(100));
+  // Eventually may want to have a queue as the origin_max_connection 
does to allow for a combination
+  // of retries and errors.  But at this point, we are just going to 
allow the error case.
+  t_state.current.state = HttpTransact::CONNECTION_ERROR;
+  call_transact_and_set_next_state(HttpTransact::HandleResponse);
   httpSessionManager.purge_keepalives();
--- End diff --

Are you sure you want to do this after `call_transact_and_set_next_state`? 
Normal is to return the return value of that call.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1303: TS-5107: Changes to autolinking in Docutils 1.3

[jsime]

Github user jsime commented on the issue:

https://github.com/apache/trafficserver/pull/1303
  
The changes are fine and everything builds fine - I don't see any adverse 
effects from the inliner for Jira issues. I'm okay with merging this in for 
7.1. I'm not sure we'd necessarily end up with comparable inline markup 
recognition for GitHub issues down the road (`TS-\d+` is pretty distinctive, 
but `#\d+` or other similar variants that come to mind briefly don't have that 
same quality).

If there are no objections from anyone else, I'll merge this later this 
morning.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1303: TS-5107: Changes to autolinking in Docutils 1.3

[jablko]

Github user jablko commented on the issue:

https://github.com/apache/trafficserver/pull/1303
  
@zwoop Sure thing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1378: 7.1.x TS-5107: Changes to autolinking in Docutils...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1378
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1396/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1341: openssl errors for every request

[bryancall]

Github user bryancall commented on the issue:

https://github.com/apache/trafficserver/issues/1341
  
This has been resloved


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1341: openssl errors for every request

[bryancall]

Github user bryancall closed the issue at:

https://github.com/apache/trafficserver/issues/1341


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1344: Origin SNI

[bryancall]

Github user bryancall commented on the issue:

https://github.com/apache/trafficserver/issues/1344
  
@brkishore Only committers can have issues assigned to them.  It is a 
limitation of GitHub.

Please submit a PR for it once you have a fix.  Thank you!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1378: 7.1.x TS-5107: Changes to autolinking in Docutils...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1378
  
Also, please remember to add Milestone, Label's etc. on each Issue / PR, 
otherwise @bryancall  gets all pissy. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1379: Make sure to schedule connect event on cor...

[shinrich]

GitHub user shinrich opened a pull request:

https://github.com/apache/trafficserver/pull/1379

Make sure to schedule connect event on correct thread type.

Cannot blindly schedule on current thread.  It may not be the right type.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shinrich/trafficserver schedule_thread_type

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1379.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1379


commit 7e8fe6e308f6c79d17713e7ecbb23f61562d7111
Author: Susan Hinrichs 
Date:   2017-01-26T00:38:17Z

Make sure to schedule connect event on correct thread type.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1379: Make sure to schedule connect event on correct th...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1379
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1397/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1377: TS-5107: init_customizations() isn't new in Docut...

[jablko]

Github user jablko commented on the issue:

https://github.com/apache/trafficserver/pull/1377
  
@jsime Thank you!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1370: Issue #1369: proxy.config.http.server_max_connect...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1370
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1287/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1377: TS-5107: init_customizations() isn't new in Docut...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1377
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1289/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1378: 7.1.x TS-5107: Changes to autolinking in D...

[jablko]

GitHub user jablko opened a pull request:

https://github.com/apache/trafficserver/pull/1378

7.1.x TS-5107: Changes to autolinking in Docutils 0.13



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jablko/trafficserver 7.1.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1378.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1378


commit e4aa6af652d4de11b7c2326eb0c7ea9f5f445ebf
Author: Jack Bates 
Date:   2017-01-06T19:49:30Z

Revert "Fix nested role (not supported)"

This reverts commit 9e374946a6700bf9766d011dadbc05891d92f058.

(cherry picked from commit 11bfc4b3a51c94c4ba891f66a6774a266339a464)

commit 55232701c59cf74f250b69b7ba5378087871ab63
Author: Jack Bates 
Date:   2017-01-06T19:49:42Z

Revert "Fix documentation build for docutils 0.13.1 (2/2)"

This reverts commit f3e37f8e104a74700b35816e50f32f95ee436741.

(cherry picked from commit ffc906a25e156f8dd4ac57f284893878b853c189)

commit 5cdadb5a7be80eb9a73af215357f9f533145dd91
Author: Jack Bates 
Date:   2017-01-06T19:49:46Z

Revert "Fix documentation build for docutils 0.13.1 (1/2)"

This reverts commit ac0db847e841d50fd38920234166a45762b00398.

(cherry picked from commit 97723e740802cfa4a5105227df13e268c98472a9)

commit 4be1b8123042927ec1f3232764141106bbd8183a
Author: Jack Bates 
Date:   2017-01-06T19:55:44Z

TS-5107: Changes to autolinking in Docutils 0.13

init_customizations() was added in Docutils 0.13.

(cherry picked from commit 111e7f5b831298cb4cba446c362cfa450e83e99d)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1377: TS-5107: init_customizations() isn't new in Docut...

[jsime]

Github user jsime commented on the issue:

https://github.com/apache/trafficserver/pull/1377
  
@jablko As much my fault as anything on #1303 for not testing against the 
same package versions as the doc server. This PR builds fine for me now with 
sphinx 1.4.8 and docutils 0.12.0. Thanks for the fixes!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1377: TS-5107: init_customizations() isn't new i...

[jsime]

Github user jsime closed the pull request at:

https://github.com/apache/trafficserver/pull/1377


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1375: Incorrectly freeing Http1ClientSession setting up...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1375
  
Is this a 7.1.x candidate?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1368: Issue #1367: HdrHeap potential corruption

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1368
  
@shinrich Should we cherry-pick this back to 7.1.x ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Build failed in Jenkins: docs-master #201

[Jack Bates]

I'll have a fix ready in a sec. Sorry about this!

On 25/01/17 01:08 PM, Jon Sime wrote:

Sure enough, if I downgrade Sphinx to 1.4.8 it's failing in that same
spot for me. Looks like PR 1303 that I merged today was depending on
changes from the stable 1.5 release.

On Wed, Jan 25, 2017 at 1:53 PM, > wrote:

https://ci.trafficserver.apache.org/job/docs-master/201/Changes
:

[Leif Hedstrom] Modify TSHttpTxnHookAdd to add hook only once

[Leif Hedstrom] [TS-5024] Ran clang-format. Modify TSHttpTxnHookAdd
to add hook only

[Chao Xu] Do not reschedule the periodic inactive_event and cancel
it after signal

[Leif Hedstrom] Change connect_attempts_rr_retries test to match
warning text

[shinrich] TS-5022: nullptr check

[Leif Hedstrom] This avoids some badness around some STL
implementations, where the

[jack] Replace gethostbyname_r() and gethostbyaddr_r()

[Bryan Call] Issue #1358: Add server_connect_end milestone.

[Bryan Call] Issue #1359: Flaw in TS-2157 port in server address may
be unset

[Bryan Call] Skip modifying response length for HEAD response

[Bryan Call] TS-4991: jtest should handle Range requests.

[jack] Fixes for building with LibreSSL

[jack] Debian libexecdir is a subdirectory of libdir

[jack] TS-4716: OpenBSD mandir should be ${prefix}/man

[jack] Fix CID 1368305: Dereference before null check

[Bryan Call] TS-5079: logging enhancements around OCSP

[Leif Hedstrom] TS-5080: log when remap.config is successfully reloaded

[shinrich] Issue #1367: HdrHeap potential corruption

[shinrich] Issue #1360: REGRESSION_TEST(SDK_API_OVERRIDABLE_CONFIGS)
sometimes

[jonsime] Revert "Fix nested role (not supported)"

[jonsime] Revert "Fix documentation build for docutils 0.13.1 (2/2)"

[jonsime] Revert "Fix documentation build for docutils 0.13.1 (1/2)"

[jonsime] TS-5107: Changes to autolinking in Docutils 0.13

--
[...truncated 17.32 KB...]
checking sys/sysinfo.h presence... yes
checking for sys/sysinfo.h... yes
checking sys/systeminfo.h usability... no
checking sys/systeminfo.h presence... no
checking for sys/systeminfo.h... no
checking netinet/in.h usability... yes
checking netinet/in.h presence... yes
checking for netinet/in.h... yes
checking netinet/in_systm.h usability... yes
checking netinet/in_systm.h presence... yes
checking for netinet/in_systm.h... yes
checking netinet/tcp.h usability... yes
checking netinet/tcp.h presence... yes
checking for netinet/tcp.h... yes
checking sys/ioctl.h usability... yes
checking sys/ioctl.h presence... yes
checking for sys/ioctl.h... yes
checking sys/byteorder.h usability... no
checking sys/byteorder.h presence... no
checking for sys/byteorder.h... no
checking sys/sockio.h usability... no
checking sys/sockio.h presence... no
checking for sys/sockio.h... no
checking sys/prctl.h usability... yes
checking sys/prctl.h presence... yes
checking for sys/prctl.h... yes
checking arpa/nameser.h usability... yes
checking arpa/nameser.h presence... yes
checking for arpa/nameser.h... yes
checking arpa/nameser_compat.h usability... yes
checking arpa/nameser_compat.h presence... yes
checking for arpa/nameser_compat.h... yes
checking for execinfo.h... (cached) yes
checking netdb.h usability... yes
checking netdb.h presence... yes
checking for netdb.h... yes
checking ctype.h usability... yes
checking ctype.h presence... yes
checking for ctype.h... yes
checking siginfo.h usability... no
checking siginfo.h presence... no
checking for siginfo.h... no
checking malloc.h usability... yes
checking malloc.h presence... yes
checking for malloc.h... yes
checking wait.h usability... yes
checking wait.h presence... yes
checking for wait.h... yes
checking float.h usability... yes
checking float.h presence... yes
checking for float.h... yes
checking libgen.h usability... yes
checking libgen.h presence... yes
checking for libgen.h... yes
checking values.h usability... yes
checking values.h presence... yes
checking for values.h... yes
checking alloca.h usability... yes
checking alloca.h presence... yes
checking for alloca.h... yes
checking cpio.h usability... yes
checking cpio.h presence... yes
checking for cpio.h... yes
checking stropts.h usability... no
checking stropts.h presence... no
checking for stropts.h... no
checking for sys/param.h... (cached) yes
checking sys/sysmacros.h usability... yes
checking sys/sysmacros.h presence... yes
checking for sys/sysmacros.h... yes
checking math.h 

[GitHub] trafficserver issue #1379: Make sure to schedule connect event on correct th...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1379
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1291/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1376: TSStringPercentDecode null-termination cli...

[shinrich]

Github user shinrich closed the pull request at:

https://github.com/apache/trafficserver/pull/1376


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...

[SolidWallOfCode]

Github user SolidWallOfCode commented on the issue:

https://github.com/apache/trafficserver/pull/1357
  
I think I want a different approach on this. I'll talk with @persiaAziz.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1376: TSStringPercentDecode null-termination cli...

[shinrich]

GitHub user shinrich opened a pull request:

https://github.com/apache/trafficserver/pull/1376

TSStringPercentDecode null-termination clipping on overflow. 

Actually fixed by @petar last summer, but forgot to get it pushed to up.

Long URL's would cause buffer overflow write.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shinrich/trafficserver 
tsstringpercentdecode_overflow

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1376.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1376


commit 1f73eac3997eb99f142b4e2dec0ecef5b55b29af
Author: Susan Hinrichs 
Date:   2017-01-25T21:49:38Z

TSStringPercentDecode null-termination clipping on overflow. Added 
Regression Test




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1376: TSStringPercentDecode null-termination clipping o...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1376
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1394/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1377: TS-5107: init_customizations() isn't new in Docut...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1377
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1395/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...

[SolidWallOfCode]

Github user SolidWallOfCode commented on the issue:

https://github.com/apache/trafficserver/pull/1357
  
The problem (as @persiaAziz patiently explained) is the client certificate 
is overridable which means it cannot be reliable precomputed when 
`remap.config` is parsed. In theory a plugin could load a distinct client 
certificate every single remap. Unfortunately this means checking every time. 
Persia said she'd look at having a single path instead of two pieces to 
simplify the code. I'll do more review once that's ready.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1378: 7.1.x TS-5107: Changes to autolinking in Docutils...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1378
  
Why are there 4 commits on this? Can you squash those?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1378: 7.1.x TS-5107: Changes to autolinking in Docutils...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1378
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1290/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Jenkins build is back to normal : docs-master #202

[jenkins]

https://ci.trafficserver.apache.org/job/docs-master/202/

[GitHub] trafficserver pull request #1374: Fix CID 1369398: Null pointer dereferences

[zwoop]

Github user zwoop closed the pull request at:

https://github.com/apache/trafficserver/pull/1374


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1303: TS-5107: Changes to autolinking in Docutils 1.3

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1303
  
This doesn't merge cleanly into 7.1.x branch (conflicts on the python 
script). @jablko Can you make a new PR, for the 7.1.x branch please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1376: TSStringPercentDecode null-termination clipping o...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1376
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1288/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1377: TS-5107: init_customizations() isn't new i...

[jablko]

GitHub user jablko opened a pull request:

https://github.com/apache/trafficserver/pull/1377

TS-5107: init_customizations() isn't new in Docutils 0.13

We can use it in 0.12 and 0.13.

@jsime Thanks for merging #1303. Sorry for the mistake! If you approve, can 
you please merge this correction?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jablko/trafficserver init_customizations

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1377.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1377


commit 70a8392466fa5426c1a7c5cc7fab053f8f5afe97
Author: Jack Bates 
Date:   2017-01-25T20:35:47Z

TS-5107: init_customizations() isn't new in Docutils 0.13

We can use it in 0.12 and 0.13.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1368: Issue #1367: HdrHeap potential corruption

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1368
  
@maskit @shinrich ping? Should we back port to 7.1.x ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1373: #1279 - CID 1367531: Uninitialized members...

[bryancall]

Github user bryancall closed the pull request at:

https://github.com/apache/trafficserver/pull/1373


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1380: Fixed issue where somaxconn was being set to 0 on...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1380
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1399/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1378: 7.1.x TS-5107: Changes to autolinking in Docutils...

[jablko]

Github user jablko commented on the issue:

https://github.com/apache/trafficserver/pull/1378
  
> Also, please remember to add Milestone, Label's etc. on each Issue / PR, 
otherwise @bryancall gets all pissy. :)

Will do! :-)

> Why are there 4 commits on this? Can you squash those? Or do we actually 
need these reverts as well?

Make that 5 ... I just added #1377 to this PR because this is broken 
without it. Whoops.

I think we need the reverts, this doesn't apply without them, and I think 
it makes most sense to maintain the parallel between the commits we're 
backporting and master -- so apply them as individual commits. That said, I'm 
happy to do it differently! I'm happy to squash any combination of them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1380: Fixed issue where somaxconn was being set to 0 on...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1380
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1400/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1380: Fixed issue where somaxconn was being set to 0 on...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1380
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1294/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1275: TS-5105: Do vc->con.setRemote(target) before sock...

[bryancall]

Github user bryancall commented on the issue:

https://github.com/apache/trafficserver/pull/1275
  
Please make sure pull requests are reviewed before merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1275: TS-5105: Do vc->con.setRemote(target) before sock...

[oknet]

Github user oknet commented on the issue:

https://github.com/apache/trafficserver/pull/1275
  
Got it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1380: Fixed issue where somaxconn was being set to 0 on...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1380
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1401/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1283: CID 1367526: CID 1367525 : money_trace/money_trac...

[bryancall]

Github user bryancall closed the issue at:

https://github.com/apache/trafficserver/issues/1283


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1378: 7.1.x TS-5107: Changes to autolinking in Docutils...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1378
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1398/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1378: 7.1.x TS-5107: Changes to autolinking in Docutils...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1378
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1292/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1380: Fixed issue where somaxconn was being set ...

[bryancall]

GitHub user bryancall opened a pull request:

https://github.com/apache/trafficserver/pull/1380

Fixed issue where somaxconn was being set to 0 on OSX and preventing

ATS to work

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bryancall/trafficserver osx_reboot

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1380.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1380


commit 0d4b4692a1f2fc0f566d03d09343763442ff498b
Author: Bryan Call 
Date:   2017-01-26T01:20:44Z

Fixed issue where somaxconn was being set to 0 on OSX and preventing
ATS to work




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1380: Fixed issue where somaxconn was being set to 0 on...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1380
  
ink_inet.cc:613:10: error: unused variable 'value_size' 
[-Werror=unused-variable]
   size_t value_size = sizeof(value);



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1345: Crash on retry to open server connection with POS...

[oknet]

Github user oknet commented on the issue:

https://github.com/apache/trafficserver/issues/1345
  
@bcall Sorry, I'm not familiar with HttpSM. Also I think this issue is
covered in the topic that "Kees Spoelstra" described in
secur...@trafficserver.apache.org.

2017-01-26 8:23 GMT+08:00 Bryan Call :

> Assigned #1345  to
> @oknet .
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1279: CID 1367531: Uninitialized members (UNINIT_CTOR):...

[bryancall]

Github user bryancall commented on the issue:

https://github.com/apache/trafficserver/issues/1279
  
This was closed in PR #1279


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1279: CID 1367531: Uninitialized members (UNINIT_CTOR):...

[bryancall]

Github user bryancall closed the issue at:

https://github.com/apache/trafficserver/issues/1279


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1380: Fixed issue where somaxconn was being set to 0 on...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1380
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1293/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1380: Fixed issue where somaxconn was being set ...

[bryancall]

Github user bryancall closed the pull request at:

https://github.com/apache/trafficserver/pull/1380


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: docs-master #201

[jenkins]

https://ci.trafficserver.apache.org/job/docs-master/201/Changes:

[Leif Hedstrom] Modify TSHttpTxnHookAdd to add hook only once

[Leif Hedstrom] [TS-5024] Ran clang-format. Modify TSHttpTxnHookAdd to add hook 
only

[Chao Xu] Do not reschedule the periodic inactive_event and cancel it after 
signal

[Leif Hedstrom] Change connect_attempts_rr_retries test to match warning text

[shinrich] TS-5022: nullptr check

[Leif Hedstrom] This avoids some badness around some STL implementations, where 
the

[jack] Replace gethostbyname_r() and gethostbyaddr_r()

[Bryan Call] Issue #1358: Add server_connect_end milestone.

[Bryan Call] Issue #1359: Flaw in TS-2157 port in server address may be unset

[Bryan Call] Skip modifying response length for HEAD response

[Bryan Call] TS-4991: jtest should handle Range requests.

[jack] Fixes for building with LibreSSL

[jack] Debian libexecdir is a subdirectory of libdir

[jack] TS-4716: OpenBSD mandir should be ${prefix}/man

[jack] Fix CID 1368305: Dereference before null check

[Bryan Call] TS-5079: logging enhancements around OCSP

[Leif Hedstrom] TS-5080: log when remap.config is successfully reloaded

[shinrich] Issue #1367: HdrHeap potential corruption

[shinrich] Issue #1360: REGRESSION_TEST(SDK_API_OVERRIDABLE_CONFIGS) sometimes

[jonsime] Revert "Fix nested role (not supported)"

[jonsime] Revert "Fix documentation build for docutils 0.13.1 (2/2)"

[jonsime] Revert "Fix documentation build for docutils 0.13.1 (1/2)"

[jonsime] TS-5107: Changes to autolinking in Docutils 0.13

--
[...truncated 17.32 KB...]
checking sys/sysinfo.h presence... yes
checking for sys/sysinfo.h... yes
checking sys/systeminfo.h usability... no
checking sys/systeminfo.h presence... no
checking for sys/systeminfo.h... no
checking netinet/in.h usability... yes
checking netinet/in.h presence... yes
checking for netinet/in.h... yes
checking netinet/in_systm.h usability... yes
checking netinet/in_systm.h presence... yes
checking for netinet/in_systm.h... yes
checking netinet/tcp.h usability... yes
checking netinet/tcp.h presence... yes
checking for netinet/tcp.h... yes
checking sys/ioctl.h usability... yes
checking sys/ioctl.h presence... yes
checking for sys/ioctl.h... yes
checking sys/byteorder.h usability... no
checking sys/byteorder.h presence... no
checking for sys/byteorder.h... no
checking sys/sockio.h usability... no
checking sys/sockio.h presence... no
checking for sys/sockio.h... no
checking sys/prctl.h usability... yes
checking sys/prctl.h presence... yes
checking for sys/prctl.h... yes
checking arpa/nameser.h usability... yes
checking arpa/nameser.h presence... yes
checking for arpa/nameser.h... yes
checking arpa/nameser_compat.h usability... yes
checking arpa/nameser_compat.h presence... yes
checking for arpa/nameser_compat.h... yes
checking for execinfo.h... (cached) yes
checking netdb.h usability... yes
checking netdb.h presence... yes
checking for netdb.h... yes
checking ctype.h usability... yes
checking ctype.h presence... yes
checking for ctype.h... yes
checking siginfo.h usability... no
checking siginfo.h presence... no
checking for siginfo.h... no
checking malloc.h usability... yes
checking malloc.h presence... yes
checking for malloc.h... yes
checking wait.h usability... yes
checking wait.h presence... yes
checking for wait.h... yes
checking float.h usability... yes
checking float.h presence... yes
checking for float.h... yes
checking libgen.h usability... yes
checking libgen.h presence... yes
checking for libgen.h... yes
checking values.h usability... yes
checking values.h presence... yes
checking for values.h... yes
checking alloca.h usability... yes
checking alloca.h presence... yes
checking for alloca.h... yes
checking cpio.h usability... yes
checking cpio.h presence... yes
checking for cpio.h... yes
checking stropts.h usability... no
checking stropts.h presence... no
checking for stropts.h... no
checking for sys/param.h... (cached) yes
checking sys/sysmacros.h usability... yes
checking sys/sysmacros.h presence... yes
checking for sys/sysmacros.h... yes
checking math.h usability... yes
checking math.h presence... yes
checking for math.h... yes
checking for stdint.h... (cached) yes
checking stdbool.h usability... yes
checking stdbool.h presence... yes
checking for stdbool.h... yes
checking sysexits.h usability... yes
checking sysexits.h presence... yes
checking for sysexits.h... yes
checking net/ppp_defs.h usability... yes
checking net/ppp_defs.h presence... yes
checking for net/ppp_defs.h... yes
checking ifaddrs.h usability... yes
checking ifaddrs.h presence... yes
checking for ifaddrs.h... yes
checking for readline/readline.h... (cached) no
checking editline/readline.h usability... yes
checking editline/readline.h presence... yes
checking for editline/readline.h... yes
checking ucred.h usability... no
checking ucred.h presence... no
checking for ucred.h... no
checking sys/statfs.h usability... yes
checking sys/statfs.h presence... 

[GitHub] trafficserver pull request #1303: TS-5107: Changes to autolinking in Docutil...

[jsime]

Github user jsime closed the pull request at:

https://github.com/apache/trafficserver/pull/1303


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1367: HdrHeap potential corruption

[maskit]

Github user maskit commented on the issue:

https://github.com/apache/trafficserver/issues/1367
  
Yes, I solved the problem, but the coalescing issue is still alive. This 
kind of bugs can be made again until we get some measure for it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1375: Incorrectly freeing Http1ClientSession set...

[shinrich]

GitHub user shinrich opened a pull request:

https://github.com/apache/trafficserver/pull/1375

Incorrectly freeing Http1ClientSession setting up to return a error

Saw a very deep stack.  The following is the stop of the stack.

{code}
#0 0x in ?? ()
#1 0x005e05ab in Http1ClientTransaction::do_io_write 
(this=0x2b512412e3d8, c=0x2b4ffd082470, nbytes=123, buf=0x2b50b4075e60, 
owner=false) at Http1ClientTransaction.h:45
#2 0x0063c7f5 in HttpTunnel::producer_run (this=0x2b4ffd082470, 
p=0x2b4ffd082670) at HttpTunnel.cc:916
#3 0x0063c103 in HttpTunnel::tunnel_run (this=0x2b4ffd082470, 
p_arg=0x2b4ffd082670) at HttpTunnel.cc:734
#4 0x005ff225 in HttpSM::setup_internal_transfer 
(this=0x2b4ffd080fd0, handler_arg=(int (HttpSM::)(HttpSM *, int, void *)) 
0x5f383c ) at HttpSM.cc:6222
#5 0x005ef6ae in HttpSM::handle_api_return (this=0x2b4ffd080fd0) at 
HttpSM.cc:1721
#6 0x005ef30b in HttpSM::state_api_callout (this=0x2b4ffd080fd0, 
event=6, data=0x0) at HttpSM.cc:1596
#7 0x005ee9e6 in HttpSM::state_api_callback (this=0x2b4ffd080fd0, 
event=6, data=0x0) at HttpSM.cc:1394
#8 0x00534ea1 in TSHttpTxnReenable (txnp=0x2b4ffd080fd0, 
event=TS_EVENT_HTTP_CONTINUE) at InkAPI.cc:5652
{code}

I spent some time grubbing through the core. It is interesting that the 
whole transaction is on the stack. The Http1ClientSession gets created in frame 
67. We crash because it has been deleted.

I think the problem is in frame 4 in HttpSM::setup_internal_transfer. This 
is an error case. Specifically ATS is trying to return "HTTP/1.0 500 INKApi 
Error\r\nDate: Wed, 18 May 2016 20:21:46 GMT\r\nConnection: close\r\nServer: 
ATS/5.3.0\r\nContent-Length: 0\r\n\r\n" which gets set from 
HttpTransact::HandleApiErrorJump.

But in setup_internal_transfer, we call tunnel.kill_tunnel to remove any 
previous static producers. But if there was a previous tunnel setup with our 
Http1ClientTransaction/Session as a consumer, it would call do_io_close on it 
which would likely free the Http1ClientSession object.

Replaced the kill_tunnel with a reset which doesn't free the 
consumer/producer.  The crash went away.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shinrich/trafficserver early-client-free

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1375.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1375


commit 95010edee4c5378b4f1f46174100e7a6e6115d13
Author: Susan Hinrichs 
Date:   2017-01-25T20:46:56Z

Incorrectly freeing Http1ClientSession while setting up to return a error 
header.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1375: Incorrectly freeing Http1ClientSession setting up...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1375
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1392/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1375: Incorrectly freeing Http1ClientSession setting up...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1375
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1286/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1370: Issue #1369: proxy.config.http.server_max_...

[shinrich]

Github user shinrich commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1370#discussion_r97871781
  
--- Diff: proxy/http/HttpSM.cc ---
@@ -4933,8 +4933,10 @@ HttpSM::do_http_server_open(bool raw)
 // between the statement above and the check below.
 // If this happens, we might go over the max by 1 but this is ok.
 if (sum >= t_state.http_config_param->server_max_connections) {
-  ink_assert(pending_action == nullptr);
-  pending_action = eventProcessor.schedule_in(this, 
HRTIME_MSECONDS(100));
+  // Eventually may want to have a queue as the origin_max_connection 
does to allow for a combination
+  // of retries and errors.  But at this point, we are just going to 
allow the error case.
+  t_state.current.state = HttpTransact::CONNECTION_ERROR;
+  call_transact_and_set_next_state(HttpTransact::HandleResponse);
   httpSessionManager.purge_keepalives();
--- End diff --

This is the order we are currently running in Yahoo production.  The 
purge_keepalives is just clearing out the global pool, so it should not 
interfere is the set next state.  This was pre-existing code.  I'm guessing the 
rationale is that is the system is loaded, we should be shutting down idle 
connections.  Could do the purge first I suppose.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Build failed in Jenkins: docs-master #201

[Jon Sime]

Sure enough, if I downgrade Sphinx to 1.4.8 it's failing in that same spot
for me. Looks like PR 1303 that I merged today was depending on changes
from the stable 1.5 release.

On Wed, Jan 25, 2017 at 1:53 PM, 
wrote:

> https://ci.trafficserver.apache.org/job/docs-master/201/Changes:
>
> [Leif Hedstrom] Modify TSHttpTxnHookAdd to add hook only once
>
> [Leif Hedstrom] [TS-5024] Ran clang-format. Modify TSHttpTxnHookAdd to add
> hook only
>
> [Chao Xu] Do not reschedule the periodic inactive_event and cancel it
> after signal
>
> [Leif Hedstrom] Change connect_attempts_rr_retries test to match warning
> text
>
> [shinrich] TS-5022: nullptr check
>
> [Leif Hedstrom] This avoids some badness around some STL implementations,
> where the
>
> [jack] Replace gethostbyname_r() and gethostbyaddr_r()
>
> [Bryan Call] Issue #1358: Add server_connect_end milestone.
>
> [Bryan Call] Issue #1359: Flaw in TS-2157 port in server address may be
> unset
>
> [Bryan Call] Skip modifying response length for HEAD response
>
> [Bryan Call] TS-4991: jtest should handle Range requests.
>
> [jack] Fixes for building with LibreSSL
>
> [jack] Debian libexecdir is a subdirectory of libdir
>
> [jack] TS-4716: OpenBSD mandir should be ${prefix}/man
>
> [jack] Fix CID 1368305: Dereference before null check
>
> [Bryan Call] TS-5079: logging enhancements around OCSP
>
> [Leif Hedstrom] TS-5080: log when remap.config is successfully reloaded
>
> [shinrich] Issue #1367: HdrHeap potential corruption
>
> [shinrich] Issue #1360: REGRESSION_TEST(SDK_API_OVERRIDABLE_CONFIGS)
> sometimes
>
> [jonsime] Revert "Fix nested role (not supported)"
>
> [jonsime] Revert "Fix documentation build for docutils 0.13.1 (2/2)"
>
> [jonsime] Revert "Fix documentation build for docutils 0.13.1 (1/2)"
>
> [jonsime] TS-5107: Changes to autolinking in Docutils 0.13
>
> --
> [...truncated 17.32 KB...]
> checking sys/sysinfo.h presence... yes
> checking for sys/sysinfo.h... yes
> checking sys/systeminfo.h usability... no
> checking sys/systeminfo.h presence... no
> checking for sys/systeminfo.h... no
> checking netinet/in.h usability... yes
> checking netinet/in.h presence... yes
> checking for netinet/in.h... yes
> checking netinet/in_systm.h usability... yes
> checking netinet/in_systm.h presence... yes
> checking for netinet/in_systm.h... yes
> checking netinet/tcp.h usability... yes
> checking netinet/tcp.h presence... yes
> checking for netinet/tcp.h... yes
> checking sys/ioctl.h usability... yes
> checking sys/ioctl.h presence... yes
> checking for sys/ioctl.h... yes
> checking sys/byteorder.h usability... no
> checking sys/byteorder.h presence... no
> checking for sys/byteorder.h... no
> checking sys/sockio.h usability... no
> checking sys/sockio.h presence... no
> checking for sys/sockio.h... no
> checking sys/prctl.h usability... yes
> checking sys/prctl.h presence... yes
> checking for sys/prctl.h... yes
> checking arpa/nameser.h usability... yes
> checking arpa/nameser.h presence... yes
> checking for arpa/nameser.h... yes
> checking arpa/nameser_compat.h usability... yes
> checking arpa/nameser_compat.h presence... yes
> checking for arpa/nameser_compat.h... yes
> checking for execinfo.h... (cached) yes
> checking netdb.h usability... yes
> checking netdb.h presence... yes
> checking for netdb.h... yes
> checking ctype.h usability... yes
> checking ctype.h presence... yes
> checking for ctype.h... yes
> checking siginfo.h usability... no
> checking siginfo.h presence... no
> checking for siginfo.h... no
> checking malloc.h usability... yes
> checking malloc.h presence... yes
> checking for malloc.h... yes
> checking wait.h usability... yes
> checking wait.h presence... yes
> checking for wait.h... yes
> checking float.h usability... yes
> checking float.h presence... yes
> checking for float.h... yes
> checking libgen.h usability... yes
> checking libgen.h presence... yes
> checking for libgen.h... yes
> checking values.h usability... yes
> checking values.h presence... yes
> checking for values.h... yes
> checking alloca.h usability... yes
> checking alloca.h presence... yes
> checking for alloca.h... yes
> checking cpio.h usability... yes
> checking cpio.h presence... yes
> checking for cpio.h... yes
> checking stropts.h usability... no
> checking stropts.h presence... no
> checking for stropts.h... no
> checking for sys/param.h... (cached) yes
> checking sys/sysmacros.h usability... yes
> checking sys/sysmacros.h presence... yes
> checking for sys/sysmacros.h... yes
> checking math.h usability... yes
> checking math.h presence... yes
> checking for math.h... yes
> checking for stdint.h... (cached) yes
> checking stdbool.h usability... yes
> checking stdbool.h presence... yes
> checking for stdbool.h... yes
> checking sysexits.h usability... yes
> checking sysexits.h presence... yes
> checking for sysexits.h... yes
> checking net/ppp_defs.h usability... yes
> checking 

[GitHub] trafficserver issue #1370: Issue #1369: proxy.config.http.server_max_connect...

[shinrich]

Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/pull/1370
  
Addressed Alan's comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---