[jira] [Commented] (ZOOKEEPER-3352) Use LevelDB For Backend
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17209922#comment-17209922 ] Michael Han commented on ZOOKEEPER-3352: I would recommend we close this issue and focus on ZOOKEEPER-3783 - which continues the efforts that [~lvfangmin] etc prototyped. It's also certainly possible to implement LevelDB based snap now Snap interface and change data capture infrastructure is introduced, but I would argue RocksDB is a better choice given its adoption and community maturity. > Use LevelDB For Backend > --- > > Key: ZOOKEEPER-3352 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3352 > Project: ZooKeeper > Issue Type: New Feature > Components: server >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Critical > Fix For: 4.0.0 > > > Use LevelDB for managing data stored in ZK (transaction logs and snapshots). > https://stackoverflow.com/questions/6779669/does-leveldb-support-java -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ZOOKEEPER-3965) Add documentation for RocksDB Snap feature
Michael Han created ZOOKEEPER-3965: -- Summary: Add documentation for RocksDB Snap feature Key: ZOOKEEPER-3965 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3965 Project: ZooKeeper Issue Type: Sub-task Components: documentation Reporter: Michael Han -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ZOOKEEPER-3783) Build ZooKeeper based on RocksDB
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17209924#comment-17209924 ] Michael Han commented on ZOOKEEPER-3783: Please refer to sub tasks for the progress of this ticket. Use this ticket as an umbrella to consolidate all on disk storage engine related tickets / tasks. > Build ZooKeeper based on RocksDB > - > > Key: ZOOKEEPER-3783 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3783 > Project: ZooKeeper > Issue Type: New Feature > Components: server >Reporter: Fangmin Lv >Assignee: Michael Han >Priority: Major > Attachments: 0001-Use-RocksDB-for-taking-a-snapshot.patch > > > Here are the things we have done so far with ZK on RocksDB project, it's in > an initial phase, we don't have time to explore more, but put here in case > the community is interested in and can help move this forward. > > *[Ideas]* > > When we were designing and working on this project, it was set into 3 phases: > > *1. Moving ZK snapshot onto RocksDB to reducing snapshot disk IO* > > It still keeps the in memory DataTree but uses RocksDB for it's snapshot to > leverage the benefit of incremental snapshot in RocksDB to reduce the write > amplification when having large snapshot but only small partial of hot znodes > being changed. > > Since ZK has it’s own txn file, the WAL in RocksDB could be disabled to avoid > double writing. > > *2. Removing in memory DataTree to get rid of memory bound* > > Read data from RocksDB (maybe with some cache), but keep key structures like > children in memory, so ZK won't be bounded to the memory limit, and still > have good through for APIs like getChildren. > > *3. Moving txn log into RocksDB with different column family* > > Consider to move the log into the RocksDB to get rid of the ZK txn files, so > that we don't need to manage the txn files ourselves and probably the > backup/restore would be simpler. > > *[Implementation for phase 1]* > > The attachment is the initial version of for the 1st phase, it may not able > to apply to the latest master code since it was based on a very old commit, > but you can get some idea from this. > > The idea is simple, when changes are made in DataTree, they're recorded and > applied to the RocksDB when processTxn in ZKDatabase. > > When loading from disk, it will iterate through the RocksDB keys to restore > the in memory DataTree. > > It also considered things for slowly rollout or rollback, so it can support > reading from snapshot file and write to RocksDB, or read from RocksDB and > write to file during runtime based on the flag. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Deleted] (ZOOKEEPER-3945) poker
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han deleted ZOOKEEPER-3945: --- > poker > - > > Key: ZOOKEEPER-3945 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3945 > Project: ZooKeeper > Issue Type: New Feature > Environment: Popularitas poker dengan cepat menjadi permainan yang > paling banyak dinikmati di dunia. Permainan populer ini dikatakan telah > sepenuhnya direvolusi oleh Chris Moneymaker, ketika ia menang di World Series > of Poker pada tahun 2003 setelah menggunakan situs poker online untuk > memenuhi syarat. Media telah menciptakan sensasi ini dan akibatnya yang > langgeng “efek Penghasil Uang”. Seorang akuntan rendahan, Moneymaker > memainkan turnamen satelit tiga puluh sembilan dolar di situs poker online > PokerStars, memenangkan kursi di acara utama World Series of Poker. Itu > adalah turnamen langsung pertama Moneymaker, dan dia membawa pulang hadiah > dua setengah juta dolar. Karena acara yang disiarkan secara luas dan > dihebohkan ini, poker online meledak ke layar dengan ribuan orang lain yang > bercita-cita menjadi besar. > Dengan ribuan pemain poker yang berharap bermimpi menjadi besar setelah > menyaksikan kemenangan Chris Moneymaker, popularitas bermain poker online > melonjak ke ketinggian baru. > Bentuk Popularitas poker yang paling umum adalah Texas Holdem. > Di Texas Holdem, yang dikatakan berasal dari Robstown, Texas, setiap pemain > diberikan dua kartu tertutup sementara lima kartu komunitas diserahkan oleh > dealer. Setiap pemain memiliki kesempatan untuk bertaruh, memeriksa, atau > melipat setelah setiap kesepakatan. Popularitasnya telah meledak selama awal > 2000-an, bahkan menggantikan stud tujuh kartu sebagai permainan kasino > Amerika Serikat yang paling banyak dimainkan. > Dengan ribuan pemain poker yang berharap bermimpi menjadi besar setelah > menyaksikan kemenangan Chris Moneymaker, popularitas bermain poker online > melonjak ke ketinggian baru. Kemudahan permainan dapat dimainkan secara > online sangat menarik bagi pemain pemula. Kasino mungkin menakutkan bagi > pemula. Mereka mungkin juga berlokasi di daerah yang secara geografis tidak > nyaman, hanya menarik penduduk lokal atau mereka yang mampu membayar liburan > mahal. Situs poker online juga memiliki taruhan yang lebih rendah daripada > kasino, karena tidak sebanding dengan waktu operasi kehidupan nyata untuk > menjalankan permainan dengan pot kecil yang tidak akan membayar biaya > overhead mereka. Menambahkan tabel untuk permainan dengan berbagai biaya dan > jenis permainan juga tidak akan menghabiskan ruang online seperti di kasino > kehidupan nyata. > Ada beberapa situs berbeda yang tersedia untuk bermain poker online, termasuk > PokerStars, Party Poker, William Hill, Everest Poker, dan Bodog. Mungkin yang > paling terkenal di antara situs untuk bermain poker online adalah PokerStars > – ruang kartu online terbesar di dunia. Situs penting lainnya untuk bermain > poker online adalah Bodog Poker. Dibuat oleh Calvin Ayre, Bodog adalah ruang > poker online AS yang diperdagangkan terbesar dan salah satu situs judi online > paling tepercaya. >Reporter: azziazah >Priority: Minor > > Popularitas poker dengan cepat menjadi permainan yang paling banyak dinikmati > di dunia. Permainan populer ini dikatakan telah sepenuhnya direvolusi oleh > Chris Moneymaker, ketika ia menang di World Series of Poker pada tahun 2003 > setelah menggunakan situs poker online untuk memenuhi syarat. Media telah > menciptakan sensasi ini dan akibatnya yang langgeng “efek Penghasil Uang”. > Seorang akuntan rendahan, Moneymaker memainkan turnamen satelit tiga puluh > sembilan dolar di situs poker online PokerStars, memenangkan kursi di acara > utama World Series of [dewapoker|https://linktr.ee/Poker_Online_Indonesia] . > Itu adalah turnamen langsung pertama Moneymaker, dan dia membawa pulang > hadiah dua setengah juta dolar. Karena acara yang disiarkan secara luas dan > dihebohkan ini, poker online meledak ke layar dengan ribuan orang lain yang > bercita-cita menjadi besar. > Dengan ribuan pemain poker yang berharap bermimpi menjadi besar setelah > menyaksikan kemenangan Chris Moneymaker, popularitas [dewa > poker|https://linktr.ee/Poker.Online.Terbesar] bermain poker online melonjak > ke ketinggian baru. > Bentuk Popularitas poker yang paling umum adalah Texas Holdem. > Di Texas Holdem, yang dikatakan berasal dari Robstown, Texas, setiap pemain > diberikan dua kartu tertutup sementara lima kartu komunitas diserahkan oleh > dealer. Setiap pemain memiliki kesempatan untuk bertaruh, memeriksa, atau > melipat setelah setiap kesepakatan. Popularitasnya telah meledak selama awal > 2000-an, bahkan menggantikan stud tujuh kartu sebagai permainan kasino > Amerika Serikat
[jira] [Created] (ZOOKEEPER-3948) Introduce a deterministic runtime behavior injection framework for ZooKeeperServer testing
Michael Han created ZOOKEEPER-3948: -- Summary: Introduce a deterministic runtime behavior injection framework for ZooKeeperServer testing Key: ZOOKEEPER-3948 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3948 Project: ZooKeeper Issue Type: New Feature Components: server, tests Reporter: Michael Han Assignee: Michael Han We'd like to understand how applications built on top of ZooKeeper behave under various faulty conditions, which is important to build resilient end to end solutions and avoid ZooKeeper being single point of failure. We'd also like to achieve this in both unit tests (in process) and integration tests (in and out of process). Traditional methods of using external fault injection mechanisms are non deterministic and requires non trivial set up and hard to integrate with unit tests, so here we introduce the ZooKeeperController service which solves both. The basic idea here is to create a controllable ZooKeeperServer which accepts various control commands (such as - delay request, drop request, eat request, expire session, shutdown, trigger leader election, and so on), and reacting based on incoming commands. The controllable server and production server share the same underlying machineries (quorum peers, ZooKeeper server, etc) but code paths are separate, thus this feature has no production impact. This controller system is currently composed of following pieces: * CommandClient: a convenient HTTP client to send control commands to controller service. * CommandListener: an embed HTTP server listening incoming commands and dispatch to controller service. * Controller Service: the service that's responsible to create controllable ZK server and the controller. * ZooKeeperServerController: the controller that changes the behavior of ZK server runtime. * Controllable Cnx / Factory: controllable connection that accept behavior change requests. In future more control commands and controllable components can be added on top of this framework. This can be used in either unit tests / integration tests as an in process embedded controllable ZooKeeper server, or as an out of process stand alone controllable ZooKeeper process. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ZOOKEEPER-3841) remove useless codes in the Leader.java
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Han resolved ZOOKEEPER-3841.
Fix Version/s: 3.6.3
Resolution: Fixed
Issue resolved by pull request 1394
[https://github.com/apache/zookeeper/pull/1394]
> remove useless codes in the Leader.java
> ---
>
> Key: ZOOKEEPER-3841
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3841
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
>Reporter: maoling
>Priority: Minor
> Fix For: 3.6.3
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> - There are some useless code in the Leader.java which were comment out.
> - Pls recheck all the things in this class to clear up
> e.g:
> {code:java}
> // Everything is a go, simply start counting the ticks
> // WARNING: I couldn't find any wait statement on a synchronized
> // block that would be notified by this notifyAll() call, so
> // I commented it out
> //synchronized (this) {
> //notifyAll();
> //}
> {code}
> {code:java}
> //turnOffFollowers();
> {code}
> {code:java}
> //LOG.warn("designated leader is: " + designatedLeader);
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (ZOOKEEPER-3858) Add metrics to track server unavailable time
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han resolved ZOOKEEPER-3858. Fix Version/s: (was: 3.7.0) 3.6.3 Resolution: Fixed Issue resolved by pull request 1378 [https://github.com/apache/zookeeper/pull/1378] > Add metrics to track server unavailable time > > > Key: ZOOKEEPER-3858 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3858 > Project: ZooKeeper > Issue Type: Improvement > Components: metric system >Reporter: Jie Huang >Priority: Minor > Fix For: 3.6.3 > > Time Spent: 10m > Remaining Estimate: 0h > > These metrics track the time when a ZooKeeper server is up and running but > not serving client traffic because it is not part of a quorum. They don't > track the hardware down time or ZooKeeper process down time. > UNAVAILABLE_TIME: time between LOOKING and BROADCAST > LEADER_UNAVAILABLE_TIME: time between LOOKING and BROADCAST on the leader > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (ZOOKEEPER-3858) Add metrics to track server unavailable time
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han reassigned ZOOKEEPER-3858: -- Assignee: Jie Huang > Add metrics to track server unavailable time > > > Key: ZOOKEEPER-3858 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3858 > Project: ZooKeeper > Issue Type: Improvement > Components: metric system >Reporter: Jie Huang >Assignee: Jie Huang >Priority: Minor > Fix For: 3.6.3 > > Time Spent: 20m > Remaining Estimate: 0h > > These metrics track the time when a ZooKeeper server is up and running but > not serving client traffic because it is not part of a quorum. They don't > track the hardware down time or ZooKeeper process down time. > UNAVAILABLE_TIME: time between LOOKING and BROADCAST > LEADER_UNAVAILABLE_TIME: time between LOOKING and BROADCAST on the leader > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ZOOKEEPER-3798) remove the useless code in the ProposalRequestProcessor#processRequest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Han resolved ZOOKEEPER-3798.
Fix Version/s: (was: 3.7.0)
3.6.3
Resolution: Fixed
Issue resolved by pull request 1335
[https://github.com/apache/zookeeper/pull/1335]
> remove the useless code in the ProposalRequestProcessor#processRequest
> --
>
> Key: ZOOKEEPER-3798
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3798
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
>Reporter: maoling
>Priority: Minor
> Labels: pull-request-available
> Fix For: 3.6.3
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> remove the following useless codes in the
> ProposalRequestProcessor#processRequest
> {code:java}
> public void processRequest(Request request) throws RequestProcessorException {
> // LOG.warn("Ack>>> cxid = " + request.cxid + " type = " +
> // request.type + " id = " + request.sessionId);
> // request.addRQRec(">prop");
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (ZOOKEEPER-3419) Backup and recovery support
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858192#comment-16858192 ] Michael Han edited comment on ZOOKEEPER-3419 at 10/3/20, 2:42 AM: -- They overlapped only in their names :) - implementation wise they are orthogonal and feature wise this Jira is more rich in terms of supporting various backup and restore use cases. Both can co-exist if community accept both, so I am not particularly worried about it. Thanks for the heads up though was (Author: hanm): They overlapped only in their names :) - implementation wise they are orthogonal and feature wise this Jira is more rich in terms of supporting various backup and restore use cases. Both can co-exist if community accept both, so I am not particularly worried about it. Thanks for the heads up though [~nixon]! > Backup and recovery support > --- > > Key: ZOOKEEPER-3419 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3419 > Project: ZooKeeper > Issue Type: New Feature > Components: server >Affects Versions: 3.6.0 >Reporter: Michael Han >Assignee: Michael Han >Priority: Major > Labels: Twitter > > Historically ZooKeeper has no intrinsic support for backup and restore. The > usual approach of doing backup and restore is through customized scripts to > copy data around, or through some 3rd party tools (exhibitor, etc), which > introduces operation burden. > This Jira will introduce another option: a direct support of backup and > restore from ZooKeeper itself. It's completely built into ZooKeeper, support > point in time recovery of an entire tree rooted after an oops event, support > recovery partial tree for test/dev purpose, and can help replay history for > bug investigation. It will try to provide a generic interface so the backups > can be directed to different data storage systems (S3, Kafka, HDFS, etc). > This same system has been in production at Twitter for X years and proved to > be quite helpful for various use cases mentioned earlier. This will be a > relative big patch, we'll try break the feature down and incrementally submit > the patches when they are ready. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (ZOOKEEPER-3419) Backup and recovery support
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206590#comment-17206590 ] Michael Han edited comment on ZOOKEEPER-3419 at 10/3/20, 2:42 AM: -- I have a working in progress branch that targeting upstream but that fell through cracks due to other priorities. It will take a while to make sure it's mergeable. I will submit the branch as is next week so folks at LinkedIn / community can pre-review, or even help me polish and finish the patch. The code is quite straightforward, the only tricky part is we probably need rewrite some of the intrusive changes we made in house to the ZK persistent layer. was (Author: hanm): I have a working in progress branch that targeting upstream but that fell through cracks due to other priorities. It will take a while to make sure it's mergeable. I will submit the branch as is so folks at LinkedIn / community can pre-review, or even help me polish and finish the patch. The code is quite straightforward, the only tricky part is we probably need rewrite some of the intrusive changes we made in house to the ZK persistent layer. > Backup and recovery support > --- > > Key: ZOOKEEPER-3419 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3419 > Project: ZooKeeper > Issue Type: New Feature > Components: server >Affects Versions: 3.6.0 >Reporter: Michael Han >Assignee: Michael Han >Priority: Major > Labels: Twitter > > Historically ZooKeeper has no intrinsic support for backup and restore. The > usual approach of doing backup and restore is through customized scripts to > copy data around, or through some 3rd party tools (exhibitor, etc), which > introduces operation burden. > This Jira will introduce another option: a direct support of backup and > restore from ZooKeeper itself. It's completely built into ZooKeeper, support > point in time recovery of an entire tree rooted after an oops event, support > recovery partial tree for test/dev purpose, and can help replay history for > bug investigation. It will try to provide a generic interface so the backups > can be directed to different data storage systems (S3, Kafka, HDFS, etc). > This same system has been in production at Twitter for X years and proved to > be quite helpful for various use cases mentioned earlier. This will be a > relative big patch, we'll try break the feature down and incrementally submit > the patches when they are ready. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ZOOKEEPER-3419) Backup and recovery support
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206590#comment-17206590 ] Michael Han commented on ZOOKEEPER-3419: I have a working in progress branch that targeting upstream but that fell through cracks due to other priorities. It will take a while to make sure it's mergeable. I will submit the branch as is so folks at LinkedIn / community can pre-review, or even help me polish and finish the patch. The code is quite straightforward, the only tricky part is we probably need rewrite some of the intrusive changes we made in house to the ZK persistent layer. > Backup and recovery support > --- > > Key: ZOOKEEPER-3419 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3419 > Project: ZooKeeper > Issue Type: New Feature > Components: server >Affects Versions: 3.6.0 >Reporter: Michael Han >Assignee: Michael Han >Priority: Major > Labels: Twitter > > Historically ZooKeeper has no intrinsic support for backup and restore. The > usual approach of doing backup and restore is through customized scripts to > copy data around, or through some 3rd party tools (exhibitor, etc), which > introduces operation burden. > This Jira will introduce another option: a direct support of backup and > restore from ZooKeeper itself. It's completely built into ZooKeeper, support > point in time recovery of an entire tree rooted after an oops event, support > recovery partial tree for test/dev purpose, and can help replay history for > bug investigation. It will try to provide a generic interface so the backups > can be directed to different data storage systems (S3, Kafka, HDFS, etc). > This same system has been in production at Twitter for X years and proved to > be quite helpful for various use cases mentioned earlier. This will be a > relative big patch, we'll try break the feature down and incrementally submit > the patches when they are ready. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (ZOOKEEPER-3774) Close quorum socket asynchronously on the leader to avoid ping being blocked by long socket closing time
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han reassigned ZOOKEEPER-3774: -- Assignee: Jie Huang > Close quorum socket asynchronously on the leader to avoid ping being blocked > by long socket closing time > > > Key: ZOOKEEPER-3774 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3774 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Reporter: Jie Huang >Assignee: Jie Huang >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.3 > > Time Spent: 3h > Remaining Estimate: 0h > > In ZOOKEEPER-3574 we close the quorum sockets on followers asynchronously > when a leader is partitioned away so the shutdown process will not be stalled > by long socket closing time and the followers can quickly establish a new > quorum to serve client requests. > We've found that the long socket closing time can cause trouble on the leader > too when a follower is partitioned away if the partition is detected by > PingLaggingDetector. When the ping thread detects partition, it tries to > disconnect the follower. If the socket closing time is long, the ping thread > will be blocked and no ping is sent to any follower--even the ones still > connected to the leader--since the ping thread is responsible for sending > pings to all followers. When followers don't receive pings, they don't send > ping response. When the leader don't receive ping response, the sessions > expire. > To prevent good sessions from expiring, we need to close the socket > asynchronously on the leader too. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ZOOKEEPER-3774) Close quorum socket asynchronously on the leader to avoid ping being blocked by long socket closing time
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han resolved ZOOKEEPER-3774. Fix Version/s: (was: 3.7.0) 3.6.3 Resolution: Fixed Issue resolved by pull request 1301 [https://github.com/apache/zookeeper/pull/1301] > Close quorum socket asynchronously on the leader to avoid ping being blocked > by long socket closing time > > > Key: ZOOKEEPER-3774 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3774 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Reporter: Jie Huang >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.3 > > Time Spent: 2h 50m > Remaining Estimate: 0h > > In ZOOKEEPER-3574 we close the quorum sockets on followers asynchronously > when a leader is partitioned away so the shutdown process will not be stalled > by long socket closing time and the followers can quickly establish a new > quorum to serve client requests. > We've found that the long socket closing time can cause trouble on the leader > too when a follower is partitioned away if the partition is detected by > PingLaggingDetector. When the ping thread detects partition, it tries to > disconnect the follower. If the socket closing time is long, the ping thread > will be blocked and no ping is sent to any follower--even the ones still > connected to the leader--since the ping thread is responsible for sending > pings to all followers. When followers don't receive pings, they don't send > ping response. When the leader don't receive ping response, the sessions > expire. > To prevent good sessions from expiring, we need to close the socket > asynchronously on the leader too. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ZOOKEEPER-3847) Add a couple metrics to help track Netty memory usage
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han resolved ZOOKEEPER-3847. Resolution: Fixed Issue resolved by pull request 1367 [https://github.com/apache/zookeeper/pull/1367] > Add a couple metrics to help track Netty memory usage > - > > Key: ZOOKEEPER-3847 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3847 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Reporter: Jie Huang >Priority: Minor > Fix For: 3.6.2 > > Time Spent: 20m > Remaining Estimate: 0h > > Adding these metrics: > * RESPONSE_BYTES: size of responses (in bytes) being sent to a client > * WATCH_BYTES: size of watch events (in bytes) being sent to a client > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (ZOOKEEPER-3847) Add a couple metrics to help track Netty memory usage
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han reassigned ZOOKEEPER-3847: -- Assignee: Jie Huang > Add a couple metrics to help track Netty memory usage > - > > Key: ZOOKEEPER-3847 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3847 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Reporter: Jie Huang >Assignee: Jie Huang >Priority: Minor > Fix For: 3.6.2 > > Time Spent: 20m > Remaining Estimate: 0h > > Adding these metrics: > * RESPONSE_BYTES: size of responses (in bytes) being sent to a client > * WATCH_BYTES: size of watch events (in bytes) being sent to a client > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (ZOOKEEPER-3846) Add a couple TLS related metrics
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han reassigned ZOOKEEPER-3846: -- Assignee: Jie Huang > Add a couple TLS related metrics > > > Key: ZOOKEEPER-3846 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3846 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Reporter: Jie Huang >Assignee: Jie Huang >Priority: Minor > Fix For: 3.6.2 > > Time Spent: 20m > Remaining Estimate: 0h > > Adding those metrics: > * UNSUCCESSFUL_HANDSHAKE: number of unsuccessful TLS handshakes > * INSECURE_ADMIN: number of insecure connections to admin port -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ZOOKEEPER-3846) Add a couple TLS related metrics
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han resolved ZOOKEEPER-3846. Resolution: Fixed Issue resolved by pull request 1366 [https://github.com/apache/zookeeper/pull/1366] > Add a couple TLS related metrics > > > Key: ZOOKEEPER-3846 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3846 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Reporter: Jie Huang >Priority: Minor > Fix For: 3.6.2 > > Time Spent: 10m > Remaining Estimate: 0h > > Adding those metrics: > * UNSUCCESSFUL_HANDSHAKE: number of unsuccessful TLS handshakes > * INSECURE_ADMIN: number of insecure connections to admin port -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ZOOKEEPER-3561) Generalize target authentication scheme for ZooKeeper authentication enforcement.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219982#comment-17219982 ] Michael Han commented on ZOOKEEPER-3561: [~arshad.mohammad] To be honest I don't have much visibility on the criteria of cherry picking master commits to other branches these days ... [~eolivelli] might have more contexts as he's managing recent releases. Feel free to start a thread on dev list about this topic (I am curious myself). > Generalize target authentication scheme for ZooKeeper authentication > enforcement. > - > > Key: ZOOKEEPER-3561 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3561 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.6.0 >Reporter: Michael Han >Assignee: Mohammad Arshad >Priority: Major > Labels: pull-request-available > Fix For: 3.7.0 > > Time Spent: 5h 50m > Remaining Estimate: 0h > > ZOOKEEPER-1634 introduced an option to allow user enforce authentication for > ZooKeeper clients, but the enforced authentication scheme in committed > implementation was SASL only. > This JIRA is to generalize the authentication scheme such that the > authentication enforcement on ZooKeeper clients could work with any supported > authentication scheme. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Deleted] (ZOOKEEPER-3984) Playing Until Die
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han deleted ZOOKEEPER-3984: --- > Playing Until Die > - > > Key: ZOOKEEPER-3984 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3984 > Project: ZooKeeper > Issue Type: Bug >Reporter: shacao666 >Priority: Major > > Situs poker resmi menyediakan fasilitas judi online yang beragam seperti > aplikasi IOS dan OS untuk mempermudah pernah agar tetap bisa login dimana dan > kapan saja. Selain aplikasi yang mebantu proses login jadi bergabung > fleksibel, aplikasi tersebut terintrogai dengan sever ternama yang > memperlancar ketika taruhan berlangsung di antaranya adalah > [dewatogel|http://www.dewatogelonline88.com/], > [poker88|https://199.192.31.67/] dan [dewabet|https://199.192.31.209/] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ZOOKEEPER-3985) pokerzoo
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221136#comment-17221136 ] Michael Han commented on ZOOKEEPER-3985: I think this is spam (google translate is your friend if anyone curious whats this is). I am going to delete it. > pokerzoo > > > Key: ZOOKEEPER-3985 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3985 > Project: ZooKeeper > Issue Type: Bug > Components: audit > Environment: [link title|http://example.com][link > title|http://example.com] >Reporter: nadiao >Priority: Major > > kartu poker > Popularitas poker dengan cepat menjadi permainan yang paling banyak dinikmati > di dunia. Permainan populer ini dikatakan telah sepenuhnya direvolusi oleh > Chris Moneymaker, ketika ia menang di World Series of Poker pada tahun 2003 > setelah menggunakan situs poker online untuk memenuhi syarat. Media telah > menciptakan sensasi ini dan akibatnya yang langgeng “efek Penghasil Uang”. > Seorang akuntan rendahan, kartu poker memainkan turnamen satelit tiga puluh > sembilan dolar di situs poker online PokerStars, memenangkan kursi di acara > utama World Series of Poker. Itu adalah turnamen langsung pertama Moneymaker, > dan dia membawa pulang hadiah dua setengah juta dolar. Karena acara yang > disiarkan secara luas dan dihebohkan ini, poker online meledak ke layar > dengan ribuan orang lain yang bercita-cita menjadi besar. > > Dengan ribuan pemain poker yang berharap bermimpi menjadi besar setelah > menyaksikan kemenangan Chris Moneymaker, popularitas bermain poker online > melonjak ke ketinggian baru. Di [pokerace 99|https://199.192.27.121] , yang > dikatakan berasal dari Robstown, Texas, setiap pemain diberikan dua kartu > tertutup sementara lima kartu komunitas diserahkan oleh dealer. Setiap pemain > memiliki kesempatan untuk bertaruh, memeriksa, atau melipat setelah setiap > kesepakatan. Popularitasnya telah meledak selama awal 2000-an, bahkan > menggantikan stud tujuh kartu sebagai permainan kasino Amerika Serikat yang > paling banyak dimainkan. > > Dengan ribuan pemain poker yang berharap bermimpi menjadi besar setelah > menyaksikan kemenangan Chris Moneymaker, popularitas bermain poker online > melonjak ke ketinggian baru. Kemudahan permainan dapat dimainkan secara > online sangat menarik bagi pemain pemula. Kasino mungkin menakutkan bagi > pemula. Mereka mungkin juga berlokasi di daerah yang secara geografis tidak > nyaman, hanya menarik penduduk lokal atau mereka yang mampu membayar liburan > mahal. Situs poker online juga memiliki taruhan yang lebih rendah daripada > https://199.192.27.121 , karena tidak sebanding dengan waktu operasi > kehidupan nyata untuk menjalankan permainan dengan pot kecil yang tidak akan > membayar biaya overhead mereka. Menambahkan tabel untuk permainan dengan > berbagai biaya dan jenis permainan juga tidak akan menghabiskan ruang online > seperti di kasino kehidupan nyata. > > Ada beberapa situs berbeda yang tersedia untuk bermain poker online, termasuk > PokerStars, Party Poker, William Hill, Everest Poker, dan Bodog. Mungkin yang > paling terkenal di antara situs untuk bermain poker online adalah PokerStars > – ruang kartu online terbesar di dunia. Situs penting lainnya untuk bermain > poker 88 online adalah Bodog Poker. Dibuat oleh Calvin Ayre, Bodog adalah > ruang poker online AS yang diperdagangkan terbesar dan salah satu situs judi > online paling tepercaya -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Deleted] (ZOOKEEPER-3985) pokerzoo
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han deleted ZOOKEEPER-3985: --- > pokerzoo > > > Key: ZOOKEEPER-3985 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3985 > Project: ZooKeeper > Issue Type: Bug > Environment: [link title|http://example.com][link > title|http://example.com] >Reporter: nadiao >Priority: Major > > kartu poker > Popularitas poker dengan cepat menjadi permainan yang paling banyak dinikmati > di dunia. Permainan populer ini dikatakan telah sepenuhnya direvolusi oleh > Chris Moneymaker, ketika ia menang di World Series of Poker pada tahun 2003 > setelah menggunakan situs poker online untuk memenuhi syarat. Media telah > menciptakan sensasi ini dan akibatnya yang langgeng “efek Penghasil Uang”. > Seorang akuntan rendahan, kartu poker memainkan turnamen satelit tiga puluh > sembilan dolar di situs poker online PokerStars, memenangkan kursi di acara > utama World Series of Poker. Itu adalah turnamen langsung pertama Moneymaker, > dan dia membawa pulang hadiah dua setengah juta dolar. Karena acara yang > disiarkan secara luas dan dihebohkan ini, poker online meledak ke layar > dengan ribuan orang lain yang bercita-cita menjadi besar. > > Dengan ribuan pemain poker yang berharap bermimpi menjadi besar setelah > menyaksikan kemenangan Chris Moneymaker, popularitas bermain poker online > melonjak ke ketinggian baru. Di [pokerace 99|https://199.192.27.121] , yang > dikatakan berasal dari Robstown, Texas, setiap pemain diberikan dua kartu > tertutup sementara lima kartu komunitas diserahkan oleh dealer. Setiap pemain > memiliki kesempatan untuk bertaruh, memeriksa, atau melipat setelah setiap > kesepakatan. Popularitasnya telah meledak selama awal 2000-an, bahkan > menggantikan stud tujuh kartu sebagai permainan kasino Amerika Serikat yang > paling banyak dimainkan. > > Dengan ribuan pemain poker yang berharap bermimpi menjadi besar setelah > menyaksikan kemenangan Chris Moneymaker, popularitas bermain poker online > melonjak ke ketinggian baru. Kemudahan permainan dapat dimainkan secara > online sangat menarik bagi pemain pemula. Kasino mungkin menakutkan bagi > pemula. Mereka mungkin juga berlokasi di daerah yang secara geografis tidak > nyaman, hanya menarik penduduk lokal atau mereka yang mampu membayar liburan > mahal. Situs poker online juga memiliki taruhan yang lebih rendah daripada > https://199.192.27.121 , karena tidak sebanding dengan waktu operasi > kehidupan nyata untuk menjalankan permainan dengan pot kecil yang tidak akan > membayar biaya overhead mereka. Menambahkan tabel untuk permainan dengan > berbagai biaya dan jenis permainan juga tidak akan menghabiskan ruang online > seperti di kasino kehidupan nyata. > > Ada beberapa situs berbeda yang tersedia untuk bermain poker online, termasuk > PokerStars, Party Poker, William Hill, Everest Poker, dan Bodog. Mungkin yang > paling terkenal di antara situs untuk bermain poker online adalah PokerStars > – ruang kartu online terbesar di dunia. Situs penting lainnya untuk bermain > poker 88 online adalah Bodog Poker. Dibuat oleh Calvin Ayre, Bodog adalah > ruang poker online AS yang diperdagangkan terbesar dan salah satu situs judi > online paling tepercaya -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (ZOOKEEPER-3863) Do not track global sessions in ReadOnlyZooKeeperServer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han reassigned ZOOKEEPER-3863: -- Assignee: Jie Huang > Do not track global sessions in ReadOnlyZooKeeperServer > --- > > Key: ZOOKEEPER-3863 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3863 > Project: ZooKeeper > Issue Type: Bug > Components: server >Reporter: Jie Huang >Assignee: Jie Huang >Priority: Minor > Fix For: 3.6.2 > > Time Spent: 10m > Remaining Estimate: 0h > > ReadOnlyZooKeeperServer is using the default SessionTrackerImpl, which tracks > and expires the global sessions, which should be tracked and expired only by > the leader. This diff changes the code to use LearnerSessionTracker, which > only tracks and expires local session. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ZOOKEEPER-3826) upgrade from 3.4.x to 3.5.x
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140059#comment-17140059
]
Michael Han commented on ZOOKEEPER-3826:
{quote}It seems that since the new version requires a snapshot to be present,
it would make sense for it to create one immediately upon successful startup
{quote}
Yes this is the expected behavior and because of this, disabling the
snapshot.trust.empty after upgrade should be ok because upgrade should involve
at least one restart after which the new version of ZK should kick in and
generate the snapshot.
bq. I'm not sure why it doesn't on an upgrade?
As we discussed earlier, this should not happen if the upgrade was successful.
Can we check the following:
* Was the upgrade successful? What's the version of the running ZK process
after upgrade?
* If ZK version is correct, check the file system to make sure it's indeed the
snapshot file was missing, instead of some IO / permission issue.
* If snapshot file is missing but ZK process is in right version (3.5.x or
3.6.x), this should be a bug and we'd need look further - a full server log
will be helpful in this case to help investigation.
> upgrade from 3.4.x to 3.5.x
> ---
>
> Key: ZOOKEEPER-3826
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3826
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
>Affects Versions: 3.5.7
> Environment: Kuberenetes
>Reporter: Aldan Brito
>Priority: Critical
>
> upgrade of zookeeper from 3.4.14 to 3.5.7
> We faced the snapshot issue which is described in
> https://issues.apache.org/jira/browse/ZOOKEEPER-3056
> After setting the property "snapshot.trust.empty=true" the upgrade was
> successful.
> while reverting the "snapshot.trust.empty=false" flag and restart of the
> zookeeper pods, one of the zookeeper server is failing with the similar stack
> trace no snapshot found.
> {code:java}
> {"type":"log", "host":"zk-testzk-0", "level":"ERROR",
> "neid":"zookeeper-4636c00bfc3849e0be179bc71cef17f8", "system":"zookeeper",
> "time":"2020-05-12T08:32:17.685Z", "timezone":"UTC", "log":{"message":"main -
> org.apache.zookeeper.server.quorum.QuorumPeer - Unable to load database on
> disk"}}
> java.io.IOException: No snapshot found, but there are log entries. Something
> is broken!
> at
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.restore(FileTxnSnapLog.java:240)
> at
> org.apache.zookeeper.server.ZKDatabase.loadDataBase(ZKDatabase.java:240)
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:901)
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:887)
> at
> org.apache.zookeeper.server.quorum.QuorumPeerMain.runFromConfig(QuorumPeerMain.java:205)
> at
> org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:123)
> at
> org.apache.zookeeper.server.quorum.QuorumPeerMain.main(QuorumPeerMain.java:82)
> {"type":"log", "host":"zk-testzk-0", "level":"ERROR",
> "neid":"zookeeper-4636c00bfc3849e0be179bc71cef17f8", "system":"zookeeper",
> "time":"2020-05-12T08:32:17.764Z", "timezone":"UTC", "log":{"message":"main -
> org.apache.zookeeper.server.quorum.QuorumPeerMain - Unexpected exception,
> exiting abnormally"}}
> java.lang.RuntimeException: Unable to run quorum server
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:938)
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:887)
> at
> org.apache.zookeeper.server.quorum.QuorumPeerMain.runFromConfig(QuorumPeerMain.java:205)
> at
> org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:123)
> at
> org.apache.zookeeper.server.quorum.QuorumPeerMain.main(QuorumPeerMain.java:82)
> Caused by: java.io.IOException: No snapshot found, but there are log entries.
> Something is broken!
> at
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.restore(FileTxnSnapLog.java:240)
> at
> org.apache.zookeeper.server.ZKDatabase.loadDataBase(ZKDatabase.java:240)
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:901)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (ZOOKEEPER-3864) Reject create/renew/close global session in RO mode
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han reassigned ZOOKEEPER-3864: -- Assignee: Jie Huang > Reject create/renew/close global session in RO mode > --- > > Key: ZOOKEEPER-3864 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3864 > Project: ZooKeeper > Issue Type: Bug > Components: server >Reporter: Jie Huang >Assignee: Jie Huang >Priority: Minor > Fix For: 3.6.2 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > These Ops are not read operations. They will modify the state, -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ZOOKEEPER-3864) Reject create/renew/close global session in RO mode
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han resolved ZOOKEEPER-3864. Resolution: Won't Fix solution merged with ZOOKEEPER-3863 > Reject create/renew/close global session in RO mode > --- > > Key: ZOOKEEPER-3864 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3864 > Project: ZooKeeper > Issue Type: Bug > Components: server >Reporter: Jie Huang >Assignee: Jie Huang >Priority: Minor > Fix For: 3.6.2 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > These Ops are not read operations. They will modify the state, -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ZOOKEEPER-4011) Maven build fails on branch-3.6 because of jUnit 5 usage in DIFFSyncConsistencyTest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Han resolved ZOOKEEPER-4011.
Resolution: Fixed
> Maven build fails on branch-3.6 because of jUnit 5 usage in
> DIFFSyncConsistencyTest
> ---
>
> Key: ZOOKEEPER-4011
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4011
> Project: ZooKeeper
> Issue Type: Bug
> Components: build, tests
>Reporter: Huizhi Lu
>Assignee: Huizhi Lu
>Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> h2. Problem
> maven build fails on branch-3.6 because a commit that uses jUnit 5 was back
> ported to branch-3.6.
> Affected version: branch-3.6
> Fix Version: branch-3.6
> h2. How to reproduce
> checkout branch 3.6 and run maven build
> Error message:
> {code:java}
> [INFO] -
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[22,36]
> package org.junit.jupiter.api does not exist
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[22,1]
> static import only from classes and interfaces
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[23,36]
> package org.junit.jupiter.api does not exist
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[23,1]
> static import only from classes and interfaces
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[24,36]
> package org.junit.jupiter.api does not exist
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[24,1]
> static import only from classes and interfaces
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[25,36]
> package org.junit.jupiter.api does not exist
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[25,1]
> static import only from classes and interfaces
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[42,29]
> package org.junit.jupiter.api does not exist
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[43,29]
> package org.junit.jupiter.api does not exist
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[44,29]
> package org.junit.jupiter.api does not exist
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[51,6]
> cannot find symbol
> symbol: class Test
> location: class org.apache.zookeeper.server.quorum.DIFFSyncConsistencyTest
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[52,6]
> cannot find symbol
> symbol: class Timeout
> location: class org.apache.zookeeper.server.quorum.DIFFSyncConsistencyTest
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[220,6]
> cannot find symbol
> symbol: class AfterEach
> location: class org.apache.zookeeper.server.quorum.DIFFSyncConsistencyTest
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[78,13]
> cannot find symbol
> symbol: method assertTrue(boolean,java.lang.String)
> location: class org.apache.zookeeper.server.quorum.DIFFSyncConsistencyTest
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[108,13]
> cannot find symbol
> symbol: method fail(java.lang.String)
> location: class org.apache.zookeeper.server.quorum.DIFFSyncConsistencyTest
> [ERROR]
>
[jira] [Assigned] (ZOOKEEPER-4011) Maven build fails on branch-3.6 because of jUnit 5 usage in DIFFSyncConsistencyTest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Han reassigned ZOOKEEPER-4011:
--
Assignee: Huizhi Lu
> Maven build fails on branch-3.6 because of jUnit 5 usage in
> DIFFSyncConsistencyTest
> ---
>
> Key: ZOOKEEPER-4011
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4011
> Project: ZooKeeper
> Issue Type: Bug
> Components: build, tests
>Reporter: Huizhi Lu
>Assignee: Huizhi Lu
>Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> h2. Problem
> maven build fails on branch-3.6 because a commit that uses jUnit 5 was back
> ported to branch-3.6.
> Affected version: branch-3.6
> Fix Version: branch-3.6
> h2. How to reproduce
> checkout branch 3.6 and run maven build
> Error message:
> {code:java}
> [INFO] -
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[22,36]
> package org.junit.jupiter.api does not exist
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[22,1]
> static import only from classes and interfaces
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[23,36]
> package org.junit.jupiter.api does not exist
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[23,1]
> static import only from classes and interfaces
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[24,36]
> package org.junit.jupiter.api does not exist
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[24,1]
> static import only from classes and interfaces
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[25,36]
> package org.junit.jupiter.api does not exist
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[25,1]
> static import only from classes and interfaces
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[42,29]
> package org.junit.jupiter.api does not exist
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[43,29]
> package org.junit.jupiter.api does not exist
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[44,29]
> package org.junit.jupiter.api does not exist
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[51,6]
> cannot find symbol
> symbol: class Test
> location: class org.apache.zookeeper.server.quorum.DIFFSyncConsistencyTest
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[52,6]
> cannot find symbol
> symbol: class Timeout
> location: class org.apache.zookeeper.server.quorum.DIFFSyncConsistencyTest
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[220,6]
> cannot find symbol
> symbol: class AfterEach
> location: class org.apache.zookeeper.server.quorum.DIFFSyncConsistencyTest
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[78,13]
> cannot find symbol
> symbol: method assertTrue(boolean,java.lang.String)
> location: class org.apache.zookeeper.server.quorum.DIFFSyncConsistencyTest
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[108,13]
> cannot find symbol
> symbol: method fail(java.lang.String)
> location: class org.apache.zookeeper.server.quorum.DIFFSyncConsistencyTest
> [ERROR]
>
[jira] [Updated] (ZOOKEEPER-4011) Maven build fails on branch-3.6 because of jUnit 5 usage in DIFFSyncConsistencyTest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Han updated ZOOKEEPER-4011:
---
Fix Version/s: 3.6.3
> Maven build fails on branch-3.6 because of jUnit 5 usage in
> DIFFSyncConsistencyTest
> ---
>
> Key: ZOOKEEPER-4011
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4011
> Project: ZooKeeper
> Issue Type: Bug
> Components: build, tests
>Reporter: Huizhi Lu
>Assignee: Huizhi Lu
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.3
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> h2. Problem
> maven build fails on branch-3.6 because a commit that uses jUnit 5 was back
> ported to branch-3.6.
> Affected version: branch-3.6
> Fix Version: branch-3.6
> h2. How to reproduce
> checkout branch 3.6 and run maven build
> Error message:
> {code:java}
> [INFO] -
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[22,36]
> package org.junit.jupiter.api does not exist
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[22,1]
> static import only from classes and interfaces
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[23,36]
> package org.junit.jupiter.api does not exist
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[23,1]
> static import only from classes and interfaces
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[24,36]
> package org.junit.jupiter.api does not exist
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[24,1]
> static import only from classes and interfaces
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[25,36]
> package org.junit.jupiter.api does not exist
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[25,1]
> static import only from classes and interfaces
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[42,29]
> package org.junit.jupiter.api does not exist
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[43,29]
> package org.junit.jupiter.api does not exist
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[44,29]
> package org.junit.jupiter.api does not exist
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[51,6]
> cannot find symbol
> symbol: class Test
> location: class org.apache.zookeeper.server.quorum.DIFFSyncConsistencyTest
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[52,6]
> cannot find symbol
> symbol: class Timeout
> location: class org.apache.zookeeper.server.quorum.DIFFSyncConsistencyTest
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[220,6]
> cannot find symbol
> symbol: class AfterEach
> location: class org.apache.zookeeper.server.quorum.DIFFSyncConsistencyTest
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[78,13]
> cannot find symbol
> symbol: method assertTrue(boolean,java.lang.String)
> location: class org.apache.zookeeper.server.quorum.DIFFSyncConsistencyTest
> [ERROR]
> /Users/myname/Projects/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/DIFFSyncConsistencyTest.java:[108,13]
> cannot find symbol
> symbol: method fail(java.lang.String)
> location: class org.apache.zookeeper.server.quorum.DIFFSyncConsistencyTest
> [ERROR]
>
[jira] [Commented] (ZOOKEEPER-4005) Zookeeper will not sync snapshot while get DIFF and cause start failed.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-4005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235185#comment-17235185 ] Michael Han commented on ZOOKEEPER-4005: there is a switch that you can use to disable the start up check during upgrades so a server with empty snapshot file can start - see ZOOKEEPER-3056. > Zookeeper will not sync snapshot while get DIFF and cause start failed. > --- > > Key: ZOOKEEPER-4005 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4005 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.1, 3.5.6 >Reporter: pengWei Dou >Priority: Major > Attachments: zookeeper-server.log > > > The version 3.5.1 of ZK does not detect whether the snapshot file exists or > not. However, the snapshot file detection is added in the subsequent version. > When I tested the upgrade from 3.5.1 to 3.5.6, I found that after the > completion of ZK election, One of the ZK node has an error in the following > phase due to some network reasons, and then it will receive a diff reply. At > this time, both snapshotNeeded and isPreZAB1_0 （ > Learner#syncWithLeader(long newLeaderZxid) ）are assigned to false. So, none > of snapshot file will be generated but a log file, which will cause the > startup failure after the upgrade. > > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ZOOKEEPER-3722) make logs of ResponseCache more readable
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Han resolved ZOOKEEPER-3722.
Fix Version/s: 3.7.0
Resolution: Fixed
Issue resolved by pull request 1253
[https://github.com/apache/zookeeper/pull/1253]
> make logs of ResponseCache more readable
>
>
> Key: ZOOKEEPER-3722
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3722
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
>Reporter: maoling
>Assignee: Nishanth Entoor
>Priority: Minor
> Labels: pull-request-available
> Fix For: 3.7.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The logs look like redundant:
> {code:java}
> 2020-02-12 16:16:09,208 [myid:3] - INFO
> [QuorumPeer[myid=3](plain=[0:0:0:0:0:0:0:0]:2183)(secure=disabled):ResponseCache@45]
> - Response cache size is initialized with value 400.
> 2020-02-12 16:16:09,208 [myid:3] - INFO
> [QuorumPeer[myid=3](plain=[0:0:0:0:0:0:0:0]:2183)(secure=disabled):ResponseCache@45]
> - Response cache size is initialized with value 400.{code}
> What we want is:
> {code:java}
> 2020-02-12 16:16:09,208 [myid:3] - INFO
> [QuorumPeer[myid=3](plain=[0:0:0:0:0:0:0:0]:2183)(secure=disabled):ResponseCache@45]
> - getData Response cache size is initialized with value 400.
> 2020-02-12 16:16:09,208 [myid:3] - INFO
> [QuorumPeer[myid=3](plain=[0:0:0:0:0:0:0:0]:2183)(secure=disabled):ResponseCache@45]
> - getChild Response cache size is initialized with value 400.
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ZOOKEEPER-3981) Flaky test MultipleAddressTest::testGetValidAddressWithNotValid
Michael Han created ZOOKEEPER-3981: -- Summary: Flaky test MultipleAddressTest::testGetValidAddressWithNotValid Key: ZOOKEEPER-3981 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3981 Project: ZooKeeper Issue Type: Task Components: tests Reporter: Michael Han Assignee: Michael Han Problem: Test MultipleAddressTest::testGetValidAddressWithNotValid might fail deterministically when the address it's using, 10.0.0.1, is reachable, as per https://tools.ietf.org/html/rfc5735 10.0.0.1 might be allocatable to private network usage. In fact, the router address of my ISP is assigned this IP, leading to this test always failing for me. Solution: Replace the address with 240.0.0.0, which is reserved for future use and less likely to be reachable. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ZOOKEEPER-3971) Auto close resources with try catch block
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han resolved ZOOKEEPER-3971. Resolution: Fixed Issue resolved by pull request 1507 [https://github.com/apache/zookeeper/pull/1507] > Auto close resources with try catch block > - > > Key: ZOOKEEPER-3971 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3971 > Project: ZooKeeper > Issue Type: Improvement >Affects Versions: 3.7.0 >Reporter: Furkan Kamaci >Priority: Minor > Labels: pull-request-available > Fix For: 3.7.0 > > Time Spent: 1h > Remaining Estimate: 0h > > Resources should be closed automatically within try catch block. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ZOOKEEPER-3561) Generalize target authentication scheme for ZooKeeper authentication enforcement.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han resolved ZOOKEEPER-3561. Fix Version/s: 3.7.0 Resolution: Fixed Issue resolved by pull request 1500 [https://github.com/apache/zookeeper/pull/1500] > Generalize target authentication scheme for ZooKeeper authentication > enforcement. > - > > Key: ZOOKEEPER-3561 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3561 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.6.0 >Reporter: Michael Han >Assignee: Mohammad Arshad >Priority: Major > Labels: pull-request-available > Fix For: 3.7.0 > > Time Spent: 5h 40m > Remaining Estimate: 0h > > ZOOKEEPER-1634 introduced an option to allow user enforce authentication for > ZooKeeper clients, but the enforced authentication scheme in committed > implementation was SASL only. > This JIRA is to generalize the authentication scheme such that the > authentication enforcement on ZooKeeper clients could work with any supported > authentication scheme. -- This message was sent by Atlassian Jira (v8.3.4#803005)
