[frameworks-syntax-highlighting] [Bug 445918] Markdown headings highlighted completely in purple rending text unreadable

2021-12-03 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=445918

Christoph Cullmann  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/fram
   ||eworks/syntax-highlighting/
   ||commit/6188135d40c8f62176c5
   ||762896d130cc0c95bd4e

--- Comment #3 from Christoph Cullmann  ---
Git commit 6188135d40c8f62176c5762896d130cc0c95bd4e by Christoph Cullmann, on
behalf of Jan Paul Batrina.
Committed on 03/12/2021 at 19:53.
Pushed by cullmann into branch 'master'.

markdown.xml: Fix highlighting of headers (include last char)

d277eb4134a2aab4d5981b605faa85b83ae4f552 introduced a hack
to close subheaders by using a header's last char as the
closing character for the subheader regions. This made the
last character always highlighted as an H6 header (which
was not visible with the Breeze themes since all headers
had the same color).

An invisible sentinel region is now used so that the header
regions won't be paired together, preventing erroneous
folding region highlights.
Related: bug 22

M  +54   -54   autotests/folding/test.markdown.fold
M  +53   -53   autotests/html/test.markdown.dark.html
M  +53   -53   autotests/html/test.markdown.html
M  +53   -53   autotests/reference/test.markdown.ref
M  +23   -13   data/syntax/markdown.xml

https://invent.kde.org/frameworks/syntax-highlighting/commit/6188135d40c8f62176c5762896d130cc0c95bd4e

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-syntax-highlighting] [Bug 445918] Markdown headings highlighted completely in purple rending text unreadable

2021-11-28 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=445918

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #2 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/frameworks/syntax-highlighting/-/merge_requests/277

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-syntax-highlighting] [Bug 445918] Markdown headings highlighted completely in purple rending text unreadable

2021-11-24 Thread Jan Paul Batrina
https://bugs.kde.org/show_bug.cgi?id=445918

Jan Paul Batrina  changed:

   What|Removed |Added

 CC||jpmbatrin...@gmail.com
 Ever confirmed|0   |1
Product|kate|frameworks-syntax-highlight
   ||ing
Version|21.08.3 |5.88.0
 Status|REPORTED|CONFIRMED
  Component|kwrite  |theme

--- Comment #1 from Jan Paul Batrina  ---
Confirmed with these steps:

1. open/create .md file
2. Insert the following text:

# heading
## heading

# heading 2

3. Place cursor on "# heading 2"

This is (unintentionally) caused by the folding region highlight introduced by
https://invent.kde.org/frameworks/ktexteditor/-/merge_requests/194. The fix
would be to ensure that the Heading color(s) and the Bracket Highlight Color
are not the same, at least for the default color schemes.

-- 
You are receiving this mail because:
You are watching all bug changes.