[plasmashell] [Bug 361228] little box around filenames is missing with Plasma 5.6

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=361228

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/pla
   ||sma-desktop/10278e79f11677b
   ||d59f7d554eb8e18e580686082
 Status|CONFIRMED   |RESOLVED
   Version Fixed In||5.12.8

--- Comment #11 from Nate Graham  ---
Git commit 10278e79f11677bd59f7d554eb8e18e580686082 by Nate Graham.
Committed on 27/11/2018 at 14:16.
Pushed by ngraham into branch 'Plasma/5.12'.

[Folder View] improve label contrast against challenging backgrounds

Summary:
Currently the shadow behind Folder View items' labels is very subtle. This
leads to poor contrast against wallpapers that are light-colored, visually
busy, or both.

This patch attempts to improve the situation by tightening up the shadow so
that it looks more like a subtle, tasteful outline.
FIXED-IN: 5.12.8

Test Plan:
Folder View items against various wallpapers:
{F6439459, size="full"}

{F6439458, size="full"}

{F6439463, size="full"}

{F6439457, size="full"}

{F6439456, size="full"}

{F6439455, size="full"}

{F6439454, size="full"}

{F6439453, size="full"}

{F6439452, size="full"}

{F6439451, size="full"}

Folder View items against the default wallpaper:
{F6439449, size="full"}

Reviewers: #plasma, hein, #vdg

Reviewed By: #plasma, hein

Subscribers: abetts, svenmauch, matheusm, filipf, emateli, mart, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D16968

M  +5-5containments/desktop/package/contents/ui/FolderItemDelegate.qml

https://commits.kde.org/plasma-desktop/10278e79f11677bd59f7d554eb8e18e580686082

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361228] little box around filenames is missing with Plasma 5.6

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=361228

--- Comment #10 from Nate Graham  ---
Here's a speculative patch: https://phabricator.kde.org/D16968

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361228] little box around filenames is missing with Plasma 5.6

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=361228

--- Comment #9 from Nate Graham  ---
Created attachment 116378
  --> https://bugs.kde.org/attachment.cgi?id=116378=edit
Tweaked shadows

Tweaking the shadows is thankfully pretty trivial (you can do so yourself by
editing
/usr/share/plasma/plasmoids/org.kde.desktopcontainment/contents/ui/FolderItemDelegate.qml,
see line 411).

Here's a tweak (radius 12, spread 0.3) on top of my favorite torture test
background. Seems a bit better; would that suffice?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361228] little box around filenames is missing with Plasma 5.6

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=361228

Nate Graham  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED
 CC||n...@kde.org

--- Comment #8 from Nate Graham  ---
I also would prefer not to go back to the old style for simple aesthetic
reasons, though I acknowledge that it was probably better with busy
backgrounds.

Maybe we should make the shadow a tad bigger?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361228] little box around filenames is missing with Plasma 5.6

[Rog131]

https://bugs.kde.org/show_bug.cgi?id=361228

Rog131  changed:

   What|Removed |Added

 CC||samrog...@hotmail.com

--- Comment #7 from Rog131  ---
Meanwhile the users can add the 'boxes' back. An example:
https://forum.kde.org/viewtopic.php?f=289=131951=407379#p407379

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361228] little box around filenames is missing with Plasma 5.6

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=361228

Eike Hein  changed:

   What|Removed |Added

  Flags||Usability+, VisualDesign+

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361228] little box around filenames is missing with Plasma 5.6

[Patrick Silva]

https://bugs.kde.org/show_bug.cgi?id=361228

Patrick Silva  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |---
 Status|RESOLVED|REPORTED

--- Comment #6 from Patrick Silva  ---
issue reported here is still valid for plasma 5.14.2.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361228] little box around filenames is missing with Plasma 5.6

[Andrew Crouthamel]

https://bugs.kde.org/show_bug.cgi?id=361228

Andrew Crouthamel  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |WORKSFORME

--- Comment #5 from Andrew Crouthamel  ---
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 30 days. The
bug is now closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki
located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361228] little box around filenames is missing with Plasma 5.6

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=361228

Dr. Chapatin  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361228] little box around filenames is missing with Plasma 5.6

[Andrew Crouthamel]

https://bugs.kde.org/show_bug.cgi?id=361228

Andrew Crouthamel  changed:

   What|Removed |Added

   Keywords||triaged

--- Comment #4 from Andrew Crouthamel  ---
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 15 days.
Please provide the requested information as soon as possible and set the bug
status as REPORTED. Due to regular bug tracker maintenance, if the bug is still
in NEEDSINFO status with no change in 30 days, the bug will be closed as
RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki
located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please set the bug
status as REPORTED so that the KDE team knows that the bug is ready to be
confirmed.

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361228] little box around filenames is missing with Plasma 5.6

[FabiB via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361228

--- Comment #3 from FabiB  ---
Created attachment 98184
  --> https://bugs.kde.org/attachment.cgi?id=98184=edit
bad readability on 4 backgrounds

Mostly black+white things. so many "normal" anime/manga backgrounds gives us
hard readability on many screens.

i'm also a little shoked that you even tried this... after all this
translucenty, blurry things on windows and KDE Plamsa 1 that makes it hard to
read text somewhere. after all Plasma distros are choosing a more "solid" dark
plasma theme instead of the translucent white(exept for KaOS, who choose a
solid, white one and some who only ship vanilla packages). it should be clear
that nobody wants this, but a always good readable thing like it finally was
with the last versions of kde plasma
:(

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361228] little box around filenames is missing with Plasma 5.6

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361228

Eike Hein  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|UNCONFIRMED |NEEDSINFO

--- Comment #2 from Eike Hein  ---
Can you show an example of a problematic background? We changed it after
testing with many different kinds of backgrounds, and the shadow version was
universally preferred so far.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 361228] little box around filenames is missing with Plasma 5.6

[FabiB via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361228

--- Comment #1 from FabiB  ---
Created attachment 98169
  --> https://bugs.kde.org/attachment.cgi?id=98169=edit
left 5.5, right 5.6 folderview-desktop

-- 
You are receiving this mail because:
You are watching all bug changes.