[plasmashell] [Bug 372717] on rtl langs the search bar isn't in the right position

2016-12-15 Thread bugzilla_noreply 
https://bugs.kde.org/show_bug.cgi?id=372717

ttv...@gmail.com changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #8 from ttv...@gmail.com ---
Committed
https://phabricator.kde.org/D3553

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 372717] on rtl langs the search bar isn't in the right position

2016-11-30 Thread Christoph Feck 
https://bugs.kde.org/show_bug.cgi?id=372717

Christoph Feck  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #7 from Christoph Feck  ---
Please only close this once the patch is committed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 372717] on rtl langs the search bar isn't in the right position

2016-11-30 Thread bugzilla_noreply 
https://bugs.kde.org/show_bug.cgi?id=372717

ttv...@gmail.com changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #6 from ttv...@gmail.com ---
I found out how to do it myself...

https://phabricator.kde.org/D3553

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 372717] on rtl langs the search bar isn't in the right position

2016-11-30 Thread bugzilla_noreply 
https://bugs.kde.org/show_bug.cgi?id=372717

--- Comment #5 from ttv...@gmail.com ---
I found the problem and I write a patch:

In plasma-desktop git,
applets/kicker/package/contents/ui/MenuRepresentation.qml

Row 62:
LayoutMirroring.enabled: ((plasmoid.location == PlasmaCore.Types.RightEdge)
|| (Qt.application.layoutDirection == Qt.RightToLeft))

Row 353:
the search field:
when: (plasmoid.location == PlasmaCore.Types.RightEdge
|| (plasmoid.location != PlasmaCore.Types.RightEdge &&
mainRow.LayoutMirroring.enabled))

The idea was if the widget is on the right edge the layout will mirrored (the
side bar be on the right - try it and understand)
This cause problem - the search field overlap logout button on RTL lang
Because when the LayoutMirroring.enabled (on LTR when RightEdge and on RTL
langs) all the left and right switched
* (363) "anchors.right: parent.right" become "anchors.left: parent.left"
* (368) "anchors.rightMargin: ..." become "anchors.LeftMargin: ..."

So I think and I write patch with this thought:
Like that LTE with RightEdge is mirrored so RTL with LeftEdge should be (not
mirrored)

The Patch:

Replace rows 62-63 with:
LayoutMirroring.enabled: ((plasmoid.location == PlasmaCore.Types.RightEdge)
|| (Qt.application.layoutDirection == Qt.RightToLeft && plasmoid.location
!= PlasmaCore.Types.LeftEdge))

Replace rows 353-354 with:
when: (plasmoid.location == PlasmaCore.Types.RightEdge &&
Qt.application.layoutDirection == Qt.LeftToRight)
|| (plasmoid.location == PlasmaCore.Types.LeftEdge &&
Qt.application.layoutDirection == Qt.RightToLeft)

I tried the patch on my system and check LTR and RTL with right and left edged
panels

Can you apply the patch?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 372717] on rtl langs the search bar isn't in the right position

2016-11-23 Thread bugzilla_noreply 
https://bugs.kde.org/show_bug.cgi?id=372717

ttv...@gmail.com changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #4 from ttv...@gmail.com ---
I Install KDE Neon on virtual machine
I try:
killall plasmashell
kstart plasmashell --reverse

The search bar still overlap logout button.

and secondly I try to set the system to Hebrew
and the search bar still overlap...

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 372717] on rtl langs the search bar isn't in the right position

2016-11-21 Thread Eike Hein 
https://bugs.kde.org/show_bug.cgi?id=372717

--- Comment #3 from Eike Hein  ---
Hmm it's always possible things bitrot, but I usually do test with rtl ...

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 372717] on rtl langs the search bar isn't in the right position

2016-11-21 Thread bugzilla_noreply 
https://bugs.kde.org/show_bug.cgi?id=372717

--- Comment #2 from ttv...@gmail.com ---
I'll try to check it on virtual machine with the last KDE Neon later

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 372717] on rtl langs the search bar isn't in the right position

2016-11-21 Thread Marco Martin 
https://bugs.kde.org/show_bug.cgi?id=372717

Marco Martin  changed:

   What|Removed |Added

 CC||notm...@gmail.com

--- Comment #1 from Marco Martin  ---
this doesn't seem reproducible with just passing --reverse argument (all is
correctly flipped, the search bar doesn't overlap logout button

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 372717] on rtl langs the search bar isn't in the right position

2016-11-20 Thread bugzilla_noreply 
https://bugs.kde.org/show_bug.cgi?id=372717

ttv...@gmail.com changed:

   What|Removed |Added

 CC|k...@privat.broulik.de   |

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 372717] on rtl langs the search bar isn't in the right position

2016-11-20 Thread bugzilla_noreply 
https://bugs.kde.org/show_bug.cgi?id=372717

ttv...@gmail.com changed:

   What|Removed |Added

 CC||k...@privat.broulik.de

-- 
You are receiving this mail because:
You are watching all bug changes.