[systemsettings] [Bug 426775] Highlight changed settings not working in workspace category

2021-06-10 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=426775

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In|5.21|5.22

--- Comment #16 from Nate Graham  ---
You're welcome! I'm glad you're happy!

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 426775] Highlight changed settings not working in workspace category

2021-06-10 Thread Nishith Khanna
https://bugs.kde.org/show_bug.cgi?id=426775

Nishith Khanna  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

--- Comment #15 from Nishith Khanna  ---
Most of the reported pages now support highlight changed settings in Plasma
5.22. As mentioned in the last comment I will open a bug page for missing
entry. Thanks so much for this feature its a godsend. Congrats on the new
release.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 426775] Highlight changed settings not working in workspace category

2020-10-31 Thread Claudius Ellsel
https://bugs.kde.org/show_bug.cgi?id=426775

--- Comment #14 from Claudius Ellsel  ---
(In reply to Nishith Khanna from comment #12)
> Hey, I tested it and its working fine thanks for your hard work. I also
> found out that its not working in Mouse settings any changed setting there
> is not highlighted. 
> Also it is showing a changed setting in file search even though nothing was
> changed. I am uploading a screenshot regarding same

Thanks for reporting your findings. This bug report has been about specific
missing items, which got added now in between, though.

To make it easier to distinguish between fixed and not fixed things, can you
please open two new bugs for the other new findings? Ideally link them here
when done, then we can close this bug again.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 426775] Highlight changed settings not working in workspace category

2020-10-31 Thread Nishith Khanna
https://bugs.kde.org/show_bug.cgi?id=426775

--- Comment #13 from Nishith Khanna  ---
Created attachment 132903
  --> https://bugs.kde.org/attachment.cgi?id=132903=edit
Here is the screenshot for file search showing incorrect info that something
was changed but it wasn't.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 426775] Highlight changed settings not working in workspace category

2020-10-31 Thread Nishith Khanna
https://bugs.kde.org/show_bug.cgi?id=426775

Nishith Khanna  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REPORTED
 Ever confirmed|1   |0

--- Comment #12 from Nishith Khanna  ---
Hey, I tested it and its working fine thanks for your hard work. I also found
out that its not working in Mouse settings any changed setting there is not
highlighted. 
Also it is showing a changed setting in file search even though nothing was
changed. I am uploading a screenshot regarding same

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 426775] Highlight changed settings not working in workspace category

2020-10-29 Thread Cyril Rossi
https://bugs.kde.org/show_bug.cgi?id=426775

Cyril Rossi  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
   Version Fixed In||5.21

--- Comment #11 from Cyril Rossi  ---
Task Switcher, Window Behavior and Workspace/General Behavior are now
implemented.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 426775] Highlight changed settings not working in workspace category

2020-10-29 Thread Cyril Rossi
https://bugs.kde.org/show_bug.cgi?id=426775

--- Comment #10 from Cyril Rossi  ---
Git commit 23d221319820f27368929d30392289b33fdf535a by Cyril Rossi.
Committed on 28/10/2020 at 09:33.
Pushed by crossi into branch 'master'.

KCM WorkspaceOptions use KCModuleData to highlight the module when settings
have changed

M  +10   -0kcms/workspaceoptions/CMakeLists.txt
M  +5-5kcms/workspaceoptions/workspaceoptions.cpp
M  +2-2kcms/workspaceoptions/workspaceoptions.h

https://invent.kde.org/plasma/plasma-desktop/commit/23d221319820f27368929d30392289b33fdf535a

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 426775] Highlight changed settings not working in workspace category

2020-10-17 Thread Claudius Ellsel
https://bugs.kde.org/show_bug.cgi?id=426775

Claudius Ellsel  changed:

   What|Removed |Added

 CC||claudius.ell...@live.de

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 426775] Highlight changed settings not working in workspace category

2020-10-14 Thread Cyril Rossi
https://bugs.kde.org/show_bug.cgi?id=426775

--- Comment #9 from Cyril Rossi  ---
Git commit d11daecce5514fd4855153e6362b5d495e30ba55 by Cyril Rossi.
Committed on 14/10/2020 at 12:10.
Pushed by crossi into branch 'master'.

KCM KWinTabbox use KCModuleData

Allow to display a dot in the category list when settings has changed
from default.

M  +1-0kcmkwin/kwintabbox/CMakeLists.txt
A  +59   -0kcmkwin/kwintabbox/kwintabboxdata.cpp [License: GPL(v2.0+)]
A  +50   -0kcmkwin/kwintabbox/kwintabboxdata.h [License: GPL(v2.0+)]
M  +42   -46   kcmkwin/kwintabbox/main.cpp
M  +2-7kcmkwin/kwintabbox/main.h

https://invent.kde.org/plasma/kwin/commit/d11daecce5514fd4855153e6362b5d495e30ba55

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 426775] Highlight changed settings not working in workspace category

2020-10-06 Thread Nishith Khanna
https://bugs.kde.org/show_bug.cgi?id=426775

--- Comment #8 from Nishith Khanna  ---
Edit on File Search KCM. I clicked on Default button it didn't change any
setting but it fixed the dot

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 426775] Highlight changed settings not working in workspace category

2020-10-06 Thread Nishith Khanna
https://bugs.kde.org/show_bug.cgi?id=426775

--- Comment #7 from Nishith Khanna  ---
I tried Windows Behavior too it has same outline but no orange dot.

Also I saw one more thing in Search KCM I see orange dot in File Search but I
haven't changed any setting in it. As its just did stock kde neon install. And
If there was some changes its not being highlighted. 

Sorry if I am nitpicking a lot just trying to help as much as I can

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 426775] Highlight changed settings not working in workspace category

2020-10-06 Thread Nishith Khanna
https://bugs.kde.org/show_bug.cgi?id=426775

--- Comment #6 from Nishith Khanna  ---
Hey Cyril, So I was  excited to try this therefore installed neon developer
edition in VM. In task switcher I see orange outline in drop down box but I
don't see orange dot in sidebar and in submenu sidebar. Sorry if you are
already aware about this. I don't know if I could comment on your merge request
as that is not the place to report bugs therefore I am doing it here. If you
need any more info I will be happy to help.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 426775] Highlight changed settings not working in workspace category

2020-09-25 Thread Cyril Rossi
https://bugs.kde.org/show_bug.cgi?id=426775

Cyril Rossi  changed:

   What|Removed |Added

 CC||cyril.ro...@enioka.com

--- Comment #5 from Cyril Rossi  ---
Hi, thank you for your detailed report.

Hopefully, Task switcher and Window behavior will quickly follow. see
https://invent.kde.org/plasma/kwin/-/merge_requests/177

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 426775] Highlight changed settings not working in workspace category

2020-09-23 Thread Nishith Khanna
https://bugs.kde.org/show_bug.cgi?id=426775

--- Comment #4 from Nishith Khanna  ---
Edit in first post

In workspace behavior > General Behavior I changed click behavior it is single
click by default but I changed it to double click. When clicking on highlight
changed settings in menu it shows that the settings is changed but in sidebar
orange dot is NOT visible.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 426775] Highlight changed settings not working in workspace category

2020-09-23 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=426775

Nate Graham  changed:

   What|Removed |Added

  Component|general |kcm_workspace
 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED
 CC||benjamin.p...@enioka.com,
   ||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 426775] Highlight changed settings not working in workspace category

2020-09-20 Thread Nishith Khanna
https://bugs.kde.org/show_bug.cgi?id=426775

--- Comment #3 from Nishith Khanna  ---
As it can be seen in the screenshot that Defaults option is not greyed out so
that means I am not using default settings on these particular pages. Hope this
helps.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 426775] Highlight changed settings not working in workspace category

2020-09-20 Thread Nishith Khanna
https://bugs.kde.org/show_bug.cgi?id=426775

--- Comment #2 from Nishith Khanna  ---
Created attachment 131810
  --> https://bugs.kde.org/attachment.cgi?id=131810=edit
Screenshot showing highlight changed setting not working in Task switcher

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 426775] Highlight changed settings not working in workspace category

2020-09-20 Thread Nishith Khanna
https://bugs.kde.org/show_bug.cgi?id=426775

--- Comment #1 from Nishith Khanna  ---
Created attachment 131809
  --> https://bugs.kde.org/attachment.cgi?id=131809=edit
Screenshot showing highlight changed setting not working in Window behavior

-- 
You are receiving this mail because:
You are watching all bug changes.