Re: Review Request 115185: Integrate kf5dot

[Aurélien Gâteau]

On Jan. 21, 2014, 6:16 p.m., Aurélien Gâteau wrote:
> > Another option for merging histories is 
> > http://thread.gmane.org/gmane.comp.version-control.git/5126/ (with some 
> > modifications; in particular, git-*-cache is now git-*-index).  But that 
> > depends on how much you care about preserving commit shasums.
> > 
> > In general, though, I approve :-)

In this case I don't care about the checksums, I just want to preserve the 
commit diffs and messages.


- Aurélien


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115185/#review47903
---


On Jan. 21, 2014, 5:58 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115185/
> ---
> 
> (Updated Jan. 21, 2014, 5:58 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kapidox
> 
> 
> Description
> ---
> 
> This big patch includes all of the kf5dot repository inside kapidox. Python 
> code is in src/kapidox/kf5dot, scripts are in src/.
> 
> I replayed all the commits from the kf5dot repository within the kapidox 
> repository using `git am` to avoid loosing history. As such, I plan to do the 
> merge using --no-ff.
> 
> 
> Diffs
> -
> 
>   src/kapidox/kf5dot/frameworkdb.py PRE-CREATION 
>   src/kf5dot-generate PRE-CREATION 
>   src/kf5dot-generate-all PRE-CREATION 
>   src/kf5dot-prepare PRE-CREATION 
>   README.md 660e9c3 
>   src/kapidox/kf5dot/framework.py PRE-CREATION 
>   setup.py 025afdb 
>   src/kapidox/kf5dot/.gitignore PRE-CREATION 
>   src/kapidox/kf5dot/block.py PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115185/diff/
> 
> 
> Testing
> ---
> 
> Generated all diagrams. Works as expected.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115185: Integrate kf5dot

[Aurélien Gâteau]

> On Jan. 21, 2014, 6:16 p.m., Alex Merry wrote:
> > - files should have licenses and encoding marks
> > - "kf5dot" is not very descriptive as a name.  I would call the module 
> > "dependencies" or "depdiags" or something like that, and the scripts 
> > something similar but with a k or kf5 prefix
> > - it would be nice if kgenframeworksapidox could do all the magic itself, 
> > when suitable option(s) are passed (although that can be something to 
> > implement later)

> - files should have licenses and encoding marks

Will fix.

> - "kf5dot" is not very descriptive as a name.  I would call the module 
> "dependencies" or "depdiags" or something like that, and the scripts 
> something similar but with a k or kf5 prefix

I am not happy with the name either, but I think this can be fixed in a 
different commit.

> - it would be nice if kgenframeworksapidox could do all the magic itself, 
> when suitable option(s) are passed (although that can be something to 
> implement later)

Agreed.


- Aurélien


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115185/#review47903
---


On Jan. 21, 2014, 5:58 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115185/
> ---
> 
> (Updated Jan. 21, 2014, 5:58 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kapidox
> 
> 
> Description
> ---
> 
> This big patch includes all of the kf5dot repository inside kapidox. Python 
> code is in src/kapidox/kf5dot, scripts are in src/.
> 
> I replayed all the commits from the kf5dot repository within the kapidox 
> repository using `git am` to avoid loosing history. As such, I plan to do the 
> merge using --no-ff.
> 
> 
> Diffs
> -
> 
>   src/kapidox/kf5dot/frameworkdb.py PRE-CREATION 
>   src/kf5dot-generate PRE-CREATION 
>   src/kf5dot-generate-all PRE-CREATION 
>   src/kf5dot-prepare PRE-CREATION 
>   README.md 660e9c3 
>   src/kapidox/kf5dot/framework.py PRE-CREATION 
>   setup.py 025afdb 
>   src/kapidox/kf5dot/.gitignore PRE-CREATION 
>   src/kapidox/kf5dot/block.py PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115185/diff/
> 
> 
> Testing
> ---
> 
> Generated all diagrams. Works as expected.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115185: Integrate kf5dot

[Aurélien Gâteau]

> On Jan. 21, 2014, 6:16 p.m., Alex Merry wrote:
> > src/kapidox/kf5dot/.gitignore, line 1
> > 
> >
> > Unnecessary; kapidox has a top-level .gitignore that already does this

Oups, left-over from the import.


- Aurélien


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115185/#review47903
---


On Jan. 21, 2014, 5:58 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115185/
> ---
> 
> (Updated Jan. 21, 2014, 5:58 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kapidox
> 
> 
> Description
> ---
> 
> This big patch includes all of the kf5dot repository inside kapidox. Python 
> code is in src/kapidox/kf5dot, scripts are in src/.
> 
> I replayed all the commits from the kf5dot repository within the kapidox 
> repository using `git am` to avoid loosing history. As such, I plan to do the 
> merge using --no-ff.
> 
> 
> Diffs
> -
> 
>   src/kapidox/kf5dot/frameworkdb.py PRE-CREATION 
>   src/kf5dot-generate PRE-CREATION 
>   src/kf5dot-generate-all PRE-CREATION 
>   src/kf5dot-prepare PRE-CREATION 
>   README.md 660e9c3 
>   src/kapidox/kf5dot/framework.py PRE-CREATION 
>   setup.py 025afdb 
>   src/kapidox/kf5dot/.gitignore PRE-CREATION 
>   src/kapidox/kf5dot/block.py PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115185/diff/
> 
> 
> Testing
> ---
> 
> Generated all diagrams. Works as expected.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

[David Narváez]

> On Jan. 17, 2014, 6:51 p.m., Alex Merry wrote:
> > KF5DocToolsMacros.cmake, lines 166-172
> > 
> >
> > These should *not* be renamed, as they are compatibility macros.  
> > However, they should probably be moved to kde4support.
> 
> Aleix Pol Gonzalez wrote:
> I wouldn't rename it indeed.
> 
> Moving it to KDE4Support can be good indeed, although it kind of defeats 
> the purpose, as you'll need to actually depend on KDE4Support to get the 
> warning.
> 
> David Narváez wrote:
> Luigi, your call.
> 
> Alex Merry wrote:
> Well, most projects will start off depending on KDE4Support anyway, and 
> if you don't use it I think you should just get an error about the macro not 
> being found.
> 
> Luigi Toscano wrote:
> My thoughts:
> - is the dependency on KDE4Support the first thing a ported application 
> should do? If yes, then the macros can be kept and moved; but please read on;
> - KDE4_CREATE_HTML_HANDBOOK can be completely removed. It has been 
> deprecated on Wed Aug 15 03:55:48 2007 +, 
> 82f7b6ba0f8be7d314ac780b9a873e98b6be39b2, and it is not used (apart from the 
> definition in kdelibs and kf5/kdoctools).
> - KDE4_CREATE_HANDBOOK should not be renamed, and it can be moved to 
> KDE4Support (I see that it was already renamed as KDOCTOOLS_CREATE_HANDBOOK 
> in the frameworks-based code)
> - I see KDE4_SERIALIZE_TOOL has been renamed as well; but it is defined 
> in KDE4Support:
> 
> http://lxr.kde.org/source/frameworks/kde4support/cmake/modules/FindKDE4Internal.cmake#455
> I'm not sure how to deal with this: probably it would be better to define 
> it here and rename it as KDOCTOOLS_blabla.
> 
> Does it make sense?
> 
> Alex Merry wrote:
> In general, yes, the first thing a ported application will do is replace 
> the lines to search for kdelibs4 with lines to find KDE4Support (and other 
> frameworks).
> 
> I agree that KDE4_CREATE_HTML_HANDBOOK should be removed (along with any 
> other macro that didn't actually do anything in kdelibs4).  If 
> KDE4_CREATE_HANDBOOK was a useful macro in kdelibs4, it should move to 
> kde4support (and either be defined as it is here, or forward to 
> KDOCTOOLS_CREATE_HANDBOOK).
> 
> I have no idea how the KDE4_SERIALIZE_TOOL thing is supposed to work, so 
> I can't comment on that.
> 
> Luigi Toscano wrote:
> KDE4_SERIALIZE_TOOL is used only here (kdoctools); I suggest to rename it 
> as KDOCTOOLS_SERIALIZE_TOOL and add its definition (see 
> http://lxr.kde.org/source/kde/kdelibs/cmake/modules/FindKDE4Internal.cmake#721).
> 
> KDE4_CREATE_HANDBOOK is used everytime there is documentation in 
> kdelibs4-based applications, so yes, we need to keep it somehow for migration 
> purposes :)
> 
> David Narváez wrote:
> I'll split this RR into several others covering those changes.

Doesn't that serialization tool sound more like ECM? It could be useful if you 
need to serialize any kind of build.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115077/#review47592
---


On Jan. 18, 2014, 1:16 p.m., David Narváez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115077/
> ---
> 
> (Updated Jan. 18, 2014, 1:16 p.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Part of the overall task of removing mentions of KDE4 from the code.
> 
> 
> Diffs
> -
> 
>   KF5DocToolsMacros.cmake 191a2c5 
> 
> Diff: https://git.reviewboard.kde.org/r/115077/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Narváez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115190: Add unit test for KWindowInfo on X11

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115190/
---

(Updated Jan. 22, 2014, 8:14 a.m.)


Review request for KDE Frameworks and Ben Cooksley.


Changes
---

installed openbox and added some fixes:
* KWin specific behavior in some tests checked for that we are running KWin
* added some sleeps for the tests which fail if they are executed directly 
after each other


Repository: kwindowsystem


Description
---

Add unit test for KWindowInfo on X11

Unit test for most methods provided by KWindowInfo. The general pattern
is to create a window, show it, test the property, change it and
verify that the change worked. This is a little bit tricky as the test
needs to interact with large parts of the window manager. In case a
property is updated by the window manager we need to send the client
message, wait till the window manager has reacted on it and updated
the property and then wait for the property update. This is mostly done
by waiting for the signal KWindowSystem::windowChanged. Unfortunately
that reports globally and not just for the window we are interested in.
So we have to filter out till we got the correct one. If there is at
the same time further interaction with the windowing system tests can
fail, but a re-run normally fixes it.

The unit test is so far written against KWin. It's possible that it
needs adjustments for succeeding on build.kde.org. Given that
KWindowInfo::actionSupported is not tested as that is clearly to
specific to the used window manager.

---

@Ben: is it possible that you try the patch on build.kde.org while it's under 
review, so that I can fix any possible failures.


Diffs (updated)
-

  autotests/CMakeLists.txt 58803aec9c807f68ff2bac227d0d9cf0305fa1f6 
  autotests/kwindowinfox11test.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/115190/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK

[David Narváez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115213/
---

Review request for KDE Frameworks and Luigi Toscano.


Repository: kdoctools


Description
---

As discussed in Review Request 115077


Diffs
-

  KF5DocToolsMacros.cmake 191a2c5 

Diff: https://git.reviewboard.kde.org/r/115213/diff/


Testing
---

Searched all CMakeLists.txt files of frameworks for that macro, found nothing.


Thanks,

David Narváez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115190: Add unit test for KWindowInfo on X11

[Martin Gräßlin]

> On Jan. 21, 2014, 11:42 p.m., Ben Cooksley wrote:
> > I'm afraid the test fails Martin. Guess KWin and Openbox behave differently 
> > in some areas.
> > 
> > 5/9 Test #5: kwindowsystem-kwindowinfox11test ..***Failed9.96 sec
> > * Start testing of KWindowInfoX11Test *
> > Config: Using QtTest library 5.2.2, Qt 5.2.2
> > PASS   : KWindowInfoX11Test::initTestCase()
> > FAIL!  : KWindowInfoX11Test::testState(max) Compared values are not the same
> >Actual   (info.state())  
> >   : 0
> >Expected (static_cast(firstRun ? NET::DemandsAttention : 
> > 0)): 2048
> >Loc: 
> > [/srv/jenkins/workspace/kwindowsystem_master_qt5/autotests/kwindowinfox11test.cpp(129)]
> > PASS   : KWindowInfoX11Test::testState(maxHoriz)
> > FAIL!  : KWindowInfoX11Test::testState(shaded) 'waitForWindow(spy, 
> > window->winId(), NET::WMState)' returned FALSE. ()
> >Loc: 
> > [/srv/jenkins/workspace/kwindowsystem_master_qt5/autotests/kwindowinfox11test.cpp(159)]
> > FAIL!  : KWindowInfoX11Test::testState(skipTaskbar) 'waitForWindow(spy, 
> > window->winId(), NET::WMState)' returned FALSE. ()
> >Loc: 
> > [/srv/jenkins/workspace/kwindowsystem_master_qt5/autotests/kwindowinfox11test.cpp(159)]
> > FAIL!  : KWindowInfoX11Test::testState(skipPager) 'waitForWindow(spy, 
> > window->winId(), NET::WMState)' returned FALSE. ()
> >Loc: 
> > [/srv/jenkins/workspace/kwindowsystem_master_qt5/autotests/kwindowinfox11test.cpp(159)]
> > FAIL!  : KWindowInfoX11Test::testState(keep above) 'waitForWindow(spy, 
> > window->winId(), NET::WMState)' returned FALSE. ()
> >Loc: 
> > [/srv/jenkins/workspace/kwindowsystem_master_qt5/autotests/kwindowinfox11test.cpp(159)]
> > FAIL!  : KWindowInfoX11Test::testState(keep below) 'waitForWindow(spy, 
> > window->winId(), NET::WMState)' returned FALSE. ()
> >Loc: 
> > [/srv/jenkins/workspace/kwindowsystem_master_qt5/autotests/kwindowinfox11test.cpp(159)]
> > FAIL!  : KWindowInfoX11Test::testState(fullscreen) 'waitForWindow(spy, 
> > window->winId(), NET::WMState)' returned FALSE. ()
> >Loc: 
> > [/srv/jenkins/workspace/kwindowsystem_master_qt5/autotests/kwindowinfox11test.cpp(159)]
> > PASS   : KWindowInfoX11Test::testMinimized()
> > PASS   : KWindowInfoX11Test::testMappingState()
> > PASS   : KWindowInfoX11Test::testWindowType(desktop)
> > PASS   : KWindowInfoX11Test::testWindowType(dock)
> > PASS   : KWindowInfoX11Test::testWindowType(toolbar)
> > PASS   : KWindowInfoX11Test::testWindowType(menu)
> > PASS   : KWindowInfoX11Test::testWindowType(dialog)
> > PASS   : KWindowInfoX11Test::testWindowType(override)
> > PASS   : KWindowInfoX11Test::testWindowType(override as normal)
> > PASS   : KWindowInfoX11Test::testWindowType(topmenu)
> > PASS   : KWindowInfoX11Test::testWindowType(topmenu as dock)
> > PASS   : KWindowInfoX11Test::testWindowType(utility)
> > PASS   : KWindowInfoX11Test::testWindowType(utility as dialog)
> > PASS   : KWindowInfoX11Test::testWindowType(splash)
> > PASS   : KWindowInfoX11Test::testWindowType(splash as dock)
> > PASS   : KWindowInfoX11Test::testWindowType(dropdownmenu)
> > PASS   : KWindowInfoX11Test::testWindowType(popupmenu)
> > PASS   : KWindowInfoX11Test::testWindowType(popupmenu as menu)
> > PASS   : KWindowInfoX11Test::testWindowType(tooltip)
> > PASS   : KWindowInfoX11Test::testWindowType(notification)
> > PASS   : KWindowInfoX11Test::testWindowType(ComboBox)
> > PASS   : KWindowInfoX11Test::testWindowType(DNDIcon)
> > PASS   : KWindowInfoX11Test::testWindowType(desktop-unknown)
> > PASS   : KWindowInfoX11Test::testWindowType(dock-unknown)
> > PASS   : KWindowInfoX11Test::testWindowType(toolbar-unknown)
> > PASS   : KWindowInfoX11Test::testWindowType(menu-unknown)
> > PASS   : KWindowInfoX11Test::testWindowType(dialog-unknown)
> > PASS   : KWindowInfoX11Test::testWindowType(override-unknown)
> > PASS   : KWindowInfoX11Test::testWindowType(topmenu-unknown)
> > PASS   : KWindowInfoX11Test::testWindowType(utility-unknown)
> > PASS   : KWindowInfoX11Test::testWindowType(splash-unknown)
> > PASS   : KWindowInfoX11Test::testWindowType(dropdownmenu-unknown)
> > PASS   : KWindowInfoX11Test::testWindowType(popupmenu-unknown)
> > PASS   : KWindowInfoX11Test::testWindowType(tooltip-unknown)
> > PASS   : KWindowInfoX11Test::testWindowType(notification-unknown)
> > PASS   : KWindowInfoX11Test::testWindowType(ComboBox-unknown)
> > PASS   : KWindowInfoX11Test::testWindowType(DNDIcon-unknown)
> > FAIL!  : KWindowInfoX11Test::testDesktop() 'waitForWindow(spy, 
> > window->winId(), NET::WMDesktop)' returned FALSE. ()
> >Loc: 
> > [/srv/jenkins/workspace/kwindowsystem_master_qt5/autotests/kwindowinfox11test.cpp(304)]
> > PASS   : KWindowInfoX11Test::testWindowClass()
> > PASS   : KWindowInfoX11Test::testWindowRole()
> > PASS   : KWindowInfoX11Test::testClientMachine()
> > FAIL!  : KWindowInfoX11Test::testName() Compared values are not the same
> >Actual   (info3.visibleName()) : kwind

Re: Split classes into separate files?

[Kevin Ottens]

Hello,

On Wednesday 22 January 2014 00:30:19 David Gil Oliva wrote:
> I'm revising KCompletion and I have found that in kcompletion.h you can see
> the declaration of KCompletionBase (which is defined in a separate file)
> and KCompletionMatches (which is defined in kcompletion.cpp).
> 
> I think I have seen that in other frameworks classes are being split into
> separate files. Should I also do it with KCompletionBase and
> KCompletionMatches?

You can, I personally consider that good practice. But it's not mandatory, so 
up to you.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Authors, maintainers and licenses in apidox

[Kevin Ottens]

On Tuesday 21 January 2014 17:18:36 Alex Merry wrote:
> Traditionally, the front pages of our apidox has included a list of
> authors, the maintainer(s) and the license.  This is obviously
> duplicating/summarising information stored elsewhere, and is easy to let
> get out of date.

Yes... definitely easy to get wrong. We should have only one place for that.
 
> Do we still want this information?  It would probably mean adding it to
> the README.md files.

Are we ditching the LICENSE and AUTHORS files which used to contain this type 
of information? I'm not sure we want everything in README.md.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

[Alexander Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115210/
---

(Updated Jan. 22, 2014, 2:56 a.m.)


Review request for Build System, Extra Cmake Modules, KDE Frameworks, and 
kdewin.


Repository: extra-cmake-modules


Description
---

Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

Otherwise QStandardPaths will always fail with e.g. GenericDataLocation


Diffs
-

  kde-modules/KDEInstallDirs.cmake 46e15c17d488d56f146aba0c2d420f74a22b9152 

Diff: https://git.reviewboard.kde.org/r/115210/diff/


Testing
---


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115212: Fix windows build + 1 compiler warning

[Alexander Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115212/
---

Review request for KDE Frameworks.


Repository: kxmlgui


Description
---

4 separate  commits: 


1. Fix windows build with QT_NO_CAST_FROM_ASCII


2. m_collator already returs bool, remove check for < 0


3. Don't use foreach for this loop, it somehow breaks MSVC


4. Don't use uname() and getpwuid() directly

Added new functions that also do the right thing on Windows


Diffs
-

  src/systeminformation_p.h PRE-CREATION 
  src/kbugreport.cpp 56f088106becbccca5e9731abc04118a19e36ba9 
  src/CMakeLists.txt 4516a9ee3da774788c76f30f15181fa0049a9d86 
  src/kgesture.cpp 49c927803b2e16806985d758103d3e359aa58dd4 
  src/kkeysequencewidget.cpp cc9016b776c16984b83a36a2742526ede624bf5e 
  src/ksendbugmail/CMakeLists.txt 12b4926ecddeb023315f6074ab57cfe6cdee65ff 
  src/ksendbugmail/main.cpp 8f85f315f0746bb774175114b1e284e899957fd3 
  src/ksendbugmail/smtp.cpp 90b6b98467b0c220cfef18bc35cf3c07df9a8cf3 
  src/kshortcutseditoritem.cpp 086f833fc505f69a3b0dbe6fceffdb94ecd60330 

Diff: https://git.reviewboard.kde.org/r/115212/diff/


Testing
---

now it compiles on windows and Linux is still fine


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115211: Mark target created by ecm_add_test as non GUI by default

[Alexander Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115211/
---

Review request for Build System, Extra Cmake Modules and KDE Frameworks.


Repository: extra-cmake-modules


Description
---

Mark target created by ecm_add_test as non GUI by default

This behaviour can be overriden by passing the GUI flag to the command


Diffs
-

  modules/ECMAddTests.cmake ff97d764d58c781d6c37dd08c8cb175ce500962e 

Diff: https://git.reviewboard.kde.org/r/115211/diff/


Testing
---

Oketeta unit tests wouldn't build on windows before this commit, now they do


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115209: Fix KDoctools build on Windows

[Alexander Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115209/
---

Review request for Documentation, KDE Frameworks and Luigi Toscano.


Repository: kdoctools


Description
---

Two separate commits: 

---

Print a message when a file is not found

This way meinproc no longer fails silently

--

Allow compiling on Windows with MSVC


Diffs
-

  CMakeLists.txt 56877a3f39b39a6d919c6b18a9c4ab1c0b5a9106 
  src/CMakeLists.txt 752604190a4b527d757d4b819dc6d85085a96e4b 
  src/meinproc.cpp f34084581205ad4f63a84823cd1a582b2f37ed69 
  src/meinproc_common.cpp 16234f70e45a703859fce42dcdb2ac1c2fdadade 
  src/xslt.cpp 79578ed8fb6cc3faccf63b8d86e29db9948b33e7 

Diff: https://git.reviewboard.kde.org/r/115209/diff/


Testing
---

Works on windows once https://git.reviewboard.kde.org/r/115210/ is also applied


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

[Alexander Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115210/
---

Review request for Build System, Extra Cmake Modules and KDE Frameworks.


Repository: extra-cmake-modules


Description
---

Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

Otherwise QStandardPaths will always fail with e.g. GenericDataLocation


Diffs
-

  kde-modules/KDEInstallDirs.cmake 46e15c17d488d56f146aba0c2d420f74a22b9152 

Diff: https://git.reviewboard.kde.org/r/115210/diff/


Testing
---


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs

[David Gil Oliva]

> On Jan. 21, 2014, 11:43 p.m., Alex Merry wrote:
> > Thanks for working on apidox!  Sorry for the large number of comments...

Wow! You were ultra-fast, just 31 minutes for all this! :-) I will see one by 
one tomorrow (just wanted to comment about something I clearly don't agree).


> On Jan. 21, 2014, 11:43 p.m., Alex Merry wrote:
> > src/kcompletion.h, line 103
> > 
> >
> > You remove the hyphen from "auto-completion" ealier, but not here.

Yes, I drop the hyphen from "auto-completion" when it works as a noun. But here 
(and in many other places) is working as a compound adjective. Some sources 
about compound adjectives and hyphens:

http://writersrelief.com/blog/2008/03/hyphen-rules-dont-let-misused-hyphens-muddle-your-adjectives-or-your-writing/
http://www.grammarbook.com/punctuation/hyphens.asp

Nevertheless, I may be wrong. If so, please tell me.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115206/#review47958
---


On Jan. 21, 2014, 11:12 p.m., David Gil Oliva wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115206/
> ---
> 
> (Updated Jan. 21, 2014, 11:12 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> ---
> 
> Correct spelling, grammar and style of kcompletion.h docs
> 
> 
> Diffs
> -
> 
>   src/kcompletion.h 46b63a4 
> 
> Diff: https://git.reviewboard.kde.org/r/115206/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115201: Use qplatformdefs.h

[Alexander Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115201/
---

(Updated Jan. 22, 2014, 12:15 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kbookmarks


Description
---

Use qplatformdefs.h


Add a dummy qHash function so that MSVC doesn't fail


Diffs
-

  src/kbookmark.h 0ce3a74b922da0ceaa214f7556d946ea1e62215a 
  src/kbookmarkimporter.cpp 9ce564f88f0a4d4bafe4a54a899ae90632d31f65 
  src/kbookmarkimporter_ie.cpp 457d22fc388def15104b9ef86958a44980a61935 
  src/kbookmarkimporter_opera.cpp d44548d8bf8039a12ceeb387985352f605cf27a1 

Diff: https://git.reviewboard.kde.org/r/115201/diff/


Testing
---


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115201: Use qplatformdefs.h

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115201/#review47967
---


This review has been submitted with commit 
7076a02f50b48904a0cac67348074d23b35a754f by Alex Richardson to branch master.

- Commit Hook


On Jan. 21, 2014, 10:22 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115201/
> ---
> 
> (Updated Jan. 21, 2014, 10:22 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kbookmarks
> 
> 
> Description
> ---
> 
> Use qplatformdefs.h
> 
> 
> Add a dummy qHash function so that MSVC doesn't fail
> 
> 
> Diffs
> -
> 
>   src/kbookmark.h 0ce3a74b922da0ceaa214f7556d946ea1e62215a 
>   src/kbookmarkimporter.cpp 9ce564f88f0a4d4bafe4a54a899ae90632d31f65 
>   src/kbookmarkimporter_ie.cpp 457d22fc388def15104b9ef86958a44980a61935 
>   src/kbookmarkimporter_opera.cpp d44548d8bf8039a12ceeb387985352f605cf27a1 
> 
> Diff: https://git.reviewboard.kde.org/r/115201/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115201: Use qplatformdefs.h

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115201/#review47968
---


This review has been submitted with commit 
27aa98c3897af2876357b8ad19ea7abc2cdb7d99 by Alex Richardson to branch master.

- Commit Hook


On Jan. 21, 2014, 10:22 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115201/
> ---
> 
> (Updated Jan. 21, 2014, 10:22 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kbookmarks
> 
> 
> Description
> ---
> 
> Use qplatformdefs.h
> 
> 
> Add a dummy qHash function so that MSVC doesn't fail
> 
> 
> Diffs
> -
> 
>   src/kbookmark.h 0ce3a74b922da0ceaa214f7556d946ea1e62215a 
>   src/kbookmarkimporter.cpp 9ce564f88f0a4d4bafe4a54a899ae90632d31f65 
>   src/kbookmarkimporter_ie.cpp 457d22fc388def15104b9ef86958a44980a61935 
>   src/kbookmarkimporter_opera.cpp d44548d8bf8039a12ceeb387985352f605cf27a1 
> 
> Diff: https://git.reviewboard.kde.org/r/115201/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115199: Fix detection of shared-mime-info on Windows

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115199/#review47966
---


This review has been submitted with commit 
0971e8cc8daffc1101ace9a37f8e777499b9843b by Alex Richardson to branch master.

- Commit Hook


On Jan. 21, 2014, 11:30 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115199/
> ---
> 
> (Updated Jan. 21, 2014, 11:30 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Fix detection of shared-mime-info on Windows
> 
> For some reason exec_program would fail, it works with execute_process
> 
> 
> Diffs
> -
> 
>   cmake/FindSharedMimeInfo.cmake 4427c733b3c4e6fb969ee03e4405fb2a12a26232 
> 
> Diff: https://git.reviewboard.kde.org/r/115199/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115199: Fix detection of shared-mime-info on Windows

[Alexander Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115199/
---

(Updated Jan. 22, 2014, 12:12 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kcoreaddons


Description
---

Fix detection of shared-mime-info on Windows

For some reason exec_program would fail, it works with execute_process


Diffs
-

  cmake/FindSharedMimeInfo.cmake 4427c733b3c4e6fb969ee03e4405fb2a12a26232 

Diff: https://git.reviewboard.kde.org/r/115199/diff/


Testing
---


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115202: Allow building KConfigWidgets on Windows

[Alexander Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115202/
---

(Updated Jan. 22, 2014, 1:06 a.m.)


Review request for KDE Frameworks.


Changes
---

don't make kdoctools optional


Repository: kconfigwidgets


Description (updated)
---

Fix compilation on MSVC


Diffs (updated)
-

  src/kcolorschememanager.cpp 2e44f88d4b613a263047899b102da53541139171 

Diff: https://git.reviewboard.kde.org/r/115202/diff/


Testing
---


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/#review47964
---


Looks like a good idea to me.

- Alex Merry


On Jan. 21, 2014, 11:36 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115207/
> ---
> 
> (Updated Jan. 21, 2014, 11:36 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Let the KAboutData set information to QApplication. This way we don't have to 
> duplicate information by passing it to the KAboutData _and_ the QApplication.
> 
> 
> Diffs
> -
> 
>   src/lib/kaboutdata.h c9e 
>   src/lib/kaboutdata.cpp f24006b 
> 
> Diff: https://git.reviewboard.kde.org/r/115207/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115199: Fix detection of shared-mime-info on Windows

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115199/#review47963
---

Ship it!


Works for me now.

- Alex Merry


On Jan. 21, 2014, 11:30 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115199/
> ---
> 
> (Updated Jan. 21, 2014, 11:30 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Fix detection of shared-mime-info on Windows
> 
> For some reason exec_program would fail, it works with execute_process
> 
> 
> Diffs
> -
> 
>   cmake/FindSharedMimeInfo.cmake 4427c733b3c4e6fb969ee03e4405fb2a12a26232 
> 
> Diff: https://git.reviewboard.kde.org/r/115199/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

[Christoph Cullmann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/#review47962
---


Think that will make porting easier and avoids boiler plate code

- Christoph Cullmann


On Jan. 21, 2014, 11:36 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115207/
> ---
> 
> (Updated Jan. 21, 2014, 11:36 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Let the KAboutData set information to QApplication. This way we don't have to 
> duplicate information by passing it to the KAboutData _and_ the QApplication.
> 
> 
> Diffs
> -
> 
>   src/lib/kaboutdata.h c9e 
>   src/lib/kaboutdata.cpp f24006b 
> 
> Diff: https://git.reviewboard.kde.org/r/115207/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/
---

Review request for KDE Frameworks.


Repository: kcoreaddons


Description
---

Let the KAboutData set information to QApplication. This way we don't have to 
duplicate information by passing it to the KAboutData _and_ the QApplication.


Diffs
-

  src/lib/kaboutdata.h c9e 
  src/lib/kaboutdata.cpp f24006b 

Diff: https://git.reviewboard.kde.org/r/115207/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115132: Append 5 to preparetips script & manpage

[Hrvoje Senjan]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115132/
---

(Updated Jan. 21, 2014, 11:36 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kconfigwidgets


Description
---

Patch to make kconfigwidgets not collide with kdelibs(4) when installed to same 
prefix.
I can cleanup whitespaces if needed (they where present in original script). 
Also, depending on the outcome of r115065, can change kdeoptions man reference.


Diffs
-

  docs/preparetips/CMakeLists.txt 4685089 
  docs/preparetips/man-preparetips.1.docbook baf4b6b 
  docs/preparetips/man-preparetips5.1.docbook PRE-CREATION 
  src/CMakeLists.txt baf5295 
  src/ktipdialog.cpp 1b74f55 
  src/preparetips a89d9f1 
  src/preparetips5 PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/115132/diff/


Testing
---

Builds :)


Thanks,

Hrvoje Senjan

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115132: Append 5 to preparetips script & manpage

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115132/#review47961
---


This review has been submitted with commit 
1ea6262185916ae453db15d325bdad0e27b1e0b3 by Hrvoje Senjan to branch master.

- Commit Hook


On Jan. 19, 2014, 10:34 p.m., Hrvoje Senjan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115132/
> ---
> 
> (Updated Jan. 19, 2014, 10:34 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> Patch to make kconfigwidgets not collide with kdelibs(4) when installed to 
> same prefix.
> I can cleanup whitespaces if needed (they where present in original script). 
> Also, depending on the outcome of r115065, can change kdeoptions man 
> reference.
> 
> 
> Diffs
> -
> 
>   docs/preparetips/CMakeLists.txt 4685089 
>   docs/preparetips/man-preparetips.1.docbook baf4b6b 
>   docs/preparetips/man-preparetips5.1.docbook PRE-CREATION 
>   src/CMakeLists.txt baf5295 
>   src/ktipdialog.cpp 1b74f55 
>   src/preparetips a89d9f1 
>   src/preparetips5 PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115132/diff/
> 
> 
> Testing
> ---
> 
> Builds :)
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115200: fix windows build

[Alexander Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115200/
---

(Updated Jan. 21, 2014, 11:33 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kauth


Description
---

Fix windows build

Add a stub implementation of syslog that simply writes to stderr.
Use QThread::usleep() instead of the Unix-only usleep()

Allow compiling the tests on windows by adding -DKAUTH_STATIC_DEFINE=1


Diffs
-

  autotests/CMakeLists.txt 746d61798d768eeeff7fe889fec768a4887053db 
  autotests/TestHelper.cpp b0005bd80af3d7232387458c4e4ffad5c5374f52 
  src/backends/dbus/DBusHelperProxy.cpp 
03f63f2edd91865cf3e636fb28df0015e7759210 
  src/kauthhelpersupport.cpp 2cd1f68880673780a9a2c18cd5b120b2baea54e9 

Diff: https://git.reviewboard.kde.org/r/115200/diff/


Testing
---


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115200: fix windows build

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115200/#review47960
---


This review has been submitted with commit 
8ea89457676104911eaa16331c6082fa1b563fc9 by Alex Richardson to branch master.

- Commit Hook


On Jan. 21, 2014, 10:21 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115200/
> ---
> 
> (Updated Jan. 21, 2014, 10:21 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kauth
> 
> 
> Description
> ---
> 
> Fix windows build
> 
> Add a stub implementation of syslog that simply writes to stderr.
> Use QThread::usleep() instead of the Unix-only usleep()
> 
> Allow compiling the tests on windows by adding -DKAUTH_STATIC_DEFINE=1
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 746d61798d768eeeff7fe889fec768a4887053db 
>   autotests/TestHelper.cpp b0005bd80af3d7232387458c4e4ffad5c5374f52 
>   src/backends/dbus/DBusHelperProxy.cpp 
> 03f63f2edd91865cf3e636fb28df0015e7759210 
>   src/kauthhelpersupport.cpp 2cd1f68880673780a9a2c18cd5b120b2baea54e9 
> 
> Diff: https://git.reviewboard.kde.org/r/115200/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115199: Fix detection of shared-mime-info on Windows

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115199/#review47959
---

Ship it!


Looks good to me.

- Aleix Pol Gonzalez


On Jan. 21, 2014, 11:30 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115199/
> ---
> 
> (Updated Jan. 21, 2014, 11:30 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Fix detection of shared-mime-info on Windows
> 
> For some reason exec_program would fail, it works with execute_process
> 
> 
> Diffs
> -
> 
>   cmake/FindSharedMimeInfo.cmake 4427c733b3c4e6fb969ee03e4405fb2a12a26232 
> 
> Diff: https://git.reviewboard.kde.org/r/115199/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115199: Fix detection of shared-mime-info on Windows

[Alexander Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115199/
---

(Updated Jan. 22, 2014, 12:30 a.m.)


Review request for KDE Frameworks.


Changes
---

right diff


Repository: kcoreaddons


Description
---

Fix detection of shared-mime-info on Windows

For some reason exec_program would fail, it works with execute_process


Diffs (updated)
-

  cmake/FindSharedMimeInfo.cmake 4427c733b3c4e6fb969ee03e4405fb2a12a26232 

Diff: https://git.reviewboard.kde.org/r/115199/diff/


Testing
---


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Split classes into separate files?

[David Gil Oliva]

Hi!

I'm revising KCompletion and I have found that in kcompletion.h you can see
the declaration of KCompletionBase (which is defined in a separate file)
and KCompletionMatches (which is defined in kcompletion.cpp).

I think I have seen that in other frameworks classes are being split into
separate files. Should I also do it with KCompletionBase and
KCompletionMatches?

Cheers

David Gil
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115199: Fix detection of shared-mime-info on Windows

[Alexander Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115199/
---

(Updated Jan. 22, 2014, 12:29 a.m.)


Review request for KDE Frameworks.


Changes
---

fixed the reported issue


Repository: kcoreaddons


Description
---

Fix detection of shared-mime-info on Windows

For some reason exec_program would fail, it works with execute_process


Diffs (updated)
-

  cmake/FindSharedMimeInfo.cmake 4427c733b3c4e6fb969ee03e4405fb2a12a26232 

Diff: https://git.reviewboard.kde.org/r/115199/diff/


Testing
---


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115199: Fix detection of shared-mime-info on Windows

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115199/#review47957
---



cmake/FindSharedMimeInfo.cmake


On Unix, `update-mime-database -v` outputs to stderr.  You should set 
ERROR_VARIABLE to the same values as OUTPUT_VARIABLE (this will merge the 
streams); that way it should work on both Windows and Unix.


- Alex Merry


On Jan. 21, 2014, 10:21 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115199/
> ---
> 
> (Updated Jan. 21, 2014, 10:21 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Fix detection of shared-mime-info on Windows
> 
> For some reason exec_program would fail, it works with execute_process
> 
> 
> Diffs
> -
> 
>   cmake/FindSharedMimeInfo.cmake 4427c733b3c4e6fb969ee03e4405fb2a12a26232 
> 
> Diff: https://git.reviewboard.kde.org/r/115199/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115200: fix windows build

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115200/#review47955
---

Ship it!


Still compiles fine for me (Linux, gcc).

- Alex Merry


On Jan. 21, 2014, 10:21 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115200/
> ---
> 
> (Updated Jan. 21, 2014, 10:21 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kauth
> 
> 
> Description
> ---
> 
> Fix windows build
> 
> Add a stub implementation of syslog that simply writes to stderr.
> Use QThread::usleep() instead of the Unix-only usleep()
> 
> Allow compiling the tests on windows by adding -DKAUTH_STATIC_DEFINE=1
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 746d61798d768eeeff7fe889fec768a4887053db 
>   autotests/TestHelper.cpp b0005bd80af3d7232387458c4e4ffad5c5374f52 
>   src/backends/dbus/DBusHelperProxy.cpp 
> 03f63f2edd91865cf3e636fb28df0015e7759210 
>   src/kauthhelpersupport.cpp 2cd1f68880673780a9a2c18cd5b120b2baea54e9 
> 
> Diff: https://git.reviewboard.kde.org/r/115200/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs

[David Gil Oliva]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115206/
---

Review request for KDE Frameworks.


Repository: kcompletion


Description
---

Correct spelling, grammar and style of kcompletion.h docs


Diffs
-

  src/kcompletion.h 46b63a4 

Diff: https://git.reviewboard.kde.org/r/115206/diff/


Testing
---


Thanks,

David Gil Oliva

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115164: Keep tests together

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115164/#review47953
---


Seems sensible to me, but I would add Valentin Rusu to the review.

- Alex Merry


On Jan. 21, 2014, 10:38 a.m., Michael Palimaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115164/
> ---
> 
> (Updated Jan. 21, 2014, 10:38 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> There are two sets of sets in the middle of the source tree, away from the 
> usual autotests/. This moves them so that they are all together.
> 
> (I don't know why git didn't recognise certain files as just being moved in 
> the diff)
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/kcookiejar/tests/cookie_rfc.test  
>   src/ioslaves/http/kcookiejar/tests/cookie_saving.test  
>   src/ioslaves/http/kcookiejar/tests/cookie_session.test  
>   src/ioslaves/http/kcookiejar/tests/cookie_settings.test  
>   src/ioslaves/http/kcookiejar/tests/kcookiejartest.cpp  
>   src/ioslaves/http/tests/CMakeLists.txt  
>   src/ioslaves/http/tests/httpauthenticationtest.h  
>   src/ioslaves/http/tests/httpauthenticationtest.cpp  
>   src/ioslaves/http/tests/httpfiltertest.cpp  
>   src/ioslaves/http/tests/httpheaderdispositiontest.h  
>   src/ioslaves/http/tests/httpheaderdispositiontest.cpp  
>   src/ioslaves/http/tests/httpheadertokenizetest.h  
>   src/ioslaves/http/tests/httpheadertokenizetest.cpp  
>   src/ioslaves/http/tests/httpobjecttest.h  
>   src/ioslaves/http/tests/httpobjecttest.cpp  
>   autotests/CMakeLists.txt 5655d45efcfd9455e1745a2ec93e2da30a9b83b2 
>   autotests/http/CMakeLists.txt PRE-CREATION 
>   autotests/http/httpfiltertest.cpp PRE-CREATION 
>   autotests/http/tests/httpauthenticationtest.h PRE-CREATION 
>   autotests/http/tests/httpauthenticationtest.cpp PRE-CREATION 
>   autotests/http/tests/httpheaderdispositiontest.h PRE-CREATION 
>   autotests/http/tests/httpheaderdispositiontest.cpp PRE-CREATION 
>   autotests/http/tests/httpheadertokenizetest.h PRE-CREATION 
>   autotests/http/tests/httpheadertokenizetest.cpp PRE-CREATION 
>   autotests/http/tests/httpobjecttest.h PRE-CREATION 
>   autotests/http/tests/httpobjecttest.cpp PRE-CREATION 
>   autotests/kcookiejar/kcookiejartest.cpp PRE-CREATION 
>   autotests/kcookiejar/tests/CMakeLists.txt PRE-CREATION 
>   autotests/kcookiejar/tests/cookie.test PRE-CREATION 
>   autotests/kcookiejar/tests/cookie_rfc.test PRE-CREATION 
>   autotests/kcookiejar/tests/cookie_saving.test PRE-CREATION 
>   autotests/kcookiejar/tests/cookie_session.test PRE-CREATION 
>   autotests/kcookiejar/tests/cookie_settings.test PRE-CREATION 
>   src/ioslaves/http/CMakeLists.txt 39fd42f62bd583f92f655739a97a02b09c61 
>   src/ioslaves/http/kcookiejar/CMakeLists.txt 
> 54b1fe0b818f63cd76ac79d5233a3c00da866950 
>   src/ioslaves/http/kcookiejar/tests/CMakeLists.txt  
>   src/ioslaves/http/kcookiejar/tests/cookie.test  
> 
> Diff: https://git.reviewboard.kde.org/r/115164/diff/
> 
> 
> Testing
> ---
> 
> Builds, affected tests pass.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115202: Allow building KConfigWidgets on Windows

[Luigi Toscano]

> On Jan. 21, 2014, 10:29 p.m., Luigi Toscano wrote:
> > Jut to be sure, are the two changes (optional KDocTools and the 
> > not-iterator hack) unrelated?
> 
> Alexander Richardson wrote:
> two separate commits, however kdoctools is broken on windows so I made it 
> optional to allow building
> 
> Luigi Toscano wrote:
> Wouldn't it be better to fix KDocTools on windows instead? :)
> 
> What is broken? Is it the issue with compiling libxml/libxslt?
> 
> Alexander Richardson wrote:
> The problem is that it can't find kdex.dtd. I guess I could fix that by 
> copying it the right location, but thats more of a hack.
>
> 
> Luigi Toscano wrote:
> Uhm, on Linux systems you have to set XDG_DATA_DIRS:
> "The value of kde-dir/share must be included in the environment variable 
> XDG_DATA_DIRS or otherwise the build will fail." where " kde-dir = your KDE 
> Frameworks 5 installation directory" (from 
> http://community.kde.org/Frameworks/Building).
> I don't know if and how it works on Windows.
> 
> Alexander Richardson wrote:
> It is not possible.
> 
> I will have to modify KDEInstallDirs to get a proper fix. Instead of 
> /share/* we have to install to C:/ProgramData/* or some per-user dir 
> (will have to investigate there, although I don't feel like spending much 
> time on this issue since I rarely use Windows)

Can you please at least report this on the TODO list of kde-windows packagers? 
As I said, I'm not sure this is the right long-term solution, I guess it will 
happen also for every other frameworks/modules on Windows.


- Luigi


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115202/#review47936
---


On Jan. 21, 2014, 10:26 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115202/
> ---
> 
> (Updated Jan. 21, 2014, 10:26 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> Make KDocTools an optional dependency
> 
> 
> Fix compilation on MSVC
> 
> Not sure whether this is a bug in MSVC or their STL or even Qt (unlikely)
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt b5b42fb207d68e44bc0fe58763a39574d81c3e9d 
>   src/kcolorschememanager.cpp 2e44f88d4b613a263047899b102da53541139171 
> 
> Diff: https://git.reviewboard.kde.org/r/115202/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115132: Append 5 to preparetips script & manpage

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115132/#review47951
---

Ship it!


Seems sensible to me.

- Alex Merry


On Jan. 19, 2014, 10:34 p.m., Hrvoje Senjan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115132/
> ---
> 
> (Updated Jan. 19, 2014, 10:34 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> Patch to make kconfigwidgets not collide with kdelibs(4) when installed to 
> same prefix.
> I can cleanup whitespaces if needed (they where present in original script). 
> Also, depending on the outcome of r115065, can change kdeoptions man 
> reference.
> 
> 
> Diffs
> -
> 
>   docs/preparetips/CMakeLists.txt 4685089 
>   docs/preparetips/man-preparetips.1.docbook baf4b6b 
>   docs/preparetips/man-preparetips5.1.docbook PRE-CREATION 
>   src/CMakeLists.txt baf5295 
>   src/ktipdialog.cpp 1b74f55 
>   src/preparetips a89d9f1 
>   src/preparetips5 PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115132/diff/
> 
> 
> Testing
> ---
> 
> Builds :)
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115099: Add function ecm_generate_pri_file() to provide qmake support. Make ECMSetupVersion set PROJECT_VERSION_*

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115099/#review47948
---



modules/ECMGeneratePriFile.cmake


It also wants PROJECT_VERSION_(MAJOR|MINOR|PATCH) (unless those are option 
in the pri file)



modules/ECMGeneratePriFile.cmake


It doesn't take a  argument



modules/ECMGeneratePriFile.cmake


I feel DEPS should really be a list, but CMake apparently doesn't have a 
join function, for some bizarre reason (although you probably could do a 
string(REPLACE) of semicolons by spaces).


- Alex Merry


On Jan. 18, 2014, 11:02 a.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115099/
> ---
> 
> (Updated Jan. 18, 2014, 11:02 a.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Two commits:
> 
> 1) Make ECMSetupVersion set PROJECT_VERSION_*
> 
> This makes it easier for other functions to access the project version,
> for instance my upcoming ECM_GENERATE_PRI_FILE()
> 
> 2) This file provides the function ecm_generate_pri_file().
> 
> ECM_GENERATE_PRI_FILE() creates a .pri file for a library so that qmake-based
> apps can more easily use the library.
> It also sets ECM_MKSPECS_INSTALL_DIR as the directory to install the .pri 
> file to.
> 
> 
> Diffs
> -
> 
>   modules/ECMGeneratePriFile.cmake PRE-CREATION 
>   modules/ECMSetupVersion.cmake 6c3a9959be31ee186cf173bb28585dfc52860a55 
> 
> Diff: https://git.reviewboard.kde.org/r/115099/diff/
> 
> 
> Testing
> ---
> 
> Adding these lines to kwidgetaddons/src/CMakeLists.txt:
> include(ECMGeneratePriFile)
> ecm_generate_pri_file(BASE_NAME KWidgetsAddons LIB_NAME KF5WidgetsAddons DEPS 
> "widgets" FILENAME_VAR PRI_FILENAME)
> install(FILES ${PRI_FILENAME} DESTINATION ${ECM_MKSPECS_INSTALL_DIR})
> 
> And these to kjobwidgets:
> include(ECMGeneratePriFile)
> ecm_generate_pri_file(BASE_NAME KJobWidgets LIB_NAME KF5JobWidgets DEPS 
> "KCoreAddons widgets" FILENAME_VAR PRI_FILENAME)
> install(FILES ${PRI_FILENAME} DESTINATION ${ECM_MKSPECS_INSTALL_DIR})
> 
> And I added a qmake_test subdir in kf5umbrella with qmake_test.pro saying:
> QT += KArchive KJobWidgets KWidgetsAddons
> SOURCES += main.cpp
> -> links to all the mentionned libs, including KCoreAddons (via KJobWidgets).
> 
> This requires $QMAKEPATH set to the kf5 install prefix.
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115202: Allow building KConfigWidgets on Windows

[Alexander Richardson]

> On Jan. 21, 2014, 11:29 p.m., Luigi Toscano wrote:
> > Jut to be sure, are the two changes (optional KDocTools and the 
> > not-iterator hack) unrelated?
> 
> Alexander Richardson wrote:
> two separate commits, however kdoctools is broken on windows so I made it 
> optional to allow building
> 
> Luigi Toscano wrote:
> Wouldn't it be better to fix KDocTools on windows instead? :)
> 
> What is broken? Is it the issue with compiling libxml/libxslt?
> 
> Alexander Richardson wrote:
> The problem is that it can't find kdex.dtd. I guess I could fix that by 
> copying it the right location, but thats more of a hack.
>
> 
> Luigi Toscano wrote:
> Uhm, on Linux systems you have to set XDG_DATA_DIRS:
> "The value of kde-dir/share must be included in the environment variable 
> XDG_DATA_DIRS or otherwise the build will fail." where " kde-dir = your KDE 
> Frameworks 5 installation directory" (from 
> http://community.kde.org/Frameworks/Building).
> I don't know if and how it works on Windows.

It is not possible.

I will have to modify KDEInstallDirs to get a proper fix. Instead of 
/share/* we have to install to C:/ProgramData/* or some per-user dir 
(will have to investigate there, although I don't feel like spending much time 
on this issue since I rarely use Windows)


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115202/#review47936
---


On Jan. 21, 2014, 11:26 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115202/
> ---
> 
> (Updated Jan. 21, 2014, 11:26 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> Make KDocTools an optional dependency
> 
> 
> Fix compilation on MSVC
> 
> Not sure whether this is a bug in MSVC or their STL or even Qt (unlikely)
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt b5b42fb207d68e44bc0fe58763a39574d81c3e9d 
>   src/kcolorschememanager.cpp 2e44f88d4b613a263047899b102da53541139171 
> 
> Diff: https://git.reviewboard.kde.org/r/115202/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115202: Allow building KConfigWidgets on Windows

[Aleix Pol Gonzalez]

> On Jan. 21, 2014, 10:53 p.m., Aleix Pol Gonzalez wrote:
> > CMakeLists.txt, line 29
> > 
> >
> > What's the problem with finding documentation on windows?

Uh sorry, didn't see somebody went before me :).


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115202/#review47947
---


On Jan. 21, 2014, 10:26 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115202/
> ---
> 
> (Updated Jan. 21, 2014, 10:26 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> Make KDocTools an optional dependency
> 
> 
> Fix compilation on MSVC
> 
> Not sure whether this is a bug in MSVC or their STL or even Qt (unlikely)
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt b5b42fb207d68e44bc0fe58763a39574d81c3e9d 
>   src/kcolorschememanager.cpp 2e44f88d4b613a263047899b102da53541139171 
> 
> Diff: https://git.reviewboard.kde.org/r/115202/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115202: Allow building KConfigWidgets on Windows

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115202/#review47947
---



CMakeLists.txt


What's the problem with finding documentation on windows?


- Aleix Pol Gonzalez


On Jan. 21, 2014, 10:26 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115202/
> ---
> 
> (Updated Jan. 21, 2014, 10:26 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> Make KDocTools an optional dependency
> 
> 
> Fix compilation on MSVC
> 
> Not sure whether this is a bug in MSVC or their STL or even Qt (unlikely)
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt b5b42fb207d68e44bc0fe58763a39574d81c3e9d 
>   src/kcolorschememanager.cpp 2e44f88d4b613a263047899b102da53541139171 
> 
> Diff: https://git.reviewboard.kde.org/r/115202/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115202: Allow building KConfigWidgets on Windows

[Luigi Toscano]

> On Jan. 21, 2014, 10:29 p.m., Luigi Toscano wrote:
> > Jut to be sure, are the two changes (optional KDocTools and the 
> > not-iterator hack) unrelated?
> 
> Alexander Richardson wrote:
> two separate commits, however kdoctools is broken on windows so I made it 
> optional to allow building
> 
> Luigi Toscano wrote:
> Wouldn't it be better to fix KDocTools on windows instead? :)
> 
> What is broken? Is it the issue with compiling libxml/libxslt?
> 
> Alexander Richardson wrote:
> The problem is that it can't find kdex.dtd. I guess I could fix that by 
> copying it the right location, but thats more of a hack.
>

Uhm, on Linux systems you have to set XDG_DATA_DIRS:
"The value of kde-dir/share must be included in the environment variable 
XDG_DATA_DIRS or otherwise the build will fail." where " kde-dir = your KDE 
Frameworks 5 installation directory" (from 
http://community.kde.org/Frameworks/Building).
I don't know if and how it works on Windows.


- Luigi


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115202/#review47936
---


On Jan. 21, 2014, 10:26 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115202/
> ---
> 
> (Updated Jan. 21, 2014, 10:26 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> Make KDocTools an optional dependency
> 
> 
> Fix compilation on MSVC
> 
> Not sure whether this is a bug in MSVC or their STL or even Qt (unlikely)
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt b5b42fb207d68e44bc0fe58763a39574d81c3e9d 
>   src/kcolorschememanager.cpp 2e44f88d4b613a263047899b102da53541139171 
> 
> Diff: https://git.reviewboard.kde.org/r/115202/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114980: Do not explicity find or use Qt5WebKit(Widgets)

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114980/#review47943
---


This review has been submitted with commit 
749336963bbcddea2e547020202e049937536275 by Alex Merry to branch master.

- Commit Hook


On Jan. 12, 2014, 12:58 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114980/
> ---
> 
> (Updated Jan. 12, 2014, 12:58 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kdesignerplugin
> 
> 
> Description
> ---
> 
> Do not explicity find or use Qt5WebKit(Widgets)
> 
> The kdewebkit designer plugin does not directly use anything from
> Qt5WebKitWidgets, only KWebView from KF5WebKit.  Qt5WebKitWidgets is
> found as a dependency of KF5WebKit.  So we do not need to find it
> ourselves, or explicitly link against it.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt d13d071f935306df2d052b58a6a03ea92bba36f3 
>   src/CMakeLists.txt 55ac819d4c2cbaac483cec9617402e18fbe22d2b 
> 
> Diff: https://git.reviewboard.kde.org/r/114980/diff/
> 
> 
> Testing
> ---
> 
> Still configures, builds and installs.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114980: Do not explicity find or use Qt5WebKit(Widgets)

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114980/
---

(Updated Jan. 21, 2014, 10:42 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Alex Merry.


Repository: kdesignerplugin


Description
---

Do not explicity find or use Qt5WebKit(Widgets)

The kdewebkit designer plugin does not directly use anything from
Qt5WebKitWidgets, only KWebView from KF5WebKit.  Qt5WebKitWidgets is
found as a dependency of KF5WebKit.  So we do not need to find it
ourselves, or explicitly link against it.


Diffs
-

  CMakeLists.txt d13d071f935306df2d052b58a6a03ea92bba36f3 
  src/CMakeLists.txt 55ac819d4c2cbaac483cec9617402e18fbe22d2b 

Diff: https://git.reviewboard.kde.org/r/114980/diff/


Testing
---

Still configures, builds and installs.


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115190: Add unit test for KWindowInfo on X11

[Ben Cooksley]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115190/#review47945
---


I'm afraid the test fails Martin. Guess KWin and Openbox behave differently in 
some areas.

5/9 Test #5: kwindowsystem-kwindowinfox11test ..***Failed9.96 sec
* Start testing of KWindowInfoX11Test *
Config: Using QtTest library 5.2.2, Qt 5.2.2
PASS   : KWindowInfoX11Test::initTestCase()
FAIL!  : KWindowInfoX11Test::testState(max) Compared values are not the same
   Actual   (info.state()): 0
   Expected (static_cast(firstRun ? NET::DemandsAttention : 0)): 
2048
   Loc: 
[/srv/jenkins/workspace/kwindowsystem_master_qt5/autotests/kwindowinfox11test.cpp(129)]
PASS   : KWindowInfoX11Test::testState(maxHoriz)
FAIL!  : KWindowInfoX11Test::testState(shaded) 'waitForWindow(spy, 
window->winId(), NET::WMState)' returned FALSE. ()
   Loc: 
[/srv/jenkins/workspace/kwindowsystem_master_qt5/autotests/kwindowinfox11test.cpp(159)]
FAIL!  : KWindowInfoX11Test::testState(skipTaskbar) 'waitForWindow(spy, 
window->winId(), NET::WMState)' returned FALSE. ()
   Loc: 
[/srv/jenkins/workspace/kwindowsystem_master_qt5/autotests/kwindowinfox11test.cpp(159)]
FAIL!  : KWindowInfoX11Test::testState(skipPager) 'waitForWindow(spy, 
window->winId(), NET::WMState)' returned FALSE. ()
   Loc: 
[/srv/jenkins/workspace/kwindowsystem_master_qt5/autotests/kwindowinfox11test.cpp(159)]
FAIL!  : KWindowInfoX11Test::testState(keep above) 'waitForWindow(spy, 
window->winId(), NET::WMState)' returned FALSE. ()
   Loc: 
[/srv/jenkins/workspace/kwindowsystem_master_qt5/autotests/kwindowinfox11test.cpp(159)]
FAIL!  : KWindowInfoX11Test::testState(keep below) 'waitForWindow(spy, 
window->winId(), NET::WMState)' returned FALSE. ()
   Loc: 
[/srv/jenkins/workspace/kwindowsystem_master_qt5/autotests/kwindowinfox11test.cpp(159)]
FAIL!  : KWindowInfoX11Test::testState(fullscreen) 'waitForWindow(spy, 
window->winId(), NET::WMState)' returned FALSE. ()
   Loc: 
[/srv/jenkins/workspace/kwindowsystem_master_qt5/autotests/kwindowinfox11test.cpp(159)]
PASS   : KWindowInfoX11Test::testMinimized()
PASS   : KWindowInfoX11Test::testMappingState()
PASS   : KWindowInfoX11Test::testWindowType(desktop)
PASS   : KWindowInfoX11Test::testWindowType(dock)
PASS   : KWindowInfoX11Test::testWindowType(toolbar)
PASS   : KWindowInfoX11Test::testWindowType(menu)
PASS   : KWindowInfoX11Test::testWindowType(dialog)
PASS   : KWindowInfoX11Test::testWindowType(override)
PASS   : KWindowInfoX11Test::testWindowType(override as normal)
PASS   : KWindowInfoX11Test::testWindowType(topmenu)
PASS   : KWindowInfoX11Test::testWindowType(topmenu as dock)
PASS   : KWindowInfoX11Test::testWindowType(utility)
PASS   : KWindowInfoX11Test::testWindowType(utility as dialog)
PASS   : KWindowInfoX11Test::testWindowType(splash)
PASS   : KWindowInfoX11Test::testWindowType(splash as dock)
PASS   : KWindowInfoX11Test::testWindowType(dropdownmenu)
PASS   : KWindowInfoX11Test::testWindowType(popupmenu)
PASS   : KWindowInfoX11Test::testWindowType(popupmenu as menu)
PASS   : KWindowInfoX11Test::testWindowType(tooltip)
PASS   : KWindowInfoX11Test::testWindowType(notification)
PASS   : KWindowInfoX11Test::testWindowType(ComboBox)
PASS   : KWindowInfoX11Test::testWindowType(DNDIcon)
PASS   : KWindowInfoX11Test::testWindowType(desktop-unknown)
PASS   : KWindowInfoX11Test::testWindowType(dock-unknown)
PASS   : KWindowInfoX11Test::testWindowType(toolbar-unknown)
PASS   : KWindowInfoX11Test::testWindowType(menu-unknown)
PASS   : KWindowInfoX11Test::testWindowType(dialog-unknown)
PASS   : KWindowInfoX11Test::testWindowType(override-unknown)
PASS   : KWindowInfoX11Test::testWindowType(topmenu-unknown)
PASS   : KWindowInfoX11Test::testWindowType(utility-unknown)
PASS   : KWindowInfoX11Test::testWindowType(splash-unknown)
PASS   : KWindowInfoX11Test::testWindowType(dropdownmenu-unknown)
PASS   : KWindowInfoX11Test::testWindowType(popupmenu-unknown)
PASS   : KWindowInfoX11Test::testWindowType(tooltip-unknown)
PASS   : KWindowInfoX11Test::testWindowType(notification-unknown)
PASS   : KWindowInfoX11Test::testWindowType(ComboBox-unknown)
PASS   : KWindowInfoX11Test::testWindowType(DNDIcon-unknown)
FAIL!  : KWindowInfoX11Test::testDesktop() 'waitForWindow(spy, window->winId(), 
NET::WMDesktop)' returned FALSE. ()
   Loc: 
[/srv/jenkins/workspace/kwindowsystem_master_qt5/autotests/kwindowinfox11test.cpp(304)]
PASS   : KWindowInfoX11Test::testWindowClass()
PASS   : KWindowInfoX11Test::testWindowRole()
PASS   : KWindowInfoX11Test::testClientMachine()
FAIL!  : KWindowInfoX11Test::testName() Compared values are not the same
   Actual   (info3.visibleName()) : kwindowinfox11test
   Expected (QStringLiteral("foobar")): foobar
   Loc: 
[/srv/jenkins/workspace/kwindowsystem_master_qt5/autotests/kwindowinfox11test.cpp(436)]

Re: Review Request 115202: Allow building KConfigWidgets on Windows

[Alexander Richardson]

> On Jan. 21, 2014, 11:29 p.m., Luigi Toscano wrote:
> > Jut to be sure, are the two changes (optional KDocTools and the 
> > not-iterator hack) unrelated?
> 
> Alexander Richardson wrote:
> two separate commits, however kdoctools is broken on windows so I made it 
> optional to allow building
> 
> Luigi Toscano wrote:
> Wouldn't it be better to fix KDocTools on windows instead? :)
> 
> What is broken? Is it the issue with compiling libxml/libxslt?

The problem is that it can't find kdex.dtd. I guess I could fix that by copying 
it the right location, but thats more of a hack.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115202/#review47936
---


On Jan. 21, 2014, 11:26 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115202/
> ---
> 
> (Updated Jan. 21, 2014, 11:26 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> Make KDocTools an optional dependency
> 
> 
> Fix compilation on MSVC
> 
> Not sure whether this is a bug in MSVC or their STL or even Qt (unlikely)
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt b5b42fb207d68e44bc0fe58763a39574d81c3e9d 
>   src/kcolorschememanager.cpp 2e44f88d4b613a263047899b102da53541139171 
> 
> Diff: https://git.reviewboard.kde.org/r/115202/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115203: Allow compiling with MSVC

[Alexander Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115203/
---

Review request for KDE Frameworks.


Repository: kcrash


Description
---

Allow compiling with MSVC


Diffs
-

  src/config-strlcpy.h.cmake 5d9163d7a60d89b9792afcdf498af6425a9038a8 
  src/kcrash.cpp 13b64adff7bce5782b054bf43ef9e357e9aa1622 

Diff: https://git.reviewboard.kde.org/r/115203/diff/


Testing
---


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114980: Do not explicity find or use Qt5WebKit(Widgets)

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114980/#review47942
---


Welp, since no-one seems to care, I'm gonna commit it.

- Alex Merry


On Jan. 12, 2014, 12:58 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114980/
> ---
> 
> (Updated Jan. 12, 2014, 12:58 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kdesignerplugin
> 
> 
> Description
> ---
> 
> Do not explicity find or use Qt5WebKit(Widgets)
> 
> The kdewebkit designer plugin does not directly use anything from
> Qt5WebKitWidgets, only KWebView from KF5WebKit.  Qt5WebKitWidgets is
> found as a dependency of KF5WebKit.  So we do not need to find it
> ourselves, or explicitly link against it.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt d13d071f935306df2d052b58a6a03ea92bba36f3 
>   src/CMakeLists.txt 55ac819d4c2cbaac483cec9617402e18fbe22d2b 
> 
> Diff: https://git.reviewboard.kde.org/r/114980/diff/
> 
> 
> Testing
> ---
> 
> Still configures, builds and installs.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115201: Use qplatformdefs.h

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115201/#review47940
---

Ship it!


Looks good, still compiles fine here (Linux, gcc).


src/kbookmark.h


I wondered if this was going to make a comeback...


- Alex Merry


On Jan. 21, 2014, 10:22 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115201/
> ---
> 
> (Updated Jan. 21, 2014, 10:22 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kbookmarks
> 
> 
> Description
> ---
> 
> Use qplatformdefs.h
> 
> 
> Add a dummy qHash function so that MSVC doesn't fail
> 
> 
> Diffs
> -
> 
>   src/kbookmark.h 0ce3a74b922da0ceaa214f7556d946ea1e62215a 
>   src/kbookmarkimporter.cpp 9ce564f88f0a4d4bafe4a54a899ae90632d31f65 
>   src/kbookmarkimporter_ie.cpp 457d22fc388def15104b9ef86958a44980a61935 
>   src/kbookmarkimporter_opera.cpp d44548d8bf8039a12ceeb387985352f605cf27a1 
> 
> Diff: https://git.reviewboard.kde.org/r/115201/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115202: Allow building KConfigWidgets on Windows

[Luigi Toscano]

> On Jan. 21, 2014, 10:29 p.m., Luigi Toscano wrote:
> > Jut to be sure, are the two changes (optional KDocTools and the 
> > not-iterator hack) unrelated?
> 
> Alexander Richardson wrote:
> two separate commits, however kdoctools is broken on windows so I made it 
> optional to allow building

Wouldn't it be better to fix KDocTools on windows instead? :)

What is broken? Is it the issue with compiling libxml/libxslt?


- Luigi


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115202/#review47936
---


On Jan. 21, 2014, 10:26 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115202/
> ---
> 
> (Updated Jan. 21, 2014, 10:26 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> Make KDocTools an optional dependency
> 
> 
> Fix compilation on MSVC
> 
> Not sure whether this is a bug in MSVC or their STL or even Qt (unlikely)
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt b5b42fb207d68e44bc0fe58763a39574d81c3e9d 
>   src/kcolorschememanager.cpp 2e44f88d4b613a263047899b102da53541139171 
> 
> Diff: https://git.reviewboard.kde.org/r/115202/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115197: Allow compiling KTextEditor on Windows

[Alexander Richardson]

> On Jan. 21, 2014, 11:24 p.m., Christoph Cullmann wrote:
> > ++ for platformsdefs, still no idea why we need winsock, thought, need to 
> > look at that.

gethostname is called, I am not familiar enough with the code to say whether 
that is necessary


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115197/#review47934
---


On Jan. 21, 2014, 11:21 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115197/
> ---
> 
> (Updated Jan. 21, 2014, 11:21 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Cullmann.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> ---
> 
> Allow compiling KTextEditor on Windows
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 761ec5ce08035ce801997e207e4f3871dfa8bd21 
>   src/syntax/katesyntaxdocument.cpp b92e07e367ecbef938f2fa184b5f92633aa4ce92 
>   src/utils/templateinterface.cpp 74e965efd0cc98b69f839cd20b7af4bf219d797b 
> 
> Diff: https://git.reviewboard.kde.org/r/115197/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115197: Allow compiling KTextEditor on Windows

[Christoph Cullmann]

> On Jan. 21, 2014, 10:24 p.m., Christoph Cullmann wrote:
> > ++ for platformsdefs, still no idea why we need winsock, thought, need to 
> > look at that.
> 
> Alexander Richardson wrote:
> gethostname is called, I am not familiar enough with the code to say 
> whether that is necessary

I see, will fix that, thanks for the hint.


- Christoph


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115197/#review47934
---


On Jan. 21, 2014, 10:21 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115197/
> ---
> 
> (Updated Jan. 21, 2014, 10:21 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Cullmann.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> ---
> 
> Allow compiling KTextEditor on Windows
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 761ec5ce08035ce801997e207e4f3871dfa8bd21 
>   src/syntax/katesyntaxdocument.cpp b92e07e367ecbef938f2fa184b5f92633aa4ce92 
>   src/utils/templateinterface.cpp 74e965efd0cc98b69f839cd20b7af4bf219d797b 
> 
> Diff: https://git.reviewboard.kde.org/r/115197/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115202: Allow building KConfigWidgets on Windows

[Alexander Richardson]

> On Jan. 21, 2014, 11:29 p.m., Luigi Toscano wrote:
> > Jut to be sure, are the two changes (optional KDocTools and the 
> > not-iterator hack) unrelated?

two separate commits, however kdoctools is broken on windows so I made it 
optional to allow building


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115202/#review47936
---


On Jan. 21, 2014, 11:26 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115202/
> ---
> 
> (Updated Jan. 21, 2014, 11:26 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> Make KDocTools an optional dependency
> 
> 
> Fix compilation on MSVC
> 
> Not sure whether this is a bug in MSVC or their STL or even Qt (unlikely)
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt b5b42fb207d68e44bc0fe58763a39574d81c3e9d 
>   src/kcolorschememanager.cpp 2e44f88d4b613a263047899b102da53541139171 
> 
> Diff: https://git.reviewboard.kde.org/r/115202/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115197: Allow compiling KTextEditor on Windows

[Alexander Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115197/
---

(Updated Jan. 21, 2014, 10:34 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Christoph Cullmann.


Repository: ktexteditor


Description
---

Allow compiling KTextEditor on Windows


Diffs
-

  src/CMakeLists.txt 761ec5ce08035ce801997e207e4f3871dfa8bd21 
  src/syntax/katesyntaxdocument.cpp b92e07e367ecbef938f2fa184b5f92633aa4ce92 
  src/utils/templateinterface.cpp 74e965efd0cc98b69f839cd20b7af4bf219d797b 

Diff: https://git.reviewboard.kde.org/r/115197/diff/


Testing
---


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115197: Allow compiling KTextEditor on Windows

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115197/#review47938
---


This review has been submitted with commit 
db925facd7a728753b2a84ec51161b2234a6bf48 by Christoph Cullmann to branch master.

- Commit Hook


On Jan. 21, 2014, 10:21 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115197/
> ---
> 
> (Updated Jan. 21, 2014, 10:21 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Cullmann.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> ---
> 
> Allow compiling KTextEditor on Windows
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 761ec5ce08035ce801997e207e4f3871dfa8bd21 
>   src/syntax/katesyntaxdocument.cpp b92e07e367ecbef938f2fa184b5f92633aa4ce92 
>   src/utils/templateinterface.cpp 74e965efd0cc98b69f839cd20b7af4bf219d797b 
> 
> Diff: https://git.reviewboard.kde.org/r/115197/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115200: fix windows build

[Alexander Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115200/
---

Review request for KDE Frameworks.


Repository: kauth


Description
---

Fix windows build

Add a stub implementation of syslog that simply writes to stderr.
Use QThread::usleep() instead of the Unix-only usleep()

Allow compiling the tests on windows by adding -DKAUTH_STATIC_DEFINE=1


Diffs
-

  autotests/CMakeLists.txt 746d61798d768eeeff7fe889fec768a4887053db 
  autotests/TestHelper.cpp b0005bd80af3d7232387458c4e4ffad5c5374f52 
  src/backends/dbus/DBusHelperProxy.cpp 
03f63f2edd91865cf3e636fb28df0015e7759210 
  src/kauthhelpersupport.cpp 2cd1f68880673780a9a2c18cd5b120b2baea54e9 

Diff: https://git.reviewboard.kde.org/r/115200/diff/


Testing
---


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115197: Allow compiling KTextEditor on Windows

[Christoph Cullmann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115197/#review47934
---


++ for platformsdefs, still no idea why we need winsock, thought, need to look 
at that.

- Christoph Cullmann


On Jan. 21, 2014, 10:21 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115197/
> ---
> 
> (Updated Jan. 21, 2014, 10:21 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Cullmann.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> ---
> 
> Allow compiling KTextEditor on Windows
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 761ec5ce08035ce801997e207e4f3871dfa8bd21 
>   src/syntax/katesyntaxdocument.cpp b92e07e367ecbef938f2fa184b5f92633aa4ce92 
>   src/utils/templateinterface.cpp 74e965efd0cc98b69f839cd20b7af4bf219d797b 
> 
> Diff: https://git.reviewboard.kde.org/r/115197/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115202: Allow building KConfigWidgets on Windows

[Luigi Toscano]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115202/#review47936
---


Jut to be sure, are the two changes (optional KDocTools and the not-iterator 
hack) unrelated?

- Luigi Toscano


On Jan. 21, 2014, 10:26 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115202/
> ---
> 
> (Updated Jan. 21, 2014, 10:26 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> Make KDocTools an optional dependency
> 
> 
> Fix compilation on MSVC
> 
> Not sure whether this is a bug in MSVC or their STL or even Qt (unlikely)
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt b5b42fb207d68e44bc0fe58763a39574d81c3e9d 
>   src/kcolorschememanager.cpp 2e44f88d4b613a263047899b102da53541139171 
> 
> Diff: https://git.reviewboard.kde.org/r/115202/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115202: Allow building KConfigWidgets on Windows

[Alexander Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115202/
---

Review request for KDE Frameworks.


Repository: kconfigwidgets


Description
---

Make KDocTools an optional dependency


Fix compilation on MSVC

Not sure whether this is a bug in MSVC or their STL or even Qt (unlikely)


Diffs
-

  CMakeLists.txt b5b42fb207d68e44bc0fe58763a39574d81c3e9d 
  src/kcolorschememanager.cpp 2e44f88d4b613a263047899b102da53541139171 

Diff: https://git.reviewboard.kde.org/r/115202/diff/


Testing
---


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kf5options and qt5options manpages

[Alex Merry]

On 21/01/14 18:38, Jonathan Riddell wrote:
> 
> kdeoptions and qtoptions manpages listed the common options to applications 
> using kdelibs4 and qt4.
> 
> These have just become kf5options and qt5options.

There is also --license and --author (via KAboutData).

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115198: Fix KDE4Support compilation

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115198/
---

Review request for KDE Frameworks and David Faure.


Repository: kde4support


Description
---

KCrash::setApplicationName and KCrash::setApplicationPath disappeared from the 
KCrash module 179de6d16fb9be580dbb7b15e0a56fcb990c7516, so I guess that a good 
fix is just stop using it.

I'm unsure what's the best way though.


Diffs
-

  src/kdeui/kapplication.cpp 5a7f4c8 

Diff: https://git.reviewboard.kde.org/r/115198/diff/


Testing
---

Builds.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115201: Use qplatformdefs.h

[Alexander Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115201/
---

Review request for KDE Frameworks.


Repository: kbookmarks


Description
---

Use qplatformdefs.h


Add a dummy qHash function so that MSVC doesn't fail


Diffs
-

  src/kbookmark.h 0ce3a74b922da0ceaa214f7556d946ea1e62215a 
  src/kbookmarkimporter.cpp 9ce564f88f0a4d4bafe4a54a899ae90632d31f65 
  src/kbookmarkimporter_ie.cpp 457d22fc388def15104b9ef86958a44980a61935 
  src/kbookmarkimporter_opera.cpp d44548d8bf8039a12ceeb387985352f605cf27a1 

Diff: https://git.reviewboard.kde.org/r/115201/diff/


Testing
---


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kf5options and qt5options manpages

[Alex Merry]

On 21/01/14 18:38, Jonathan Riddell wrote:
>--nocrashhandler
>Disable the crash handler, to get core dumps.

Gone; use KDE_DEBUG=1 instead (see David Faure's email).

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115197: Allow compiling KTextEditor on Windows

[Alexander Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115197/
---

Review request for KDE Frameworks and Christoph Cullmann.


Repository: ktexteditor


Description
---

Allow compiling KTextEditor on Windows


Diffs
-

  src/CMakeLists.txt 761ec5ce08035ce801997e207e4f3871dfa8bd21 
  src/syntax/katesyntaxdocument.cpp b92e07e367ecbef938f2fa184b5f92633aa4ce92 
  src/utils/templateinterface.cpp 74e965efd0cc98b69f839cd20b7af4bf219d797b 

Diff: https://git.reviewboard.kde.org/r/115197/diff/


Testing
---


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115199: Fix detection of shared-mime-info on Windows

[Alexander Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115199/
---

Review request for KDE Frameworks.


Repository: kcoreaddons


Description
---

Fix detection of shared-mime-info on Windows

For some reason exec_program would fail, it works with execute_process


Diffs
-

  cmake/FindSharedMimeInfo.cmake 4427c733b3c4e6fb969ee03e4405fb2a12a26232 

Diff: https://git.reviewboard.kde.org/r/115199/diff/


Testing
---


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KCrash

[David Faure]

On Sunday 19 January 2014 20:56:23 David Faure wrote:
> On Sunday 19 January 2014 20:44:48 Kevin Ottens wrote:
> > What about KCRASH_NO_CRASH_HANDLER ? It's long but it makes it at least
> > descriptive.
> 
> Except that it's not technically correct, a crash handler (= a function
> called upon crashing) is still called, to handle autorestart functionality
> (when enabled by the app) and to print out some information (app foo is
> crashing). Or if the app installs a custom crash handler, it will be
> called.
> The only thing that this disables is drkonqi -- the command-line option has
> always been misnamed, although not as much as the env var :)
> 
> KCRASH_DISABLE_DRKONQI is probably the only strictly-correct name.
> 
> Anyhow, naming is the easy part on to actually implementing it...

Done:

commit 6f0059cd976bbd2968eb8d903e797fdcfb23d3af
Author: David Faure 
Date:   Tue Jan 21 22:52:00 2014 +0100

Replace --nocrashhandler with KCRASH_AUTO_RESTARTED=1 in the kcrash code.

This is how we internally detect that we are being restarted after a crash
and therefore we must
1) disable drkonqi
2) delay the crashhandler, to avoid infinite respawning in case the app 
crashes on startup

For users, KDE_DEBUG=1 remains the way to disable drkonqi. No cmdline arg 
anymore.


-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115166: Add a CMakeLists.txt which wraps python setup.py

[David Faure]

> On Jan. 21, 2014, 2:57 p.m., David Faure wrote:
> > Note that I fixed the "build failure with kdesrc-build" differently - I 
> > added a "ignore-modules kapidox" in kdesrc-build's include files.
> > 
> > And I don't like that this will break when using a custom prefix and 
> > PYTHONPATH is not set (which is the case here).
> >
> 
> Alex Merry wrote:
> You can't really avoid that with Python packages; you can install them 
> with --user and make sure your PATH is set correctly, or you can install them 
> with a prefix and make sure your PYTHONPATH is set correctly (or there are a 
> couple of other ways of telling python about custom site package dirs).
> 
> Well, or you can install them in a standard location, such as for distro 
> packages.
> 
> Aurélien Gâteau wrote:
> Note that the breakage is at runtime, not install time. But since 
> kdesrc-build now ignores kapidox, maybe it's simpler to discard this patch? 
> That's one less piece to maintain.
> 
> Alex Merry wrote:
> Sure; I have no opinion on it either way, TBH.

Ah right, it won't break make install. Then I withdraw my objection, go ahead.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115166/#review47881
---


On Jan. 21, 2014, 1:49 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115166/
> ---
> 
> (Updated Jan. 21, 2014, 1:49 p.m.)
> 
> 
> Review request for Build System, KDE Frameworks and Alex Merry.
> 
> 
> Repository: kapidox
> 
> 
> Description
> ---
> 
> To fix build failures with kdesrc-build, add a CMakeLists.txt which wraps 
> python setup.py.
> 
> 
> Diffs
> -
> 
>   README.md 660e9c3 
>   CMakeLists.txt PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115166/diff/
> 
> 
> Testing
> ---
> 
> Built and installed with the classic CMake commands. The kapidox tools work 
> fine as long as the installation prefix is either the system one, or defined 
> in $PYTHONPATH.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kf5options and qt5options manpages

[Jonathan Riddell]

Comments from dfaure on https://git.reviewboard.kde.org/r/115065/

>--caption caption
>Use caption as name in the titlebar.

"Still works with Qt5, but remove one dash.
Testcase:
   kate -caption KATE_KF5
"

>--config filename
>Use the alternative configuration filename

"this is gone [one can use XDG_CONFIG_HOME instead, I suppose]"
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

kf5options and qt5options manpages

[Jonathan Riddell]

kdeoptions and qtoptions manpages listed the common options to applications 
using kdelibs4 and qt4.

These have just become kf5options and qt5options.

But which options are still true?

>From qt5options:

   --display displayname
   Use the X-server display displayname.

   --session sessionId
   Restore the application for the given sessionId.

   --cmap
   Causes the application to install a private color map on an 8-bit 
display.

   --ncols count
   Limits the number of colors allocated in the color cube on an 8-bit 
display, if the application is using the
   QApplication::ManyColor color specification.

   --nograb
   Tells Qt(TM) to never grab the mouse or the keyboard.

   --dograb
   Running under a debugger can cause an implicit --nograb, use 
--dograb to override.

   --sync
   Switches to synchronous mode for debugging.

   --fn,--font fontname
   Defines the application font.

   --bg,--background color
   Sets the default background color and an application palette (light 
and dark shades are calculated).

   --fg,--foreground color
   Sets the default foreground color
   --btn,--button color
   Sets the default button color.

   --name name
   Sets the application name.

   --title title
   Sets the application title (caption).

   --visual TrueColor
   Forces the application to use a TrueColor visual on an 8-bit display.

   --inputstyle inputstyle
   Sets XIM (X Input Method) input style. Possible values are 
onthespot, overthespot, offthespot and root.

   --im XIM server
   Set XIM server.

   --noxim
   Disable XIM

   --reverse
   mirrors the whole layout of widgets

   --stylesheet file.qss
   applies the Qt stylesheet to the application widgets

>From kf5options:

   --caption caption
   Use caption as name in the titlebar.

   --icon icon
   Use icon as the application icon.

   --config filename
   Use the alternative configuration filename

   --nocrashhandler
   Disable the crash handler, to get core dumps.

   --waitforwm
   Waits for a WM_NET compatible windowmanager.

   --style style
   Sets the application GUI style.

   --geometry geometry
   Sets the client geometry of the main widget.


Jonathan
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115065/#review47918
---


This review has been submitted with commit 
84c78978a52cc490896013e7881f0a25e4aa5828 by Jonathan Riddell to branch master.

- Commit Hook


On Jan. 17, 2014, 4:48 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115065/
> ---
> 
> (Updated Jan. 17, 2014, 4:48 p.m.)
> 
> 
> Review request for Documentation, KDE Frameworks, Luigi Toscano, and Scarlett 
> Clark.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Rename man pages and checkXML tool to prevent clashes with kdelibs4
> credit should go to scarlett
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 74c7af5 
>   checkXML.in.cmake d7a57c7 
>   checkXML5.in.cmake PRE-CREATION 
>   docs/CMakeLists.txt 7e9612f 
>   docs/checkXML/CMakeLists.txt 7f8226c 
>   docs/checkXML/man-checkXML.1.docbook 2bfb3f3 
>   docs/checkXML5/CMakeLists.txt PRE-CREATION 
>   docs/checkXML5/man-checkXML5.1.docbook PRE-CREATION 
>   docs/kde5options/CMakeLists.txt PRE-CREATION 
>   docs/kde5options/man-kde5options.7.docbook PRE-CREATION 
>   docs/kdeoptions/CMakeLists.txt a91f451 
>   docs/kdeoptions/man-kdeoptions.7.docbook 7e62f41 
>   docs/qt5options/CMakeLists.txt PRE-CREATION 
>   docs/qt5options/man-qt5options.7.docbook PRE-CREATION 
>   docs/qtoptions/CMakeLists.txt f1dbb6c 
>   docs/qtoptions/man-qtoptions.7.docbook a00677a 
> 
> Diff: https://git.reviewboard.kde.org/r/115065/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115065/
---

(Updated Jan. 21, 2014, 6:35 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation, KDE Frameworks, Luigi Toscano, and Scarlett 
Clark.


Repository: kdoctools


Description
---

Rename man pages and checkXML tool to prevent clashes with kdelibs4
credit should go to scarlett


Diffs
-

  CMakeLists.txt 74c7af5 
  checkXML.in.cmake d7a57c7 
  checkXML5.in.cmake PRE-CREATION 
  docs/CMakeLists.txt 7e9612f 
  docs/checkXML/CMakeLists.txt 7f8226c 
  docs/checkXML/man-checkXML.1.docbook 2bfb3f3 
  docs/checkXML5/CMakeLists.txt PRE-CREATION 
  docs/checkXML5/man-checkXML5.1.docbook PRE-CREATION 
  docs/kde5options/CMakeLists.txt PRE-CREATION 
  docs/kde5options/man-kde5options.7.docbook PRE-CREATION 
  docs/kdeoptions/CMakeLists.txt a91f451 
  docs/kdeoptions/man-kdeoptions.7.docbook 7e62f41 
  docs/qt5options/CMakeLists.txt PRE-CREATION 
  docs/qt5options/man-qt5options.7.docbook PRE-CREATION 
  docs/qtoptions/CMakeLists.txt f1dbb6c 
  docs/qtoptions/man-qtoptions.7.docbook a00677a 

Diff: https://git.reviewboard.kde.org/r/115065/diff/


Testing
---


Thanks,

Jonathan Riddell

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114897: Make KDE_ENABLE_EXCEPTIONS a list

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114897/
---

(Updated Jan. 21, 2014, 6:14 p.m.)


Status
--

This change has been discarded.


Review request for Build System, Extra Cmake Modules, KDE Frameworks, and 
Stephen Kelly.


Repository: extra-cmake-modules


Description
---

Make KDE_ENABLE_EXCEPTIONS a list

When KDE_ENABLE_EXCEPTIONS contains two arguments, they are currently a
single string containing those space-separated arguments.  It can thus
be used as
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${KDE_ENABLE_EXCEPTIONS}")
However, the proper way to set compile flags these days is to use
add_compile_options, as in
add_compile_options(${KDE_ENABLE_EXCEPTIONS})
which requires KDE_ENABLE_EXCEPTIONS to be a list.

Note that this change means that setting CMAKE_CXX_FLAGS like above NO
LONGER WORKS (as you will get the argument
-fexceptions;-UQT_NO_EXCEPTIONS added for GCC and Clang).


Diffs
-

  kde-modules/KDECompilerSettings.cmake 
cd93e519dea4917a6c09df02bb32254f468c2861 

Diff: https://git.reviewboard.kde.org/r/114897/diff/


Testing
---

ThreadWeaver compiles under GCC on Linux if (and only if) I change the 
src/CMakeLists.txt file to use add_compile_options instead of setting 
CMAKE_CXX_FLAGS.


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115190: Add unit test for KWindowInfo on X11

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115190/
---

Review request for KDE Frameworks and Ben Cooksley.


Repository: kwindowsystem


Description
---

Add unit test for KWindowInfo on X11

Unit test for most methods provided by KWindowInfo. The general pattern
is to create a window, show it, test the property, change it and
verify that the change worked. This is a little bit tricky as the test
needs to interact with large parts of the window manager. In case a
property is updated by the window manager we need to send the client
message, wait till the window manager has reacted on it and updated
the property and then wait for the property update. This is mostly done
by waiting for the signal KWindowSystem::windowChanged. Unfortunately
that reports globally and not just for the window we are interested in.
So we have to filter out till we got the correct one. If there is at
the same time further interaction with the windowing system tests can
fail, but a re-run normally fixes it.

The unit test is so far written against KWin. It's possible that it
needs adjustments for succeeding on build.kde.org. Given that
KWindowInfo::actionSupported is not tested as that is clearly to
specific to the used window manager.

---

@Ben: is it possible that you try the patch on build.kde.org while it's under 
review, so that I can fix any possible failures.


Diffs
-

  autotests/CMakeLists.txt 58803aec9c807f68ff2bac227d0d9cf0305fa1f6 
  autotests/kwindowinfox11test.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/115190/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

[David Narváez]

> On Jan. 17, 2014, 6:51 p.m., Alex Merry wrote:
> > KF5DocToolsMacros.cmake, lines 166-172
> > 
> >
> > These should *not* be renamed, as they are compatibility macros.  
> > However, they should probably be moved to kde4support.
> 
> Aleix Pol Gonzalez wrote:
> I wouldn't rename it indeed.
> 
> Moving it to KDE4Support can be good indeed, although it kind of defeats 
> the purpose, as you'll need to actually depend on KDE4Support to get the 
> warning.
> 
> David Narváez wrote:
> Luigi, your call.
> 
> Alex Merry wrote:
> Well, most projects will start off depending on KDE4Support anyway, and 
> if you don't use it I think you should just get an error about the macro not 
> being found.
> 
> Luigi Toscano wrote:
> My thoughts:
> - is the dependency on KDE4Support the first thing a ported application 
> should do? If yes, then the macros can be kept and moved; but please read on;
> - KDE4_CREATE_HTML_HANDBOOK can be completely removed. It has been 
> deprecated on Wed Aug 15 03:55:48 2007 +, 
> 82f7b6ba0f8be7d314ac780b9a873e98b6be39b2, and it is not used (apart from the 
> definition in kdelibs and kf5/kdoctools).
> - KDE4_CREATE_HANDBOOK should not be renamed, and it can be moved to 
> KDE4Support (I see that it was already renamed as KDOCTOOLS_CREATE_HANDBOOK 
> in the frameworks-based code)
> - I see KDE4_SERIALIZE_TOOL has been renamed as well; but it is defined 
> in KDE4Support:
> 
> http://lxr.kde.org/source/frameworks/kde4support/cmake/modules/FindKDE4Internal.cmake#455
> I'm not sure how to deal with this: probably it would be better to define 
> it here and rename it as KDOCTOOLS_blabla.
> 
> Does it make sense?
> 
> Alex Merry wrote:
> In general, yes, the first thing a ported application will do is replace 
> the lines to search for kdelibs4 with lines to find KDE4Support (and other 
> frameworks).
> 
> I agree that KDE4_CREATE_HTML_HANDBOOK should be removed (along with any 
> other macro that didn't actually do anything in kdelibs4).  If 
> KDE4_CREATE_HANDBOOK was a useful macro in kdelibs4, it should move to 
> kde4support (and either be defined as it is here, or forward to 
> KDOCTOOLS_CREATE_HANDBOOK).
> 
> I have no idea how the KDE4_SERIALIZE_TOOL thing is supposed to work, so 
> I can't comment on that.
> 
> Luigi Toscano wrote:
> KDE4_SERIALIZE_TOOL is used only here (kdoctools); I suggest to rename it 
> as KDOCTOOLS_SERIALIZE_TOOL and add its definition (see 
> http://lxr.kde.org/source/kde/kdelibs/cmake/modules/FindKDE4Internal.cmake#721).
> 
> KDE4_CREATE_HANDBOOK is used everytime there is documentation in 
> kdelibs4-based applications, so yes, we need to keep it somehow for migration 
> purposes :)

I'll split this RR into several others covering those changes.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115077/#review47592
---


On Jan. 18, 2014, 1:16 p.m., David Narváez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115077/
> ---
> 
> (Updated Jan. 18, 2014, 1:16 p.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Part of the overall task of removing mentions of KDE4 from the code.
> 
> 
> Diffs
> -
> 
>   KF5DocToolsMacros.cmake 191a2c5 
> 
> Diff: https://git.reviewboard.kde.org/r/115077/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Narváez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115189: rename dbus interface files for kstatusnotifier

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115189/
---

Review request for KDE Frameworks and Martin Klapetek.


Repository: knotifications


Description
---

Rename dbus interface files on install, but keep the same dbus interface.  This 
prevents files clashing with kdelibs4 equivalents but maintains the specified 
interface.


Diffs
-

  src/CMakeLists.txt 5d731eb 

Diff: https://git.reviewboard.kde.org/r/115189/diff/


Testing
---


Thanks,

Jonathan Riddell

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114908: Use add_definitions directly, instead of via _KDE4_PLATFORM_DEFINITIONS

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114908/#review47909
---


This review has been submitted with commit 
8b055d7f229d6596cf15d045b85ec937f8e2abe8 by Alex Merry to branch master.

- Commit Hook


On Jan. 19, 2014, 1:21 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114908/
> ---
> 
> (Updated Jan. 19, 2014, 1:21 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Use add_definitions directly, instead of via _KDE4_PLATFORM_DEFINITIONS
> 
> Setting the variable just leads to set() calls overwriting each other
> accidentally (as appeared to have happened in the WIN32 block).
> 
> 
> Diffs
> -
> 
>   kde-modules/KDECompilerSettings.cmake 
> 6adbc069bf314ae1a462ffbc5abe25264dac0ac2 
> 
> Diff: https://git.reviewboard.kde.org/r/114908/diff/
> 
> 
> Testing
> ---
> 
> KCoreAddons still compiles, and "make VERBOSE=1" shows that it is setting 
> -D_BSD_SOURCE -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500, as 
> expected.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114908: Use add_definitions directly, instead of via _KDE4_PLATFORM_DEFINITIONS

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114908/
---

(Updated Jan. 21, 2014, 5:33 p.m.)


Status
--

This change has been marked as submitted.


Review request for Build System, Extra Cmake Modules and KDE Frameworks.


Repository: extra-cmake-modules


Description
---

Use add_definitions directly, instead of via _KDE4_PLATFORM_DEFINITIONS

Setting the variable just leads to set() calls overwriting each other
accidentally (as appeared to have happened in the WIN32 block).


Diffs
-

  kde-modules/KDECompilerSettings.cmake 
6adbc069bf314ae1a462ffbc5abe25264dac0ac2 

Diff: https://git.reviewboard.kde.org/r/114908/diff/


Testing
---

KCoreAddons still compiles, and "make VERBOSE=1" shows that it is setting 
-D_BSD_SOURCE -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500, as 
expected.


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115134: Append 5 to kjscmd & it's manpage

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115134/#review47905
---


This review has been submitted with commit 
a310819d576e267e54bd5c965eeda78afb87ed9b by Hrvoje Senjan to branch master.

- Commit Hook


On Jan. 21, 2014, 4:43 p.m., Hrvoje Senjan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115134/
> ---
> 
> (Updated Jan. 21, 2014, 4:43 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kjsembed
> 
> 
> Description
> ---
> 
> Patch to make kjsembed not collide with kdelibs(4) when installed to same 
> prefix.
> Additionally, adjusted manpage to reference kjs5 instead of kjs, as that 
> binary has been renamed.
> 
> 
> Diffs
> -
> 
>   docs/kjscmd/man-kjscmd5.1.docbook PRE-CREATION 
>   docs/kjscmd/man-kjscmd.1.docbook 5a7fd02 
>   docs/kjscmd/CMakeLists.txt eda31bf 
>   src/kjscmd/CMakeLists.txt a659f0f 
> 
> Diff: https://git.reviewboard.kde.org/r/115134/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115185: Integrate kf5dot

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115185/#review47903
---


- files should have licenses and encoding marks
- "kf5dot" is not very descriptive as a name.  I would call the module 
"dependencies" or "depdiags" or something like that, and the scripts something 
similar but with a k or kf5 prefix
- it would be nice if kgenframeworksapidox could do all the magic itself, when 
suitable option(s) are passed (although that can be something to implement 
later)


src/kapidox/kf5dot/.gitignore


Unnecessary; kapidox has a top-level .gitignore that already does this


Another option for merging histories is 
http://thread.gmane.org/gmane.comp.version-control.git/5126/ (with some 
modifications; in particular, git-*-cache is now git-*-index).  But that 
depends on how much you care about preserving commit shasums.

In general, though, I approve :-)

- Alex Merry


On Jan. 21, 2014, 4:58 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115185/
> ---
> 
> (Updated Jan. 21, 2014, 4:58 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kapidox
> 
> 
> Description
> ---
> 
> This big patch includes all of the kf5dot repository inside kapidox. Python 
> code is in src/kapidox/kf5dot, scripts are in src/.
> 
> I replayed all the commits from the kf5dot repository within the kapidox 
> repository using `git am` to avoid loosing history. As such, I plan to do the 
> merge using --no-ff.
> 
> 
> Diffs
> -
> 
>   src/kapidox/kf5dot/frameworkdb.py PRE-CREATION 
>   src/kf5dot-generate PRE-CREATION 
>   src/kf5dot-generate-all PRE-CREATION 
>   src/kf5dot-prepare PRE-CREATION 
>   README.md 660e9c3 
>   src/kapidox/kf5dot/framework.py PRE-CREATION 
>   setup.py 025afdb 
>   src/kapidox/kf5dot/.gitignore PRE-CREATION 
>   src/kapidox/kf5dot/block.py PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115185/diff/
> 
> 
> Testing
> ---
> 
> Generated all diagrams. Works as expected.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115134: Append 5 to kjscmd & it's manpage

[Hrvoje Senjan]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115134/
---

(Updated Jan. 21, 2014, 5:17 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kjsembed


Description
---

Patch to make kjsembed not collide with kdelibs(4) when installed to same 
prefix.
Additionally, adjusted manpage to reference kjs5 instead of kjs, as that binary 
has been renamed.


Diffs
-

  docs/kjscmd/man-kjscmd5.1.docbook PRE-CREATION 
  docs/kjscmd/man-kjscmd.1.docbook 5a7fd02 
  docs/kjscmd/CMakeLists.txt eda31bf 
  src/kjscmd/CMakeLists.txt a659f0f 

Diff: https://git.reviewboard.kde.org/r/115134/diff/


Testing
---

Builds.


Thanks,

Hrvoje Senjan

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Authors, maintainers and licenses in apidox

[Alex Merry]

Traditionally, the front pages of our apidox has included a list of
authors, the maintainer(s) and the license.  This is obviously
duplicating/summarising information stored elsewhere, and is easy to let
get out of date.

Do we still want this information?  It would probably mean adding it to
the README.md files.

Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115186: rename dbus interface file for kjobviewer

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115186/
---

Review request for KDE Frameworks.


Repository: kjobwidgets


Description
---

This dbus interface file also gets installed in kdelibs4 which overlaps it in 
kf5, some distros can not handle this.  So rename the file on install.  The 
dbus interface remains the same.  This is the same technique used for 
kglobalaccel.


Diffs
-

  src/CMakeLists.txt 7527a0a 

Diff: https://git.reviewboard.kde.org/r/115186/diff/


Testing
---


Thanks,

Jonathan Riddell

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115185: Integrate kf5dot

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115185/
---

Review request for KDE Frameworks and Alex Merry.


Repository: kapidox


Description
---

This big patch includes all of the kf5dot repository inside kapidox. Python 
code is in src/kapidox/kf5dot, scripts are in src/.

I replayed all the commits from the kf5dot repository within the kapidox 
repository using `git am` to avoid loosing history. As such, I plan to do the 
merge using --no-ff.


Diffs
-

  src/kapidox/kf5dot/frameworkdb.py PRE-CREATION 
  src/kf5dot-generate PRE-CREATION 
  src/kf5dot-generate-all PRE-CREATION 
  src/kf5dot-prepare PRE-CREATION 
  README.md 660e9c3 
  src/kapidox/kf5dot/framework.py PRE-CREATION 
  setup.py 025afdb 
  src/kapidox/kf5dot/.gitignore PRE-CREATION 
  src/kapidox/kf5dot/block.py PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/115185/diff/


Testing
---

Generated all diagrams. Works as expected.


Thanks,

Aurélien Gâteau

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115186: rename dbus interface file for kjobviewer

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115186/#review47902
---


https://git.reviewboard.kde.org/r/115188/  kde-workspace update to match

- Jonathan Riddell


On Jan. 21, 2014, 5:02 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115186/
> ---
> 
> (Updated Jan. 21, 2014, 5:02 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kjobwidgets
> 
> 
> Description
> ---
> 
> This dbus interface file also gets installed in kdelibs4 which overlaps it in 
> kf5, some distros can not handle this.  So rename the file on install.  The 
> dbus interface remains the same.  This is the same technique used for 
> kglobalaccel.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 7527a0a 
> 
> Diff: https://git.reviewboard.kde.org/r/115186/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115166: Add a CMakeLists.txt which wraps python setup.py

[Alex Merry]

> On Jan. 21, 2014, 2:57 p.m., David Faure wrote:
> > Note that I fixed the "build failure with kdesrc-build" differently - I 
> > added a "ignore-modules kapidox" in kdesrc-build's include files.
> > 
> > And I don't like that this will break when using a custom prefix and 
> > PYTHONPATH is not set (which is the case here).
> >
> 
> Alex Merry wrote:
> You can't really avoid that with Python packages; you can install them 
> with --user and make sure your PATH is set correctly, or you can install them 
> with a prefix and make sure your PYTHONPATH is set correctly (or there are a 
> couple of other ways of telling python about custom site package dirs).
> 
> Well, or you can install them in a standard location, such as for distro 
> packages.
> 
> Aurélien Gâteau wrote:
> Note that the breakage is at runtime, not install time. But since 
> kdesrc-build now ignores kapidox, maybe it's simpler to discard this patch? 
> That's one less piece to maintain.

Sure; I have no opinion on it either way, TBH.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115166/#review47881
---


On Jan. 21, 2014, 1:49 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115166/
> ---
> 
> (Updated Jan. 21, 2014, 1:49 p.m.)
> 
> 
> Review request for Build System, KDE Frameworks and Alex Merry.
> 
> 
> Repository: kapidox
> 
> 
> Description
> ---
> 
> To fix build failures with kdesrc-build, add a CMakeLists.txt which wraps 
> python setup.py.
> 
> 
> Diffs
> -
> 
>   README.md 660e9c3 
>   CMakeLists.txt PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115166/diff/
> 
> 
> Testing
> ---
> 
> Built and installed with the classic CMake commands. The kapidox tools work 
> fine as long as the installation prefix is either the system one, or defined 
> in $PYTHONPATH.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115134: Append 5 to kjscmd & it's manpage

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115134/#review47899
---

Ship it!


Ship It!

- Jonathan Riddell


On Jan. 21, 2014, 4:43 p.m., Hrvoje Senjan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115134/
> ---
> 
> (Updated Jan. 21, 2014, 4:43 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kjsembed
> 
> 
> Description
> ---
> 
> Patch to make kjsembed not collide with kdelibs(4) when installed to same 
> prefix.
> Additionally, adjusted manpage to reference kjs5 instead of kjs, as that 
> binary has been renamed.
> 
> 
> Diffs
> -
> 
>   docs/kjscmd/man-kjscmd5.1.docbook PRE-CREATION 
>   docs/kjscmd/man-kjscmd.1.docbook 5a7fd02 
>   docs/kjscmd/CMakeLists.txt eda31bf 
>   src/kjscmd/CMakeLists.txt a659f0f 
> 
> Diff: https://git.reviewboard.kde.org/r/115134/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115134: Append 5 to kjscmd & it's manpage

[Hrvoje Senjan]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115134/
---

(Updated Jan. 21, 2014, 4:43 p.m.)


Review request for KDE Frameworks.


Changes
---

Fix mentioned issue


Repository: kjsembed


Description
---

Patch to make kjsembed not collide with kdelibs(4) when installed to same 
prefix.
Additionally, adjusted manpage to reference kjs5 instead of kjs, as that binary 
has been renamed.


Diffs (updated)
-

  docs/kjscmd/man-kjscmd5.1.docbook PRE-CREATION 
  docs/kjscmd/man-kjscmd.1.docbook 5a7fd02 
  docs/kjscmd/CMakeLists.txt eda31bf 
  src/kjscmd/CMakeLists.txt a659f0f 

Diff: https://git.reviewboard.kde.org/r/115134/diff/


Testing
---

Builds.


Thanks,

Hrvoje Senjan

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115134: Append 5 to kjscmd & it's manpage

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115134/#review47897
---


looks good, ksjcmd is just a developer binary so nothing else needs a rename to 
use it
a couple more changes in the man page and it's good
"The most common way to run kjscmd is simply as" "The most common way to run 
kjscmd is simply as"

- Jonathan Riddell


On Jan. 19, 2014, 10:57 p.m., Hrvoje Senjan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115134/
> ---
> 
> (Updated Jan. 19, 2014, 10:57 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kjsembed
> 
> 
> Description
> ---
> 
> Patch to make kjsembed not collide with kdelibs(4) when installed to same 
> prefix.
> Additionally, adjusted manpage to reference kjs5 instead of kjs, as that 
> binary has been renamed.
> 
> 
> Diffs
> -
> 
>   docs/kjscmd/CMakeLists.txt eda31bf 
>   docs/kjscmd/man-kjscmd.1.docbook 5a7fd02 
>   docs/kjscmd/man-kjscmd5.1.docbook PRE-CREATION 
>   src/kjscmd/CMakeLists.txt a659f0f 
> 
> Diff: https://git.reviewboard.kde.org/r/115134/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115078: don't install dbus interface files in kglobalaccel

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115078/
---

(Updated Jan. 21, 2014, 4:24 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Martin Gräßlin.


Repository: kglobalaccel


Description
---

don't install dbus interface files in kglobalaccel, these overlap with the 
equivalent files in kdelibs4 which causes problems for some distributions


Diffs
-

  src/CMakeLists.txt d48e92e 

Diff: https://git.reviewboard.kde.org/r/115078/diff/


Testing
---


Thanks,

Jonathan Riddell

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115078: don't install dbus interface files in kglobalaccel

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115078/#review47894
---


This review has been submitted with commit 
fc7deb7e9d7a641495729380746821dae140fb6b by Jonathan Riddell to branch master.

- Commit Hook


On Jan. 21, 2014, 3:10 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115078/
> ---
> 
> (Updated Jan. 21, 2014, 3:10 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Gräßlin.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> ---
> 
> don't install dbus interface files in kglobalaccel, these overlap with the 
> equivalent files in kdelibs4 which causes problems for some distributions
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt d48e92e 
> 
> Diff: https://git.reviewboard.kde.org/r/115078/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115166: Add a CMakeLists.txt which wraps python setup.py

[Aurélien Gâteau]

> On Jan. 21, 2014, 3:57 p.m., David Faure wrote:
> > Note that I fixed the "build failure with kdesrc-build" differently - I 
> > added a "ignore-modules kapidox" in kdesrc-build's include files.
> > 
> > And I don't like that this will break when using a custom prefix and 
> > PYTHONPATH is not set (which is the case here).
> >
> 
> Alex Merry wrote:
> You can't really avoid that with Python packages; you can install them 
> with --user and make sure your PATH is set correctly, or you can install them 
> with a prefix and make sure your PYTHONPATH is set correctly (or there are a 
> couple of other ways of telling python about custom site package dirs).
> 
> Well, or you can install them in a standard location, such as for distro 
> packages.

Note that the breakage is at runtime, not install time. But since kdesrc-build 
now ignores kapidox, maybe it's simpler to discard this patch? That's one less 
piece to maintain.


- Aurélien


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115166/#review47881
---


On Jan. 21, 2014, 2:49 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115166/
> ---
> 
> (Updated Jan. 21, 2014, 2:49 p.m.)
> 
> 
> Review request for Build System, KDE Frameworks and Alex Merry.
> 
> 
> Repository: kapidox
> 
> 
> Description
> ---
> 
> To fix build failures with kdesrc-build, add a CMakeLists.txt which wraps 
> python setup.py.
> 
> 
> Diffs
> -
> 
>   README.md 660e9c3 
>   CMakeLists.txt PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115166/diff/
> 
> 
> Testing
> ---
> 
> Built and installed with the classic CMake commands. The kapidox tools work 
> fine as long as the installation prefix is either the system one, or defined 
> in $PYTHONPATH.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115166: Add a CMakeLists.txt which wraps python setup.py

[Alex Merry]

> On Jan. 21, 2014, 2:57 p.m., David Faure wrote:
> > Note that I fixed the "build failure with kdesrc-build" differently - I 
> > added a "ignore-modules kapidox" in kdesrc-build's include files.
> > 
> > And I don't like that this will break when using a custom prefix and 
> > PYTHONPATH is not set (which is the case here).
> >

You can't really avoid that with Python packages; you can install them with 
--user and make sure your PATH is set correctly, or you can install them with a 
prefix and make sure your PYTHONPATH is set correctly (or there are a couple of 
other ways of telling python about custom site package dirs).

Well, or you can install them in a standard location, such as for distro 
packages.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115166/#review47881
---


On Jan. 21, 2014, 1:49 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115166/
> ---
> 
> (Updated Jan. 21, 2014, 1:49 p.m.)
> 
> 
> Review request for Build System, KDE Frameworks and Alex Merry.
> 
> 
> Repository: kapidox
> 
> 
> Description
> ---
> 
> To fix build failures with kdesrc-build, add a CMakeLists.txt which wraps 
> python setup.py.
> 
> 
> Diffs
> -
> 
>   README.md 660e9c3 
>   CMakeLists.txt PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115166/diff/
> 
> 
> Testing
> ---
> 
> Built and installed with the classic CMake commands. The kapidox tools work 
> fine as long as the installation prefix is either the system one, or defined 
> in $PYTHONPATH.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115078: don't install dbus interface files in kglobalaccel

[Hrvoje Senjan]

> On Jan. 21, 2014, 3:23 p.m., Martin Gräßlin wrote:
> > Ship It!

Many thanks to Jonathan for working on this, and Martin for giving a green 
light! ;-)


- Hrvoje


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115078/#review47887
---


On Jan. 21, 2014, 3:10 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115078/
> ---
> 
> (Updated Jan. 21, 2014, 3:10 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Gräßlin.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> ---
> 
> don't install dbus interface files in kglobalaccel, these overlap with the 
> equivalent files in kdelibs4 which causes problems for some distributions
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt d48e92e 
> 
> Diff: https://git.reviewboard.kde.org/r/115078/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KF5 Update Meeting Minutes 2014-w4

[Luigi Toscano]

On Tuesday 21 of January 2014 16:42:42 Kevin Ottens wrote:
>  * tosky found out that the validity of the qtoptions and kdeoptions man
> pages is in need of review;
>  * he's also working with the doc team toward a switch to docbook 4.2;
Quick patch: to docbook 4.5 (our documentation is based on 4.2 now).

Ciao
-- 
Luigi

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

KF5 Update Meeting Minutes 2014-w4

[Kevin Ottens]

Hello everyone,

This is the minutes of the Week 3 KF5 meeting. As usual it has been held on 
#kde-devel at 4pm Paris time.

Were present: afiestas, agateau, alexmerry, arichardson, dfaure, mgraesslin, 
Riddell, tosky and myself.

Announcement:
 * Come on people, we're still short on maintainers!
 * Aiming at a frameworks sprint somewhen in spring;
 * Don't forget that Alpha 1 is due for release next week;

 * afiestas signed up for maintaining kded;
 * he also wrote a proposal to split runtime and workspace:
   http://community.kde.org/Plasma/Tokamak7/split_proposal

 * agateau fixed ki18n so that tests would work without install;
 * he also worked on integrating kf5dot in kapidox;
 * he also created a todo list for the doc of the frameworks and the tooling;

 * alexmerry got the apidox script working;
 * he is about to remove all the Mainpage.dox files as the script won't need 
them (preserving useful content of course);
 * he's also working with ben to get the necessary deps on ebn to run the 
script;
 * he's also working on reducing the KDE stuff in ECM;

 * arichardson got almost all of KF5 building on windows, patches to follow;
 * he got to the point where okteta is running on windows:
   http://postimg.org/image/51gwpoxpf ;

 * dfaure is focusing on generating .pri files for qmake users;
 * he needs a review on https://git.reviewboard.kde.org/r/115099/ ;
 * he also started to fix kcrash use of command line options;

 * mgraesslin took over maintainership of kwindowsystem and kglobalaccel;
 * he's working on KWindowInfo unit tests;
 * he also plans to transform the classes to give them runtime platform 
detection for wayland;
 * he'll need help from windows and mac people if they don't want their 
implementations to break;

 * Riddell is working on coinstallability, especially around dbus interfaces;
 * he's also close of having tier 2 fully packaged, some parts of tier 3 being 
done already;

 * tosky found out that the validity of the qtoptions and kdeoptions man pages 
is in need of review;
 * he's also working with the doc team toward a switch to docbook 4.2;

 * ervin got a few more maintainers, still some positions open;
 * he also contacted afiestas for a sprint in Barcelona.

If you got questions, feel free to ask.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115078: don't install dbus interface files in kglobalaccel

[Jonathan Riddell]

> On Jan. 21, 2014, 3:16 p.m., Martin Gräßlin wrote:
> > something went wrong with the latest patch. CMake looks fine but it 
> > includes the renamed files.

Maybe I'm going mad but I don't see any renamed files in it.  Here's the same 
patch in a pastebin
http://paste.ubuntu.com/6792111/


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115078/#review47884
---


On Jan. 21, 2014, 3:10 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115078/
> ---
> 
> (Updated Jan. 21, 2014, 3:10 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Gräßlin.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> ---
> 
> don't install dbus interface files in kglobalaccel, these overlap with the 
> equivalent files in kdelibs4 which causes problems for some distributions
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt d48e92e 
> 
> Diff: https://git.reviewboard.kde.org/r/115078/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115078: don't install dbus interface files in kglobalaccel

[Martin Gräßlin]

> On Jan. 21, 2014, 4:16 p.m., Martin Gräßlin wrote:
> > something went wrong with the latest patch. CMake looks fine but it 
> > includes the renamed files.
> 
> Jonathan Riddell wrote:
> Maybe I'm going mad but I don't see any renamed files in it.  Here's the 
> same patch in a pastebin
> http://paste.ubuntu.com/6792111/

I blame review board. It showed me the new CMakeLists.txt but still the renamed 
files... Now it works.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115078/#review47884
---


On Jan. 21, 2014, 4:10 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115078/
> ---
> 
> (Updated Jan. 21, 2014, 4:10 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Gräßlin.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> ---
> 
> don't install dbus interface files in kglobalaccel, these overlap with the 
> equivalent files in kdelibs4 which causes problems for some distributions
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt d48e92e 
> 
> Diff: https://git.reviewboard.kde.org/r/115078/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115078: don't install dbus interface files in kglobalaccel

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115078/#review47887
---

Ship it!


Ship It!

- Martin Gräßlin


On Jan. 21, 2014, 4:10 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115078/
> ---
> 
> (Updated Jan. 21, 2014, 4:10 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Gräßlin.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> ---
> 
> don't install dbus interface files in kglobalaccel, these overlap with the 
> equivalent files in kdelibs4 which causes problems for some distributions
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt d48e92e 
> 
> Diff: https://git.reviewboard.kde.org/r/115078/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel