D8920: Fixes url navigation with relative links on KUrlNavigator
dfaure added a comment. Sounds to me like ~/foo should always mean $HOME/foo even if that doesn't exist. INLINE COMMENTS > kurlnavigatortest.cpp:207 > + > +QTest::newRow("relativeFile") << QStringLiteral(".some_dotfile") << > QUrl::fromUserInput(".some_dotfile", QLatin1String(""), > QUrl::AssumeLocalFile); > +QTest::newRow("relativeDir") << QStringLiteral("some_directory") << > QUrl::fromUserInput("some_directory", QLatin1String(""), > QUrl::AssumeLocalFile); I think this should have a clear expected value, not the same call as the implementation, which is then not testing the actual behavior; it's like checking that a==a, but not the value of a. I mean, to me it's unclear what fromUserInput(3 args) does when the 2nd arg is QLatin1String("") (yes, even though I actually wrote that method!). Why QLatin1String("")? Does it behave any different when called with QString() instead? In any case, these are questions for the implementation. Here it should be a clear hardcoded expected value (well using QDir::homePath and QUrl::fromLocalFile if necessary, of course). > kurifilter.cpp:270 > > KUriFilterData::KUriFilterData(const QString &url) > +: d(new KUriFilterDataPrivate(QUrl::fromUserInput(url, > QLatin1String(""), QUrl::AssumeLocalFile), url)) I would very very much like that KUriFilterData is left untouched if possible. Is there no way do call this in the caller instead? (which would then call the QUrl method) The whole point of KUriFilterData was to not have any string-url conversion logic itself, but leave that to the actual uri filters. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8920 To: emateli, #frameworks, dfaure Cc: #frameworks
KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 - Build # 3 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.10/3/ Project: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 Date of build: Fri, 01 Dec 2017 21:35:46 + Build duration: 10 min and counting JUnit Tests Name: (root) Failed: 5 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-compositingenabled_testFailed: TestSuite.kwindowsystem-kwindoweffectstestFailed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-kwindowsystem_threadtestFailed: TestSuite.kwindowsystem-kwindowsystemx11test Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report67% (4/6)64% (38/59)64% (38/59)62% (5909/9531)42% (3171/7506)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests89% (16/18)89% (16/18)85% (2673/3161)43% (1458/3359)autotests.helper100% (1/1)100% (1/1)70% (7/10)50% (3/6)src75% (12/16)75% (12/16)53% (733/1396)37% (277/747)src.platforms.wayland0% (0/3)0% (0/3)0% (0/71)100% (0/0)src.platforms.xcb56% (9/16)56% (9/16)54% (2496/4614)43% (1433/3344)tests0% (0/5)0% (0/5)0% (0/279)0% (0/50)
KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.7 - Build # 39 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.7/39/ Project: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 01 Dec 2017 21:35:46 + Build duration: 10 min and counting JUnit Tests Name: (root) Failed: 5 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: TestSuite.kwindowsystem-compositingenabled_testFailed: TestSuite.kwindowsystem-kwindoweffectstestFailed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-kwindowsystem_threadtestFailed: TestSuite.kwindowsystem-kwindowsystemx11test
KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.7 - Build # 2 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.7/2/ Project: Frameworks kwindowsystem kf5-qt5 SUSEQt5.7 Date of build: Fri, 01 Dec 2017 21:35:46 + Build duration: 10 min and counting JUnit Tests Name: (root) Failed: 5 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-compositingenabled_testFailed: TestSuite.kwindowsystem-kwindoweffectstestFailed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-kwindowsystem_threadtestFailed: TestSuite.kwindowsystem-kwindowsystemx11test Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report67% (4/6)64% (38/59)64% (38/59)62% (5909/9531)42% (3171/7506)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests89% (16/18)89% (16/18)85% (2673/3161)43% (1458/3359)autotests.helper100% (1/1)100% (1/1)70% (7/10)50% (3/6)src75% (12/16)75% (12/16)53% (733/1396)37% (277/747)src.platforms.wayland0% (0/3)0% (0/3)0% (0/71)100% (0/0)src.platforms.xcb56% (9/16)56% (9/16)54% (2496/4614)43% (1433/3344)tests0% (0/5)0% (0/5)0% (0/279)0% (0/50)
D9086: [KWindowEffectsPrivateX11] Add reserve() call
This revision was automatically updated to reflect the committed changes. Closed by commit R278:b82e40fb2fc1: [KWindowEffectsPrivateX11] Add reserve() call (authored by broulik). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9086?vs=23213&id=23236 REVISION DETAIL https://phabricator.kde.org/D9086 AFFECTED FILES src/platforms/xcb/kwindoweffects.cpp To: broulik, #plasma, graesslin Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
Re: KDE Frameworks on Android
Am 01.12.2017 um 21:27 schrieb Aleix Pol: > On Thu, Nov 30, 2017 at 10:16 PM, Ralf Habacker > wrote: >> Am 30.11.2017 um 21:21 schrieb Aleix Pol: >>> Hi, >>> Recently I put together some CI for Android, where some frameworks are >>> being checked to _build_ for Android + ARM. >>> >>> Now there's many frameworks that can't be built at the moment, you can >>> see them listed here: >>> https://phabricator.kde.org/source/sysadmin-ci-tooling/browse/master/local-metadata/project-ignore-rules.yaml >>> >>> As you can see most of them it's because of dbus, >> Hi, >> >> you are refering to QtDBus - which could not be build because no dbus >> for android is there - or raw dbus for android ? > I am referring to QtDBus in this case. > But also dbus is not part of the NDK. I guess that QtDBus on Android could be build with dbus support after dbus has been added to the KDE CI. DBus could be cross build for android out of the box. I filed a bug for adding a related readme to dbus source (see https://bugs.freedesktop.org/show_bug.cgi?id=104022) Ralf
Re: KDE Frameworks on Android
On Thu, Nov 30, 2017 at 10:16 PM, Ralf Habacker wrote: > Am 30.11.2017 um 21:21 schrieb Aleix Pol: >> Hi, >> Recently I put together some CI for Android, where some frameworks are >> being checked to _build_ for Android + ARM. >> >> Now there's many frameworks that can't be built at the moment, you can >> see them listed here: >> https://phabricator.kde.org/source/sysadmin-ci-tooling/browse/master/local-metadata/project-ignore-rules.yaml >> >> As you can see most of them it's because of dbus, > Hi, > > you are refering to QtDBus - which could not be build because no dbus > for android is there - or raw dbus for android ? I am referring to QtDBus in this case. But also dbus is not part of the NDK. Aleix
D8917: Reduce the amount of spurious property changes on ColorScope
apol updated this revision to Diff 23233. apol added a comment. Fix david's comment REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8917?vs=23202&id=23233 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8917 AFFECTED FILES src/declarativeimports/core/colorscope.cpp src/declarativeimports/core/colorscope.h To: apol, #plasma, mart, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9049: Compile with stricter compilation flags
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH fix_strict_compile REVISION DETAIL https://phabricator.kde.org/D9049 To: mlaurent, dfaure Cc: apol, #frameworks
KDE CI: Frameworks kparts kf5-qt5 SUSEQt5.10 - Build # 4 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kparts%20kf5-qt5%20SUSEQt5.10/4/ Project: Frameworks kparts kf5-qt5 SUSEQt5.10 Date of build: Fri, 01 Dec 2017 19:34:41 + Build duration: 11 min and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report67% (2/3)36% (20/55)36% (20/55)22% (628/2833)13% (206/1534)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (3/3)100% (3/3)94% (188/199)49% (92/186)src39% (17/44)39% (17/44)19% (440/2301)9% (114/1264)tests0% (0/8)0% (0/8)0% (0/333)0% (0/84)
KDE CI: Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9 - Build # 19 - Still unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20WindowsMSVCQt5.9/19/ Project: Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9 Date of build: Fri, 01 Dec 2017 19:30:20 + Build duration: 3 min 59 sec and counting JUnit Tests Name: (root) Failed: 3 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: TestSuite.externalextractortestFailed: TestSuite.externalwritertestFailed: TestSuite.qtmultimediaextractortest
[kfilemetadata] autotests: The usermetadatawritertest requires Taglib.
Git commit 6c9111a952fb7c70c864b663d25080e418a0222c by Ben Cooksley. Committed on 01/12/2017 at 19:29. Pushed by bcooksley into branch 'master'. The usermetadatawritertest requires Taglib. Therefore if Taglib isn't around, we shouldn't try to build something that requires it. This fixes the build on Windows. CCMAIL: smithj...@gmail.com CCMAIL: kde-frameworks-devel@kde.org M +9-5autotests/CMakeLists.txt https://commits.kde.org/kfilemetadata/6c9111a952fb7c70c864b663d25080e418a0222c diff --git a/autotests/CMakeLists.txt b/autotests/CMakeLists.txt index 68f3778..cb7f3b9 100644 --- a/autotests/CMakeLists.txt +++ b/autotests/CMakeLists.txt @@ -152,11 +152,15 @@ ecm_add_test(${extractorcollection_SRCS} # UserMetaData # -kde_enable_exceptions() -ecm_add_test(usermetadatawritertest.cpp ../src/usermetadata.cpp -TEST_NAME "usermetadatawritertest" -LINK_LIBRARIES Qt5::Test KF5::FileMetaData -) +if(TAGLIB_FOUND) +include_directories(${TAGLIB_INCLUDES}) + +kde_enable_exceptions() +ecm_add_test(usermetadatawritertest.cpp ../src/usermetadata.cpp +TEST_NAME "usermetadatawritertest" +LINK_LIBRARIES Qt5::Test KF5::FileMetaData +) +endif() # # TagLib
D9092: Group some blocking dbus calls
graesslin accepted this revision. REPOSITORY R268 KGlobalAccel BRANCH master REVISION DETAIL https://phabricator.kde.org/D9092 To: apol, #frameworks, #plasma, davidedmundson, graesslin Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9092: Group some blocking dbus calls
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R268 KGlobalAccel BRANCH master REVISION DETAIL https://phabricator.kde.org/D9092 To: apol, #frameworks, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9092: Group some blocking dbus calls
apol created this revision. apol added reviewers: Frameworks, Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Calling KGlobalAccel::setDefaultShortcut would do few blocking calls one after the other. This reuses some of the values as we are essentially doing the same call twice with a small difference between them TEST PLAN Test still passes, my system still seems to work REPOSITORY R268 KGlobalAccel BRANCH master REVISION DETAIL https://phabricator.kde.org/D9092 AFFECTED FILES src/kglobalaccel.cpp src/kglobalaccel_p.h To: apol, #frameworks, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9086: [KWindowEffectsPrivateX11] Add reserve() call
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D9086 To: broulik, #plasma, graesslin Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
KDE CI: Frameworks kdnssd kf5-qt5 FreeBSDQt5.7 - Build # 23 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdnssd%20kf5-qt5%20FreeBSDQt5.7/23/ Project: Frameworks kdnssd kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 01 Dec 2017 17:34:54 + Build duration: 40 sec and counting
KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.7 - Build # 2 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.7/2/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.7 Date of build: Fri, 01 Dec 2017 16:16:53 + Build duration: 8 min 51 sec and counting JUnit Tests Name: (root) Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (5/5)96% (23/24)96% (23/24)73% (1541/2098)52% (1188/2303)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (10/10)100% (10/10)100% (500/502)52% (303/588)autotests.mockdepresolver100% (1/1)100% (1/1)78% (14/18)58% (7/12)src.kpackage75% (3/4)75% (3/4)73% (537/734)63% (606/967)src.kpackage.private100% (6/6)100% (6/6)79% (289/364)53% (120/226)src.kpackagetool100% (3/3)100% (3/3)42% (201/480)30% (152/510)
KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 2 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/2/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Fri, 01 Dec 2017 16:16:53 + Build duration: 6 min 9 sec and counting JUnit Tests Name: (root) Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (5/5)96% (23/24)96% (23/24)73% (1541/2098)52% (1188/2303)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (10/10)100% (10/10)100% (500/502)52% (303/588)autotests.mockdepresolver100% (1/1)100% (1/1)78% (14/18)58% (7/12)src.kpackage75% (3/4)75% (3/4)73% (537/734)63% (606/967)src.kpackage.private100% (6/6)100% (6/6)79% (289/364)53% (120/226)src.kpackagetool100% (3/3)100% (3/3)42% (201/480)30% (152/510)
KDE CI: Frameworks kpackage kf5-qt5 AndroidQt5.9 - Build # 5 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20AndroidQt5.9/5/ Project: Frameworks kpackage kf5-qt5 AndroidQt5.9 Date of build: Fri, 01 Dec 2017 16:16:53 + Build duration: 3 min 19 sec and counting
KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.7 - Build # 39 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.7/39/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 01 Dec 2017 16:16:53 + Build duration: 1 min 33 sec and counting JUnit Tests Name: (root) Failed: 4 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: TestSuite.plasma-packagestructuretestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
D8917: Reduce the amount of spurious property changes on ColorScope
mart added a comment. ah, you are right, yes, it should do checkcologgroupchanged instead REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8917 To: apol, #plasma, mart, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8917: Reduce the amount of spurious property changes on ColorScope
davidedmundson added inline comments. INLINE COMMENTS > mart wrote in colorscope.cpp:193 > this is when the item changes window and we're not sure we are still in the > same color set, so i think is ok to keep this signal yeah, my point was we may /also/ need the colorsChanged signal (via checkColorGroupChanged) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8917 To: apol, #plasma, mart, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8917: Reduce the amount of spurious property changes on ColorScope
mart accepted this revision. mart added inline comments. INLINE COMMENTS > davidedmundson wrote in colorscope.cpp:193 > check here. this is when the item changes window and we're not sure we are still in the same color set, so i think is ok to keep this signal REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8917 To: apol, #plasma, mart, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 13 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/13/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Fri, 01 Dec 2017 14:44:31 + Build duration: 52 min and counting JUnit Tests Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report33% (6/18)35% (56/159)35% (56/159)27% (3560/13212)19% (1967/10371)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests85% (22/26)85% (22/26)54% (609/1130)28% (419/1474)src.declarativeimports.calendar0% (0/11)0% (0/11)0% (0/448)0% (0/237)src.declarativeimports.core22% (4/18)22% (4/18)12% (250/2126)7% (95/1412)src.declarativeimports.plasmacomponents0% (0/9)0% (0/9)0% (0/522)0% (0/214)src.declarativeimports.plasmaextracomponents0% (0/5)0% (0/5)0% (0/44)0% (0/27)src.declarativeimports.platformcomponents0% (0/4)0% (0/4)0% (0/60)0% (0/14)src.declarativeimports.platformcomponents.utils0% (0/2)0% (0/2)0% (0/15)0% (0/4)src.plasma55% (12/22)55% (12/22)41% (1441/3486)28% (826/2903)src.plasma.packagestructure0% (0/7)0% (0/7)0% (0/141)0% (0/14)src.plasma.private46% (11/24)46% (11/24)42% (673/1614)28% (316/1115)src.plasma.scripting0% (0/3)0% (0/3)0% (0/161)0% (0/130)src.plasmapkg0% (0/1)0% (0/1)0% (0/45)0% (0/40)src.plasmaquick50% (6/12)50% (6/12)28% (556/1996)18% (306/1695)src.plasmaquick.private33% (1/3)33% (1/3)28% (31/110)36% (5/14)src.scriptengines.qml.plasmoid0% (0/6)0% (0/6)0% (0/1156)0% (0/1054)tests.dpi0% (0/2)0% (0/2)0% (0/22)0% (0/2)tests.kplugins0%
KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 10 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/10/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Fri, 01 Dec 2017 14:44:31 + Build duration: 52 min and counting JUnit Tests Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report33% (6/18)35% (56/159)35% (56/159)27% (3561/13216)19% (1968/10371)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests85% (22/26)85% (22/26)54% (609/1130)28% (419/1474)src.declarativeimports.calendar0% (0/11)0% (0/11)0% (0/448)0% (0/237)src.declarativeimports.core22% (4/18)22% (4/18)12% (251/2130)7% (96/1416)src.declarativeimports.plasmacomponents0% (0/9)0% (0/9)0% (0/522)0% (0/214)src.declarativeimports.plasmaextracomponents0% (0/5)0% (0/5)0% (0/44)0% (0/27)src.declarativeimports.platformcomponents0% (0/4)0% (0/4)0% (0/60)0% (0/14)src.declarativeimports.platformcomponents.utils0% (0/2)0% (0/2)0% (0/15)0% (0/4)src.plasma55% (12/22)55% (12/22)41% (1441/3486)28% (826/2899)src.plasma.packagestructure0% (0/7)0% (0/7)0% (0/141)0% (0/14)src.plasma.private46% (11/24)46% (11/24)42% (673/1614)28% (316/1115)src.plasma.scripting0% (0/3)0% (0/3)0% (0/161)0% (0/130)src.plasmapkg0% (0/1)0% (0/1)0% (0/45)0% (0/40)src.plasmaquick50% (6/12)50% (6/12)28% (556/1996)18% (306/1695)src.plasmaquick.private33% (1/3)33% (1/3)28% (31/110)36% (5/14)src.scriptengines.qml.plasmoid0% (0/6)0% (0/6)0% (0/1156)0% (0/1054)tests.dpi0% (0/2)0% (0/2)0% (0/22)0% (0/2)tests.kplugins0%
D8917: Reduce the amount of spurious property changes on ColorScope
davidedmundson added a comment. description needs updating with the new benefits (saving lookups every time) INLINE COMMENTS > colorscope.cpp:193 > if (value.window) { > emit colorGroupChanged(); > } check here. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8917 To: apol, #plasma, mart, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9085: Offer KAutostart::path
apol abandoned this revision. apol added a comment. Meh REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D9085 To: apol, #frameworks
KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 156 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/156/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 01 Dec 2017 14:44:31 + Build duration: 13 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest
D9070: KDE platform plugin: don't force default stylename on user-specified fonts
rjvbb added a comment. If you read https://bugreports.qt.io/browse/QTBUG-63792?focusedCommentId=381570 the take-home message seems to be that the platform theme plugin (and KDE in general) shouldn't be messing with setStyleName() at all UNLESS asking for a font with properties that cannot be represented in the old Panose system. Such fonts should probably be rare and a priori mostly encountered in very specific applications (Krita, Karbon and the like). REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9070 To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck Cc: ngraham, cfeck, fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9089: Suppress unnecessary scroll indicators if the flickable is a ListView with known orientation
This revision was automatically updated to reflect the committed changes. Closed by commit R242:4779f9564a4a: Suppress unnecessary scroll indicators if the flickable is a ListView with… (authored by hein). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9089?vs=23220&id=23221 REVISION DETAIL https://phabricator.kde.org/D9089 AFFECTED FILES src/declarativeimports/plasmastyle/ScrollViewStyle.qml To: hein, #plasma, mart, garg Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9089: Suppress unnecessary scroll indicators if the flickable is a ListView with known orientation
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D9089 To: hein, #plasma, mart, garg Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9089: Suppress unnecessary scroll indicators if the flickable is a ListView with known orientation
hein added a reviewer: garg. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9089 To: hein, #plasma, mart, garg Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9089: Suppress unnecessary scroll indicators if the flickable is a ListView with known orientation
hein created this revision. hein added reviewers: Plasma, mart. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY ListView.atYEnd is notoriously buggy and sometimes will cause indicators to blink in and out of existence where not needed. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D9089 AFFECTED FILES src/declarativeimports/plasmastyle/ScrollViewStyle.qml To: hein, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
KDE CI: Frameworks kdnssd kf5-qt5 FreeBSDQt5.7 - Build # 22 - Failure!
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kdnssd%20kf5-qt5%20FreeBSDQt5.7/22/ Project: Frameworks kdnssd kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 01 Dec 2017 12:47:44 + Build duration: 2 min 26 sec and counting CONSOLE OUTPUT [...truncated 145.45 KB...]gmake[2]: *** [src/CMakeFiles/KF5DNSSD.dir/build.make:216: src/CMakeFiles/KF5DNSSD.dir/avahi-servicebrowser.cpp.o] Error 1/usr/home/jenkins/workspace/Frameworks kdnssd kf5-qt5 FreeBSDQt5.7/src/avahi_server_interface.cpp:46:16: error: calling a private constructor of class 'QString'return QUrl::toAce(domain); ^/usr/local/include/qt5/QtCore/qstring.h:798:5: note: declared private hereQString(const QByteArray &a);^/usr/home/jenkins/workspace/Frameworks kdnssd kf5-qt5 FreeBSDQt5.7/src/avahi-publicservice.cpp:45:21: error: 'operator=' is a private member of 'QString'd->m_domain = "local.";~~~ ^ /usr/local/include/qt5/QtCore/qstring.h:799:14: note: declared private hereQString &operator=(const char *ch); ^/usr/home/jenkins/workspace/Frameworks kdnssd kf5-qt5 FreeBSDQt5.7/src/avahi-publicservice.cpp:164:59: error: calling a private constructor of class 'QString'm_group = new org::freedesktop::Avahi::EntryGroup("org.freedesktop.Avahi", rep.value().path(), QDBusConnection::systemBus()); ^/usr/local/include/qt5/QtCore/qstring.h:797:5: note: declared private hereQString(const char *ch);^/usr/home/jenkins/workspace/Frameworks kdnssd kf5-qt5 FreeBSDQt5.7/src/avahi-publicservice.cpp:244:59: error: calling a private constructor of class 'QString'd->m_server = new org::freedesktop::Avahi::Server("org.freedesktop.Avahi", "/", QDBusConnection::systemBus()); ^/usr/local/include/qt5/QtCore/qstring.h:797:5: note: declared private hereQString(const char *ch);^/usr/home/jenkins/workspace/Frameworks kdnssd kf5-qt5 FreeBSDQt5.7/src/avahi-publicservice.cpp:244:84: error: calling a private constructor of class 'QString'd->m_server = new org::freedesktop::Avahi::Server("org.freedesktop.Avahi", "/", QDBusConnection::systemBus()); ^/usr/local/include/qt5/QtCore/qstring.h:797:5: note: declared private hereQString(const char *ch);^1 error generated.gmake[2]: *** [src/CMakeFiles/KF5DNSSD.dir/build.make:312: src/CMakeFiles/KF5DNSSD.dir/avahi_server_interface.cpp.o] Error 1/usr/home/jenkins/workspace/Frameworks kdnssd kf5-qt5 FreeBSDQt5.7/src/avahi-remoteservice.cpp:60:39: error: calling a private constructor of class 'QString'org::freedesktop::Avahi::Server s("org.freedesktop.Avahi", "/", QDBusConnection::systemBus()); ^/usr/local/include/qt5/QtCore/qstring.h:797:5: note: declared private hereQString(const char *ch);^/usr/home/jenkins/workspace/Frameworks kdnssd kf5-qt5 FreeBSDQt5.7/src/avahi-remoteservice.cpp:60:64: error: calling a private constructor of class 'QString'org::freedesktop::Avahi::Server s("org.freedesktop.Avahi", "/", QDBusConnection::systemBus()); ^/usr/local/include/qt5/QtCore/qstring.h:797:5: note: declared private hereQString(const char *ch);^/usr/home/jenkins/workspace/Frameworks kdnssd kf5-qt5 FreeBSDQt5.7/src/avahi-remoteservice.cpp:69:96: error: calling a private constructor of class 'QString'org::freedesktop::Avahi::ServiceResolver *b = new org::freedesktop::Avahi::ServiceResolver("org.freedesktop.Avahi", rep.value().path(), ^/usr/local/include/qt5/QtCore/qstring.h:797:5: note: declared private hereQString(const char *ch);^/usr/home/jenkins/workspace/Frameworks kdnssd kf5-qt5 FreeBSDQt5.7/src/avahi-remoteservice.cpp:101:24: error: calling a private constructor of class 'QString'm_textData[x] = QByteArray(); ^/usr/local/include/qt5/QtCore/qstring.h:798:5: note: declared private hereQString(const QByteArray &a);^/usr/home/jenkins/workspace/Frameworks kdnssd kf5-qt5 FreeBSDQt5.7/src/avahi-remoteservice.cpp:103:24: error: calling a private constructor of class 'QString'm_textData[x.mid(0, pos)] = x.mid(pos + 1, x.size() - pos); ^/usr/local/include/qt5/QtCore/qstring.h:798:5: note: declared private hereQString(const QByteArray &a);^4 errors generated.gmake[2]: *** [src/CMakeFiles/KF5DNSSD.dir/build.make:264: src/CMakeFiles/KF5DNSSD.dir/avahi-publicservice.cpp.o] Error 15 errors generated.gmake[2]: *** [src/CMakeFiles/KF5DNSSD.dir/build.make:240: src/CMakeFiles/KF5DNSSD.dir/avahi-remoteservice.cpp.o] Error 1/usr/home/jenkins/workspace/Frameworks kdnssd kf5-qt5 FreeBSDQt5.7/src
D9086: [KWindowEffectsPrivateX11] Add reserve() call
broulik updated this revision to Diff 23213. broulik added a comment. - Take into account that below we're adding 16 additional items from rawData REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9086?vs=23212&id=23213 REVISION DETAIL https://phabricator.kde.org/D9086 AFFECTED FILES src/platforms/xcb/kwindoweffects.cpp To: broulik, #plasma, graesslin Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9086: [KWindowEffectsPrivateX11] Add reserve() call
broulik created this revision. broulik added reviewers: Plasma, graesslin. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY We know how many items we're going to add to the vector. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D9086 AFFECTED FILES src/platforms/xcb/kwindoweffects.cpp To: broulik, #plasma, graesslin Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9086: [KWindowEffectsPrivateX11] Add reserve() call
broulik edited the test plan for this revision. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D9086 To: broulik, #plasma, graesslin Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9085: Offer KAutostart::path
apol created this revision. apol added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY Explains which service file it's actually describing REPOSITORY R309 KService BRANCH master REVISION DETAIL https://phabricator.kde.org/D9085 AFFECTED FILES src/services/kautostart.cpp src/services/kautostart.h To: apol, #frameworks
D9028: [UDisks DeviceBackend] Slightly optimize
davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in udisksdevicebackend.cpp:67 > Similar code in different place had a comment > > // Delay connecting to DBus signals to avoid the related time penalty > // in hot paths such as predicate matching Never trust existing code. You're not going to get to process DBus events until we hit the event queue anyway. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D9028 To: broulik, #frameworks, davidedmundson Cc: apol
D9028: [UDisks DeviceBackend] Slightly optimize
broulik added inline comments. INLINE COMMENTS > apol wrote in udisksdevicebackend.cpp:67 > What do we gain by delaying dbus connection? Similar code in different place had a comment // Delay connecting to DBus signals to avoid the related time penalty // in hot paths such as predicate matching REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D9028 To: broulik, #frameworks, davidedmundson Cc: apol
D8917: Reduce the amount of spurious property changes on ColorScope
apol updated this revision to Diff 23202. apol added a comment. Move to tracking parents instead of doing a look-up on every color get REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8917?vs=22664&id=23202 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8917 AFFECTED FILES src/declarativeimports/core/colorscope.cpp src/declarativeimports/core/colorscope.h To: apol, #plasma, mart, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8920: Fixes url navigation with relative links on KUrlNavigator
emateli added a comment. Ping. Thoughts on the last comment? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8920 To: emateli, #frameworks, dfaure Cc: #frameworks