D17257: KateViewInternal: S

2018-12-05 Thread Christoph Cullmann 
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:87bcf0f51270: KateViewInternal: SR (authored by 
loh.tar, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17257?vs=46561=46909

REVISION DETAIL
  https://phabricator.kde.org/D17257

AFFECTED FILES
  src/view/kateviewinternal.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17257: KateViewInternal: S

2018-12-05 Thread Christoph Cullmann 
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  No, I was just busy ;=)
  Diff looks ok, will apply.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17257

To: loh.tar, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17257: KateViewInternal: S

2018-12-05 Thread loh tar 
loh.tar added a comment.


  @cullmann Did you notice this? The other patches did you apply very quick, so 
I hope I didn't unsettle you with my comments.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17257

To: loh.tar, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17257: KateViewInternal: S

2018-11-30 Thread loh tar 
loh.tar added a comment.


  Only 'm_view->' => 'view()' has plenty of hits, the others only a few.
  
  Please do a grep for m_startPos. To replace these few would  require a 
changed or added function.
  
  Last note: I hope you test all these changes thoroughly. At the last 
mentioned m_startPos S was suddenly the scrolling broken: Hence undo to only 
one change.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17257

To: loh.tar, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17257: KateViewInternal: S

2018-11-30 Thread loh tar 
loh.tar created this revision.
loh.tar added reviewers: KTextEditor, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  - 'm_view->' => 'view()'
  - 'm_startPos.line()' => 'startLine()'
  - 'm_startX' => 'startX()'
  - 'startPos().line()' => 'startLine()'
  - 'm_startPos' => 'startPos()'

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17257

AFFECTED FILES
  src/view/kateviewinternal.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann