Re: Review Request 115234: Only set QT_STRICT_ITERATORS when not compiling with MSVC
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/#review48092 --- Ship it! Oh, OK, didn't know this was broken on MSVC. Worth a Qt fix or at least bugreport? - David Faure On Jan. 22, 2014, 5:51 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/ --- (Updated Jan. 22, 2014, 5:51 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Only set QT_STRICT_ITERATORS when not compiling with MSVC On MSVC linker errors will happen when this flag is set. Diffs - kde-modules/KDEFrameworkCompilerSettings.cmake d71c407f9c0b504ebb1c0cf662e69545f7a46371 Diff: https://git.reviewboard.kde.org/r/115234/diff/ Testing --- E.g. KConfigWidgets didn't compile before, compiles now Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115234: Only set QT_STRICT_ITERATORS when not compiling with MSVC
On Jan. 23, 2014, 9:28 a.m., David Faure wrote: Oh, OK, didn't know this was broken on MSVC. Worth a Qt fix or at least bugreport? Thiago reported it: see http://lists.kde.org/?l=kde-buildsystemm=139042097719628w=2 and https://codereview.qt-project.org/#change,76311 - Luigi --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/#review48092 --- On Jan. 22, 2014, 5:51 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/ --- (Updated Jan. 22, 2014, 5:51 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Only set QT_STRICT_ITERATORS when not compiling with MSVC On MSVC linker errors will happen when this flag is set. Diffs - kde-modules/KDEFrameworkCompilerSettings.cmake d71c407f9c0b504ebb1c0cf662e69545f7a46371 Diff: https://git.reviewboard.kde.org/r/115234/diff/ Testing --- E.g. KConfigWidgets didn't compile before, compiles now Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115234: Only set QT_STRICT_ITERATORS when not compiling with MSVC
On Jan. 23, 2014, 10:28 a.m., David Faure wrote: Oh, OK, didn't know this was broken on MSVC. Worth a Qt fix or at least bugreport? Luigi Toscano wrote: Thiago reported it: see http://lists.kde.org/?l=kde-buildsystemm=139042097719628w=2 and https://codereview.qt-project.org/#change,76311 Should I add a check for the Qt version? Obviously this will only work if Qt is searched for first - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/#review48092 --- On Jan. 22, 2014, 6:51 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/ --- (Updated Jan. 22, 2014, 6:51 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Only set QT_STRICT_ITERATORS when not compiling with MSVC On MSVC linker errors will happen when this flag is set. Diffs - kde-modules/KDEFrameworkCompilerSettings.cmake d71c407f9c0b504ebb1c0cf662e69545f7a46371 Diff: https://git.reviewboard.kde.org/r/115234/diff/ Testing --- E.g. KConfigWidgets didn't compile before, compiles now Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115234: Only set QT_STRICT_ITERATORS when not compiling with MSVC
On Jan. 23, 2014, 9:28 a.m., David Faure wrote: Oh, OK, didn't know this was broken on MSVC. Worth a Qt fix or at least bugreport? Luigi Toscano wrote: Thiago reported it: see http://lists.kde.org/?l=kde-buildsystemm=139042097719628w=2 and https://codereview.qt-project.org/#change,76311 Alexander Richardson wrote: Should I add a check for the Qt version? Obviously this will only work if Qt is searched for first Can you put a link to the change request in the comment, and a TODO to revisit this when we depend on Qt 5.3? We unfortunately can't check the Qt version in this file, as we can't guarantee it's been found. But it is likely we'll bump the required Qt version for all the frameworks at once. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/#review48092 --- On Jan. 22, 2014, 5:51 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/ --- (Updated Jan. 22, 2014, 5:51 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Only set QT_STRICT_ITERATORS when not compiling with MSVC On MSVC linker errors will happen when this flag is set. Diffs - kde-modules/KDEFrameworkCompilerSettings.cmake d71c407f9c0b504ebb1c0cf662e69545f7a46371 Diff: https://git.reviewboard.kde.org/r/115234/diff/ Testing --- E.g. KConfigWidgets didn't compile before, compiles now Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115234: Only set QT_STRICT_ITERATORS when not compiling with MSVC
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/ --- (Updated Jan. 23, 2014, 3:10 p.m.) Status -- This change has been marked as submitted. Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Only set QT_STRICT_ITERATORS when not compiling with MSVC On MSVC linker errors will happen when this flag is set. Diffs - kde-modules/KDEFrameworkCompilerSettings.cmake d71c407f9c0b504ebb1c0cf662e69545f7a46371 Diff: https://git.reviewboard.kde.org/r/115234/diff/ Testing --- E.g. KConfigWidgets didn't compile before, compiles now Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115234: Only set QT_STRICT_ITERATORS when not compiling with MSVC
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/#review48133 --- This review has been submitted with commit 506bd64a3b30fbb5c1940a796f82e281053db4bd by Alex Richardson to branch master. - Commit Hook On Jan. 22, 2014, 5:51 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/ --- (Updated Jan. 22, 2014, 5:51 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Only set QT_STRICT_ITERATORS when not compiling with MSVC On MSVC linker errors will happen when this flag is set. Diffs - kde-modules/KDEFrameworkCompilerSettings.cmake d71c407f9c0b504ebb1c0cf662e69545f7a46371 Diff: https://git.reviewboard.kde.org/r/115234/diff/ Testing --- E.g. KConfigWidgets didn't compile before, compiles now Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115234: Only set QT_STRICT_ITERATORS when not compiling with MSVC
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Only set QT_STRICT_ITERATORS when not compiling with MSVC On MSVC linker errors will happen when this flag is set. Diffs - kde-modules/KDEFrameworkCompilerSettings.cmake d71c407f9c0b504ebb1c0cf662e69545f7a46371 Diff: https://git.reviewboard.kde.org/r/115234/diff/ Testing --- E.g. KConfigWidgets didn't compile before, compiles now Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
