D15426: Avoid QByteArray::remove in AccessManagerReply::readData

[Fabian Vogt]

fvogt updated this revision to Diff 41456.
fvogt added a comment.


  Avoid reallocation in slotData if removing m_offset frees enough space.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15426?vs=41455=41456

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15426

AFFECTED FILES
  src/widgets/accessmanagerreply_p.cpp
  src/widgets/accessmanagerreply_p.h

To: fvogt, #frameworks, elvisangelaccio
Cc: ngraham, bruns, kde-frameworks-devel, michaelh

D15407: Fix OCS provider URL in about dialog

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D15407

To: broulik, #frameworks, leinir, alexanderschmidt
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

[Fabian Vogt]

fvogt added a comment.


  In D15426#324284 , @bruns wrote:
  
  > For the trivial case, do the clear in `readData()`.
  >
  > For the non-trivial case:
  >
  > 1. in `readData()`, no memmoves were ever done. Currently, if you have e.g. 
50 kB in m_data, you read 2 * 16 kB, and move the remaining 18 kB to the front. 
You can instead just read 3 * 16 + 2 kB.
  
  
  It's always a cpu/memory trade off. I prefer KISS to premature optimization.
  
  > 1. in `slotData()`, you have to do a copy every time `capacity()` is 
exceeded. You can piggy-pack on this necessary copy/move, and either do a move 
if `m_offset >= data.size()` else do a copy of the old data, last append the 
new `data`.
  
  Sure, I added that. Note that it does not actually make a difference for the 
`readAll()` case as m_offset is always 0 in `slotData`.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15426

To: fvogt, #frameworks, elvisangelaccio
Cc: ngraham, bruns, kde-frameworks-devel, michaelh

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

[Fabian Vogt]

fvogt updated this revision to Diff 41455.
fvogt added a comment.


  Save m_offset bytes in slotData as well.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15426?vs=41427=41455

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15426

AFFECTED FILES
  src/widgets/accessmanagerreply_p.cpp
  src/widgets/accessmanagerreply_p.h

To: fvogt, #frameworks, elvisangelaccio
Cc: ngraham, bruns, kde-frameworks-devel, michaelh

D6513: Add support for Attica tags support

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D6513#324419 , @ngraham wrote:
  
  > In D6513#322167 , @leinir wrote:
  >
  > > In D6513#322078 , @ngraham 
wrote:
  > >
  > > > So is this enough for people to start tagging KDE4 content as such? Or 
is anything else still required before that capability lands?
  > >
  > >
  > > In short, this is basically enough :) When people run KNewStuff with this 
patch, any content which has been marked as ghns_exclude (that tick box you and 
the other moderators have on the store) will be hidden from the user :) For 
doing more "proper" filtering, changes will want to be done to either just the 
knsrc files, or to the clients themselves (which would be for things like 
"don't show wallpapers with incorrect resolutions" or "only show things with 
x86 binaries" or that sort of stuff).
  >
  >
  > So I see `ghns_exclude` over at store.kde.org, but it doesn't feel quite 
right to check that box next to everything KDE4. Is that what I should be doing?
  
  
  That is precisely what you should be doing, yes :) You are right, it doesn't 
quite feel right to just outright exclude everything KDE4 from GHNS, but the 
reason it works is that the filtering happens clientside, and it will still 
show up for anybody who doesn't have this patch (or, in other words, anybody 
who has a less than version 5.51 Frameworks).
  
  We should, however, also be talking about which other tags we want to have - 
it seems like we might well want to have some more capable filtering in our 
various dialogues. That, however, is not really something that'd make sense to 
discuss in a comment thread under some differential revision ;) Perhaps we 
should take it up at a Plasma meeting, sort of air the idea that it's now a 
thing that can be done, and then collect ideas in a Task?

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6513

To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure, 
cfeck
Cc: dfaure, cfeck, mlaurent, ngraham, ahiemstra, kde-frameworks-devel, 
#knewstuff, michaelh, ZrenBot, bruns

KDE CI: Frameworks » solid » kf5-qt5 SUSEQt5.10 - Build # 60 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20SUSEQt5.10/60/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 12 Sep 2018 15:23:16 +
 Build duration:
1 min 37 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report85%
(11/13)51%
(73/143)51%
(73/143)30%
(1532/5167)18%
(650/3564)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)99%
(321/325)51%
(155/304)src.imports0%
(0/2)0%
(0/2)0%
(0/93)0%
(0/50)src.solid.devices67%
(2/3)67%
(2/3)81%
(99/122)57%
(21/37)src.solid.devices.backends.fakehw100%
(16/16)100%
(16/16)52%
(354/680)43%
(140/328)src.solid.devices.backends.fstab43%
(3/7)43%
(3/7)22%
(70/313)17%
(33/190)src.solid.devices.backends.shared20%
(1/5)20%
(1/5)11%
(36/330)10%
(15/156)src.solid.devices.backends.udev9%
(1/11)9%
(1/11)8%
(32/394)0%
(2/484)src.solid.devices.backends.udisks214%
(2/14)14%
(2/14)4%
(51/1351)2%
(22/1183)src.solid.devices.backends.udisks2.dbus100%
(2/2)100%
(2/2)70%
(7/10)100%
(0/0)src.solid.devices.backends.upower14%
(1/7)14%
(1/7)5%
(20/370)5%
(8/175)src.solid.devices.frontend50%
(22/44)50%
(22/44)57%
(501/879)50%
(249/500)src.solid.devices.ifaces74%
(20/27)74%
(20/27)63%
(41/65)21%
(5/24)src.tools.solid-hardware0%
(0/2)0%
(0/2)0%
(0/235)0%
(0/133)

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.11 - Build # 9 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.11/9/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Wed, 12 Sep 2018 15:23:16 +
 Build duration:
58 sec and counting

KDE CI: Frameworks » kunitconversion » kf5-qt5 AndroidQt5.11 - Build # 16 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kunitconversion/job/kf5-qt5%20AndroidQt5.11/16/
 Project:
kf5-qt5 AndroidQt5.11
 Date of build:
Wed, 12 Sep 2018 16:46:47 +
 Build duration:
3 min 48 sec and counting
   CONSOLE OUTPUT
  [...truncated 72.74 KB...] * Qt5Test * Qt5 (required version >= 5.8.0)-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- Configuring done-- Generating doneCMake Warning:  Manually-specified variables were not used by the project:KF5_HOST_TOOLING-- Build files have been written to: /home/user/workspace/Frameworks/kunitconversion/kf5-qt5 AndroidQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[kf5-qt5 AndroidQt5.11] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kunitconversion --branchGroup kf5-qt5 --platform AndroidQt5.11 --usingInstall /home/user/install-prefix/Scanning dependencies of target KF5UnitConversion_autogen[  2%] Automatic MOC for target KF5UnitConversion[  2%] Built target KF5UnitConversion_autogenScanning dependencies of target KF5UnitConversion[  4%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/converter.cpp.o[  7%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/area.cpp.o[  9%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/volume.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/temperature.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/velocity.cpp.o[ 16%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/mass.cpp.o[ 19%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/pressure.cpp.o[ 21%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/energy.cpp.o[ 23%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/currency.cpp.o[ 26%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/power.cpp.o[ 28%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/timeunit.cpp.o[ 30%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/fuel_efficiency.cpp.o[ 33%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/density.cpp.o[ 35%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/acceleration.cpp.o[ 38%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/force.cpp.o[ 40%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/angle.cpp.o[ 42%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/frequency.cpp.o[ 45%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/thermal_conductivity.cpp.o[ 47%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/thermal_flux.cpp.o[ 50%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/thermal_generation.cpp.o[ 52%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/voltage.cpp.o[ 54%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/electrical_current.cpp.o[ 57%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/electrical_resistance.cpp.o[ 59%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/KF5UnitConversion_autogen/mocs_compilation.cpp.o[ 61%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/length.cpp.o[ 64%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/unitcategory.cpp.o[ 66%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/unit.cpp.o[ 69%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/value.cpp.o[ 71%] Linking CXX shared library ../bin/libKF5UnitConversion.so/home/user/workspace/Frameworks/kunitconversion/kf5-qt5 AndroidQt5.11/src/unit.cpp:33: error: undefined reference to 'KLocalizedString::KLocalizedString()'/home/user/workspace/Frameworks/kunitconversion/kf5-qt5 AndroidQt5.11/src/unit.cpp:33: error: undefined reference to 'KLocalizedString::KLocalizedString()'/home/user/workspace/Frameworks/kunitconversion/kf5-qt5 AndroidQt5.11/src/unit.cpp:33: error: undefined reference to 'KLocalizedString::KLocalizedString()'/home/user/workspace/Frameworks/kunitconversion/kf5-qt5 AndroidQt5.11/src/unit.cpp:49: error: undefined reference to 'KLocalizedString::KLocalizedString(KLocalizedString const&)'/home/user/workspace/Frameworks/kunitconversion/kf5-qt5 AndroidQt5.11/src/unit.cpp:49: error: undefined reference to 'KLocalizedString::KLocalizedString(KLocalizedString const&)'/home/user/workspace/Frameworks/kunitconversion/kf5-qt5 AndroidQt5.11/src/unit.cpp:49: error: undefined reference to 'KLocalizedString::KLocalizedString(KLocalizedString const&)'/home/user/workspace/Frameworks/kunitconversion/kf5-qt5 AndroidQt5.11/src/unit.cpp:53: error: undefined reference to 'KLocalizedString::~KLocalizedString()'/home/user/workspace/Frameworks/kunitconversion/kf5-qt5 AndroidQt5.11/src/unit.cpp:53: error: undefined reference to 'KLocalizedString::~KLocalizedString()'/home/user/workspace/Frameworks/kunitconversion/kf5-qt5 AndroidQt5.11/src/unit.cpp:53: error: undefined reference 

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 85 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/85/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 12 Sep 2018 17:50:37 +
 Build duration:
5 min 6 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 44 test(s), Skipped: 0 test(s), Total: 45 test(s)Failed: TestSuite.kwayland-testDataDevice
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(234/254)92%
(234/254)87%
(24765/28429)53%
(9798/18335)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(41/41)100%
(41/41)99%
(11670/11759)50%
(6194/12323)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client99%
(71/72)99%
(71/72)85%
(5732/6771)65%
(1504/2322)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(115/115)100%
(115/115)87%
(6929/7968)66%
(1931/2933)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/732)0%
(0/131)

KDE CI: Frameworks » solid » kf5-qt5 WindowsMSVCQt5.11 - Build # 8 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20WindowsMSVCQt5.11/8/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Wed, 12 Sep 2018 14:54:36 +
 Build duration:
1 min 39 sec and counting
   CONSOLE OUTPUT
  [...truncated 218.24 KB...][ 65%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/win/winblock.cpp.objwinblock.cpp[ 67%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/win/winopticaldrive.cpp.objwinopticaldrive.cpp[ 67%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/win/wininterface.cpp.objwininterface.cpp[ 69%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/win/wingenericinterface.cpp.objwingenericinterface.cpp[ 71%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/win/windevice.cpp.objwindevice.cpp[ 71%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/win/windevicemanager.cpp.objwindevicemanager.cpp[ 73%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/win/winopticaldisc.cpp.objwinopticaldisc.cpp[ 73%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/win/winprocessor.cpp.objwinprocessor.cpp[ 75%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/win/winstorageaccess.cpp.obj[ 76%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/win/winstoragedrive.cpp.objwinstoragedrive.cppwinstorageaccess.cpp[ 77%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/win/winstoragevolume.cpp.objwinstoragevolume.cpp[ 79%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/win/winbattery.cpp.objwinbattery.cpp[ 79%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/ECMQmLoader-solid5_qt.cpp.objECMQmLoader-solid5_qt.cpp[ 81%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/KF5Solid_autogen/mocs_compilation.cpp.objmocs_compilation.cpp[ 82%] Building C object src/solid/CMakeFiles/KF5Solid.dir/predicate_parser.c.objpredicate_parser.c[ 83%] Building C object src/solid/CMakeFiles/KF5Solid.dir/predicate_lexer.c.objpredicate_lexer.cdevices/predicate_lexer.l(66): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data[ 86%] Linking CXX shared library ..\..\bin\KF5Solid.dllScanning dependencies of target fakehardwaretest_autogenScanning dependencies of target solidmttest_autogenScanning dependencies of target solidhwtest_autogen[ 87%] Automatic MOC for target fakehardwaretest[ 89%] Built target fakehardwaretest_autogen[ 89%] Automatic MOC for target solidhwtest[ 89%] Built target solidhwtest_autogen[ 88%] Automatic MOC for target solidmttest   Creating library ..\..\lib\KF5Solid.lib and object ..\..\lib\KF5Solid.exp[ 89%] Built target solidmttest_autogenScanning dependencies of target fakehardwaretestScanning dependencies of target solidhwtestScanning dependencies of target solidmttest   Creating library ..\..\lib\KF5Solid.lib and object ..\..\lib\KF5Solid.exp[ 92%] Built target KF5Solid[ 92%] Building CXX object autotests/CMakeFiles/fakehardwaretest.dir/fakehardwaretest.cpp.obj[ 92%] Building CXX object autotests/CMakeFiles/fakehardwaretest.dir/fakehardwaretest_autogen/mocs_compilation.cpp.objfakehardwaretest.cppmocs_compilation.cpp[ 92%] Building CXX object autotests/CMakeFiles/solidhwtest.dir/solidhwtest.cpp.obj[ 92%] Building CXX object autotests/CMakeFiles/solidhwtest.dir/solidhwtest_autogen/mocs_compilation.cpp.objsolidhwtest.cppmocs_compilation.cpp[ 92%] Building CXX object autotests/CMakeFiles/solidmttest.dir/solidmttest_autogen/mocs_compilation.cpp.obj[ 92%] Building CXX object autotests/CMakeFiles/solidmttest.dir/solidmttest.cpp.objsolidmttest.cppmocs_compilation.cppScanning dependencies of target solidextensionplugin_autogenScanning dependencies of target solid-hardware5_autogen[ 93%] Automatic MOC for target solidextensionplugin[ 94%] Automatic MOC for target solid-hardware5[ 94%] Built target solidextensionplugin_autogen[ 94%] Built target solid-hardware5_autogenScanning dependencies of target solid-hardware5Scanning dependencies of target solidextensionplugin[ 97%] Linking CXX executable ..\bin\fakehardwaretest.exe[ 96%] Building CXX object src/imports/CMakeFiles/solidextensionplugin.dir/solidextensionplugin.cpp.objjom: C:\CI\workspace\Frameworks\solid\kf5-qt5 WindowsMSVCQt5.11\build\src\imports\CMakeFiles\solidextensionplugin.dir\build.make [src\imports\CMakeFiles\solidextensionplugin.dir\solidextensionplugin.cpp.obj] Error 2[ 96%] Building CXX object src/imports/CMakeFiles/solidextensionplugin.dir/devices.cpp.obj[ 96%] Building CXX object src/imports/CMakeFiles/solidextensionplugin.dir/solidextensionplugin_autogen/mocs_compilation.cpp.objsolidextensionplugin.cppC:\CI\workspace\Frameworks\solid\kf5-qt5 WindowsMSVCQt5.11\src\imports\solidextensionplugin.cpp(36): error C2065: 'qmlRegisterType': undeclared 

KDE CI: Frameworks » solid » kf5-qt5 SUSEQt5.9 - Build # 44 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20SUSEQt5.9/44/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 12 Sep 2018 15:23:16 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report85%
(11/13)51%
(73/143)51%
(73/143)30%
(1532/5167)18%
(650/3564)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)99%
(321/325)51%
(155/304)src.imports0%
(0/2)0%
(0/2)0%
(0/93)0%
(0/50)src.solid.devices67%
(2/3)67%
(2/3)81%
(99/122)57%
(21/37)src.solid.devices.backends.fakehw100%
(16/16)100%
(16/16)52%
(354/680)43%
(140/328)src.solid.devices.backends.fstab43%
(3/7)43%
(3/7)22%
(70/313)17%
(33/190)src.solid.devices.backends.shared20%
(1/5)20%
(1/5)11%
(36/330)10%
(15/156)src.solid.devices.backends.udev9%
(1/11)9%
(1/11)8%
(32/394)0%
(2/484)src.solid.devices.backends.udisks214%
(2/14)14%
(2/14)4%
(51/1351)2%
(22/1183)src.solid.devices.backends.udisks2.dbus100%
(2/2)100%
(2/2)70%
(7/10)100%
(0/0)src.solid.devices.backends.upower14%
(1/7)14%
(1/7)5%
(20/370)5%
(8/175)src.solid.devices.frontend50%
(22/44)50%
(22/44)57%
(501/879)50%
(249/500)src.solid.devices.ifaces74%
(20/27)74%
(20/27)63%
(41/65)21%
(5/24)src.tools.solid-hardware0%
(0/2)0%
(0/2)0%
(0/235)0%
(0/133)

KDE CI: Frameworks » kwallet » kf5-qt5 WindowsMSVCQt5.11 - Build # 5 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kwallet/job/kf5-qt5%20WindowsMSVCQt5.11/5/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Wed, 12 Sep 2018 17:05:22 +
 Build duration:
7 min 46 sec and counting
   CONSOLE OUTPUT
  [...truncated 127.33 KB...]-- Configuring done-- Generating done-- Build files have been written to: C:/CI/workspace/Frameworks/kwallet/kf5-qt5 WindowsMSVCQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] bat[kf5-qt5 WindowsMSVCQt5.11] Running batch scriptC:\CI\workspace\Frameworks\kwallet\kf5-qt5 WindowsMSVCQt5.11>call "C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Auxiliary/Build/vcvars64.bat"  Visual Studio 2017 Developer Command Prompt v15.7.3** Copyright (c) 2017 Microsoft Corporation**[vcvarsall.bat] Environment initialized for: 'x64'jom 1.1.2 - empower your coresjom: parallel job execution disabled for MakefileScanning dependencies of target KF5Wallet_autogenScanning dependencies of target docs-kwallet-query-kwallet-query-1Scanning dependencies of target kwalletbackend5_autogenScanning dependencies of target KF5Wallet_QCH[  1%] Automatic MOC for target KF5Wallet[  4%] Automatic MOC for target kwalletbackend5[  4%] Built target KF5Wallet_autogen[  2%] Generating src/api/KWallet/KF5Wallet.qch, src/api/KWallet/KF5Wallet.tagsfile:///C:/CI/workspace/Frameworks/kwallet/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/kdedbx45.dtd:102: warning: failed to load external entity "file:///C:/CI/Craft/CI-Qt511/windows-msvc2017_64-cl-debug/bin/data/xml/docbook/schema/dtd/4.5/docbookx.dtd"%DocBookDTD;^file:///C:/CI/workspace/Frameworks/kwallet/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: validity error : PEReference: %div.t[  4%] Built target kwalletbackend5_autogen[  3%] Generating kwallet-query.1itle.content; not found ^file:///C:/CI/workspace/Frameworks/kwallet/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : ContentDecl : Name or '(' expected ^file:///C:/CI/workspace/Frameworks/kwallet/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : expected '>'   ^file:///C:/CI/workspace/Frameworks/kwallet/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : Content error in the external subset   ^man-kwallet-query.1.docbook:8: parser error : Entity 'language' not defined  ^jom: C:\CI\workspace\Frameworks\kwallet\kf5-qt5 WindowsMSVCQt5.11\build\docs\kwallet-query\CMakeFiles\docs-kwallet-query-kwallet-query-1.dir\build.make [docs\kwallet-query\kwallet-query.1] Error 1jom: C:\CI\workspace\Frameworks\kwallet\kf5-qt5 WindowsMSVCQt5.11\build\CMakeFiles\Makefile2 [docs\kwallet-query\CMakeFiles\docs-kwallet-query-kwallet-query-1.dir\all] Error 2[  5%] Generating kwallet_interface.cpp, kwallet_interface.hScanning dependencies of target kwalletbackend5[  5%] Generating kwallet_interface.moc[  6%] Building CXX object src/runtime/kwalletd/backend/CMakeFiles/kwalletbackend5.dir/cbc.cc.obj[  7%] Building CXX object src/runtime/kwalletd/backend/CMakeFiles/kwalletbackend5.dir/blockcipher.cc.obj[  7%] Building CXX object src/runtime/kwalletd/backend/CMakeFiles/kwalletbackend5.dir/kwalletbackend.cc.obj[  8%] Building CXX object src/runtime/kwalletd/backend/CMakeFiles/kwalletbackend5.dir/kwalletentry.cc.obj[  9%] Building CXX object src/runtime/kwalletd/backend/CMakeFiles/kwalletbackend5.dir/blowfish.cc.obj[ 10%] Building CXX object src/runtime/kwalletd/backend/CMakeFiles/kwalletbackend5.dir/sha1.cc.objblockcipher.ccblowfish.cccbc.ccsha1.cckwalletentry.cckwalletbackend.ccScanning dependencies of target KF5Wallet[ 11%] Building CXX object src/runtime/kwalletd/backend/CMakeFiles/kwalletbackend5.dir/backendpersisthandler.cpp.objbackendpersisthandler.cpp[ 12%] Building CXX object src/api/KWallet/CMakeFiles/KF5Wallet.dir/kwallet_api_debug.cpp.obj[ 12%] Building CXX object src/runtime/kwalletd/backend/CMakeFiles/kwalletbackend5.dir/kwalletbackend_debug.cpp.objkwallet_api_debug.cpp[ 13%] Building CXX object src/api/KWallet/CMakeFiles/KF5Wallet.dir/KF5Wallet_autogen/mocs_compilation.cpp.objkwalletbackend_debug.cppmocs_compilation.cpp[ 14%] Building CXX object src/runtime/kwalletd/backend/CMakeFiles/kwalletbackend5.dir/kwalletbackend5_autogen/mocs_compilation.cpp.objmocs_compilation.cpp[ 15%] Building CXX object 

KDE CI: Frameworks » solid » kf5-qt5 SUSEQt5.9 - Build # 43 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20SUSEQt5.9/43/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 12 Sep 2018 14:54:36 +
 Build duration:
7 min 25 sec and counting
   CONSOLE OUTPUT
  [...truncated 199.06 KB...]/home/jenkins/workspace/Frameworks/solid/kf5-qt5 SUSEQt5.9/src/solid/devices/backends/upower/upowerdevice.cpp:92:9: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (uptype) { ^~/home/jenkins/workspace/Frameworks/solid/kf5-qt5 SUSEQt5.9/src/solid/devices/backends/upower/upowerdevice.cpp:110:5: note: here default: ^~~[ 78%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/upower/upowerbattery.cpp.o[ 79%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/upower/upowerdeviceinterface.cpp.o[ 79%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/upower/upowergenericinterface.cpp.o[ 79%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksmanager.cpp.o[ 80%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksdevice.cpp.o[ 80%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksdevicebackend.cpp.o[ 81%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksblock.cpp.o[ 81%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksstoragevolume.cpp.o[ 82%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksdeviceinterface.cpp.o[ 82%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksopticaldisc.cpp.o[ 83%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksopticaldrive.cpp.o[ 83%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksstoragedrive.cpp.o[ 84%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksstorageaccess.cpp.o[ 84%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksgenericinterface.cpp.o[ 85%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/dbus/manager.cpp.o[ 85%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/udisks_debug.cpp.o[ 86%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fstab/fstabmanager.cpp.o[ 86%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fstab/fstabdevice.cpp.o[ 87%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fstab/fstabnetworkshare.cpp.o[ 87%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fstab/fstabstorageaccess.cpp.o[ 87%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fstab/fstabhandling.cpp.o[ 88%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fstab/fstabwatcher.cpp.o[ 88%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/ECMQmLoader-solid5_qt.cpp.o[ 89%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/KF5Solid_autogen/mocs_compilation.cpp.o[ 89%] Linking CXX shared library ../../bin/libKF5Solid.so[ 89%] Built target KF5SolidScanning dependencies of target solidmttest_autogen[ 90%] Automatic MOC for target solidmttest[ 90%] Built target solidmttest_autogenScanning dependencies of target fakehardwaretest_autogen[ 91%] Automatic MOC for target fakehardwaretest[ 91%] Built target fakehardwaretest_autogenScanning dependencies of target solidhwtest_autogen[ 92%] Automatic MOC for target solidhwtest[ 92%] Built target solidhwtest_autogenScanning dependencies of target solid-hardware5_autogen[ 92%] Automatic MOC for target solid-hardware5[ 92%] Built target solid-hardware5_autogenScanning dependencies of target solidextensionplugin_autogen[ 93%] Automatic MOC for target solidextensionplugin[ 93%] Built target solidextensionplugin_autogenScanning dependencies of target solidmttest[ 93%] Building CXX object autotests/CMakeFiles/solidmttest.dir/solidmttest.cpp.o[ 94%] Building CXX object autotests/CMakeFiles/solidmttest.dir/solidmttest_autogen/mocs_compilation.cpp.o[ 94%] Linking CXX executable ../bin/solidmttest[ 94%] Built target solidmttestScanning dependencies of target fakehardwaretest[ 94%] Building CXX object autotests/CMakeFiles/fakehardwaretest.dir/fakehardwaretest.cpp.o[ 95%] Building CXX object autotests/CMakeFiles/fakehardwaretest.dir/fakehardwaretest_autogen/mocs_compilation.cpp.o[ 95%] Linking CXX executable ../bin/fakehardwaretest[ 95%] Built target fakehardwaretestScanning dependencies of target solidhwtest[ 95%] Building CXX object autotests/CMakeFiles/solidhwtest.dir/solidhwtest.cpp.o[ 96%] Building CXX object autotests/CMakeFiles/solidhwtest.dir/solidhwtest_autogen/mocs_compilation.cpp.o[ 96%] Linking CXX executable ../bin/solidhwtest[ 96%] Built target solidhwtestScanning dependencies of 

KDE CI: Frameworks » solid » kf5-qt5 WindowsMSVCQt5.11 - Build # 9 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20WindowsMSVCQt5.11/9/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Wed, 12 Sep 2018 15:23:16 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.solidhwtest

D15421: [server] Add surface data proxy mechanism

[Roman Gilg]

romangg updated this revision to Diff 41497.
romangg added a comment.


  Remove updateProxy call on pointer button press. The compositor is instead
  responsible for updating it before a drag starts, what allows more freedom
  in how the proxy is used.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15421?vs=41395=41497

BRANCH
  0proxyDataSurface

REVISION DETAIL
  https://phabricator.kde.org/D15421

AFFECTED FILES
  src/server/datadevice_interface.cpp
  src/server/datadevice_interface.h
  src/server/pointer_interface.cpp
  src/server/seat_interface.cpp
  src/server/surface_interface.cpp
  src/server/surface_interface.h
  src/server/surface_interface_p.h

To: romangg, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 SUSEQt5.10 - Build # 59 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20SUSEQt5.10/59/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 12 Sep 2018 14:54:36 +
 Build duration:
2 min 29 sec and counting
   CONSOLE OUTPUT
  [...truncated 198.58 KB...][ 77%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udev/udevdeviceinterface.cpp.o[ 77%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udev/udevgenericinterface.cpp.o[ 78%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udev/cpuinfo.cpp.o[ 78%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udev/udevprocessor.cpp.o[ 79%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udev/udevcamera.cpp.o[ 79%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udev/udevportablemediaplayer.cpp.o[ 80%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udev/udevblock.cpp.o[ 80%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/shared/udevqtclient.cpp.o[ 81%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/shared/udevqtdevice.cpp.o[ 81%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/upower/upowermanager.cpp.o[ 82%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/upower/upowerdevice.cpp.o/home/jenkins/workspace/Frameworks/solid/kf5-qt5 SUSEQt5.10/src/solid/devices/backends/upower/upowerdevice.cpp: In member function ���virtual bool Solid::Backends::UPower::UPowerDevice::queryDeviceInterface(const Solid::DeviceInterface::Type&) const���:/home/jenkins/workspace/Frameworks/solid/kf5-qt5 SUSEQt5.10/src/solid/devices/backends/upower/upowerdevice.cpp:92:9: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (uptype) { ^~/home/jenkins/workspace/Frameworks/solid/kf5-qt5 SUSEQt5.10/src/solid/devices/backends/upower/upowerdevice.cpp:110:5: note: here default: ^~~[ 83%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksblock.cpp.o[ 83%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksstoragevolume.cpp.o[ 84%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksdeviceinterface.cpp.o[ 84%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksopticaldisc.cpp.o[ 85%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksopticaldrive.cpp.o[ 85%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksdevicebackend.cpp.o[ 85%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksstoragedrive.cpp.o[ 86%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksdevice.cpp.o[ 86%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksmanager.cpp.o[ 86%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/upower/upowergenericinterface.cpp.o[ 87%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksstorageaccess.cpp.o[ 87%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/udisksgenericinterface.cpp.o[ 88%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/upower/upowerdeviceinterface.cpp.o[ 89%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/udisks2/dbus/manager.cpp.o[ 89%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/upower/upowerbattery.cpp.o[ 89%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/udisks_debug.cpp.o[ 90%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fstab/fstabmanager.cpp.o[ 90%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fstab/fstabdevice.cpp.o[ 91%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fstab/fstabnetworkshare.cpp.o[ 91%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fstab/fstabstorageaccess.cpp.o[ 91%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fstab/fstabhandling.cpp.o[ 92%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fstab/fstabwatcher.cpp.o[ 92%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/ECMQmLoader-solid5_qt.cpp.o[ 93%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/KF5Solid_autogen/mocs_compilation.cpp.o[ 93%] Linking CXX shared library ../../bin/libKF5Solid.so[ 93%] Built target KF5SolidScanning dependencies of target solidextensionplugin_autogenScanning dependencies of target solid-hardware5_autogenScanning dependencies of target fakehardwaretest_autogen[ 94%] Automatic MOC for target solidextensionplugin[ 95%] Automatic MOC for target fakehardwaretest[ 95%] Automatic MOC for target 

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 FreeBSDQt5.11 - Build # 5 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20FreeBSDQt5.11/5/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Wed, 12 Sep 2018 18:36:02 +
 Build duration:
2 min 9 sec and counting

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 AndroidQt5.11 - Build # 23 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20AndroidQt5.11/23/
 Project:
kf5-qt5 AndroidQt5.11
 Date of build:
Wed, 12 Sep 2018 18:32:32 +
 Build duration:
36 sec and counting
   CONSOLE OUTPUT
  [...truncated 93.44 KB...] KPopupAccelManager(QMenu *popup);  ^/home/user/workspace/Frameworks/kwidgetsaddons/kf5-qt5 AndroidQt5.11/src/kacceleratormanager_p.h:169:5: error: 'QMenu' does not name a type QMenu   *m_popup; ^/home/user/workspace/Frameworks/kwidgetsaddons/kf5-qt5 AndroidQt5.11/src/kacceleratormanager.cpp: In static member function 'static void KAcceleratorManagerPrivate::manage(QWidget*)':/home/user/workspace/Frameworks/kwidgetsaddons/kf5-qt5 AndroidQt5.11/src/kacceleratormanager.cpp:106:64: error: no matching function for call to 'KPopupAccelManager::manage(QMenu*)' KPopupAccelManager::manage(static_cast(widget));^/home/user/workspace/Frameworks/kwidgetsaddons/kf5-qt5 AndroidQt5.11/src/kacceleratormanager.cpp:106:64: note: candidate is:In file included from /home/user/workspace/Frameworks/kwidgetsaddons/kf5-qt5 AndroidQt5.11/src/kacceleratormanager.cpp:21:0:/home/user/workspace/Frameworks/kwidgetsaddons/kf5-qt5 AndroidQt5.11/src/kacceleratormanager_p.h:152:17: note: static void KPopupAccelManager::manage(int*) static void manage(QMenu *popup); ^/home/user/workspace/Frameworks/kwidgetsaddons/kf5-qt5 AndroidQt5.11/src/kacceleratormanager_p.h:152:17: note:   no known conversion for argument 1 from 'QMenu*' to 'int*'/home/user/workspace/Frameworks/kwidgetsaddons/kf5-qt5 AndroidQt5.11/src/kacceleratormanager.cpp: In static member function 'static void KAcceleratorManagerPrivate::manageWidget(QWidget*, KAcceleratorManagerPrivate::Item*)':/home/user/workspace/Frameworks/kwidgetsaddons/kf5-qt5 AndroidQt5.11/src/kacceleratormanager.cpp:238:45: error: no matching function for call to 'KPopupAccelManager::manage(QMenu*&)' KPopupAccelManager::manage(popupMenu); ^/home/user/workspace/Frameworks/kwidgetsaddons/kf5-qt5 AndroidQt5.11/src/kacceleratormanager.cpp:238:45: note: candidate is:In file included from /home/user/workspace/Frameworks/kwidgetsaddons/kf5-qt5 AndroidQt5.11/src/kacceleratormanager.cpp:21:0:/home/user/workspace/Frameworks/kwidgetsaddons/kf5-qt5 AndroidQt5.11/src/kacceleratormanager_p.h:152:17: note: static void KPopupAccelManager::manage(int*) static void manage(QMenu *popup); ^/home/user/workspace/Frameworks/kwidgetsaddons/kf5-qt5 AndroidQt5.11/src/kacceleratormanager_p.h:152:17: note:   no known conversion for argument 1 from 'QMenu*' to 'int*'/home/user/workspace/Frameworks/kwidgetsaddons/kf5-qt5 AndroidQt5.11/src/kacceleratormanager.cpp: In static member function 'static void KAcceleratorManagerPrivate::manageMenuBar(QMenuBar*, KAcceleratorManagerPrivate::Item*)':/home/user/workspace/Frameworks/kwidgetsaddons/kf5-qt5 AndroidQt5.11/src/kacceleratormanager.cpp:418:55: error: no matching function for call to 'KPopupAccelManager::manage(QMenu*)' KPopupAccelManager::manage(maction->menu());   ^/home/user/workspace/Frameworks/kwidgetsaddons/kf5-qt5 AndroidQt5.11/src/kacceleratormanager.cpp:418:55: note: candidate is:In file included from /home/user/workspace/Frameworks/kwidgetsaddons/kf5-qt5 AndroidQt5.11/src/kacceleratormanager.cpp:21:0:/home/user/workspace/Frameworks/kwidgetsaddons/kf5-qt5 AndroidQt5.11/src/kacceleratormanager_p.h:152:17: note: static void KPopupAccelManager::manage(int*) static void manage(QMenu *popup); ^/home/user/workspace/Frameworks/kwidgetsaddons/kf5-qt5 AndroidQt5.11/src/kacceleratormanager_p.h:152:17: note:   no known conversion for argument 1 from 'QMenu*' to 'int*'[  7%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatetable.cpp.o/home/user/workspace/Frameworks/kwidgetsaddons/kf5-qt5 AndroidQt5.11/src/kacceleratormanager.cpp: At global scope:/home/user/workspace/Frameworks/kwidgetsaddons/kf5-qt5 AndroidQt5.11/src/kacceleratormanager.cpp:702:1: error: prototype for 'KPopupAccelManager::KPopupAccelManager(QMenu*)' does not match any in class 'KPopupAccelManager' KPopupAccelManager::KPopupAccelManager(QMenu *popup) ^In file included from /home/user/workspace/Frameworks/kwidgetsaddons/kf5-qt5 AndroidQt5.11/src/kacceleratormanager.cpp:21:0:/home/user/workspace/Frameworks/kwidgetsaddons/kf5-qt5 AndroidQt5.11/src/kacceleratormanager_p.h:146:7: error: candidates are: KPopupAccelManager::KPopupAccelManager(KPopupAccelManager&&) class KPopupAccelManager : public QObject   ^/home/user/workspace/Frameworks/kwidgetsaddons/kf5-qt5 AndroidQt5.11/src/kacceleratormanager_p.h:146:7: error: KPopupAccelManager::KPopupAccelManager(const 

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 WindowsMSVCQt5.11 - Build # 5 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20WindowsMSVCQt5.11/5/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Wed, 12 Sep 2018 18:40:06 +
 Build duration:
24 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: TestSuite.kcolorbuttontestFailed: TestSuite.kpasswordlineedittestFailed: TestSuite.ksplittercollapserbuttontest

KDE CI: Frameworks » kwallet » kf5-qt5 WindowsMSVCQt5.11 - Build # 6 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwallet/job/kf5-qt5%20WindowsMSVCQt5.11/6/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Wed, 12 Sep 2018 19:58:39 +
 Build duration:
2 min 10 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 AndroidQt5.11 - Build # 24 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20AndroidQt5.11/24/
 Project:
kf5-qt5 AndroidQt5.11
 Date of build:
Wed, 12 Sep 2018 18:36:02 +
 Build duration:
1 min 0 sec and counting

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.9 - Build # 50 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.9/50/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 12 Sep 2018 18:36:08 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)42%
(70/166)42%
(70/166)30%
(4526/15015)22%
(1731/7860)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(19/19)100%
(19/19)99%
(1655/1664)50%
(797/1602)examples.kmessagebox0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/2)src45%
(51/113)45%
(51/113)23%
(2871/12218)15%
(934/6101)tests0%
(0/33)0%
(0/33)0%
(0/1116)0%
(0/155)

D12520: [PasteJob] Emit KDirNotify on paste

[Nathaniel Graham]

ngraham added a comment.


  Works for me, FWIW.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12520

To: broulik, #frameworks
Cc: ngraham, elvisangelaccio, kde-frameworks-devel, michaelh, bruns

D15464: [server] Touch drag support

[Roman Gilg]

romangg added a dependency: D15443: [server] Allow multiple touch interfaces 
per client and remove fallback code.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D15464

To: romangg, #kwin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15443: [server] Allow multiple touch interfaces per client and remove fallback code

[Roman Gilg]

romangg added a dependent revision: D15464: [server] Touch drag support.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D15443

To: romangg, #kwin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15464: [server] Touch drag support

[Roman Gilg]

romangg added a dependent revision: D15466: Add Wayland touch drag and drop 
support.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D15464

To: romangg, #kwin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 FreeBSDQt5.11 - Build # 4 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20FreeBSDQt5.11/4/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Wed, 12 Sep 2018 18:32:32 +
 Build duration:
31 sec and counting
   CONSOLE OUTPUT
  [...truncated 81.55 KB...][  2%] Generating qrc_icons.cpp[  3%] Generating ui_knewpassworddialog.h[  3%] Generating ui_knewpasswordwidget.h[  3%] Linking CXX executable ../bin/kdatetabletest[  3%] Built target kdatetabletestScanning dependencies of target KF5WidgetsAddons[  4%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kacceleratormanager.cpp.o[  4%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcharselect.cpp.o[  4%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kanimatedbutton.cpp.o[  6%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcolumnresizer.cpp.o[  6%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcharselectdata.cpp.o[  6%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcollapsiblegroupbox.cpp.o[  6%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcolorbutton.cpp.o[  6%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatecombobox.cpp.oIn file included from /usr/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 FreeBSDQt5.11/src/kacceleratormanager.cpp:21:/usr/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 FreeBSDQt5.11/src/kacceleratormanager_p.h:93:18: error: implicit instantiation of undefined template 'QVector'QVector m_weight; ^/usr/local/include/qt5/QtCore/qmetatype.h:2105:1: note: template is declared hereQT_FOR_EACH_AUTOMATIC_TEMPLATE_1ARG(Q_DECLARE_SEQUENTIAL_CONTAINER_METATYPE_ITER)^/usr/local/include/qt5/QtCore/qmetatype.h:207:7: note: expanded from macro 'QT_FOR_EACH_AUTOMATIC_TEMPLATE_1ARG'F(QVector) \  ^In file included from /usr/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 FreeBSDQt5.11/src/kacceleratormanager.cpp:21:/usr/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 FreeBSDQt5.11/src/kacceleratormanager_p.h:152:24: error: unknown type name 'QMenu'static void manage(QMenu *popup);   ^/usr/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 FreeBSDQt5.11/src/kacceleratormanager_p.h:156:24: error: unknown type name 'QMenu'KPopupAccelManager(QMenu *popup);   ^/usr/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 FreeBSDQt5.11/src/kacceleratormanager_p.h:169:5: error: unknown type name 'QMenu'QMenu   *m_popup;^/usr/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 FreeBSDQt5.11/src/kacceleratormanager_p.h:146:7: warning: 'KPopupAccelManager' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor]class KPopupAccelManager : public QObject  ^/usr/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 FreeBSDQt5.11/src/kacceleratormanager.cpp:702:21: error: out-of-line definition of 'KPopupAccelManager' does not match any declaration in 'KPopupAccelManager'KPopupAccelManager::KPopupAccelManager(QMenu *popup)^~/usr/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 FreeBSDQt5.11/src/kacceleratormanager.cpp:806:26: error: out-of-line definition of 'manage' does not match any declaration in 'KPopupAccelManager'void KPopupAccelManager::manage(QMenu *popup) ^~/usr/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 FreeBSDQt5.11/src/kacceleratormanager.cpp:810:13: error: no matching constructor for initialization of 'KPopupAccelManager'new KPopupAccelManager(popup);^  ~/usr/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 FreeBSDQt5.11/src/kacceleratormanager_p.h:146:7: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'QMenu *' to 'const KPopupAccelManager' for 1st argumentclass KPopupAccelManager : public QObject  ^/usr/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 FreeBSDQt5.11/src/kacceleratormanager_p.h:146:7: note: candidate constructor (the implicit move constructor) not viable: no known conversion from 'QMenu *' to 'KPopupAccelManager' for 1st argument/usr/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 FreeBSDQt5.11/src/kacceleratormanager_p.h:146:7: note: candidate constructor (the implicit default constructor) not viable: requires 0 arguments, but 1 was providedIn file included from /usr/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 FreeBSDQt5.11/src/kacceleratormanager.cpp:857:/usr/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 FreeBSDQt5.11/build/src/KF5WidgetsAddons_autogen/include/moc_kacceleratormanager_p.cpp:94:21: error: cannot initialize object parameter of type 'QObject' with an _expression_ of type 'KPopupAccelManager'return QObject::qt_metacast(_clname);

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 WindowsMSVCQt5.11 - Build # 4 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20WindowsMSVCQt5.11/4/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Wed, 12 Sep 2018 18:32:32 +
 Build duration:
7 min 8 sec and counting
   CONSOLE OUTPUT
  [...truncated 118.01 KB...][  6%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcharselect.cpp.obj[  6%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatecombobox.cpp.objkacceleratormanager.cppc:\ci\workspace\frameworks\kwidgetsaddons\kf5-qt5 windowsmsvcqt5.11\src\kacceleratormanager_p.h(93): error C2079: 'KAccelString::m_weight' uses undefined class 'QVector'c:\ci\workspace\frameworks\kwidgetsaddons\kf5-qt5 windowsmsvcqt5.11\src\kacceleratormanager_p.h(152): error C2061: syntax error: identifier 'QMenu'c:\ci\workspace\frameworks\kwidgetsaddons\kf5-qt5 windowsmsvcqt5.11\src\kacceleratormanager_p.h(156): error C2061: syntax error: identifier 'QMenu'c:\ci\workspace\frameworks\kwidgetsaddons\kf5-qt5 windowsmsvcqt5.11\src\kacceleratormanager_p.h(169): error C2143: syntax error: missing ';' before '*'c:\ci\workspace\frameworks\kwidgetsaddons\kf5-qt5 windowsmsvcqt5.11\src\kacceleratormanager_p.h(169): error C4430: missing type specifier - int assumed. Note: C++ does not support default-intc:\ci\workspace\frameworks\kwidgetsaddons\kf5-qt5 windowsmsvcqt5.11\src\kacceleratormanager_p.h(169): error C2238: unexpected token(s) preceding ';'kanimatedbutton.cpp[  6%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatepicker.cpp.objkcollapsiblegroupbox.cppkdatecombobox.cppkcolumnresizer.cpp[  7%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatetable.cpp.obj[  7%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontaction.cpp.objC:\CI\workspace\Frameworks\kwidgetsaddons\kf5-qt5 WindowsMSVCQt5.11\src\kacceleratormanager.cpp(106): error C2660: 'KPopupAccelManager::manage': function does not take 1 argumentsc:\ci\workspace\frameworks\kwidgetsaddons\kf5-qt5 windowsmsvcqt5.11\src\kacceleratormanager_p.h(152): note: see declaration of 'KPopupAccelManager::manage'[  7%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/fonthelpers.cpp.objC:\CI\workspace\Frameworks\kwidgetsaddons\kf5-qt5 WindowsMSVCQt5.11\src\kacceleratormanager.cpp(238): error C2660: 'KPopupAccelManager::manage': function does not take 1 argumentsc:\ci\workspace\frameworks\kwidgetsaddons\kf5-qt5 windowsmsvcqt5.11\src\kacceleratormanager_p.h(152): note: see declaration of 'KPopupAccelManager::manage'C:\CI\workspace\Frameworks\kwidgetsaddons\kf5-qt5 WindowsMSVCQt5.11\src\kacceleratormanager.cpp(418): error C2660: 'KPopupAccelManager::manage': function does not take 1 argumentsc:\ci\workspace\frameworks\kwidgetsaddons\kf5-qt5 windowsmsvcqt5.11\src\kacceleratormanager_p.h(152): note: see declaration of 'KPopupAccelManager::manage'C:\CI\workspace\Frameworks\kwidgetsaddons\kf5-qt5 WindowsMSVCQt5.11\src\kacceleratormanager.cpp(526): error C2228: left of '.resize' must have class/struct/unionC:\CI\workspace\Frameworks\kwidgetsaddons\kf5-qt5 WindowsMSVCQt5.11\src\kacceleratormanager.cpp(526): note: type is 'int'C:\CI\workspace\Frameworks\kwidgetsaddons\kf5-qt5 WindowsMSVCQt5.11\src\kacceleratormanager.cpp(567): error C2109: subscript requires array or pointer typekcharselect.cppkcolorbutton.cppC:\CI\workspace\Frameworks\kwidgetsaddons\kf5-qt5 WindowsMSVCQt5.11\src\kacceleratormanager.cpp(606): error C2109: subscript requires array or pointer typeC:\CI\workspace\Frameworks\kwidgetsaddons\kf5-qt5 WindowsMSVCQt5.11\src\kacceleratormanager.cpp(607): error C2109: subscript requires array or pointer typeC:\CI\workspace\Frameworks\kwidgetsaddons\kf5-qt5 WindowsMSVCQt5.11\src\kacceleratormanager.cpp(617): error C2228: left of '.count' must have class/struct/unionC:\CI\workspace\Frameworks\kwidgetsaddons\kf5-qt5 WindowsMSVCQt5.11\src\kacceleratormanager.cpp(617): note: type is 'int'[  8%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kpopupframe.cpp.objC:\CI\workspace\Frameworks\kwidgetsaddons\kf5-qt5 WindowsMSVCQt5.11\src\kacceleratormanager.cpp(618): error C2109: subscript requires array or pointer type[  8%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontsizeaction.cpp.objC:\CI\workspace\Frameworks\kwidgetsaddons\kf5-qt5 WindowsMSVCQt5.11\src\kacceleratormanager.cpp(703): error C2511: 'KPopupAccelManager::KPopupAccelManager(QMenu *)': overloaded member function not found in 'KPopupAccelManager'c:\ci\workspace\frameworks\kwidgetsaddons\kf5-qt5 windowsmsvcqt5.11\src\kacceleratormanager_p.h(146): note: see declaration of 'KPopupAccelManager'C:\CI\workspace\Frameworks\kwidgetsaddons\kf5-qt5 WindowsMSVCQt5.11\src\kacceleratormanager.cpp(704): error C2550: 'KPopupAccelManager::{ctor}': constructor initializer lists are only allowed on constructor definitionsC:\CI\workspace\Frameworks\kwidgetsaddons\kf5-qt5 WindowsMSVCQt5.11\src\kacceleratormanager.cpp(705): error C2352: 

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.10 - Build # 75 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.10/75/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 12 Sep 2018 18:36:02 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)42%
(70/166)42%
(70/166)30%
(4515/15013)22%
(1729/7860)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(19/19)100%
(19/19)99%
(1655/1664)50%
(797/1602)examples.kmessagebox0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/2)src45%
(51/113)45%
(51/113)23%
(2860/12216)15%
(932/6101)tests0%
(0/33)0%
(0/33)0%
(0/1116)0%
(0/155)

D15443: [server] Allow multiple touch interfaces per client and remove fallback code

[Roman Gilg]

romangg added a comment.


  I believe it works like this: A seat has one global pointer, one global 
keyboard and one global touch "object" each. But clients can bind to them 
multiple times. That's why there are focus.pointers and focus.keyboards vectors 
although there is only one global pointer/keyboard.
  
  A different question is what happens on a multi-seat system: when there are 
several mice or keyboards, the compositor must support splitting them up to 
multiple seats (but every seat again has only one global keyboard and pointer 
object). This does not work of course for touch screens, so that's why the 
specs is reads differently here. But as said this is not directly related to 
focus.pointers, focus.keyboards or focus.touchs being vectors per seat or not.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D15443

To: romangg, #kwin, #frameworks
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D15464: [server] Touch drag support

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> datadevice_interface.cpp:102
>  {
>  // TODO: allow touch
> +const bool pointerGrab = seat->hasImplicitPointerGrab(serial) && 
> seat->focusedPointerSurface() == origin;

done

> seat_interface.cpp:1331
>  Q_D();
> -const qint32 id = d->globalTouch.ids.isEmpty() ? 0 : 
> d->globalTouch.ids.last() + 1;
> +const qint32 id = d->globalTouch.ids.isEmpty() ? 0 : 
> d->globalTouch.ids.size();
>  const qint32 serial = display()->nextSerial();

If I add 2 IDs

[0,1]

then remove ID 0

[1]

with the old code I would  get the ID 2, with this I'll get a second ID 1

> seat_interface.cpp:1358
>  const qint32 serial = display()->nextSerial();
> +if (d->drag.mode == Private::Drag::Mode::Touch &&
> +d->drag.source->dragImplicitGrabSerial() == 
> d->globalTouch.ids.value(id)) {

I expect you need this in touchCancel too

> seat_interface_p.h:153
>  Focus focus;
> -QVector ids;
> +QMap ids;
>  };

If you don't need the order QHash over QMap

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D15464

To: romangg, #kwin, #frameworks
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.9 - Build # 49 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.9/49/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 12 Sep 2018 18:32:32 +
 Build duration:
3 min 34 sec and counting
   CONSOLE OUTPUT
  [...truncated 116.13 KB...] static void manage(QMenu *popup);^/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.9/src/kacceleratormanager_p.h:156:29: error: expected ���)��� before ���*��� token KPopupAccelManager(QMenu *popup);   ~ ^~ )/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.9/src/kacceleratormanager_p.h:169:5: error: ���QMenu��� does not name a type; did you mean ���QPen���? QMenu   *m_popup; ^ QPen/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.9/src/kacceleratormanager.cpp: In static member function ���static void KAcceleratorManagerPrivate::manage(QWidget*)���:/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.9/src/kacceleratormanager.cpp:106:64: error: no matching function for call to ���KPopupAccelManager::manage(QMenu*)��� KPopupAccelManager::manage(static_cast(widget));^In file included from /home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.9/src/kacceleratormanager.cpp:21:/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.9/src/kacceleratormanager_p.h:152:17: note: candidate: ���static void KPopupAccelManager::manage(int*)��� static void manage(QMenu *popup); ^~/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.9/src/kacceleratormanager_p.h:152:17: note:   no known conversion for argument 1 from ���QMenu*��� to ���int*���/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.9/src/kacceleratormanager.cpp: In static member function ���static void KAcceleratorManagerPrivate::manageWidget(QWidget*, KAcceleratorManagerPrivate::Item*)���:/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.9/src/kacceleratormanager.cpp:238:45: error: no matching function for call to ���KPopupAccelManager::manage(QMenu*&)��� KPopupAccelManager::manage(popupMenu); ^In file included from /home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.9/src/kacceleratormanager.cpp:21:/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.9/src/kacceleratormanager_p.h:152:17: note: candidate: ���static void KPopupAccelManager::manage(int*)��� static void manage(QMenu *popup); ^~/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.9/src/kacceleratormanager_p.h:152:17: note:   no known conversion for argument 1 from ���QMenu*��� to ���int*���/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.9/src/kacceleratormanager.cpp: In static member function ���static void KAcceleratorManagerPrivate::manageMenuBar(QMenuBar*, KAcceleratorManagerPrivate::Item*)���:/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.9/src/kacceleratormanager.cpp:418:55: error: no matching function for call to ���KPopupAccelManager::manage(QMenu*)��� KPopupAccelManager::manage(maction->menu());   ^In file included from /home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.9/src/kacceleratormanager.cpp:21:/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.9/src/kacceleratormanager_p.h:152:17: note: candidate: ���static void KPopupAccelManager::manage(int*)��� static void manage(QMenu *popup); ^~/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.9/src/kacceleratormanager_p.h:152:17: note:   no known conversion for argument 1 from ���QMenu*��� to ���int*���/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.9/src/kacceleratormanager.cpp: At global scope:/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.9/src/kacceleratormanager.cpp:702:1: error: no declaration matches ���KPopupAccelManager::KPopupAccelManager(QMenu*)��� KPopupAccelManager::KPopupAccelManager(QMenu *popup) ^~In file included from /home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.9/src/kacceleratormanager.cpp:21:/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.9/src/kacceleratormanager_p.h:146:7: note: candidates are: ���KPopupAccelManager::KPopupAccelManager(KPopupAccelManager&&)��� class KPopupAccelManager : public QObject   ^~/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.9/src/kacceleratormanager_p.h:146:7: note: ���KPopupAccelManager::KPopupAccelManager(const KPopupAccelManager&)���/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.10 - Build # 74 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.10/74/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 12 Sep 2018 18:32:32 +
 Build duration:
3 min 18 sec and counting
   CONSOLE OUTPUT
  [...truncated 115.89 KB...] )/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.10/src/kacceleratormanager_p.h:169:5: error: ���QMenu��� does not name a type; did you mean ���QPen���? QMenu   *m_popup; ^ QPen/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.10/src/kacceleratormanager.cpp: In static member function ���static void KAcceleratorManagerPrivate::manage(QWidget*)���:/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.10/src/kacceleratormanager.cpp:106:64: error: no matching function for call to ���KPopupAccelManager::manage(QMenu*)��� KPopupAccelManager::manage(static_cast(widget));^In file included from /home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.10/src/kacceleratormanager.cpp:21:/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.10/src/kacceleratormanager_p.h:152:17: note: candidate: ���static void KPopupAccelManager::manage(int*)��� static void manage(QMenu *popup); ^~/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.10/src/kacceleratormanager_p.h:152:17: note:   no known conversion for argument 1 from ���QMenu*��� to ���int*���/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.10/src/kacceleratormanager.cpp: In static member function ���static void KAcceleratorManagerPrivate::manageWidget(QWidget*, KAcceleratorManagerPrivate::Item*)���:/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.10/src/kacceleratormanager.cpp:238:45: error: no matching function for call to ���KPopupAccelManager::manage(QMenu*&)��� KPopupAccelManager::manage(popupMenu); ^In file included from /home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.10/src/kacceleratormanager.cpp:21:/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.10/src/kacceleratormanager_p.h:152:17: note: candidate: ���static void KPopupAccelManager::manage(int*)��� static void manage(QMenu *popup); ^~/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.10/src/kacceleratormanager_p.h:152:17: note:   no known conversion for argument 1 from ���QMenu*��� to ���int*���/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.10/src/kacceleratormanager.cpp: In static member function ���static void KAcceleratorManagerPrivate::manageMenuBar(QMenuBar*, KAcceleratorManagerPrivate::Item*)���:/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.10/src/kacceleratormanager.cpp:418:55: error: no matching function for call to ���KPopupAccelManager::manage(QMenu*)��� KPopupAccelManager::manage(maction->menu());   ^In file included from /home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.10/src/kacceleratormanager.cpp:21:/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.10/src/kacceleratormanager_p.h:152:17: note: candidate: ���static void KPopupAccelManager::manage(int*)��� static void manage(QMenu *popup); ^~/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.10/src/kacceleratormanager_p.h:152:17: note:   no known conversion for argument 1 from ���QMenu*��� to ���int*���/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.10/src/kacceleratormanager.cpp: At global scope:/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.10/src/kacceleratormanager.cpp:702:1: error: no declaration matches ���KPopupAccelManager::KPopupAccelManager(QMenu*)��� KPopupAccelManager::KPopupAccelManager(QMenu *popup) ^~In file included from /home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.10/src/kacceleratormanager.cpp:21:/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.10/src/kacceleratormanager_p.h:146:7: note: candidates are: ���KPopupAccelManager::KPopupAccelManager(KPopupAccelManager&&)��� class KPopupAccelManager : public QObject   ^~/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.10/src/kacceleratormanager_p.h:146:7: note: ���KPopupAccelManager::KPopupAccelManager(const KPopupAccelManager&)���/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.10/src/kacceleratormanager_p.h:146:7: note: ���KPopupAccelManager::KPopupAccelManager()���/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.10/src/kacceleratormanager_p.h:146:7: note: ���class KPopupAccelManager��� defined 

D15443: [server] Allow multiple touch interfaces per client and remove fallback code

[David Edmundson]

davidedmundson added a comment.


  > has been for no apparent reason
  
  From the spec (emphasis mine)
  
  The wl_touch interface represents **a** touchscreen associated with a seat.
  
  The wl_pointer interface represents **one or more** input devices,
  
  The wl_keyboard interface represents **one or more** keyboards associated 
with a seat.
  
  I assume the rationale being that wl_touch already has multiplicity inside 
it; mutliple touch screens, just add more touches. Whereas wl_pointer is always 
just one.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D15443

To: romangg, #kwin, #frameworks
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D15464: [server] Touch drag support

[Roman Gilg]

romangg created this revision.
romangg added reviewers: KWin, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
romangg requested review of this revision.

REVISION SUMMARY
  Adds functionality to do drag and drop with touch screens.

TEST PLAN
  Manually. Autotest planned.

REPOSITORY
  R127 KWayland

BRANCH
  touchDrag

REVISION DETAIL
  https://phabricator.kde.org/D15464

AFFECTED FILES
  src/server/datadevice_interface.cpp
  src/server/seat_interface.cpp
  src/server/seat_interface.h
  src/server/seat_interface_p.h

To: romangg, #kwin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kjsembed » kf5-qt5 WindowsMSVCQt5.11 - Build # 5 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kjsembed/job/kf5-qt5%20WindowsMSVCQt5.11/5/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Wed, 12 Sep 2018 20:00:58 +
 Build duration:
3 hr 59 min and counting
   CONSOLE OUTPUT
  [...truncated 84.46 KB...]-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.14.26428/bin/Hostx64/x64/cl.exe-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.14.26428/bin/Hostx64/x64/cl.exe -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Tried to enable sanitizers (-DECM_ENABLE_SANITIZERS=address), but compiler (MSVC) does not have sanitizer support-- Could not set up the appstream test. appstreamcli is missing.-- Found Gettext: C:/Craft/CI-Qt511/windows-msvc2017_64-cl-debug/bin/msgmerge.exe (found version "0.19.8.1") -- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Failed-- Performing Test COMPILER_HAS_DEPRECATED-- Performing Test COMPILER_HAS_DEPRECATED - Success-- The following OPTIONAL packages have been found: * KF5DocTools (required version >= 5.50.0)-- The following REQUIRED packages have been found: * ECM (required version >= 5.50.0), Extra CMake Modules.,  * Qt5Gui (required version >= 5.11.1) * Qt5UiTools * Qt5Widgets * Qt5Xml * Qt5Svg * Qt5 (required version >= 5.8.0) * Qt5Core * KF5JS (required version >= 5.50.0) * Gettext * KF5I18n (required version >= 5.50.0)-- Configuring done-- Generating doneCMake Warning:  Manually-specified variables were not used by the project:BUILD_QCH-- Build files have been written to: C:/CI/workspace/Frameworks/kjsembed/kf5-qt5 WindowsMSVCQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] bat[kf5-qt5 WindowsMSVCQt5.11] Running batch scriptC:\CI\workspace\Frameworks\kjsembed\kf5-qt5 WindowsMSVCQt5.11>call "C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Auxiliary/Build/vcvars64.bat"  Visual Studio 2017 Developer Command Prompt v15.7.3** Copyright (c) 2017 Microsoft Corporation**[vcvarsall.bat] Environment initialized for: 'x64'jom 1.1.2 - empower your coresjom: parallel job execution disabled for MakefileScanning dependencies of target KF5JsEmbed_autogenScanning dependencies of target docs-kjscmd5-kjscmd5-1[  3%] Generating kjscmd5.1[  1%] Automatic MOC for target KF5JsEmbed[  3%] Built target KF5JsEmbed_autogenfile:///C:/CI/workspace/Frameworks/kjsembed/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/kdedbx45.dtd:102: warning: failed to load external entity "file:///C:/CI/Craft/CI-Qt511/windows-msvc2017_64-cl-debug/bin/data/xml/docbook/schema/dtd/4.5/docbookx.dtd"%DocBookDTD;^file:///C:/CI/workspace/Frameworks/kjsembed/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: validity error : PEReference: %div.title.content; not found ^file:///C:/CI/workspace/Frameworks/kjsembed/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : ContentDecl : Name or '(' expected ^file:///C:/CI/workspace/Frameworks/kjsembed/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : expected '>'   ^file:///C:/CI/workspace/Frameworks/kjsembed/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : Content error in the external subset   ^man-kjscmd5.1.docbook:6: parser error : Entity 'language' not defined  ^jom: C:\CI\workspace\Frameworks\kjsembed\kf5-qt5 WindowsMSVCQt5.11\build\docs\kjscmd5\CMakeFiles\docs-kjscmd5-kjscmd5-1.dir\build.make [docs\kjscmd5\kjscmd5.1] Error 1jom: C:\CI\workspace\Frameworks\kjsembed\kf5-qt5 WindowsMSVCQt5.11\build\CMakeFiles\Makefile2 [docs\kjscmd5\CMakeFiles\docs-kjscmd5-kjscmd5-1.dir\all] Error 2Scanning dependencies of target KF5JsEmbedjom: C:\CI\workspace\Frameworks\kjsembed\kf5-qt5 WindowsMSVCQt5.11\build\Makefile [all] Error 2[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks » plasma-framework » kf5-qt5 WindowsMSVCQt5.11 - Build # 20 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20WindowsMSVCQt5.11/20/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Wed, 12 Sep 2018 20:00:55 +
 Build duration:
3 hr 58 min and counting
   CONSOLE OUTPUT
  [...truncated 186.94 KB...]./package/contents/config/main.xml./package/contents/ui./package/contents/ui/config.qml./package/contents/ui/main.qml./package/metadata.desktop./plasma-wallpaper.kdevtemplate./READMEfile:///C:/CI/workspace/Frameworks/plasma-framework/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/kdedbx45.dtd:102: warning: failed to load external entity "file:///C:/CI/Craft/CI-Qt511/windows-msvc2017_64-cl-debug/bin/data/xml/docbook/schema/dtd/4.5/docbookx.dtd"%DocBookDTD;^file:///C:/CI/workspace/Frameworks/plasma-framework/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: validity error : PEReference: %div.title.content; not found ^file:///C:/CI/workspace/Frameworks/plasma-framework/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : ContentDecl : Name or '(' expected ^file:///C:/CI/workspace/Frameworks/plasma-framework/kf5-qt5%[  3%] Generating qml-plasmoid.tar.bz2../CMakeLists.txt./Messages.sh./package./package/contents./package/contents/images./package/contents/images/pairs.svgz./package/contents/ui./package/contents/ui/main.qml./package/metadata.desktop./qml-plasmoid.kdevtemplate./qml-plasmoid.png./README20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : expected '>'   ^file:///C:/CI/workspace/Frameworks/plasma-framework/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : Content error in the external subset   ^man-plasmapkg2.1.docbook:6: parser error : Entity 'language' not defined  ^man-plasmapkg2.1.docbook:62: parser error : Entity 'eg' not definedThe type of package,  theme, wallpaper, plasmoid, dataengine ^man-plasmapkg2.1.docbook:62: parser error : Entity 'etc' not definedage,  theme, wallpaper, plasmoid, dataengine, runner, layout-template, [  6%] Built target plasmapkg2_autogen[  6%] Built target plasma-wallpaper[  6%] Generating cpp-plasmoid.tar.bz2../CMakeLists.txt./cpp-plasmoid.kdevtemplate./cpp-plasmoid.png./Messages.sh./README./src./src/%{APPNAMELC}.cpp./src/%{APPNAMELC}.h./src/CMakeLists.txt./src/package./src/package/contents./src/package/contents/images./src/package/contents/images/pairs.svgz./src/package/contents/ui./src/package/contents/ui/main.qml./src/package/metadata.desktop[  6%] Built target qml-plasmoid-with-qml-extension   ^man-plasmapkg2.1.docbook:91: parser error : Entity 'plasma' not defineddirectories for this  session will be searched instead. ^man-plasmapkg2.1.docbook:103: parser error : Entity 'konqueror' not defined(either enter this URL into , or run  ^[  6%] Built target plasma-wallpaper-with-qml-extension[  6%] Built target qml-plasmoidjom: C:\CI\workspace\Frameworks\plasma-framework\kf5-qt5 WindowsMSVCQt5.11\build\docs\plasmapkg2\CMakeFiles\docs-plasmapkg2-plasmapkg2-1.dir\build.make [docs\plasmapkg2\plasmapkg2.1] Error 1jom: C:\CI\workspace\Frameworks\plasma-framework\kf5-qt5 WindowsMSVCQt5.11\build\CMakeFiles\Makefile2 [docs\plasmapkg2\CMakeFiles\docs-plasmapkg2-plasmapkg2-1.dir\all] Error 2[  0%] Automatic MOC for target KF5Plasma[  2%] Generating src/plasma/KF5Plasma.qch, src/plasma/KF5Plasma.tags[  3%] Automatic MOC for target platformcomponentsplugin[  2%] Automatic MOC for target calendarplugin[  6%] Built target cpp-plasmoidScanning dependencies of target plasmapkg2[  7%] Building CXX object src/plasmapkg/CMakeFiles/plasmapkg2.dir/main.cpp.obj[  7%] Building CXX object src/plasmapkg/CMakeFiles/plasmapkg2.dir/plasmapkg2_autogen/mocs_compilation.cpp.objmain.cppmocs_compilation.cpp[  7%] Built target calendarplugin_autogen[  7%] Built target platformcomponentsplugin_autogen[  8%] Linking CXX executable ..\..\bin\plasmapkg2.exe[  8%] Built target KF5Plasma_autogen[  8%] Built target plasmapkg2jom: C:\CI\workspace\Frameworks\plasma-framework\kf5-qt5 WindowsMSVCQt5.11\build\Makefile [all] Error 2[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks » kservice » kf5-qt5 WindowsMSVCQt5.11 - Build # 6 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20WindowsMSVCQt5.11/6/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Wed, 12 Sep 2018 20:00:59 +
 Build duration:
3 hr 59 min and counting
   CONSOLE OUTPUT
  [...truncated 113.00 KB...]   Required for the Trader parser * Doxygen (required version >= 1.8.13)   Needed for API dox QCH file generation * QHelpGenerator, Part of Qt5 tools   Needed for API dox QCH file generation * Qt5Concurrent * Qt5Test * Qt5 (required version >= 5.8.0)-- Configuring done-- Generating done-- Build files have been written to: C:/CI/workspace/Frameworks/kservice/kf5-qt5 WindowsMSVCQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] bat[kf5-qt5 WindowsMSVCQt5.11] Running batch scriptC:\CI\workspace\Frameworks\kservice\kf5-qt5 WindowsMSVCQt5.11>call "C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Auxiliary/Build/vcvars64.bat"  Visual Studio 2017 Developer Command Prompt v15.7.3** Copyright (c) 2017 Microsoft Corporation**[vcvarsall.bat] Environment initialized for: 'x64'jom 1.1.2 - empower your coresjom: parallel job execution disabled for MakefileScanning dependencies of target docs-kbuildsycoca5-kbuildsycoca5-8Scanning dependencies of target copy_servicetypesScanning dependencies of target copy_menuScanning dependencies of target docs-desktoptojson-desktoptojson-8Scanning dependencies of target KF5Service_QCH[  1%] Generating kbuildsycoca5.8[  2%] Built target copy_menu[  2%] Built target copy_servicetypesScanning dependencies of target KF5Service_autogen[  1%] Generating desktoptojson.8file:///C:/CI/workspace/Frameworks/kservice/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/kdedbx45.dtd:102: warning: failed to load external entity "file:///C:/CI/Craft/CI-Qt511/windows-msvc2017_64-cl-debug/bin/data/xml/docbook/schema/dtd/4.5/docbookx.dtd"%DocBookDTD;^file:///C:/CI/workspace/Frameworks/kservice/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: validity error : PEReference: %div.title.content; not found ^file:///C:/CI/workspace/Frameworks/kservice/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : ContentDecl : Name or '(' expected ^file:///C:/CI/workspace/Frameworks/kservice/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : expected '>'   ^file:///C:/CI/workspace/Frameworks/kservice/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : Content error in the external subset   ^man-desktoptojson.8.docbook:6: parser error : Entity 'language' not defined  ^man-desktoptojson.8.docbook:9: parser error : Entity 'kde' not defined Frameworks: KService^jom: C:\CI\workspace\Frameworks\kservice\kf5-qt5 WindowsMSVCQt5.11\build\docs\desktoptojson\CMakeFiles\docs-desktoptojson-desktoptojson-8.dir\build.make [docs\desktoptojson\desktoptojson.8] Error 1file:///C:/CI/workspace/Frameworks/kservice/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/kdedbx45.dtd:102: warning: failed to load external entity "file:///C:/CI/Craft/CI-Qt511/windows-msvc2017_64-cl-debug/bin/data/xml/docbook/schema/dtd/4.5/docbookx.dtd"%DocBookDTD;^file:///C:/CI/workspace/Frameworks/kservice/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: validity error : PEReference: %div.title.content; not found ^file:///C:/CI/workspace/Frameworks/kservice/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : ContentDecl : Name or '(' expected ^file:///C:/CI/workspace/Frameworks/kservice/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : expected '>'   ^file:///C:/CI/workspace/Frameworks/kservice/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : Content error in the external subset   ^man-kbuildsycoca5.8.docbook:6: parser error : Entity 'language' not defined  ^man-kbuildsycoca5.8.docbook:9: parser error : Entity 'kde' not defined 

KDE CI: Frameworks » kjs » kf5-qt5 WindowsMSVCQt5.11 - Build # 5 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kjs/job/kf5-qt5%20WindowsMSVCQt5.11/5/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Wed, 12 Sep 2018 20:00:57 +
 Build duration:
3 hr 58 min and counting
   CONSOLE OUTPUT
  [...truncated 121.60 KB...] * ECM (required version >= 5.50.0), Extra CMake Modules.,  * Qt5Core (required version >= 5.8.0) * Perl,Needed for building kdelibs * Qt5Test (required version >= 5.8.0)-- Configuring doneCMake Warning (dev) in src/kjs/CMakeLists.txt:  Policy CMP0071 is not set: Let AUTOMOC and AUTOUIC process GENERATED files.  Run "cmake --help-policy CMP0071" for policy details.  Use the cmake_policy  command to set the policy and suppress this warning.  For compatibility, CMake is excluding the GENERATED source file(s):"C:/CI/workspace/Frameworks/kjs/kf5-qt5 WindowsMSVCQt5.11/build/src/kjs/date_object.lut.h""C:/CI/workspace/Frameworks/kjs/kf5-qt5 WindowsMSVCQt5.11/build/src/kjs/number_object.lut.h""C:/CI/workspace/Frameworks/kjs/kf5-qt5 WindowsMSVCQt5.11/build/src/kjs/string_object.lut.h""C:/CI/workspace/Frameworks/kjs/kf5-qt5 WindowsMSVCQt5.11/build/src/kjs/array_object.lut.h""C:/CI/workspace/Frameworks/kjs/kf5-qt5 WindowsMSVCQt5.11/build/src/kjs/math_object.lut.h""C:/CI/workspace/Frameworks/kjs/kf5-qt5 WindowsMSVCQt5.11/build/src/kjs/json_object.lut.h""C:/CI/workspace/Frameworks/kjs/kf5-qt5 WindowsMSVCQt5.11/build/src/kjs/regexp_object.lut.h""C:/CI/workspace/Frameworks/kjs/kf5-qt5 WindowsMSVCQt5.11/build/src/kjs/lexer.lut.h""C:/CI/workspace/Frameworks/kjs/kf5-qt5 WindowsMSVCQt5.11/build/src/kjs/opcodes.cpp""C:/CI/workspace/Frameworks/kjs/kf5-qt5 WindowsMSVCQt5.11/build/src/kjs/machine.cpp"  from processing by AUTOMOC.  If any of the files should be processed, set  CMP0071 to NEW.  If any of the files should not be processed, explicitly  exclude them by setting the source file property SKIP_AUTOMOC:set_property(SOURCE file.h PROPERTY SKIP_AUTOMOC ON)This warning is for project developers.  Use -Wno-dev to suppress it.-- Generating doneCMake Warning:  Manually-specified variables were not used by the project:BUILD_QCH-- Build files have been written to: C:/CI/workspace/Frameworks/kjs/kf5-qt5 WindowsMSVCQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] bat[kf5-qt5 WindowsMSVCQt5.11] Running batch scriptC:\CI\workspace\Frameworks\kjs\kf5-qt5 WindowsMSVCQt5.11>call "C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Auxiliary/Build/vcvars64.bat"  Visual Studio 2017 Developer Command Prompt v15.7.3** Copyright (c) 2017 Microsoft Corporation**[vcvarsall.bat] Environment initialized for: 'x64'jom 1.1.2 - empower your coresjom: parallel job execution disabled for MakefileScanning dependencies of target icemaker_autogenScanning dependencies of target docs-kjs5-kjs5-1Scanning dependencies of target KF5JS_autogen[  2%] Automatic MOC for target icemaker[  3%] Built target icemaker_autogen[  3%] Automatic MOC for target KF5JS[  2%] Generating kjs5.1file:///C:/CI/workspace/Frameworks/kjs/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/kdedbx45.dtd:102: warning: failed to load external entity "file:///C:/CI/Craft/CI-Qt511/windows-msvc2017_64-cl-debug/bin/data/xml/docbook/schema/dtd/4.5/docbookx.dtd"%DocBookDTD;^file:///C:/CI/workspace/Frameworks/kjs/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: validity error : PEReference: %div.title.content; not found ^file:///C:/CI/workspace/Frameworks/kjs/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : ContentDecl : Name or '(' expected ^file:///C:/CI/workspace/Frameworks/kjs/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : expected '>'   ^file:///C:/CI/workspace/Frameworks/kjs/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : Content error in the external subset   ^man-kjs5.1.docbook:6: parser error : Entity 'language' not defined  ^man-kjs5.1.docbook:32: parser error : Entity 'kde' not defined ECMAScript compatible interpreter ^jom: C:\CI\workspace\Frameworks\kjs\kf5-qt5 WindowsMSVCQt5.11\build\docs\kjs5\CMakeFiles\docs-kjs5-kjs5-1.dir\build.make [docs\kjs5\kjs5.1] Error 1jom: C:\CI\workspace\Frameworks\kjs\kf5-qt5 WindowsMSVCQt5.11\build\CMakeFiles\Makefile2 

D15321: [Calendar] Expose firstDayOfWeek in MonthView for calendar widgets to override the Locale

[Nathaniel Graham]

ngraham added a comment.


  (and branching is tomorrow, per https://community.kde.org/Schedules/Plasma_5)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15321

To: Zren, broulik
Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D15443: [server] Allow multiple touch interfaces per client and remove fallback code

[Roman Gilg]

romangg added a comment.


  In D15443#324889 , @davidedmundson 
wrote:
  
  > I don't understand removing this. If I have an app that doesn't understand 
touch doesn't it make sense to synthesise a pointer?
  
  
  I didn't read the code correctly. Thought it is meant for compositors not 
supporting touch, but indeed it's meant for clients not supporting it. Hmm, I 
imagine since most Wayland clients use some sort of GUI library there are not 
many Wayland native clients not supporting touch. And Xwayland translates touch 
events. So maybe it would still make sense to remove the code. But I'll add it 
back for now. This way the change also becomes more narrow.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D15443

To: romangg, #kwin, #frameworks
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D15443: [server] Allow multiple touch interfaces per client and remove fallback code

[David Edmundson]

davidedmundson added a comment.


  Oh, I see what you're saying, I misread, sorry. That does indeed make sense.
  
  > Some undocumented fallback code has been removed as well. Platforms not 
supporting touch are just considered not capable instead.
  
  I don't understand removing this. If I have an app that doesn't understand 
touch doesn't it make sense to synthesise a pointer?

INLINE COMMENTS

> seat_interface_p.h:147
>  SurfaceInterface *surface = nullptr;
> -TouchInterface *touch = nullptr;
> +QVector touchs;
>  QMetaObject::Connection destroyConnection;

touchs -> touches

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D15443

To: romangg, #kwin, #frameworks
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D6513: Add support for Attica tags support

[Nathaniel Graham]

ngraham added a comment.


  In D6513#324458 , @leinir wrote:
  
  > In D6513#324419 , @ngraham wrote:
  >
  > > So I see `ghns_exclude` over at store.kde.org, but it doesn't feel quite 
right to check that box next to everything KDE4. Is that what I should be doing?
  >
  >
  > That is precisely what you should be doing, yes :) You are right, it 
doesn't quite feel right to just outright exclude everything KDE4 from GHNS, 
but the reason it works is that the filtering happens clientside, and it will 
still show up for anybody who doesn't have this patch (or, in other words, 
anybody who has a less than version 5.51 Frameworks).
  
  
  OK, got it! Will commence that work and then document it with some 
instructions in https://community.kde.org/Get_Involved. :)
  
  > We should, however, also be talking about which other tags we want to have 
- it seems like we might well want to have some more capable filtering in our 
various dialogues. That, however, is not really something that'd make sense to 
discuss in a comment thread under some differential revision ;) Perhaps we 
should take it up at a Plasma meeting, sort of air the idea that it's now a 
thing that can be done, and then collect ideas in a Task?
  
  Sounds good to me. Can I get an invite/mention/whatever when that happens?

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6513

To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure, 
cfeck
Cc: dfaure, cfeck, mlaurent, ngraham, ahiemstra, kde-frameworks-devel, 
#knewstuff, michaelh, ZrenBot, bruns

D15213: Provide icons for 2x scaling

[Christoph Feck]

cfeck added a comment.


  Did this fix bug 398094?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15213

To: rizzitello, #vdg, #plasma, broulik, ngraham
Cc: cfeck, acrouthamel, ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D15213: Provide icons for 2x scaling

[Nathaniel Graham]

ngraham added a comment.


  Hah, yes it did!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15213

To: rizzitello, #vdg, #plasma, broulik, ngraham
Cc: cfeck, acrouthamel, ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

[Fabian Vogt]

fvogt marked 3 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15426

To: fvogt, #frameworks, elvisangelaccio
Cc: ngraham, bruns, kde-frameworks-devel, michaelh

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> accessmanagerreply_p.cpp:433
> +newData.append(data);
> +m_data = newData;
> +m_offset = 0;

if you swap these two lines (i.e. append to m_data), you have `m_data += data` 
in all three branches, and you can move it to the bottom.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15426

To: fvogt, #frameworks, elvisangelaccio
Cc: ngraham, bruns, kde-frameworks-devel, michaelh

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

[Fabian Vogt]

fvogt updated this revision to Diff 41468.
fvogt added a comment.


  The empty "if" is kept for readability.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15426?vs=41456=41468

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15426

AFFECTED FILES
  src/widgets/accessmanagerreply_p.cpp
  src/widgets/accessmanagerreply_p.h

To: fvogt, #frameworks, elvisangelaccio
Cc: ngraham, bruns, kde-frameworks-devel, michaelh

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

[Fabian Vogt]

fvogt updated this revision to Diff 41476.
fvogt added a comment.


  Remove code.
  
  Any more nits to pick?

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15426?vs=41468=41476

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15426

AFFECTED FILES
  src/widgets/accessmanagerreply_p.cpp
  src/widgets/accessmanagerreply_p.h

To: fvogt, #frameworks, elvisangelaccio
Cc: ngraham, bruns, kde-frameworks-devel, michaelh

D14971: Combine display OSD icon files and move to plasma icon theme

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nah, I'll land this now, and bump `X-KDE-PluginInfo-Version` in 
`src/desktoptheme/breeze/metadata.desktop` before Frameworks 5.51 tagging.
  
  Thanks so much for your work here, Phil! I know it's been a long road, but 
I'm going to land this now.
  
  For your next patch, for all the icons that currently have a desktop-looking 
screen, could you make additional versions that have a laptop instead? Then we 
can patch KScreen for Plasma 5.15 to dynamically show one set or other other 
depending on whether you're on a laptop or a desktop. That'll be totally 
awesome.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14971

To: pstefan, ngraham, #vdg, broulik
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14971: Combine display OSD icon files and move to plasma icon theme

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:32e0f7867758: Combine display OSD icon files and move to 
plasma icon theme (authored by pstefan, committed by ngraham).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14971?vs=40157=41477

REVISION DETAIL
  https://phabricator.kde.org/D14971

AFFECTED FILES
  src/desktoptheme/breeze/icons/osd.svgz
  src/desktoptheme/breeze/icons/video.svgz

To: pstefan, ngraham, #vdg, broulik
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 WindowsMSVCQt5.11 - Build # 19 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20WindowsMSVCQt5.11/19/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Wed, 12 Sep 2018 14:05:16 +
 Build duration:
2 min 33 sec and counting
   CONSOLE OUTPUT
  [...truncated 190.09 KB...]./plugin/qmldir./qml-plasmoid-with-qml-extension.kdevtemplate./README[  6%] Built target plasma-wallpaper[  6%] Generating plasma-wallpaper-with-qml-extension.tar.bz2../CMakeLists.txt./Messages.sh./package./package/contents./package/contents/config./package/contents/config/main.xml./package/contents/ui./package/contents/ui/config.qml./package/contents/ui/main.qml./package/metadata.desktop./plasma-wallpaper-with-qml-extension.kdevtemplate./plugin./plugin/%{APPNAMELC}plugin.cpp./plugin/%{APPNAMELC}plugin.h./plugin/CMakeLists.txt./plugin/qmldir./README[  6%] Built target qml-plasmoid[  6%] Generating cpp-plasmoid.tar.bz2../CMakeLists.txt./cpp-plasmoid.kdevtemplate./cpp-plasmoid.png./Messages.sh./README./src./src/%{APPNAMELC}.cpp./src/%{APPNAMELC}.h./src/CMakeLists.txt./src/package./src/package/contents./src/package/contents/images./src/package/contents/images/pairs.svgz./src/package/contents/ui./src/package/contents/ui/main.qml./src/package/metadata.desktop[  6%] Built target qml-plasmoid-with-qml-extension[  6%] Built target plasma-wallpaper-with-qml-extension[  6%] Built target cpp-plasmoidfile:///C:/CI/workspace/Frameworks/plasma-framework/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/kdedbx45.dtd:102: warning: failed to load external entity "file:///C:/CI/Craft/CI-Qt511/windows-msvc2017_64-cl-debug/bin/data/xml/docbook/schema/dtd/4.5/docbookx.dtd"%DocBookDTD;^file:///C:/CI/workspace/Frameworks/plasma-framework/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: validity error : PEReference: %div.title.content; not found ^file:///C:/CI/workspace/Frameworks/plasma-framework/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : ContentDecl : Name or '(' expected ^file:///C:/CI/workspace/Frameworks/plasma-framework/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : expected '>'   ^file:///C:/CI/workspace/Frameworks/plasma-framework/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : Content error in the external subset  Scanning dependencies of target plasmapkg2 ^man-plasmapkg2.1.docbook:6: parser error : Entity 'language' not defined  ^man-plasmapkg2.1.docbook:62: parser error : Entity 'eg' not definedThe type of package,  theme, wallpaper, plasmoid, dataengine ^man-plasmapkg2.1.docbook:62: parser error : Entity 'etc' not definedage,  theme, wallpaper, plasmoid, dataengine, runner, layout-template,^man-plasmapkg2.1.docbook:91: parser error : Entity 'plasma' not defineddirectories for this  session will be searched instead. ^man-plasmapkg2.1.docbook:103: parser error : Entity 'konqueror' not defined(either enter this URL into , or run  ^jom: C:\CI\workspace\Frameworks\plasma-framework\kf5-qt5 WindowsMSVCQt5.11\build\docs\plasmapkg2\CMakeFiles\docs-plasmapkg2-plasmapkg2-1.dir\build.make [docs\plasmapkg2\plasmapkg2.1] Error 1jom: C:\CI\workspace\Frameworks\plasma-framework\kf5-qt5 WindowsMSVCQt5.11\build\CMakeFiles\Makefile2 [docs\plasmapkg2\CMakeFiles\docs-plasmapkg2-plasmapkg2-1.dir\all] Error 2[  1%] Automatic MOC for target KF5Plasma[  3%] Generating src/plasma/KF5Plasma.qch, src/plasma/KF5Plasma.tags[  1%] Automatic MOC for target platformcomponentsplugin[  2%] Automatic MOC for target calendarplugin[  6%] Building CXX object src/plasmapkg/CMakeFiles/plasmapkg2.dir/plasmapkg2_autogen/mocs_compilation.cpp.obj[  7%] Building CXX object src/plasmapkg/CMakeFiles/plasmapkg2.dir/main.cpp.objmain.cppmocs_compilation.cpp[  7%] Built target calendarplugin_autogen[  7%] Built target platformcomponentsplugin_autogen[  8%] Linking CXX executable ..\..\bin\plasmapkg2.exe[  8%] Built target KF5Plasma_autogen[  8%] Built target KF5Plasma_QCHjom: C:\CI\workspace\Frameworks\plasma-framework\kf5-qt5 WindowsMSVCQt5.11\build\Makefile [all] Error 2[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 220 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/220/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 12 Sep 2018 14:05:16 +
 Build duration:
2 min 48 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3599/13112)19%
(1821/9436)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2217)7%
(96/1434)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1420/3491)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(663/1542)30%
(301/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1976)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
  

D15451: Let KUrlCombo operate on QIcon instead of QPixmap

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, dfaure, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Lets the view load the correctly scaled icon on demand.

TEST PLAN
  Before
  F6256160: Screenshot_20180912_155136.png 

  After
  F6256162: Screenshot_20180912_160656.png 

  
  `KIO::pixmapForUrl` and `KIconLoader::loadMimeTypeIcon` says something about 
"loading additional icon themes" but they're hardly used in KIO anymore so it's 
likely the file list itself would have a hard time finding the icons anyway, so 
we can just use `QIcon::fromTheme` here

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15451

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: broulik, #frameworks, dfaure, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

[Stefan Brüns]

bruns added a comment.


  In D15426#324486 , @fvogt wrote:
  
  > In D15426#324284 , @bruns wrote:
  >
  > > For the trivial case, do the clear in `readData()`.
  > >
  > > For the non-trivial case:
  > >
  > > 1. in `readData()`, no memmoves were ever done. Currently, if you have 
e.g. 50 kB in m_data, you read 2 * 16 kB, and move the remaining 18 kB to the 
front. You can instead just read 3 * 16 + 2 kB.
  >
  >
  > It's always a cpu/memory trade off. I prefer KISS to premature optimization.
  
  
  if you remove the `|| m_offset * 2 >= m_data.length()`, it gets even simpler, 
and does less work (especially for the readAll() case). The garbage collection 
is already done in slotData.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15426

To: fvogt, #frameworks, elvisangelaccio
Cc: ngraham, bruns, kde-frameworks-devel, michaelh

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

[Fabian Vogt]

fvogt added a comment.


  In D15426#324636 , @bruns wrote:
  
  > In D15426#324486 , @fvogt wrote:
  >
  > > In D15426#324284 , @bruns 
wrote:
  > >
  > > > For the trivial case, do the clear in `readData()`.
  > > >
  > > > For the non-trivial case:
  > > >
  > > > 1. in `readData()`, no memmoves were ever done. Currently, if you have 
e.g. 50 kB in m_data, you read 2 * 16 kB, and move the remaining 18 kB to the 
front. You can instead just read 3 * 16 + 2 kB.
  > >
  > >
  > > It's always a cpu/memory trade off. I prefer KISS to premature 
optimization.
  >
  >
  > if you remove the `|| m_offset * 2 >= m_data.length()`, it gets even 
simpler, and does less work (especially for the readAll() case). The garbage 
collection is already done in slotData.
  
  
  I did not remove that because it means even if there's only a single byte in 
the buffer remaining (for some reason), the memory of `m_data` is never freed.
  
  However, I looked at the QByteArray source code and found that `:remove` 
doesn't actually change the capacity of the array at all, so it's indeed a bit 
pointless.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15426

To: fvogt, #frameworks, elvisangelaccio
Cc: ngraham, bruns, kde-frameworks-devel, michaelh

D15407: Fix OCS provider URL in about dialog

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R263:229ae4f1add4: Fix OCS provider URL in about dialog 
(authored by broulik).

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15407?vs=41349=41463

REVISION DETAIL
  https://phabricator.kde.org/D15407

AFFECTED FILES
  src/kaboutapplicationpersonmodel_p.cpp

To: broulik, #frameworks, leinir, alexanderschmidt
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12520: [PasteJob] Emit KDirNotify on paste

[Kai Uwe Broulik]

broulik added a comment.


  Ping

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12520

To: broulik, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.11 - Build # 8 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.11/8/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Wed, 12 Sep 2018 14:54:36 +
 Build duration:
45 sec and counting
   CONSOLE OUTPUT
  [...truncated 183.33 KB...][ 67%] Linking CXX shared library ../../bin/libKF5Solid.so[ 67%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/fakehw/fakemanager.cpp.o[ 68%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/fakehw/fakenetworkshare.cpp.o[ 68%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/fakehw/fakeopticaldisc.cpp.o[ 69%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/fakehw/fakeportablemediaplayer.cpp.o[ 69%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/fakehw/fakeprocessor.cpp.o[ 70%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/fakehw/fakestorage.cpp.o[ 70%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/fakehw/fakestorageaccess.cpp.o[ 70%] Built target KF5SolidScanning dependencies of target solid-hardware5_autogen[ 71%] Automatic MOC for target solid-hardware5[ 72%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/fakehw/fakevolume.cpp.o[ 72%] Built target solid-hardware5_autogen[ 72%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/upower/upowermanager.cpp.oScanning dependencies of target solidextensionplugin_autogen[ 72%] Automatic MOC for target solidextensionplugin[ 73%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/upower/upowerdevice.cpp.o[ 73%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/upower/upowerbattery.cpp.o[ 74%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/upower/upowerdeviceinterface.cpp.o[ 74%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/upower/upowergenericinterface.cpp.o[ 74%] Built target solidextensionplugin_autogen[ 75%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/fstab/fstabmanager.cpp.oScanning dependencies of target solid-hardware5[ 75%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/fstab/fstabdevice.cpp.o[ 75%] Building CXX object src/tools/solid-hardware/CMakeFiles/solid-hardware5.dir/solid-hardware.cpp.o[ 76%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/fstab/fstabnetworkshare.cpp.oScanning dependencies of target solidextensionplugin[ 76%] Building CXX object src/imports/CMakeFiles/solidextensionplugin.dir/solidextensionplugin.cpp.o[ 77%] Building CXX object src/imports/CMakeFiles/solidextensionplugin.dir/devices.cpp.o[ 77%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/fstab/fstabstorageaccess.cpp.o[ 78%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/fstab/fstabhandling.cpp.o[ 78%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/fstab/fstabwatcher.cpp.o[ 79%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/hal/halbattery.cpp.o[ 79%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/hal/halblock.cpp.o[ 80%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/hal/halcamera.cpp.o[ 81%] Building CXX object src/tools/solid-hardware/CMakeFiles/solid-hardware5.dir/solid-hardware5_autogen/mocs_compilation.cpp.o/usr/home/jenkins/workspace/Frameworks/solid/kf5-qt5 FreeBSDQt5.11/src/imports/solidextensionplugin.cpp:36:5: error: use of undeclared identifier 'qmlRegisterType'; did you mean 'registerTypes'?qmlRegisterType (uri, 1, 0, "Devices");^~~registerTypes/usr/home/jenkins/workspace/Frameworks/solid/kf5-qt5 FreeBSDQt5.11/src/imports/solidextensionplugin.cpp:30:28: note: 'registerTypes' declared herevoid SolidExtensionPlugin::registerTypes(const char *uri)   ^/usr/home/jenkins/workspace/Frameworks/solid/kf5-qt5 FreeBSDQt5.11/src/imports/solidextensionplugin.cpp:36:5: error: 'registerTypes' does not name a template but is followed by template argumentsqmlRegisterType (uri, 1, 0, "Devices");^  ~/usr/home/jenkins/workspace/Frameworks/solid/kf5-qt5 FreeBSDQt5.11/src/imports/solidextensionplugin.cpp:30:28: note: non-template declaration found by name lookupvoid SolidExtensionPlugin::registerTypes(const char *uri)   ^2 errors generated.gmake[2]: *** [src/imports/CMakeFiles/solidextensionplugin.dir/build.make:63: src/imports/CMakeFiles/solidextensionplugin.dir/solidextensionplugin.cpp.o] Error 1gmake[2]: *** Waiting for unfinished jobs[ 82%] Building CXX object