KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 305 - Still Failing!

2020-06-29 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/305/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Tue, 30 Jun 2020 03:49:25 +
 Build duration:
1 min 47 sec and counting
   CONSOLE OUTPUT
  [...truncated 949 lines...][2020-06-30T03:51:03.603Z] ..\src\ioslaves\trash\kio_trash_win.cpp: note: see previous definition of 'QT_NO_CAST_FROM_ASCII'[2020-06-30T03:51:03.603Z] [204/735] Building CXX object src\ioslaves\ftp\CMakeFiles\kio_ftp.dir\ftp.cpp.obj[2020-06-30T03:51:03.603Z] ..\src\ioslaves\ftp\ftp.cpp(152): warning C4267: 'argument': conversion from 'size_t' to 'unsigned int', possible loss of data[2020-06-30T03:51:03.865Z] [205/735] Building CXX object src\ioslaves\remote\kdedmodule\CMakeFiles\remotedirnotify.dir\__\debug.cpp.obj[2020-06-30T03:51:03.865Z] [206/735] Automatic MOC for target KF5KIOGui[2020-06-30T03:51:03.865Z] [207/735] Building CXX object src\ioslaves\remote\kdedmodule\CMakeFiles\remotedirnotify.dir\remotedirnotify.cpp.obj[2020-06-30T03:51:03.865Z] [208/735] Automatic MOC for target kpasswdservertest[2020-06-30T03:51:03.865Z] [209/735] Generating org.kde.KIOExecd.xml[2020-06-30T03:51:03.865Z] [210/735] Automatic MOC for target kiod_kpasswdserver[2020-06-30T03:51:03.865Z] [211/735] Generating kpasswdserveradaptor.cpp, kpasswdserveradaptor.h[2020-06-30T03:51:04.129Z] [212/735] Generating kpasswdserveradaptor.moc[2020-06-30T03:51:04.129Z] [213/735] Building CXX object src\ioslaves\remote\kdedmodule\CMakeFiles\remotedirnotify.dir\remotedirnotify_autogen\mocs_compilation.cpp.obj[2020-06-30T03:51:04.397Z] [214/735] Linking CXX executable bin\kiod5.exe[2020-06-30T03:51:04.397Z] [215/735] Linking CXX shared module bin\kf5\kio\http.dll[2020-06-30T03:51:04.397Z]Creating library lib\http.lib and object lib\http.exp[2020-06-30T03:51:04.397Z]Creating library lib\http.lib and object lib\http.exp[2020-06-30T03:51:04.397Z] [216/735] Linking CXX shared module bin\kf5\kio\remote.dll[2020-06-30T03:51:04.397Z]Creating library lib\remote.lib and object lib\remote.exp[2020-06-30T03:51:04.397Z]Creating library lib\remote.lib and object lib\remote.exp[2020-06-30T03:51:04.397Z] [217/735] Linking CXX shared module bin\kf5\kio\trash.dll[2020-06-30T03:51:04.397Z]Creating library lib\trash.lib and object lib\trash.exp[2020-06-30T03:51:04.397Z]Creating library lib\trash.lib and object lib\trash.exp[2020-06-30T03:51:04.397Z] [218/735] Linking CXX shared module bin\kf5\kio\ftp.dll[2020-06-30T03:51:04.397Z]Creating library lib\ftp.lib and object lib\ftp.exp[2020-06-30T03:51:04.397Z]Creating library lib\ftp.lib and object lib\ftp.exp[2020-06-30T03:51:04.666Z] [219/735] Generating kpasswdserveradaptor.cpp, kpasswdserveradaptor.h[2020-06-30T03:51:04.666Z] [220/735] Generating kpasswdserveradaptor.moc[2020-06-30T03:51:04.929Z] [221/735] Building CXX object src\ioslaves\remote\kdedmodule\CMakeFiles\remotedirnotify.dir\remotedirnotifymodule.cpp.obj[2020-06-30T03:51:05.203Z] [222/735] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\openwithhandlerinterface.cpp.obj[2020-06-30T03:51:05.467Z] [223/735] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\commandlauncherjob.cpp.obj[2020-06-30T03:51:05.467Z] [224/735] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\openurljob.cpp.obj[2020-06-30T03:51:05.725Z] [225/735] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\faviconrequestjob.cpp.obj[2020-06-30T03:51:05.725Z] [226/735] Linking CXX shared module bin\remotenotifier.dll[2020-06-30T03:51:05.725Z]Creating library lib\remotenotifier.lib and object lib\remotenotifier.exp[2020-06-30T03:51:05.725Z]Creating library lib\remotenotifier.lib and object lib\remotenotifier.exp[2020-06-30T03:51:05.725Z] [227/735] Building CXX object src\kpasswdserver\CMakeFiles\kiod_kpasswdserver.dir\kiod_kpasswdserver.cpp.obj[2020-06-30T03:51:05.984Z] [228/735] Building CXX object src\kpasswdserver\CMakeFiles\kiod_kpasswdserver.dir\kiod_kpasswdserver_autogen\mocs_compilation.cpp.obj[2020-06-30T03:51:05.984Z] [229/735] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\KF5KIOGui_autogen\mocs_compilation.cpp.obj[2020-06-30T03:51:06.247Z] [230/735] Automatic MOC for target kioexecd[2020-06-30T03:51:06.247Z] [231/735] Building CXX object src\kpasswdserver\autotests\CMakeFiles\kpasswdservertest.dir\kpasswdservertest_autogen\mocs_compilation.cpp.obj[2020-06-30T03:51:06.519Z] [232/735] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\applicationlauncherjob.cpp.obj[2020-06-30T03:51:06.519Z] [233/735] Generating kioexecdadaptor.cpp, kioexecdadaptor.h[2020-06-30T03:51:06.519Z] [234/735] Generating kioexecdadaptor.moc[2020-06-30T03:51:06.519Z] [235/735] Automatic MOC for target kcookiejartest[2020-06-30T03:51:06.782Z] [236/735] Automatic MOC for target upurltest[2020-06-30T03:51:06.782Z] [237/735] Automatic MOC for target threadtest[2020-06-30T03:51:07.042Z] [238/735] Building CXX object

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 715 - Unstable!

2020-06-29 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/715/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 30 Jun 2020 03:49:25 +
 Build duration:
6 min 32 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.72.0.xmllogs/KF5KIO/5.72.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)68%
(281/415)68%
(281/415)57%
(36291/63375)41%
(18542/45134)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(59/59)100%
(59/59)95%
(10349/10869)46%
(4899/10716)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(103/116)89%
(103/116)60%
(8713/14412)52%
(4580/8730)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(29/38)76%
(29/38)58%
(4855/8386)45%
(2171/4858)src.gui88%
(7/8)88%
(7/8)78%
(635/819)62%
(373/598)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(718/1300)41%
(431/1054)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3632)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.15 - Build # 28 - Still Unstable!

2020-06-29 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.15/28/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Tue, 30 Jun 2020 03:49:25 +
 Build duration:
5 min 44 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_fileundomanagertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

Re: Deprecate KRandomSequence ?

2020-06-29 Thread Aleix Pol 
On Mon, Jun 29, 2020 at 10:27 PM Albert Astals Cid  wrote:
>
> QRandomGenerator is very similar in which you can give it a seed and get 
> randomness out of it.
>
> Things that QRandomGenerator doesn't have:
>  * getBool(); -> should be easy enough to port to bounded(2) == 1
>  * randomize(QList) -> We could add namespace function in KRandom
>  * modulate() -> Couldn't find any user, so no worries if we drop it
>
> Benefits of deprecation:
>  * Less manintaince
>
> Problems of deprecation:
>  * Moving from KRadomSequence(FIXED_SEED) to QRandomGenerator(FIXED_SEED) 
> will probably generate a different sequence, so if you need to 100% generate 
> the same sequence for all your app versions (e.g. for a game or something) 
> moving may not be "possible"
>
> Ideas? Comments?

+1 makes sense to me.

If an application was relying on the random application sequence, it
probably has bigger problems. It can always be hardcoded into the
application too.

Aleix

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 304 - Failure!

2020-06-29 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/304/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Mon, 29 Jun 2020 21:36:16 +
 Build duration:
1 min 59 sec and counting
   CONSOLE OUTPUT
  [...truncated 946 lines...][2020-06-29T21:38:03.771Z]Creating library lib\ftp.lib and object lib\ftp.exp[2020-06-29T21:38:03.771Z] [208/735] Building CXX object src\ioslaves\http\CMakeFiles\kio_http.dir\http.cpp.obj[2020-06-29T21:38:03.771Z] C:\CI\Job Build\src\ioslaves\http\parsinghelpers.cpp(280): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-06-29T21:38:03.771Z] ..\src\ioslaves\http\http.cpp(2037): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data[2020-06-29T21:38:03.771Z] ..\src\ioslaves\http\http.cpp(2037): warning C4267: 'initializing': conversion from 'size_t' to 'const int', possible loss of data[2020-06-29T21:38:03.771Z] ..\src\ioslaves\http\http.cpp(2058): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-06-29T21:38:03.771Z] ..\src\ioslaves\http\http.cpp(2865): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data[2020-06-29T21:38:03.771Z] ..\src\ioslaves\http\http.cpp(4212): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data[2020-06-29T21:38:03.771Z] ..\src\ioslaves\http\http.cpp(4212): warning C4267: 'initializing': conversion from 'size_t' to 'const int', possible loss of data[2020-06-29T21:38:03.771Z] ..\src\ioslaves\http\http.cpp(4231): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data[2020-06-29T21:38:03.771Z] [209/735] Linking CXX shared module bin\kf5\kio\trash.dll[2020-06-29T21:38:03.771Z]Creating library lib\trash.lib and object lib\trash.exp[2020-06-29T21:38:03.771Z]Creating library lib\trash.lib and object lib\trash.exp[2020-06-29T21:38:03.771Z] [210/735] Linking CXX executable bin\kiod5.exe[2020-06-29T21:38:03.771Z] [211/735] Building CXX object src\ioslaves\remote\CMakeFiles\kio_remote.dir\kio_remote.cpp.obj[2020-06-29T21:38:03.771Z] [212/735] Building CXX object src\ioslaves\remote\CMakeFiles\kio_remote.dir\remoteimpl.cpp.obj[2020-06-29T21:38:03.771Z] [213/735] Building CXX object src\kioslave\CMakeFiles\kioslave5.dir\kioslave.cpp.obj[2020-06-29T21:38:04.032Z] [214/735] Building CXX object src\kssld\CMakeFiles\kssld.dir\kssld.cpp.obj[2020-06-29T21:38:04.290Z] [215/735] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\openwithhandlerinterface.cpp.obj[2020-06-29T21:38:04.577Z] [216/735] Linking CXX shared module bin\remotenotifier.dll[2020-06-29T21:38:04.577Z]Creating library lib\remotenotifier.lib and object lib\remotenotifier.exp[2020-06-29T21:38:04.577Z]Creating library lib\remotenotifier.lib and object lib\remotenotifier.exp[2020-06-29T21:38:04.577Z] [217/735] Linking CXX executable bin\kioslave5.exe[2020-06-29T21:38:04.851Z] [218/735] Generating kpasswdserveradaptor.cpp, kpasswdserveradaptor.h[2020-06-29T21:38:04.851Z] [219/735] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\applicationlauncherjob.cpp.obj[2020-06-29T21:38:05.150Z] [220/735] Generating kpasswdserveradaptor.moc[2020-06-29T21:38:05.415Z] [221/735] Linking CXX shared module bin\kf5\kio\remote.dll[2020-06-29T21:38:05.415Z]Creating library lib\remote.lib and object lib\remote.exp[2020-06-29T21:38:05.415Z]Creating library lib\remote.lib and object lib\remote.exp[2020-06-29T21:38:05.415Z] [222/735] Linking CXX shared module bin\kf5\kio\http.dll[2020-06-29T21:38:05.415Z]Creating library lib\http.lib and object lib\http.exp[2020-06-29T21:38:05.415Z]Creating library lib\http.lib and object lib\http.exp[2020-06-29T21:38:05.683Z] [223/735] Linking CXX shared module bin\kf5\kiod\kssld.dll[2020-06-29T21:38:05.683Z]Creating library lib\kssld.lib and object lib\kssld.exp[2020-06-29T21:38:05.683Z]Creating library lib\kssld.lib and object lib\kssld.exp[2020-06-29T21:38:05.945Z] [224/735] Building CXX object src\kpasswdserver\autotests\CMakeFiles\kpasswdservertest.dir\kpasswdservertest_autogen\mocs_compilation.cpp.obj[2020-06-29T21:38:05.945Z] [225/735] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\faviconrequestjob.cpp.obj[2020-06-29T21:38:06.221Z] [226/735] Building CXX object src\kpasswdserver\autotests\CMakeFiles\kpasswdservertest.dir\kpasswdservertest.cpp.obj[2020-06-29T21:38:06.503Z] [227/735] Building CXX object src\gui\CMakeFiles\KF5KIOGui.dir\kprocessrunner.cpp.obj[2020-06-29T21:38:06.503Z] ..\src\gui\kprocessrunner.cpp(184): warning C4551: function call missing argument list[2020-06-29T21:38:07.147Z] [228/735] Automatic MOC for target kioexecd[2020-06-29T21:38:07.481Z] [229/735] Generating org.kde.KIOExecd.xml[2020-06-29T21:38:07.764Z] [230/735] Generating kioexecdadaptor.cpp, kioexecdadaptor.h[2020-06-29T21:38:07.764Z] [231/735] Generating

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.15 - Build # 27 - Still Unstable!

2020-06-29 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.15/27/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Mon, 29 Jun 2020 21:36:16 +
 Build duration:
6 min 40 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_fileundomanagertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D28745: Skip caching thumbnails on encrypted filesystems

2020-06-29 Thread Marcin Gurtowski 
marcingu added a comment.


  Ok, so far I have implemented `Solid::Device::storageAccessFromPath` by 
talking all StorageAccess devices, going though all of them and and returning 
proper one.
  code:
  
Solid::Device Solid::Device::storageAccessFromPath(const QString )
{
// TODO check if symlinks are in the path
QFileInfo fileInfo = QFileInfo(path);
if (!fileInfo.exists()) {
//TODO error handling
}
QSet checked; //To avoid weird infinete loops
checked.insert(fileInfo.path());
while (fileInfo.isSymLink()) {
fileInfo = QFileInfo(fileInfo.symLinkTarget());
if (checked.contains(fileInfo.path())) {
//TODO error handling
}
checked.insert(fileInfo.path());
}
QDir dir = fileInfo.dir();
QString canonPath = dir.canonicalPath();
QList list = 
Solid::Device::listFromType(DeviceInterface::Type::StorageAccess);
Device match;
int match_length = 0;
for (Device device: list) {
StorageAccess *storageAccess = device.as();
if (canonPath.startsWith(storageAccess->filePath()) && 
storageAccess->filePath().size() > match_length) {
match_length = storageAccess->filePath().size();
match = device;
}
}
return match;
}
  
  and in the thumbnail.cpp:
  
Solid::Device device = Solid::Device::storageAccessFromPath(filePath);
if (device.is()) {
allowCache = device.as()->usage() != 
Solid::StorageVolume::UsageType::Encrypted;
}
  
  It works, but it might be better to hold tree structure with all StorageAcces 
devices where position on tree would be determined by mountpoint of device, 
which would allow us to go straight to the desired StorageAccess without 
checking all of them.
  On the other hand, to do that we would have to slice path into parts and 
compare those parts with nodes on the tree and also create special structure 
for that. I'm not sure which approach is better.
  
  Another problem with storing StorageAccess tree is that I looked at 
DeviceManager classes and it might be too difficult for me, as I don't know 
Solid well.
  
  Which should it be and do we go about it?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns
Cc: thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, 
waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, 
cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.15 - Build # 2 - Still Unstable!

2020-06-29 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.15/2/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Mon, 29 Jun 2020 09:22:55 +
 Build duration:
37 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kptyprocesstest

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.15 - Build # 26 - Still Unstable!

2020-06-29 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.15/26/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Mon, 29 Jun 2020 09:59:40 +
 Build duration:
4 min 3 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D28745: Skip caching thumbnails on encrypted filesystems

2020-06-29 Thread Stefan Brüns 
bruns added a comment.


  In D28745#675685 , @marcingu wrote:
  
  >   Solid::Device device = Solid::Device::storageAccessFromPath(filePath);
  >   if (device.is()) {
  >   allowCache = device.as()->usage() != 
Solid::StorageVolume::UsageType::Encrypted;
  >   }
  >
  
  
  How often do I have to repeat the thumbnailer has to use the canonical path 
anyway? Please use that.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns
Cc: thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, 
waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, 
cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov

D28745: Skip caching thumbnails on encrypted filesystems

2020-06-29 Thread Thiago Macieira 
thiago added a comment.


  >   for (Device device: list) {
  >   StorageAccess *storageAccess = device.as();
  >   if (canonPath.startsWith(storageAccess->filePath()) && 
storageAccess->filePath().size() > match_length) {
  >   match_length = storageAccess->filePath().size();
  >   match = device;
  >   }
  >
  
  This search is affected by the same sibling match bug that QStorageInfo was. 
See https://bugreports.qt.io/browse/QTBUG-49498.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns
Cc: thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, 
waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, 
cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.15 - Build # 2 - Still Unstable!

2020-06-29 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.15/2/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Mon, 29 Jun 2020 17:39:45 +
 Build duration:
1 min 40 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 24 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.kdirwatch_stat_unittestFailed: projectroot.autotests.klistopenfilesjobtest_unix

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 203 - Fixed!

2020-06-29 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/203/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 29 Jun 2020 17:39:45 +
 Build duration:
2 min 42 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.72.0.xmllogs/KF5CoreAddons/5.72.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 27 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6947/9141)43%
(10848/24943)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2913/3008)49%
(6223/12784)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(108/290)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(869/1309)35%
(991/2822)src.lib.jobs71%
(5/7)71%
(5/7)55%
(157/284)39%
(54/140)src.lib.plugin100%
(7/7)100%
(7/7)85%
(681/801)42%
(957/2273)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(46/80)src.lib.text63%
(5/8)63%
(5/8)52%
(443/850)47%
(1026/2187)src.lib.util100%
(15/15)100%
(15/15)83%
(994/1191)51%
(1012/1999)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

D17816: Support for xattrs on kio copy/move

2020-06-29 Thread Gleb Popov 
arrowd updated this revision to Diff 83318.
arrowd marked 3 inline comments as done.
arrowd added a comment.


  - Handle attrs with empty values.
  - Add test for it.
  - Fix syscalls for FreeBSD case.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17816?vs=83309=83318

BRANCH
  arcpatch-D17816

REVISION DETAIL
  https://phabricator.kde.org/D17816

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/ioslaves/file/ConfigureChecks.cmake
  src/ioslaves/file/config-kioslave-file.h.cmake
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp

To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise
Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, 
funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, 
nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.15 - Build # 3 - Still Unstable!

2020-06-29 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.15/3/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Mon, 29 Jun 2020 17:41:28 +
 Build duration:
1 min 33 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 24 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.kdirwatch_stat_unittestFailed: projectroot.autotests.klistopenfilesjobtest_unix

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.15 - Build # 4 - Still Unstable!

2020-06-29 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.15/4/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Mon, 29 Jun 2020 19:20:06 +
 Build duration:
1 min 28 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 24 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.kdirwatch_stat_unittestFailed: projectroot.autotests.klistopenfilesjobtest_unix

D17816: Support for xattrs on kio copy/move

2020-06-29 Thread Stefan Brüns 
bruns added inline comments.

INLINE COMMENTS

> bruns wrote in jobtest.cpp:487
> this obviously needs test cases with a key ley/value len > 512, to check the 
> the array-to-short/resize path.

not done ...

> file_unix.cpp:620
> +#endif
> +qDebug(KIO_FILE) << valuelen << " " << key << " " << value;
> +if (valuelen > 0 && value.size() == 0) {

No extra spaces for qDebug, inserts spaces itself.

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise
Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, 
funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, 
nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh

Deprecate KRandomSequence ?

2020-06-29 Thread Albert Astals Cid 
QRandomGenerator is very similar in which you can give it a seed and get 
randomness out of it.

Things that QRandomGenerator doesn't have:
 * getBool(); -> should be easy enough to port to bounded(2) == 1
 * randomize(QList) -> We could add namespace function in KRandom
 * modulate() -> Couldn't find any user, so no worries if we drop it

Benefits of deprecation:
 * Less manintaince

Problems of deprecation:
 * Moving from KRadomSequence(FIXED_SEED) to QRandomGenerator(FIXED_SEED) will 
probably generate a different sequence, so if you need to 100% generate the 
same sequence for all your app versions (e.g. for a game or something) moving 
may not be "possible"

Ideas? Comments?

Cheers,
  Albert