[Koha-bugs] [Bug 12930] Web installer does not show login errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com --- Comment #17 from Mason James --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12930] Web installer does not show login errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #16 from Julian Maurice --- Pushed to 3.22.x for 3.22.20 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12930] Web installer does not show login errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Katrin Fischer changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||katrin.fisc...@bsz-bw.de --- Comment #15 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.07. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12930] Web installer does not show login errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #14 from Kyle M Hall --- Pushed to master for 17.05, thanks Alex! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12930] Web installer does not show login errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12930] Web installer does not show login errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Marcel de Rooy changed: What|Removed |Added Attachment #62117|0 |1 is obsolete|| --- Comment #13 from Marcel de Rooy --- Created attachment 62166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62166&action=edit Bug 12930: Web installer does not show login errors Implemented invalid_username_or_password template variable being handed to Auth.tt. Removed indentation changes and modification to return value of checkpw Test plan: See comment #2 Alternative test plan: - Clear session cookies or close / open your browser - Go to [MY SERVER]/cgi-bin/koha/installer/install.pl - Verify that message appears if wrong username/pw provided - Verify that you can log in with databas administrator account Tested with alternative test plan, works as expected. Title and description in commit message adapted. Signed-off-by: Marc Véron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12930] Web installer does not show login errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12930] Web installer does not show login errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #12 from Marc Véron --- Changed title and text of commit message, obsoleted previous patch, signed off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12930] Web installer does not show login errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Marc Véron changed: What|Removed |Added Attachment #62116|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12930] Web installer does not show login errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 --- Comment #11 from Marc Véron --- Created attachment 62117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62117&action=edit Bug 12930: Web installer does not show login errors Implemented invalid_username_or_password template variable being handed to Auth.tt. Removed indentation changes and modification to return value of checkpw Test plan: See comment #2 Alternative test plan: - Clear session cookies or close / open your browser - Go to [MY SERVER]/cgi-bin/koha/installer/install.pl - Verify that message appears if wrong username/pw provided - Verify that you can log in with databas administrator account Tested with alternative test plan, works as expected. Title and description in commit message adapted. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12930] Web installer does not show login errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Alex Buckley changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #10 from Alex Buckley --- (in response to Jonathan Druart in comment 8) I have implemented a single patch meeting the requests you asked in comment 8. The comment 2 test plan is still applicable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12930] Web installer does not show login errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 --- Comment #9 from Alex Buckley --- Created attachment 62116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62116&action=edit Bug 12930 - Implemented invalid_username_or_password template variable being handed to Auth.tt. Removed indentation changes and modification to return value of checkpw -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12930] Web installer does not show login errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Alex Buckley changed: What|Removed |Added Attachment #61808|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12930] Web installer does not show login errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Alex Buckley changed: What|Removed |Added Attachment #61807|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12930] Web installer does not show login errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #8 from Jonathan Druart --- Alex, it seems that the only changes you made are: +if ($info{'invalid_username_or_password'} == 1) { +$template->param( 'invalid_username_or_password' => $info{'invalid_username_or_password'}); +} If it is right I would prefer a single patch with only the needed changes instead of indentation changes and modification of the return value of checkpw. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12930] Web installer does not show login errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Marc Véron changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12930] Web installer does not show login errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Marc Véron changed: What|Removed |Added Attachment #61777|0 |1 is obsolete|| --- Comment #7 from Marc Véron --- Created attachment 61808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61808&action=edit Bug 12930 - Followup removing empty else branch Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12930] Web installer does not show login errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Marc Véron changed: What|Removed |Added Attachment #61768|0 |1 is obsolete|| --- Comment #6 from Marc Véron --- Created attachment 61807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61807&action=edit Bug 12930 - Implemented error message display for invalid username or password on web installer login Now InstallAuth.pm hands the invalid_username_or_password variable to the template file auth.tt if the user entered an invalid username or password and this is displayed to the user I tested both patches together by direkctly calling [MY SERVER]/cgi-bin/koha/installer/install.pl?step=1&op=updatestructure Works as expected Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12930] Web installer does not show login errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 --- Comment #5 from Alex Buckley --- Thanks for noticing that Marc, I forgot to remove it. The followup patch I have just attached removes it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12930] Web installer does not show login errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 --- Comment #4 from Alex Buckley --- Created attachment 61777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61777&action=edit Bug 12930 - Followup removing empty else branch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12930] Web installer does not show login errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch --- Comment #3 from Marc Véron --- Hi Alex I do not understand the empty else branch in https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61768&action=diff#a/C4/InstallAuth.pm_sec5 Marc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12930] Web installer does not show login errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Alex Buckley changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #2 from Alex Buckley --- The patch I have attached displays an error message if the user writes in an invalid username and/or password. The InstallAuth.pm module does not contain subroutines to check for permissions, session timeout, or if the ip address is different even though the markup checking for these in the auth.tt has been implemented. Regarding the nopermission check, as I understand it the only password that is valid to be written into this installer login is the database admin credentials and so I don't see why we need the nopermission check in the markup (as is required for the staff interface login). Test plan: 1. Restart memcached: sudo service memcached restart 2. Drop and recreate the database 3. Login with these pretend credentials: username: fred password: password 4. Notice the page refreshes and you get no "invalid username or password" error displayed 5. Apply the patch attached to this bug 6. Try logging in with the same username and password specified in step 3 7. Notice the page refreshes and a "invalid username or password' error message is displayed 8. Now login with the Koha database administrator account and notice you are logged in successfully -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12930] Web installer does not show login errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 --- Comment #1 from Alex Buckley --- Created attachment 61768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61768&action=edit Bug 12930 - Implemented error message display for invalid username or password on web installer login Now InstallAuth.pm hands the invalid_username_or_password variable to the template file auth.tt if the user entered an invalid username or password and this is displayed to the user -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12930] Web installer does not show login errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Alex Buckley changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz |ity.org | CC||alexbuck...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/