[Koha-bugs] [Bug 21357] Filter elisions from index and search terms in Elasticsearch

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

--- Comment #55 from Ere Maijala  ---
Indeed my proposal was just to add elision filtering to the default ES index
config without any code changes. The first patch still does that, but since
then there have been additional ideas incorporated. I think that it would make
sense to create separate bugs for them. 

Then it would only leave us with the question of whether we include elision
filtering in the default configuration or just document this as a possibility.
Either way is fine for me since in Finland we'll need to customize the default
config regardless. I'm not sure how to reach consensus on this. I believe
including filtering by default would make sense regardless of whether the
catalog contains French titles since it helps searching e.g. author names too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21357] Filter elisions from index and search terms in Elasticsearch

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

--- Comment #56 from Katrin Fischer  ---

+1 for default filtering. It's how it works now in the default and we haven't
seen questions or complaints about this. To me it appears to be the expected
behaviour.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21357] Filter elisions from index and search terms in Elasticsearch

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

--- Comment #57 from Katrin Fischer  ---
(In reply to Katrin Fischer from comment #56)
> +1 for default filtering. It's how it works now in the default and we
> haven't seen questions or complaints about this. To me it appears to be the
> expected behaviour.

And welcome back, Ere :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12617] Koha should let admins to configure automatically generated password complexity/difficulty

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12617

Emmi Takkinen  changed:

   What|Removed |Added

 Attachment #107382|0   |1
is obsolete||
 Attachment #107384|0   |1
is obsolete||

--- Comment #9 from Emmi Takkinen  ---
Created attachment 109388
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109388&action=edit
Bug 12617: Koha should let admins to configure automatically generated password
complexity/difficulty

Rebased and reworked patch against bug 23816. Changes made
'PasswordLengthsForCategories' syspref obsolete so patch for it is dropped.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12617] Koha should let admins to configure automatically generated password complexity/difficulty

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12617

Emmi Takkinen  changed:

   What|Removed |Added

 Attachment #107383|0   |1
is obsolete||

--- Comment #10 from Emmi Takkinen  ---
Created attachment 109389
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109389&action=edit
Bug 12617: Add new regex patterns to password_check.inc

Rebased and reworked patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12617] Koha should let admins to configure automatically generated password complexity/difficulty

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12617

Emmi Takkinen  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25101] Add ability to skip previewing results when batch extending due dates

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101

--- Comment #20 from Jonathan Druart  
---
I am not a native English speaker but for me the 2 sentences have opposite
sense.

The hint from Katrin's patch is
  "This is recommended when changing very large numbers of due dates."

Which means: you should check it if you are processing a lot of issues.

It's the reverse, if the checkbox is checked we are going to display the
preview screen, which will fail if the amount of due dates is too large.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25101] Add ability to skip previewing results when batch extending due dates

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101

--- Comment #21 from Katrin Fischer  ---
A new day, maybe the fix is simple:

"This is not recommended when changing very large numbers of due dates."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26045] Search/History.t is failing randomly

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26045

--- Comment #1 from Jonathan Druart  
---
20.05_U16 #57 (Docker_2)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26031] www/search_utf8.t is failing randomly

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26031

--- Comment #16 from Jonathan Druart  
---
Koha_20.05_U18 #61 (Docker_3)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26332] Koha::Account::pay incorrectly defaults to '0' for manager_id

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26332

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||22008


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008
[Bug 22008] accountlines.manager_id is missing a foreign key constraint
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26332] New: Koha::Account::pay incorrectly defaults to '0' for manager_id

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26332

Bug ID: 26332
   Summary: Koha::Account::pay incorrectly defaults to '0' for
manager_id
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Fines and fees
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

Since bug 22008 we have a foreign key constraint for manager_id against the
borrowers table; However, we neglected to update the 'pay' routing in
Koha::Account to reflect this non-required field and left it to default to '0'
which may not be a borrower at all.

We should allow 'undef' to be passed into 'pay' unaltered when the interface is
anything other than 'staff'.. as it may reflect a SIP or OPAC payment where no
staff member is required to be present.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||26332


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26332
[Bug 26332] Koha::Account::pay incorrectly defaults to '0' for manager_id
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26332] Koha::Account::pay incorrectly defaults to '0' for manager_id

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26332

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||26332


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26332
[Bug 26332] Koha::Account::pay incorrectly defaults to '0' for manager_id
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26332] Koha::Account::pay incorrectly defaults to '0' for manager_id

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26332

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||14825


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26332] Koha::Account::pay incorrectly defaults to '0' for manager_id

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26332

--- Comment #1 from Martin Renvoize  ---
Hmm.. 

The data in question is coming from the userenv.. so in theory should always be
set and not require a fallback at all.

I think this perhaps highlights an issue in some plugin code not setting
userenv properly in my case.. but I still feel we should not be defaulting back
to '0' and exploding..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #205 from Jonathan Druart  
---
Created attachment 109391
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109391&action=edit
Bug 22417: Add tests

Finally!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #204 from Jonathan Druart  
---
Created attachment 109390
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109390&action=edit
Bug 22417: Remove $dbh in Koha::BackgroundJob::*

Also remove unused $job_type var

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #208 from Jonathan Druart  
---
Created attachment 109394
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109394&action=edit
Bug 22417: Add Koha::BackgroundJob[s]

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Cook 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #209 from Jonathan Druart  
---
Created attachment 109395
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109395&action=edit
Bug 22417: Add Koha::BackgroundJob::BatchUpdateBiblio

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Cook 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #207 from Jonathan Druart  
---
Created attachment 109393
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109393&action=edit
Bug 22417: DBIX Schema changes

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Cook 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #109319|0   |1
is obsolete||
 Attachment #109320|0   |1
is obsolete||
 Attachment #109321|0   |1
is obsolete||
 Attachment #109322|0   |1
is obsolete||
 Attachment #109323|0   |1
is obsolete||
 Attachment #109324|0   |1
is obsolete||
 Attachment #109325|0   |1
is obsolete||
 Attachment #109326|0   |1
is obsolete||
 Attachment #109327|0   |1
is obsolete||
 Attachment #109328|0   |1
is obsolete||
 Attachment #109329|0   |1
is obsolete||
 Attachment #109330|0   |1
is obsolete||
 Attachment #109331|0   |1
is obsolete||
 Attachment #109332|0   |1
is obsolete||
 Attachment #109333|0   |1
is obsolete||
 Attachment #109334|0   |1
is obsolete||
 Attachment #109335|0   |1
is obsolete||
 Attachment #109336|0   |1
is obsolete||
 Attachment #109337|0   |1
is obsolete||
 Attachment #109338|0   |1
is obsolete||
 Attachment #109339|0   |1
is obsolete||
 Attachment #109340|0   |1
is obsolete||
 Attachment #109341|0   |1
is obsolete||
 Attachment #109342|0   |1
is obsolete||
 Attachment #109343|0   |1
is obsolete||
 Attachment #109344|0   |1
is obsolete||
 Attachment #109345|0   |1
is obsolete||
 Attachment #109350|0   |1
is obsolete||
 Attachment #109351|0   |1
is obsolete||
 Attachment #109355|0   |1
is obsolete||
 Attachment #109390|0   |1
is obsolete||
 Attachment #109391|0   |1
is obsolete||

--- Comment #206 from Jonathan Druart  
---
Created attachment 109392
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109392&action=edit
Bug 22417: UpdateDB entry

TODO:
- Add the FK on borrowernumber

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Cook 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #210 from Jonathan Druart  
---
Created attachment 109396
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109396&action=edit
Bug 22417: Add Koha::BackgroundJob::BatchUpdateAuthority

This is not ready yet!

Note that this is too close to Koha::BackgroundJob::BatchUpdateBiblio,
we will want to refactor bit of code.

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Cook 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #213 from Jonathan Druart  
---
Created attachment 109399
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109399&action=edit
Bug 22417: Add the ability to cancel a job

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Cook 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #211 from Jonathan Druart  
---
Created attachment 109397
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109397&action=edit
Bug 22417: Add GUI to watch the progress of jobs

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Cook 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #215 from Jonathan Druart  
---
Created attachment 109401
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109401&action=edit
Bug 22417: Add debian script koha-worker

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Cook 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #212 from Jonathan Druart  
---
Created attachment 109398
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109398&action=edit
Bug 22417: Adapt the batch_record_modification tool

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Cook 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #214 from Jonathan Druart  
---
Created attachment 109400
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109400&action=edit
Bug 22417: Fix borrowernumber values

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Cook 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #217 from Jonathan Druart  
---
Created attachment 109403
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109403&action=edit
Bug 22417: Handle errors

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Cook 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #218 from Jonathan Druart  
---
Created attachment 109404
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109404&action=edit
Bug 22417: Try to display pending jobs - only work if worker not started

ie. no subscription yet

This needs to be fixed (if possible), or removed from the patchset

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Cook 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #216 from Jonathan Druart  
---
Created attachment 109402
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109402&action=edit
Bug 22417: Switch to STOMP

apt install rabbitmq-server
service rabbitmq-server start
rabbitmq-plugins enable rabbitmq_stomp
apt install libnet-stomp-perl
cp debian/scripts/koha-functions.sh /usr/share/koha/bin/koha-functions.sh
cp debian/scripts/koha-worker /usr/bin/
koha-worker --start kohadev
tail -f /var/log/rabbitmq/*

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Cook 

Signed-off-by: Marcel de Rooy 

Bug 22417: Remove useless use statement

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #220 from Jonathan Druart  
---
Created attachment 109406
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109406&action=edit
Bug 22417: Restore the concept of namespace

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Cook 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #219 from Jonathan Druart  
---
Created attachment 109405
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109405&action=edit
Bug 22417: Fix the batch authority tool

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Cook 

Signed-off-by: Marcel de Rooy 

Bug 22417: Add a note about the existence of the DB row

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Cook 

Signed-off-by: Marcel de Rooy 

Bug 22417: (follow-up) Fix the batch authority tool

Signed-off-by: David Cook 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #224 from Jonathan Druart  
---
Created attachment 109410
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109410&action=edit
Bug 22417: Remove record_type from BatchUpdate*

We don't need to pass it to the job, they each know which record type
they are dealing with

Signed-off-by: David Cook 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #222 from Jonathan Druart  
---
Created attachment 109408
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109408&action=edit
Bug 22417: Add the new permission manage_background_jobs

QA: Please answer the question in admin/background_jobs.pl

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Cook 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #221 from Jonathan Druart  
---
Created attachment 109407
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109407&action=edit
Bug 22417: Restore the 'add to list' feature

This feature has been added recently by bug 18127.

It highlights the need of a post processing hook.

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Cook 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #225 from Jonathan Druart  
---
Created attachment 109411
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109411&action=edit
Bug 22417: Let owner of a job see the progress

A owner of a job should be able to see the progress of this job.

Signed-off-by: David Cook 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #223 from Jonathan Druart  
---
Created attachment 109409
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109409&action=edit
Bug 22417: Send message to /queue

This cannot be:
  /queue/$namespace/$job_type

I got: '/koha_kohadev/batch_biblio_record_modification' is not a valid queue
destination

So keeping the dash in $namespace-$job_type

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Cook 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #228 from Jonathan Druart  
---
Created attachment 109414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109414&action=edit
Bug 22417: Add new Net::Stomp dependency

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #226 from Jonathan Druart  
---
Created attachment 109412
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109412&action=edit
Bug 22417: Remove FIXME in the template

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #229 from Jonathan Druart  
---
Created attachment 109415
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109415&action=edit
Bug 22417: Fix spelling resizeable vs resizable

For the record, codespell does not raise the problem within ktd with
1.17.1 but appears with 1.14

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #227 from Jonathan Druart  
---
Created attachment 109413
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109413&action=edit
Bug 22417: Add missing POD and html filters

Also remove "authnotrequired => 0,"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #232 from Jonathan Druart  
---
Created attachment 109418
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109418&action=edit
Bug 22417: [DO NOT PUSH] Add simple worker and add_job scripts

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #230 from Jonathan Druart  
---
Created attachment 109416
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109416&action=edit
Bug 22417: Remove $dbh in Koha::BackgroundJob::*

Also remove unused $job_type var

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #231 from Jonathan Druart  
---
Created attachment 109417
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109417&action=edit
Bug 22417: Add tests

Finally!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #233 from Jonathan Druart  
---
I squashed some patches (the easy ones), more squashes could be done but
changes will have to be split (so more work and not much added value IMO).

I put the 2 test scripts on a separate commit (for history).

Julian, do you want to have another look?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26299] Help text for OPAC SMS number should be less North American-centric

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299

--- Comment #6 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #4)
> Nick, are you ok with this?

I checked with our educators - their concern is that it not start with 1, which
is the indicator of 'long distance' calls here.

9785550123 would be better as it won't end up being a real phone number
https://en.wikipedia.org/wiki/555_(telephone_number)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

--- Comment #92 from Jonathan Druart  
---
Created attachment 109419
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109419&action=edit
Bug 19889: Add new attribute to the REST API definition

It fixes t/db_dependent/api/v1/items.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25504] Wrong API spec breaks plack without meaningful error

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25504

--- Comment #26 from Jonathan Druart  
---
Created attachment 109420
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109420&action=edit
Bug 25504: Fix failing tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25504] Wrong API spec breaks plack without meaningful error

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25504

--- Comment #27 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #26)
> Created attachment 109420 [details] [review]
> Bug 25504: Fix failing tests

Pushed to master for 20.11.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

--- Comment #93 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #92)
> Created attachment 109419 [details] [review]
> Bug 19889: Add new attribute to the REST API definition
> 
> It fixes t/db_dependent/api/v1/items.t

Pushed to master for 20.11.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26316] Add the option to un-lost an item on claim return resolution

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26316

--- Comment #1 from Kelly McElligott  ---
Tomas, 
I understand the purpose of doing this for claim returned, however, I do see a
larger need for the entire LOST status to have this functionality.  It would be
nice to not have only one LOST status have the capability to remove the LOST
status and not the others.  A great deal of libraries would appreciate the
ability to remove the LOST status without having to check it in and go through
the credit process.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26308] Normal view (vue normale) is not displayed in French

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26308

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
Caroline, the problem should be fixed for 19.11.x too apparently, and maybe
19.05 (needs to be confirmed).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19382] Add ability to block guarantees based on fees owed by guarantor and other guarantees

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382

--- Comment #27 from Jonathan Druart  
---
With only the 2 first patches applied:

153 is( $child_1->relationships_debt({ only_this_guarantor => 0,
include_guarantors => 0, include_this_patron => 0 }), 10, 'Family debt is
correct' );

157 is( $child_1->relationships_debt({ only_this_guarantor => 1,
include_guarantors => 0, include_this_patron => 0 }), 0, 'Family debt is
correct' );

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26320] Crash when click search button with empty key word

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26320

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25624] Update patrons category script should allow finding null and not null and wildcards

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25624] Update patrons category script should allow finding null and not null and wildcards

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624

Nick Clemens  changed:

   What|Removed |Added

 Attachment #109370|0   |1
is obsolete||

--- Comment #17 from Nick Clemens  ---
Created attachment 109421
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109421&action=edit
Bug 25624: Add more flexibily with --where and literal search

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26330] jQueryUI tabs don't work with non-Latin-1 characters

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26330

Owen Leonard  changed:

   What|Removed |Added

Summary|Subfields constraints   |jQueryUI tabs don't work
   |editor should hide all new  |with non-Latin-1 characters
   |others subfields|

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26333] New: "In" analytics link incorrectly formed when "UseControlNumber" set to "Don't use"

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26333

Bug ID: 26333
   Summary: "In" analytics link incorrectly formed when
"UseControlNumber" set to "Don't use"
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

The "In" links for analytics don't work if not using control numbers

To test:
- Pick any serial record in your database, make sure 001 is set
- Go to new > new child record
- Fill in 245 and save
- Click on the "In" link, it will not find the record
- Look at the link, it is performing a title,phrase search but populating the
link with both the author and title

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26333] "In" analytics link incorrectly formed when "UseControlNumber" set to "Don't use"

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26333

Nick Clemens  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26330] jQueryUI tabs don't work with non-Latin-1 characters

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26330

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26330] jQueryUI tabs don't work with non-Latin-1 characters

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26330

--- Comment #1 from Owen Leonard  ---
Created attachment 109422
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109422&action=edit
Bug 26330: Change encoding of text used as tab triggers in MARC subfield
constraints

This patch changes the encoding of the data being used to define
jQueryUI tabs on the MARC subfield constraints page. A jQueryUI bug
prevents non-Latin-1 characters from being used when defining tab
controls. Using Template:Toolkit's "uri" filter converts the data to
usable characters.

To test, apply the patch and go to Administration -> MARC frameworks ->
MARC structure -> tag 952 -> Edit subfields.

- Under the "New" tab, add a subfield code which is outside the basic
  Latin character set, e.g. £, §, æ.
- Save changes.
- Edit any subfield code to load the subfield constraints page again.
- Test that the subfield code tabs work correctly: Clicking each tab
  should load only the corresponding panel.
- Test a variety of tabs including the one you created with the
  non-Latin character.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26334] New: Move translatable strings out of members-menu.inc into members-menu.js

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26334

Bug ID: 26334
   Summary: Move translatable strings out of members-menu.inc into
members-menu.js
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Depends on: 21156

Strings defined for translation in members-menu.inc can now be wrapped in the
new translation function and put in members-menu.js.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156
[Bug 21156] Internationalization: plural forms, context, and more for JS files
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25624] Update patrons category script should allow finding null and not null and wildcards

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||and...@bywatersolutions.com

--- Comment #18 from Andrew Fuerste-Henry  ---
I get a SQL error whenever I run this without a --where defined.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156

Owen Leonard  changed:

   What|Removed |Added

 Blocks||26334


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26334
[Bug 26334] Move translatable strings out of members-menu.inc into
members-menu.js
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26313] "Show analytics" link doesn't work with Elasticsearch and UseControlNumber

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26313] "Show analytics" link doesn't work with Elasticsearch and UseControlNumber

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26313] "Show analytics" link doesn't work with Elasticsearch and UseControlNumber

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313

--- Comment #1 from Nick Clemens  ---
Created attachment 109423
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109423&action=edit
Bug 26313: "Show analytics" link must use uppercase for booleans

In elasticsearch we only treat AND and OR as boolean operators if
they are capitalized

To test:
- Turn SearchEngine to Elasticsearch and make sure it works
- Pick any serial record in your database, make sure 001 is set
- Go to new > new child record
- Fill in 245 and save
- Click on the "In" link, it should bring you to the parent record
- Click on "Show analytics" => there will be no result
- Apply patch
- restart and reload
- Try again
- It works!
- Switch SearchEngine syspref to 'Zebra'
- Test again
- It still works!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19382] Add ability to block guarantees based on fees owed by guarantor and other guarantees

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382

--- Comment #28 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #27)
> With only the 2 first patches applied:
> 
> 153 is( $child_1->relationships_debt({ only_this_guarantor => 0,
> include_guarantors => 0, include_this_patron => 0 }), 10, 'Family debt is
> correct' );

In this case, we are not specifying only_this_guarantor, and we are specifying
not to include this patron, and not to include the guarantors themselves, so
the code will total the charges from the guarantors other guarantees. Since the
sibling owes 10, the returned value is 10.

> 157 is( $child_1->relationships_debt({ only_this_guarantor => 1,
> include_guarantors => 0, include_this_patron => 0 }), 0, 'Family debt is
> correct' );

This one is much simpler, since only_this_guarantor is specified, but the
patron is not a guarantor, there are no guarantors to check. No guarantors
means no guarantees so the total returned is 0.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26313] "Show analytics" link doesn't work with Elasticsearch and UseControlNumber

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313

--- Comment #2 from Tomás Cohen Arazi  ---
Well, this is interesting. Shouldn't we make the query parser handle things
without case sensitivity?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25101] Add ability to skip previewing results when batch extending due dates

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101

--- Comment #22 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #20)
> I am not a native English speaker but for me the 2 sentences have opposite
> sense.
> 
> The hint from Katrin's patch is
>   "This is recommended when changing very large numbers of due dates."
> 
> Which means: you should check it if you are processing a lot of issues.
> 
> It's the reverse, if the checkbox is checked we are going to display the
> preview screen, which will fail if the amount of due dates is too large.

Ah! That wasn't clicking for me, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25101] Add ability to skip previewing results when batch extending due dates

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101

--- Comment #23 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #21)
> A new day, maybe the fix is simple:
> 
> "This is not recommended when changing very large numbers of due dates."

Perfect!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26334] Move translatable strings out of members-menu.inc into members-menu.js

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26334

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26334] Move translatable strings out of members-menu.inc into members-menu.js

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26334

--- Comment #1 from Owen Leonard  ---
Created attachment 109424
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109424&action=edit
Bug 26334: Move translatable strings out of members-menu.inc into
members-menu.js

This patch moves translatable strings out of members-menu.inc into
members-menu.js where they can be translated using the double-underscore
i18n function.

To test, apply the patch and go to Patrons.

- Expand the search options in the search header by clicking the [+]
  link.
- Select "Date of birth" from the "Search fields" dropdown.
  - A tooltip should appear above the search form, "Dates of birth
should be entered in the format..." with your current date format.
- Remove all "Adult" type patron categories but one.
  - Check out to a child patron.
  - From the "More" menu choose "Update child to adult patron."
  - You should see a confirmation.
- From the checkout screen, from the "More" menu, choose "Renew patron"
  - You should get a confirmation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25101] Add ability to skip previewing results when batch extending due dates

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25101] Add ability to skip previewing results when batch extending due dates

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101

--- Comment #24 from Kyle M Hall  ---
Created attachment 109425
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109425&action=edit
Bug 25101: (QA follow-up) Fix hint for new option

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #267 from Jonathan Druart  
---
Remote branch has been rebased against master, few tweaks made:
* new commit "Bug 20271: Fix - is_current is nullable"
* Only 1 "DBIC changes" commit and a separate "Declare is_current as boolean in
schema" to deal with is_boolean.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26335] New: Aku

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26335

Bug ID: 26335
   Summary: Aku
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Web services
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: xaiha...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 109426
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109426&action=edit
Sayank

Sayang kamu

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26336] New: Cannot import items if items ignored when staging

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26336

Bug ID: 26336
   Summary: Cannot import items if items ignored when staging
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

When staging marc records you have the option to process or ignore items.

If you choose to ignore you can change the option after staging, however, items
are not processed unless they are parsed in initial staging

To test:
0 - Check the count of import_items
SELECT COUNT(*) FROM import_items;
1 - Import a marc file with items , process the items
2 - Check the count of import items, it has increased
3 - Stage the file again, do not process items
4 - Count of import_items has not increased
5 - Manage the stage batch, process items and reapply
6 - Check the count of import_items, no change
7 - Import the file, no items are processed

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25624] Update patrons category script should allow finding null and not null and wildcards

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #107291|0   |1
is obsolete||
 Attachment #107292|0   |1
is obsolete||
 Attachment #109421|0   |1
is obsolete||

--- Comment #19 from Jonathan Druart  
---
Created attachment 109427
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109427&action=edit
Bug 25624: Add --where option to update_patrons_category.pl

The script did not allow to find empty fields or use wildcards

With this new option we will now have the ability to filter patrons by
some of their attributes.

Test plan:
1 - Run the script with no parameters and verify the help explains the
parameters
2 - Try the script with one or more --where parameters, like:
  --where "firstname='koha'"
3 - Test null values
  --where "firstname IS NULL"
4 - Test like values with wildcards
  --where "firstname LIKE '%a%'
5 - Test like with the word null to find fields containing the word rather than
being unset

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25624] Update patrons category script should allow finding null and not null and wildcards

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25624] Update patrons category script should allow finding null and not null and wildcards

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624

Jonathan Druart  changed:

   What|Removed |Added

 QA Contact|alex.arn...@biblibre.com|
   Assignee|n...@bywatersolutions.com   |jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26313] "Show analytics" link doesn't work with Elasticsearch and UseControlNumber

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313

--- Comment #3 from Katrin Fischer  ---
(In reply to Tomás Cohen Arazi from comment #2)
> Well, this is interesting. Shouldn't we make the query parser handle things
> without case sensitivity?

I see an advantage of this behaviour. If a record title contains 'and' or 'or'
they won't get seen as boolean operators (= less accidental booleans). I
believe that this is an issue with Zebra currently, but couldn't locate the
right bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26335] SPAM

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26335

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |INVALID
Summary|Aku |SPAM
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26308] Normal view (vue normale) is not displayed in French

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26308

--- Comment #4 from Caroline Cyr La Rose  ---
Hi Jonathan,

I did the same corrections on Pootle for 19.11, 19.05 and 18.11.

Caroline

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26332] Koha::Account::pay incorrectly defaults to '0' for manager_id

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26332

--- Comment #2 from Martin Renvoize  ---
Created attachment 109430
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109430&action=edit
Bug 26332: Remove hard coded '0' for manager_id

This patch removes the fallback to '0' for the manager_id in
Koha::Account::pay. This will only affect plugins that contain a
background callback that doesn't set the user environment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26337] New: Remove unused authorities script should skip merge

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26337

Bug ID: 26337
   Summary: Remove unused authorities script should skip merge
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

Remove unused authorities checks if an authority is used

If not it calls DelAuthority

DelAuthority checks if the authority is used and removes it from records if it
is.

We should pass 'skip_merge' when calling form this script as we have already
checked the usage here

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26337] Remove unused authorities script should skip merge

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26337

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |
   Severity|enhancement |normal
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19382] Add ability to block guarantees based on fees owed by guarantor and other guarantees

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382

Jonathan Druart  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com, tomasco...@gmail.com

--- Comment #29 from Jonathan Druart  
---
This is confusing to me.
First, child_1 is not a guarantor so only_this_guarantor should not modify the
returned value. Then, in the same logic, only_this_guarantor should not have
any effects if include_guarantors is not set.

Asking Tomas and Martin for additional feedbacks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26337] Remove unused authorities script should skip merge

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26337

--- Comment #1 from Nick Clemens  ---
Created attachment 109431
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109431&action=edit
Bug 26337: Pass skip_merge to DelAuthority when removing unsused authorities

This script checks that an authority is not being used before deleting it.
We do not need to check biblios for the authority id as we have already
verified it is unused.

TO test:
 1 - Reset db to koha test database
 2 - perl misc/migration_tools/remove_unused_authorities.pl -t
 3 - Note a number of unsued authorities
 4 - perl misc/migration_tools/remove_unused_authorities.pl -c
 5 - Note authorities are removed
 6 - Reset db
 7 - Apply patch
 8 - perl misc/migration_tools/remove_unused_authorities.pl -t
 9 - Note results are the same
10 - perl misc/migration_tools/remove_unused_authorities.pl -c
11 - Note results are the same

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26337] Remove unused authorities script should skip merge

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26337

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #234 from Julian Maurice  ---
Sorry, there is a new error from QA script:

 FAIL   t/lib/Koha/BackgroundJob/BatchTest.pm   
   FAIL   pod coverage
POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666

Once it is fixed, I think it safe to change status back to Passed QA, since 2
QAers already added their signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26338] New: Show tool plugins run in tools home

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26338

Bug ID: 26338
   Summary: Show tool plugins run in tools home
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Plugin architecture
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

In tools home there is a link to the table showing tool plugins.
Would be great to be able to run a tool plugin directly from tools home.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156

Owen Leonard  changed:

   What|Removed |Added

 Blocks||26339


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26339
[Bug 26339] Move translatable strings out of addorderiso2709.tt into
addorderiso2709.js
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26338] Show tool plugins run in tools home

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26338

Fridolin SOMERS  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co
   |ity.org |m
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26339] New: Move translatable strings out of addorderiso2709.tt into addorderiso2709.js

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26339

Bug ID: 26339
   Summary: Move translatable strings out of addorderiso2709.tt
into addorderiso2709.js
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Depends on: 21156

Strings defined for translation in addorderiso2709.tt can now be wrapped in the
new translation function and put in addorderiso2709.js.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156
[Bug 21156] Internationalization: plural forms, context, and more for JS files
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26338] Show tool plugins run in tools home

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26338

--- Comment #1 from Fridolin SOMERS  ---
Created attachment 109432
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109432&action=edit
Screenshot

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26338] Show tool plugins run in tools home

2020-09-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26338

--- Comment #2 from Fridolin SOMERS  ---
(In reply to Fridolin SOMERS from comment #1)
> Created attachment 109432 [details]
> Screenshot

With the example of plugin Carrousel
https://inlibro.com/instructions-carrousel/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >