Re: Review Request 124721: Adapt CMakeLists.txt to kf5

2017-10-04 Thread Luigi Toscano 


> On Set. 30, 2017, 8:10 p.m., Luigi Toscano wrote:
> > Can this be dropped? The kf5 branch is way more updated.
> > 
> > @rharishnavnit (and all the others), can you please recheck which of your 
> > patches are outdated and can be dropped (because already applied or not 
> > relevant anymore)?
> 
> R.Harish  Navnit wrote:
> The KF5 branch might be way more updated but it needs a through review 
> before merging to master. I understand porting work was carried on during 
> this year's Google Summer of Code and I'm not sure if this was fixed during 
> the same. I haven't been following the updates lately, sorry.
> 
> Luigi Toscano wrote:
> I'm not talking about merging to master: my question was specifically 
> about this patch. Is it correct that the code in the kf5 branch is more 
> advanced than this patch? I think so; in this case please drop this review.

The patch itself is lost, but it was probably covered by the following commit:
https://commits.kde.org/kopete/cedf02769d84e6ecb53aefefd17a5123052b0cc2


- Luigi


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124721/#review103753
---


On Ago. 12, 2015, 10:19 p.m., R.Harish  Navnit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124721/
> ---
> 
> (Updated Ago. 12, 2015, 10:19 p.m.)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> ---
> 
> Changes obtained by running the kde-dev-scripts/adapt_cmakelists_file script. 
> Adapt CMakeLists.txt for kf5 port.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 24479a4fb2e679f97d6685d832fa46e9e5e62cd8 
>   doc-dev/t2/CMakeLists.txt 0ef0d1c42a33beb9b91c7389317bd7c403d0558d 
>   doc-dev/t3/CMakeLists.txt f41a2f841946a852eb071a4429bda31dfa1095d3 
>   doc/CMakeLists.txt 91c3e23df02510f1165a8ee33e47362cb71fc350 
>   icons/CMakeLists.txt 02e3c9ecf2e80622b6cb3a816c89cba556b500a8 
>   kopete/CMakeLists.txt 8097f41cf60f1ad3dfdd3de9212703aa1883a67a 
>   kopete/addaccountwizard/CMakeLists.txt 
> e49bf672f4b19eecfa26281fe4a24b91d7aa4a6c 
>   kopete/chatwindow/CMakeLists.txt 62e395b07ba2499178b7f7dc90714221e3396fb2 
>   kopete/chatwindow/a11y/CMakeLists.txt 
> f20cf4404ee0d21b224bf6d2c1cf849db29401de 
>   kopete/chatwindow/tests/CMakeLists.txt 
> adc6129fb6a08a69d63d27d3c5642c32af76805d 
>   kopete/config/accounts/CMakeLists.txt 
> f0a463d187df10ea9e4f6a79aceb2a8e7b09e866 
>   kopete/config/appearance/CMakeLists.txt 
> abfe7aef01d7de40f8a50341e6155def2b76ecab 
>   kopete/config/avdevice/CMakeLists.txt 
> c4e3eb2a44383bcd237afe6406907692040ef0b6 
>   kopete/config/behavior/CMakeLists.txt 
> bba08e0725068e00b85d182008b55aa4e6b1e83b 
>   kopete/config/chatwindow/CMakeLists.txt 
> 89e6faec8310da9e63c6ab1253b3db4fba38b6d3 
>   kopete/config/plugins/CMakeLists.txt 
> 5dc269d072d86662647d189c3fa887406ab8c2bd 
>   kopete/config/status/CMakeLists.txt 
> 8cab8f1cfb735bb81663a8e47e394c0f08458562 
>   kopete/contactlist/CMakeLists.txt 2219addf953accacf39d534f1a2cd74438b1e295 
>   kopete/identity/CMakeLists.txt e42c4b423af2b7ea091ef138f93225535f68a5eb 
>   kopete/statusmenu/CMakeLists.txt 6ef9e813d983d83e9c4aabe8a6c6324881b53908 
>   libkopete/CMakeLists.txt c1df8437803bc43461529d296defdbf7134fbaea 
>   libkopete/avdevice/CMakeLists.txt d91f4c81a6855fa66a0e6eddaf9db5106a91c146 
>   libkopete/tests/CMakeLists.txt 78e489a17a6c4393adc903232439b47fdecb16df 
>   plugins/CMakeLists.txt 86fe572a13898f4c6c9e26a33f51e4a0786c898b 
>   plugins/addbookmarks/CMakeLists.txt 
> 84fe18c20fae30af8ac025ec7b1f59ce86709089 
>   plugins/alias/CMakeLists.txt ddfe3c24df9b3668e1b3194e626c22b2f6bb55b6 
>   plugins/autoreplace/CMakeLists.txt a7a2e90402a503d5ced1166e55bcb82189f1f8ff 
>   plugins/autoreplace/icons/CMakeLists.txt 
> c62b24b1187bce066c7b7438a980b79f3954851f 
>   plugins/contactnotes/CMakeLists.txt 
> 3742e4b9304f9dcefa82291268691dba5129e590 
>   plugins/cryptography/CMakeLists.txt 
> f1faffac6ed17209195194242889521a03d34f4d 
>   plugins/highlight/CMakeLists.txt eb892732f1008bf78150074abf0b96ee6d5017b8 
>   plugins/highlight/icons/CMakeLists.txt 
> 1a9fa43e0cbf836dae76112c55ccd69b709f67f1 
>   plugins/history/CMakeLists.txt 015df954111a843ba464fe510a3404abc856ce73 
>   plugins/history2/CMakeLists.txt 195edf63462568c5ab3da85ac600422c6eaab6fa 
>   plugins/latex/CMakeLists.txt 7ab71de615f21d30019e26e0c197153ac4b37ab8 
>   plugins/latex/icons/CMakeLists.txt 321add4f82d42b7fb7072b6022457b15a446b30a 
>   plugins/nowlistening/CMakeLists.txt 
> d910afc14c00c4bac80b934753aadb70561d 
>   plugins/otr/CMakeLists.txt f291e55cdd3604138ecbf4220939b0fb121c327f 
>   plugins/otr/icons/CMakeLists.txt 106884f432c1d1e0b0584959af854c79ede4ea6d 
>

Re: Review Request 124721: Adapt CMakeLists.txt to kf5

2017-10-01 Thread Luigi Toscano 


> On Set. 30, 2017, 8:10 p.m., Luigi Toscano wrote:
> > Can this be dropped? The kf5 branch is way more updated.
> > 
> > @rharishnavnit (and all the others), can you please recheck which of your 
> > patches are outdated and can be dropped (because already applied or not 
> > relevant anymore)?
> 
> R.Harish  Navnit wrote:
> The KF5 branch might be way more updated but it needs a through review 
> before merging to master. I understand porting work was carried on during 
> this year's Google Summer of Code and I'm not sure if this was fixed during 
> the same. I haven't been following the updates lately, sorry.

I'm not talking about merging to master: my question was specifically about 
this patch. Is it correct that the code in the kf5 branch is more advanced than 
this patch? I think so; in this case please drop this review.


- Luigi


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124721/#review103753
---


On Ago. 12, 2015, 10:19 p.m., R.Harish  Navnit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124721/
> ---
> 
> (Updated Ago. 12, 2015, 10:19 p.m.)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> ---
> 
> Changes obtained by running the kde-dev-scripts/adapt_cmakelists_file script. 
> Adapt CMakeLists.txt for kf5 port.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 24479a4fb2e679f97d6685d832fa46e9e5e62cd8 
>   doc-dev/t2/CMakeLists.txt 0ef0d1c42a33beb9b91c7389317bd7c403d0558d 
>   doc-dev/t3/CMakeLists.txt f41a2f841946a852eb071a4429bda31dfa1095d3 
>   doc/CMakeLists.txt 91c3e23df02510f1165a8ee33e47362cb71fc350 
>   icons/CMakeLists.txt 02e3c9ecf2e80622b6cb3a816c89cba556b500a8 
>   kopete/CMakeLists.txt 8097f41cf60f1ad3dfdd3de9212703aa1883a67a 
>   kopete/addaccountwizard/CMakeLists.txt 
> e49bf672f4b19eecfa26281fe4a24b91d7aa4a6c 
>   kopete/chatwindow/CMakeLists.txt 62e395b07ba2499178b7f7dc90714221e3396fb2 
>   kopete/chatwindow/a11y/CMakeLists.txt 
> f20cf4404ee0d21b224bf6d2c1cf849db29401de 
>   kopete/chatwindow/tests/CMakeLists.txt 
> adc6129fb6a08a69d63d27d3c5642c32af76805d 
>   kopete/config/accounts/CMakeLists.txt 
> f0a463d187df10ea9e4f6a79aceb2a8e7b09e866 
>   kopete/config/appearance/CMakeLists.txt 
> abfe7aef01d7de40f8a50341e6155def2b76ecab 
>   kopete/config/avdevice/CMakeLists.txt 
> c4e3eb2a44383bcd237afe6406907692040ef0b6 
>   kopete/config/behavior/CMakeLists.txt 
> bba08e0725068e00b85d182008b55aa4e6b1e83b 
>   kopete/config/chatwindow/CMakeLists.txt 
> 89e6faec8310da9e63c6ab1253b3db4fba38b6d3 
>   kopete/config/plugins/CMakeLists.txt 
> 5dc269d072d86662647d189c3fa887406ab8c2bd 
>   kopete/config/status/CMakeLists.txt 
> 8cab8f1cfb735bb81663a8e47e394c0f08458562 
>   kopete/contactlist/CMakeLists.txt 2219addf953accacf39d534f1a2cd74438b1e295 
>   kopete/identity/CMakeLists.txt e42c4b423af2b7ea091ef138f93225535f68a5eb 
>   kopete/statusmenu/CMakeLists.txt 6ef9e813d983d83e9c4aabe8a6c6324881b53908 
>   libkopete/CMakeLists.txt c1df8437803bc43461529d296defdbf7134fbaea 
>   libkopete/avdevice/CMakeLists.txt d91f4c81a6855fa66a0e6eddaf9db5106a91c146 
>   libkopete/tests/CMakeLists.txt 78e489a17a6c4393adc903232439b47fdecb16df 
>   plugins/CMakeLists.txt 86fe572a13898f4c6c9e26a33f51e4a0786c898b 
>   plugins/addbookmarks/CMakeLists.txt 
> 84fe18c20fae30af8ac025ec7b1f59ce86709089 
>   plugins/alias/CMakeLists.txt ddfe3c24df9b3668e1b3194e626c22b2f6bb55b6 
>   plugins/autoreplace/CMakeLists.txt a7a2e90402a503d5ced1166e55bcb82189f1f8ff 
>   plugins/autoreplace/icons/CMakeLists.txt 
> c62b24b1187bce066c7b7438a980b79f3954851f 
>   plugins/contactnotes/CMakeLists.txt 
> 3742e4b9304f9dcefa82291268691dba5129e590 
>   plugins/cryptography/CMakeLists.txt 
> f1faffac6ed17209195194242889521a03d34f4d 
>   plugins/highlight/CMakeLists.txt eb892732f1008bf78150074abf0b96ee6d5017b8 
>   plugins/highlight/icons/CMakeLists.txt 
> 1a9fa43e0cbf836dae76112c55ccd69b709f67f1 
>   plugins/history/CMakeLists.txt 015df954111a843ba464fe510a3404abc856ce73 
>   plugins/history2/CMakeLists.txt 195edf63462568c5ab3da85ac600422c6eaab6fa 
>   plugins/latex/CMakeLists.txt 7ab71de615f21d30019e26e0c197153ac4b37ab8 
>   plugins/latex/icons/CMakeLists.txt 321add4f82d42b7fb7072b6022457b15a446b30a 
>   plugins/nowlistening/CMakeLists.txt 
> d910afc14c00c4bac80b934753aadb70561d 
>   plugins/otr/CMakeLists.txt f291e55cdd3604138ecbf4220939b0fb121c327f 
>   plugins/otr/icons/CMakeLists.txt 106884f432c1d1e0b0584959af854c79ede4ea6d 
>   plugins/pipes/CMakeLists.txt a3ea9ba26e71ccaa01d7565b522af08be06a446a 
>   plugins/pipes/tests/CMakeLists.txt 1018c9d8c7cb357b00a5b1f36137271df0240d2b 
>   plugins/privacy/CMakeLists.txt

Re: Review Request 124721: Adapt CMakeLists.txt to kf5

2017-09-30 Thread Luigi Toscano 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124721/#review103753
---



Can this be dropped? The kf5 branch is way more updated.

@rharishnavnit (and all the others), can you please recheck which of your 
patches are outdated and can be dropped (because already applied or not 
relevant anymore)?

- Luigi Toscano


On Ago. 12, 2015, 10:19 p.m., R.Harish  Navnit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124721/
> ---
> 
> (Updated Ago. 12, 2015, 10:19 p.m.)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> ---
> 
> Changes obtained by running the kde-dev-scripts/adapt_cmakelists_file script. 
> Adapt CMakeLists.txt for kf5 port.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 24479a4fb2e679f97d6685d832fa46e9e5e62cd8 
>   doc-dev/t2/CMakeLists.txt 0ef0d1c42a33beb9b91c7389317bd7c403d0558d 
>   doc-dev/t3/CMakeLists.txt f41a2f841946a852eb071a4429bda31dfa1095d3 
>   doc/CMakeLists.txt 91c3e23df02510f1165a8ee33e47362cb71fc350 
>   icons/CMakeLists.txt 02e3c9ecf2e80622b6cb3a816c89cba556b500a8 
>   kopete/CMakeLists.txt 8097f41cf60f1ad3dfdd3de9212703aa1883a67a 
>   kopete/addaccountwizard/CMakeLists.txt 
> e49bf672f4b19eecfa26281fe4a24b91d7aa4a6c 
>   kopete/chatwindow/CMakeLists.txt 62e395b07ba2499178b7f7dc90714221e3396fb2 
>   kopete/chatwindow/a11y/CMakeLists.txt 
> f20cf4404ee0d21b224bf6d2c1cf849db29401de 
>   kopete/chatwindow/tests/CMakeLists.txt 
> adc6129fb6a08a69d63d27d3c5642c32af76805d 
>   kopete/config/accounts/CMakeLists.txt 
> f0a463d187df10ea9e4f6a79aceb2a8e7b09e866 
>   kopete/config/appearance/CMakeLists.txt 
> abfe7aef01d7de40f8a50341e6155def2b76ecab 
>   kopete/config/avdevice/CMakeLists.txt 
> c4e3eb2a44383bcd237afe6406907692040ef0b6 
>   kopete/config/behavior/CMakeLists.txt 
> bba08e0725068e00b85d182008b55aa4e6b1e83b 
>   kopete/config/chatwindow/CMakeLists.txt 
> 89e6faec8310da9e63c6ab1253b3db4fba38b6d3 
>   kopete/config/plugins/CMakeLists.txt 
> 5dc269d072d86662647d189c3fa887406ab8c2bd 
>   kopete/config/status/CMakeLists.txt 
> 8cab8f1cfb735bb81663a8e47e394c0f08458562 
>   kopete/contactlist/CMakeLists.txt 2219addf953accacf39d534f1a2cd74438b1e295 
>   kopete/identity/CMakeLists.txt e42c4b423af2b7ea091ef138f93225535f68a5eb 
>   kopete/statusmenu/CMakeLists.txt 6ef9e813d983d83e9c4aabe8a6c6324881b53908 
>   libkopete/CMakeLists.txt c1df8437803bc43461529d296defdbf7134fbaea 
>   libkopete/avdevice/CMakeLists.txt d91f4c81a6855fa66a0e6eddaf9db5106a91c146 
>   libkopete/tests/CMakeLists.txt 78e489a17a6c4393adc903232439b47fdecb16df 
>   plugins/CMakeLists.txt 86fe572a13898f4c6c9e26a33f51e4a0786c898b 
>   plugins/addbookmarks/CMakeLists.txt 
> 84fe18c20fae30af8ac025ec7b1f59ce86709089 
>   plugins/alias/CMakeLists.txt ddfe3c24df9b3668e1b3194e626c22b2f6bb55b6 
>   plugins/autoreplace/CMakeLists.txt a7a2e90402a503d5ced1166e55bcb82189f1f8ff 
>   plugins/autoreplace/icons/CMakeLists.txt 
> c62b24b1187bce066c7b7438a980b79f3954851f 
>   plugins/contactnotes/CMakeLists.txt 
> 3742e4b9304f9dcefa82291268691dba5129e590 
>   plugins/cryptography/CMakeLists.txt 
> f1faffac6ed17209195194242889521a03d34f4d 
>   plugins/highlight/CMakeLists.txt eb892732f1008bf78150074abf0b96ee6d5017b8 
>   plugins/highlight/icons/CMakeLists.txt 
> 1a9fa43e0cbf836dae76112c55ccd69b709f67f1 
>   plugins/history/CMakeLists.txt 015df954111a843ba464fe510a3404abc856ce73 
>   plugins/history2/CMakeLists.txt 195edf63462568c5ab3da85ac600422c6eaab6fa 
>   plugins/latex/CMakeLists.txt 7ab71de615f21d30019e26e0c197153ac4b37ab8 
>   plugins/latex/icons/CMakeLists.txt 321add4f82d42b7fb7072b6022457b15a446b30a 
>   plugins/nowlistening/CMakeLists.txt 
> d910afc14c00c4bac80b934753aadb70561d 
>   plugins/otr/CMakeLists.txt f291e55cdd3604138ecbf4220939b0fb121c327f 
>   plugins/otr/icons/CMakeLists.txt 106884f432c1d1e0b0584959af854c79ede4ea6d 
>   plugins/pipes/CMakeLists.txt a3ea9ba26e71ccaa01d7565b522af08be06a446a 
>   plugins/pipes/tests/CMakeLists.txt 1018c9d8c7cb357b00a5b1f36137271df0240d2b 
>   plugins/privacy/CMakeLists.txt b2fdeba9b3a4ab9b249534d6b8cd65a07dd75a84 
>   plugins/statistics/CMakeLists.txt a4bb8dcea0b45d4f0918acbf51a082e17f386001 
>   plugins/texteffect/CMakeLists.txt 892e732004d371c9276040bd35d52d8f06e789e6 
>   plugins/texteffect/icons/CMakeLists.txt 
> 5e7073f2f27421daf5782028ae6e3580e6e1793e 
>   plugins/translator/CMakeLists.txt 2df6e22ba63e11cdbb5ab8ec98da4876686d1144 
>   plugins/urlpicpreview/CMakeLists.txt 
> 9fa72ea53bbb7b679bbe5970df8c17a6c3b3f734 
>   plugins/webpresence/CMakeLists.txt d5c0ebd5d38b9feefb19eb860f76db10c11eb2b2 
>   protocols/bonjour/CMakeLists.txt c7acede530d5a3e7f963d4712defef9bf0fd85f3 
>

Re: Review Request 124721: Adapt CMakeLists.txt to kf5

2017-03-12 Thread Pali Rohár 


> On aug. 18, 2015, 4:31 popoludní, Laurent Montel wrote:
> > protocols/groupwise/libgroupwise/tests/CMakeLists.txt, line 11
> > 
> >
> > qt-mt ?
> 
> R.Harish  Navnit wrote:
> Not sure what this serves, maybe Pali can explain.
> 
> Pali Rohár wrote:
> IIRC qt-mt is old qt3 multithread library
> 
> R.Harish  Navnit wrote:
> Shall remove it.
> 
> Vijay Krishnavanshi wrote:
> Hi, I see these issues coresponding to their commits and can solve them. 
> But do I have to file a new review addressing these issues and this review 
> request or something else?

If you cannot update this review request feel free to open new.

But note that before any switching to KF5, first it is needed to convert 
KDE3support to KDE4!


- Pali


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124721/#review83993
---


On aug. 12, 2015, 10:19 popoludní, R.Harish  Navnit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124721/
> ---
> 
> (Updated aug. 12, 2015, 10:19 popoludní)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> ---
> 
> Changes obtained by running the kde-dev-scripts/adapt_cmakelists_file script. 
> Adapt CMakeLists.txt for kf5 port.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 24479a4fb2e679f97d6685d832fa46e9e5e62cd8 
>   doc-dev/t2/CMakeLists.txt 0ef0d1c42a33beb9b91c7389317bd7c403d0558d 
>   doc-dev/t3/CMakeLists.txt f41a2f841946a852eb071a4429bda31dfa1095d3 
>   doc/CMakeLists.txt 91c3e23df02510f1165a8ee33e47362cb71fc350 
>   icons/CMakeLists.txt 02e3c9ecf2e80622b6cb3a816c89cba556b500a8 
>   kopete/CMakeLists.txt 8097f41cf60f1ad3dfdd3de9212703aa1883a67a 
>   kopete/addaccountwizard/CMakeLists.txt 
> e49bf672f4b19eecfa26281fe4a24b91d7aa4a6c 
>   kopete/chatwindow/CMakeLists.txt 62e395b07ba2499178b7f7dc90714221e3396fb2 
>   kopete/chatwindow/a11y/CMakeLists.txt 
> f20cf4404ee0d21b224bf6d2c1cf849db29401de 
>   kopete/chatwindow/tests/CMakeLists.txt 
> adc6129fb6a08a69d63d27d3c5642c32af76805d 
>   kopete/config/accounts/CMakeLists.txt 
> f0a463d187df10ea9e4f6a79aceb2a8e7b09e866 
>   kopete/config/appearance/CMakeLists.txt 
> abfe7aef01d7de40f8a50341e6155def2b76ecab 
>   kopete/config/avdevice/CMakeLists.txt 
> c4e3eb2a44383bcd237afe6406907692040ef0b6 
>   kopete/config/behavior/CMakeLists.txt 
> bba08e0725068e00b85d182008b55aa4e6b1e83b 
>   kopete/config/chatwindow/CMakeLists.txt 
> 89e6faec8310da9e63c6ab1253b3db4fba38b6d3 
>   kopete/config/plugins/CMakeLists.txt 
> 5dc269d072d86662647d189c3fa887406ab8c2bd 
>   kopete/config/status/CMakeLists.txt 
> 8cab8f1cfb735bb81663a8e47e394c0f08458562 
>   kopete/contactlist/CMakeLists.txt 2219addf953accacf39d534f1a2cd74438b1e295 
>   kopete/identity/CMakeLists.txt e42c4b423af2b7ea091ef138f93225535f68a5eb 
>   kopete/statusmenu/CMakeLists.txt 6ef9e813d983d83e9c4aabe8a6c6324881b53908 
>   libkopete/CMakeLists.txt c1df8437803bc43461529d296defdbf7134fbaea 
>   libkopete/avdevice/CMakeLists.txt d91f4c81a6855fa66a0e6eddaf9db5106a91c146 
>   libkopete/tests/CMakeLists.txt 78e489a17a6c4393adc903232439b47fdecb16df 
>   plugins/CMakeLists.txt 86fe572a13898f4c6c9e26a33f51e4a0786c898b 
>   plugins/addbookmarks/CMakeLists.txt 
> 84fe18c20fae30af8ac025ec7b1f59ce86709089 
>   plugins/alias/CMakeLists.txt ddfe3c24df9b3668e1b3194e626c22b2f6bb55b6 
>   plugins/autoreplace/CMakeLists.txt a7a2e90402a503d5ced1166e55bcb82189f1f8ff 
>   plugins/autoreplace/icons/CMakeLists.txt 
> c62b24b1187bce066c7b7438a980b79f3954851f 
>   plugins/contactnotes/CMakeLists.txt 
> 3742e4b9304f9dcefa82291268691dba5129e590 
>   plugins/cryptography/CMakeLists.txt 
> f1faffac6ed17209195194242889521a03d34f4d 
>   plugins/highlight/CMakeLists.txt eb892732f1008bf78150074abf0b96ee6d5017b8 
>   plugins/highlight/icons/CMakeLists.txt 
> 1a9fa43e0cbf836dae76112c55ccd69b709f67f1 
>   plugins/history/CMakeLists.txt 015df954111a843ba464fe510a3404abc856ce73 
>   plugins/history2/CMakeLists.txt 195edf63462568c5ab3da85ac600422c6eaab6fa 
>   plugins/latex/CMakeLists.txt 7ab71de615f21d30019e26e0c197153ac4b37ab8 
>   plugins/latex/icons/CMakeLists.txt 321add4f82d42b7fb7072b6022457b15a446b30a 
>   plugins/nowlistening/CMakeLists.txt 
> d910afc14c00c4bac80b934753aadb70561d 
>   plugins/otr/CMakeLists.txt f291e55cdd3604138ecbf4220939b0fb121c327f 
>   plugins/otr/icons/CMakeLists.txt 106884f432c1d1e0b0584959af854c79ede4ea6d 
>   plugins/pipes/CMakeLists.txt a3ea9ba26e71ccaa01d7565b522af08be06a446a 
>   plugins/pipes/tests/CMakeLists.txt 1018c9d8c7cb357b00a5b1f36137271df0240d2b 
>   plugins/privacy/CMakeLists.txt

Re: Review Request 124721: Adapt CMakeLists.txt to kf5

2016-01-05 Thread Pali Rohár 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124721/#review90661
---



plugins/CMakeLists.txt (line 3)


New history plugin is not finished and not ready yet. So we cannot use it 
and we need to use old plugin...


- Pali Rohár


On aug. 12, 2015, 10:19 popoludní, R.Harish  Navnit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124721/
> ---
> 
> (Updated aug. 12, 2015, 10:19 popoludní)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> ---
> 
> Changes obtained by running the kde-dev-scripts/adapt_cmakelists_file script. 
> Adapt CMakeLists.txt for kf5 port.
> 
> 
> Diffs
> -
> 
>   kopete/addaccountwizard/CMakeLists.txt 
> e49bf672f4b19eecfa26281fe4a24b91d7aa4a6c 
>   kopete/CMakeLists.txt 8097f41cf60f1ad3dfdd3de9212703aa1883a67a 
>   icons/CMakeLists.txt 02e3c9ecf2e80622b6cb3a816c89cba556b500a8 
>   doc/CMakeLists.txt 91c3e23df02510f1165a8ee33e47362cb71fc350 
>   doc-dev/t3/CMakeLists.txt f41a2f841946a852eb071a4429bda31dfa1095d3 
>   doc-dev/t2/CMakeLists.txt 0ef0d1c42a33beb9b91c7389317bd7c403d0558d 
>   CMakeLists.txt 24479a4fb2e679f97d6685d832fa46e9e5e62cd8 
>   kopete/chatwindow/CMakeLists.txt 62e395b07ba2499178b7f7dc90714221e3396fb2 
>   kopete/chatwindow/a11y/CMakeLists.txt 
> f20cf4404ee0d21b224bf6d2c1cf849db29401de 
>   kopete/chatwindow/tests/CMakeLists.txt 
> adc6129fb6a08a69d63d27d3c5642c32af76805d 
>   kopete/config/accounts/CMakeLists.txt 
> f0a463d187df10ea9e4f6a79aceb2a8e7b09e866 
>   kopete/config/appearance/CMakeLists.txt 
> abfe7aef01d7de40f8a50341e6155def2b76ecab 
>   kopete/config/avdevice/CMakeLists.txt 
> c4e3eb2a44383bcd237afe6406907692040ef0b6 
>   kopete/config/behavior/CMakeLists.txt 
> bba08e0725068e00b85d182008b55aa4e6b1e83b 
>   kopete/config/chatwindow/CMakeLists.txt 
> 89e6faec8310da9e63c6ab1253b3db4fba38b6d3 
>   kopete/config/plugins/CMakeLists.txt 
> 5dc269d072d86662647d189c3fa887406ab8c2bd 
>   kopete/config/status/CMakeLists.txt 
> 8cab8f1cfb735bb81663a8e47e394c0f08458562 
>   kopete/contactlist/CMakeLists.txt 2219addf953accacf39d534f1a2cd74438b1e295 
>   kopete/identity/CMakeLists.txt e42c4b423af2b7ea091ef138f93225535f68a5eb 
>   kopete/statusmenu/CMakeLists.txt 6ef9e813d983d83e9c4aabe8a6c6324881b53908 
>   libkopete/CMakeLists.txt c1df8437803bc43461529d296defdbf7134fbaea 
>   libkopete/avdevice/CMakeLists.txt d91f4c81a6855fa66a0e6eddaf9db5106a91c146 
>   libkopete/tests/CMakeLists.txt 78e489a17a6c4393adc903232439b47fdecb16df 
>   plugins/CMakeLists.txt 86fe572a13898f4c6c9e26a33f51e4a0786c898b 
>   plugins/addbookmarks/CMakeLists.txt 
> 84fe18c20fae30af8ac025ec7b1f59ce86709089 
>   plugins/alias/CMakeLists.txt ddfe3c24df9b3668e1b3194e626c22b2f6bb55b6 
>   plugins/autoreplace/CMakeLists.txt a7a2e90402a503d5ced1166e55bcb82189f1f8ff 
>   plugins/autoreplace/icons/CMakeLists.txt 
> c62b24b1187bce066c7b7438a980b79f3954851f 
>   plugins/contactnotes/CMakeLists.txt 
> 3742e4b9304f9dcefa82291268691dba5129e590 
>   plugins/cryptography/CMakeLists.txt 
> f1faffac6ed17209195194242889521a03d34f4d 
>   plugins/highlight/CMakeLists.txt eb892732f1008bf78150074abf0b96ee6d5017b8 
>   plugins/highlight/icons/CMakeLists.txt 
> 1a9fa43e0cbf836dae76112c55ccd69b709f67f1 
>   plugins/history/CMakeLists.txt 015df954111a843ba464fe510a3404abc856ce73 
>   plugins/history2/CMakeLists.txt 195edf63462568c5ab3da85ac600422c6eaab6fa 
>   plugins/latex/CMakeLists.txt 7ab71de615f21d30019e26e0c197153ac4b37ab8 
>   plugins/latex/icons/CMakeLists.txt 321add4f82d42b7fb7072b6022457b15a446b30a 
>   plugins/nowlistening/CMakeLists.txt 
> d910afc14c00c4bac80b934753aadb70561d 
>   plugins/otr/CMakeLists.txt f291e55cdd3604138ecbf4220939b0fb121c327f 
>   plugins/otr/icons/CMakeLists.txt 106884f432c1d1e0b0584959af854c79ede4ea6d 
>   plugins/pipes/CMakeLists.txt a3ea9ba26e71ccaa01d7565b522af08be06a446a 
>   plugins/pipes/tests/CMakeLists.txt 1018c9d8c7cb357b00a5b1f36137271df0240d2b 
>   plugins/privacy/CMakeLists.txt b2fdeba9b3a4ab9b249534d6b8cd65a07dd75a84 
>   plugins/statistics/CMakeLists.txt a4bb8dcea0b45d4f0918acbf51a082e17f386001 
>   plugins/texteffect/CMakeLists.txt 892e732004d371c9276040bd35d52d8f06e789e6 
>   plugins/texteffect/icons/CMakeLists.txt 
> 5e7073f2f27421daf5782028ae6e3580e6e1793e 
>   plugins/translator/CMakeLists.txt 2df6e22ba63e11cdbb5ab8ec98da4876686d1144 
>   plugins/urlpicpreview/CMakeLists.txt 
> 9fa72ea53bbb7b679bbe5970df8c17a6c3b3f734 
>   plugins/webpresence/CMakeLists.txt d5c0ebd5d38b9feefb19eb860f76db10c11eb2b2 
>   protocols/bonjour/CMakeLists.txt c7acede530d5a3e7f963d4712defef9bf0fd85f3 
>

Re: Review Request 124721: Adapt CMakeLists.txt to kf5

2016-01-05 Thread R.Harish Navnit 


> On Jan. 4, 2016, 11:52 p.m., Pali Rohár wrote:
> > plugins/CMakeLists.txt, line 3
> > 
> >
> > Reason for this?

Because the history plugin was being re-written right ?


- R.Harish


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124721/#review90585
---


On Aug. 13, 2015, 1:49 a.m., R.Harish  Navnit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124721/
> ---
> 
> (Updated Aug. 13, 2015, 1:49 a.m.)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> ---
> 
> Changes obtained by running the kde-dev-scripts/adapt_cmakelists_file script. 
> Adapt CMakeLists.txt for kf5 port.
> 
> 
> Diffs
> -
> 
>   kopete/addaccountwizard/CMakeLists.txt 
> e49bf672f4b19eecfa26281fe4a24b91d7aa4a6c 
>   kopete/CMakeLists.txt 8097f41cf60f1ad3dfdd3de9212703aa1883a67a 
>   icons/CMakeLists.txt 02e3c9ecf2e80622b6cb3a816c89cba556b500a8 
>   doc/CMakeLists.txt 91c3e23df02510f1165a8ee33e47362cb71fc350 
>   doc-dev/t3/CMakeLists.txt f41a2f841946a852eb071a4429bda31dfa1095d3 
>   doc-dev/t2/CMakeLists.txt 0ef0d1c42a33beb9b91c7389317bd7c403d0558d 
>   CMakeLists.txt 24479a4fb2e679f97d6685d832fa46e9e5e62cd8 
>   kopete/chatwindow/CMakeLists.txt 62e395b07ba2499178b7f7dc90714221e3396fb2 
>   kopete/chatwindow/a11y/CMakeLists.txt 
> f20cf4404ee0d21b224bf6d2c1cf849db29401de 
>   kopete/chatwindow/tests/CMakeLists.txt 
> adc6129fb6a08a69d63d27d3c5642c32af76805d 
>   kopete/config/accounts/CMakeLists.txt 
> f0a463d187df10ea9e4f6a79aceb2a8e7b09e866 
>   kopete/config/appearance/CMakeLists.txt 
> abfe7aef01d7de40f8a50341e6155def2b76ecab 
>   kopete/config/avdevice/CMakeLists.txt 
> c4e3eb2a44383bcd237afe6406907692040ef0b6 
>   kopete/config/behavior/CMakeLists.txt 
> bba08e0725068e00b85d182008b55aa4e6b1e83b 
>   kopete/config/chatwindow/CMakeLists.txt 
> 89e6faec8310da9e63c6ab1253b3db4fba38b6d3 
>   kopete/config/plugins/CMakeLists.txt 
> 5dc269d072d86662647d189c3fa887406ab8c2bd 
>   kopete/config/status/CMakeLists.txt 
> 8cab8f1cfb735bb81663a8e47e394c0f08458562 
>   kopete/contactlist/CMakeLists.txt 2219addf953accacf39d534f1a2cd74438b1e295 
>   kopete/identity/CMakeLists.txt e42c4b423af2b7ea091ef138f93225535f68a5eb 
>   kopete/statusmenu/CMakeLists.txt 6ef9e813d983d83e9c4aabe8a6c6324881b53908 
>   libkopete/CMakeLists.txt c1df8437803bc43461529d296defdbf7134fbaea 
>   libkopete/avdevice/CMakeLists.txt d91f4c81a6855fa66a0e6eddaf9db5106a91c146 
>   libkopete/tests/CMakeLists.txt 78e489a17a6c4393adc903232439b47fdecb16df 
>   plugins/CMakeLists.txt 86fe572a13898f4c6c9e26a33f51e4a0786c898b 
>   plugins/addbookmarks/CMakeLists.txt 
> 84fe18c20fae30af8ac025ec7b1f59ce86709089 
>   plugins/alias/CMakeLists.txt ddfe3c24df9b3668e1b3194e626c22b2f6bb55b6 
>   plugins/autoreplace/CMakeLists.txt a7a2e90402a503d5ced1166e55bcb82189f1f8ff 
>   plugins/autoreplace/icons/CMakeLists.txt 
> c62b24b1187bce066c7b7438a980b79f3954851f 
>   plugins/contactnotes/CMakeLists.txt 
> 3742e4b9304f9dcefa82291268691dba5129e590 
>   plugins/cryptography/CMakeLists.txt 
> f1faffac6ed17209195194242889521a03d34f4d 
>   plugins/highlight/CMakeLists.txt eb892732f1008bf78150074abf0b96ee6d5017b8 
>   plugins/highlight/icons/CMakeLists.txt 
> 1a9fa43e0cbf836dae76112c55ccd69b709f67f1 
>   plugins/history/CMakeLists.txt 015df954111a843ba464fe510a3404abc856ce73 
>   plugins/history2/CMakeLists.txt 195edf63462568c5ab3da85ac600422c6eaab6fa 
>   plugins/latex/CMakeLists.txt 7ab71de615f21d30019e26e0c197153ac4b37ab8 
>   plugins/latex/icons/CMakeLists.txt 321add4f82d42b7fb7072b6022457b15a446b30a 
>   plugins/nowlistening/CMakeLists.txt 
> d910afc14c00c4bac80b934753aadb70561d 
>   plugins/otr/CMakeLists.txt f291e55cdd3604138ecbf4220939b0fb121c327f 
>   plugins/otr/icons/CMakeLists.txt 106884f432c1d1e0b0584959af854c79ede4ea6d 
>   plugins/pipes/CMakeLists.txt a3ea9ba26e71ccaa01d7565b522af08be06a446a 
>   plugins/pipes/tests/CMakeLists.txt 1018c9d8c7cb357b00a5b1f36137271df0240d2b 
>   plugins/privacy/CMakeLists.txt b2fdeba9b3a4ab9b249534d6b8cd65a07dd75a84 
>   plugins/statistics/CMakeLists.txt a4bb8dcea0b45d4f0918acbf51a082e17f386001 
>   plugins/texteffect/CMakeLists.txt 892e732004d371c9276040bd35d52d8f06e789e6 
>   plugins/texteffect/icons/CMakeLists.txt 
> 5e7073f2f27421daf5782028ae6e3580e6e1793e 
>   plugins/translator/CMakeLists.txt 2df6e22ba63e11cdbb5ab8ec98da4876686d1144 
>   plugins/urlpicpreview/CMakeLists.txt 
> 9fa72ea53bbb7b679bbe5970df8c17a6c3b3f734 
>   plugins/webpresence/CMakeLists.txt d5c0ebd5d38b9feefb19eb860f76db10c11eb2b2 
>   protocols/bonjour/CMakeLists.txt

Re: Review Request 124721: Adapt CMakeLists.txt to kf5

2016-01-04 Thread Pali Rohár 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124721/#review90585
---



CMakeLists.txt (line 136)


Please clean cmake files. Do not let such lines with whitespaces...



kopete/CMakeLists.txt (line 34)


Please, move all find_package() macros into main CMakeLists.txt file



kopete/CMakeLists.txt (line 60)


These KF5 libs do not have cmake variable? It is really preferred format to 
hardcode them?



kopete/contactlist/CMakeLists.txt (line 12)


If those files are really not used, removed them. Do not comment.



kopete/statusmenu/CMakeLists.txt (line 23)


Need to change VERSION and SOVERSION according to semversion scheme. KF5 is 
ABI incomaptible with KDE4.



plugins/CMakeLists.txt (line 3)


Reason for this?



plugins/CMakeLists.txt (line 27)


Incorrect parsing of if/endif.



protocols/irc/CMakeLists.txt (line 1)


Drop IRC code. It is not working with KDE4, so there is no need to port it 
into KF5.



protocols/jabber/libiris/src/jdns/src/qjdns/CMakeLists.txt (line 1)


We are not using this cmake file. Do not change it.



protocols/jabber/libiris/src/jdns/tools/jdns/CMakeLists.txt (line 1)


Same here.



protocols/testbed/icons/CMakeLists.txt (line 8)


Why commented line above? And is this change ok?


- Pali Rohár


On aug. 12, 2015, 10:19 popoludní, R.Harish  Navnit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124721/
> ---
> 
> (Updated aug. 12, 2015, 10:19 popoludní)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> ---
> 
> Changes obtained by running the kde-dev-scripts/adapt_cmakelists_file script. 
> Adapt CMakeLists.txt for kf5 port.
> 
> 
> Diffs
> -
> 
>   kopete/addaccountwizard/CMakeLists.txt 
> e49bf672f4b19eecfa26281fe4a24b91d7aa4a6c 
>   kopete/CMakeLists.txt 8097f41cf60f1ad3dfdd3de9212703aa1883a67a 
>   icons/CMakeLists.txt 02e3c9ecf2e80622b6cb3a816c89cba556b500a8 
>   doc/CMakeLists.txt 91c3e23df02510f1165a8ee33e47362cb71fc350 
>   doc-dev/t3/CMakeLists.txt f41a2f841946a852eb071a4429bda31dfa1095d3 
>   doc-dev/t2/CMakeLists.txt 0ef0d1c42a33beb9b91c7389317bd7c403d0558d 
>   CMakeLists.txt 24479a4fb2e679f97d6685d832fa46e9e5e62cd8 
>   kopete/chatwindow/CMakeLists.txt 62e395b07ba2499178b7f7dc90714221e3396fb2 
>   kopete/chatwindow/a11y/CMakeLists.txt 
> f20cf4404ee0d21b224bf6d2c1cf849db29401de 
>   kopete/chatwindow/tests/CMakeLists.txt 
> adc6129fb6a08a69d63d27d3c5642c32af76805d 
>   kopete/config/accounts/CMakeLists.txt 
> f0a463d187df10ea9e4f6a79aceb2a8e7b09e866 
>   kopete/config/appearance/CMakeLists.txt 
> abfe7aef01d7de40f8a50341e6155def2b76ecab 
>   kopete/config/avdevice/CMakeLists.txt 
> c4e3eb2a44383bcd237afe6406907692040ef0b6 
>   kopete/config/behavior/CMakeLists.txt 
> bba08e0725068e00b85d182008b55aa4e6b1e83b 
>   kopete/config/chatwindow/CMakeLists.txt 
> 89e6faec8310da9e63c6ab1253b3db4fba38b6d3 
>   kopete/config/plugins/CMakeLists.txt 
> 5dc269d072d86662647d189c3fa887406ab8c2bd 
>   kopete/config/status/CMakeLists.txt 
> 8cab8f1cfb735bb81663a8e47e394c0f08458562 
>   kopete/contactlist/CMakeLists.txt 2219addf953accacf39d534f1a2cd74438b1e295 
>   kopete/identity/CMakeLists.txt e42c4b423af2b7ea091ef138f93225535f68a5eb 
>   kopete/statusmenu/CMakeLists.txt 6ef9e813d983d83e9c4aabe8a6c6324881b53908 
>   libkopete/CMakeLists.txt c1df8437803bc43461529d296defdbf7134fbaea 
>   libkopete/avdevice/CMakeLists.txt d91f4c81a6855fa66a0e6eddaf9db5106a91c146 
>   libkopete/tests/CMakeLists.txt 78e489a17a6c4393adc903232439b47fdecb16df 
>   plugins/CMakeLists.txt 86fe572a13898f4c6c9e26a33f51e4a0786c898b 
>   plugins/addbookmarks/CMakeLists.txt 
> 84fe18c20fae30af8ac025ec7b1f59ce86709089 
>   plugins/alias/CMakeLists.txt ddfe3c24df9b3668e1b3194e626c22b2f6bb55b6 
>   plugins/autoreplace/CMakeLists.txt a7a2e90402a503d5ced1166e55bcb82189f1f8ff 
>   plugins/autoreplace/icons/CMakeLists.txt 
> c62b24b1187bce066c7b7438a980b79f3954851f 
>   plugins/contactnotes/CMakeLists.txt 
> 3742e4b9304f9dcefa82291268691dba5129e590 
>

Re: Review Request 124721: Adapt CMakeLists.txt to kf5

2015-12-30 Thread Pali Rohár 


> On aug. 18, 2015, 4:31 popoludní, Laurent Montel wrote:
> > protocols/groupwise/libgroupwise/tests/CMakeLists.txt, line 11
> > 
> >
> > qt-mt ?
> 
> R.Harish  Navnit wrote:
> Not sure what this serves, maybe Pali can explain.

IIRC qt-mt is old qt3 multithread library


- Pali


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124721/#review83993
---


On aug. 12, 2015, 10:19 popoludní, R.Harish  Navnit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124721/
> ---
> 
> (Updated aug. 12, 2015, 10:19 popoludní)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> ---
> 
> Changes obtained by running the kde-dev-scripts/adapt_cmakelists_file script. 
> Adapt CMakeLists.txt for kf5 port.
> 
> 
> Diffs
> -
> 
>   kopete/addaccountwizard/CMakeLists.txt 
> e49bf672f4b19eecfa26281fe4a24b91d7aa4a6c 
>   kopete/CMakeLists.txt 8097f41cf60f1ad3dfdd3de9212703aa1883a67a 
>   icons/CMakeLists.txt 02e3c9ecf2e80622b6cb3a816c89cba556b500a8 
>   doc/CMakeLists.txt 91c3e23df02510f1165a8ee33e47362cb71fc350 
>   doc-dev/t3/CMakeLists.txt f41a2f841946a852eb071a4429bda31dfa1095d3 
>   doc-dev/t2/CMakeLists.txt 0ef0d1c42a33beb9b91c7389317bd7c403d0558d 
>   CMakeLists.txt 24479a4fb2e679f97d6685d832fa46e9e5e62cd8 
>   kopete/chatwindow/CMakeLists.txt 62e395b07ba2499178b7f7dc90714221e3396fb2 
>   kopete/chatwindow/a11y/CMakeLists.txt 
> f20cf4404ee0d21b224bf6d2c1cf849db29401de 
>   kopete/chatwindow/tests/CMakeLists.txt 
> adc6129fb6a08a69d63d27d3c5642c32af76805d 
>   kopete/config/accounts/CMakeLists.txt 
> f0a463d187df10ea9e4f6a79aceb2a8e7b09e866 
>   kopete/config/appearance/CMakeLists.txt 
> abfe7aef01d7de40f8a50341e6155def2b76ecab 
>   kopete/config/avdevice/CMakeLists.txt 
> c4e3eb2a44383bcd237afe6406907692040ef0b6 
>   kopete/config/behavior/CMakeLists.txt 
> bba08e0725068e00b85d182008b55aa4e6b1e83b 
>   kopete/config/chatwindow/CMakeLists.txt 
> 89e6faec8310da9e63c6ab1253b3db4fba38b6d3 
>   kopete/config/plugins/CMakeLists.txt 
> 5dc269d072d86662647d189c3fa887406ab8c2bd 
>   kopete/config/status/CMakeLists.txt 
> 8cab8f1cfb735bb81663a8e47e394c0f08458562 
>   kopete/contactlist/CMakeLists.txt 2219addf953accacf39d534f1a2cd74438b1e295 
>   kopete/identity/CMakeLists.txt e42c4b423af2b7ea091ef138f93225535f68a5eb 
>   kopete/statusmenu/CMakeLists.txt 6ef9e813d983d83e9c4aabe8a6c6324881b53908 
>   libkopete/CMakeLists.txt c1df8437803bc43461529d296defdbf7134fbaea 
>   libkopete/avdevice/CMakeLists.txt d91f4c81a6855fa66a0e6eddaf9db5106a91c146 
>   libkopete/tests/CMakeLists.txt 78e489a17a6c4393adc903232439b47fdecb16df 
>   plugins/CMakeLists.txt 86fe572a13898f4c6c9e26a33f51e4a0786c898b 
>   plugins/addbookmarks/CMakeLists.txt 
> 84fe18c20fae30af8ac025ec7b1f59ce86709089 
>   plugins/alias/CMakeLists.txt ddfe3c24df9b3668e1b3194e626c22b2f6bb55b6 
>   plugins/autoreplace/CMakeLists.txt a7a2e90402a503d5ced1166e55bcb82189f1f8ff 
>   plugins/autoreplace/icons/CMakeLists.txt 
> c62b24b1187bce066c7b7438a980b79f3954851f 
>   plugins/contactnotes/CMakeLists.txt 
> 3742e4b9304f9dcefa82291268691dba5129e590 
>   plugins/cryptography/CMakeLists.txt 
> f1faffac6ed17209195194242889521a03d34f4d 
>   plugins/highlight/CMakeLists.txt eb892732f1008bf78150074abf0b96ee6d5017b8 
>   plugins/highlight/icons/CMakeLists.txt 
> 1a9fa43e0cbf836dae76112c55ccd69b709f67f1 
>   plugins/history/CMakeLists.txt 015df954111a843ba464fe510a3404abc856ce73 
>   plugins/history2/CMakeLists.txt 195edf63462568c5ab3da85ac600422c6eaab6fa 
>   plugins/latex/CMakeLists.txt 7ab71de615f21d30019e26e0c197153ac4b37ab8 
>   plugins/latex/icons/CMakeLists.txt 321add4f82d42b7fb7072b6022457b15a446b30a 
>   plugins/nowlistening/CMakeLists.txt 
> d910afc14c00c4bac80b934753aadb70561d 
>   plugins/otr/CMakeLists.txt f291e55cdd3604138ecbf4220939b0fb121c327f 
>   plugins/otr/icons/CMakeLists.txt 106884f432c1d1e0b0584959af854c79ede4ea6d 
>   plugins/pipes/CMakeLists.txt a3ea9ba26e71ccaa01d7565b522af08be06a446a 
>   plugins/pipes/tests/CMakeLists.txt 1018c9d8c7cb357b00a5b1f36137271df0240d2b 
>   plugins/privacy/CMakeLists.txt b2fdeba9b3a4ab9b249534d6b8cd65a07dd75a84 
>   plugins/statistics/CMakeLists.txt a4bb8dcea0b45d4f0918acbf51a082e17f386001 
>   plugins/texteffect/CMakeLists.txt 892e732004d371c9276040bd35d52d8f06e789e6 
>   plugins/texteffect/icons/CMakeLists.txt 
> 5e7073f2f27421daf5782028ae6e3580e6e1793e 
>   plugins/translator/CMakeLists.txt 2df6e22ba63e11cdbb5ab8ec98da4876686d1144 
>   plugins/urlpicpreview/CMakeLists.txt 
> 9fa72ea53bbb7b679bbe5970df8c17a6c3b3f734 
>

Re: Review Request 124721: Adapt CMakeLists.txt to kf5

2015-12-30 Thread R.Harish Navnit 


> On Aug. 18, 2015, 8:01 p.m., Laurent Montel wrote:
> > protocols/groupwise/libgroupwise/tests/CMakeLists.txt, line 11
> > 
> >
> > qt-mt ?
> 
> R.Harish  Navnit wrote:
> Not sure what this serves, maybe Pali can explain.
> 
> Pali Rohár wrote:
> IIRC qt-mt is old qt3 multithread library

Shall remove it.


- R.Harish


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124721/#review83993
---


On Aug. 13, 2015, 1:49 a.m., R.Harish  Navnit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124721/
> ---
> 
> (Updated Aug. 13, 2015, 1:49 a.m.)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> ---
> 
> Changes obtained by running the kde-dev-scripts/adapt_cmakelists_file script. 
> Adapt CMakeLists.txt for kf5 port.
> 
> 
> Diffs
> -
> 
>   kopete/addaccountwizard/CMakeLists.txt 
> e49bf672f4b19eecfa26281fe4a24b91d7aa4a6c 
>   kopete/CMakeLists.txt 8097f41cf60f1ad3dfdd3de9212703aa1883a67a 
>   icons/CMakeLists.txt 02e3c9ecf2e80622b6cb3a816c89cba556b500a8 
>   doc/CMakeLists.txt 91c3e23df02510f1165a8ee33e47362cb71fc350 
>   doc-dev/t3/CMakeLists.txt f41a2f841946a852eb071a4429bda31dfa1095d3 
>   doc-dev/t2/CMakeLists.txt 0ef0d1c42a33beb9b91c7389317bd7c403d0558d 
>   CMakeLists.txt 24479a4fb2e679f97d6685d832fa46e9e5e62cd8 
>   kopete/chatwindow/CMakeLists.txt 62e395b07ba2499178b7f7dc90714221e3396fb2 
>   kopete/chatwindow/a11y/CMakeLists.txt 
> f20cf4404ee0d21b224bf6d2c1cf849db29401de 
>   kopete/chatwindow/tests/CMakeLists.txt 
> adc6129fb6a08a69d63d27d3c5642c32af76805d 
>   kopete/config/accounts/CMakeLists.txt 
> f0a463d187df10ea9e4f6a79aceb2a8e7b09e866 
>   kopete/config/appearance/CMakeLists.txt 
> abfe7aef01d7de40f8a50341e6155def2b76ecab 
>   kopete/config/avdevice/CMakeLists.txt 
> c4e3eb2a44383bcd237afe6406907692040ef0b6 
>   kopete/config/behavior/CMakeLists.txt 
> bba08e0725068e00b85d182008b55aa4e6b1e83b 
>   kopete/config/chatwindow/CMakeLists.txt 
> 89e6faec8310da9e63c6ab1253b3db4fba38b6d3 
>   kopete/config/plugins/CMakeLists.txt 
> 5dc269d072d86662647d189c3fa887406ab8c2bd 
>   kopete/config/status/CMakeLists.txt 
> 8cab8f1cfb735bb81663a8e47e394c0f08458562 
>   kopete/contactlist/CMakeLists.txt 2219addf953accacf39d534f1a2cd74438b1e295 
>   kopete/identity/CMakeLists.txt e42c4b423af2b7ea091ef138f93225535f68a5eb 
>   kopete/statusmenu/CMakeLists.txt 6ef9e813d983d83e9c4aabe8a6c6324881b53908 
>   libkopete/CMakeLists.txt c1df8437803bc43461529d296defdbf7134fbaea 
>   libkopete/avdevice/CMakeLists.txt d91f4c81a6855fa66a0e6eddaf9db5106a91c146 
>   libkopete/tests/CMakeLists.txt 78e489a17a6c4393adc903232439b47fdecb16df 
>   plugins/CMakeLists.txt 86fe572a13898f4c6c9e26a33f51e4a0786c898b 
>   plugins/addbookmarks/CMakeLists.txt 
> 84fe18c20fae30af8ac025ec7b1f59ce86709089 
>   plugins/alias/CMakeLists.txt ddfe3c24df9b3668e1b3194e626c22b2f6bb55b6 
>   plugins/autoreplace/CMakeLists.txt a7a2e90402a503d5ced1166e55bcb82189f1f8ff 
>   plugins/autoreplace/icons/CMakeLists.txt 
> c62b24b1187bce066c7b7438a980b79f3954851f 
>   plugins/contactnotes/CMakeLists.txt 
> 3742e4b9304f9dcefa82291268691dba5129e590 
>   plugins/cryptography/CMakeLists.txt 
> f1faffac6ed17209195194242889521a03d34f4d 
>   plugins/highlight/CMakeLists.txt eb892732f1008bf78150074abf0b96ee6d5017b8 
>   plugins/highlight/icons/CMakeLists.txt 
> 1a9fa43e0cbf836dae76112c55ccd69b709f67f1 
>   plugins/history/CMakeLists.txt 015df954111a843ba464fe510a3404abc856ce73 
>   plugins/history2/CMakeLists.txt 195edf63462568c5ab3da85ac600422c6eaab6fa 
>   plugins/latex/CMakeLists.txt 7ab71de615f21d30019e26e0c197153ac4b37ab8 
>   plugins/latex/icons/CMakeLists.txt 321add4f82d42b7fb7072b6022457b15a446b30a 
>   plugins/nowlistening/CMakeLists.txt 
> d910afc14c00c4bac80b934753aadb70561d 
>   plugins/otr/CMakeLists.txt f291e55cdd3604138ecbf4220939b0fb121c327f 
>   plugins/otr/icons/CMakeLists.txt 106884f432c1d1e0b0584959af854c79ede4ea6d 
>   plugins/pipes/CMakeLists.txt a3ea9ba26e71ccaa01d7565b522af08be06a446a 
>   plugins/pipes/tests/CMakeLists.txt 1018c9d8c7cb357b00a5b1f36137271df0240d2b 
>   plugins/privacy/CMakeLists.txt b2fdeba9b3a4ab9b249534d6b8cd65a07dd75a84 
>   plugins/statistics/CMakeLists.txt a4bb8dcea0b45d4f0918acbf51a082e17f386001 
>   plugins/texteffect/CMakeLists.txt 892e732004d371c9276040bd35d52d8f06e789e6 
>   plugins/texteffect/icons/CMakeLists.txt 
> 5e7073f2f27421daf5782028ae6e3580e6e1793e 
>   plugins/translator/CMakeLists.txt 2df6e22ba63e11cdbb5ab8ec98da4876686d1144 
>   plugins/urlpicpreview/CMakeLists.txt 
>

Re: Review Request 124721: Adapt CMakeLists.txt to kf5

2015-09-17 Thread R.Harish Navnit 


> On Aug. 18, 2015, 8:01 p.m., Laurent Montel wrote:
> > protocols/groupwise/libgroupwise/tests/CMakeLists.txt, line 11
> > 
> >
> > qt-mt ?

Not sure what this serves, maybe Pali can explain.


- R.Harish


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124721/#review83993
---


On Aug. 13, 2015, 1:49 a.m., R.Harish  Navnit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124721/
> ---
> 
> (Updated Aug. 13, 2015, 1:49 a.m.)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> ---
> 
> Changes obtained by running the kde-dev-scripts/adapt_cmakelists_file script. 
> Adapt CMakeLists.txt for kf5 port.
> 
> 
> Diffs
> -
> 
>   kopete/addaccountwizard/CMakeLists.txt 
> e49bf672f4b19eecfa26281fe4a24b91d7aa4a6c 
>   kopete/CMakeLists.txt 8097f41cf60f1ad3dfdd3de9212703aa1883a67a 
>   icons/CMakeLists.txt 02e3c9ecf2e80622b6cb3a816c89cba556b500a8 
>   doc/CMakeLists.txt 91c3e23df02510f1165a8ee33e47362cb71fc350 
>   doc-dev/t3/CMakeLists.txt f41a2f841946a852eb071a4429bda31dfa1095d3 
>   doc-dev/t2/CMakeLists.txt 0ef0d1c42a33beb9b91c7389317bd7c403d0558d 
>   CMakeLists.txt 24479a4fb2e679f97d6685d832fa46e9e5e62cd8 
>   kopete/chatwindow/CMakeLists.txt 62e395b07ba2499178b7f7dc90714221e3396fb2 
>   kopete/chatwindow/a11y/CMakeLists.txt 
> f20cf4404ee0d21b224bf6d2c1cf849db29401de 
>   kopete/chatwindow/tests/CMakeLists.txt 
> adc6129fb6a08a69d63d27d3c5642c32af76805d 
>   kopete/config/accounts/CMakeLists.txt 
> f0a463d187df10ea9e4f6a79aceb2a8e7b09e866 
>   kopete/config/appearance/CMakeLists.txt 
> abfe7aef01d7de40f8a50341e6155def2b76ecab 
>   kopete/config/avdevice/CMakeLists.txt 
> c4e3eb2a44383bcd237afe6406907692040ef0b6 
>   kopete/config/behavior/CMakeLists.txt 
> bba08e0725068e00b85d182008b55aa4e6b1e83b 
>   kopete/config/chatwindow/CMakeLists.txt 
> 89e6faec8310da9e63c6ab1253b3db4fba38b6d3 
>   kopete/config/plugins/CMakeLists.txt 
> 5dc269d072d86662647d189c3fa887406ab8c2bd 
>   kopete/config/status/CMakeLists.txt 
> 8cab8f1cfb735bb81663a8e47e394c0f08458562 
>   kopete/contactlist/CMakeLists.txt 2219addf953accacf39d534f1a2cd74438b1e295 
>   kopete/identity/CMakeLists.txt e42c4b423af2b7ea091ef138f93225535f68a5eb 
>   kopete/statusmenu/CMakeLists.txt 6ef9e813d983d83e9c4aabe8a6c6324881b53908 
>   libkopete/CMakeLists.txt c1df8437803bc43461529d296defdbf7134fbaea 
>   libkopete/avdevice/CMakeLists.txt d91f4c81a6855fa66a0e6eddaf9db5106a91c146 
>   libkopete/tests/CMakeLists.txt 78e489a17a6c4393adc903232439b47fdecb16df 
>   plugins/CMakeLists.txt 86fe572a13898f4c6c9e26a33f51e4a0786c898b 
>   plugins/addbookmarks/CMakeLists.txt 
> 84fe18c20fae30af8ac025ec7b1f59ce86709089 
>   plugins/alias/CMakeLists.txt ddfe3c24df9b3668e1b3194e626c22b2f6bb55b6 
>   plugins/autoreplace/CMakeLists.txt a7a2e90402a503d5ced1166e55bcb82189f1f8ff 
>   plugins/autoreplace/icons/CMakeLists.txt 
> c62b24b1187bce066c7b7438a980b79f3954851f 
>   plugins/contactnotes/CMakeLists.txt 
> 3742e4b9304f9dcefa82291268691dba5129e590 
>   plugins/cryptography/CMakeLists.txt 
> f1faffac6ed17209195194242889521a03d34f4d 
>   plugins/highlight/CMakeLists.txt eb892732f1008bf78150074abf0b96ee6d5017b8 
>   plugins/highlight/icons/CMakeLists.txt 
> 1a9fa43e0cbf836dae76112c55ccd69b709f67f1 
>   plugins/history/CMakeLists.txt 015df954111a843ba464fe510a3404abc856ce73 
>   plugins/history2/CMakeLists.txt 195edf63462568c5ab3da85ac600422c6eaab6fa 
>   plugins/latex/CMakeLists.txt 7ab71de615f21d30019e26e0c197153ac4b37ab8 
>   plugins/latex/icons/CMakeLists.txt 321add4f82d42b7fb7072b6022457b15a446b30a 
>   plugins/nowlistening/CMakeLists.txt 
> d910afc14c00c4bac80b934753aadb70561d 
>   plugins/otr/CMakeLists.txt f291e55cdd3604138ecbf4220939b0fb121c327f 
>   plugins/otr/icons/CMakeLists.txt 106884f432c1d1e0b0584959af854c79ede4ea6d 
>   plugins/pipes/CMakeLists.txt a3ea9ba26e71ccaa01d7565b522af08be06a446a 
>   plugins/pipes/tests/CMakeLists.txt 1018c9d8c7cb357b00a5b1f36137271df0240d2b 
>   plugins/privacy/CMakeLists.txt b2fdeba9b3a4ab9b249534d6b8cd65a07dd75a84 
>   plugins/statistics/CMakeLists.txt a4bb8dcea0b45d4f0918acbf51a082e17f386001 
>   plugins/texteffect/CMakeLists.txt 892e732004d371c9276040bd35d52d8f06e789e6 
>   plugins/texteffect/icons/CMakeLists.txt 
> 5e7073f2f27421daf5782028ae6e3580e6e1793e 
>   plugins/translator/CMakeLists.txt 2df6e22ba63e11cdbb5ab8ec98da4876686d1144 
>   plugins/urlpicpreview/CMakeLists.txt 
> 9fa72ea53bbb7b679bbe5970df8c17a6c3b3f734 
>   plugins/webpresence/CMakeLists.txt d5c0ebd5d38b9feefb19eb860f76db10c11eb2b2 
>   protocols/bonjour/CMakeLists.txt

Re: Review Request 124721: Adapt CMakeLists.txt to kf5

2015-08-18 Thread Laurent Montel 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124721/#review83993
---



doc-dev/t2/CMakeLists.txt (line 16)
https://git.reviewboard.kde.org/r/124721/#comment58182

/kopete ? perhaps ${CMAKE_SOURCE_DIR}/kopete



doc-dev/t3/CMakeLists.txt (line 16)
https://git.reviewboard.kde.org/r/124721/#comment58183

same here



kopete/CMakeLists.txt (line 62)
https://git.reviewboard.kde.org/r/124721/#comment58184

remove it and all KDE4_*



kopete/contactlist/CMakeLists.txt (line 4)
https://git.reviewboard.kde.org/r/124721/#comment58185

remove it



protocols/groupwise/libgroupwise/tests/CMakeLists.txt (line 11)
https://git.reviewboard.kde.org/r/124721/#comment58186

qt-mt ?



protocols/sms/services/CMakeLists.txt (line 9)
https://git.reviewboard.kde.org/r/124721/#comment58187

Add info about commented code ?
MESSAGE(STATUS commented code )


- Laurent Montel


On août 12, 2015, 8:19 après-midi, R.Harish  Navnit wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124721/
 ---
 
 (Updated août 12, 2015, 8:19 après-midi)
 
 
 Review request for Kopete, Laurent Montel and Pali Rohár.
 
 
 Repository: kopete
 
 
 Description
 ---
 
 Changes obtained by running the kde-dev-scripts/adapt_cmakelists_file script. 
 Adapt CMakeLists.txt for kf5 port.
 
 
 Diffs
 -
 
   kopete/addaccountwizard/CMakeLists.txt 
 e49bf672f4b19eecfa26281fe4a24b91d7aa4a6c 
   kopete/CMakeLists.txt 8097f41cf60f1ad3dfdd3de9212703aa1883a67a 
   icons/CMakeLists.txt 02e3c9ecf2e80622b6cb3a816c89cba556b500a8 
   doc/CMakeLists.txt 91c3e23df02510f1165a8ee33e47362cb71fc350 
   doc-dev/t3/CMakeLists.txt f41a2f841946a852eb071a4429bda31dfa1095d3 
   doc-dev/t2/CMakeLists.txt 0ef0d1c42a33beb9b91c7389317bd7c403d0558d 
   CMakeLists.txt 24479a4fb2e679f97d6685d832fa46e9e5e62cd8 
   kopete/chatwindow/CMakeLists.txt 62e395b07ba2499178b7f7dc90714221e3396fb2 
   kopete/chatwindow/a11y/CMakeLists.txt 
 f20cf4404ee0d21b224bf6d2c1cf849db29401de 
   kopete/chatwindow/tests/CMakeLists.txt 
 adc6129fb6a08a69d63d27d3c5642c32af76805d 
   kopete/config/accounts/CMakeLists.txt 
 f0a463d187df10ea9e4f6a79aceb2a8e7b09e866 
   kopete/config/appearance/CMakeLists.txt 
 abfe7aef01d7de40f8a50341e6155def2b76ecab 
   kopete/config/avdevice/CMakeLists.txt 
 c4e3eb2a44383bcd237afe6406907692040ef0b6 
   kopete/config/behavior/CMakeLists.txt 
 bba08e0725068e00b85d182008b55aa4e6b1e83b 
   kopete/config/chatwindow/CMakeLists.txt 
 89e6faec8310da9e63c6ab1253b3db4fba38b6d3 
   kopete/config/plugins/CMakeLists.txt 
 5dc269d072d86662647d189c3fa887406ab8c2bd 
   kopete/config/status/CMakeLists.txt 
 8cab8f1cfb735bb81663a8e47e394c0f08458562 
   kopete/contactlist/CMakeLists.txt 2219addf953accacf39d534f1a2cd74438b1e295 
   kopete/identity/CMakeLists.txt e42c4b423af2b7ea091ef138f93225535f68a5eb 
   kopete/statusmenu/CMakeLists.txt 6ef9e813d983d83e9c4aabe8a6c6324881b53908 
   libkopete/CMakeLists.txt c1df8437803bc43461529d296defdbf7134fbaea 
   libkopete/avdevice/CMakeLists.txt d91f4c81a6855fa66a0e6eddaf9db5106a91c146 
   libkopete/tests/CMakeLists.txt 78e489a17a6c4393adc903232439b47fdecb16df 
   plugins/CMakeLists.txt 86fe572a13898f4c6c9e26a33f51e4a0786c898b 
   plugins/addbookmarks/CMakeLists.txt 
 84fe18c20fae30af8ac025ec7b1f59ce86709089 
   plugins/alias/CMakeLists.txt ddfe3c24df9b3668e1b3194e626c22b2f6bb55b6 
   plugins/autoreplace/CMakeLists.txt a7a2e90402a503d5ced1166e55bcb82189f1f8ff 
   plugins/autoreplace/icons/CMakeLists.txt 
 c62b24b1187bce066c7b7438a980b79f3954851f 
   plugins/contactnotes/CMakeLists.txt 
 3742e4b9304f9dcefa82291268691dba5129e590 
   plugins/cryptography/CMakeLists.txt 
 f1faffac6ed17209195194242889521a03d34f4d 
   plugins/highlight/CMakeLists.txt eb892732f1008bf78150074abf0b96ee6d5017b8 
   plugins/highlight/icons/CMakeLists.txt 
 1a9fa43e0cbf836dae76112c55ccd69b709f67f1 
   plugins/history/CMakeLists.txt 015df954111a843ba464fe510a3404abc856ce73 
   plugins/history2/CMakeLists.txt 195edf63462568c5ab3da85ac600422c6eaab6fa 
   plugins/latex/CMakeLists.txt 7ab71de615f21d30019e26e0c197153ac4b37ab8 
   plugins/latex/icons/CMakeLists.txt 321add4f82d42b7fb7072b6022457b15a446b30a 
   plugins/nowlistening/CMakeLists.txt 
 d910afc14c00c4bac80b934753aadb70561d 
   plugins/otr/CMakeLists.txt f291e55cdd3604138ecbf4220939b0fb121c327f 
   plugins/otr/icons/CMakeLists.txt 106884f432c1d1e0b0584959af854c79ede4ea6d 
   plugins/pipes/CMakeLists.txt a3ea9ba26e71ccaa01d7565b522af08be06a446a 
   plugins/pipes/tests/CMakeLists.txt 1018c9d8c7cb357b00a5b1f36137271df0240d2b 
   plugins/privacy/CMakeLists.txt b2fdeba9b3a4ab9b249534d6b8cd65a07dd75a84 
   plugins/statistics/CMakeLists.txt

Review Request 124721: Adapt CMakeLists.txt to kf5

2015-08-12 Thread R.Harish Navnit 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124721/
---

Review request for Kopete, Laurent Montel and Pali Rohár.


Repository: kopete


Description
---

Changes obtained by running the kde-dev-scripts/adapt_cmakelists_file script. 
Adapt CMakeLists.txt for kf5 port.


Diffs
-

  kopete/addaccountwizard/CMakeLists.txt 
e49bf672f4b19eecfa26281fe4a24b91d7aa4a6c 
  kopete/CMakeLists.txt 8097f41cf60f1ad3dfdd3de9212703aa1883a67a 
  icons/CMakeLists.txt 02e3c9ecf2e80622b6cb3a816c89cba556b500a8 
  doc/CMakeLists.txt 91c3e23df02510f1165a8ee33e47362cb71fc350 
  doc-dev/t3/CMakeLists.txt f41a2f841946a852eb071a4429bda31dfa1095d3 
  doc-dev/t2/CMakeLists.txt 0ef0d1c42a33beb9b91c7389317bd7c403d0558d 
  CMakeLists.txt 24479a4fb2e679f97d6685d832fa46e9e5e62cd8 
  kopete/chatwindow/CMakeLists.txt 62e395b07ba2499178b7f7dc90714221e3396fb2 
  kopete/chatwindow/a11y/CMakeLists.txt 
f20cf4404ee0d21b224bf6d2c1cf849db29401de 
  kopete/chatwindow/tests/CMakeLists.txt 
adc6129fb6a08a69d63d27d3c5642c32af76805d 
  kopete/config/accounts/CMakeLists.txt 
f0a463d187df10ea9e4f6a79aceb2a8e7b09e866 
  kopete/config/appearance/CMakeLists.txt 
abfe7aef01d7de40f8a50341e6155def2b76ecab 
  kopete/config/avdevice/CMakeLists.txt 
c4e3eb2a44383bcd237afe6406907692040ef0b6 
  kopete/config/behavior/CMakeLists.txt 
bba08e0725068e00b85d182008b55aa4e6b1e83b 
  kopete/config/chatwindow/CMakeLists.txt 
89e6faec8310da9e63c6ab1253b3db4fba38b6d3 
  kopete/config/plugins/CMakeLists.txt 5dc269d072d86662647d189c3fa887406ab8c2bd 
  kopete/config/status/CMakeLists.txt 8cab8f1cfb735bb81663a8e47e394c0f08458562 
  kopete/contactlist/CMakeLists.txt 2219addf953accacf39d534f1a2cd74438b1e295 
  kopete/identity/CMakeLists.txt e42c4b423af2b7ea091ef138f93225535f68a5eb 
  kopete/statusmenu/CMakeLists.txt 6ef9e813d983d83e9c4aabe8a6c6324881b53908 
  libkopete/CMakeLists.txt c1df8437803bc43461529d296defdbf7134fbaea 
  libkopete/avdevice/CMakeLists.txt d91f4c81a6855fa66a0e6eddaf9db5106a91c146 
  libkopete/tests/CMakeLists.txt 78e489a17a6c4393adc903232439b47fdecb16df 
  plugins/CMakeLists.txt 86fe572a13898f4c6c9e26a33f51e4a0786c898b 
  plugins/addbookmarks/CMakeLists.txt 84fe18c20fae30af8ac025ec7b1f59ce86709089 
  plugins/alias/CMakeLists.txt ddfe3c24df9b3668e1b3194e626c22b2f6bb55b6 
  plugins/autoreplace/CMakeLists.txt a7a2e90402a503d5ced1166e55bcb82189f1f8ff 
  plugins/autoreplace/icons/CMakeLists.txt 
c62b24b1187bce066c7b7438a980b79f3954851f 
  plugins/contactnotes/CMakeLists.txt 3742e4b9304f9dcefa82291268691dba5129e590 
  plugins/cryptography/CMakeLists.txt f1faffac6ed17209195194242889521a03d34f4d 
  plugins/highlight/CMakeLists.txt eb892732f1008bf78150074abf0b96ee6d5017b8 
  plugins/highlight/icons/CMakeLists.txt 
1a9fa43e0cbf836dae76112c55ccd69b709f67f1 
  plugins/history/CMakeLists.txt 015df954111a843ba464fe510a3404abc856ce73 
  plugins/history2/CMakeLists.txt 195edf63462568c5ab3da85ac600422c6eaab6fa 
  plugins/latex/CMakeLists.txt 7ab71de615f21d30019e26e0c197153ac4b37ab8 
  plugins/latex/icons/CMakeLists.txt 321add4f82d42b7fb7072b6022457b15a446b30a 
  plugins/nowlistening/CMakeLists.txt d910afc14c00c4bac80b934753aadb70561d 
  plugins/otr/CMakeLists.txt f291e55cdd3604138ecbf4220939b0fb121c327f 
  plugins/otr/icons/CMakeLists.txt 106884f432c1d1e0b0584959af854c79ede4ea6d 
  plugins/pipes/CMakeLists.txt a3ea9ba26e71ccaa01d7565b522af08be06a446a 
  plugins/pipes/tests/CMakeLists.txt 1018c9d8c7cb357b00a5b1f36137271df0240d2b 
  plugins/privacy/CMakeLists.txt b2fdeba9b3a4ab9b249534d6b8cd65a07dd75a84 
  plugins/statistics/CMakeLists.txt a4bb8dcea0b45d4f0918acbf51a082e17f386001 
  plugins/texteffect/CMakeLists.txt 892e732004d371c9276040bd35d52d8f06e789e6 
  plugins/texteffect/icons/CMakeLists.txt 
5e7073f2f27421daf5782028ae6e3580e6e1793e 
  plugins/translator/CMakeLists.txt 2df6e22ba63e11cdbb5ab8ec98da4876686d1144 
  plugins/urlpicpreview/CMakeLists.txt 9fa72ea53bbb7b679bbe5970df8c17a6c3b3f734 
  plugins/webpresence/CMakeLists.txt d5c0ebd5d38b9feefb19eb860f76db10c11eb2b2 
  protocols/bonjour/CMakeLists.txt c7acede530d5a3e7f963d4712defef9bf0fd85f3 
  protocols/bonjour/icons/CMakeLists.txt 
5c80f4680e6baa5cc7b2e9c7b6761cf752da9d1d 
  protocols/gadu/CMakeLists.txt b6da7736c94a1174b507aac3055b88c76da6aec2 
  protocols/gadu/icons/CMakeLists.txt 5a4021207f802e546d1c4cc44efb0292e875ec2f 
  protocols/groupwise/CMakeLists.txt 936e9be09131ec93da3aec27ffe0e45f1625a523 
  protocols/groupwise/icons/CMakeLists.txt 
5a4021207f802e546d1c4cc44efb0292e875ec2f 
  protocols/groupwise/libgroupwise/CMakeLists.txt 
45d0859863e2e0d34ccc0106902c9b74a240b8aa 
  protocols/groupwise/libgroupwise/tasks/tests/CMakeLists.txt 
44be324d3a283ff4bde27a994338b9891bfaca2e 
  protocols/groupwise/libgroupwise/tests/CMakeLists.txt 
a7272c40f6560febe8d33cc3c192578e3ce893b1 
  protocols/irc/CMakeLists.txt