[LEDE-DEV] [PATCH] ubox: Replace strerror(errno) with %m format.
Saves 872 bytes on Ubuntu 16.04. No change in functionality. Signed-off-by: Rosen Penev--- getrandom.c | 4 ++-- log/logd.c| 2 +- log/logread.c | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/getrandom.c b/getrandom.c index 73a37b0..ad3a7af 100644 --- a/getrandom.c +++ b/getrandom.c @@ -50,9 +50,9 @@ int main(int argc, char *argv[]) if (nbtot <= sizeof(buf)) len = nbtot; if (syscall(SYS_getrandom, buf, len, 0) == -1) - ERROR_EXIT("getrandom() failed: %s\n", strerror(errno)); + ERROR_EXIT("getrandom() failed: %m\n"); if (write(STDOUT_FILENO, buf, len) != len) - ERROR_EXIT("write() failed: %s\n", strerror(errno)); + ERROR_EXIT("write() failed: %m\n"); nbtot -= sizeof(buf); } diff --git a/log/logd.c b/log/logd.c index 9931723..18788fe 100644 --- a/log/logd.c +++ b/log/logd.c @@ -119,7 +119,7 @@ read_log(struct ubus_context *ctx, struct ubus_object *obj, l = log_list(count, NULL); if (stream) { if (pipe(fds) == -1) { - fprintf(stderr, "logd: failed to create pipe: %s\n", strerror(errno)); + fprintf(stderr, "logd: failed to create pipe: %m\n"); return -1; } diff --git a/log/logread.c b/log/logread.c index 784d1f9..d85e03c 100644 --- a/log/logread.c +++ b/log/logread.c @@ -78,7 +78,7 @@ static void log_handle_reconnect(struct uloop_timeout *timeout) { sender.fd = usock((log_udp) ? (USOCK_UDP) : (USOCK_TCP), log_ip, log_port); if (sender.fd < 0) { - fprintf(stderr, "failed to connect: %s\n", strerror(errno)); + fprintf(stderr, "failed to connect: %m\n"); uloop_timeout_set(, 1000); } else { uloop_fd_add(, ULOOP_READ); @@ -126,7 +126,7 @@ static int log_notify(struct blob_attr *msg) } sender.fd = open(log_file, O_CREAT | O_WRONLY | O_APPEND, 0600); if (sender.fd < 0) { - fprintf(stderr, "failed to open %s: %s\n", log_file, strerror(errno)); + fprintf(stderr, "failed to open %s: %m\n", log_file); exit(-1); } } @@ -358,7 +358,7 @@ int main(int argc, char **argv) log_type = LOG_FILE; sender.fd = open(log_file, O_CREAT | O_WRONLY| O_APPEND, 0600); if (sender.fd < 0) { - fprintf(stderr, "failed to open %s: %s\n", log_file, strerror(errno)); + fprintf(stderr, "failed to open %s: %m\n", log_file); exit(-1); } } else { -- 2.7.4 ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
[LEDE-DEV] [PATCH v2] imx6: add support for the intel gbit driver on GW5520
The Gateworks GW5520 board uses 2x intel gigabit mac's, instead of the internal i.MX6 FEC. Add support for these. Signed-off-by: Scott V. KampSigned-off-by: Koen Vandeputte --- target/linux/imx6/config-4.9 | 1 + 1 file changed, 1 insertion(+) diff --git a/target/linux/imx6/config-4.9 b/target/linux/imx6/config-4.9 index e4f262b38183..12ba56687747 100644 --- a/target/linux/imx6/config-4.9 +++ b/target/linux/imx6/config-4.9 @@ -160,6 +160,7 @@ CONFIG_DMADEVICES=y CONFIG_DMA_ENGINE=y CONFIG_DMA_OF=y CONFIG_DTC=y +CONFIG_E1000E=y CONFIG_EDAC_ATOMIC_SCRUB=y CONFIG_EDAC_SUPPORT=y # CONFIG_ENABLE_DEFAULT_TRACERS is not set -- 2.7.4 ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
[LEDE-DEV] [PATCH] config: don't define the same symbol twice
In commit fce35bce0f6e ("config: support new symbol intro'd in kernel 4.12") I forgot to remove the initial debug test line. This clearly is wrong as the same symbol is defined conditionally in the line below as it should be. I looked over it as I just checked if the symbol was present now upon testing it. Fixes: fce35bce0f6e ("config: support new symbol intro'd in kernel 4.12") Signed-off-by: Koen Vandeputte--- include/kernel-defaults.mk | 1 - 1 file changed, 1 deletion(-) diff --git a/include/kernel-defaults.mk b/include/kernel-defaults.mk index 33f3a8210ff0..5e905a2faa68 100644 --- a/include/kernel-defaults.mk +++ b/include/kernel-defaults.mk @@ -63,7 +63,6 @@ ifeq ($(CONFIG_TARGET_ROOTFS_INITRAMFS),y) $(call Kernel/SetInitramfs/PreConfigure) echo 'CONFIG_INITRAMFS_ROOT_UID=$(shell id -u)' >> $(LINUX_DIR)/.config echo 'CONFIG_INITRAMFS_ROOT_GID=$(shell id -g)' >> $(LINUX_DIR)/.config - echo 'CONFIG_INITRAMFS_FORCE=y' >> $(LINUX_DIR)/.config echo "$(if $(CONFIG_TARGET_INITRAMFS_FORCE),CONFIG_INITRAMFS_FORCE=y,# CONFIG_INITRAMFS_FORCE is not set)" >> $(LINUX_DIR)/.config echo "$(if $(CONFIG_TARGET_INITRAMFS_COMPRESSION_NONE),CONFIG_INITRAMFS_COMPRESSION_NONE=y,# CONFIG_INITRAMFS_COMPRESSION_NONE is not set)" >> $(LINUX_DIR)/.config echo -e "$(if $(CONFIG_TARGET_INITRAMFS_COMPRESSION_GZIP),CONFIG_INITRAMFS_COMPRESSION_GZIP=y\nCONFIG_RD_GZIP=y,# CONFIG_INITRAMFS_COMPRESSION_GZIP is not set\n# CONFIG_RD_GZIP is not set)" >> $(LINUX_DIR)/.config -- 2.7.4 ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
[LEDE-DEV] Merged:
Merged into lede-17.01 with http://git.lede-project.org/?p=source.git;a=commitdiff;h=a9d1c0e923. Thank you! ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] ath9k - WARN_ON origskb->len <= FCS_LEN - Driver bug?
Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.617226] [ cut here ] Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.621909] WARNING: CPU: 0 PID: 0 at backports-2017-11-01/net/mac80211/rx.c:629 ieee80211_rx_napi+0x1dd/0x7de [mac80211] Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.632921] Modules linked in: ath9k ath9k_common pppoe ppp_async ath9k_hw ath pppox ppp_generic nf_conntrack_ipv6 mac80211 iptable_nat ipt_REJECT ipt_MASQUERADE cfg80211 xt_time xt_tcpudp xt_state xt_nat xt_multiport xt_mark xt_mac xt_limit xt_conntrack xt_comment xt_TCPMSS xt_REDIRECT xt_LOG xt_CT slhc r8169 nf_reject_ipv4 nf_nat_redirect nf_nat_masquerade_ipv4 nf_conntrack_ipv4 nf_nat_ipv4 nf_nat nf_log_ipv4 nf_defrag_ipv6 nf_defrag_ipv4 nf_conntrack_rtcache nf_conntrack iptable_mangle iptable_filter ip_tables e1000e crc_ccitt compat i2c_dev ip6t_REJECT nf_reject_ipv6 nf_log_ipv6 nf_log_common ip6table_mangle ip6table_filter ip6_tables x_tables igb i2c_algo_bit e1000 leds_apu2 button_hotplug ptp pps_core mii Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.697754] CPU: 0 PID: 0 Comm: swapper/0 Tainted: GW 4.9.76 #0 Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.704922] Hardware name: PC Engines APU2/APU2, BIOS 4.0.7 02/28/2017 Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.711473] 811f34ee 0009 Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.719045] 8106c2bc 880119612800 880118e50f40 Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.726575] 0246 880119612800 a01ad021 Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.734133] Call Trace: Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.736607] Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.738554] [] ? dump_stack+0x5d/0x79 Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.743937] [] ? __warn+0xb2/0xcb Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.748963] [] ? ieee80211_rx_napi+0x1dd/0x7de [mac80211] Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.756042] [] ? swiotlb_tbl_map_single+0x198/0x22e Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.762603] [] ? ath9k_cmn_rx_skb_postprocess+0x47/0x10d [ath9k_common] Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.770936] [] ? ath_rx_tasklet+0xc2f/0xc55 [ath9k] Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.777496] [] ? ath9k_tasklet+0x160/0x1d9 [ath9k] Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.783964] [] ? tasklet_action+0x9f/0xa8 Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.789680] [] ? __do_softirq+0xb8/0x1a1 Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.795284] [] ? irq_exit+0x4f/0x5b Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.800455] [] ? do_IRQ+0xa4/0xba Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.805451] [] ? common_interrupt+0x93/0x93 Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.811312] Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.813258] [] ? native_safe_halt+0x2/0x3 Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.818971] [] ? acpi_safe_halt+0x15/0x1f Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.824656] [] ? acpi_idle_enter+0x1be/0x1de Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.830622] [] ? cpuidle_enter_state+0xda/0x18e Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.836849] [] ? cpu_startup_entry+0x15b/0x1ce Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.842994] [] ? start_kernel+0x4e2/0x4ea Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.848684] [] ? early_idt_handler_array+0x120/0x120 Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.855331] [] ? x86_64_start_kernel+0xe5/0xf2 Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.861465] ---[ end trace 031f3c64238b9dd3 ]--- Sat Jan 13 09:30:19 2018 kern.warn kernel: [49273.996500] [ cut here ] On Sat, Jan 13, 2018 at 4:25 PM, Nick Lowewrote: > Hi all, > > I am seeing a WARN_ON being hit frequently with ath9k after updating > to OpenWrt SNAPSHOT r5763-89233a8. The code generating the warning > seems to point that this is a driver bug. > > rx.c: > if (ieee80211_hw_check(>hw, RX_INCLUDES_FCS)) { > if (unlikely(origskb->len <= FCS_LEN)) { > /* driver bug */ > WARN_ON(1); > dev_kfree_skb(origskb); > return NULL; > } > present_fcs_len = FCS_LEN; > } > > Any thoughts? :-) > > > Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.585033] > [ cut here ] > Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.589716] WARNING: > CPU: 0 PID: 11565 at backports-2017-11-01/net/mac80211/rx.c:629 > ieee80211_rx_napi+0x1dd/0x7de [mac80211] > Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.601095] Modules > linked in: ath9k ath9k_common pppoe ppp_async ath9k_hw ath pppox > ppp_generic nf_conntrack_ipv6
[LEDE-DEV] ath9k - WARN_ON origskb->len <= FCS_LEN - Driver bug?
Hi all, I am seeing a WARN_ON being hit frequently with ath9k after updating to OpenWrt SNAPSHOT r5763-89233a8. The code generating the warning seems to point that this is a driver bug. rx.c: if (ieee80211_hw_check(>hw, RX_INCLUDES_FCS)) { if (unlikely(origskb->len <= FCS_LEN)) { /* driver bug */ WARN_ON(1); dev_kfree_skb(origskb); return NULL; } present_fcs_len = FCS_LEN; } Any thoughts? :-) Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.585033] [ cut here ] Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.589716] WARNING: CPU: 0 PID: 11565 at backports-2017-11-01/net/mac80211/rx.c:629 ieee80211_rx_napi+0x1dd/0x7de [mac80211] Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.601095] Modules linked in: ath9k ath9k_common pppoe ppp_async ath9k_hw ath pppox ppp_generic nf_conntrack_ipv6 mac80211 iptable_nat ipt_REJECT ipt_MASQUERADE cfg80211 xt_time xt_tcpudp xt_state xt_nat xt_multiport xt_mark xt_mac xt_limit xt_conntrack xt_comment xt_TCPMSS xt_REDIRECT xt_LOG xt_CT slhc r8169 nf_reject_ipv4 nf_nat_redirect nf_nat_masquerade_ipv4 nf_conntrack_ipv4 nf_nat_ipv4 nf_nat nf_log_ipv4 nf_defrag_ipv6 nf_defrag_ipv4 nf_conntrack_rtcache nf_conntrack iptable_mangle iptable_filter ip_tables e1000e crc_ccitt compat i2c_dev ip6t_REJECT nf_reject_ipv6 nf_log_ipv6 nf_log_common ip6table_mangle ip6table_filter ip6_tables x_tables igb i2c_algo_bit e1000 leds_apu2 button_hotplug ptp pps_core mii Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.665926] CPU: 0 PID: 11565 Comm: kworker/u8:1 Tainted: GW 4.9.76 #0 Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.673715] Hardware name: PC Engines APU2/APU2, BIOS 4.0.7 02/28/2017 Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.680288] Workqueue: phy0 ath_reset_work [ath9k] Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.685135] 811f34ee 0009 Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.692664] 8106c2bc 88011944f100 880118e50f40 Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.700197] 0246 88011944f100 a01ad021 Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.707745] Call Trace: Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.710228] [] ? dump_stack+0x5d/0x79 Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.715590] [] ? __warn+0xb2/0xcb Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.720607] [] ? ieee80211_rx_napi+0x1dd/0x7de [mac80211] Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.727685] [] ? swiotlb_tbl_map_single+0x198/0x22e Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.734256] [] ? ath9k_cmn_rx_skb_postprocess+0x47/0x10d [ath9k_common] Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.742581] [] ? ath_rx_tasklet+0xc2f/0xc55 [ath9k] Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.749149] [] ? ath_stoprecv+0x67/0xbf7 [ath9k] Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.755449] [] ? ath9k_deinit_device+0x49d/0x67d [ath9k] Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.762471] [] ? ath9k_calculate_summary_state+0x46f/0x52a [ath9k] Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.770366] [] ? ath_reset_work+0x1a/0x1cc [ath9k] Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.776845] [] ? process_one_work+0x196/0x29f Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.782894] [] ? worker_thread+0x28e/0x381 Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.788674] [] ? rescuer_thread+0x2d7/0x2d7 Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.794536] [] ? do_group_exit+0x36/0x98 Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.800144] [] ? kthread+0xc2/0xca Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.805231] [] ? kthread_park+0x4b/0x4b Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.810753] [] ? ret_from_fork+0x41/0x50 Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.816387] ---[ end trace 031f3c64238b9dd0 ]--- Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.050693] [ cut here ] Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.055414] WARNING: CPU: 1 PID: 0 at backports-2017-11-01/net/mac80211/rx.c:629 ieee80211_rx_napi+0x1dd/0x7de [mac80211] Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.066442] Modules linked in: ath9k ath9k_common pppoe ppp_async ath9k_hw ath pppox ppp_generic nf_conntrack_ipv6 mac80211 iptable_nat ipt_REJECT ipt_MASQUERADE cfg80211 xt_time xt_tcpudp xt_state xt_nat xt_multiport xt_mark xt_mac xt_limit xt_conntrack xt_comment xt_TCPMSS xt_REDIRECT xt_LOG xt_CT slhc r8169 nf_reject_ipv4 nf_nat_redirect nf_nat_masquerade_ipv4 nf_conntrack_ipv4 nf_nat_ipv4 nf_nat nf_log_ipv4 nf_defrag_ipv6 nf_defrag_ipv4 nf_conntrack_rtcache nf_conntrack iptable_mangle iptable_filter ip_tables e1000e crc_ccitt compat i2c_dev ip6t_REJECT nf_reject_ipv6 nf_log_ipv6
[LEDE-DEV] [PATCH v2] ar71xx: Netgear WNR2000v4: do not include USB packages [17.01]
The Netgear WNR2000v4 does not have a USB port. Hence, including USB packages into the default images is useless. It looks like the WNR2000v4 definition in master is OK. v2 fixes the silly typo in the patch title (WNR2000v4 instead of WNR200v4) Signed-off-by: Stijn Segers--- target/linux/ar71xx/image/legacy-devices.mk | 1 - 1 file changed, 1 deletion(-) diff --git a/target/linux/ar71xx/image/legacy-devices.mk b/target/linux/ar71xx/image/legacy-devices.mk index 87423ce55c..6667bef97e 100644 --- a/target/linux/ar71xx/image/legacy-devices.mk +++ b/target/linux/ar71xx/image/legacy-devices.mk @@ -440,7 +440,6 @@ LEGACY_DEVICES += WNR2000V3 define LegacyDevice/WNR2000V4 DEVICE_TITLE := NETGEAR WNR2000V4 - DEVICE_PACKAGES := kmod-usb-core kmod-usb2 kmod-usb-ledtrig-usbport endef LEGACY_DEVICES += WNR2000V4 -- 2.11.0 ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
[LEDE-DEV] [PATCH] ar71xx: Netgear WNR200v4: do not include USB packages [17.01]
The Netgear WNR2000v4 does not have a USB port. Hence, including USB packages into the default images is useless. It looks like the WNR2000v4 definition in master is OK. Signed-off-by: Stijn Segers--- target/linux/ar71xx/image/legacy-devices.mk | 1 - 1 file changed, 1 deletion(-) diff --git a/target/linux/ar71xx/image/legacy-devices.mk b/target/linux/ar71xx/image/legacy-devices.mk index 87423ce55c..6667bef97e 100644 --- a/target/linux/ar71xx/image/legacy-devices.mk +++ b/target/linux/ar71xx/image/legacy-devices.mk @@ -440,7 +440,6 @@ LEGACY_DEVICES += WNR2000V3 define LegacyDevice/WNR2000V4 DEVICE_TITLE := NETGEAR WNR2000V4 - DEVICE_PACKAGES := kmod-usb-core kmod-usb2 kmod-usb-ledtrig-usbport endef LEGACY_DEVICES += WNR2000V4 -- 2.11.0 ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [PATCH v4] ar71xx: add ew-balin platform from Embedded Wireless
Hello Catrinel, As John already wrote, it seems that your patch got whitespace mangled. Please, send new version using git send-email. Also, please see minor comments inline, below. On 13.01.2018 11:36, Catrinel Catrinescu wrote: Add the Embedded Wireless "Balin" platform, based on AR9344: http://www.embeddedwireless.de/uploads/Balin_data_2016_10.pdf Please, drop url from commit message. SoC: QCA AR9344 or AR9350 RAM: DDR2-RAM 64MBytes Flash: SPI-NOR 16MBytes WLAN: 2 x 2 MIMO 2.4 & 5 GHz IEEE802.11 a/b/g/n Ethernet: 3 x 10/100 Mb/s USB: 1 x USB2.0 Host/Device bootstrap-pin at power-up PCI-Express: 1 x lane PCIe 1.2 UART: 1 x Normal, 1 x High-Speed JTAG: 1 x EJTAG GPIO: 10 x Input/Output multiplexed The module comes already with the current vanilla OpenWRT firmware, so no need to install "factory"-image, or any other stuff :-) OpenWRT -> OpenWrt. If the boards already runs OpenWrt, maybe it would be better to write something like this instead: Use "sysupgrade" image directly in vendor firmware which is based on OpenWrt. I don't see any reason to mention that "factory" image is not required when your patch doesn't include code for it. And please, drop ":-)" ;) Signed-off-by: Catrinel Catrinescu--- .../linux/ar71xx/base-files/etc/board.d/02_network | 6 ++ target/linux/ar71xx/base-files/etc/diag.sh | 3 + .../etc/uci-defaults/03_network-switchX-migration | 1 + target/linux/ar71xx/base-files/lib/ar71xx.sh | 3 + .../ar71xx/base-files/lib/upgrade/platform.sh | 1 + target/linux/ar71xx/config-4.4 | 1 + target/linux/ar71xx/config-4.9 | 1 + .../ar71xx/files/arch/mips/ath79/Kconfig.openwrt | 11 ++ target/linux/ar71xx/files/arch/mips/ath79/Makefile | 1 + .../ar71xx/files/arch/mips/ath79/mach-ew-balin.c | 112 + .../linux/ar71xx/files/arch/mips/ath79/machtypes.h | 1 + target/linux/ar71xx/image/generic.mk | 9 ++ target/linux/ar71xx/mikrotik/config-default| 1 + target/linux/ar71xx/nand/config-default| 1 + 14 files changed, 152 insertions(+) create mode 100644 target/linux/ar71xx/files/arch/mips/ath79/mach-ew-balin.c diff --git a/target/linux/ar71xx/base-files/etc/board.d/02_network b/target/linux/ar71xx/base-files/etc/board.d/02_network index fb61792bf4..4919e7c983 100755 --- a/target/linux/ar71xx/base-files/etc/board.d/02_network +++ b/target/linux/ar71xx/base-files/etc/board.d/02_network @@ -368,6 +368,12 @@ ar71xx_setup_interfaces() ucidef_add_switch "switch0" \ "0@eth0" "1:lan:4" "2:lan:3" "3:lan:2" "4:lan:1" "5:wan" ;; + ew-balin) + ucidef_set_interface_raw "usb2" "usb0" "static" + ucidef_set_interface_raw "usb3" "usb0" "static" Could you please explain these two lines? This code will create two static interfaces with the same netdev (usb0). Is USB in this module/board set to device mode by default? + ucidef_add_switch "switch0" \ + "0@eth0" "5:lan:4" "4:lan:5" "3:wan" + ;; ew-dorin) ucidef_add_switch "switch0" \ "0@eth0" "1:lan" "2:lan" "3:wan" diff --git a/target/linux/ar71xx/base-files/etc/diag.sh b/target/linux/ar71xx/base-files/etc/diag.sh index 6cbb3576d8..ca73d5f62b 100644 --- a/target/linux/ar71xx/base-files/etc/diag.sh +++ b/target/linux/ar71xx/base-files/etc/diag.sh @@ -193,6 +193,9 @@ get_status_led() { el-mini) status_led="easylink:green:system" ;; + ew-balin) + status_led="balin:green:status" + ;; ew-dorin|\ ew-dorin-router) status_led="dorin:green:status" diff --git a/target/linux/ar71xx/base-files/lib/ar71xx.sh b/target/linux/ar71xx/base-files/lib/ar71xx.sh index b5440230a5..162742a94c 100755 --- a/target/linux/ar71xx/base-files/lib/ar71xx.sh +++ b/target/linux/ar71xx/base-files/lib/ar71xx.sh @@ -640,6 +640,9 @@ ar71xx_board_detect() { *"EL-MINI") name="el-mini" ;; + *EmbWir-Balin) *"EmbWir-Balin") + name="ew-balin" + ;; *"EmbWir-Dorin") name="ew-dorin" ;; diff --git a/target/linux/ar71xx/base-files/lib/upgrade/platform.sh b/target/linux/ar71xx/base-files/lib/upgrade/platform.sh index ecf6820a2b..9dceadc563 100755 --- a/target/linux/ar71xx/base-files/lib/upgrade/platform.sh +++ b/target/linux/ar71xx/base-files/lib/upgrade/platform.sh @@ -237,6 +237,7 @@ platform_check_image() { epg5000|\ esr1750|\ esr900|\ + ew-balin|\ ew-dorin|\ ew-dorin-router|\ gl-ar150|\ diff --git a/target/linux/ar71xx/config-4.4 b/target/linux/ar71xx/config-4.4 index 5a8004a03e..36b266f21c 100644 --- a/target/linux/ar71xx/config-4.4 +++
Re: [LEDE-DEV] [PATCH v4] ar71xx: add ew-balin platform from Embedded Wireless
Hi, patch is whitespace mangled and does not apply. How did you send the patch ? [...] --- a/target/linux/ar71xx/config-4.4 +++ b/target/linux/ar71xx/config-4.4 @@ -109,6 +109,7 @@ CONFIG_ATH79_MACH_ENS202EXT=y CONFIG_ATH79_MACH_EPG5000=y CONFIG_ATH79_MACH_ESR1750=y CONFIG_ATH79_MACH_ESR900=y here +CONFIG_ATH79_MACH_EW_BALIN=y CONFIG_ATH79_MACH_EW_DORIN=y CONFIG_ATH79_MACH_F9K1115V2=y CONFIG_ATH79_MACH_FRITZ300E=y diff --git a/target/linux/ar71xx/config-4.9 b/target/linux/ar71xx/config-4.9 index 4334d25b80..d51fe5f797 100644 --- a/target/linux/ar71xx/config-4.9 +++ b/target/linux/ar71xx/config-4.9 @@ -107,6 +107,7 @@ CONFIG_ATH79_MACH_ENS202EXT=y CONFIG_ATH79_MACH_EPG5000=y CONFIG_ATH79_MACH_ESR1750=y CONFIG_ATH79_MACH_ESR900=y and here John +CONFIG_ATH79_MACH_EW_BALIN=y CONFIG_ATH79_MACH_EW_DORIN=y CONFIG_ATH79_MACH_F9K1115V2=y CONFIG_ATH79_MACH_FRITZ300E=y diff --git a/target/linux/ar71xx/files/arch/mips/ath79/Kconfig.openwrt b/target/linux/ar71xx/files/arch/mips/ath79/Kconfig.openwrt index 1198fcb74b..a94c5a3a2e 100644 --- a/target/linux/ar71xx/files/arch/mips/ath79/Kconfig.openwrt +++ b/target/linux/ar71xx/files/arch/mips/ath79/Kconfig.openwrt @@ -702,6 +702,17 @@ config ATH79_MACH_ESR900 select ATH79_DEV_WMAC select ATH79_NVRAM +config ATH79_MACH_EW_BALIN + bool "embedded wireless Balin Platform support" + select SOC_AR934X + select ATH79_DEV_M25P80 + select ATH79_DEV_GPIO_BUTTONS + select ATH79_DEV_LEDS_GPIO + select ATH79_DEV_WMAC + select ATH79_DEV_ETH + select ATH79_DEV_USB + select ATH79_DEV_AP9X_PCI if PCI + config ATH79_MACH_EW_DORIN bool "embedded wireless Dorin Platform support" select SOC_AR933X diff --git a/target/linux/ar71xx/files/arch/mips/ath79/Makefile b/target/linux/ar71xx/files/arch/mips/ath79/Makefile index 455af762e3..bde1b75308 100644 --- a/target/linux/ar71xx/files/arch/mips/ath79/Makefile +++ b/target/linux/ar71xx/files/arch/mips/ath79/Makefile @@ -115,6 +115,7 @@ obj-$(CONFIG_ATH79_MACH_ENS202EXT) += mach-ens202ext.o obj-$(CONFIG_ATH79_MACH_EPG5000) += mach-epg5000.o obj-$(CONFIG_ATH79_MACH_ESR1750) += mach-esr1750.o obj-$(CONFIG_ATH79_MACH_ESR900) += mach-esr900.o +obj-$(CONFIG_ATH79_MACH_EW_BALIN) += mach-ew-balin.o obj-$(CONFIG_ATH79_MACH_EW_DORIN) += mach-ew-dorin.o obj-$(CONFIG_ATH79_MACH_F9K1115V2)+= mach-f9k1115v2.o obj-$(CONFIG_ATH79_MACH_FRITZ300E)+= mach-fritz300e.o diff --git a/target/linux/ar71xx/files/arch/mips/ath79/mach-ew-balin.c b/target/linux/ar71xx/files/arch/mips/ath79/mach-ew-balin.c new file mode 100644 index 00..7d7f38c1d2 --- /dev/null +++ b/target/linux/ar71xx/files/arch/mips/ath79/mach-ew-balin.c @@ -0,0 +1,112 @@ +/* + * EW Balin board support + * (based on Atheros DB120 reference board support) + * + * Copyright (c) 2011 Qualcomm Atheros + * Copyright (c) 2011-2012 Gabor Juhos+ * Copyright (C) 2017 Embedded Wireless GmbHwww.80211.de + * + * Permission to use, copy, modify, and/or distribute this software for +any + * purpose with or without fee is hereby granted, provided that the +above + * copyright notice and this permission notice appear in all copies. + * + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL +WARRANTIES + * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF + * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE +FOR + * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY +DAMAGES + * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN +AN + * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT +OF + * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. + * + */ + +#include +#include +#include +#include +#include + +#include + +#include "common.h" +#include "dev-ap9x-pci.h" +#include "dev-eth.h" +#include "dev-gpio-buttons.h" +#include "dev-leds-gpio.h" +#include "dev-m25p80.h" +#include "dev-spi.h" +#include "dev-usb.h" +#include "dev-wmac.h" +#include "machtypes.h" +#include "pci.h" + +#define BALIN_GPIO_LED_STATUS 14 + +#define BALIN_GPIO_BTN_WPS 18 + +#define BALIN_KEYS_POLL_INTERVAL 20 /* msecs */ +#define BALIN_KEYS_DEBOUNCE_INTERVAL (3 * BALIN_KEYS_POLL_INTERVAL) + +#define BALIN_CALDATA_OFFSET 0x1000 +#define BALIN_WMAC_MAC_OFFSET (BALIN_CALDATA_OFFSET + 0x02) + +static struct gpio_led balin_leds_gpio[] __initdata = { + { + .name = "balin:green:status", + .gpio = BALIN_GPIO_LED_STATUS, + .active_low = 1, + }, +}; + +static struct gpio_keys_button balin_gpio_keys[] __initdata = { + { + .desc = "WPS button", + .type = EV_KEY, + .code =
[LEDE-DEV] [PATCH v4] ar71xx: add ew-balin platform from Embedded Wireless
Add the Embedded Wireless "Balin" platform, based on AR9344: http://www.embeddedwireless.de/uploads/Balin_data_2016_10.pdf SoC: QCA AR9344 or AR9350 RAM: DDR2-RAM 64MBytes Flash: SPI-NOR 16MBytes WLAN: 2 x 2 MIMO 2.4 & 5 GHz IEEE802.11 a/b/g/n Ethernet: 3 x 10/100 Mb/s USB: 1 x USB2.0 Host/Device bootstrap-pin at power-up PCI-Express: 1 x lane PCIe 1.2 UART: 1 x Normal, 1 x High-Speed JTAG: 1 x EJTAG GPIO: 10 x Input/Output multiplexed The module comes already with the current vanilla OpenWRT firmware, so no need to install "factory"-image, or any other stuff :-) Signed-off-by: Catrinel Catrinescu--- .../linux/ar71xx/base-files/etc/board.d/02_network | 6 ++ target/linux/ar71xx/base-files/etc/diag.sh | 3 + .../etc/uci-defaults/03_network-switchX-migration | 1 + target/linux/ar71xx/base-files/lib/ar71xx.sh | 3 + .../ar71xx/base-files/lib/upgrade/platform.sh | 1 + target/linux/ar71xx/config-4.4 | 1 + target/linux/ar71xx/config-4.9 | 1 + .../ar71xx/files/arch/mips/ath79/Kconfig.openwrt | 11 ++ target/linux/ar71xx/files/arch/mips/ath79/Makefile | 1 + .../ar71xx/files/arch/mips/ath79/mach-ew-balin.c | 112 + .../linux/ar71xx/files/arch/mips/ath79/machtypes.h | 1 + target/linux/ar71xx/image/generic.mk | 9 ++ target/linux/ar71xx/mikrotik/config-default| 1 + target/linux/ar71xx/nand/config-default| 1 + 14 files changed, 152 insertions(+) create mode 100644 target/linux/ar71xx/files/arch/mips/ath79/mach-ew-balin.c diff --git a/target/linux/ar71xx/base-files/etc/board.d/02_network b/target/linux/ar71xx/base-files/etc/board.d/02_network index fb61792bf4..4919e7c983 100755 --- a/target/linux/ar71xx/base-files/etc/board.d/02_network +++ b/target/linux/ar71xx/base-files/etc/board.d/02_network @@ -368,6 +368,12 @@ ar71xx_setup_interfaces() ucidef_add_switch "switch0" \ "0@eth0" "1:lan:4" "2:lan:3" "3:lan:2" "4:lan:1" "5:wan" ;; + ew-balin) + ucidef_set_interface_raw "usb2" "usb0" "static" + ucidef_set_interface_raw "usb3" "usb0" "static" + ucidef_add_switch "switch0" \ + "0@eth0" "5:lan:4" "4:lan:5" "3:wan" + ;; ew-dorin) ucidef_add_switch "switch0" \ "0@eth0" "1:lan" "2:lan" "3:wan" diff --git a/target/linux/ar71xx/base-files/etc/diag.sh b/target/linux/ar71xx/base-files/etc/diag.sh index 6cbb3576d8..ca73d5f62b 100644 --- a/target/linux/ar71xx/base-files/etc/diag.sh +++ b/target/linux/ar71xx/base-files/etc/diag.sh @@ -193,6 +193,9 @@ get_status_led() { el-mini) status_led="easylink:green:system" ;; + ew-balin) + status_led="balin:green:status" + ;; ew-dorin|\ ew-dorin-router) status_led="dorin:green:status" diff --git a/target/linux/ar71xx/base-files/lib/ar71xx.sh b/target/linux/ar71xx/base-files/lib/ar71xx.sh index b5440230a5..162742a94c 100755 --- a/target/linux/ar71xx/base-files/lib/ar71xx.sh +++ b/target/linux/ar71xx/base-files/lib/ar71xx.sh @@ -640,6 +640,9 @@ ar71xx_board_detect() { *"EL-MINI") name="el-mini" ;; + *EmbWir-Balin) + name="ew-balin" + ;; *"EmbWir-Dorin") name="ew-dorin" ;; diff --git a/target/linux/ar71xx/base-files/lib/upgrade/platform.sh b/target/linux/ar71xx/base-files/lib/upgrade/platform.sh index ecf6820a2b..9dceadc563 100755 --- a/target/linux/ar71xx/base-files/lib/upgrade/platform.sh +++ b/target/linux/ar71xx/base-files/lib/upgrade/platform.sh @@ -237,6 +237,7 @@ platform_check_image() { epg5000|\ esr1750|\ esr900|\ + ew-balin|\ ew-dorin|\ ew-dorin-router|\ gl-ar150|\ diff --git a/target/linux/ar71xx/config-4.4 b/target/linux/ar71xx/config-4.4 index 5a8004a03e..36b266f21c 100644 --- a/target/linux/ar71xx/config-4.4 +++ b/target/linux/ar71xx/config-4.4 @@ -109,6 +109,7 @@ CONFIG_ATH79_MACH_ENS202EXT=y CONFIG_ATH79_MACH_EPG5000=y CONFIG_ATH79_MACH_ESR1750=y CONFIG_ATH79_MACH_ESR900=y +CONFIG_ATH79_MACH_EW_BALIN=y CONFIG_ATH79_MACH_EW_DORIN=y CONFIG_ATH79_MACH_F9K1115V2=y CONFIG_ATH79_MACH_FRITZ300E=y diff --git a/target/linux/ar71xx/config-4.9 b/target/linux/ar71xx/config-4.9 index 4334d25b80..d51fe5f797 100644 --- a/target/linux/ar71xx/config-4.9 +++ b/target/linux/ar71xx/config-4.9 @@ -107,6 +107,7 @@ CONFIG_ATH79_MACH_ENS202EXT=y CONFIG_ATH79_MACH_EPG5000=y CONFIG_ATH79_MACH_ESR1750=y CONFIG_ATH79_MACH_ESR900=y +CONFIG_ATH79_MACH_EW_BALIN=y CONFIG_ATH79_MACH_EW_DORIN=y CONFIG_ATH79_MACH_F9K1115V2=y CONFIG_ATH79_MACH_FRITZ300E=y diff --git a/target/linux/ar71xx/files/arch/mips/ath79/Kconfig.openwrt
Re: [LEDE-DEV] Collecting issues on github
On 12/01/18 20:03, Ted Hess wrote: Hi folks, I would like to propose we close the issues tab on the github/openwrt/openwrt source repository as we did for the lede-project/source repo. We can continue to re-direct people to our bug-tracker for the mainline sources. The packages repo remains as it is now. /ted Hi Ted, We agreed on closing the issue tracker during the meeting at the owrt summit. feel free to close the issue tracker. John ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev