[Libreoffice-bugs] [Bug 98540] Info.plist seems to be broken in OS X
https://bugs.documentfoundation.org/show_bug.cgi?id=98540 Xisco Faulíchanged: What|Removed |Added Status|NEEDINFO|NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113156] mailing assistant menu
https://bugs.documentfoundation.org/show_bug.cgi?id=113156 Xisco Faulíchanged: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |NOTABUG --- Comment #6 from Xisco Faulí --- The last 4 steps in the wizard were removed when the it was refactored. You can find them in the mailmerge toolbar once the mailmerge is created. Closing as RESOLVED NOTABUG -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47603] EDITING: External update in CALC OLE objects needs manual update for each single object
https://bugs.documentfoundation.org/show_bug.cgi?id=47603 Xisco Faulíchanged: What|Removed |Added Status|NEEDINFO|RESOLVED CC||xiscofa...@libreoffice.org Resolution|--- |INSUFFICIENTDATA --- Comment #5 from Xisco Faulí --- Hi Rainer Bielefeld Retired, Could you please attached the document? Closing as RESOLVED INSUFFICIENTDATA for the time being -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76513] FILEOPEN: Very bad positioning of drawing objects on writer throughout the document in docx
https://bugs.documentfoundation.org/show_bug.cgi?id=76513 Xisco Faulíchanged: What|Removed |Added Status|NEEDINFO|NEW CC||xiscofa...@libreoffice.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83844] FILEOPEN: DOC - Hanging paragraph indent not imported correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=83844 Xisco Faulíchanged: What|Removed |Added Status|NEEDINFO|NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104901] Image object cumulative placement error affecting print preview/ print & cell anchor behavior with irregular row height (see comment 6)
https://bugs.documentfoundation.org/show_bug.cgi?id=104901 Xisco Faulíchanged: What|Removed |Added Status|NEEDINFO|RESOLVED CC||xiscofa...@libreoffice.org Resolution|--- |DUPLICATE --- Comment #8 from Xisco Faulí --- Closing as dupe of 98931. R. Bingham, please, try on a master build as Buovjaga said. *** This bug has been marked as a duplicate of bug 98931 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105584] [META] Calc image bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105584 Bug 105584 depends on bug 104901, which changed state. Bug 104901 Summary: Image object cumulative placement error affecting print preview/print & cell anchor behavior with irregular row height (see comment 6) https://bugs.documentfoundation.org/show_bug.cgi?id=104901 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 72120] UI: Ability to use imposition N-up / folded layout when exporting to PDF.
https://bugs.documentfoundation.org/show_bug.cgi?id=72120 Xisco Faulíchanged: What|Removed |Added Status|NEEDINFO|NEW CC||xiscofa...@libreoffice.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: xmlsecurity/inc xmlsecurity/source
xmlsecurity/inc/framework/saxeventkeeperimpl.hxx|2 - xmlsecurity/source/framework/saxeventkeeperimpl.cxx | 26 ++-- 2 files changed, 14 insertions(+), 14 deletions(-) New commits: commit 5cb225b0b3dbb55fd44899b1fb16bdcfeb866849 Author: Noel GrandinDate: Mon Jan 22 14:22:24 2018 +0200 loplugin:useuniqueptr in SAXEventKeeperImpl Change-Id: I1bb683dc8d492db73c2f2cc07c67b4dcb75bc1fb Reviewed-on: https://gerrit.libreoffice.org/48558 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/xmlsecurity/inc/framework/saxeventkeeperimpl.hxx b/xmlsecurity/inc/framework/saxeventkeeperimpl.hxx index 9b6a8d472754..4f8a06959a4c 100644 --- a/xmlsecurity/inc/framework/saxeventkeeperimpl.hxx +++ b/xmlsecurity/inc/framework/saxeventkeeperimpl.hxx @@ -96,7 +96,7 @@ private: * it has the same structure with the document which maintains those * elements physically. */ -BufferNode* m_pRootBufferNode; +std::unique_ptr m_pRootBufferNode; /* * the current active BufferNode. diff --git a/xmlsecurity/source/framework/saxeventkeeperimpl.cxx b/xmlsecurity/source/framework/saxeventkeeperimpl.cxx index 636e6e4d5436..9659f420c70a 100644 --- a/xmlsecurity/source/framework/saxeventkeeperimpl.cxx +++ b/xmlsecurity/source/framework/saxeventkeeperimpl.cxx @@ -59,10 +59,10 @@ SAXEventKeeperImpl::~SAXEventKeeperImpl() if (m_pRootBufferNode != nullptr) { m_pRootBufferNode->freeAllChildren(); -delete m_pRootBufferNode; +m_pRootBufferNode.reset(); } -m_pRootBufferNode = m_pCurrentBufferNode = m_pCurrentBlockingBufferNode = nullptr; +m_pCurrentBufferNode = m_pCurrentBlockingBufferNode = nullptr; /* * delete all unfreed ElementMarks @@ -95,7 +95,7 @@ void SAXEventKeeperImpl::setCurrentBufferNode(BufferNode* pBufferNode) { if (pBufferNode != m_pCurrentBufferNode) { -if ( m_pCurrentBufferNode == m_pRootBufferNode && +if ( m_pCurrentBufferNode == m_pRootBufferNode.get() && m_xSAXEventKeeperStatusChangeListener.is()) { m_xSAXEventKeeperStatusChangeListener->collectionStatusChanged(true); @@ -423,7 +423,7 @@ void SAXEventKeeperImpl::smashBufferNode( /* * delete the XML data */ -if (pParent == m_pRootBufferNode) +if (pParent == m_pRootBufferNode.get()) { bool bIsNotBlocking = (m_pCurrentBlockingBufferNode == nullptr); bool bIsBlockInside = false; @@ -437,7 +437,7 @@ void SAXEventKeeperImpl::smashBufferNode( if (bClearRoot) { cssu::Sequence< cssu::Reference< cssxw::XXMLElementWrapper > > -aChildElements = collectChildWorkingElement(m_pRootBufferNode); +aChildElements = collectChildWorkingElement(m_pRootBufferNode.get()); /* * the clearUselessData only clearup the content in the @@ -931,7 +931,7 @@ OUString SAL_CALL SAXEventKeeperImpl::printBufferNodeTree() + OUString::number(m_vElementMarkBuffers.size()) + "\nCurrentBufferNode: " + m_xXMLDocument->getNodeName(m_pCurrentBufferNode->getXMLElement()) -+ "\n" + printBufferNode(m_pRootBufferNode, 0); ++ "\n" + printBufferNode(m_pRootBufferNode.get(), 0); return rc; } @@ -1071,7 +1071,7 @@ void SAL_CALL SAXEventKeeperImpl::endElement( const OUString& aName ) } if ((m_pCurrentBlockingBufferNode != nullptr) || -(m_pCurrentBufferNode != m_pRootBufferNode) || +(m_pCurrentBufferNode != m_pRootBufferNode.get()) || (!m_xXMLDocument->isCurrentElementEmpty())) { if (!m_bIsForwarding) @@ -1084,14 +1084,14 @@ void SAL_CALL SAXEventKeeperImpl::endElement( const OUString& aName ) * the current buffer node is waiting for the current element, * then let it notify. */ -if (bIsCurrent && (m_pCurrentBufferNode != m_pRootBufferNode)) +if (bIsCurrent && (m_pCurrentBufferNode != m_pRootBufferNode.get())) { BufferNode* pOldCurrentBufferNode = m_pCurrentBufferNode; m_pCurrentBufferNode = const_cast (m_pCurrentBufferNode->getParent()); pOldCurrentBufferNode->setReceivedAll(); -if ((m_pCurrentBufferNode == m_pRootBufferNode) && +if ((m_pCurrentBufferNode == m_pRootBufferNode.get()) && m_xSAXEventKeeperStatusChangeListener.is()) { m_xSAXEventKeeperStatusChangeListener->collectionStatusChanged(false); @@ -1117,7 +1117,7 @@ void SAL_CALL SAXEventKeeperImpl::characters( const OUString& aChars ) } if ((m_pCurrentBlockingBufferNode != nullptr) || -(m_pCurrentBufferNode != m_pRootBufferNode)) +
[Libreoffice-bugs] [Bug 90568] Confusing behavior with Direct Formatting with copy/ paste - when overseeing that default formatting is no direct formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=90568 Xisco Faulíchanged: What|Removed |Added Status|NEEDINFO|NEW CC||xiscofa...@libreoffice.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/rtfexport/data/tdf115180.docx |binary sw/qa/extras/rtfexport/rtfexport3.cxx | 15 +++ sw/source/filter/inc/wrtswtbl.hxx |1 + sw/source/filter/ww8/rtfattributeoutput.cxx |4 +++- 4 files changed, 19 insertions(+), 1 deletion(-) New commits: commit d91236ad8fc74e1ec15c39b90660717ebab013ac Author: Mike KaganskiDate: Wed Jan 24 15:25:36 2018 +0300 tdf#115180: take table base width into account Change-Id: I4238e6c757499e289193efa3498fb1e68d5f3e9c Reviewed-on: https://gerrit.libreoffice.org/48501 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/sw/qa/extras/rtfexport/data/tdf115180.docx b/sw/qa/extras/rtfexport/data/tdf115180.docx new file mode 100644 index ..2e41c7a24a1d Binary files /dev/null and b/sw/qa/extras/rtfexport/data/tdf115180.docx differ diff --git a/sw/qa/extras/rtfexport/rtfexport3.cxx b/sw/qa/extras/rtfexport/rtfexport3.cxx index c8941ed26633..870650ab9b88 100644 --- a/sw/qa/extras/rtfexport/rtfexport3.cxx +++ b/sw/qa/extras/rtfexport/rtfexport3.cxx @@ -80,6 +80,21 @@ DECLARE_RTFEXPORT_TEST(testTdf114333, "tdf114333.rtf") CPPUNIT_ASSERT_EQUAL(sal_Int32(8498), getProperty(xTable, "Width")); } +DECLARE_RTFEXPORT_TEST(testTdf115180, "tdf115180.docx") +{ +// On export to RTF, column separator positions were written without taking base width +// into account and then arrived huge, ~64000, which resulted in wrong table and cell widths + +sal_Int32 rowWidth = parseDump("/root/page/body/tab/row/infos/bounds", "width").toInt32(); +CPPUNIT_ASSERT_EQUAL_MESSAGE("Row width", sal_Int32(9360), rowWidth); +sal_Int32 cell1Width += parseDump("/root/page/body/tab/row/cell[1]/infos/bounds", "width").toInt32(); +CPPUNIT_ASSERT_EQUAL_MESSAGE("First cell width", sal_Int32(9142), cell1Width); +sal_Int32 cell2Width += parseDump("/root/page/body/tab/row/cell[2]/infos/bounds", "width").toInt32(); +CPPUNIT_ASSERT_EQUAL_MESSAGE("First cell width", sal_Int32(218), cell2Width); +} + CPPUNIT_PLUGIN_IMPLEMENT(); /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/sw/source/filter/inc/wrtswtbl.hxx b/sw/source/filter/inc/wrtswtbl.hxx index ee1cbd771537..20b9554c582a 100644 --- a/sw/source/filter/inc/wrtswtbl.hxx +++ b/sw/source/filter/inc/wrtswtbl.hxx @@ -286,6 +286,7 @@ public: long GetAbsHeight(long nRawWidth, size_t nRow, sal_uInt16 nRowSpan) const; +double GetAbsWidthRatio() const { return m_nTabWidth == m_nBaseWidth ? 1.0 : double(m_nTabWidth) / m_nBaseWidth; } protected: long GetLineHeight( const SwTableLine *pLine ); static long GetLineHeight( const SwTableBox *pBox ); diff --git a/sw/source/filter/ww8/rtfattributeoutput.cxx b/sw/source/filter/ww8/rtfattributeoutput.cxx index 770ae936c824..8e15fe6c9aed 100644 --- a/sw/source/filter/ww8/rtfattributeoutput.cxx +++ b/sw/source/filter/ww8/rtfattributeoutput.cxx @@ -721,6 +721,7 @@ void RtfAttributeOutput::TableDefinition( } // The cell-dependent properties +const double fWidthRatio = m_pTableWrt->GetAbsWidthRatio(); const SwWriteTableRows& aRows = m_pTableWrt->GetRows(); SwWriteTableRow* pRow = aRows[pTableTextNodeInfoInner->getRow()]; SwTwips nSz = 0; @@ -740,7 +741,8 @@ void RtfAttributeOutput::TableDefinition( // value of nSz is needed. nSz += pCellFormat->GetFrameSize().GetWidth(); m_aRowDefs.append(OOO_STRING_SVTOOLS_RTF_CELLX); - m_aRowDefs.append(static_cast(pFormat->GetLRSpace().GetLeft() + nSz)); + m_aRowDefs.append(static_cast(pFormat->GetLRSpace().GetLeft() + + rtl::math::round(nSz * fWidthRatio))); } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 114795] Calc freezes on table paste.; wrong import of table from webpage
https://bugs.documentfoundation.org/show_bug.cgi?id=114795 Xisco Faulíchanged: What|Removed |Added Status|NEEDINFO|RESOLVED CC||xiscofa...@libreoffice.org Resolution|--- |DUPLICATE --- Comment #4 from Xisco Faulí --- *** This bug has been marked as a duplicate of bug 91237 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91237] CALC hangs on web table paste (intermittent)
https://bugs.documentfoundation.org/show_bug.cgi?id=91237 Xisco Faulíchanged: What|Removed |Added CC||rj.amdphr...@gmail.com --- Comment #16 from Xisco Faulí --- *** Bug 114795 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] help.git: CustomTarget_html.mk help3xsl/default.css help3xsl/online_transform.xsl
CustomTarget_html.mk |2 +- help3xsl/default.css | 18 +- help3xsl/online_transform.xsl |2 +- 3 files changed, 11 insertions(+), 11 deletions(-) New commits: commit 67a993c05d19976f5ed347b16584d29d6866a870 Author: Ilmari LauhakangasDate: Wed Jan 24 15:27:16 2018 +0200 Module names must stay uppercase due to DbPAR=MODULE Change-Id: I10cea1b204b20d482abec6a8f66d5cfee6cf6dfe Reviewed-on: https://gerrit.libreoffice.org/48509 Reviewed-by: Olivier Hallot Tested-by: Olivier Hallot diff --git a/CustomTarget_html.mk b/CustomTarget_html.mk index 0c71db255..479eab889 100644 --- a/CustomTarget_html.mk +++ b/CustomTarget_html.mk @@ -12,7 +12,7 @@ $(eval $(call gb_CustomTarget_CustomTarget,helpcontent2/help3xsl)) # HACK!! html_TREE_MODULES := sbasic scalc schart shared simpress smath swriter html_TEXT_MODULES := $(html_TREE_MODULES) sdatabase sdraw -html_BMARK_MODULES := swriter:writer scalc:calc simpress:impress sdraw:draw shared/explorer/database:base smath:math schart:chart sbasic:basic shared:shared +html_BMARK_MODULES := swriter:WRITER scalc:CALC simpress:IMPRESS sdraw:DRAW shared/explorer/database:BASE smath:MATH schart:CHART sbasic:BASIC shared:SHARED $(eval $(call gb_CustomTarget_register_targets,helpcontent2/help3xsl,\ hid2file.js \ diff --git a/help3xsl/default.css b/help3xsl/default.css index 70af31efb..9ddb07c36 100644 --- a/help3xsl/default.css +++ b/help3xsl/default.css @@ -369,63 +369,63 @@ aside input[type=checkbox]:checked ~ .contents-treeview { font-weight: bold; color: #18A303; } -#writer::before { +#WRITER::before { content: "WRITER"; display: block; font-size: 22px; font-weight: bold; color: #18A303; } -#calc::before { +#CALC::before { content: "CALC"; display: block; font-size: 22px; font-weight: bold; color: #18A303; } -#impress::before { +#IMPRESS::before { content: "IMPRESS"; display: block; font-size: 22px; font-weight: bold; color: #18A303; } -#draw::before { +#DRAW::before { content: "DRAW"; display: block; font-size: 22px; font-weight: bold; color: #18A303; } -#base::before { +#BASE::before { content: "BASE"; display: block; font-size: 22px; font-weight: bold; color: #18A303; } -#math::before { +#MATH::before { content: "MATH"; display: block; font-size: 22px; font-weight: bold; color: #18A303; } -#chart::before { +#CHART::before { content: "CHART"; display: block; font-size: 22px; font-weight: bold; color: #18A303; } -#basic::before { +#BASIC::before { content: "BASIC"; display: block; font-size: 22px; font-weight: bold; color: #18A303; } -#shared::before { +#SHARED::before { content: "GLOBAL"; display: block; font-size: 22px; diff --git a/help3xsl/online_transform.xsl b/help3xsl/online_transform.xsl index c1764e573..acdc6febb 100644 --- a/help3xsl/online_transform.xsl +++ b/help3xsl/online_transform.xsl @@ -332,7 +332,7 @@ } }); } -var modules = [ 'calc', 'writer', 'impress', 'draw', 'base', 'math', 'chart', 'basic', 'shared' ]; +var modules = [ 'CALC', 'WRITER', 'IMPRESS', 'DRAW', 'BASE', 'MATH', 'CHART', 'BASIC', 'SHARED' ]; // options for List.js http://listjs.com/ var options = { valueNames: modules, ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit da7c0245bf0fd6cca7a589f7cf7e0b39412aa577 Author: Ilmari LauhakangasDate: Wed Jan 24 15:27:16 2018 +0200 Updated core Project: help 67a993c05d19976f5ed347b16584d29d6866a870 Module names must stay uppercase due to DbPAR=MODULE Change-Id: I10cea1b204b20d482abec6a8f66d5cfee6cf6dfe Reviewed-on: https://gerrit.libreoffice.org/48509 Reviewed-by: Olivier Hallot Tested-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 94375babd75d..67a993c05d19 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 94375babd75d8b611311bab682f9017e0485d19b +Subproject commit 67a993c05d19976f5ed347b16584d29d6866a870 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 61037] VIEWING: Selection is not visible while scrolling
https://bugs.documentfoundation.org/show_bug.cgi?id=61037 Xisco Faulíchanged: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 61594] FILEOPEN:docx with multi-page floating table ( workaround from MS Office: Table Properties - set Text Wrapping to None)
https://bugs.documentfoundation.org/show_bug.cgi?id=61594 Xisco Faulíchanged: What|Removed |Added CC||vojtech.f...@marbes.cz --- Comment #29 from Xisco Faulí --- *** Bug 112544 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112544] DOCX: Incorrect layout of table in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=112544 Xisco Faulíchanged: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Xisco Faulí --- *** This bug has been marked as a duplicate of bug 61594 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104528] [META] Saved DOCX files that MS Word can't open
https://bugs.documentfoundation.org/show_bug.cgi?id=104528 Aron Budeachanged: What|Removed |Added Depends on||115212 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115212 [Bug 115212] FILESAVE DOCX Change tracking deleted TOC entries cause invalid text node error in Word -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83946] [META] Tracking changes issues
https://bugs.documentfoundation.org/show_bug.cgi?id=83946 Aron Budeachanged: What|Removed |Added Depends on||115212 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115212 [Bug 115212] FILESAVE DOCX Change tracking deleted TOC entries cause invalid text node error in Word -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115212] FILESAVE DOCX Change tracking deleted TOC entries cause invalid text node error in Word
https://bugs.documentfoundation.org/show_bug.cgi?id=115212 Aron Budeachanged: What|Removed |Added CC||ba...@caesar.elte.hu Blocks||104528, 83946 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=83946 [Bug 83946] [META] Tracking changes issues https://bugs.documentfoundation.org/show_bug.cgi?id=104528 [Bug 104528] [META] Saved DOCX files that MS Word can't open -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/core/doc/DocumentRedlineManager.cxx | 22 -- sw/source/core/inc/DocumentRedlineManager.hxx |3 +-- 2 files changed, 13 insertions(+), 12 deletions(-) New commits: commit 61e048808873c4edea983de0ab54366cd41e2082 Author: Michael StahlDate: Thu Jan 25 12:13:50 2018 +0100 sw: uninitialised DocumentRedlineManager::bHideLinineTooltips (regression from 86e3f95cff4d3dad48d64e50e0c4b05034fa7064) Change-Id: I48db6f070d7cf5ef0071952ad34822f75d472a21 diff --git a/sw/source/core/doc/DocumentRedlineManager.cxx b/sw/source/core/doc/DocumentRedlineManager.cxx index d43b5f1cb855..166152f275b7 100644 --- a/sw/source/core/doc/DocumentRedlineManager.cxx +++ b/sw/source/core/doc/DocumentRedlineManager.cxx @@ -606,14 +606,16 @@ namespace namespace sw { -DocumentRedlineManager::DocumentRedlineManager( SwDoc& i_rSwdoc ) : m_rDoc( i_rSwdoc ), - meRedlineFlags(RedlineFlags::ShowInsert | RedlineFlags::ShowDelete), - mpRedlineTable( new SwRedlineTable ), - mpExtraRedlineTable ( new SwExtraRedlineTable ), - mpAutoFormatRedlnComment( nullptr ), - mbIsRedlineMove(false), - mbReadlineChecked(false), - mnAutoFormatRedlnCommentNo( 0 ) +DocumentRedlineManager::DocumentRedlineManager(SwDoc& i_rSwdoc) +: m_rDoc(i_rSwdoc) +, meRedlineFlags(RedlineFlags::ShowInsert | RedlineFlags::ShowDelete) +, mpRedlineTable(new SwRedlineTable) +, mpExtraRedlineTable(new SwExtraRedlineTable) +, mpAutoFormatRedlnComment(nullptr) +, mbIsRedlineMove(false) +, mbReadlineChecked(false) +, mnAutoFormatRedlnCommentNo(0) +, m_bHideInlineTooltips(false) { } @@ -2719,12 +2721,12 @@ void DocumentRedlineManager::checkRedlining(RedlineFlags& _rReadlineMode) bool DocumentRedlineManager::IsHideInlineTooltips() { -return bHideInlineTooltips; +return m_bHideInlineTooltips; } void DocumentRedlineManager::SetHideInlineTooltips(bool bSet) { -bHideInlineTooltips = bSet; +m_bHideInlineTooltips = bSet; } DocumentRedlineManager::~DocumentRedlineManager() diff --git a/sw/source/core/inc/DocumentRedlineManager.hxx b/sw/source/core/inc/DocumentRedlineManager.hxx index 26c8050dbb2c..52be64fa7d28 100644 --- a/sw/source/core/inc/DocumentRedlineManager.hxx +++ b/sw/source/core/inc/DocumentRedlineManager.hxx @@ -30,8 +30,6 @@ namespace sw class DocumentRedlineManager : public IDocumentRedlineAccess { -bool bHideInlineTooltips : 1; - public: DocumentRedlineManager( SwDoc& i_rSwdoc ); @@ -144,6 +142,7 @@ private: sal_uInt16 mnAutoFormatRedlnCommentNo; /**< SeqNo for conjoining of AutoFormat-Redlines. by the UI. Managed by SwAutoFormat! */ css::uno::Sequence maRedlinePasswd; +bool m_bHideInlineTooltips : 1; }; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - configure.ac vcl/unx
configure.ac |4 - vcl/unx/gtk3_kde5/gtk3_kde5_filepicker.cxx |9 -- vcl/unx/gtk3_kde5/gtk3_kde5_filepicker.hxx |3 vcl/unx/gtk3_kde5/gtk3_kde5_filepicker_ipc.cxx | 98 +++-- vcl/unx/gtk3_kde5/gtk3_kde5_filepicker_ipc.hxx | 29 +-- vcl/unx/gtk3_kde5/gtk3_kde5_gtkinst.cxx|6 - 6 files changed, 101 insertions(+), 48 deletions(-) New commits: commit cbf0c689d41ba11f37e557c10db7976f8318d43c Author: Milian WolffDate: Wed Jan 24 11:43:20 2018 +0100 Undo "check for boost/process/child.hpp in configure.ac if --enable-gtk3-kde5" This reverts commit c7a1320593191e8359aa64d8e262948da085d358. It's no longer required since we ported away from boost.:process Change-Id: I53c5b994c3ba2801823ba0d6ab25f43223db1476 Reviewed-on: https://gerrit.libreoffice.org/48491 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/configure.ac b/configure.ac index 3de79ab4d192..2780d20f7b9b 100644 --- a/configure.ac +++ b/configure.ac @@ -8716,10 +8716,6 @@ if test "$with_system_boost" = "yes"; then [AC_MSG_ERROR(boost/shared_ptr.hpp not found. install boost)], []) AC_CHECK_HEADER(boost/spirit/include/classic_core.hpp, [], [AC_MSG_ERROR(boost/spirit/include/classic_core.hpp not found. install boost >= 1.36)], []) -if test "x$enable_gtk3_kde5" = "xyes"; then -AC_CHECK_HEADER(boost/process/child.hpp, [], - [AC_MSG_ERROR(boost/process/child.hpp not found. install boost >= 1.64)], []) -fi CXXFLAGS=$save_CXXFLAGS AC_LANG_POP([C++]) # this is in m4/ax_boost_base.m4 commit 068f244222edcc5916fe864a0265ab6ccb4e43d2 Author: Milian Wolff Date: Wed Jan 24 11:35:20 2018 +0100 gtk3_kde5: port away from boost::process While this uglifies the code, it removes a dependency on newer boost 1.64+ which ships boost::process. This helps on systems where LO is linked against system boost and an older version of boost is used. Additionally, and this is the main motivation, this makes it easier to backport these changes to 5.2, where the bundled boost is also only at 1.60. To keep the required changes at a minimum, the osl_* API for reading from/writing to the stdout/stdin of the helper process, we buffer the responses on a line-by-line basis. Note that one cannot simply reuse osl_readLine on the non-seekable oslFileHandle. Instead, we have to roll our own simplistic readLine implementation... Change-Id: I1197e38cb2416e926d8ba985accd6c10d78bcc52 Reviewed-on: https://gerrit.libreoffice.org/48490 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/vcl/unx/gtk3_kde5/gtk3_kde5_filepicker.cxx b/vcl/unx/gtk3_kde5/gtk3_kde5_filepicker.cxx index 7372d476f55e..8c983996b791 100644 --- a/vcl/unx/gtk3_kde5/gtk3_kde5_filepicker.cxx +++ b/vcl/unx/gtk3_kde5/gtk3_kde5_filepicker.cxx @@ -42,13 +42,6 @@ #include -#include - -#include -#include -#include -#include - using namespace ::com::sun::star; using namespace ::com::sun::star::ui::dialogs; using namespace ::com::sun::star::ui::dialogs::TemplateDescription; @@ -57,8 +50,6 @@ using namespace ::com::sun::star::ui::dialogs::CommonFilePickerElementIds; using namespace ::com::sun::star::lang; using namespace ::com::sun::star::beans; using namespace ::com::sun::star::uno; -namespace bp = boost::process; -namespace bf = boost::filesystem; // helper functions diff --git a/vcl/unx/gtk3_kde5/gtk3_kde5_filepicker.hxx b/vcl/unx/gtk3_kde5/gtk3_kde5_filepicker.hxx index 80261ded9f9b..740382d9ec49 100644 --- a/vcl/unx/gtk3_kde5/gtk3_kde5_filepicker.hxx +++ b/vcl/unx/gtk3_kde5/gtk3_kde5_filepicker.hxx @@ -32,9 +32,6 @@ #include -#include -#include - #include "gtk3_kde5_filepicker_ipc.hxx" #include diff --git a/vcl/unx/gtk3_kde5/gtk3_kde5_filepicker_ipc.cxx b/vcl/unx/gtk3_kde5/gtk3_kde5_filepicker_ipc.cxx index fd9c1c7b64e1..21690c5e74f8 100644 --- a/vcl/unx/gtk3_kde5/gtk3_kde5_filepicker_ipc.cxx +++ b/vcl/unx/gtk3_kde5/gtk3_kde5_filepicker_ipc.cxx @@ -26,6 +26,7 @@ #include #include +#include #include @@ -41,38 +42,33 @@ #include #include -#include -#include -#include using namespace ::com::sun::star::ui::dialogs; -namespace bp = boost::process; -namespace bf = boost::filesystem; - // helper functions namespace { -bf::path applicationDirPath() +OUString applicationDirPath() { OUString applicationFilePath; osl_getExecutableFile(); OUString applicationSystemPath; osl_getSystemPathFromFileURL(applicationFilePath.pData, ); -auto sysPath = applicationSystemPath.toUtf8(); -auto ret = bf::path(sysPath.getStr(), sysPath.getStr() + sysPath.getLength()); +const auto utf8Path = applicationSystemPath.toUtf8(); +
[Libreoffice-commits] core.git: compilerplugins/clang sdext/source
compilerplugins/clang/datamembershadow.cxx |2 -- sdext/source/presenter/PresenterPane.cxx | 11 +-- sdext/source/presenter/PresenterPane.hxx |1 - sdext/source/presenter/PresenterPaneBase.cxx |9 - sdext/source/presenter/PresenterPaneBase.hxx |2 -- sdext/source/presenter/PresenterSpritePane.cxx |5 - sdext/source/presenter/PresenterSpritePane.hxx |2 -- 7 files changed, 9 insertions(+), 23 deletions(-) New commits: commit 390fad39a8f945c848ff998d9f75720318781123 Author: Noel GrandinDate: Thu Jan 25 08:53:14 2018 +0200 loplugin:datamembershadow in PresenterPane the subclass field is just a copy of the parent field, so drop the subclass, and consequently simply the CreateCanvases method, we don't need to pass the parameter down, can just access the parent field. Change-Id: I3be448a06b32d01cdda4fc36b78cafb4488e2913 Reviewed-on: https://gerrit.libreoffice.org/48553 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/compilerplugins/clang/datamembershadow.cxx b/compilerplugins/clang/datamembershadow.cxx index 54e671daffa1..e89a44214339 100644 --- a/compilerplugins/clang/datamembershadow.cxx +++ b/compilerplugins/clang/datamembershadow.cxx @@ -80,8 +80,6 @@ bool DataMemberShadow::VisitFieldDecl(FieldDecl const * fieldDecl) return true; if (loplugin::isSamePathname(aFileName, SRCDIR "/sd/source/ui/view/viewoverlaymanager.cxx")) return true; -if (loplugin::isSamePathname(aFileName, SRCDIR "/sdext/source/presenter/PresenterSpritePane.hxx")) -return true; if (loplugin::isSamePathname(aFileName, SRCDIR "/store/source/stortree.hxx") || loplugin::isSamePathname(aFileName, SRCDIR "/store/source/stordata.hxx")) return true; diff --git a/sdext/source/presenter/PresenterPane.cxx b/sdext/source/presenter/PresenterPane.cxx index e806c7e58a51..e539d98b4373 100644 --- a/sdext/source/presenter/PresenterPane.cxx +++ b/sdext/source/presenter/PresenterPane.cxx @@ -128,27 +128,26 @@ void SAL_CALL PresenterPane::windowPaint (const awt::PaintEvent& rEvent) void PresenterPane::CreateCanvases ( -const Reference& rxParentWindow, const Reference& rxParentCanvas) { if ( ! mxPresenterHelper.is()) return; -if ( ! rxParentWindow.is()) +if ( ! mxParentWindow.is()) return; if ( ! rxParentCanvas.is()) return; mxBorderCanvas = mxPresenterHelper->createSharedCanvas( rxParentCanvas, -rxParentWindow, +mxParentWindow, Reference(rxParentCanvas, UNO_QUERY), -rxParentWindow, +mxParentWindow, mxBorderWindow); mxContentCanvas = mxPresenterHelper->createSharedCanvas( rxParentCanvas, -rxParentWindow, +mxParentWindow, Reference(rxParentCanvas, UNO_QUERY), -rxParentWindow, +mxParentWindow, mxContentWindow); PaintBorder(mxBorderWindow->getPosSize()); diff --git a/sdext/source/presenter/PresenterPane.hxx b/sdext/source/presenter/PresenterPane.hxx index dc12aa920abc..681245389be9 100644 --- a/sdext/source/presenter/PresenterPane.hxx +++ b/sdext/source/presenter/PresenterPane.hxx @@ -76,7 +76,6 @@ private: css::awt::Rectangle maBoundingBox; virtual void CreateCanvases ( -const css::uno::Reference& rxParentWindow, const css::uno::Reference& rxParentCanvas) override; void Invalidate ( diff --git a/sdext/source/presenter/PresenterPaneBase.cxx b/sdext/source/presenter/PresenterPaneBase.cxx index 4f8dc23e2573..f6174652b103 100644 --- a/sdext/source/presenter/PresenterPaneBase.cxx +++ b/sdext/source/presenter/PresenterPaneBase.cxx @@ -197,7 +197,7 @@ void SAL_CALL PresenterPaneBase::initialize (const Sequence& rArguments) 5); } -CreateWindows(mxParentWindow, bIsWindowVisibleOnCreation); +CreateWindows(bIsWindowVisibleOnCreation); if (mxBorderWindow.is()) { @@ -205,7 +205,7 @@ void SAL_CALL PresenterPaneBase::initialize (const Sequence& rArguments) mxBorderWindow->addPaintListener(this); } -CreateCanvases(mxParentWindow, xParentCanvas); +CreateCanvases(xParentCanvas); // Raise new windows. ToTop(); @@ -265,14 +265,13 @@ void SAL_CALL PresenterPaneBase::disposing (const lang::EventObject& rEvent) void PresenterPaneBase::CreateWindows ( -const Reference& rxParentWindow, const bool bIsWindowVisibleOnCreation) { -if (mxPresenterHelper.is() && rxParentWindow.is()) +if (mxPresenterHelper.is() && mxParentWindow.is()) { mxBorderWindow = mxPresenterHelper->createWindow( -rxParentWindow, +mxParentWindow, false, bIsWindowVisibleOnCreation, false, diff
[Libreoffice-bugs] [Bug 68576] Pre-installed User-defined Dictionaries Can be neither Modified nor Deleted
https://bugs.documentfoundation.org/show_bug.cgi?id=68576 Harald Koesterchanged: What|Removed |Added Blocks||108728 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108728 [Bug 108728] [META] Dictionaries bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108728] [META] Dictionaries bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108728 Harald Koesterchanged: What|Removed |Added Depends on||68576 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=68576 [Bug 68576] Pre-installed User-defined Dictionaries Can be neither Modified nor Deleted -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109178] [META] Cell names bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109178 Bug 109178 depends on bug 108989, which changed state. Bug 108989 Summary: Add contextual UNO commands for name ranges and data validity to context menu https://bugs.documentfoundation.org/show_bug.cgi?id=108989 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108988] [META] Validity-related bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108988 Bug 108988 depends on bug 108989, which changed state. Bug 108989 Summary: Add contextual UNO commands for name ranges and data validity to context menu https://bugs.documentfoundation.org/show_bug.cgi?id=108989 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86899] [META] Requests for the addition of UNO commands
https://bugs.documentfoundation.org/show_bug.cgi?id=86899 Bug 86899 depends on bug 108989, which changed state. Bug 108989 Summary: Add contextual UNO commands for name ranges and data validity to context menu https://bugs.documentfoundation.org/show_bug.cgi?id=108989 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86349] [META] Context menu bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=86349 Bug 86349 depends on bug 108989, which changed state. Bug 108989 Summary: Add contextual UNO commands for name ranges and data validity to context menu https://bugs.documentfoundation.org/show_bug.cgi?id=108989 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: officecfg/registry sc/inc sc/sdi sc/source sc/uiconfig
officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu |5 + sc/inc/document.hxx |7 ++ sc/inc/sc.hrc |3 - sc/sdi/cellsh.sdi |1 sc/sdi/scalc.sdi | 18 ++ sc/source/core/data/documen3.cxx | 26 ++ sc/source/ui/view/cellsh.cxx | 13 + sc/source/ui/view/cellsh1.cxx |1 sc/uiconfig/scalc/popupmenu/cell.xml |1 9 files changed, 74 insertions(+), 1 deletion(-) New commits: commit a626e249033fb9a7ac117e28f3152cedf98b61fc Author: Gulsah KoseDate: Tue Jan 16 01:30:04 2018 +0300 [Pardus] tdf#108989 Add contextual manage names command. If cursor in a named range .uno:DefineCurrentName command appears on context menu. Opens manage names dialog. This patch is sponsored by ULAKBIM/Pardus project. Change-Id: I730fd427fa3d6f5c92563282ff8ca3c0e668eddd Signed-off-by: Gulsah Kose Reviewed-on: https://gerrit.libreoffice.org/47925 Tested-by: Jenkins diff --git a/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu b/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu index f87cc3f47f35..979f4a176698 100644 --- a/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu +++ b/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu @@ -1289,6 +1289,11 @@ 1 + + + ~Manage Names... + + ~Insert Named Range or Expression... diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx index c1c628fb451f..10b2bd45213f 100644 --- a/sc/inc/document.hxx +++ b/sc/inc/document.hxx @@ -252,6 +252,12 @@ enum CommentCaptionState MIXED // There are comments in shown and hidden. }; +enum RangeNameScope +{ +GLOBAL,// A range name can be defined +SHEET // with two scope on Manage Names dialog. +}; + struct ScDocStat { OUString aDocName; @@ -606,6 +612,7 @@ public: SC_DLLPUBLIC ScRangeName* GetRangeName() const; void SetRangeName(SCTAB nTab, ScRangeName* pNew); void SetRangeName( ScRangeName* pNewRangeName ); +bool IsAddressInRangeName( RangeNameScope eScope, ScAddress& rAddress); /** Find a named expression / range name in either global or a local scope. @param nTab diff --git a/sc/inc/sc.hrc b/sc/inc/sc.hrc index b20f0680711f..5c75ae6c8c45 100644 --- a/sc/inc/sc.hrc +++ b/sc/inc/sc.hrc @@ -301,7 +301,8 @@ #define FID_INS_COLUMNS_AFTER (INSERT_MENU_START + 21) #define FID_INS_ROWS_BEFORE (INSERT_MENU_START + 22) #define FID_INS_COLUMNS_BEFORE (INSERT_MENU_START + 23) -#define INSERT_MENU_END (INSERT_MENU_START + 24) +#define FID_DEFINE_CURRENT_NAME (INSERT_MENU_START + 24) +#define INSERT_MENU_END (INSERT_MENU_START + 25) #define FORMAT_MENU_START (INSERT_MENU_END) #define FID_CELL_FORMAT (FORMAT_MENU_START) diff --git a/sc/sdi/cellsh.sdi b/sc/sdi/cellsh.sdi index b21769d8d258..4fc0a44f1da0 100644 --- a/sc/sdi/cellsh.sdi +++ b/sc/sdi/cellsh.sdi @@ -21,6 +21,7 @@ interface CellSelection { // slots which are disabled in the DrawShell { FID_DEFINE_NAME [ ExecMethod = ExecuteEdit; StateMethod = GetState; ] +FID_DEFINE_CURRENT_NAME [ ExecMethod = ExecuteEdit; StateMethod = GetState; ] FID_ADD_NAME[ ExecMethod = ExecuteEdit; StateMethod = GetState; ] SID_DEFINE_COLROWNAMERANGES [ ExecMethod = ExecuteEdit; StateMethod = GetState; ] SID_OPENDLG_SOLVE [ ExecMethod = Execute; StateMethod = GetState; ] diff --git a/sc/sdi/scalc.sdi b/sc/sdi/scalc.sdi index 956bacaae8e3..0925e0483865 100644 --- a/sc/sdi/scalc.sdi +++ b/sc/sdi/scalc.sdi @@ -1184,6 +1184,24 @@ SfxVoidItem DefineName FID_DEFINE_NAME ] +SfxVoidItem DefineCurrentName FID_DEFINE_CURRENT_NAME +(SfxStringItem Name FID_DEFINE_CURRENT_NAME,SfxStringItem Symbol FN_PARAM_1,SfxStringItem Options FN_PARAM_2) +[ +AutoUpdate = FALSE, +FastCall = FALSE, +ReadOnlyDoc = TRUE, +Toggle = FALSE, +Container = FALSE, +RecordAbsolute = FALSE, +RecordPerSet; + +AccelConfig = TRUE, +MenuConfig = TRUE, +ToolBoxConfig = TRUE, +GroupId = SfxGroupId::Insert; +] + + SfxVoidItem DefinePrintArea SID_DEFINE_PRINTAREA () [ diff --git a/sc/source/core/data/documen3.cxx b/sc/source/core/data/documen3.cxx index a018a065b1d2..f7f8687ca4b2 100644 --- a/sc/source/core/data/documen3.cxx +++ b/sc/source/core/data/documen3.cxx @@ -208,6
[Libreoffice-bugs] [Bug 115221] PRINTING: CRASH immediately after choosing comment (+doc) printing in the print dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=115221 Xisco Faulíchanged: What|Removed |Added Keywords||bibisected, bisected, ||regression Priority|medium |highest CC||noelgran...@gmail.com Crash report or|d8229188-fe3d-4f87-8295-168 |["SwViewShell::GetPostItMgr crash signature|695dc4f5c |()"] Severity|normal |critical --- Comment #3 from Xisco Faulí --- Regression introduced by: author Noel Grandin 2017-10-04 13:30:11 +0200 committer Noel Grandin 2017-10-05 13:49:22 +0200 commit cc483d0470dbf0d01e4da818b148ff0b851c5187 (patch) tree8775e63c99cca6d0d44c0f2820d859691edb4cfa parent 74977861a63c920f9b49e90087cac9a841392729 (diff) tdf#112292 - fix memory leak and use more auto ref counting in sw this bug was introduced in commit a754294ac7a902fe96fbbd6b8b6824a360d6b248 use rtl::Reference in SwDocFac instead of manual acquire/release fix it by using automatic ref-counting (i.e. rtl::Reference) everywhere. Note that the logic in SwViewShell::~SwViewShell is somewhat interesting. >From my reading of it, it was previously potentially calling getIDocumentLayoutAccess on an SwDoc that had just been deleted. So if there is a problem with this commit I would look there first. Bisected with: bibisect-linux64-6.0 Adding Cc: to Noel Grandin -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115206] UI - Native Finder FileOpen dialog within LO has been replaced with something hideous and pixellated
https://bugs.documentfoundation.org/show_bug.cgi?id=115206 --- Comment #12 from Heiko Tietze--- Tried with the official Vanilla version and got the inbuilt dialogs. But after cleaning the user folder everything was fine. Don't remember if I changed the configuration before. Building master at the moment, will report later. The patch https://gerrit.libreoffice.org/#/c/46546/ (bug 114484) just hides access to the checkbox at the UI. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115221] PRINTING: CRASH immediately after choosing comment (+doc) printing in the print dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=115221 Xisco Faulíchanged: What|Removed |Added CC||xiscofa...@libreoffice.org --- Comment #2 from Xisco Faulí --- Created attachment 139357 --> https://bugs.documentfoundation.org/attachment.cgi?id=139357=edit gdb backtrace -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115206] UI - Native Finder FileOpen dialog within LO has been replaced with something hideous and pixellated
https://bugs.documentfoundation.org/show_bug.cgi?id=115206 --- Comment #11 from Alex Thurgood--- OK, so SafeMode with Version: 6.1.0.0.alpha0+ Build ID: 44e9bbc29cc37d2bac089b8f051478f62f7d5d31 CPU threads: 4; OS: Mac OS X 10.13.3; UI render: default; Locale: fr-FR (fr_FR.UTF-8); Calc: group threaded shows the correct Finder dialog, which means that my LO local profile has indeed been corrupted, yet I don't ever recall activating the Native Dialog switch. @Jay : could the recent removal of the option have caused this ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115206] UI - Native Finder FileOpen dialog within LO has been replaced with something hideous and pixellated
https://bugs.documentfoundation.org/show_bug.cgi?id=115206 --- Comment #10 from Alex Thurgood--- (In reply to Yousuf Philips (jay) from comment #8) > Seems like an issue with the user profile having the LO internal file dialog > enabled. The enabling/disabling of the internal file dialog was removed in > bug 114484, but you can still see its value in Tools ▸ Options ▸ LibreOffice > ▸ Advanced ▸ Expert configuration ▸ org.openoffice.Office.Common.Misc ▸ > UseSystemFileDialog. > > Alex please try with a fresh user profile. Hmm, my master build instdir/LO.app always uses a fresh profile and I saw the problem there first. Let me try with LODev (installed on my local disk) in SafeMode. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: svl/source
svl/source/config/cjkoptions.cxx | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) New commits: commit ec4de8ff110d6064303f4a1027e4d55c29c4db54 Author: Julien NabetDate: Thu Jan 25 09:00:02 2018 +0100 Simplify logic in cjkoptions Following https://cgit.freedesktop.org/libreoffice/core/commit/?id=6a579702b1128372aa30c86156996e57ba73b2c8 Change-Id: I5e2528bc69065260dfce7ac8c29ba4aa76905bbe Reviewed-on: https://gerrit.libreoffice.org/48554 Reviewed-by: Noel Grandin Tested-by: Julien Nabet Reviewed-by: Julien Nabet diff --git a/svl/source/config/cjkoptions.cxx b/svl/source/config/cjkoptions.cxx index 58c9e0090626..a0af655e8950 100644 --- a/svl/source/config/cjkoptions.cxx +++ b/svl/source/config/cjkoptions.cxx @@ -116,15 +116,15 @@ SvtCJKOptions_Impl::SvtCJKOptions_Impl() : voidSvtCJKOptions_Impl::SetAll(bool bSet) { if ( -!(!bROCJKFont && -!bROVerticalText && -!bROAsianTypography && -!bROJapaneseFind && -!bRORuby && -!bROChangeCaseMap&& -!bRODoubleLines && -!bROEmphasisMarks&& -!bROVerticalCallOut) +bROCJKFont || +bROVerticalText || +bROAsianTypography || +bROJapaneseFind || +bRORuby || +bROChangeCaseMap|| +bRODoubleLines || +bROEmphasisMarks|| +bROVerticalCallOut ) return; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened
https://bugs.documentfoundation.org/show_bug.cgi?id=103571 --- Comment #41 from Alex Thurgood--- (In reply to Telesto from comment #39) > Argh.. I probably found the cause. The dock size slider in System > Preferences -> Dock is set halfway by default. However, the slider range is > totally wrong. The dock size only changes between 0-40%. Setting the slider > to 50% will cause a mismatch, triggering NSApplication notifications... Yep. Confirming with Version: 6.1.0.0.alpha0+ Build ID: 44e9bbc29cc37d2bac089b8f051478f62f7d5d31 CPU threads: 4; OS: Mac OS X 10.13.2; UI render: default; Locale: fr-FR (fr_FR.UTF-8); Calc: group threaded I've managed to freeze LO completely just by opening up 20 new Writer documents and then reducing one window, after setting the Dock to 50% with the slider. I didn't need to send LO to sleep. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: fpicker/source
fpicker/source/office/iodlg.cxx |4 1 file changed, 4 insertions(+) New commits: commit 9711a8a35796d0d4ab4b69204bd4484686bf0707 Author: Pranav KantDate: Thu Jan 25 15:52:52 2018 +0530 lokdialog: Disable filepicker for LOK We don't want people to browser their jails in the filepicker dialog. Change-Id: I2fdd3d948cc1f193098492d1a310424ac2d49317 diff --git a/fpicker/source/office/iodlg.cxx b/fpicker/source/office/iodlg.cxx index 333c384734f1..d40f93214411 100644 --- a/fpicker/source/office/iodlg.cxx +++ b/fpicker/source/office/iodlg.cxx @@ -69,6 +69,7 @@ #include #include +#include #include #include @@ -1797,6 +1798,9 @@ void SvtFileDialog::EnableControl( Control* _pControl, bool _bEnable ) short SvtFileDialog::PrepareExecute() { +if (comphelper::LibreOfficeKit::isActive()) +return 0; + OUString aEnvValue; if ( getEnvironmentValue( "WorkDirMustContainRemovableMedia", aEnvValue ) && aEnvValue == "1" ) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 107134] Filter navigator can not read operators.
https://bugs.documentfoundation.org/show_bug.cgi?id=107134 Julien Nabetchanged: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #12 from Julien Nabet --- On pc Debian x86-64 with master sources updated yesterday, I could reproduce most of this. The only thing I don't reproduce is when I open filter form navigator and close it, the filter is still ok. However, if I open the filter form navigator, I confirm ">" doesn't appear and obviously if I click apply, LO considers like there was an "=". -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115190] Template manager shows extension on OOXML templates
https://bugs.documentfoundation.org/show_bug.cgi?id=115190 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEW CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #3 from Xisco Faulí --- (In reply to Heiko Tietze from comment #2) > Sounds like a bug. Moving to NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115178] Crash in: swlo.dll
https://bugs.documentfoundation.org/show_bug.cgi?id=115178 Xisco Faulíchanged: What|Removed |Added CC||xiscofa...@libreoffice.org --- Comment #1 from Xisco Faulí --- Do you reproduce it every time ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 115190] Template manager shows extension on OOXML templates
https://bugs.documentfoundation.org/show_bug.cgi?id=115190 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEW CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #3 from Xisco Faulí --- (In reply to Heiko Tietze from comment #2) > Sounds like a bug. Moving to NEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 115219] 5.4.3 fails to install
https://bugs.documentfoundation.org/show_bug.cgi?id=115219 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #1 from Xisco Faulí --- Thank you for reporting the bug. it seems you're using an old version of LibreOffice. Could you please try to reproduce it with the latest version of LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ ? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the latest version. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - sfx2/source vcl/source
sfx2/source/dialog/basedlgs.cxx |5 ++--- vcl/source/window/dialog.cxx|5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) New commits: commit 3b22b8077d744f39ca5c202570d21f2f32f02b45 Author: Pranav KantDate: Thu Jan 25 14:34:19 2018 +0530 lokdialog: Fix incorrect dialog sizes sent to client GetSizePixel triggers pending resize handler and gives more correct sizes than GetOptimalSize(). Some of the dialog with inconsistencies in sizes like EditStyle, Manage Changes, etc. are fixed with this patch. Change-Id: I0661b7d2e98233edf0cd2c9c525b271d0724da08 (cherry picked from commit 668deca97d8dd049bb17b6d8b73c4ea73f7b8b9c) Reviewed-on: https://gerrit.libreoffice.org/48560 Reviewed-by: Jan Holesovsky Tested-by: Jan Holesovsky diff --git a/sfx2/source/dialog/basedlgs.cxx b/sfx2/source/dialog/basedlgs.cxx index 729e1fbbdb97..94b4225ddf7f 100644 --- a/sfx2/source/dialog/basedlgs.cxx +++ b/sfx2/source/dialog/basedlgs.cxx @@ -199,10 +199,9 @@ void SfxModalDialog::StateChanged( StateChangedType nType ) // SfxModalDialog even though they are modeless, i.e., their Execute method // isn't called. SetLOKNotifier(SfxViewShell::Current()); -const Size aSize = GetOptimalSize(); std::vector aItems; aItems.emplace_back("type", "dialog"); -aItems.emplace_back("size", aSize.toString()); +aItems.emplace_back("size", GetSizePixel().toString()); if (!GetText().isEmpty()) aItems.emplace_back("title", GetText().toUtf8()); SfxViewShell::Current()->notifyWindow(GetLOKWindowId(), "created", aItems); @@ -265,7 +264,7 @@ void SfxModelessDialog::StateChanged( StateChangedType nStateChange ) SetLOKNotifier(pViewShell); std::vector aItems; aItems.emplace_back("type", "dialog"); -aItems.emplace_back("size", GetOptimalSize().toString()); +aItems.emplace_back("size", GetSizePixel().toString()); if (!GetText().isEmpty()) aItems.emplace_back("title", GetText().toUtf8()); pViewShell->notifyWindow(GetLOKWindowId(), "created", aItems); diff --git a/vcl/source/window/dialog.cxx b/vcl/source/window/dialog.cxx index d2d20d1ef7cd..f9dbaa534f5f 100644 --- a/vcl/source/window/dialog.cxx +++ b/vcl/source/window/dialog.cxx @@ -895,10 +895,9 @@ bool Dialog::ImplStartExecuteModal() { if(const vcl::ILibreOfficeKitNotifier* pNotifier = GetLOKNotifier()) { -const Size aSize = GetOptimalSize(); std::vector aItems; aItems.emplace_back("type", "dialog"); -aItems.emplace_back("size", aSize.toString()); +aItems.emplace_back("size", GetSizePixel().toString()); if (!GetText().isEmpty()) aItems.emplace_back("title", GetText().toUtf8()); pNotifier->notifyWindow(GetLOKWindowId(), "created", aItems); @@ -1284,7 +1283,7 @@ void Dialog::Resize() if (const vcl::ILibreOfficeKitNotifier* pNotifier = GetLOKNotifier()) { std::vector aItems; -aItems.emplace_back("size", GetOptimalSize().toString()); +aItems.emplace_back("size", GetSizePixel().toString()); pNotifier->notifyWindow(GetLOKWindowId(), "size_changed", aItems); } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 115226] Update bundled Amiri to 0.111
https://bugs.documentfoundation.org/show_bug.cgi?id=115226 Xisco Faulíchanged: What|Removed |Added CC||khaledho...@eglug.org, ||philip...@hotmail.com, ||xiscofa...@libreoffice.org --- Comment #1 from Xisco Faulí --- Link -> https://github.com/alif-type/amiri/releases/tag/0.111 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114920] Calc Cell contents at an angle do not appear during printing
https://bugs.documentfoundation.org/show_bug.cgi?id=114920 Xisco Faulíchanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Xisco Faulí --- *** This bug has been marked as a duplicate of bug 115169 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114824] Export to PDF and Printing: Borders of Merged Cells Flow to Page Footer
https://bugs.documentfoundation.org/show_bug.cgi?id=114824 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from Xisco Faulí --- Moving to NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113532] Bundle and use open source Arabic fonts by default
https://bugs.documentfoundation.org/show_bug.cgi?id=113532 Volgachanged: What|Removed |Added Blocks||115226 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115226 [Bug 115226] Update bundled Amiri to 0.111 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115226] Update bundled Amiri to 0.111
https://bugs.documentfoundation.org/show_bug.cgi?id=115226 Volgachanged: What|Removed |Added Depends on||113532 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=113532 [Bug 113532] Bundle and use open source Arabic fonts by default -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115226] New: Update bundled Amiri to 0.111
https://bugs.documentfoundation.org/show_bug.cgi?id=115226 Bug ID: 115226 Summary: Update bundled Amiri to 0.111 Product: LibreOffice Version: 6.0.0.2 rc Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: shanshandehongx...@outlook.com Description: The Amiri font released version 0.111 after bug 113532, so LibreOffice can update bundled Amiri font. Steps to Reproduce: - Actual Results: - Expected Results: - Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (Android 5.1.1; Mobile; rv:58.0) Gecko/58.0 Firefox/58.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sfx2/source vcl/source
sfx2/source/dialog/basedlgs.cxx |5 ++--- vcl/source/window/dialog.cxx|5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) New commits: commit 668deca97d8dd049bb17b6d8b73c4ea73f7b8b9c Author: Pranav KantDate: Thu Jan 25 14:34:19 2018 +0530 lokdialog: Fix incorrect dialog sizes sent to client GetSizePixel triggers pending resize handler and gives more correct sizes than GetOptimalSize(). Some of the dialog with inconsistencies in sizes like EditStyle, Manage Changes, etc. are fixed with this patch. Change-Id: I0661b7d2e98233edf0cd2c9c525b271d0724da08 diff --git a/sfx2/source/dialog/basedlgs.cxx b/sfx2/source/dialog/basedlgs.cxx index 9ed41424e133..02533e4fb22e 100644 --- a/sfx2/source/dialog/basedlgs.cxx +++ b/sfx2/source/dialog/basedlgs.cxx @@ -193,10 +193,9 @@ void SfxModalDialog::StateChanged( StateChangedType nType ) // SfxModalDialog even though they are modeless, i.e., their Execute method // isn't called. SetLOKNotifier(SfxViewShell::Current()); -const Size aSize = GetOptimalSize(); std::vector aItems; aItems.emplace_back("type", "dialog"); -aItems.emplace_back("size", aSize.toString()); +aItems.emplace_back("size", GetSizePixel().toString()); if (!GetText().isEmpty()) aItems.emplace_back("title", GetText().toUtf8()); SfxViewShell::Current()->notifyWindow(GetLOKWindowId(), "created", aItems); @@ -259,7 +258,7 @@ void SfxModelessDialog::StateChanged( StateChangedType nStateChange ) SetLOKNotifier(pViewShell); std::vector aItems; aItems.emplace_back("type", "dialog"); -aItems.emplace_back("size", GetOptimalSize().toString()); +aItems.emplace_back("size", GetSizePixel().toString()); if (!GetText().isEmpty()) aItems.emplace_back("title", GetText().toUtf8()); pViewShell->notifyWindow(GetLOKWindowId(), "created", aItems); diff --git a/vcl/source/window/dialog.cxx b/vcl/source/window/dialog.cxx index c61a41be32f1..272da360b503 100644 --- a/vcl/source/window/dialog.cxx +++ b/vcl/source/window/dialog.cxx @@ -886,10 +886,9 @@ bool Dialog::ImplStartExecuteModal() { if(const vcl::ILibreOfficeKitNotifier* pNotifier = GetLOKNotifier()) { -const Size aSize = GetOptimalSize(); std::vector aItems; aItems.emplace_back("type", "dialog"); -aItems.emplace_back("size", aSize.toString()); +aItems.emplace_back("size", GetSizePixel().toString()); if (!GetText().isEmpty()) aItems.emplace_back("title", GetText().toUtf8()); pNotifier->notifyWindow(GetLOKWindowId(), "created", aItems); @@ -1256,7 +1255,7 @@ void Dialog::Resize() if (const vcl::ILibreOfficeKitNotifier* pNotifier = GetLOKNotifier()) { std::vector aItems; -aItems.emplace_back("size", GetOptimalSize().toString()); +aItems.emplace_back("size", GetSizePixel().toString()); pNotifier->notifyWindow(GetLOKWindowId(), "size_changed", aItems); } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 115187] when importing a collada model, no errors occur but also nothing appears in the presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=115187 --- Comment #4 from thomas.a.kaed...@gmail.com --- no I read that version 6 drops support for 3d models completely. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115225] Base cannot open Access mdb file
https://bugs.documentfoundation.org/show_bug.cgi?id=115225 --- Comment #1 from luca m.--- Created attachment 139356 --> https://bugs.documentfoundation.org/attachment.cgi?id=139356=edit MDB with problem -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115225] Base cannot open Access mdb file
https://bugs.documentfoundation.org/show_bug.cgi?id=115225 --- Comment #2 from luca m.--- I've attached the MDB for testing purpose. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115225] New: Base cannot open Access mdb file
https://bugs.documentfoundation.org/show_bug.cgi?id=115225 Bug ID: 115225 Summary: Base cannot open Access mdb file Product: LibreOffice Version: 5.4.3.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: luc...@gmail.com Description: With Libreoffice Base 5.3.3, I cannot open the mdb (attached). OpenOffice 3.4 can manage it successfully. Steps to Reproduce: 1. Open mdb 2. doesn't work Actual Results: doesn't work Expected Results: should open as in OpenOffice 3.4 Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: xmloff/source
xmloff/source/transform/TransformerBase.cxx | 52 xmloff/source/transform/TransformerBase.hxx | 19 +- 2 files changed, 34 insertions(+), 37 deletions(-) New commits: commit f1a68998e11291d117140ea07f1da84b4309f2d4 Author: Noel GrandinDate: Wed Jan 17 17:20:35 2018 +0200 loplugin:useuniqueptr in XMLTransformerBase and flatten some members, no need to allocate separate object Change-Id: I9f6b7ee89af935608424a88d9343d8bbebaaada1 Reviewed-on: https://gerrit.libreoffice.org/48513 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/xmloff/source/transform/TransformerBase.cxx b/xmloff/source/transform/TransformerBase.cxx index 34864459a114..fd0f3ea903e6 100644 --- a/xmloff/source/transform/TransformerBase.cxx +++ b/xmloff/source/transform/TransformerBase.cxx @@ -175,9 +175,8 @@ XMLTransformerBase::XMLTransformerBase( XMLTransformerActionInit *pInit, ::xmloff::token::XMLTokenEnum *pTKMapInit ) throw () : m_pNamespaceMap( new SvXMLNamespaceMap ), -m_pReplaceNamespaceMap( new SvXMLNamespaceMap ), -m_pElemActions( new XMLTransformerActions( pInit ) ), -m_pTokenMap( new XMLTransformerTokenMap( pTKMapInit ) ) +m_ElemActions( pInit ), +m_TokenMap( pTKMapInit ) { GetNamespaceMap().Add( GetXMLToken(XML_NP_XLINK), GetXMLToken(XML_N_XLINK), XML_NAMESPACE_XLINK ); GetNamespaceMap().Add( GetXMLToken(XML_NP_DC), GetXMLToken(XML_N_DC), XML_NAMESPACE_DC ); @@ -190,10 +189,6 @@ XMLTransformerBase::XMLTransformerBase( XMLTransformerActionInit *pInit, XMLTransformerBase::~XMLTransformerBase() throw () { -delete m_pNamespaceMap; -delete m_pReplaceNamespaceMap; -delete m_pElemActions; -delete m_pTokenMap; } void SAL_CALL XMLTransformerBase::startDocument() @@ -209,7 +204,7 @@ void SAL_CALL XMLTransformerBase::endDocument() void SAL_CALL XMLTransformerBase::startElement( const OUString& rName, const Reference< XAttributeList >& rAttrList ) { -SvXMLNamespaceMap *pRewindMap = nullptr; +std::unique_ptr pRewindMap; // Process namespace attributes. This must happen before creating the // context, because namespace declaration apply to the element name itself. @@ -225,8 +220,8 @@ void SAL_CALL XMLTransformerBase::startElement( const OUString& rName, { if( !pRewindMap ) { -pRewindMap = m_pNamespaceMap; -m_pNamespaceMap = new SvXMLNamespaceMap( *m_pNamespaceMap ); +pRewindMap = std::move(m_pNamespaceMap); +m_pNamespaceMap.reset( new SvXMLNamespaceMap( *pRewindMap ) ); } const OUString& rAttrValue = xAttrList->getValueByIndex( i ); @@ -247,7 +242,7 @@ void SAL_CALL XMLTransformerBase::startElement( const OUString& rName, if( XML_NAMESPACE_UNKNOWN == nKey ) nKey = m_pNamespaceMap->Add( aPrefix, rAttrValue ); -const OUString& rRepName = m_pReplaceNamespaceMap->GetNameByKey( nKey ); +const OUString& rRepName = m_vReplaceNamespaceMap.GetNameByKey( nKey ); if( !rRepName.isEmpty() ) { if( !pMutableAttrList ) @@ -269,9 +264,9 @@ void SAL_CALL XMLTransformerBase::startElement( const OUString& rName, // If there are contexts already, call a CreateChildContext at the topmost // context. Otherwise, create a default context. ::rtl::Reference < XMLTransformerContext > xContext; -if( !m_pContexts.empty() ) +if( !m_vContexts.empty() ) { -xContext = m_pContexts.back()->CreateChildContext( nPrefix, +xContext = m_vContexts.back()->CreateChildContext( nPrefix, aLocalName, rName, xAttrList ); @@ -287,10 +282,10 @@ void SAL_CALL XMLTransformerBase::startElement( const OUString& rName, // Remember old namespace map. if( pRewindMap ) -xContext->PutRewindMap( pRewindMap ); +xContext->PutRewindMap( pRewindMap.release() ); // Push context on stack. -m_pContexts.push_back( xContext ); +m_vContexts.push_back( xContext ); // Call a startElement at the new context. xContext->StartElement( xAttrList ); @@ -302,10 +297,10 @@ rName #endif ) { -if( !m_pContexts.empty() ) +if( !m_vContexts.empty() ) { // Get topmost context -::rtl::Reference< XMLTransformerContext > xContext = m_pContexts.back(); +::rtl::Reference< XMLTransformerContext > xContext = m_vContexts.back(); #if OSL_DEBUG_LEVEL > 0 OSL_ENSURE( xContext->GetQName() == rName, @@ -316,7 +311,7 @@ rName
[Libreoffice-bugs] [Bug 114951] Writer loses my dictionary
https://bugs.documentfoundation.org/show_bug.cgi?id=114951 Xisco Faulíchanged: What|Removed |Added CC||xiscofa...@libreoffice.org --- Comment #7 from Xisco Faulí --- I can't reproduce it in Versió: 5.4.4.2 ID de la construcció: 1:5.4.4~rc2-0ubuntu0.17.04.1~lo1 Fils de CPU: 4; SO: Linux 4.10; Renderitzador de la IU: per defecte; VCL: gtk3; Configuració local: ca-ES (ca_ES.UTF-8); Calc: grou (In reply to J22Gim from comment #6) > Regarding the file: why would a 2-lines-of-text ODT file weight 1.1MB? Does > it include the dictionaries? Could you explain how you created it ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115170] configure arbitrary sockets for loolwsd including unix-domain sockets
https://bugs.documentfoundation.org/show_bug.cgi?id=115170 Michael Meekschanged: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #2 from Michael Meeks --- AF_UNIX is a chunk of work - but it is configurable between IPv4 and IPv6 - cf. the config file ;-) I believe our internal 9981 socket is purely local. It should be easy enough to change: /// Create the externally listening public socket std::shared_ptr findServerPort(int port) ... std::shared_ptr socket = getServerSocket( ServerSocket::Type::Public, port, WebServerPoll, factory); to pass ServerSocket::Type::Local instead - in the case that we don't want to listen publicly there. Should be an easy enough config option to add - go for it ;-) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115187] when importing a collada model, no errors occur but also nothing appears in the presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=115187 --- Comment #3 from Xisco Faulí--- (In reply to thomas.a.kaeding from comment #2) > The .dae files I tried were COLLADA.dae and duck.dae, both of which can be > found here: > > https://github.com/assimp/assimp/tree/master/test/models/Collada Did you try with LibreOffice 6.0 RC 2? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108471] In a Form Table Control the Default time is not working in Date/Time ( time) fields.
https://bugs.documentfoundation.org/show_bug.cgi?id=108471 Julien Nabetchanged: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #5 from Julien Nabet --- On pc Debian x86-64 with master sources updated yesterday, I could reproduce this. Just for my information, where do you put default time, date or other? In table design, default values are empty and I don't find other places. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105257] Wayland: Popup menus are misplaced when two monitors are not combined exactly side by side
https://bugs.documentfoundation.org/show_bug.cgi?id=105257 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #11 from Xisco Faulí --- Could you please try to reproduce it with a master build from http://dev-builds.libreoffice.org/daily/master/ ? You can install it alongside the standard version. I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the master build -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114226] Bugs related to Windows Defender Security Centre - Controlled Folder Access (LIBREOFFICE INSTALLATION FAILS - multiple versions) (LO CALC 5.4.3 'Save' /'Save As' does n
https://bugs.documentfoundation.org/show_bug.cgi?id=114226 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||xiscofa...@libreoffice.org Resolution|--- |NOTABUG --- Comment #2 from Xisco Faulí --- (In reply to Buovjaga from comment #1) > So as this is about something that is out of our control, is your proposal > to include the file and folder path in the error messages? > > Naturally the ideal solution would be to say "Hey, Windows Defender is > blocking the install, do something about it", but I don't know if we can > detect it. i don't think we can detect such a thing... NOTABUG to me... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115089] when adding glue point to a shape in LO draw, the glue points are not displayed
https://bugs.documentfoundation.org/show_bug.cgi?id=115089 --- Comment #5 from Alex Thurgood--- (In reply to Alex Thurgood from comment #4) > So, I'm guessing it was either : > > > commit bf151f0716910b56e3538579f4af7ede8f51bbcf > > > or > > > commit 4173798ef73d3fc7da8c5b8fa575a36f05cd6f83 > > or a combination of both... OK, forget that, I see that 113594 has a backport for 5.4... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115089] when adding glue point to a shape in LO draw, the glue points are not displayed
https://bugs.documentfoundation.org/show_bug.cgi?id=115089 --- Comment #4 from Alex Thurgood--- So, I'm guessing it was either : commit bf151f0716910b56e3538579f4af7ede8f51bbcf or commit 4173798ef73d3fc7da8c5b8fa575a36f05cd6f83 or a combination of both... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106340] Buttons overlap other buttons when assigning Format options in Find & Replace dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=106340 Xisco Faulíchanged: What|Removed |Added Keywords||bibisected, bisected CC||akshaydeepi...@gmail.com --- Comment #4 from Xisco Faulí --- Regression introduced by: author Akshay Deep 2016-03-08 19:54:57 +0530 committer Samuel Mehrbrodt 2016-04-04 08:51:17 + commit beeef93480fae65840646e4e36aa888efe92579a (patch) tree7bd736c58b22f84429828e32870d669cd6ea91e1 parent 0085eb42fdb7cceece11004841c50f3008c9e120 (diff) tdf#98417, tdf#98539: DIALOG: Improvements to the Find & Replace dialog. Added Find Previous Button. Replaced backward checkbox with 'Replace Backward' from other options. Modified Dialog Layout as per the attachment in bug report. Removed vertical spacing in parent_container_box to reduce height of the dialog. Removed InfoBox from ReplaceAll functionality in writer, shifted it to SearchLabel. Attribute labels only show up when attribues are used in search, else they remain hidden. Bisected with: bibisect-linux-64-5.2 Adding Cc: to Akshay Deep -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114757] Poor gluepoint handling
https://bugs.documentfoundation.org/show_bug.cgi?id=114757 Julien Nabetchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||serval2...@yahoo.fr Resolution|--- |DUPLICATE --- Comment #1 from Julien Nabet --- *** This bug has been marked as a duplicate of bug 113594 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115098] Easily reorder table columns
https://bugs.documentfoundation.org/show_bug.cgi?id=115098 --- Comment #2 from Heiko Tietze--- Would discuss this idea together with other aspects of table manipulation in bug 113603, if you agree. In particular the attachment to comment 3 shows a nice approach. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 115098] Easily reorder table columns
https://bugs.documentfoundation.org/show_bug.cgi?id=115098 --- Comment #2 from Heiko Tietze--- Would discuss this idea together with other aspects of table manipulation in bug 113603, if you agree. In particular the attachment to comment 3 shows a nice approach. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 115089] when adding glue point to a shape in LO draw, the glue points are not displayed
https://bugs.documentfoundation.org/show_bug.cgi?id=115089 Julien Nabetchanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Julien Nabet --- I think it's a dup If you still reproduce this with next release 5.4.5 or with next 6.0, don't hesitate to reopen this tracker. *** This bug has been marked as a duplicate of bug 113594 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115089] when adding glue point to a shape in LO draw, the glue points are not displayed
https://bugs.documentfoundation.org/show_bug.cgi?id=115089 --- Comment #2 from Alex Thurgood--- Confirming that the problem has disappeared in my master build Version: 6.1.0.0.alpha0+ Build ID: 44e9bbc29cc37d2bac089b8f051478f62f7d5d31 CPU threads: 4; OS: Mac OS X 10.13.3; UI render: default; Locale: fr-FR (fr_FR.UTF-8); Calc: group threaded but I haven't yet managed to identify a commit which could be used for a backport to 5.4. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115089] when adding glue point to a shape in LO draw, the glue points are not displayed
https://bugs.documentfoundation.org/show_bug.cgi?id=115089 Alex Thurgoodchanged: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115089] when adding glue point to a shape in LO draw, the glue points are not displayed
https://bugs.documentfoundation.org/show_bug.cgi?id=115089 Alex Thurgoodchanged: What|Removed |Added OS|Linux (All) |All -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115220] Can't edit / move / delete / direction change glue points any more in DRAW
https://bugs.documentfoundation.org/show_bug.cgi?id=115220 Julien Nabetchanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #9 from Julien Nabet --- *** This bug has been marked as a duplicate of bug 113594 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115222] Crash in the File menu mouse moving
https://bugs.documentfoundation.org/show_bug.cgi?id=115222 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #2 from Xisco Faulí --- Hi Andras, Does it fix the problem -> https://bugs.documentfoundation.org/show_bug.cgi?id=108619#c16 ? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the question has been answered -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115221] PRINTING: CRASH immediately after choosing comment (+doc) printing in the print dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=115221 Mike Kaganskichanged: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Mike Kaganski --- Reproduced with Version: 6.0.0.2 (x64) Build ID: 06b618bb6f431d27fd2def25aa19c833e29b61cd CPU threads: 4; OS: Windows 10.0; UI render: default; Locale: ru-RU (ru_RU); Calc: and with Version: 6.1.0.0.alpha0+ (x64) Build ID: de1bb0878fc7d7eb6071ec94d770712648013075 CPU threads: 4; OS: Windows 10.0; UI render: default; Locale: ru-RU (ru_RU); Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115220] Can't edit / move / delete / direction change glue points any more in DRAW
https://bugs.documentfoundation.org/show_bug.cgi?id=115220 --- Comment #8 from Alex Thurgood--- (In reply to Julien Nabet from comment #7) > On pc Debian x86-64 with LO Debian package 5.4.4.2, I could reproduce both > bugs. > With master sources updated yesterday, I don't reproduce any of them. Indeed, this is working again in Version: 6.1.0.0.alpha0+ Build ID: 44e9bbc29cc37d2bac089b8f051478f62f7d5d31 CPU threads: 4; OS: Mac OS X 10.13.3; UI render: default; Locale: fr-FR (fr_FR.UTF-8); Calc: group threaded but what about a backport to 5.4 ? I haven't managed to identify a commit yet that fixed this problem. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108473] Inserting into a Form Table Control Date/Time (Time) field gets stuck
https://bugs.documentfoundation.org/show_bug.cgi?id=108473 Julien Nabetchanged: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #4 from Julien Nabet --- With LO Debian package 5.4.4.2 or with master sources updated yesterday, I don't reproduce this. I opened the form, put "4:00" on fourth line of the first table on Date column, then could move the cursor with keys. I noticed that "4:00" was automatically replaced by "04:00" and the ID automatically filled. Buovjaga: do you still reproduce this with a recent LO version? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106781] Addition of a style-focused formatting toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=106781 --- Comment #36 from Xisco Faulí--- A polite ping to Yousuf Philips: is this bug fixed? if so, could you please close it as RESOLVED FIXED ? Thanks -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 106781] Addition of a style-focused formatting toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=106781 --- Comment #36 from Xisco Faulí--- A polite ping to Yousuf Philips: is this bug fixed? if so, could you please close it as RESOLVED FIXED ? Thanks -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 115222] Crash in the File menu mouse moving
https://bugs.documentfoundation.org/show_bug.cgi?id=115222 --- Comment #1 from Mike Kaganski--- A dupe of bug 108619? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115068] FILESAVE EXPORT as HTML : bad positioned images in HTML export
https://bugs.documentfoundation.org/show_bug.cgi?id=115068 Marianchanged: What|Removed |Added Version|unspecified |5.1.6.2 release --- Comment #17 from Marian --- Tests done with LO 5.1 (from Ubuntu 16.04) and 6.0. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115205] FILESAVE HTMLEXPORT images are overlapped when spreadsheet exported as HTML
https://bugs.documentfoundation.org/show_bug.cgi?id=115205 Marianchanged: What|Removed |Added Version|unspecified |5.1.6.2 release --- Comment #2 from Marian --- Tests done with LO 5.1 (from Ubuntu 16.04) and 6.0. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114033] Crash in: libgobject-2.0.so.0.5000.3
https://bugs.documentfoundation.org/show_bug.cgi?id=114033 Julien Nabetchanged: What|Removed |Added CC||r...@debian.org, ||serval2...@yahoo.fr --- Comment #8 from Julien Nabet --- (In reply to Howard Johnson from comment #5) > @Alex, It's a downloaded version. Debian repository is at 1:5.2.7-1 > (5.2.7). This is about the third or forth version I think I have > downloaded. I think it might be the pb. Linux versions on TDF are more for package maintainers. I use Debian testing and LO package is 5.4.4.2 Rene: thought you might be interested in this one. Indeed, when you download a package from tdf, is there a lot of work (I think about dependencies) to upload it on SID (or perhaps in experimental first?) or do you think it's safe to use TDF packages directly on one's distrib? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")
https://bugs.documentfoundation.org/show_bug.cgi?id=112153 --- Comment #32 from Tor Lillqvist--- @Jonathan: if you want 5.4.4, 5.3.7, or some other already released version, but with just this patch additionally applied, then you have to build a such yourself, or ask/pay somebody else to do it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115223] FILESAVE: colours lost in HTML save
https://bugs.documentfoundation.org/show_bug.cgi?id=115223 Marianchanged: What|Removed |Added Version|unspecified |5.1.6.2 release --- Comment #1 from Marian --- Tests done with LO 5.1 (from Ubuntu 16.04) and 6.0. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115224] FILESAVE HTMLEXPORT shapes badly positioned after saved as HTML
https://bugs.documentfoundation.org/show_bug.cgi?id=115224 Marianchanged: What|Removed |Added Summary|FILESAVE HTMLEXPORT shapes |FILESAVE HTMLEXPORT shapes |badly positioned after savd |badly positioned after |as HTML |saved as HTML -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112452] Undo delete of cell comment looses comment position
https://bugs.documentfoundation.org/show_bug.cgi?id=112452 Xisco Faulíchanged: What|Removed |Added Status|ASSIGNED|NEW Assignee|dennisfrancis...@gmail.com |libreoffice-b...@lists.free ||desktop.org --- Comment #3 from Xisco Faulí --- Dear Dennis Francis, This bug has been in ASSIGNED status for more than 3 months without any activity. Resetting it to NEW. Please assigned it back to yourself if you're still working on this. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115224] FILESAVE HTMLEXPORT shapes badly positioned after savd as HTML
https://bugs.documentfoundation.org/show_bug.cgi?id=115224 Marianchanged: What|Removed |Added Version|unspecified |5.1.6.2 release -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115224] New: FILESAVE HTMLEXPORT shapes badly positioned after savd as HTML
https://bugs.documentfoundation.org/show_bug.cgi?id=115224 Bug ID: 115224 Summary: FILESAVE HTMLEXPORT shapes badly positioned after savd as HTML Product: LibreOffice Version: unspecified Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: m@oodrive.fr Created attachment 139355 --> https://bugs.documentfoundation.org/attachment.cgi?id=139355=edit spreadsheet containing variois shapes After saving the attached spreadsheet in HTML (or simply previewing it in the browser) the shapes are thrown in the oddest places! Tested with LO version 6 and 5.1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115221] PRINTING: CRASH immediately after choosing comment (+doc) printing in the print dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=115221 Tobias Burnuschanged: What|Removed |Added Crash report or||d8229188-fe3d-4f87-8295-168 crash signature||695dc4f5c -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: compilerplugins/clang editeng/source include/editeng
compilerplugins/clang/datamembershadow.cxx |5 + editeng/source/uno/unotext.cxx |2 +- include/editeng/unotext.hxx|2 +- 3 files changed, 3 insertions(+), 6 deletions(-) New commits: commit fbe2d12f19dac29107e89ce4b3153fa6922633e5 Author: Noel GrandinDate: Wed Jan 24 16:39:11 2018 +0200 loplugin:datamembershadow in SvxUnoTextRangeBase make the superclass member private Change-Id: I665d87bfdfc3d7804cd4cac6108f9bc65b9ca2b5 Reviewed-on: https://gerrit.libreoffice.org/48552 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/compilerplugins/clang/datamembershadow.cxx b/compilerplugins/clang/datamembershadow.cxx index 520e1195f0ca..54e671daffa1 100644 --- a/compilerplugins/clang/datamembershadow.cxx +++ b/compilerplugins/clang/datamembershadow.cxx @@ -19,6 +19,7 @@ * Check for data member being shadowed. * * @TODO check for any members in superclass hierarchy with duplicate names, + * regardless of their visibility, * more specific names will make the code easier to read */ namespace @@ -84,12 +85,8 @@ bool DataMemberShadow::VisitFieldDecl(FieldDecl const * fieldDecl) if (loplugin::isSamePathname(aFileName, SRCDIR "/store/source/stortree.hxx") || loplugin::isSamePathname(aFileName, SRCDIR "/store/source/stordata.hxx")) return true; -if (loplugin::isSamePathname(aFileName, SRCDIR "/svx/source/inc/cell.hxx")) -return true; if (loplugin::isSamePathname(aFileName, SRCDIR "/sw/source/uibase/inc/dbtree.hxx")) return true; -if (loplugin::isSamePathname(aFileName, SRCDIR "/vcl/unx/generic/print/genpspgraphics.cxx")) -return true; const CXXRecordDecl* parentCXXRecordDecl = dyn_cast(fieldDecl->getDeclContext()); if (!parentCXXRecordDecl) { diff --git a/editeng/source/uno/unotext.cxx b/editeng/source/uno/unotext.cxx index 7859b4f1185e..6b6127c92ec8 100644 --- a/editeng/source/uno/unotext.cxx +++ b/editeng/source/uno/unotext.cxx @@ -208,7 +208,7 @@ void CheckSelection( struct ESelection& rSel, SvxEditSource *pEdit ) throw() UNO3_GETIMPLEMENTATION_IMPL( SvxUnoTextRangeBase ); SvxUnoTextRangeBase::SvxUnoTextRangeBase(const SvxItemPropertySet* _pSet) -: mpEditSource(nullptr) , mpPropSet(_pSet) +: mpPropSet(_pSet), mpEditSource(nullptr) { } diff --git a/include/editeng/unotext.hxx b/include/editeng/unotext.hxx index 4ee3bf4fc11d..4b4eb127aae0 100644 --- a/include/editeng/unotext.hxx +++ b/include/editeng/unotext.hxx @@ -250,11 +250,11 @@ class EDITENG_DLLPUBLIC SvxUnoTextRangeBase : public css::text::XTextRange, { friend class SvxUnoTextRangeEnumeration; friend class ::accessibility::AccessibleEditableTextPara; +const SvxItemPropertySet* mpPropSet; protected: SvxEditSource* mpEditSource; ESelection maSelection; -const SvxItemPropertySet* mpPropSet; /// @throws css::beans::UnknownPropertyException /// @throws css::beans::PropertyVetoException ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 115206] UI - Native Finder FileOpen dialog within LO has been replaced with something hideous and pixellated
https://bugs.documentfoundation.org/show_bug.cgi?id=115206 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||tietze.he...@gmail.com Ever confirmed|0 |1 --- Comment #9 from Xisco Faulí --- (In reply to Yousuf Philips (jay) from comment #8) > Seems like an issue with the user profile having the LO internal file dialog > enabled. The enabling/disabling of the internal file dialog was removed in > bug 114484, but you can still see its value in Tools ▸ Options ▸ LibreOffice > ▸ Advanced ▸ Expert configuration ▸ org.openoffice.Office.Common.Misc ▸ > UseSystemFileDialog. > > Alex please try with a fresh user profile. Putting to NEEDINFO OTOH, Heike, can you test it on your mac? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115165] no calculation with data=>subtotal
https://bugs.documentfoundation.org/show_bug.cgi?id=115165 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME --- Comment #3 from Xisco Faulí --- (In reply to Xavier Van Wijmeersch from comment #2) > @raal > > thanks, will search for info on the subject data=>subtotals > can be closed as WFM, and yes i will first search for info before reporting > a bug > > Best regards Let's put it to WFM then. Ideally, the best would be to search for info first. Anyway, you both are doing a great deal of good to the project :-) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115220] Can't edit / move / delete / direction change glue points any more in DRAW
https://bugs.documentfoundation.org/show_bug.cgi?id=115220 --- Comment #7 from Julien Nabet--- On pc Debian x86-64 with LO Debian package 5.4.4.2, I could reproduce both bugs. With master sources updated yesterday, I don't reproduce any of them. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115205] FILESAVE HTMLEXPORT images are overlapped when spreadsheet exported as HTML
https://bugs.documentfoundation.org/show_bug.cgi?id=115205 Marianchanged: What|Removed |Added Status|RESOLVED|NEW Resolution|INVALID |--- Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115223] New: FILESAVE: colours lost in HTML save
https://bugs.documentfoundation.org/show_bug.cgi?id=115223 Bug ID: 115223 Summary: FILESAVE: colours lost in HTML save Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Keywords: dataLoss Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: m@oodrive.fr Created attachment 139354 --> https://bugs.documentfoundation.org/attachment.cgi?id=139354=edit spreadsheet with cells coloured background The background colour of the cells is lost during a save in HTML format. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115220] Can't edit / move / delete / direction change glue points any more in DRAW
https://bugs.documentfoundation.org/show_bug.cgi?id=115220 Alex Thurgoodchanged: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115220] Can't edit / move / delete / direction change glue points any more in DRAW
https://bugs.documentfoundation.org/show_bug.cgi?id=115220 --- Comment #6 from Alex Thurgood--- Actually, proably better to check between 5.3.2 and 5.4.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: desktop/source sfx2/source
desktop/source/lib/init.cxx |1 + sfx2/source/control/unoctitm.cxx |3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) New commits: commit dd42329b4a204d9d9dcac102095f144ea3eca791 Author: Jan HolesovskyDate: Wed Jan 24 20:07:40 2018 +0100 lok: Send the enabled / disabled state of .uno:TransformDialog. Change-Id: If2d8e0da6c289deb65dc8a6b38a21dfd5bbfc1bd Reviewed-on: https://gerrit.libreoffice.org/48534 Tested-by: Jenkins Reviewed-by: Jan Holesovsky diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index 381e727ee954..dfff8646fef6 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -1762,6 +1762,7 @@ static void doc_iniUnoCommands () OUString(".uno:OutlineBullet"), OUString(".uno:InsertIndexesEntry"), OUString(".uno:DocumentRepair"), +OUString(".uno:TransformDialog"), OUString(".uno:InsertPageHeader"), OUString(".uno:InsertPageFooter") }; diff --git a/sfx2/source/control/unoctitm.cxx b/sfx2/source/control/unoctitm.cxx index 2193914465f2..894b88f79dbd 100644 --- a/sfx2/source/control/unoctitm.cxx +++ b/sfx2/source/control/unoctitm.cxx @@ -1092,7 +1092,8 @@ static void InterceptLOKStateChangeEvent(const SfxViewFrame* pViewFrame, const c aEvent.FeatureURL.Path == "FontDialog" || aEvent.FeatureURL.Path == "ParagraphDialog" || aEvent.FeatureURL.Path == "OutlineBullet" || - aEvent.FeatureURL.Path == "InsertIndexesEntry") + aEvent.FeatureURL.Path == "InsertIndexesEntry" || + aEvent.FeatureURL.Path == "TransformDialog") { aBuffer.append(aEvent.IsEnabled ? OUString("enabled") : OUString("disabled")); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits