[Libreoffice-commits] core.git: sd/source
sd/source/ui/func/fuarea.cxx |2 +- sd/source/ui/func/fuline.cxx |2 +- sd/source/ui/func/futransf.cxx |5 +++-- 3 files changed, 5 insertions(+), 4 deletions(-) New commits: commit 7616b3dd942efad8fa20b30ab3a0833a21501ffd Author: Jan HolesovskyDate: Wed Jan 24 19:13:46 2018 +0100 lokdialog: Parents for the Impress async dialogs. After 072e3ce1cfea5bb61cc5f3001c288df6deb45613, the dialogs must have parents, otherwise the LOK notification does not work for them. Change-Id: I46774d05a7d47adaaa0e06104541e47daf68f3db Reviewed-on: https://gerrit.libreoffice.org/48533 Tested-by: Jenkins Reviewed-by: Jan Holesovsky diff --git a/sd/source/ui/func/fuarea.cxx b/sd/source/ui/func/fuarea.cxx index 042de7aa239f..29d8cb5311a3 100644 --- a/sd/source/ui/func/fuarea.cxx +++ b/sd/source/ui/func/fuarea.cxx @@ -65,7 +65,7 @@ void FuArea::DoExecute( SfxRequest& rReq ) mpView->GetAttributes( aNewAttr ); SvxAbstractDialogFactory* pFact = SvxAbstractDialogFactory::Create(); -VclPtr pDlg(pFact ? pFact->CreateSvxAreaTabDialog(nullptr, , mpDoc, true) : nullptr); +VclPtr pDlg(pFact ? pFact->CreateSvxAreaTabDialog(mpViewShell->GetActiveWindow(), , mpDoc, true) : nullptr); if (!pDlg) { mpViewShell->Cancel(); diff --git a/sd/source/ui/func/fuline.cxx b/sd/source/ui/func/fuline.cxx index 9fa501ce52c4..d4511fdcc610 100644 --- a/sd/source/ui/func/fuline.cxx +++ b/sd/source/ui/func/fuline.cxx @@ -79,7 +79,7 @@ void FuLine::DoExecute( SfxRequest& rReq ) bool bHasMarked = mpView->AreObjectsMarked(); SvxAbstractDialogFactory* pFact = SvxAbstractDialogFactory::Create(); -VclPtr pDlg(pFact ? pFact->CreateSvxLineTabDialog(nullptr,pNewAttr.get(),mpDoc,pObj,bHasMarked) : nullptr); +VclPtr pDlg(pFact ? pFact->CreateSvxLineTabDialog(mpViewShell->GetActiveWindow(), pNewAttr.get(), mpDoc, pObj, bHasMarked) : nullptr); if (!pDlg) { mpViewShell->Cancel(); diff --git a/sd/source/ui/func/futransf.cxx b/sd/source/ui/func/futransf.cxx index 9dddef1dde4b..ef2894cc37f5 100644 --- a/sd/source/ui/func/futransf.cxx +++ b/sd/source/ui/func/futransf.cxx @@ -27,6 +27,7 @@ #include #include #include +#include #include #include #include @@ -101,7 +102,7 @@ void FuTransform::DoExecute( SfxRequest& rReq ) if (!pFact) return; -pDlg.reset(pFact->CreateCaptionDialog(nullptr, mpView)); +pDlg.reset(pFact->CreateCaptionDialog(mpViewShell->GetActiveWindow(), mpView)); const sal_uInt16* pRange = pDlg->GetInputRanges( *aNewAttr.GetPool() ); SfxItemSet aCombSet( *aNewAttr.GetPool(), pRange ); @@ -115,7 +116,7 @@ void FuTransform::DoExecute( SfxRequest& rReq ) if (!pFact) return; -pDlg.reset(pFact->CreateSvxTransformTabDialog(nullptr, , mpView)); + pDlg.reset(pFact->CreateSvxTransformTabDialog(mpViewShell->GetActiveWindow(), , mpView)); } if (!pDlg) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 115220] Can't edit / move / delete / direction change glue points any more in DRAW
https://bugs.documentfoundation.org/show_bug.cgi?id=115220 --- Comment #5 from Alex Thurgood--- Bibisect range probably between 5.3.4 and 5.4.0 release. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: desktop/source framework/source
desktop/source/lib/init.cxx | 17 ++ framework/source/accelerators/globalacceleratorconfiguration.cxx |3 + 2 files changed, 20 insertions(+) New commits: commit 5fc484a786a04d65811518b7effab66925dcec72 Author: Michael MeeksDate: Fri Dec 1 21:56:55 2017 + Initialize more for sharing during pre-init. Change-Id: I12b90504ec9161318683ebad8f8e4dd1e614da89 Reviewed-on: https://gerrit.libreoffice.org/46120 Reviewed-by: Jan Holesovsky Tested-by: Jan Holesovsky Reviewed-on: https://gerrit.libreoffice.org/48510 diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index 569960e82f02..381e727ee954 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -55,6 +55,7 @@ #include #include #include +#include #include #include @@ -84,6 +85,7 @@ #include #include #include +#include #include #include #include @@ -95,6 +97,7 @@ #include #include #include +#include #include @@ -3665,6 +3668,20 @@ static void preloadData() xThesaurus->queryMeanings("forcefed", it, aNone); } std::cerr << "\n"; + +css::uno::Reference< css::ui::XAcceleratorConfiguration > xGlobalCfg; +xGlobalCfg = css::ui::GlobalAcceleratorConfiguration::create( +comphelper::getProcessComponentContext()); +xGlobalCfg->getAllKeyEvents(); + +std::cerr << "Preload icons\n"; +ImageTree = ImageTree::get(); +images.getImageUrl("forcefed.png", "style", "FO_oo"); + +std::cerr << "Preload languages\n"; +// force load language singleton +SvtLanguageTable::HasLanguageType(LANGUAGE_SYSTEM); +LanguageTag::isValidBcp47("foo", nullptr); } static int lo_initialize(LibreOfficeKit* pThis, const char* pAppPath, const char* pUserProfileUrl) diff --git a/framework/source/accelerators/globalacceleratorconfiguration.cxx b/framework/source/accelerators/globalacceleratorconfiguration.cxx index 36691cb3f2d7..2a05887f7c98 100644 --- a/framework/source/accelerators/globalacceleratorconfiguration.cxx +++ b/framework/source/accelerators/globalacceleratorconfiguration.cxx @@ -19,6 +19,7 @@ #include #include +#include #include #include @@ -81,6 +82,8 @@ private: GlobalAcceleratorConfiguration::GlobalAcceleratorConfiguration(const css::uno::Reference< css::uno::XComponentContext >& xContext) : GlobalAcceleratorConfiguration_BASE(xContext) { +// force keyboard string registration. +KeyMapping::get(); } void GlobalAcceleratorConfiguration::fillCache() ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: desktop/source
desktop/source/lib/init.cxx | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) New commits: commit fa72a3379d3641565ddab561d32d0a7d03b83665 Author: Jan HolesovskyDate: Wed Jan 24 13:32:24 2018 +0100 lok: Preload thesauri too. Change-Id: If2bfd3a024fc61900d3c12ff976df136d4e61bf6 Reviewed-on: https://gerrit.libreoffice.org/48502 Reviewed-by: Jan Holesovsky Tested-by: Jan Holesovsky diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index 338d11221566..569960e82f02 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -3637,13 +3637,13 @@ static void lo_status_indicator_callback(void *data, comphelper::LibreOfficeKit: /// Used only by LibreOfficeKit when used by Online to pre-initialize static void preloadData() { -// First: sit down and read all dictionaries: yum. +// preload all available dictionaries css::uno::Reference xLngSvcMgr = css::linguistic2::LinguServiceManager::create(comphelper::getProcessComponentContext()); css::uno::Reference xSpellChecker(xLngSvcMgr->getSpellChecker()); -css::uno::Reference xLocales(xSpellChecker, css::uno::UNO_QUERY_THROW); -uno::Sequence< css::lang::Locale > aLocales = xLocales->getLocales(); +css::uno::Reference xSpellLocales(xSpellChecker, css::uno::UNO_QUERY_THROW); +uno::Sequence< css::lang::Locale > aLocales = xSpellLocales->getLocales(); std::cerr << "Preloading dictionaries: "; for (auto : aLocales) { @@ -3652,6 +3652,19 @@ static void preloadData() xSpellChecker->isValid("forcefed", it, aNone); } std::cerr << "\n"; + +// preload all available thesauri +css::uno::Reference xThesaurus(xLngSvcMgr->getThesaurus()); +css::uno::Reference xThesLocales(xSpellChecker, css::uno::UNO_QUERY_THROW); +aLocales = xThesLocales->getLocales(); +std::cerr << "Preloading thesauri: "; +for (auto : aLocales) +{ +std::cerr << it.Language << "_" << it.Country << " "; +css::beans::PropertyValues aNone; +xThesaurus->queryMeanings("forcefed", it, aNone); +} +std::cerr << "\n"; } static int lo_initialize(LibreOfficeKit* pThis, const char* pAppPath, const char* pUserProfileUrl) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: docker/l10n-docker-nightly.sh
docker/l10n-docker-nightly.sh |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 5448c0a7bf6699475fbf08466bf159b37ec73c17 Author: Andras TimarDate: Thu Jan 25 10:06:10 2018 +0100 Online docker: we need galaxy theme too as fallback Change-Id: Iaa91f6c81b40ee3702e864dc283fe30317a80a85 diff --git a/docker/l10n-docker-nightly.sh b/docker/l10n-docker-nightly.sh index b6629cc3..dbfbf526 100755 --- a/docker/l10n-docker-nightly.sh +++ b/docker/l10n-docker-nightly.sh @@ -90,7 +90,7 @@ cat > libreoffice/autogen.input << EOF --with-linker-hash-style=both --with-system-dicts --with-system-zlib ---with-theme=tango +--with-theme=tango galaxy --without-branding --without-help --without-java ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sd/source
sd/source/ui/func/futransf.cxx | 32 +++- 1 file changed, 7 insertions(+), 25 deletions(-) New commits: commit 9f05a323d50c6750e25f2ca69f758ec7fc4313bc Author: Jan HolesovskyDate: Wed Jan 24 13:19:41 2018 +0100 sd: Kill an own scope guard impl. and use comphelper::ScopeGuard instead. Change-Id: I769c1c6c9d10081b706d0e1e0fbd7ad373a6e04f Reviewed-on: https://gerrit.libreoffice.org/48499 Reviewed-by: Jan Holesovsky Tested-by: Jan Holesovsky diff --git a/sd/source/ui/func/futransf.cxx b/sd/source/ui/func/futransf.cxx index f62c9788da8a..9dddef1dde4b 100644 --- a/sd/source/ui/func/futransf.cxx +++ b/sd/source/ui/func/futransf.cxx @@ -19,6 +19,7 @@ #include +#include #include #include #include @@ -61,34 +62,15 @@ void setUndo(::sd::View* pView, const SfxItemSet* pArgs) pView->EndUndo(); } -class ScopeCleanup -{ -ViewShell* mpViewShell; -public: -ScopeCleanup(ViewShell* pViewShell) : mpViewShell(pViewShell) -{ -} - -~ScopeCleanup() -{ -if (mpViewShell) -{ -mpViewShell->Invalidate(SID_RULER_OBJECT); -mpViewShell->Cancel(); -} -} - -void ignore() -{ -mpViewShell = nullptr; -} -}; - } void FuTransform::DoExecute( SfxRequest& rReq ) { -ScopeCleanup aCleanup(mpViewShell); +comphelper::ScopeGuard guard([&]() { +// cleanup when leaving +mpViewShell->Invalidate(SID_RULER_OBJECT); +mpViewShell->Cancel(); +}); if (!mpView->AreObjectsMarked()) return; @@ -141,7 +123,7 @@ void FuTransform::DoExecute( SfxRequest& rReq ) std::shared_ptr pRequest(new SfxRequest(rReq)); rReq.Ignore(); // the 'old' request is not relevant any more -aCleanup.ignore(); // the lambda does it +guard.dismiss(); // we'll invalidate explicitly after the dialog ends pDlg->StartExecuteAsync([=](sal_Int32 nResult){ if (nResult == RET_OK) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/uiview/viewling.cxx | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) New commits: commit 3a9c80c4cdcd4387ff07ddd4347973aaa7df9860 Author: Jan HolesovskyDate: Wed Jan 24 12:47:20 2018 +0100 lokdialog: Convert the Tools -> Thesaurus... to async exec. Change-Id: Iee25e3fa970e5e28a14a95cfc8804ce944d4f762 Reviewed-on: https://gerrit.libreoffice.org/48497 Reviewed-by: Jan Holesovsky Tested-by: Jan Holesovsky diff --git a/sw/source/uibase/uiview/viewling.cxx b/sw/source/uibase/uiview/viewling.cxx index 70dbdb94fa2e..cb7f8b11c546 100644 --- a/sw/source/uibase/uiview/viewling.cxx +++ b/sw/source/uibase/uiview/viewling.cxx @@ -28,6 +28,7 @@ #include #include #include +#include #include #include #include @@ -546,8 +547,9 @@ void SwView::StartThesaurus() } SwViewOption* pVOpt = const_cast (m_pWrtShell->GetViewOptions()); -bool bOldIdle = pVOpt->IsIdle(); +const bool bOldIdle = pVOpt->IsIdle(); pVOpt->SetIdle( false ); +comphelper::ScopeGuard guard([&]() { pVOpt->SetIdle(bOldIdle); }); // restore when leaving scope // get initial LookUp text const bool bSelection = static_cast (m_pWrtShell)->HasSelection(); @@ -559,20 +561,27 @@ void SwView::StartThesaurus() SpellError( eLang ); else { -ScopedVclPtr pDlg; +VclPtr pDlg; // create dialog { //Scope for SwWait-Object SwWait aWait( *GetDocShell(), true ); // load library with dialog only on demand ... SvxAbstractDialogFactory* pFact = SvxAbstractDialogFactory::Create(); -pDlg.disposeAndReset(pFact->CreateThesaurusDialog( (), xThes, aTmp, eLang )); +pDlg.reset(pFact->CreateThesaurusDialog((), xThes, aTmp, eLang)); } -if ( pDlg->Execute()== RET_OK ) -InsertThesaurusSynonym( pDlg->GetWord(), aTmp, bSelection ); -} +if (pDlg) +{ +guard.dismiss(); // ignore, we'll call SetIdle() explictly after the dialog ends -pVOpt->SetIdle( bOldIdle ); +pDlg->StartExecuteAsync([=](sal_Int32 nResult){ +if (nResult == RET_OK ) +InsertThesaurusSynonym(pDlg->GetWord(), aTmp, bSelection); + +pVOpt->SetIdle(bOldIdle); +}); +} +} } // Offer online suggestions ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 115165] no calculation with data=>subtotal
https://bugs.documentfoundation.org/show_bug.cgi?id=115165 --- Comment #2 from Xavier Van Wijmeersch--- @raal thanks, will search for info on the subject data=>subtotals can be closed as WFM, and yes i will first search for info before reporting a bug Best regards -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")
https://bugs.documentfoundation.org/show_bug.cgi?id=112153 --- Comment #31 from steve -_---- @jonathan: a backport is done already. 6.0 and 5.4.5 will include the fix. You can always see that in the top of a bug in the "whiteboard" target info. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115220] Can't edit / move / delete / direction change glue points any more in DRAW
https://bugs.documentfoundation.org/show_bug.cgi?id=115220 Alex Thurgoodchanged: What|Removed |Added Version|5.4.3.2 release |5.4.0.3 release --- Comment #4 from Alex Thurgood --- Problem present in Version: 5.4.0.3 Build ID: 7556cbc6811c9d992f4064ab9287069087d7f62c CPU threads: 4; OS: Mac OS X 10.13.3; UI render: default; Locale: fr-FR (fr_FR.UTF-8); Calc: group setting version to earliest found -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115220] Can't edit / move / delete / direction change glue points any more in DRAW
https://bugs.documentfoundation.org/show_bug.cgi?id=115220 Alex Thurgoodchanged: What|Removed |Added Priority|medium |high Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115222] New: Crash in the File menu mouse moving
https://bugs.documentfoundation.org/show_bug.cgi?id=115222 Bug ID: 115222 Summary: Crash in the File menu mouse moving Product: LibreOffice Version: 6.0.0.2 rc Hardware: x86 (IA32) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: afe...@sze.hu Description: Writer deb packages 6.0.0.2 Linux 32 bit (LxLE) In the file menu move below Send item the program crash. Steps to Reproduce: 1. Start program 2. File menu 3. Move mouse down to de direction print item 4. Below the send item crashing. Actual Results: crash Expected Results: move mouse Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: TextDocument [Information guessed from browser] OS: Linux (All) OS is 64bit: no User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:58.0) Gecko/20100101 Firefox/58.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115220] Can't edit / move / delete / direction change glue points any more in DRAW
https://bugs.documentfoundation.org/show_bug.cgi?id=115220 --- Comment #3 from Alex Thurgood--- The gluepoints can be deleted in Version: 5.3.7.2 Build ID: 6b8ed514a9f8b44d37a1b96673cbbdd077e24059 Threads CPU : 4; Version de l'OS :Mac OS X 10.13.3; UI Render : par défaut; Moteur de mise en page : nouveau; Locale : fr-FR (fr_FR.UTF-8); Calc: group Confirming regression -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - dbaccess/source
dbaccess/source/ui/inc/browserids.hxx | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) New commits: commit 5f4e31a3464961211aafcfdf9c7548eb0cf1516b Author: Caolán McNamaraDate: Tue Jan 23 20:48:51 2018 + tdf#115080 menu id collision 21 collides with the pattern field menu id Change-Id: Ia90995861adabbe1615e24ee10defe25cee76c56 Reviewed-on: https://gerrit.libreoffice.org/48486 Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/dbaccess/source/ui/inc/browserids.hxx b/dbaccess/source/ui/inc/browserids.hxx index 3864a3577175..51793bd8102d 100644 --- a/dbaccess/source/ui/inc/browserids.hxx +++ b/dbaccess/source/ui/inc/browserids.hxx @@ -47,11 +47,11 @@ #define ID_BROWSER_REMOVEFILTER SID_FM_REMOVE_FILTER_SORT #define ID_BROWSER_FILTERED SID_FM_FORM_FILTERED #define ID_BROWSER_REFRESH SID_FM_REFRESH -#define ID_BROWSER_COLATTRSET 20 // column formatting -#define ID_BROWSER_COLWIDTH 21 // column width -#define ID_BROWSER_TABLEATTR22 // table format attributes -#define ID_BROWSER_ROWHEIGHT23 // row height -#define ID_BROWSER_COLUMNINFO 24 // copies the column description to insert it into the table design +#define ID_BROWSER_COLATTRSET 10020 // column formatting +#define ID_BROWSER_COLWIDTH 10021 // column width +#define ID_BROWSER_TABLEATTR10022 // table format attributes +#define ID_BROWSER_ROWHEIGHT10023 // row height +#define ID_BROWSER_COLUMNINFO 10024 // copies the column description to insert it into the table design #define ID_BROWSER_ADDTABLE SID_FM_ADDTABLE #define ID_BROWSER_EXPLORER SID_DSBROWSER_EXPLORER #define ID_BROWSER_DOCUMENT_DATASOURCE SID_DOCUMENT_DATA_SOURCE ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 115221] New: PRINTING: CRASH immediately after choosing comment (+doc ) printing in the print dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=115221 Bug ID: 115221 Summary: PRINTING: CRASH immediately after choosing comment (+doc) printing in the print dialog Product: LibreOffice Version: 6.0.0.1 rc Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tobias.bur...@physik.fu-berlin.de The following occurs with both 6.0.0.1 on Windows 7 (32bit) and 6.1.0.0.alpha0+ Build ID: 0074951704022d173a5fdb9df933f47be1dcbb91 CPU threads: 4; OS: Windows 6.1; UI render: default; TinderBox: Win-x86@42, Branch:master, Time: 2018-01-10_01:01:50 Try: 1. Open Writer with a new (empty) document 2. Insert -> Comment (a yellow comment box is shown right of the page edge, if you want, type something it it) 3. File -> Print... 4. At the bottom center in "Comments:" one has - None (document only) [-> OK] - Comments only[-> OK] - Place at end of document [-> CRASH] - Place at end of page [-> CRASH] - Place in margins [-> CRASH] Choosing one of those marked with CRASH causes LibreOffice immediately to crash. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/window/seleng.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 4158cbabd6587431c89f288abea6080947d9f421 Author: Caolán McNamaraDate: Wed Jan 24 17:32:25 2018 + why set CMDEVT on flags for unhandled commands Change-Id: I565e26ad01310cc05707123f4d42e24c77838793 Reviewed-on: https://gerrit.libreoffice.org/48530 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/vcl/source/window/seleng.cxx b/vcl/source/window/seleng.cxx index c545824436cd..b35576ee1bf1 100644 --- a/vcl/source/window/seleng.cxx +++ b/vcl/source/window/seleng.cxx @@ -342,12 +342,12 @@ void SelectionEngine::Reset() void SelectionEngine::Command( const CommandEvent& rCEvt ) { // Timer aWTimer is active during enlarging a selection -if ( !pFunctionSet || !pWin || aWTimer.IsActive() || rCEvt.GetCommand() == CommandEventId::Swipe ) +if ( !pFunctionSet || !pWin || aWTimer.IsActive() ) return; aWTimer.Stop(); -nFlags |= SelectionEngineFlags::CMDEVT; if ( rCEvt.GetCommand() == CommandEventId::StartDrag ) { +nFlags |= SelectionEngineFlags::CMDEVT; if ( nFlags & SelectionEngineFlags::DRG_ENAB ) { SAL_WARN_IF( !rCEvt.IsMouseEvent(), "vcl", "STARTDRAG: Not a MouseEvent" ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/filter/ww8/ww8par.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit f2935e5fb8fb8937f8a3ee9d9adf497b2b253a94 Author: Caolán McNamaraDate: Wed Jan 24 15:25:24 2018 + ofz#5628 close props, del extra paras, commit redlines Change-Id: Id019205b92b76d4514e3cf6091af7fbe6ddea47c Reviewed-on: https://gerrit.libreoffice.org/48517 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/sw/source/filter/ww8/ww8par.cxx b/sw/source/filter/ww8/ww8par.cxx index a84241e6c2df..3195a498f74c 100644 --- a/sw/source/filter/ww8/ww8par.cxx +++ b/sw/source/filter/ww8/ww8par.cxx @@ -5302,6 +5302,8 @@ ErrCode SwWW8ImplReader::CoreLoad(WW8Glossary const *pGloss) m_pTableStream = nullptr; DeleteCtrlStack(); +DeleteAnchorStack(); +DeleteRefStacks(); m_pLastAnchorPos.reset();//ensure this is deleted before UpdatePageDescs // remove extra paragraphs after attribute ctrl // stacks etc. are destroyed, and before fields @@ -5309,8 +5311,6 @@ ErrCode SwWW8ImplReader::CoreLoad(WW8Glossary const *pGloss) m_aExtraneousParas.delete_all_from_doc(); m_xRedlineStack->closeall(*m_pPaM->GetPoint()); m_xRedlineStack.reset(); -DeleteAnchorStack(); -DeleteRefStacks(); // For i120928,achieve the graphics from the special bookmark with is for graphic bullet { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/filter/ww8/ww8par.cxx |9 - 1 file changed, 4 insertions(+), 5 deletions(-) New commits: commit 603f4ae4363d26c5e14534fe6b6c9328ba47b474 Author: Caolán McNamaraDate: Wed Jan 24 14:59:27 2018 + ofz#5578 remove Extraneous Paras before applying redlines Change-Id: Ibcc75de98f1d01f8617e34b3844b62e57142466e Reviewed-on: https://gerrit.libreoffice.org/48515 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/sw/source/filter/ww8/ww8par.cxx b/sw/source/filter/ww8/ww8par.cxx index 1bfacdd4f79b..a84241e6c2df 100644 --- a/sw/source/filter/ww8/ww8par.cxx +++ b/sw/source/filter/ww8/ww8par.cxx @@ -5303,6 +5303,10 @@ ErrCode SwWW8ImplReader::CoreLoad(WW8Glossary const *pGloss) DeleteCtrlStack(); m_pLastAnchorPos.reset();//ensure this is deleted before UpdatePageDescs +// remove extra paragraphs after attribute ctrl +// stacks etc. are destroyed, and before fields +// are updated +m_aExtraneousParas.delete_all_from_doc(); m_xRedlineStack->closeall(*m_pPaM->GetPoint()); m_xRedlineStack.reset(); DeleteAnchorStack(); @@ -5393,11 +5397,6 @@ ErrCode SwWW8ImplReader::CoreLoad(WW8Glossary const *pGloss) mpCursor.reset(); m_pPaM = nullptr; -// remove extra paragraphs after attribute ctrl -// stacks etc. are destroyed, and before fields -// are updated -m_aExtraneousParas.delete_all_from_doc(); - UpdateFields(); // delete the pam before the call for hide all redlines (Bug 73683) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/filter/ww8/ww8par.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3f4e239a7d6f822093769a394fd4ee50a7f79a0f Author: Caolán McNamaraDate: Wed Jan 24 11:27:52 2018 + release lastanchorpos before closing redlines Change-Id: I2fae6c2a6e44bdcd3c0d7f7a8cfa4a96973cc640 Reviewed-on: https://gerrit.libreoffice.org/48505 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/sw/source/filter/ww8/ww8par.cxx b/sw/source/filter/ww8/ww8par.cxx index 31a8b7cc9176..1bfacdd4f79b 100644 --- a/sw/source/filter/ww8/ww8par.cxx +++ b/sw/source/filter/ww8/ww8par.cxx @@ -5302,6 +5302,7 @@ ErrCode SwWW8ImplReader::CoreLoad(WW8Glossary const *pGloss) m_pTableStream = nullptr; DeleteCtrlStack(); +m_pLastAnchorPos.reset();//ensure this is deleted before UpdatePageDescs m_xRedlineStack->closeall(*m_pPaM->GetPoint()); m_xRedlineStack.reset(); DeleteAnchorStack(); @@ -5391,7 +5392,6 @@ ErrCode SwWW8ImplReader::CoreLoad(WW8Glossary const *pGloss) mpCursor.reset(); m_pPaM = nullptr; -m_pLastAnchorPos.reset();//ensure this is deleted before UpdatePageDescs // remove extra paragraphs after attribute ctrl // stacks etc. are destroyed, and before fields ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: xmloff/source
xmloff/source/style/xmlnumfi.cxx |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) New commits: commit fd5c9c7bcd75077f82add31929f23cffe3f482e0 Author: Caolán McNamaraDate: Wed Jan 24 12:45:03 2018 + reuse limit Change-Id: I5942b6581c02ac55d7eb6acf535214daa5b34865 Reviewed-on: https://gerrit.libreoffice.org/48507 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/xmloff/source/style/xmlnumfi.cxx b/xmloff/source/style/xmlnumfi.cxx index ce5d6ef925d4..e918edcea82a 100644 --- a/xmloff/source/style/xmlnumfi.cxx +++ b/xmloff/source/style/xmlnumfi.cxx @@ -884,8 +884,6 @@ static void lcl_EnquoteIfNecessary( OUStringBuffer& rContent, const SvXMLNumForm // SvXMLNumFmtElementContext -const sal_Int32 MAX_SECOND_DIGITS = 20; // fdo#58539 & gnome#627420: limit number of digits during import - SvXMLNumFmtElementContext::SvXMLNumFmtElementContext( SvXMLImport& rImport, sal_uInt16 nPrfx, const OUString& rLName, SvXMLNumFormatContext& rParentContext, sal_uInt16 nNewType, @@ -919,7 +917,10 @@ SvXMLNumFmtElementContext::SvXMLNumFmtElementContext( SvXMLImport& rImport, { case XML_TOK_ELEM_ATTR_DECIMAL_PLACES: if (::sax::Converter::convertNumber( nAttrVal, sValue, 0 )) -aNumInfo.nDecimals = std::min(nAttrVal, MAX_SECOND_DIGITS); +{ +// fdo#58539 & gnome#627420: limit number of digits during import +aNumInfo.nDecimals = std::min(nAttrVal, NF_MAX_FORMAT_SYMBOLS); +} break; case XML_TOK_ELEM_ATTR_MIN_DECIMAL_PLACES: if (::sax::Converter::convertNumber( nAttrVal, sValue, 0 )) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/svl svl/source xmloff/source
include/svl/zforlist.hxx |2 ++ svl/source/numbers/zforscan.hxx |1 - xmloff/source/style/xmlnumfi.cxx |2 +- 3 files changed, 3 insertions(+), 2 deletions(-) New commits: commit 4f9d4b9b524ed3afd26d2cd67d3559e6a4e6fdfe Author: Caolán McNamaraDate: Wed Jan 24 12:43:39 2018 + ofz: out-of-memory Change-Id: If1c9ade3268f4ebadfdad771fe3b35641dca210d Reviewed-on: https://gerrit.libreoffice.org/48506 Reviewed-by: Eike Rathke Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/include/svl/zforlist.hxx b/include/svl/zforlist.hxx index 838f69508338..e0c2b95d61c9 100644 --- a/include/svl/zforlist.hxx +++ b/include/svl/zforlist.hxx @@ -56,6 +56,8 @@ namespace com { namespace sun { namespace star { #define SV_COUNTRY_LANGUAGE_OFFSET 1 // Max count of formats per country/language #define SV_MAX_COUNT_STANDARD_FORMATS 100// Max count of builtin default formats per CL +constexpr size_t NF_MAX_FORMAT_SYMBOLS = 100; + /// The built-in @ Text format, offset within a locale, key in the locale the /// number formatter was constructed with. constexpr sal_uInt32 NF_STANDARD_FORMAT_TEXT = SV_MAX_COUNT_STANDARD_FORMATS; diff --git a/svl/source/numbers/zforscan.hxx b/svl/source/numbers/zforscan.hxx index 309f963c9c21..34e64bd25da6 100644 --- a/svl/source/numbers/zforscan.hxx +++ b/svl/source/numbers/zforscan.hxx @@ -30,7 +30,6 @@ class SvNumberFormatter; struct ImpSvNumberformatInfo; -const size_t NF_MAX_FORMAT_SYMBOLS = 100; const size_t NF_MAX_DEFAULT_COLORS = 10; // Hack: nThousand==1000 => "Default" occurs in format string diff --git a/xmloff/source/style/xmlnumfi.cxx b/xmloff/source/style/xmlnumfi.cxx index e3576285f3da..ce5d6ef925d4 100644 --- a/xmloff/source/style/xmlnumfi.cxx +++ b/xmloff/source/style/xmlnumfi.cxx @@ -951,7 +951,7 @@ SvXMLNumFmtElementContext::SvXMLNumFmtElementContext( SvXMLImport& rImport, break; case XML_TOK_ELEM_ATTR_MIN_EXPONENT_DIGITS: if (::sax::Converter::convertNumber( nAttrVal, sValue, 0 )) -aNumInfo.nExpDigits = nAttrVal; +aNumInfo.nExpDigits = std::min(nAttrVal, NF_MAX_FORMAT_SYMBOLS); break; case XML_TOK_ELEM_ATTR_EXPONENT_INTERVAL: if (::sax::Converter::convertNumber( nAttrVal, sValue, 0 )) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/filter/ww8/ww8par3.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 6a042742d34ce6503cbebae0268845d7f71a95d6 Author: Caolán McNamaraDate: Wed Jan 24 15:39:28 2018 + ofz#5661 check nLevel against maParaSprms size Change-Id: I9bcaf176e6a2f70348712ca98c4176125c2f455e Reviewed-on: https://gerrit.libreoffice.org/48519 Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/sw/source/filter/ww8/ww8par3.cxx b/sw/source/filter/ww8/ww8par3.cxx index e209103d892d..6b54244c0529 100644 --- a/sw/source/filter/ww8/ww8par3.cxx +++ b/sw/source/filter/ww8/ww8par3.cxx @@ -1415,7 +1415,8 @@ WW8ListManager::WW8ListManager(SvStream& rSt_, SwWW8ImplReader& rReader_) aLFOLVL.bFormat = true; // if bStartup is true, replace Startup-Level // with the LVLF that is saved in the LVL -bLVLOk = ReadLVL(aNumFormat, aItemSet[nLevel], +bLVLOk = nLevel < rLFOInfo.maParaSprms.size() && +ReadLVL(aNumFormat, aItemSet[nLevel], pParentListInfo->aIdSty[nLevel], aLFOLVL.bStartAt, aNotReallyThere, nLevel, rLFOInfo.maParaSprms[nLevel]); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 114677] Base Form titles incorrect
https://bugs.documentfoundation.org/show_bug.cgi?id=114677 Julien Nabetchanged: What|Removed |Added Severity|normal |major --- Comment #7 from Julien Nabet --- Szymon: any update? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: compilerplugins/clang xmloff/source
compilerplugins/clang/datamembershadow.cxx |2 -- xmloff/source/draw/ximplink.hxx|1 - 2 files changed, 3 deletions(-) New commits: commit 97b7ada0388d0b0da4303cf95443339ab0f3523b Author: Noel GrandinDate: Wed Jan 24 14:54:19 2018 +0200 loplugin:datamembershadow in SdXMLShapeLinkContext in this case, we can just drop the child member and re-use the parent member. The parent class barely contains any logic anyway. Change-Id: I520217c04a38b66323a76bf5fddb476bd3fc8e15 Reviewed-on: https://gerrit.libreoffice.org/48551 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/compilerplugins/clang/datamembershadow.cxx b/compilerplugins/clang/datamembershadow.cxx index 040743bad028..520e1195f0ca 100644 --- a/compilerplugins/clang/datamembershadow.cxx +++ b/compilerplugins/clang/datamembershadow.cxx @@ -90,8 +90,6 @@ bool DataMemberShadow::VisitFieldDecl(FieldDecl const * fieldDecl) return true; if (loplugin::isSamePathname(aFileName, SRCDIR "/vcl/unx/generic/print/genpspgraphics.cxx")) return true; -if (loplugin::isSamePathname(aFileName, SRCDIR "/xmloff/source/draw/ximplink.hxx")) -return true; const CXXRecordDecl* parentCXXRecordDecl = dyn_cast(fieldDecl->getDeclContext()); if (!parentCXXRecordDecl) { diff --git a/xmloff/source/draw/ximplink.hxx b/xmloff/source/draw/ximplink.hxx index c930f9b0f7e7..3a52244cb7e2 100644 --- a/xmloff/source/draw/ximplink.hxx +++ b/xmloff/source/draw/ximplink.hxx @@ -35,7 +35,6 @@ class SdXMLShapeLinkContext : public SvXMLShapeContext { // the parent shape group this link is placed in css::uno::Reference< css::drawing::XShapes > mxParent; -OUString msHyperlink; public: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 114677] Base Form titles incorrect
https://bugs.documentfoundation.org/show_bug.cgi?id=114677 Julien Nabetchanged: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #6 from Julien Nabet --- Created attachment 139353 --> https://bugs.documentfoundation.org/attachment.cgi?id=139353=edit bt with debug symbols I attached a bt which shows where title is formed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115220] Can't edit / move / delete / direction change glue points any more in DRAW
https://bugs.documentfoundation.org/show_bug.cgi?id=115220 Alex Thurgoodchanged: What|Removed |Added Keywords||regression -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115220] Can't edit / move / delete / direction change glue points any more in DRAW
https://bugs.documentfoundation.org/show_bug.cgi?id=115220 Alex Thurgoodchanged: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #2 from Alex Thurgood --- Confirming. This happened to me recently when attempting to edit a shape, had to move back to a previous version of LO to finish my work. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened
https://bugs.documentfoundation.org/show_bug.cgi?id=103571 --- Comment #40 from Telesto--- *** Bug 103126 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103126] 100% usage when creating new document after sleep and OSX Dock in autohide mode
https://bugs.documentfoundation.org/show_bug.cgi?id=103126 Telestochanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #17 from Telesto --- *** This bug has been marked as a duplicate of bug 103571 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113023] [META] MacOS performance issues
https://bugs.documentfoundation.org/show_bug.cgi?id=113023 Bug 113023 depends on bug 103126, which changed state. Bug 103126 Summary: 100% usage when creating new document after sleep and OSX Dock in autohide mode https://bugs.documentfoundation.org/show_bug.cgi?id=103126 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108746] [META] Page number field bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108746 Bug 108746 depends on bug 92685, which changed state. Bug 92685 Summary: Add PageNumber Header option ... https://bugs.documentfoundation.org/show_bug.cgi?id=92685 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source sw/uiconfig
sw/source/uibase/docvw/HeaderFooterWin.cxx |6 ++ sw/uiconfig/swriter/ui/headerfootermenu.ui |8 2 files changed, 14 insertions(+) New commits: commit 463ca11b764dfdf48d0422b0a392a462bf6681a3 Author: Gulsah KoseDate: Mon Jan 8 15:37:08 2018 +0300 [Pardus] tdf#92685 Add insert page number option to header menu. This patch is sponsored by ULAKBIM/Pardus project. Change-Id: I9f1f5bd0f05b7f92204615b48a1e7be06272a8a3 Signed-off-by: Gulsah Kose Reviewed-on: https://gerrit.libreoffice.org/47597 Tested-by: Jenkins diff --git a/sw/source/uibase/docvw/HeaderFooterWin.cxx b/sw/source/uibase/docvw/HeaderFooterWin.cxx index 23a85053f358..007184220816 100644 --- a/sw/source/uibase/docvw/HeaderFooterWin.cxx +++ b/sw/source/uibase/docvw/HeaderFooterWin.cxx @@ -41,6 +41,7 @@ #include #include #include +#include #include #include #include @@ -462,6 +463,11 @@ void SwHeaderFooterWin::ExecuteCommand(const OString& rIdent) { rSh.ChangeHeaderOrFooter( rStyleName, m_bIsHeader, false, true ); } +else if (rIdent == "insert_pagenumber") +{ +SfxViewFrame* pVFrame = rSh.GetView().GetViewFrame(); +pVFrame->GetBindings().Execute(FN_INSERT_FLD_PGNUMBER); +} } void SwHeaderFooterWin::SetReadonly( bool bReadonly ) diff --git a/sw/uiconfig/swriter/ui/headerfootermenu.ui b/sw/uiconfig/swriter/ui/headerfootermenu.ui index be7661876209..037931137938 100644 --- a/sw/uiconfig/swriter/ui/headerfootermenu.ui +++ b/sw/uiconfig/swriter/ui/headerfootermenu.ui @@ -27,5 +27,13 @@ True + + +True +False +Insert Page Number +True + + ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 115213] Cannot get printing out of landscape mode
https://bugs.documentfoundation.org/show_bug.cgi?id=115213 Alex Thurgoodchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Alex Thurgood --- *** This bug has been marked as a duplicate of bug 92190 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92190] PRINTs landscape despite configured as portrait (Mac OS)
https://bugs.documentfoundation.org/show_bug.cgi?id=92190 Alex Thurgoodchanged: What|Removed |Added CC||ro...@mac.com --- Comment #114 from Alex Thurgood --- *** Bug 115213 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115016] [Feature Request] Gnome Desktop Integration -- Command Left/ Right/Top/Down
https://bugs.documentfoundation.org/show_bug.cgi?id=115016 Alex Thurgoodchanged: What|Removed |Added Component|Base|UI --- Comment #1 from Alex Thurgood --- Not a database bug report, correcting module to UI. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44854] Upgrade bundled HSQLDB to 2.x
https://bugs.documentfoundation.org/show_bug.cgi?id=44854 --- Comment #18 from Alex Thurgood--- Can we close this bug as WONTFIX? I have serious doubts about whether moving to embedded 2.3 is actually going to happen, or be a reality, given that the current development focus is on Firebird3 integration. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113937] Forms and reports hang
https://bugs.documentfoundation.org/show_bug.cgi?id=113937 Alex Thurgoodchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INSUFFICIENTDATA --- Comment #45 from Alex Thurgood --- Closing this report as insufficient data. The information about the legendary instability of the embedded hsqsl 1.8.0 when the ODB file contains many reports, forms, macros, etc and a file size of several Mb is well known. It is documented in many places and certainly not a new phenomena. I could have set this to WONTFIX, as it is unlikely that the instability issues will ever be addressed for the current embedded version of hsqldb, considering that the project is moving towards supporting embedded Firebird as the default rather than continuing with embedded hsqldb. This means that the code relating to embedded hsqldb is in "maintenance/curation mode" rather than "active development". Regressions are still being fixed for the time being, but tomy knowledge, no specific development with regard to improving embedded hsqldb 1.8 is being undertaken. As we don't have a sample db file with which to test, and as the original poster has moved to an external hdsqldb solution, I am setting this to INSUFFICIENT DATA rather than worksforme. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113939] double underline - inconsistent shortcut across components
https://bugs.documentfoundation.org/show_bug.cgi?id=113939 Heiko Tietzechanged: What|Removed |Added Status|ASSIGNED|NEW Assignee|tietze.he...@gmail.com |libreoffice-b...@lists.free ||desktop.org --- Comment #9 from Heiko Tietze --- Shift+ctrl+U cannot work since it interferes with ctrl+U, see bug 114010 (containing link to the preliminary patch). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: desktop/source include/LibreOfficeKit
desktop/source/lib/init.cxx | 95 ++ include/LibreOfficeKit/LibreOfficeKit.hxx |5 - 2 files changed, 95 insertions(+), 5 deletions(-) New commits: commit 027abe22f11a8c7dac38697f02d03156bb91a8a1 Author: Miklos VajnaDate: Wed Jan 24 22:05:17 2018 +0100 desktop: always clear LOK error message on success Change-Id: Idefdbd3d9ae19f7cf5889017b111c12620ab08c2 Reviewed-on: https://gerrit.libreoffice.org/48541 Reviewed-by: Miklos Vajna Tested-by: Jenkins diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index b3631ba3ade7..338d11221566 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -1332,6 +1332,7 @@ static LibreOfficeKitDocument* lo_documentLoadWithOptions(LibreOfficeKit* pThis, SolarMutexGuard aGuard; LibLibreOffice_Impl* pLib = static_cast (pThis); +pLib->maLastExceptionMsg.clear(); OUString aURL(getAbsoluteURL(pURL)); if (aURL.isEmpty()) @@ -1435,6 +1436,7 @@ static int lo_runMacro(LibreOfficeKit* pThis, const char *pURL) SolarMutexGuard aGuard; LibLibreOffice_Impl* pLib = static_cast (pThis); +pLib->maLastExceptionMsg.clear(); OUString sURL( pURL, strlen(pURL), RTL_TEXTENCODING_UTF8 ); if (sURL.isEmpty()) @@ -1525,6 +1527,7 @@ static void lo_registerCallback (LibreOfficeKit* pThis, SolarMutexGuard aGuard; LibLibreOffice_Impl* pLib = static_cast (pThis); +pLib->maLastExceptionMsg.clear(); pLib->mpCallback = pCallback; pLib->mpCallbackData = pData; @@ -1533,6 +1536,8 @@ static void lo_registerCallback (LibreOfficeKit* pThis, static int doc_saveAs(LibreOfficeKitDocument* pThis, const char* sUrl, const char* pFormat, const char* pFilterOptions) { SolarMutexGuard aGuard; +if (gImpl) +gImpl->maLastExceptionMsg.clear(); LibLODocument_Impl* pDocument = static_cast (pThis); @@ -1660,6 +1665,8 @@ static int doc_saveAs(LibreOfficeKitDocument* pThis, const char* sUrl, const cha static void doc_iniUnoCommands () { SolarMutexGuard aGuard; +if (gImpl) +gImpl->maLastExceptionMsg.clear(); OUString sUnoCommands[] = { @@ -1799,6 +1806,8 @@ static void doc_iniUnoCommands () static int doc_getDocumentType (LibreOfficeKitDocument* pThis) { SolarMutexGuard aGuard; +if (gImpl) +gImpl->maLastExceptionMsg.clear(); LibLODocument_Impl* pDocument = static_cast (pThis); @@ -1851,6 +1860,8 @@ static int doc_getParts (LibreOfficeKitDocument* pThis) static int doc_getPart (LibreOfficeKitDocument* pThis) { SolarMutexGuard aGuard; +if (gImpl) +gImpl->maLastExceptionMsg.clear(); ITiledRenderable* pDoc = getTiledRenderable(pThis); if (!pDoc) @@ -1865,6 +1876,8 @@ static int doc_getPart (LibreOfficeKitDocument* pThis) static void doc_setPart(LibreOfficeKitDocument* pThis, int nPart) { SolarMutexGuard aGuard; +if (gImpl) +gImpl->maLastExceptionMsg.clear(); ITiledRenderable* pDoc = getTiledRenderable(pThis); if (!pDoc) @@ -1879,6 +1892,8 @@ static void doc_setPart(LibreOfficeKitDocument* pThis, int nPart) static char* doc_getPartPageRectangles(LibreOfficeKitDocument* pThis) { SolarMutexGuard aGuard; +if (gImpl) +gImpl->maLastExceptionMsg.clear(); ITiledRenderable* pDoc = getTiledRenderable(pThis); if (!pDoc) @@ -1898,6 +1913,8 @@ static char* doc_getPartPageRectangles(LibreOfficeKitDocument* pThis) static char* doc_getPartName(LibreOfficeKitDocument* pThis, int nPart) { SolarMutexGuard aGuard; +if (gImpl) +gImpl->maLastExceptionMsg.clear(); ITiledRenderable* pDoc = getTiledRenderable(pThis); if (!pDoc) @@ -1917,6 +1934,8 @@ static char* doc_getPartName(LibreOfficeKitDocument* pThis, int nPart) static char* doc_getPartHash(LibreOfficeKitDocument* pThis, int nPart) { SolarMutexGuard aGuard; +if (gImpl) +gImpl->maLastExceptionMsg.clear(); ITiledRenderable* pDoc = getTiledRenderable(pThis); if (!pDoc) @@ -1937,6 +1956,8 @@ static void doc_setPartMode(LibreOfficeKitDocument* pThis, int nPartMode) { SolarMutexGuard aGuard; +if (gImpl) +gImpl->maLastExceptionMsg.clear(); ITiledRenderable* pDoc = getTiledRenderable(pThis); if (!pDoc) @@ -1976,6 +1997,8 @@ static void doc_paintTile(LibreOfficeKitDocument* pThis, const int nTileWidth, const int nTileHeight) { SolarMutexGuard aGuard; +if (gImpl) +gImpl->maLastExceptionMsg.clear(); SAL_INFO( "lok.tiledrendering", "paintTile: painting [" << nTileWidth << "x" << nTileHeight << "]@(" << nTilePosX << ", " << nTilePosY << ") to [" << @@ -2028,6 +2051,8 @@
[Libreoffice-bugs] [Bug 102593] [META] Paste bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102593 Thomas Lendochanged: What|Removed |Added Depends on||115088 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115088 [Bug 115088] Pasting multi-line text from external source behaves strangely -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: writerfilter/source
writerfilter/source/dmapper/GraphicHelpers.cxx |4 1 file changed, 4 insertions(+) New commits: commit 82dcf015154c3fb00240c5630ae926c74c7f4213 Author: Patrick JaapDate: Wed Jan 24 11:45:57 2018 +0100 Add SAL_WARN in writerfilter graphic import Change-Id: Iac6265094572c57f421b0533db2c90a41b2ef427 Reviewed-on: https://gerrit.libreoffice.org/48492 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/writerfilter/source/dmapper/GraphicHelpers.cxx b/writerfilter/source/dmapper/GraphicHelpers.cxx index a7ce01868714..ca2892a013af 100644 --- a/writerfilter/source/dmapper/GraphicHelpers.cxx +++ b/writerfilter/source/dmapper/GraphicHelpers.cxx @@ -83,6 +83,8 @@ void PositionHandler::lcl_attribute( Id aName, Value& rVal ) break; // TODO There are some other unhandled values +default: +SAL_WARN("writerfilter", "unhandled case (" << nIntValue << ") in NS_ooxml::LN_CT_PosV_relativeFrom"); } } break; @@ -116,6 +118,8 @@ void PositionHandler::lcl_attribute( Id aName, Value& rVal ) break; // TODO There are some other unhandled values +default: +SAL_WARN("writerfilter", "unhandled case (" << nIntValue << ") in NS_ooxml::LN_CT_PosH_relativeFrom"); } } break; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 115089] when adding glue point to a shape in LO draw, the glue points are not displayed
https://bugs.documentfoundation.org/show_bug.cgi?id=115089 Julien Nabetchanged: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||5220 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115220] Can't edit / move / delete / direction change glue points any more in DRAW
https://bugs.documentfoundation.org/show_bug.cgi?id=115220 Julien Nabetchanged: What|Removed |Added CC||serval2...@yahoo.fr See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||5089 --- Comment #1 from Julien Nabet --- About bug 1, see tdf#115089 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95953] Size of text not preserved and Liberation changed to Arial through save and open as pptx
https://bugs.documentfoundation.org/show_bug.cgi?id=95953 Timurchanged: What|Removed |Added Summary|Size of text not preserved |Size of text not preserved |through save and open as|and Liberation changed to |pptx|Arial through save and open ||as pptx -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs